* [Qemu-devel] [PATCH v1 0/2] Remove un-needed use of ssi_create_slave_no_init
@ 2013-04-04 1:03 Peter Crosthwaite
2013-04-04 1:04 ` [Qemu-devel] [PATCH v1 1/2] petalogix_ml605_mmu: Cleanup ssi_create_slave() Peter Crosthwaite
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Peter Crosthwaite @ 2013-04-04 1:03 UTC (permalink / raw)
To: qemu-devel
Cc: qemu-trivial, peter.maydell, Peter Crosthwaite, dantesu, edgar.iglesias
Trivial code cleanup of the PetaLogix and Zynq machine models.
Peter Crosthwaite (2):
petalogix_ml605_mmu: Cleanup ssi_create_slave()
xilinx_zynq: Cleanup ssi_create_slave
hw/arm/xilinx_zynq.c | 3 +--
hw/microblaze/petalogix_ml605_mmu.c | 3 +--
2 files changed, 2 insertions(+), 4 deletions(-)
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Qemu-devel] [PATCH v1 1/2] petalogix_ml605_mmu: Cleanup ssi_create_slave()
2013-04-04 1:03 [Qemu-devel] [PATCH v1 0/2] Remove un-needed use of ssi_create_slave_no_init Peter Crosthwaite
@ 2013-04-04 1:04 ` Peter Crosthwaite
2013-04-04 1:04 ` [Qemu-devel] [PATCH v1 2/2] xilinx_zynq: Cleanup ssi_create_slave Peter Crosthwaite
2013-04-05 13:04 ` [Qemu-devel] [Qemu-trivial] [PATCH v1 0/2] Remove un-needed use of ssi_create_slave_no_init Stefan Hajnoczi
2 siblings, 0 replies; 4+ messages in thread
From: Peter Crosthwaite @ 2013-04-04 1:04 UTC (permalink / raw)
To: qemu-devel
Cc: qemu-trivial, peter.maydell, Peter Crosthwaite, dantesu, edgar.iglesias
With the recent m25p80 cleanup there is no need to use
ssi_create_slave_no_init() anymore. Just use ssi_create_slave().
Signed-off-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
---
hw/microblaze/petalogix_ml605_mmu.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/hw/microblaze/petalogix_ml605_mmu.c b/hw/microblaze/petalogix_ml605_mmu.c
index cfc0220..07dc808 100644
--- a/hw/microblaze/petalogix_ml605_mmu.c
+++ b/hw/microblaze/petalogix_ml605_mmu.c
@@ -158,8 +158,7 @@ petalogix_ml605_init(QEMUMachineInitArgs *args)
for (i = 0; i < NUM_SPI_FLASHES; i++) {
qemu_irq cs_line;
- dev = ssi_create_slave_no_init(spi, "n25q128");
- qdev_init_nofail(dev);
+ dev = ssi_create_slave(spi, "n25q128");
cs_line = qdev_get_gpio_in(dev, 0);
sysbus_connect_irq(busdev, i+1, cs_line);
}
--
1.7.0.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Qemu-devel] [PATCH v1 2/2] xilinx_zynq: Cleanup ssi_create_slave
2013-04-04 1:03 [Qemu-devel] [PATCH v1 0/2] Remove un-needed use of ssi_create_slave_no_init Peter Crosthwaite
2013-04-04 1:04 ` [Qemu-devel] [PATCH v1 1/2] petalogix_ml605_mmu: Cleanup ssi_create_slave() Peter Crosthwaite
@ 2013-04-04 1:04 ` Peter Crosthwaite
2013-04-05 13:04 ` [Qemu-devel] [Qemu-trivial] [PATCH v1 0/2] Remove un-needed use of ssi_create_slave_no_init Stefan Hajnoczi
2 siblings, 0 replies; 4+ messages in thread
From: Peter Crosthwaite @ 2013-04-04 1:04 UTC (permalink / raw)
To: qemu-devel
Cc: qemu-trivial, peter.maydell, Peter Crosthwaite, dantesu, edgar.iglesias
With the recent m25p80 cleanup there is no need to use
ssi_create_slave_no_init() anymore. Just use ssi_create_slave().
Signed-off-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
---
hw/arm/xilinx_zynq.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/hw/arm/xilinx_zynq.c b/hw/arm/xilinx_zynq.c
index 6f36286..5b9257a 100644
--- a/hw/arm/xilinx_zynq.c
+++ b/hw/arm/xilinx_zynq.c
@@ -86,8 +86,7 @@ static inline void zynq_init_spi_flashes(uint32_t base_addr, qemu_irq irq,
spi = (SSIBus *)qdev_get_child_bus(dev, bus_name);
for (j = 0; j < num_ss; ++j) {
- flash_dev = ssi_create_slave_no_init(spi, "n25q128");
- qdev_init_nofail(flash_dev);
+ flash_dev = ssi_create_slave(spi, "n25q128");
cs_line = qdev_get_gpio_in(flash_dev, 0);
sysbus_connect_irq(busdev, i * num_ss + j + 1, cs_line);
--
1.7.0.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH v1 0/2] Remove un-needed use of ssi_create_slave_no_init
2013-04-04 1:03 [Qemu-devel] [PATCH v1 0/2] Remove un-needed use of ssi_create_slave_no_init Peter Crosthwaite
2013-04-04 1:04 ` [Qemu-devel] [PATCH v1 1/2] petalogix_ml605_mmu: Cleanup ssi_create_slave() Peter Crosthwaite
2013-04-04 1:04 ` [Qemu-devel] [PATCH v1 2/2] xilinx_zynq: Cleanup ssi_create_slave Peter Crosthwaite
@ 2013-04-05 13:04 ` Stefan Hajnoczi
2 siblings, 0 replies; 4+ messages in thread
From: Stefan Hajnoczi @ 2013-04-05 13:04 UTC (permalink / raw)
To: Peter Crosthwaite
Cc: qemu-trivial, peter.maydell, qemu-devel, dantesu, edgar.iglesias
On Thu, Apr 04, 2013 at 11:03:14AM +1000, Peter Crosthwaite wrote:
> Trivial code cleanup of the PetaLogix and Zynq machine models.
>
>
> Peter Crosthwaite (2):
> petalogix_ml605_mmu: Cleanup ssi_create_slave()
> xilinx_zynq: Cleanup ssi_create_slave
>
> hw/arm/xilinx_zynq.c | 3 +--
> hw/microblaze/petalogix_ml605_mmu.c | 3 +--
> 2 files changed, 2 insertions(+), 4 deletions(-)
>
>
Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-04-05 13:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-04-04 1:03 [Qemu-devel] [PATCH v1 0/2] Remove un-needed use of ssi_create_slave_no_init Peter Crosthwaite
2013-04-04 1:04 ` [Qemu-devel] [PATCH v1 1/2] petalogix_ml605_mmu: Cleanup ssi_create_slave() Peter Crosthwaite
2013-04-04 1:04 ` [Qemu-devel] [PATCH v1 2/2] xilinx_zynq: Cleanup ssi_create_slave Peter Crosthwaite
2013-04-05 13:04 ` [Qemu-devel] [Qemu-trivial] [PATCH v1 0/2] Remove un-needed use of ssi_create_slave_no_init Stefan Hajnoczi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.