[PATCH 0/1]wget:fix do_configure failed

[PATCH 0/1]wget:fix do_configure failed

[Hongxu Jia]

The following changes since commit 1dd643b142c69ac9035e29bff11d02201638dc65:

  licences: Add SGI license (2013-06-17 16:45:37 +0100)

are available in the git repository at:

  git://git.pokylinux.org/poky-contrib hongxu/fix-wget
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=hongxu/fix-wget

Hongxu Jia (1):
  wget:fix do_configure failed

 meta/recipes-extended/wget/wget.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
1.8.1.2

[PATCH 1/1] wget:fix do_configure failed

[Hongxu Jia]

Create a new build enviroment, build wget failed
...
configure:34512: checking for libssl
configure:34542: i586-poky-linux-gcc  -m32 -march=i586 --sysroot=/home/jiahongxu/yocto/build-20130613-qemu/tmp/sysroots/qemux86 -o conftest - O2 -pipe -g -feliminate-unused-debug-types  -Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed conftest.c -ldl  -lssl /home/jiahongxu/yocto/build-  20130613-qemu/tmp/sysroots/qemux86/lib/libcrypto.so -lz >&5
/home/jiahongxu/yocto/build-20130613-qemu/tmp/sysroots/x86_64-linux/usr/libexec/i586-poky-linux/gcc/i586-poky-linux/4.7.2/ld: cannot find -lz collect2: error: ld returned 1 exit status
...

From log as we known, the reason is link zlib failed, it isn't
explicitly in wget's DEPENDS. Add zlib to wget's DEPENDS.

[YOCTO #4749]

Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
---
 meta/recipes-extended/wget/wget.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-extended/wget/wget.inc b/meta/recipes-extended/wget/wget.inc
index ba37a87..de9b620 100644
--- a/meta/recipes-extended/wget/wget.inc
+++ b/meta/recipes-extended/wget/wget.inc
@@ -2,7 +2,7 @@ DESCRIPTION = "A console URL download utility featuring HTTP, FTP, and more."
 SECTION = "console/network"
 LICENSE = "GPLv3"
 LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504"
-DEPENDS = "openssl"
+DEPENDS = "openssl zlib"
 
 INC_PR = "r16"
 
-- 
1.8.1.2

Re: [PATCH 1/1] wget:fix do_configure failed

[Richard Purdie]

On Wed, 2013-06-19 at 10:45 +0800, Hongxu Jia wrote:
> Create a new build enviroment, build wget failed
> ...
> configure:34512: checking for libssl
> configure:34542: i586-poky-linux-gcc  -m32 -march=i586 --sysroot=/home/jiahongxu/yocto/build-20130613-qemu/tmp/sysroots/qemux86 -o conftest - O2 -pipe -g -feliminate-unused-debug-types  -Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed conftest.c -ldl  -lssl /home/jiahongxu/yocto/build-  20130613-qemu/tmp/sysroots/qemux86/lib/libcrypto.so -lz >&5
> /home/jiahongxu/yocto/build-20130613-qemu/tmp/sysroots/x86_64-linux/usr/libexec/i586-poky-linux/gcc/i586-poky-linux/4.7.2/ld: cannot find -lz collect2: error: ld returned 1 exit status
> ...
> 
> From log as we known, the reason is link zlib failed, it isn't
> explicitly in wget's DEPENDS. Add zlib to wget's DEPENDS.
> 
> [YOCTO #4749]
> 
> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
> ---
>  meta/recipes-extended/wget/wget.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

I'll take this but the summary of this change should be something like
"wget: Add missing DEPENDS on zlib" which explains more about what the
change does. Fixing a configure failure doesn't tell us much when looked
at in a history of changes. I'll tweak the summary this time.

Cheers,

Richard

> diff --git a/meta/recipes-extended/wget/wget.inc b/meta/recipes-extended/wget/wget.inc
> index ba37a87..de9b620 100644
> --- a/meta/recipes-extended/wget/wget.inc
> +++ b/meta/recipes-extended/wget/wget.inc
> @@ -2,7 +2,7 @@ DESCRIPTION = "A console URL download utility featuring HTTP, FTP, and more."
>  SECTION = "console/network"
>  LICENSE = "GPLv3"
>  LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504"
> -DEPENDS = "openssl"
> +DEPENDS = "openssl zlib"
>  
>  INC_PR = "r16"
>  

Re: [PATCH 1/1] wget:fix do_configure failed

[Hongxu Jia]

Thank you for your suggestion, I will correct this next time.

Thanks,
Hongxu

On 06/19/2013 04:15 PM, Richard Purdie wrote:
> On Wed, 2013-06-19 at 10:45 +0800, Hongxu Jia wrote:
>> Create a new build enviroment, build wget failed
>> ...
>> configure:34512: checking for libssl
>> configure:34542: i586-poky-linux-gcc  -m32 -march=i586 --sysroot=/home/jiahongxu/yocto/build-20130613-qemu/tmp/sysroots/qemux86 -o conftest - O2 -pipe -g -feliminate-unused-debug-types  -Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed conftest.c -ldl  -lssl /home/jiahongxu/yocto/build-  20130613-qemu/tmp/sysroots/qemux86/lib/libcrypto.so -lz >&5
>> /home/jiahongxu/yocto/build-20130613-qemu/tmp/sysroots/x86_64-linux/usr/libexec/i586-poky-linux/gcc/i586-poky-linux/4.7.2/ld: cannot find -lz collect2: error: ld returned 1 exit status
>> ...
>>
>>  From log as we known, the reason is link zlib failed, it isn't
>> explicitly in wget's DEPENDS. Add zlib to wget's DEPENDS.
>>
>> [YOCTO #4749]
>>
>> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
>> ---
>>   meta/recipes-extended/wget/wget.inc | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
> I'll take this but the summary of this change should be something like
> "wget: Add missing DEPENDS on zlib" which explains more about what the
> change does. Fixing a configure failure doesn't tell us much when looked
> at in a history of changes. I'll tweak the summary this time.
>
> Cheers,
>
> Richard
>
>> diff --git a/meta/recipes-extended/wget/wget.inc b/meta/recipes-extended/wget/wget.inc
>> index ba37a87..de9b620 100644
>> --- a/meta/recipes-extended/wget/wget.inc
>> +++ b/meta/recipes-extended/wget/wget.inc
>> @@ -2,7 +2,7 @@ DESCRIPTION = "A console URL download utility featuring HTTP, FTP, and more."
>>   SECTION = "console/network"
>>   LICENSE = "GPLv3"
>>   LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504"
>> -DEPENDS = "openssl"
>> +DEPENDS = "openssl zlib"
>>   
>>   INC_PR = "r16"
>>   
>