From: Jeff Cody <jcody@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, benoit.canet@irqsave.net, pkrempa@redhat.com,
famz@redhat.com, stefanha@redhat.com
Subject: [Qemu-devel] [PATCH v6 for 2.1 00/10] Modify block jobs to use node-names
Date: Tue, 17 Jun 2014 17:53:48 -0400 [thread overview]
Message-ID: <cover.1403041699.git.jcody@redhat.com> (raw)
Changes from v5->v6:
* Check for attempt to commit an image to itself (Eric)
* Add a comment to the bdrv_find for block-commit, indicating
that libvirt uses the error case for probing (Eric)
* Added Benoit's R-b's
Changes from v4->v5:
* Rebased on master
* Fixed commit log typos / stale paragraphs (Eric)
* Fixed comment typo (Eric)
* Added Eric's remaining R-b's
Changes from v3->v4:
* Rebased on master
* Dropped overlay pointers, Eric's concerns are correct
* Require "device" for all arguments, in light of the above,
so we can find the active layer in all cases.
* Simplify more operations!
* Dropped Eric's Reviewed-by: on patches 3,5,6
Added Eric's Reviewed-by: on patches 8,9
Changes from v2->v3:
* Add Eric's reviewed-by
* Addressed Eric's review comments
* Dropped HMP changes
* Added helper function for setting the overlay, and
set the overlay in bdrv_append()
* Use bs->backing_file instead of bs->backing_hd->filename in block_stream
Using node-names instead of filenames for block job operations
over QMP is a superior method of identifying the block driver
images to operate on, as it removes all pathname ambiguity.
This series modifies block-commit and block-stream to use node-names,
and creates a new QAPI command to allow stand-alone backing file
changes on an image file.
So that node-names can be used as desired for all block job
operations, this series also auto-generates node-names for every
BDS. User-specified node-names will override any autogenerated
Jeff Cody (10):
block: Auto-generate node_names for each BDS entry
block: add helper function to determine if a BDS is in a chain
block: simplify bdrv_find_base() and bdrv_find_overlay()
block: make 'top' argument to block-commit optional
block: Accept node-name arguments for block-commit
block: extend block-commit to accept a string for the backing file
block: add ability for block-stream to use node-name
block: add backing-file option to block-stream
block: Add QMP documentation for block-stream
block: add QAPI command to allow live backing file change
block.c | 80 ++++++++--------
block/commit.c | 9 +-
block/stream.c | 11 +--
blockdev.c | 238 ++++++++++++++++++++++++++++++++++++++++++----
hmp.c | 1 +
include/block/block.h | 4 +-
include/block/block_int.h | 3 +-
qapi/block-core.json | 145 +++++++++++++++++++++++++---
qmp-commands.hx | 181 +++++++++++++++++++++++++++++++++--
tests/qemu-iotests/040 | 28 ++++--
10 files changed, 602 insertions(+), 98 deletions(-)
--
1.9.3
next reply other threads:[~2014-06-17 21:54 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-17 21:53 Jeff Cody [this message]
2014-06-17 21:53 ` [Qemu-devel] [PATCH v6 for 2.1 01/10] block: Auto-generate node_names for each BDS entry Jeff Cody
2014-06-18 12:53 ` Benoît Canet
2014-06-18 13:13 ` Jeff Cody
2014-06-18 13:31 ` Benoît Canet
2014-06-19 8:55 ` Stefan Hajnoczi
2014-06-19 12:30 ` Jeff Cody
2014-06-19 17:03 ` Eric Blake
2014-06-20 4:24 ` Stefan Hajnoczi
2014-06-23 12:41 ` Stefan Hajnoczi
2014-06-17 21:53 ` [Qemu-devel] [PATCH v6 for 2.1 02/10] block: add helper function to determine if a BDS is in a chain Jeff Cody
2014-06-19 6:27 ` Stefan Hajnoczi
2014-06-23 10:24 ` Benoît Canet
2014-06-17 21:53 ` [Qemu-devel] [PATCH v6 for 2.1 03/10] block: simplify bdrv_find_base() and bdrv_find_overlay() Jeff Cody
2014-06-19 6:31 ` Stefan Hajnoczi
2014-06-17 21:53 ` [Qemu-devel] [PATCH v6 for 2.1 04/10] block: make 'top' argument to block-commit optional Jeff Cody
2014-06-17 22:25 ` Eric Blake
2014-06-19 16:56 ` Eric Blake
2014-06-19 6:40 ` Stefan Hajnoczi
2014-06-17 21:53 ` [Qemu-devel] [PATCH v6 for 2.1 05/10] block: Accept node-name arguments for block-commit Jeff Cody
2014-06-18 12:58 ` Benoît Canet
2014-06-17 21:53 ` [Qemu-devel] [PATCH v6 for 2.1 06/10] block: extend block-commit to accept a string for the backing file Jeff Cody
2014-06-19 7:49 ` Stefan Hajnoczi
2014-06-17 21:53 ` [Qemu-devel] [PATCH v6 for 2.1 07/10] block: add ability for block-stream to use node-name Jeff Cody
2014-06-18 13:06 ` Benoît Canet
2014-06-19 8:01 ` Stefan Hajnoczi
2014-06-17 21:53 ` [Qemu-devel] [PATCH v6 for 2.1 08/10] block: add backing-file option to block-stream Jeff Cody
2014-06-19 8:04 ` Stefan Hajnoczi
2014-06-17 21:53 ` [Qemu-devel] [PATCH v6 for 2.1 09/10] block: Add QMP documentation for block-stream Jeff Cody
2014-06-19 8:06 ` Stefan Hajnoczi
2014-06-17 21:53 ` [Qemu-devel] [PATCH v6 for 2.1 10/10] block: add QAPI command to allow live backing file change Jeff Cody
2014-06-18 13:15 ` Benoît Canet
2014-06-19 8:37 ` Stefan Hajnoczi
2014-06-19 19:08 ` Jeff Cody
2014-06-19 8:37 ` Stefan Hajnoczi
2014-06-19 9:17 ` [Qemu-devel] [PATCH v6 for 2.1 00/10] Modify block jobs to use node-names Stefan Hajnoczi
2014-06-19 16:26 ` Jeff Cody
2014-06-19 16:49 ` Eric Blake
2014-06-19 16:54 ` Eric Blake
2014-06-19 18:22 ` [Qemu-devel] Op Blockers on child nodes (was Re: [PATCH v6 for 2.1 00/10] Modify block jobs to use) node-names Jeff Cody
2014-06-24 12:55 ` [Qemu-devel] [PATCH v6 for 2.1 00/10] Modify block jobs to use node-names Kevin Wolf
2014-06-23 13:08 ` Stefan Hajnoczi
2014-06-23 14:17 ` Benoît Canet
2014-06-24 2:48 ` Fam Zheng
2014-06-24 13:32 ` Jeff Cody
2014-06-24 14:08 ` Kevin Wolf
2014-06-24 15:30 ` Benoît Canet
2014-06-19 17:49 ` Benoît Canet
2014-06-24 17:08 ` Jeff Cody
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1403041699.git.jcody@redhat.com \
--to=jcody@redhat.com \
--cc=benoit.canet@irqsave.net \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=pkrempa@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.