All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/1] eglibc: check for required distro features
@ 2014-07-03  3:23 Chen Qi
  2014-07-03  3:23 ` [PATCH 1/1] " Chen Qi
  0 siblings, 1 reply; 2+ messages in thread
From: Chen Qi @ 2014-07-03  3:23 UTC (permalink / raw)
  To: openembedded-core

The following changes since commit c36d459f0d40bdbd3ba809835e0475e8992bc778:

  python3: fix builtins imports (2014-06-30 16:35:03 +0100)

are available in the git repository at:

  git://git.openembedded.org/openembedded-core-contrib ChenQi/distro_features_libc
  http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=ChenQi/distro_features_libc

Chen Qi (1):
  eglibc: check for required distro features

 meta/recipes-core/eglibc/eglibc.inc |    7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

-- 
1.7.9.5



^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH 1/1] eglibc: check for required distro features
  2014-07-03  3:23 [PATCH 0/1] eglibc: check for required distro features Chen Qi
@ 2014-07-03  3:23 ` Chen Qi
  0 siblings, 0 replies; 2+ messages in thread
From: Chen Qi @ 2014-07-03  3:23 UTC (permalink / raw)
  To: openembedded-core

If users accidently override the DISTRO_FEATURES in local.conf,
then build failures occur for lack of libc functions.

All features in DISTRO_FEATURES_LIBC should be in DISTRO_FEATURES.
That's why this patch let the recipe inherit distro_features_check
class and set REQUIRED_DISTRO_FEATURES to "${DISTRO_FEATURES_LIBC}".

[YOCTO #6381]

Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
---
 meta/recipes-core/eglibc/eglibc.inc |    7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-core/eglibc/eglibc.inc b/meta/recipes-core/eglibc/eglibc.inc
index 68128e9..af7f6ad 100644
--- a/meta/recipes-core/eglibc/eglibc.inc
+++ b/meta/recipes-core/eglibc/eglibc.inc
@@ -38,9 +38,14 @@ DEPENDS = "virtual/${TARGET_PREFIX}gcc-initial libgcc-initial linux-libc-headers
 #RDEPENDS_${PN} += "${@['','libgcc']['nptl' in '${GLIBC_ADDONS}']}"
 PROVIDES = "virtual/libc virtual/${TARGET_PREFIX}libc-for-gcc"
 PROVIDES += "virtual/libintl virtual/libiconv"
-inherit autotools texinfo
+inherit autotools texinfo distro_features_check
 require eglibc-options.inc
 
+# The main purpose of setting this variable is to prevent users from accidently
+# overriding DISTRO_FEATRUES, causing obscure build failures because of lack
+# of libc functions.
+REQUIRED_DISTRO_FEATURES = "${DISTRO_FEATURES_LIBC}"
+
 LEAD_SONAME = "libc.so"
 
 CACHED_CONFIGUREVARS += " \
-- 
1.7.9.5



^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-07-03  3:22 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-03  3:23 [PATCH 0/1] eglibc: check for required distro features Chen Qi
2014-07-03  3:23 ` [PATCH 1/1] " Chen Qi

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.