* [PATCH 0/1] rootfs.py: fix PRE/POSTPROCESS_COMMANDS for rpm and deb
@ 2014-09-09 10:16 Robert Yang
2014-09-09 10:16 ` [PATCH 1/1] " Robert Yang
0 siblings, 1 reply; 9+ messages in thread
From: Robert Yang @ 2014-09-09 10:16 UTC (permalink / raw)
To: openembedded-core
Hello,
This patch fixes RPM_PREPROCESS_COMMANDS and RPM_POSTPROCESS_COMMANDS
(the similar to deb).
Btw., there is another ROOTFS_POSTINSTALL_COMMAND, only the ipk's
install runs it atm, what's the difference between
ROOTFS_POSTINSTALL_COMMAND and ROOTFS_POSTPROCESS_COMMAND? Do we need
rpm and deb run it, please ?
// Robert
The following changes since commit e72aac2ae9e5fce1715fa04b7e94034fd06892d9:
alsa-lib: libasound should runtime depends on alsa-conf (2014-09-03 11:30:11 +0100)
are available in the git repository at:
git://git.openembedded.org/openembedded-core-contrib rbt/post
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/post
Robert Yang (1):
rootfs.py: fix PRE/POSTPROCESS_COMMANDS for rpm and deb
meta/lib/oe/rootfs.py | 14 +++++++++++++-
1 file changed, 13 insertions(+), 1 deletion(-)
--
1.7.9.5
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 1/1] rootfs.py: fix PRE/POSTPROCESS_COMMANDS for rpm and deb
2014-09-09 10:16 [PATCH 0/1] rootfs.py: fix PRE/POSTPROCESS_COMMANDS for rpm and deb Robert Yang
@ 2014-09-09 10:16 ` Robert Yang
2014-09-24 1:30 ` Robert Yang
2014-10-20 8:05 ` Laurentiu Palcu
0 siblings, 2 replies; 9+ messages in thread
From: Robert Yang @ 2014-09-09 10:16 UTC (permalink / raw)
To: openembedded-core
The rpm didn't run RPM_PREPROCESS_COMMANDS or RPM_POSTPROCESS_COMMANDS,
the similar to deb, this patch fix the problem.
And fix a typo:
DEB_POSTPROCESS_COMMAND -> DEB_POSTPROCESS_COMMANDS
Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
---
meta/lib/oe/rootfs.py | 14 +++++++++++++-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/meta/lib/oe/rootfs.py b/meta/lib/oe/rootfs.py
index 0424a01..ed2af80 100644
--- a/meta/lib/oe/rootfs.py
+++ b/meta/lib/oe/rootfs.py
@@ -295,10 +295,14 @@ class RpmRootfs(Rootfs):
def _create(self):
pkgs_to_install = self.manifest.parse_initial_manifest()
+ rpm_pre_process_cmds = self.d.getVar('RPM_PREPROCESS_COMMANDS', True)
+ rpm_post_process_cmds = self.d.getVar('RPM_POSTPROCESS_COMMANDS', True)
# update PM index files
self.pm.write_index()
+ execute_pre_post_process(self.d, rpm_pre_process_cmds)
+
self.pm.dump_all_available_pkgs()
if self.inc_rpm_image_gen == "1":
@@ -320,6 +324,8 @@ class RpmRootfs(Rootfs):
self.pm.install_complementary()
+ execute_pre_post_process(self.d, rpm_post_process_cmds)
+
self._log_check()
if self.inc_rpm_image_gen == "1":
@@ -401,6 +407,8 @@ class DpkgRootfs(Rootfs):
def _create(self):
pkgs_to_install = self.manifest.parse_initial_manifest()
+ deb_pre_process_cmds = self.d.getVar('DEB_PREPROCESS_COMMANDS', True)
+ deb_post_process_cmds = self.d.getVar('DEB_POSTPROCESS_COMMANDS', True)
alt_dir = self.d.expand("${IMAGE_ROOTFS}/var/lib/dpkg/alternatives")
bb.utils.mkdirhier(alt_dir)
@@ -408,6 +416,8 @@ class DpkgRootfs(Rootfs):
# update PM index files
self.pm.write_index()
+ execute_pre_post_process(self.d, deb_pre_process_cmds)
+
self.pm.update()
for pkg_type in self.install_order:
@@ -423,9 +433,11 @@ class DpkgRootfs(Rootfs):
self.pm.run_pre_post_installs()
+ execute_pre_post_process(self.d, deb_post_process_cmds)
+
@staticmethod
def _depends_list():
- return ['DEPLOY_DIR_DEB', 'DEB_SDK_ARCH', 'APTCONF_TARGET', 'APT_ARGS', 'DPKG_ARCH', 'DEB_PREPROCESS_COMMANDS', 'DEB_POSTPROCESS_COMMAND']
+ return ['DEPLOY_DIR_DEB', 'DEB_SDK_ARCH', 'APTCONF_TARGET', 'APT_ARGS', 'DPKG_ARCH', 'DEB_PREPROCESS_COMMANDS', 'DEB_POSTPROCESS_COMMANDS']
def _get_delayed_postinsts(self):
pkg_list = []
--
1.7.9.5
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 1/1] rootfs.py: fix PRE/POSTPROCESS_COMMANDS for rpm and deb
2014-09-09 10:16 ` [PATCH 1/1] " Robert Yang
@ 2014-09-24 1:30 ` Robert Yang
2014-09-24 10:46 ` Burton, Ross
2014-10-20 8:05 ` Laurentiu Palcu
1 sibling, 1 reply; 9+ messages in thread
From: Robert Yang @ 2014-09-24 1:30 UTC (permalink / raw)
To: openembedded-core
Ping, I think that we need it since it is a function lost.
// Robert
On 09/09/2014 06:16 PM, Robert Yang wrote:
> The rpm didn't run RPM_PREPROCESS_COMMANDS or RPM_POSTPROCESS_COMMANDS,
> the similar to deb, this patch fix the problem.
>
> And fix a typo:
> DEB_POSTPROCESS_COMMAND -> DEB_POSTPROCESS_COMMANDS
>
> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> ---
> meta/lib/oe/rootfs.py | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/meta/lib/oe/rootfs.py b/meta/lib/oe/rootfs.py
> index 0424a01..ed2af80 100644
> --- a/meta/lib/oe/rootfs.py
> +++ b/meta/lib/oe/rootfs.py
> @@ -295,10 +295,14 @@ class RpmRootfs(Rootfs):
>
> def _create(self):
> pkgs_to_install = self.manifest.parse_initial_manifest()
> + rpm_pre_process_cmds = self.d.getVar('RPM_PREPROCESS_COMMANDS', True)
> + rpm_post_process_cmds = self.d.getVar('RPM_POSTPROCESS_COMMANDS', True)
>
> # update PM index files
> self.pm.write_index()
>
> + execute_pre_post_process(self.d, rpm_pre_process_cmds)
> +
> self.pm.dump_all_available_pkgs()
>
> if self.inc_rpm_image_gen == "1":
> @@ -320,6 +324,8 @@ class RpmRootfs(Rootfs):
>
> self.pm.install_complementary()
>
> + execute_pre_post_process(self.d, rpm_post_process_cmds)
> +
> self._log_check()
>
> if self.inc_rpm_image_gen == "1":
> @@ -401,6 +407,8 @@ class DpkgRootfs(Rootfs):
>
> def _create(self):
> pkgs_to_install = self.manifest.parse_initial_manifest()
> + deb_pre_process_cmds = self.d.getVar('DEB_PREPROCESS_COMMANDS', True)
> + deb_post_process_cmds = self.d.getVar('DEB_POSTPROCESS_COMMANDS', True)
>
> alt_dir = self.d.expand("${IMAGE_ROOTFS}/var/lib/dpkg/alternatives")
> bb.utils.mkdirhier(alt_dir)
> @@ -408,6 +416,8 @@ class DpkgRootfs(Rootfs):
> # update PM index files
> self.pm.write_index()
>
> + execute_pre_post_process(self.d, deb_pre_process_cmds)
> +
> self.pm.update()
>
> for pkg_type in self.install_order:
> @@ -423,9 +433,11 @@ class DpkgRootfs(Rootfs):
>
> self.pm.run_pre_post_installs()
>
> + execute_pre_post_process(self.d, deb_post_process_cmds)
> +
> @staticmethod
> def _depends_list():
> - return ['DEPLOY_DIR_DEB', 'DEB_SDK_ARCH', 'APTCONF_TARGET', 'APT_ARGS', 'DPKG_ARCH', 'DEB_PREPROCESS_COMMANDS', 'DEB_POSTPROCESS_COMMAND']
> + return ['DEPLOY_DIR_DEB', 'DEB_SDK_ARCH', 'APTCONF_TARGET', 'APT_ARGS', 'DPKG_ARCH', 'DEB_PREPROCESS_COMMANDS', 'DEB_POSTPROCESS_COMMANDS']
>
> def _get_delayed_postinsts(self):
> pkg_list = []
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/1] rootfs.py: fix PRE/POSTPROCESS_COMMANDS for rpm and deb
2014-09-24 1:30 ` Robert Yang
@ 2014-09-24 10:46 ` Burton, Ross
2014-09-24 14:07 ` Robert Yang
0 siblings, 1 reply; 9+ messages in thread
From: Burton, Ross @ 2014-09-24 10:46 UTC (permalink / raw)
To: Robert Yang; +Cc: OE-core
On 24 September 2014 02:30, Robert Yang <liezhi.yang@windriver.com> wrote:
> Ping, I think that we need it since it is a function lost.
If we're going to unify the behaviour - which is a good thing - then
ROOTFS_POSTPROCESS_COMMAND needs to be unified too.
Ross
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/1] rootfs.py: fix PRE/POSTPROCESS_COMMANDS for rpm and deb
2014-09-24 10:46 ` Burton, Ross
@ 2014-09-24 14:07 ` Robert Yang
2014-10-20 6:26 ` Robert Yang
0 siblings, 1 reply; 9+ messages in thread
From: Robert Yang @ 2014-09-24 14:07 UTC (permalink / raw)
To: Burton, Ross; +Cc: OE-core
On 09/24/2014 06:46 PM, Burton, Ross wrote:
> On 24 September 2014 02:30, Robert Yang <liezhi.yang@windriver.com> wrote:
>> Ping, I think that we need it since it is a function lost.
>
> If we're going to unify the behaviour - which is a good thing - then
> ROOTFS_POSTPROCESS_COMMAND needs to be unified too.
The ROOTFS_POSTPROCESS_COMMAND works well, there isn't anything wrong
with it, did you mean the ROOTFS_POSTINSTALL_COMMAND ? I don't know
the difference between ROOTFS_POSTINSTALL_COMMAND and
ROOTFS_POSTPROCESS_COMMAND, maybe we need remove ROOTFS_POSTINSTALL_COMMAND ?
// Robert
>
> Ross
>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/1] rootfs.py: fix PRE/POSTPROCESS_COMMANDS for rpm and deb
2014-09-24 14:07 ` Robert Yang
@ 2014-10-20 6:26 ` Robert Yang
0 siblings, 0 replies; 9+ messages in thread
From: Robert Yang @ 2014-10-20 6:26 UTC (permalink / raw)
To: Burton, Ross; +Cc: OE-core
On 09/24/2014 10:07 PM, Robert Yang wrote:
>
>
> On 09/24/2014 06:46 PM, Burton, Ross wrote:
>> On 24 September 2014 02:30, Robert Yang <liezhi.yang@windriver.com> wrote:
>>> Ping, I think that we need it since it is a function lost.
>>
>> If we're going to unify the behaviour - which is a good thing - then
>> ROOTFS_POSTPROCESS_COMMAND needs to be unified too.
>
> The ROOTFS_POSTPROCESS_COMMAND works well, there isn't anything wrong
> with it, did you mean the ROOTFS_POSTINSTALL_COMMAND ? I don't know
> the difference between ROOTFS_POSTINSTALL_COMMAND and
> ROOTFS_POSTPROCESS_COMMAND, maybe we need remove ROOTFS_POSTINSTALL_COMMAND ?
>
Hi Ross,
Any comments on this, please ?
// Robert
> // Robert
>
>>
>> Ross
>>
>>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/1] rootfs.py: fix PRE/POSTPROCESS_COMMANDS for rpm and deb
2014-09-09 10:16 ` [PATCH 1/1] " Robert Yang
2014-09-24 1:30 ` Robert Yang
@ 2014-10-20 8:05 ` Laurentiu Palcu
2014-10-20 8:11 ` Laurentiu Palcu
1 sibling, 1 reply; 9+ messages in thread
From: Laurentiu Palcu @ 2014-10-20 8:05 UTC (permalink / raw)
To: Robert Yang; +Cc: openembedded-core
On Tue, Sep 09, 2014 at 03:16:08AM -0700, Robert Yang wrote:
> The rpm didn't run RPM_PREPROCESS_COMMANDS or RPM_POSTPROCESS_COMMANDS,
> the similar to deb, this patch fix the problem.
I'm not sure I understand this... The pre/post process commands are run
in the abstract class Rootfs create() method, which is inherited by all
backends. The create_rootfs() function calls the create() method for
each backend. So, these have to execute. Unless, there is something else
going on, which has to be properly fixed.
>
> And fix a typo:
> DEB_POSTPROCESS_COMMAND -> DEB_POSTPROCESS_COMMANDS
this change is ok.
>
> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> ---
> meta/lib/oe/rootfs.py | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/meta/lib/oe/rootfs.py b/meta/lib/oe/rootfs.py
> index 0424a01..ed2af80 100644
> --- a/meta/lib/oe/rootfs.py
> +++ b/meta/lib/oe/rootfs.py
> @@ -295,10 +295,14 @@ class RpmRootfs(Rootfs):
>
> def _create(self):
> pkgs_to_install = self.manifest.parse_initial_manifest()
> + rpm_pre_process_cmds = self.d.getVar('RPM_PREPROCESS_COMMANDS', True)
> + rpm_post_process_cmds = self.d.getVar('RPM_POSTPROCESS_COMMANDS', True)
>
> # update PM index files
> self.pm.write_index()
>
> + execute_pre_post_process(self.d, rpm_pre_process_cmds)
> +
> self.pm.dump_all_available_pkgs()
>
> if self.inc_rpm_image_gen == "1":
> @@ -320,6 +324,8 @@ class RpmRootfs(Rootfs):
>
> self.pm.install_complementary()
>
> + execute_pre_post_process(self.d, rpm_post_process_cmds)
> +
> self._log_check()
>
> if self.inc_rpm_image_gen == "1":
> @@ -401,6 +407,8 @@ class DpkgRootfs(Rootfs):
>
> def _create(self):
> pkgs_to_install = self.manifest.parse_initial_manifest()
> + deb_pre_process_cmds = self.d.getVar('DEB_PREPROCESS_COMMANDS', True)
> + deb_post_process_cmds = self.d.getVar('DEB_POSTPROCESS_COMMANDS', True)
>
> alt_dir = self.d.expand("${IMAGE_ROOTFS}/var/lib/dpkg/alternatives")
> bb.utils.mkdirhier(alt_dir)
> @@ -408,6 +416,8 @@ class DpkgRootfs(Rootfs):
> # update PM index files
> self.pm.write_index()
>
> + execute_pre_post_process(self.d, deb_pre_process_cmds)
> +
> self.pm.update()
>
> for pkg_type in self.install_order:
> @@ -423,9 +433,11 @@ class DpkgRootfs(Rootfs):
>
> self.pm.run_pre_post_installs()
>
> + execute_pre_post_process(self.d, deb_post_process_cmds)
> +
> @staticmethod
> def _depends_list():
> - return ['DEPLOY_DIR_DEB', 'DEB_SDK_ARCH', 'APTCONF_TARGET', 'APT_ARGS', 'DPKG_ARCH', 'DEB_PREPROCESS_COMMANDS', 'DEB_POSTPROCESS_COMMAND']
> + return ['DEPLOY_DIR_DEB', 'DEB_SDK_ARCH', 'APTCONF_TARGET', 'APT_ARGS', 'DPKG_ARCH', 'DEB_PREPROCESS_COMMANDS', 'DEB_POSTPROCESS_COMMANDS']
>
> def _get_delayed_postinsts(self):
> pkg_list = []
> --
> 1.7.9.5
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/1] rootfs.py: fix PRE/POSTPROCESS_COMMANDS for rpm and deb
2014-10-20 8:05 ` Laurentiu Palcu
@ 2014-10-20 8:11 ` Laurentiu Palcu
0 siblings, 0 replies; 9+ messages in thread
From: Laurentiu Palcu @ 2014-10-20 8:11 UTC (permalink / raw)
To: Robert Yang; +Cc: openembedded-core
My bad... I saw it now... It's about backend specific pre/post commands.
Sorry for the noise.
laurentiu
On Mon, Oct 20, 2014 at 11:05:15AM +0300, Laurentiu Palcu wrote:
> On Tue, Sep 09, 2014 at 03:16:08AM -0700, Robert Yang wrote:
> > The rpm didn't run RPM_PREPROCESS_COMMANDS or RPM_POSTPROCESS_COMMANDS,
> > the similar to deb, this patch fix the problem.
> I'm not sure I understand this... The pre/post process commands are run
> in the abstract class Rootfs create() method, which is inherited by all
> backends. The create_rootfs() function calls the create() method for
> each backend. So, these have to execute. Unless, there is something else
> going on, which has to be properly fixed.
>
> >
> > And fix a typo:
> > DEB_POSTPROCESS_COMMAND -> DEB_POSTPROCESS_COMMANDS
> this change is ok.
>
> >
> > Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> > ---
> > meta/lib/oe/rootfs.py | 14 +++++++++++++-
> > 1 file changed, 13 insertions(+), 1 deletion(-)
> >
> > diff --git a/meta/lib/oe/rootfs.py b/meta/lib/oe/rootfs.py
> > index 0424a01..ed2af80 100644
> > --- a/meta/lib/oe/rootfs.py
> > +++ b/meta/lib/oe/rootfs.py
> > @@ -295,10 +295,14 @@ class RpmRootfs(Rootfs):
> >
> > def _create(self):
> > pkgs_to_install = self.manifest.parse_initial_manifest()
> > + rpm_pre_process_cmds = self.d.getVar('RPM_PREPROCESS_COMMANDS', True)
> > + rpm_post_process_cmds = self.d.getVar('RPM_POSTPROCESS_COMMANDS', True)
> >
> > # update PM index files
> > self.pm.write_index()
> >
> > + execute_pre_post_process(self.d, rpm_pre_process_cmds)
> > +
> > self.pm.dump_all_available_pkgs()
> >
> > if self.inc_rpm_image_gen == "1":
> > @@ -320,6 +324,8 @@ class RpmRootfs(Rootfs):
> >
> > self.pm.install_complementary()
> >
> > + execute_pre_post_process(self.d, rpm_post_process_cmds)
> > +
> > self._log_check()
> >
> > if self.inc_rpm_image_gen == "1":
> > @@ -401,6 +407,8 @@ class DpkgRootfs(Rootfs):
> >
> > def _create(self):
> > pkgs_to_install = self.manifest.parse_initial_manifest()
> > + deb_pre_process_cmds = self.d.getVar('DEB_PREPROCESS_COMMANDS', True)
> > + deb_post_process_cmds = self.d.getVar('DEB_POSTPROCESS_COMMANDS', True)
> >
> > alt_dir = self.d.expand("${IMAGE_ROOTFS}/var/lib/dpkg/alternatives")
> > bb.utils.mkdirhier(alt_dir)
> > @@ -408,6 +416,8 @@ class DpkgRootfs(Rootfs):
> > # update PM index files
> > self.pm.write_index()
> >
> > + execute_pre_post_process(self.d, deb_pre_process_cmds)
> > +
> > self.pm.update()
> >
> > for pkg_type in self.install_order:
> > @@ -423,9 +433,11 @@ class DpkgRootfs(Rootfs):
> >
> > self.pm.run_pre_post_installs()
> >
> > + execute_pre_post_process(self.d, deb_post_process_cmds)
> > +
> > @staticmethod
> > def _depends_list():
> > - return ['DEPLOY_DIR_DEB', 'DEB_SDK_ARCH', 'APTCONF_TARGET', 'APT_ARGS', 'DPKG_ARCH', 'DEB_PREPROCESS_COMMANDS', 'DEB_POSTPROCESS_COMMAND']
> > + return ['DEPLOY_DIR_DEB', 'DEB_SDK_ARCH', 'APTCONF_TARGET', 'APT_ARGS', 'DPKG_ARCH', 'DEB_PREPROCESS_COMMANDS', 'DEB_POSTPROCESS_COMMANDS']
> >
> > def _get_delayed_postinsts(self):
> > pkg_list = []
> > --
> > 1.7.9.5
> >
> > --
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 0/1] rootfs.py: fix PRE/POSTPROCESS_COMMANDS for rpm and deb
@ 2015-07-28 3:10 Robert Yang
0 siblings, 0 replies; 9+ messages in thread
From: Robert Yang @ 2015-07-28 3:10 UTC (permalink / raw)
To: openembedded-core
The following changes since commit 27d068d05239c26a3848eb101571acab54635e37:
harfbuzz: upgrade to 1.0.1 (2015-07-27 23:28:23 +0100)
are available in the git repository at:
git://git.openembedded.org/openembedded-core-contrib rbt/post
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/PU
Robert Yang (1):
rootfs.py: fix PRE/POSTPROCESS_COMMANDS for rpm and deb
meta/lib/oe/rootfs.py | 16 +++++++++++++++-
1 file changed, 15 insertions(+), 1 deletion(-)
--
1.7.9.5
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2015-07-28 3:10 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-09 10:16 [PATCH 0/1] rootfs.py: fix PRE/POSTPROCESS_COMMANDS for rpm and deb Robert Yang
2014-09-09 10:16 ` [PATCH 1/1] " Robert Yang
2014-09-24 1:30 ` Robert Yang
2014-09-24 10:46 ` Burton, Ross
2014-09-24 14:07 ` Robert Yang
2014-10-20 6:26 ` Robert Yang
2014-10-20 8:05 ` Laurentiu Palcu
2014-10-20 8:11 ` Laurentiu Palcu
2015-07-28 3:10 [PATCH 0/1] " Robert Yang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.