* [RFC 0/2] x86, vdso, pvclock: Cleanups and speedups
@ 2014-12-23 0:39 Andy Lutomirski
0 siblings, 0 replies; 8+ messages in thread
From: Andy Lutomirski @ 2014-12-23 0:39 UTC (permalink / raw)
To: Paolo Bonzini, Marcelo Tosatti
Cc: Gleb Natapov, xen-devel, linux-kernel, kvm list, Andy Lutomirski
This is a dramatic simplification and speedup of the vdso pvclock read
code. Is it correct?
Andy Lutomirski (2):
x86, vdso: Use asm volatile in __getcpu
x86, vdso, pvclock: Simplify and speed up the vdso pvclock reader
arch/x86/include/asm/vgtod.h | 6 ++--
arch/x86/vdso/vclock_gettime.c | 82 ++++++++++++++++++++++++------------------
2 files changed, 51 insertions(+), 37 deletions(-)
--
2.1.0
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RFC 0/2] x86, vdso, pvclock: Cleanups and speedups
2014-12-23 8:16 ` Andy Lutomirski
2014-12-23 8:30 ` Paolo Bonzini
@ 2014-12-23 8:30 ` Paolo Bonzini
1 sibling, 0 replies; 8+ messages in thread
From: Paolo Bonzini @ 2014-12-23 8:30 UTC (permalink / raw)
To: Andy Lutomirski
Cc: Marcelo Tosatti, Gleb Natapov, kvm list, linux-kernel, xen-devel,
glommer
On 23/12/2014 09:16, Andy Lutomirski wrote:
> Any thoughts as to whether it should be tagged for stable? I haven't
> looked closely enough at the old pvclock code or the generated code to
> have much of an opinion there. It'll be a big speedup for non-pvclock
> users at least.
Yes, please.
Paolo
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RFC 0/2] x86, vdso, pvclock: Cleanups and speedups
2014-12-23 8:16 ` Andy Lutomirski
@ 2014-12-23 8:30 ` Paolo Bonzini
2014-12-23 8:30 ` Paolo Bonzini
1 sibling, 0 replies; 8+ messages in thread
From: Paolo Bonzini @ 2014-12-23 8:30 UTC (permalink / raw)
To: Andy Lutomirski
Cc: kvm list, Gleb Natapov, glommer, Marcelo Tosatti, linux-kernel,
xen-devel
On 23/12/2014 09:16, Andy Lutomirski wrote:
> Any thoughts as to whether it should be tagged for stable? I haven't
> looked closely enough at the old pvclock code or the generated code to
> have much of an opinion there. It'll be a big speedup for non-pvclock
> users at least.
Yes, please.
Paolo
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RFC 0/2] x86, vdso, pvclock: Cleanups and speedups
2014-12-23 7:21 ` Paolo Bonzini
@ 2014-12-23 8:16 ` Andy Lutomirski
2014-12-23 8:30 ` Paolo Bonzini
2014-12-23 8:30 ` Paolo Bonzini
2014-12-23 8:16 ` Andy Lutomirski
1 sibling, 2 replies; 8+ messages in thread
From: Andy Lutomirski @ 2014-12-23 8:16 UTC (permalink / raw)
To: Paolo Bonzini
Cc: Marcelo Tosatti, Gleb Natapov, kvm list, linux-kernel, xen-devel,
glommer
On Mon, Dec 22, 2014 at 11:21 PM, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
>
> On 23/12/2014 01:39, Andy Lutomirski wrote:
>> This is a dramatic simplification and speedup of the vdso pvclock read
>> code. Is it correct?
>>
>> Andy Lutomirski (2):
>> x86, vdso: Use asm volatile in __getcpu
>> x86, vdso, pvclock: Simplify and speed up the vdso pvclock reader
>
> Patch 1 is ok,
>
> Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Any thoughts as to whether it should be tagged for stable? I haven't
looked closely enough at the old pvclock code or the generated code to
have much of an opinion there. It'll be a big speedup for non-pvclock
users at least.
--Andy
>
> For patch 2 I will defer to Marcelo and Glauber (and the Xen folks).
>
> Paolo
--
Andy Lutomirski
AMA Capital Management, LLC
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RFC 0/2] x86, vdso, pvclock: Cleanups and speedups
2014-12-23 7:21 ` Paolo Bonzini
2014-12-23 8:16 ` Andy Lutomirski
@ 2014-12-23 8:16 ` Andy Lutomirski
1 sibling, 0 replies; 8+ messages in thread
From: Andy Lutomirski @ 2014-12-23 8:16 UTC (permalink / raw)
To: Paolo Bonzini
Cc: kvm list, Gleb Natapov, glommer, Marcelo Tosatti, linux-kernel,
xen-devel
On Mon, Dec 22, 2014 at 11:21 PM, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
>
> On 23/12/2014 01:39, Andy Lutomirski wrote:
>> This is a dramatic simplification and speedup of the vdso pvclock read
>> code. Is it correct?
>>
>> Andy Lutomirski (2):
>> x86, vdso: Use asm volatile in __getcpu
>> x86, vdso, pvclock: Simplify and speed up the vdso pvclock reader
>
> Patch 1 is ok,
>
> Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Any thoughts as to whether it should be tagged for stable? I haven't
looked closely enough at the old pvclock code or the generated code to
have much of an opinion there. It'll be a big speedup for non-pvclock
users at least.
--Andy
>
> For patch 2 I will defer to Marcelo and Glauber (and the Xen folks).
>
> Paolo
--
Andy Lutomirski
AMA Capital Management, LLC
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RFC 0/2] x86, vdso, pvclock: Cleanups and speedups
2014-12-23 0:39 Andy Lutomirski
@ 2014-12-23 7:21 ` Paolo Bonzini
2014-12-23 8:16 ` Andy Lutomirski
2014-12-23 8:16 ` Andy Lutomirski
2014-12-23 7:21 ` Paolo Bonzini
1 sibling, 2 replies; 8+ messages in thread
From: Paolo Bonzini @ 2014-12-23 7:21 UTC (permalink / raw)
To: Andy Lutomirski, Marcelo Tosatti
Cc: Gleb Natapov, kvm list, linux-kernel, xen-devel, glommer
On 23/12/2014 01:39, Andy Lutomirski wrote:
> This is a dramatic simplification and speedup of the vdso pvclock read
> code. Is it correct?
>
> Andy Lutomirski (2):
> x86, vdso: Use asm volatile in __getcpu
> x86, vdso, pvclock: Simplify and speed up the vdso pvclock reader
Patch 1 is ok,
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
For patch 2 I will defer to Marcelo and Glauber (and the Xen folks).
Paolo
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RFC 0/2] x86, vdso, pvclock: Cleanups and speedups
2014-12-23 0:39 Andy Lutomirski
2014-12-23 7:21 ` Paolo Bonzini
@ 2014-12-23 7:21 ` Paolo Bonzini
1 sibling, 0 replies; 8+ messages in thread
From: Paolo Bonzini @ 2014-12-23 7:21 UTC (permalink / raw)
To: Andy Lutomirski, Marcelo Tosatti
Cc: Gleb Natapov, xen-devel, linux-kernel, kvm list, glommer
On 23/12/2014 01:39, Andy Lutomirski wrote:
> This is a dramatic simplification and speedup of the vdso pvclock read
> code. Is it correct?
>
> Andy Lutomirski (2):
> x86, vdso: Use asm volatile in __getcpu
> x86, vdso, pvclock: Simplify and speed up the vdso pvclock reader
Patch 1 is ok,
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
For patch 2 I will defer to Marcelo and Glauber (and the Xen folks).
Paolo
^ permalink raw reply [flat|nested] 8+ messages in thread
* [RFC 0/2] x86, vdso, pvclock: Cleanups and speedups
@ 2014-12-23 0:39 Andy Lutomirski
2014-12-23 7:21 ` Paolo Bonzini
2014-12-23 7:21 ` Paolo Bonzini
0 siblings, 2 replies; 8+ messages in thread
From: Andy Lutomirski @ 2014-12-23 0:39 UTC (permalink / raw)
To: Paolo Bonzini, Marcelo Tosatti
Cc: Gleb Natapov, kvm list, linux-kernel, xen-devel, Andy Lutomirski
This is a dramatic simplification and speedup of the vdso pvclock read
code. Is it correct?
Andy Lutomirski (2):
x86, vdso: Use asm volatile in __getcpu
x86, vdso, pvclock: Simplify and speed up the vdso pvclock reader
arch/x86/include/asm/vgtod.h | 6 ++--
arch/x86/vdso/vclock_gettime.c | 82 ++++++++++++++++++++++++------------------
2 files changed, 51 insertions(+), 37 deletions(-)
--
2.1.0
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2014-12-23 8:30 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-12-23 0:39 [RFC 0/2] x86, vdso, pvclock: Cleanups and speedups Andy Lutomirski
2014-12-23 0:39 Andy Lutomirski
2014-12-23 7:21 ` Paolo Bonzini
2014-12-23 8:16 ` Andy Lutomirski
2014-12-23 8:30 ` Paolo Bonzini
2014-12-23 8:30 ` Paolo Bonzini
2014-12-23 8:16 ` Andy Lutomirski
2014-12-23 7:21 ` Paolo Bonzini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.