[PATCH v3 0/2] Staging: rtl8192u: Fix coding style issues.

[PATCH v3 0/2] Staging: rtl8192u: Fix coding style issues.

[Ksenija Stanojevic]

This patchset fixes following issues:
        Convert comments from C99 to C89 style.
        Staging: rtl8192u: Fix grammar in a sentence.

Signed-off-by: Ksenija Stanojevic<ksenija.stanojevic@gmail.com>

Ksenija Stanojevic (2):
  Staging: rtl8192u: Convert comments from C99 to C89 style
  Staging: rtl8192u: Fix grammar in a sentence.

 .../staging/rtl8192u/ieee80211/ieee80211_module.c  | 52 +++++++++++-----------
 1 file changed, 26 insertions(+), 26 deletions(-)

-- 
1.9.1

[PATCH v3 1/2] Staging: rtl8192u: Convert comments from C99 to C89 style

[Ksenija Stanojevic]

Remove linux/config.h because it is not used in modern linux versions
and replace C99 comments with C89.
Issue found by checkpatch.pl.

Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>

---
v2: remove linux/config.h and format comment.
v3: change commit message.
 .../staging/rtl8192u/ieee80211/ieee80211_module.c  | 52 +++++++++++-----------
 1 file changed, 26 insertions(+), 26 deletions(-)

diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
index afbd09d..4d6bd2e 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
@@ -31,7 +31,6 @@
 *******************************************************************************/
 
 #include <linux/compiler.h>
-//#include <linux/config.h>
 #include <linux/errno.h>
 #include <linux/if_arp.h>
 #include <linux/in6.h>
@@ -141,7 +140,7 @@ struct net_device *alloc_ieee80211(int sizeof_priv)
 	spin_lock_init(&ieee->wpax_suitlist_lock);
 	spin_lock_init(&ieee->bw_spinlock);
 	spin_lock_init(&ieee->reorder_spinlock);
-	//added by WB
+	/* added by WB */
 	atomic_set(&(ieee->atm_chnlop), 0);
 	atomic_set(&(ieee->atm_swbw), 0);
 
@@ -152,8 +151,8 @@ struct net_device *alloc_ieee80211(int sizeof_priv)
 	ieee->privacy_invoked = 0;
 	ieee->ieee802_1x = 1;
 	ieee->raw_tx = 0;
-	//ieee->hwsec_support = 1; //defalt support hw security. //use module_param instead.
-	ieee->hwsec_active = 0; //disable hwsec, switch it on when necessary.
+	/* ieee->hwsec_support = 1; //defalt support hw security. //use module_param instead. */
+	ieee->hwsec_active = 0; /* disable hwsec, switch it on when necessary. */
 
 	ieee80211_softmac_init(ieee);
 
@@ -164,7 +163,7 @@ struct net_device *alloc_ieee80211(int sizeof_priv)
 		goto failed;
 	}
 	HTUpdateDefaultSetting(ieee);
-	HTInitializeHTInfo(ieee); //may move to other place.
+	HTInitializeHTInfo(ieee); /* may move to other place. */
 	TSInitialize(ieee);
 
 	for (i = 0; i < IEEE_IBSS_MAC_HASH_SIZE; i++)
@@ -176,7 +175,7 @@ struct net_device *alloc_ieee80211(int sizeof_priv)
 	  ieee->last_packet_time[i] = 0;
 	}
 
-//These function were added to load crypte module autoly
+/* These function were added to load crypte module autoly */
 	ieee80211_tkip_null();
 	ieee80211_wep_null();
 	ieee80211_ccmp_null();
@@ -195,8 +194,8 @@ void free_ieee80211(struct net_device *dev)
 {
 	struct ieee80211_device *ieee = netdev_priv(dev);
 	int i;
-	//struct list_head *p, *q;
-//	del_timer_sync(&ieee->SwBwTimer);
+	/* struct list_head *p, *q; */
+     /* del_timer_sync(&ieee->SwBwTimer); */
 	kfree(ieee->pHTInfo);
 	ieee->pHTInfo = NULL;
 	RemoveAllTS(ieee);
@@ -222,24 +221,25 @@ void free_ieee80211(struct net_device *dev)
 
 u32 ieee80211_debug_level;
 static int debug = \
-	//		    IEEE80211_DL_INFO	|
-	//		    IEEE80211_DL_WX	|
-	//		    IEEE80211_DL_SCAN	|
-	//		    IEEE80211_DL_STATE	|
-	//		    IEEE80211_DL_MGMT	|
-	//		    IEEE80211_DL_FRAG	|
-	//		    IEEE80211_DL_EAP	|
-	//		    IEEE80211_DL_DROP	|
-	//		    IEEE80211_DL_TX	|
-	//		    IEEE80211_DL_RX	|
-			    //IEEE80211_DL_QOS    |
-	//		    IEEE80211_DL_HT	|
-	//		    IEEE80211_DL_TS	|
-//			    IEEE80211_DL_BA	|
-	//		    IEEE80211_DL_REORDER|
-//			    IEEE80211_DL_TRACE  |
-			    //IEEE80211_DL_DATA	|
-			    IEEE80211_DL_ERR	  //awayls open this flags to show error out
+			 /* IEEE80211_DL_INFO	| */
+			 /* IEEE80211_DL_WX	| */
+			 /* IEEE80211_DL_SCAN	| */
+			 /* IEEE80211_DL_STATE	| */
+			 /* IEEE80211_DL_MGMT	| */
+			 /* IEEE80211_DL_FRAG	| */
+			 /* IEEE80211_DL_EAP	| */
+			 /* IEEE80211_DL_DROP	| */
+			 /* IEEE80211_DL_TX	| */
+			 /* IEEE80211_DL_RX	| */
+			 /* IEEE80211_DL_QOS    | */
+			 /* IEEE80211_DL_HT	| */
+			 /* IEEE80211_DL_TS	| */
+			 /* IEEE80211_DL_BA	| */
+			 /* IEEE80211_DL_REORDER| */
+			 /* IEEE80211_DL_TRACE  | */
+			 /* IEEE80211_DL_DATA	| */
+			    IEEE80211_DL_ERR	  /* awayls open this flags
+						   * to show error out */
 			    ;
 static struct proc_dir_entry *ieee80211_proc;
 
-- 
1.9.1

[PATCH v3 2/2] Staging: rtl8192u: Fix grammar in a sentence.

[Ksenija Stanojevic]

Write always instead of awalys.

Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
---
v3: nothing has changed
v2: nothing has changed
 drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
index 4d6bd2e..0a76f81 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
@@ -238,7 +238,7 @@ static int debug = \
 			 /* IEEE80211_DL_REORDER| */
 			 /* IEEE80211_DL_TRACE  | */
 			 /* IEEE80211_DL_DATA	| */
-			    IEEE80211_DL_ERR	  /* awayls open this flags
+			    IEEE80211_DL_ERR	  /* always open this flags
 						   * to show error out */
 			    ;
 static struct proc_dir_entry *ieee80211_proc;
-- 
1.9.1

Re: [Outreachy kernel] [PATCH v3 1/2] Staging: rtl8192u: Convert comments from C99 to C89 style

[Greg KH]

On Sun, Feb 22, 2015 at 04:52:58PM +0100, Ksenija Stanojevic wrote:
> Remove linux/config.h because it is not used in modern linux versions
> and replace C99 comments with C89.
> Issue found by checkpatch.pl.
> 
> Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
> 
> ---
> v2: remove linux/config.h and format comment.
> v3: change commit message.
>  .../staging/rtl8192u/ieee80211/ieee80211_module.c  | 52 +++++++++++-----------
>  1 file changed, 26 insertions(+), 26 deletions(-)

This series fails to apply to the tree now, as someone else already did
these same changes :(