All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/1] fs-perms.txt: fix ROOT_HOME's permission
@ 2016-04-07  7:50 Robert Yang
  2016-04-07  7:50 ` [PATCH 1/1] " Robert Yang
  0 siblings, 1 reply; 9+ messages in thread
From: Robert Yang @ 2016-04-07  7:50 UTC (permalink / raw)
  To: openembedded-core

The following changes since commit 5ebea1114d54120d5ff5d8a6cd148110d0fda23f:

  build-appliance-image: Update to master head revision (2016-04-06 23:54:57 +0100)

are available in the git repository at:

  git://git.openembedded.org/openembedded-core-contrib rbt/home
  http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/home

Robert Yang (1):
  fs-perms.txt: fix ROOT_HOME's permission

 meta/files/fs-perms.txt | 1 +
 1 file changed, 1 insertion(+)

-- 
2.8.0



^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH 1/1] fs-perms.txt: fix ROOT_HOME's permission
  2016-04-07  7:50 [PATCH 0/1] fs-perms.txt: fix ROOT_HOME's permission Robert Yang
@ 2016-04-07  7:50 ` Robert Yang
  2016-04-07 13:30   ` Dan McGregor
  0 siblings, 1 reply; 9+ messages in thread
From: Robert Yang @ 2016-04-07  7:50 UTC (permalink / raw)
  To: openembedded-core

It should be 0700 rather than 0755.

Reported-by: Charles Chan <charles.wh.chan@gmail.com>
Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
---
 meta/files/fs-perms.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/files/fs-perms.txt b/meta/files/fs-perms.txt
index 109cbe5..1d74da7 100644
--- a/meta/files/fs-perms.txt
+++ b/meta/files/fs-perms.txt
@@ -51,6 +51,7 @@ ${localstatedir}/lock	link	/run/lock
 ${localstatedir}/tmp	link	volatile/tmp
 
 /home				0755	root	root	false - - -
+${ROOT_HOME}			0700	root	root	false - - -
 /srv				0755	root	root	false - - -
 ${prefix}/src			0755	root	root	false - - -
 ${localstatedir}/local		0755	root	root	false - - -
-- 
2.8.0



^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH 1/1] fs-perms.txt: fix ROOT_HOME's permission
  2016-04-07  7:50 ` [PATCH 1/1] " Robert Yang
@ 2016-04-07 13:30   ` Dan McGregor
  2016-04-07 13:46     ` Robert Yang
  0 siblings, 1 reply; 9+ messages in thread
From: Dan McGregor @ 2016-04-07 13:30 UTC (permalink / raw)
  To: Robert Yang; +Cc: Patches and discussions about the oe-core layer

On 7 April 2016 at 01:50, Robert Yang <liezhi.yang@windriver.com> wrote:
> It should be 0700 rather than 0755.
>
> Reported-by: Charles Chan <charles.wh.chan@gmail.com>
> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> ---
>  meta/files/fs-perms.txt | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/meta/files/fs-perms.txt b/meta/files/fs-perms.txt
> index 109cbe5..1d74da7 100644
> --- a/meta/files/fs-perms.txt
> +++ b/meta/files/fs-perms.txt
> @@ -51,6 +51,7 @@ ${localstatedir}/lock link    /run/lock
>  ${localstatedir}/tmp   link    volatile/tmp
>
>  /home                          0755    root    root    false - - -
> +${ROOT_HOME}                   0700    root    root    false - - -

I'd like to see this in the section labelled "Special permissions from
base-files" around line 58. I think that makes it more clear that this
is a special permission setting.


>  /srv                           0755    root    root    false - - -
>  ${prefix}/src                  0755    root    root    false - - -
>  ${localstatedir}/local         0755    root    root    false - - -
> --
> 2.8.0
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 1/1] fs-perms.txt: fix ROOT_HOME's permission
  2016-04-07 13:30   ` Dan McGregor
@ 2016-04-07 13:46     ` Robert Yang
  2016-04-07 15:55       ` Dan McGregor
  0 siblings, 1 reply; 9+ messages in thread
From: Robert Yang @ 2016-04-07 13:46 UTC (permalink / raw)
  To: Dan McGregor; +Cc: Patches and discussions about the oe-core layer



On 04/07/2016 09:30 PM, Dan McGregor wrote:
> On 7 April 2016 at 01:50, Robert Yang <liezhi.yang@windriver.com> wrote:
>> It should be 0700 rather than 0755.
>>
>> Reported-by: Charles Chan <charles.wh.chan@gmail.com>
>> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
>> ---
>>   meta/files/fs-perms.txt | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/meta/files/fs-perms.txt b/meta/files/fs-perms.txt
>> index 109cbe5..1d74da7 100644
>> --- a/meta/files/fs-perms.txt
>> +++ b/meta/files/fs-perms.txt
>> @@ -51,6 +51,7 @@ ${localstatedir}/lock link    /run/lock
>>   ${localstatedir}/tmp   link    volatile/tmp
>>
>>   /home                          0755    root    root    false - - -
>> +${ROOT_HOME}                   0700    root    root    false - - -
>
> I'd like to see this in the section labelled "Special permissions from
> base-files" around line 58. I think that makes it more clear that this
> is a special permission setting.

Thanks, updated in the repo:

   git://git.openembedded.org/openembedded-core-contrib rbt/home
   http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/home


commit ccc59f44f5fc6c6ccef6b0fed58b0d582c9ee32b
Author: Robert Yang <liezhi.yang@windriver.com>
Date:   Tue Apr 5 22:34:25 2016 -0700

     fs-perms.txt: fix ROOT_HOME's permission

     It should be 0700 rather than 0755.

     Reported-by: Charles Chan <charles.wh.chan@gmail.com>
     Signed-off-by: Robert Yang <liezhi.yang@windriver.com>

diff --git a/meta/files/fs-perms.txt b/meta/files/fs-perms.txt
index 109cbe5..6c1083c 100644
--- a/meta/files/fs-perms.txt
+++ b/meta/files/fs-perms.txt
@@ -59,6 +59,7 @@ ${localstatedir}/local                0755    root    root 
false - - -
  # Set 1777
  /tmp                           01777   root    root    false - - -
  ${localstatedir}/volatile/tmp  01777   root    root    false - - -
+${ROOT_HOME}                   0700    root    root    false - - -

  # Set 755-lsb
  /srv                           0755    root    root    false - - -


// Robert

>
>
>>   /srv                           0755    root    root    false - - -
>>   ${prefix}/src                  0755    root    root    false - - -
>>   ${localstatedir}/local         0755    root    root    false - - -
>> --
>> 2.8.0
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH 1/1] fs-perms.txt: fix ROOT_HOME's permission
  2016-04-07 13:46     ` Robert Yang
@ 2016-04-07 15:55       ` Dan McGregor
  2016-04-08  0:47         ` Robert Yang
  0 siblings, 1 reply; 9+ messages in thread
From: Dan McGregor @ 2016-04-07 15:55 UTC (permalink / raw)
  To: Robert Yang; +Cc: Patches and discussions about the oe-core layer

On 7 April 2016 at 07:46, Robert Yang <liezhi.yang@windriver.com> wrote:
>
>
> On 04/07/2016 09:30 PM, Dan McGregor wrote:
>>
>> On 7 April 2016 at 01:50, Robert Yang <liezhi.yang@windriver.com> wrote:
>>>
>>> It should be 0700 rather than 0755.
>>>
>>> Reported-by: Charles Chan <charles.wh.chan@gmail.com>
>>> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
>>> ---
>>>   meta/files/fs-perms.txt | 1 +
>>>   1 file changed, 1 insertion(+)
>>>
>>> diff --git a/meta/files/fs-perms.txt b/meta/files/fs-perms.txt
>>> index 109cbe5..1d74da7 100644
>>> --- a/meta/files/fs-perms.txt
>>> +++ b/meta/files/fs-perms.txt
>>> @@ -51,6 +51,7 @@ ${localstatedir}/lock link    /run/lock
>>>   ${localstatedir}/tmp   link    volatile/tmp
>>>
>>>   /home                          0755    root    root    false - - -
>>> +${ROOT_HOME}                   0700    root    root    false - - -
>>
>>
>> I'd like to see this in the section labelled "Special permissions from
>> base-files" around line 58. I think that makes it more clear that this
>> is a special permission setting.
>
>
> Thanks, updated in the repo:
>
>   git://git.openembedded.org/openembedded-core-contrib rbt/home
>
> http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/home
>
>
> commit ccc59f44f5fc6c6ccef6b0fed58b0d582c9ee32b
> Author: Robert Yang <liezhi.yang@windriver.com>
> Date:   Tue Apr 5 22:34:25 2016 -0700
>
>     fs-perms.txt: fix ROOT_HOME's permission
>
>     It should be 0700 rather than 0755.
>
>     Reported-by: Charles Chan <charles.wh.chan@gmail.com>
>     Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
>
> diff --git a/meta/files/fs-perms.txt b/meta/files/fs-perms.txt
> index 109cbe5..6c1083c 100644
> --- a/meta/files/fs-perms.txt
> +++ b/meta/files/fs-perms.txt
> @@ -59,6 +59,7 @@ ${localstatedir}/local                0755    root    root
> false - - -
>  # Set 1777
>  /tmp                           01777   root    root    false - - -
>  ${localstatedir}/volatile/tmp  01777   root    root    false - - -
> +${ROOT_HOME}                   0700    root    root    false - - -
>

Thanks, this is the right track, but this implies that ${ROOT_HOME}
should be mode 1777, how about:

+
+# Set 700
+${ROOT_HOME}                   0700    root    root    false - - -

>  # Set 755-lsb
>  /srv                           0755    root    root    false - - -
>
>
> // Robert
>
>
>>
>>
>>>   /srv                           0755    root    root    false - - -
>>>   ${prefix}/src                  0755    root    root    false - - -
>>>   ${localstatedir}/local         0755    root    root    false - - -
>>> --
>>> 2.8.0
>>>
>>> --
>>> _______________________________________________
>>> Openembedded-core mailing list
>>> Openembedded-core@lists.openembedded.org
>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>
>>
>


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 1/1] fs-perms.txt: fix ROOT_HOME's permission
  2016-04-07 15:55       ` Dan McGregor
@ 2016-04-08  0:47         ` Robert Yang
  2016-04-08  3:49           ` Dan McGregor
  2016-04-14 16:23           ` Dan McGregor
  0 siblings, 2 replies; 9+ messages in thread
From: Robert Yang @ 2016-04-08  0:47 UTC (permalink / raw)
  To: Dan McGregor; +Cc: Patches and discussions about the oe-core layer



On 04/07/2016 11:55 PM, Dan McGregor wrote:
> On 7 April 2016 at 07:46, Robert Yang <liezhi.yang@windriver.com> wrote:
>>
>>
>> On 04/07/2016 09:30 PM, Dan McGregor wrote:
>>>
>>> On 7 April 2016 at 01:50, Robert Yang <liezhi.yang@windriver.com> wrote:
>>>>
>>>> It should be 0700 rather than 0755.
>>>>
>>>> Reported-by: Charles Chan <charles.wh.chan@gmail.com>
>>>> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
>>>> ---
>>>>    meta/files/fs-perms.txt | 1 +
>>>>    1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/meta/files/fs-perms.txt b/meta/files/fs-perms.txt
>>>> index 109cbe5..1d74da7 100644
>>>> --- a/meta/files/fs-perms.txt
>>>> +++ b/meta/files/fs-perms.txt
>>>> @@ -51,6 +51,7 @@ ${localstatedir}/lock link    /run/lock
>>>>    ${localstatedir}/tmp   link    volatile/tmp
>>>>
>>>>    /home                          0755    root    root    false - - -
>>>> +${ROOT_HOME}                   0700    root    root    false - - -
>>>
>>>
>>> I'd like to see this in the section labelled "Special permissions from
>>> base-files" around line 58. I think that makes it more clear that this
>>> is a special permission setting.
>>
>>
>> Thanks, updated in the repo:
>>
>>    git://git.openembedded.org/openembedded-core-contrib rbt/home
>>
>> http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/home
>>
>>
>> commit ccc59f44f5fc6c6ccef6b0fed58b0d582c9ee32b
>> Author: Robert Yang <liezhi.yang@windriver.com>
>> Date:   Tue Apr 5 22:34:25 2016 -0700
>>
>>      fs-perms.txt: fix ROOT_HOME's permission
>>
>>      It should be 0700 rather than 0755.
>>
>>      Reported-by: Charles Chan <charles.wh.chan@gmail.com>
>>      Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
>>
>> diff --git a/meta/files/fs-perms.txt b/meta/files/fs-perms.txt
>> index 109cbe5..6c1083c 100644
>> --- a/meta/files/fs-perms.txt
>> +++ b/meta/files/fs-perms.txt
>> @@ -59,6 +59,7 @@ ${localstatedir}/local                0755    root    root
>> false - - -
>>   # Set 1777
>>   /tmp                           01777   root    root    false - - -
>>   ${localstatedir}/volatile/tmp  01777   root    root    false - - -
>> +${ROOT_HOME}                   0700    root    root    false - - -
>>
>
> Thanks, this is the right track, but this implies that ${ROOT_HOME}
> should be mode 1777, how about:
>
> +
> +# Set 700
> +${ROOT_HOME}                   0700    root    root    false - - -

Thanks, updated in the repo:

   git://git.openembedded.org/openembedded-core-contrib rbt/home
   http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/home


commit 5d0c64fd55edc957d8fb6340c9842bf8498a485d
Author: Robert Yang <liezhi.yang@windriver.com>
Date:   Tue Apr 5 22:34:25 2016 -0700

     fs-perms.txt: fix ROOT_HOME's permission

     It should be 0700 rather than 0755.

     Reported-by: Charles Chan <charles.wh.chan@gmail.com>
     Signed-off-by: Robert Yang <liezhi.yang@windriver.com>

diff --git a/meta/files/fs-perms.txt b/meta/files/fs-perms.txt
index 109cbe5..3d00e86 100644
--- a/meta/files/fs-perms.txt
+++ b/meta/files/fs-perms.txt
@@ -60,6 +60,9 @@ ${localstatedir}/local                0755    root    root 
false - - -
  /tmp                           01777   root    root    false - - -
  ${localstatedir}/volatile/tmp  01777   root    root    false - - -

+# Set 0700
+${ROOT_HOME}                   0700    root    root    false - - -
+
  # Set 755-lsb
  /srv                           0755    root    root    false - - -


// Robert

>
>>   # Set 755-lsb
>>   /srv                           0755    root    root    false - - -
>>
>>
>> // Robert
>>
>>
>>>
>>>
>>>>    /srv                           0755    root    root    false - - -
>>>>    ${prefix}/src                  0755    root    root    false - - -
>>>>    ${localstatedir}/local         0755    root    root    false - - -
>>>> --
>>>> 2.8.0
>>>>
>>>> --
>>>> _______________________________________________
>>>> Openembedded-core mailing list
>>>> Openembedded-core@lists.openembedded.org
>>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>>
>>>
>>
>


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH 1/1] fs-perms.txt: fix ROOT_HOME's permission
  2016-04-08  0:47         ` Robert Yang
@ 2016-04-08  3:49           ` Dan McGregor
  2016-04-14 16:23           ` Dan McGregor
  1 sibling, 0 replies; 9+ messages in thread
From: Dan McGregor @ 2016-04-08  3:49 UTC (permalink / raw)
  To: Robert Yang; +Cc: Patches and discussions about the oe-core layer

On 7 April 2016 at 18:47, Robert Yang <liezhi.yang@windriver.com> wrote:
>
>
> On 04/07/2016 11:55 PM, Dan McGregor wrote:
>>
>> On 7 April 2016 at 07:46, Robert Yang <liezhi.yang@windriver.com> wrote:
>>>
>>>
>>>
>>> On 04/07/2016 09:30 PM, Dan McGregor wrote:
>>>>
>>>>
>>>> On 7 April 2016 at 01:50, Robert Yang <liezhi.yang@windriver.com> wrote:
>>>>>
>>>>>
>>>>> It should be 0700 rather than 0755.
>>>>>
>>>>> Reported-by: Charles Chan <charles.wh.chan@gmail.com>
>>>>> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
>>>>> ---
>>>>>    meta/files/fs-perms.txt | 1 +
>>>>>    1 file changed, 1 insertion(+)
>>>>>
>>>>> diff --git a/meta/files/fs-perms.txt b/meta/files/fs-perms.txt
>>>>> index 109cbe5..1d74da7 100644
>>>>> --- a/meta/files/fs-perms.txt
>>>>> +++ b/meta/files/fs-perms.txt
>>>>> @@ -51,6 +51,7 @@ ${localstatedir}/lock link    /run/lock
>>>>>    ${localstatedir}/tmp   link    volatile/tmp
>>>>>
>>>>>    /home                          0755    root    root    false - - -
>>>>> +${ROOT_HOME}                   0700    root    root    false - - -
>>>>
>>>>
>>>>
>>>> I'd like to see this in the section labelled "Special permissions from
>>>> base-files" around line 58. I think that makes it more clear that this
>>>> is a special permission setting.
>>>
>>>
>>>
>>> Thanks, updated in the repo:
>>>
>>>    git://git.openembedded.org/openembedded-core-contrib rbt/home
>>>
>>>
>>> http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/home
>>>
>>>
>>> commit ccc59f44f5fc6c6ccef6b0fed58b0d582c9ee32b
>>> Author: Robert Yang <liezhi.yang@windriver.com>
>>> Date:   Tue Apr 5 22:34:25 2016 -0700
>>>
>>>      fs-perms.txt: fix ROOT_HOME's permission
>>>
>>>      It should be 0700 rather than 0755.
>>>
>>>      Reported-by: Charles Chan <charles.wh.chan@gmail.com>
>>>      Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
>>>
>>> diff --git a/meta/files/fs-perms.txt b/meta/files/fs-perms.txt
>>> index 109cbe5..6c1083c 100644
>>> --- a/meta/files/fs-perms.txt
>>> +++ b/meta/files/fs-perms.txt
>>> @@ -59,6 +59,7 @@ ${localstatedir}/local                0755    root
>>> root
>>> false - - -
>>>   # Set 1777
>>>   /tmp                           01777   root    root    false - - -
>>>   ${localstatedir}/volatile/tmp  01777   root    root    false - - -
>>> +${ROOT_HOME}                   0700    root    root    false - - -
>>>
>>
>> Thanks, this is the right track, but this implies that ${ROOT_HOME}
>> should be mode 1777, how about:
>>
>> +
>> +# Set 700
>> +${ROOT_HOME}                   0700    root    root    false - - -
>
>
> Thanks, updated in the repo:
>
>   git://git.openembedded.org/openembedded-core-contrib rbt/home
>
> http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/home
>
>
> commit 5d0c64fd55edc957d8fb6340c9842bf8498a485d
> Author: Robert Yang <liezhi.yang@windriver.com>
> Date:   Tue Apr 5 22:34:25 2016 -0700
>
>     fs-perms.txt: fix ROOT_HOME's permission
>
>     It should be 0700 rather than 0755.
>
>     Reported-by: Charles Chan <charles.wh.chan@gmail.com>
>     Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
>
> diff --git a/meta/files/fs-perms.txt b/meta/files/fs-perms.txt
> index 109cbe5..3d00e86 100644
> --- a/meta/files/fs-perms.txt
> +++ b/meta/files/fs-perms.txt
> @@ -60,6 +60,9 @@ ${localstatedir}/local                0755    root    root
> false - - -
>  /tmp                           01777   root    root    false - - -
>  ${localstatedir}/volatile/tmp  01777   root    root    false - - -
>
> +# Set 0700
> +${ROOT_HOME}                   0700    root    root    false - - -
> +
>
>  # Set 755-lsb
>  /srv                           0755    root    root    false - - -
>

Looks good to me.

>
> // Robert
>
>>
>>>   # Set 755-lsb
>>>   /srv                           0755    root    root    false - - -
>>>
>>>
>>> // Robert
>>>
>>>
>>>>
>>>>
>>>>>    /srv                           0755    root    root    false - - -
>>>>>    ${prefix}/src                  0755    root    root    false - - -
>>>>>    ${localstatedir}/local         0755    root    root    false - - -
>>>>> --
>>>>> 2.8.0
>>>>>
>>>>> --
>>>>> _______________________________________________
>>>>> Openembedded-core mailing list
>>>>> Openembedded-core@lists.openembedded.org
>>>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>>>
>>>>
>>>>
>>>
>>
>


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 1/1] fs-perms.txt: fix ROOT_HOME's permission
  2016-04-08  0:47         ` Robert Yang
  2016-04-08  3:49           ` Dan McGregor
@ 2016-04-14 16:23           ` Dan McGregor
  2016-04-14 16:33             ` Burton, Ross
  1 sibling, 1 reply; 9+ messages in thread
From: Dan McGregor @ 2016-04-14 16:23 UTC (permalink / raw)
  To: Robert Yang, Richard Purdie
  Cc: Patches and discussions about the oe-core layer

Richard,

I believe you merged the wrong version of this patch.

Dan

On 7 April 2016 at 18:47, Robert Yang <liezhi.yang@windriver.com> wrote:
>
>
> On 04/07/2016 11:55 PM, Dan McGregor wrote:
>>
>> On 7 April 2016 at 07:46, Robert Yang <liezhi.yang@windriver.com> wrote:
>>>
>>>
>>>
>>> On 04/07/2016 09:30 PM, Dan McGregor wrote:
>>>>
>>>>
>>>> On 7 April 2016 at 01:50, Robert Yang <liezhi.yang@windriver.com> wrote:
>>>>>
>>>>>
>>>>> It should be 0700 rather than 0755.
>>>>>
>>>>> Reported-by: Charles Chan <charles.wh.chan@gmail.com>
>>>>> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
>>>>> ---
>>>>>    meta/files/fs-perms.txt | 1 +
>>>>>    1 file changed, 1 insertion(+)
>>>>>
>>>>> diff --git a/meta/files/fs-perms.txt b/meta/files/fs-perms.txt
>>>>> index 109cbe5..1d74da7 100644
>>>>> --- a/meta/files/fs-perms.txt
>>>>> +++ b/meta/files/fs-perms.txt
>>>>> @@ -51,6 +51,7 @@ ${localstatedir}/lock link    /run/lock
>>>>>    ${localstatedir}/tmp   link    volatile/tmp
>>>>>
>>>>>    /home                          0755    root    root    false - - -
>>>>> +${ROOT_HOME}                   0700    root    root    false - - -
>>>>
>>>>
>>>>
>>>> I'd like to see this in the section labelled "Special permissions from
>>>> base-files" around line 58. I think that makes it more clear that this
>>>> is a special permission setting.
>>>
>>>
>>>
>>> Thanks, updated in the repo:
>>>
>>>    git://git.openembedded.org/openembedded-core-contrib rbt/home
>>>
>>>
>>> http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/home
>>>
>>>
>>> commit ccc59f44f5fc6c6ccef6b0fed58b0d582c9ee32b
>>> Author: Robert Yang <liezhi.yang@windriver.com>
>>> Date:   Tue Apr 5 22:34:25 2016 -0700
>>>
>>>      fs-perms.txt: fix ROOT_HOME's permission
>>>
>>>      It should be 0700 rather than 0755.
>>>
>>>      Reported-by: Charles Chan <charles.wh.chan@gmail.com>
>>>      Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
>>>
>>> diff --git a/meta/files/fs-perms.txt b/meta/files/fs-perms.txt
>>> index 109cbe5..6c1083c 100644
>>> --- a/meta/files/fs-perms.txt
>>> +++ b/meta/files/fs-perms.txt
>>> @@ -59,6 +59,7 @@ ${localstatedir}/local                0755    root
>>> root
>>> false - - -
>>>   # Set 1777
>>>   /tmp                           01777   root    root    false - - -
>>>   ${localstatedir}/volatile/tmp  01777   root    root    false - - -
>>> +${ROOT_HOME}                   0700    root    root    false - - -
>>>
>>
>> Thanks, this is the right track, but this implies that ${ROOT_HOME}
>> should be mode 1777, how about:
>>
>> +
>> +# Set 700
>> +${ROOT_HOME}                   0700    root    root    false - - -
>
>
> Thanks, updated in the repo:
>
>   git://git.openembedded.org/openembedded-core-contrib rbt/home
>
> http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/home
>
>
> commit 5d0c64fd55edc957d8fb6340c9842bf8498a485d
> Author: Robert Yang <liezhi.yang@windriver.com>
> Date:   Tue Apr 5 22:34:25 2016 -0700
>
>     fs-perms.txt: fix ROOT_HOME's permission
>
>     It should be 0700 rather than 0755.
>
>     Reported-by: Charles Chan <charles.wh.chan@gmail.com>
>     Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
>
> diff --git a/meta/files/fs-perms.txt b/meta/files/fs-perms.txt
> index 109cbe5..3d00e86 100644
> --- a/meta/files/fs-perms.txt
> +++ b/meta/files/fs-perms.txt
> @@ -60,6 +60,9 @@ ${localstatedir}/local                0755    root    root
> false - - -
>  /tmp                           01777   root    root    false - - -
>  ${localstatedir}/volatile/tmp  01777   root    root    false - - -
>
> +# Set 0700
> +${ROOT_HOME}                   0700    root    root    false - - -
> +
>
>  # Set 755-lsb
>  /srv                           0755    root    root    false - - -
>
>
> // Robert
>
>>
>>>   # Set 755-lsb
>>>   /srv                           0755    root    root    false - - -
>>>
>>>
>>> // Robert
>>>
>>>
>>>>
>>>>
>>>>>    /srv                           0755    root    root    false - - -
>>>>>    ${prefix}/src                  0755    root    root    false - - -
>>>>>    ${localstatedir}/local         0755    root    root    false - - -
>>>>> --
>>>>> 2.8.0
>>>>>
>>>>> --
>>>>> _______________________________________________
>>>>> Openembedded-core mailing list
>>>>> Openembedded-core@lists.openembedded.org
>>>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>>>
>>>>
>>>>
>>>
>>
>


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 1/1] fs-perms.txt: fix ROOT_HOME's permission
  2016-04-14 16:23           ` Dan McGregor
@ 2016-04-14 16:33             ` Burton, Ross
  0 siblings, 0 replies; 9+ messages in thread
From: Burton, Ross @ 2016-04-14 16:33 UTC (permalink / raw)
  To: Dan McGregor; +Cc: Patches and discussions about the oe-core layer

[-- Attachment #1: Type: text/plain, Size: 206 bytes --]

On 14 April 2016 at 17:23, Dan McGregor <danismostlikely@gmail.com> wrote:

> I believe you merged the wrong version of this patch.
>

I've updated mut with a revert/add of the revised patch.

Ross

[-- Attachment #2: Type: text/html, Size: 610 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2016-04-14 16:33 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-07  7:50 [PATCH 0/1] fs-perms.txt: fix ROOT_HOME's permission Robert Yang
2016-04-07  7:50 ` [PATCH 1/1] " Robert Yang
2016-04-07 13:30   ` Dan McGregor
2016-04-07 13:46     ` Robert Yang
2016-04-07 15:55       ` Dan McGregor
2016-04-08  0:47         ` Robert Yang
2016-04-08  3:49           ` Dan McGregor
2016-04-14 16:23           ` Dan McGregor
2016-04-14 16:33             ` Burton, Ross

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.