* [PATCH 0/1] grub2: fix do_configure failure when largefile is not in DISTRO_FEATURES
@ 2016-04-07 9:22 Chen Qi
2016-04-07 9:22 ` [PATCH 1/1] " Chen Qi
0 siblings, 1 reply; 6+ messages in thread
From: Chen Qi @ 2016-04-07 9:22 UTC (permalink / raw)
To: openembedded-core
The following changes since commit 5ebea1114d54120d5ff5d8a6cd148110d0fda23f:
build-appliance-image: Update to master head revision (2016-04-06 23:54:57 +0100)
are available in the git repository at:
git://git.openembedded.org/openembedded-core-contrib ChenQi/grub2-largefile
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=ChenQi/grub2-largefile
Chen Qi (1):
grub2: fix do_configure failure when largefile is not in
DISTRO_FEATURES
...-configure.ac-support-disabling-largefile.patch | 44 ++++++++++++++++++++++
meta/recipes-bsp/grub/grub2.inc | 1 +
2 files changed, 45 insertions(+)
create mode 100644 meta/recipes-bsp/grub/files/0001-configure.ac-support-disabling-largefile.patch
--
1.9.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/1] grub2: fix do_configure failure when largefile is not in DISTRO_FEATURES
2016-04-07 9:22 [PATCH 0/1] grub2: fix do_configure failure when largefile is not in DISTRO_FEATURES Chen Qi
@ 2016-04-07 9:22 ` Chen Qi
2016-04-07 10:24 ` Burton, Ross
0 siblings, 1 reply; 6+ messages in thread
From: Chen Qi @ 2016-04-07 9:22 UTC (permalink / raw)
To: openembedded-core
When 'largefile' is not in DISTRO_FEATURES, '--disable-largefile' is passed
to the configure options. However, the configure script checks the size
of off_t regardless of this option. This raises the following error.
configure: error: Large file support is required
This patch fixes the above problem.
Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
---
...-configure.ac-support-disabling-largefile.patch | 44 ++++++++++++++++++++++
meta/recipes-bsp/grub/grub2.inc | 1 +
2 files changed, 45 insertions(+)
create mode 100644 meta/recipes-bsp/grub/files/0001-configure.ac-support-disabling-largefile.patch
diff --git a/meta/recipes-bsp/grub/files/0001-configure.ac-support-disabling-largefile.patch b/meta/recipes-bsp/grub/files/0001-configure.ac-support-disabling-largefile.patch
new file mode 100644
index 0000000..e22dc00
--- /dev/null
+++ b/meta/recipes-bsp/grub/files/0001-configure.ac-support-disabling-largefile.patch
@@ -0,0 +1,44 @@
+Upstream-Status: Pending
+
+Subject: configure.ac: support disabling largefile
+
+Do not check off_t size when largefile is disabled.
+
+Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
+---
+ configure.ac | 19 ++++++++++++-------
+ 1 file changed, 12 insertions(+), 7 deletions(-)
+
+diff --git a/configure.ac b/configure.ac
+index df20991..14ff7ac 100644
+--- a/configure.ac
++++ b/configure.ac
+@@ -306,13 +306,18 @@ if test x$grub_cv_apple_cc = xyes ; then
+ HOST_LDFLAGS="$HOST_LDFLAGS -Wl,-allow_stack_execute"
+ fi
+
+-case "$host_os" in
+- cygwin | windows* | mingw32* | aros*)
+- ;;
+- *)
+- AC_CHECK_SIZEOF(off_t)
+- test x"$ac_cv_sizeof_off_t" = x8 || AC_MSG_ERROR([Large file support is required]);;
+-esac
++AC_ARG_ENABLE([largefile],
++ [AS_HELP_STRING([--enable-largefile],
++ [Enable large file support (default=guessed)])])
++if test x"$enable_largefile" = xyes ; then
++ case "$host_os" in
++ cygwin | windows* | mingw32* | aros*)
++ ;;
++ *)
++ AC_CHECK_SIZEOF(off_t)
++ test x"$ac_cv_sizeof_off_t" = x8 || AC_MSG_ERROR([Large file support is required]);;
++ esac
++fi
+
+ if test x$USE_NLS = xno; then
+ HOST_CFLAGS="$HOST_CFLAGS -fno-builtin-gettext"
+--
+1.9.1
+
diff --git a/meta/recipes-bsp/grub/grub2.inc b/meta/recipes-bsp/grub/grub2.inc
index 146dde6..6cd8d36 100644
--- a/meta/recipes-bsp/grub/grub2.inc
+++ b/meta/recipes-bsp/grub/grub2.inc
@@ -30,6 +30,7 @@ SRC_URI = "ftp://ftp.gnu.org/gnu/grub/grub-${PV}.tar.gz \
file://0001-Fix-CVE-2015-8370-Grub2-user-pass-vulnerability.patch \
file://0001-Remove-direct-_llseek-code-and-require-long-filesyst.patch \
file://fix-texinfo.patch \
+ file://0001-configure.ac-support-disabling-largefile.patch \
"
DEPENDS = "flex-native bison-native"
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] grub2: fix do_configure failure when largefile is not in DISTRO_FEATURES
2016-04-07 9:22 ` [PATCH 1/1] " Chen Qi
@ 2016-04-07 10:24 ` Burton, Ross
2016-04-08 2:00 ` ChenQi
0 siblings, 1 reply; 6+ messages in thread
From: Burton, Ross @ 2016-04-07 10:24 UTC (permalink / raw)
To: Chen Qi; +Cc: OE-core
[-- Attachment #1: Type: text/plain, Size: 220 bytes --]
On 7 April 2016 at 10:22, Chen Qi <Qi.Chen@windriver.com> wrote:
> configure: error: Large file support is required
>
Is it safe to ignore configure.ac telling you that large file support is
required?
Ross
[-- Attachment #2: Type: text/html, Size: 662 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] grub2: fix do_configure failure when largefile is not in DISTRO_FEATURES
2016-04-07 10:24 ` Burton, Ross
@ 2016-04-08 2:00 ` ChenQi
2016-04-08 2:08 ` Khem Raj
0 siblings, 1 reply; 6+ messages in thread
From: ChenQi @ 2016-04-08 2:00 UTC (permalink / raw)
To: Burton, Ross; +Cc: OE-core
[-- Attachment #1: Type: text/plain, Size: 447 bytes --]
On 04/07/2016 06:24 PM, Burton, Ross wrote:
>
> On 7 April 2016 at 10:22, Chen Qi <Qi.Chen@windriver.com
> <mailto:Qi.Chen@windriver.com>> wrote:
>
> configure: error: Large file support is required
>
>
> Is it safe to ignore configure.ac <http://configure.ac> telling you
> that large file support is required?
>
> Ross
Frankly I'm not sure about it ...
Maybe Khem has more knowledge in this area.
Best Regards,
Chen Qi
[-- Attachment #2: Type: text/html, Size: 1603 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] grub2: fix do_configure failure when largefile is not in DISTRO_FEATURES
2016-04-08 2:00 ` ChenQi
@ 2016-04-08 2:08 ` Khem Raj
2016-04-11 19:49 ` Burton, Ross
0 siblings, 1 reply; 6+ messages in thread
From: Khem Raj @ 2016-04-08 2:08 UTC (permalink / raw)
To: ChenQi; +Cc: Patches and discussions about the oe-core layer
[-- Attachment #1: Type: text/plain, Size: 611 bytes --]
On Apr 7, 2016 6:59 PM, "ChenQi" <Qi.Chen@windriver.com> wrote:
>
> On 04/07/2016 06:24 PM, Burton, Ross wrote:
>>
>>
>> On 7 April 2016 at 10:22, Chen Qi <Qi.Chen@windriver.com> wrote:
>>>
>>> configure: error: Large file support is required
>>
>>
>> Is it safe to ignore configure.ac telling you that large file support is
required?
>>
>> Ross
>
>
> Frankly I'm not sure about it ...
> Maybe Khem has more knowledge in this area.
>
We cache sizeof off_t with out considering lfs support thats the
fundamental problem. We should probably stop doing that.
> Best Regards,
> Chen Qi
[-- Attachment #2: Type: text/html, Size: 980 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] grub2: fix do_configure failure when largefile is not in DISTRO_FEATURES
2016-04-08 2:08 ` Khem Raj
@ 2016-04-11 19:49 ` Burton, Ross
0 siblings, 0 replies; 6+ messages in thread
From: Burton, Ross @ 2016-04-11 19:49 UTC (permalink / raw)
To: Khem Raj; +Cc: Patches and discussions about the oe-core layer
[-- Attachment #1: Type: text/plain, Size: 261 bytes --]
On 8 April 2016 at 03:08, Khem Raj <raj.khem@gmail.com> wrote:
> We cache sizeof off_t with out considering lfs support thats the
> fundamental problem. We should probably stop doing that.
>
>
Thanks for reminding me, patch on the list shortly.
Ross
[-- Attachment #2: Type: text/html, Size: 637 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-04-11 19:49 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-07 9:22 [PATCH 0/1] grub2: fix do_configure failure when largefile is not in DISTRO_FEATURES Chen Qi
2016-04-07 9:22 ` [PATCH 1/1] " Chen Qi
2016-04-07 10:24 ` Burton, Ross
2016-04-08 2:00 ` ChenQi
2016-04-08 2:08 ` Khem Raj
2016-04-11 19:49 ` Burton, Ross
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.