All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Lutomirski <luto@kernel.org>
To: x86@kernel.org
Cc: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
	Borislav Petkov <bp@alien8.de>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Brian Gerst <brgerst@gmail.com>,
	Matthew Whitehead <tedheadster@gmail.com>,
	Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
	Peter Zijlstra <peterz@infradead.org>,
	Andy Lutomirski <luto@kernel.org>
Subject: [PATCH v2 0/6] CPUID-less CPU/sync_core fixes and improvements
Date: Thu,  1 Dec 2016 16:34:56 -0800	[thread overview]
Message-ID: <cover.1480638597.git.luto@kernel.org> (raw)
In-Reply-To: <cover.1480536936.git.luto@kernel.org>

*** PATCHES 1 and 2 MAY BE 4.9 MATERIAL ***

Alan Cox pointed out that the 486 isn't the only supported CPU that
doesn't have CPUID.  Let's clean up the mess and make everything
faster while we're at it.

Patch 1 is intended to be an easy fix: it makes sync_core() work
without CPUID on all 32-bit kernels.  It should be quite safe.  This
will have a negligible performance cost during boot on kernels built
for newer CPUs.  With this in place, patch 2 reverts the buggy 486
check I added.

Patches 3-6 are meant to improve the situation.  Patch 3 cleans
up the Intel microcode loader and the rest (which depend on patch 3)
stops using CPUID in sync_core() altogether.

Changes from v1:
 - Fix Xen
 - Add timing info to the changelog (hint: 2x speedup)
 - Document patch 1 a bit better.

Andy Lutomirski (6):
  x86/asm/32: Make sync_core() handle missing CPUID on all 32-bit
    kernels
  Revert "x86/boot: Fail the boot if !M486 and CPUID is missing"
  x86/microcode/intel: Replace sync_core() with cpuid_eax(1)
  x86/paravirt: Make sync_core() be a paravirt op
  x86/xen: Add a Xen-specific sync_core() implementation
  x86/asm: Change sync_core() to use MOV to CR2 to serialize

 arch/x86/boot/cpu.c                   |  6 ------
 arch/x86/include/asm/paravirt.h       |  5 +++++
 arch/x86/include/asm/paravirt_types.h |  2 ++
 arch/x86/include/asm/processor.h      | 34 ++++++++++------------------------
 arch/x86/kernel/cpu/microcode/intel.c |  6 +++---
 arch/x86/kernel/paravirt.c            |  2 ++
 arch/x86/xen/enlighten.c              | 35 +++++++++++++++++++++++++++++++++++
 7 files changed, 57 insertions(+), 33 deletions(-)

-- 
2.9.3

  parent reply	other threads:[~2016-12-02  0:37 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-30 20:34 [PATCH 0/4] CPUID-less CPU fixes and improvements Andy Lutomirski
2016-11-30 20:34 ` [PATCH 1/4] x86/asm/32: Make sync_core() handle missing CPUID on all 32-bit kernels Andy Lutomirski
2016-11-30 20:34 ` [PATCH 2/4] Revert "x86/boot: Fail the boot if !M486 and CPUID is missing" Andy Lutomirski
2016-12-01  5:53   ` Peter Zijlstra
2016-12-01  9:02     ` Borislav Petkov
2016-12-01 10:07       ` Thomas Gleixner
2016-12-01 11:15         ` [PATCH] x86/CPU: Add X86_FEATURE_CPUID Borislav Petkov
2016-12-01 17:00           ` Andy Lutomirski
2016-12-02  0:33       ` [PATCH 2/4] Revert "x86/boot: Fail the boot if !M486 and CPUID is missing" Andy Lutomirski
2016-12-01 17:00     ` Andy Lutomirski
2016-11-30 20:34 ` [PATCH 3/4] x86/microcode/intel: Replace sync_core() with cpuid_eax(1) Andy Lutomirski
2016-12-01  9:11   ` Borislav Petkov
2016-11-30 20:34 ` [PATCH 4/4] x86/asm: Change sync_core() to use MOV to CR2 to serialize Andy Lutomirski
2016-12-01  9:22   ` Borislav Petkov
2016-12-01 17:08     ` Andy Lutomirski
2016-12-01 17:46       ` Andrew Cooper
2016-12-02  7:34     ` Ingo Molnar
2016-12-02  0:34 ` Andy Lutomirski [this message]
2016-12-02  0:34   ` [PATCH v2 1/6] x86/asm/32: Make sync_core() handle missing CPUID on all 32-bit kernels Andy Lutomirski
2016-12-02  0:34   ` [PATCH v2 2/6] Revert "x86/boot: Fail the boot if !M486 and CPUID is missing" Andy Lutomirski
2016-12-02  0:34   ` [PATCH v2 3/6] x86/microcode/intel: Replace sync_core() with cpuid_eax(1) Andy Lutomirski
2016-12-02  0:35   ` [PATCH v2 4/6] x86/paravirt: Make sync_core() be a paravirt op Andy Lutomirski
2016-12-02  0:35   ` [PATCH v2 5/6] x86/xen: Add a Xen-specific sync_core() implementation Andy Lutomirski
2016-12-02 11:44     ` Andrew Cooper
2016-12-02 11:44     ` Andrew Cooper
2016-12-02 17:07       ` Andy Lutomirski
2016-12-02 17:07       ` Andy Lutomirski
2016-12-02 17:16         ` Andrew Cooper
2016-12-02 17:16         ` Andrew Cooper
2016-12-02 17:23           ` Andy Lutomirski
2016-12-02 17:26             ` Andrew Cooper
2016-12-02 17:26             ` Andrew Cooper
2016-12-02 17:23           ` Andy Lutomirski
2016-12-02 18:50       ` Boris Ostrovsky
2016-12-02 18:50       ` Boris Ostrovsky
2016-12-02 19:34         ` Andy Lutomirski
2016-12-02 19:34         ` Andy Lutomirski
2016-12-02 20:09       ` Boris Ostrovsky
2016-12-02 20:09         ` Boris Ostrovsky
2016-12-02 17:32     ` Linus Torvalds
2016-12-02 17:38       ` Andy Lutomirski
2016-12-02 17:53         ` Linus Torvalds
2016-12-02 18:03         ` Borislav Petkov
2016-12-02 18:27           ` Linus Torvalds
2016-12-02 18:50             ` Borislav Petkov
2016-12-02 19:03               ` Linus Torvalds
2016-12-02 19:20                 ` Borislav Petkov
2016-12-02 19:24                   ` Linus Torvalds
2016-12-02 19:28                     ` Borislav Petkov
2016-12-03 15:02                       ` [PATCH] x86/alternatives: Do not use sync_core() to serialize I$ Borislav Petkov
2016-12-03 17:05                         ` Andy Lutomirski
2016-12-20  7:58                         ` [tip:x86/urgent] " tip-bot for Borislav Petkov
2016-12-20  9:35                         ` tip-bot for Borislav Petkov
2016-12-02 19:30                     ` [PATCH v2 5/6] x86/xen: Add a Xen-specific sync_core() implementation Andy Lutomirski
2016-12-02 19:35                       ` Linus Torvalds
2016-12-02 20:41                         ` Andy Lutomirski
2016-12-02 21:10                           ` Linus Torvalds
2016-12-02 22:55                             ` Andy Lutomirski
2016-12-02 23:09                               ` Linus Torvalds
2016-12-02 19:23                 ` Andy Lutomirski
2016-12-02 19:30                   ` Borislav Petkov
2016-12-03 12:44         ` Borislav Petkov
2016-12-02  0:35   ` [PATCH v2 6/6] x86/asm: Change sync_core() to use MOV to CR2 to serialize Andy Lutomirski
2016-12-02  0:36 ` [PATCH 0/4] CPUID-less CPU fixes and improvements Andy Lutomirski
2016-12-02 10:17   ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1480638597.git.luto@kernel.org \
    --to=luto@kernel.org \
    --cc=bp@alien8.de \
    --cc=brgerst@gmail.com \
    --cc=gnomes@lxorguk.ukuu.org.uk \
    --cc=hmh@hmh.eng.br \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=tedheadster@gmail.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.