[Buildroot] [PATCH 0/7 v4] support/test-pkg: fixes and enhancements

[Buildroot] [PATCH 0/7 v4] support/test-pkg: fixes and enhancements

[Yann E. MORIN]

Hello All!

This series brins a few fixes and improvements to the test-pkg script.

First, it fixes the cioding style, to be more in-line with what is used
in Buildroot.

Changes v2 -> v3:
  - drop patches already applied
  - simplify the config check  (Cam)
  - be less verbose  (Thomas)
  - fix coding style  (Thomas)

Changes v2 -> v3:
  - simplify the code to store missing config lines  (Luca)
  - properly run when -r is not provided
  - add 5th path to use an alternate list
  - add 6th patch to print the progress [n/N] for each toolchain


Regards,
Yann E. MORIN.


The following changes since commit 8ac3f121f0ccc31a79b08c473e19e4d4ae922942

  wiringpi: fix static linking (2017-02-12 15:03:02 +0100)


are available in the git repository at:

  git://git.buildroot.org/~ymorin/git/buildroot.git

for you to fetch changes up to 05e8a8e4a66b175edcd8f6250c583051f77eeae9

  support/test-pkg: print number of toolchain and progress (2017-02-12 15:18:08 +0100)


----------------------------------------------------------------
Yann E. MORIN (7):
      supprt/test-pkg: fix code style
      support/scripts: check the config snippet exists
      support/test-pkg: simplify the config check
      support/test-pkg: be less verbose
      support/test-pkg: report number and types of failures
      support/test-pkg: add option to use an alternate list of toolchains
      support/test-pkg: print number of toolchain and progress

 support/scripts/test-pkg | 125 ++++++++++++++++++++++++++++++-----------------
 1 file changed, 81 insertions(+), 44 deletions(-)

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH 1/7 v4] supprt/test-pkg: fix code style

[Yann E. MORIN]

Reported-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
 support/scripts/test-pkg | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/support/scripts/test-pkg b/support/scripts/test-pkg
index b867da8..9066fa0 100755
--- a/support/scripts/test-pkg
+++ b/support/scripts/test-pkg
@@ -10,7 +10,7 @@ main() {
 
     o='hc:d:p:r:'
     O='help,config-snippet:build-dir:package:,random:'
-    opts="$( getopt -n "${my_name}" -o "${o}" -l "${O}" -- "${@}"  )"
+    opts="$(getopt -n "${my_name}" -o "${o}" -l "${O}" -- "${@}")"
     eval set -- "${opts}"
 
     random=0
@@ -46,14 +46,14 @@ main() {
     # Extract the URLs of the toolchains; drop internal toolchains
     # E.g.: http://server/path/to/name.config,arch,libc
     #  -->  http://server/path/to/name.config
-    toolchains=( $( curl -s "${TOOLCHAINS_URL}" \
-                    |sed -r -e 's/,.*//; /internal/d;' \
-                    |if [ ${random} -gt 0 ]; then \
-                        sort -R |head -n ${random}
-                     else
-                        cat
-                     fi |sort
-                  )
+    toolchains=($(curl -s "${TOOLCHAINS_URL}" \
+                  |sed -r -e 's/,.*//; /internal/d;' \
+                  |if [ ${random} -gt 0 ]; then \
+                      sort -R |head -n ${random}
+                   else
+                      cat
+                   fi |sort
+                 )
                )
 
     if [ ${#toolchains[@]} -eq 0 ]; then
@@ -73,7 +73,7 @@ build_one() {
     local toolchain line skip
 
     # Using basename(1) on a URL works nicely
-    toolchain="$( basename "${url}" .config )"
+    toolchain="$(basename "${url}" .config)"
 
     printf "%40s: " "${toolchain}"
 
-- 
2.7.4

[Buildroot] [PATCH 1/7 v4] supprt/test-pkg: fix code style

[Thomas Petazzoni]

Hello,

On Sun, 12 Feb 2017 15:53:05 +0100, Yann E. MORIN wrote:
> Reported-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> ---
>  support/scripts/test-pkg | 20 ++++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)

Applied to master after fixing the typo in the commit title. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 2/7 v4] support/scripts: check the config snippet exists

[Yann E. MORIN]

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
 support/scripts/test-pkg | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/support/scripts/test-pkg b/support/scripts/test-pkg
index 9066fa0..11ec18c 100755
--- a/support/scripts/test-pkg
+++ b/support/scripts/test-pkg
@@ -39,6 +39,9 @@ main() {
     if [ -z "${cfg}" ]; then
         printf "error: no config snippet specified\n" >&2; exit 1
     fi
+    if [ ! -e "${cfg}" ]; then
+        printf "error: %s: no such file\n" "${cfg}" >&2; exit 1
+    fi
     if [ -z "${dir}" ]; then
         dir="${HOME}/br-test-pkg"
     fi
-- 
2.7.4

[Buildroot] [PATCH 2/7 v4] support/scripts: check the config snippet exists

[Thomas Petazzoni]

Hello,

On Sun, 12 Feb 2017 15:53:06 +0100, Yann E. MORIN wrote:
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> ---
>  support/scripts/test-pkg | 3 +++
>  1 file changed, 3 insertions(+)

Applied to master, after adjusting the commit title to
support/test-pkg, in order to be consistent with other patches in the
series.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 3/7 v4] support/test-pkg: simplify the config check

[Yann E. MORIN]

Use comm(1) to check that all our config options are properly set in the
resulting configuration, rather than our canned and fragile code.

Reported-by: Cam Hutchison <camh@xdna.net>
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
 support/scripts/test-pkg | 14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)

diff --git a/support/scripts/test-pkg b/support/scripts/test-pkg
index 11ec18c..a1d272a 100755
--- a/support/scripts/test-pkg
+++ b/support/scripts/test-pkg
@@ -73,7 +73,7 @@ build_one() {
     local url="${2}"
     local cfg="${3}"
     local pkg="${4}"
-    local toolchain line skip
+    local toolchain
 
     # Using basename(1) on a URL works nicely
     toolchain="$(basename "${url}" .config)"
@@ -106,14 +106,10 @@ build_one() {
     # or not set) in the actual .config; if one of them is not, it means
     # some dependency from the toolchain or arch is not available, in
     # which case this config is untestable and we skip it.
-    skip=false
-    while read line; do
-        if ! grep "^${line}\$" "${dir}/.config" >/dev/null 2>&1; then
-            printf "%s\n" "${line}"
-            skip=true
-        fi
-    done <"${cfg}" >"${dir}/missing.config"
-    if ${skip}; then
+    # We don't care about the locale to sort in, as long as both sort are
+    # done in the same locale.
+    comm -23 <(sort "${cfg}") <(sort "${dir}/.config") >"${dir}/missing.config"
+    if [ -s "${dir}/missing.config" ]; then
         printf ", SKIPPED\n"
         return
     fi
-- 
2.7.4

[Buildroot] [PATCH 3/7 v4] support/test-pkg: simplify the config check

[Thomas Petazzoni]

Hello,

On Sun, 12 Feb 2017 15:53:07 +0100, Yann E. MORIN wrote:
> Use comm(1) to check that all our config options are properly set in the
> resulting configuration, rather than our canned and fragile code.
> 
> Reported-by: Cam Hutchison <camh@xdna.net>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> ---
>  support/scripts/test-pkg | 14 +++++---------
>  1 file changed, 5 insertions(+), 9 deletions(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 4/7 v4] support/test-pkg: be less verbose

[Yann E. MORIN]

Requested-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
 support/scripts/test-pkg | 16 ++++++----------
 1 file changed, 6 insertions(+), 10 deletions(-)

diff --git a/support/scripts/test-pkg b/support/scripts/test-pkg
index a1d272a..d9ae5c5 100755
--- a/support/scripts/test-pkg
+++ b/support/scripts/test-pkg
@@ -83,9 +83,8 @@ build_one() {
     dir="${dir}/${toolchain}"
     mkdir -p "${dir}"
 
-    printf "download config"
     if ! curl -s "${url}" >"${dir}/.config"; then
-        printf ": FAILED\n"
+        printf "FAILED\n"
         return
     fi
 
@@ -97,9 +96,8 @@ build_one() {
 	_EOF_
     cat "${cfg}" >>"${dir}/.config"
 
-    printf ", olddefconfig"
     if ! make O="${dir}" olddefconfig >/dev/null 2>&1; then
-        printf ": FAILED\n"
+        printf "FAILED\n"
         return
     fi
     # We want all the options from the snippet to be present as-is (set
@@ -110,28 +108,26 @@ build_one() {
     # done in the same locale.
     comm -23 <(sort "${cfg}") <(sort "${dir}/.config") >"${dir}/missing.config"
     if [ -s "${dir}/missing.config" ]; then
-        printf ", SKIPPED\n"
+        printf "SKIPPED\n"
         return
     fi
     # Remove file, it's empty anyway.
     rm -f "${dir}/missing.config"
 
     if [ -n "${pkg}" ]; then
-        printf ", dirclean"
         if ! make O="${dir}" "${pkg}-dirclean" >> "${dir}/logfile" 2>&1; then
-            printf ": FAILED\n"
+            printf "FAILED\n"
             return
         fi
     fi
 
-    printf ", build"
     # shellcheck disable=SC2086
     if ! make O="${dir}" ${pkg} >> "${dir}/logfile" 2>&1; then
-        printf ": FAILED\n"
+        printf "FAILED\n"
         return
     fi
 
-    printf ": OK\n"
+    printf "OK\n"
 }
 
 help() {
-- 
2.7.4

[Buildroot] [PATCH 4/7 v4] support/test-pkg: be less verbose

[Thomas Petazzoni]

Hello,

On Sun, 12 Feb 2017 15:53:08 +0100, Yann E. MORIN wrote:
> Requested-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> ---
>  support/scripts/test-pkg | 16 ++++++----------
>  1 file changed, 6 insertions(+), 10 deletions(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 5/7 v4] support/test-pkg: report number and types of failures

[Yann E. MORIN]

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Luca Ceresoli <luca@lucaceresoli.net>
Cc: Thomas De Schampheleire <patrickdepinguin@gmail.com>
---
 support/scripts/test-pkg | 24 ++++++++++++++++++------
 1 file changed, 18 insertions(+), 6 deletions(-)

diff --git a/support/scripts/test-pkg b/support/scripts/test-pkg
index d9ae5c5..a040ce1 100755
--- a/support/scripts/test-pkg
+++ b/support/scripts/test-pkg
@@ -6,6 +6,7 @@ TOOLCHAINS_URL='http://autobuild.buildroot.org/toolchains/configs/toolchain-conf
 main() {
     local o O opts
     local cfg dir pkg random toolchain
+    local ret nb nb_skip nb_fail
     local -a toolchains
 
     o='hc:d:p:r:'
@@ -63,9 +64,20 @@ main() {
         printf "error: no toolchain found (networking issue?)\n" >&2; exit 1
     fi
 
+    nb=0
+    nb_skip=0
+    nb_fail=0
     for toolchain in "${toolchains[@]}"; do
-        build_one "${dir}" "${toolchain}" "${cfg}" "${pkg}"
+        build_one "${dir}" "${toolchain}" "${cfg}" "${pkg}" && ret=0 || ret=${?}
+        case ${ret} in
+        (0) ;;
+        (1) : $((nb_skip++));;
+        (2) : $((nb_fail++));;
+        esac
+        : $((nb++))
     done
+
+    printf "%d builds, %d skipped, %d failed\n" ${nb} ${nb_skip} ${nb_fail}
 }
 
 build_one() {
@@ -85,7 +97,7 @@ build_one() {
 
     if ! curl -s "${url}" >"${dir}/.config"; then
         printf "FAILED\n"
-        return
+        return 2
     fi
 
     cat >>"${dir}/.config" <<-_EOF_
@@ -98,7 +110,7 @@ build_one() {
 
     if ! make O="${dir}" olddefconfig >/dev/null 2>&1; then
         printf "FAILED\n"
-        return
+        return 2
     fi
     # We want all the options from the snippet to be present as-is (set
     # or not set) in the actual .config; if one of them is not, it means
@@ -109,7 +121,7 @@ build_one() {
     comm -23 <(sort "${cfg}") <(sort "${dir}/.config") >"${dir}/missing.config"
     if [ -s "${dir}/missing.config" ]; then
         printf "SKIPPED\n"
-        return
+        return 1
     fi
     # Remove file, it's empty anyway.
     rm -f "${dir}/missing.config"
@@ -117,14 +129,14 @@ build_one() {
     if [ -n "${pkg}" ]; then
         if ! make O="${dir}" "${pkg}-dirclean" >> "${dir}/logfile" 2>&1; then
             printf "FAILED\n"
-            return
+            return 2
         fi
     fi
 
     # shellcheck disable=SC2086
     if ! make O="${dir}" ${pkg} >> "${dir}/logfile" 2>&1; then
         printf "FAILED\n"
-        return
+        return 2
     fi
 
     printf "OK\n"
-- 
2.7.4

[Buildroot] [PATCH 5/7 v4] support/test-pkg: report number and types of failures

[Thomas Petazzoni]

Hello,

On Sun, 12 Feb 2017 15:53:09 +0100, Yann E. MORIN wrote:
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: Luca Ceresoli <luca@lucaceresoli.net>
> Cc: Thomas De Schampheleire <patrickdepinguin@gmail.com>
> ---
>  support/scripts/test-pkg | 24 ++++++++++++++++++------
>  1 file changed, 18 insertions(+), 6 deletions(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 6/7 v4] support/test-pkg: add option to use an alternate list of toolchains

[Yann E. MORIN]

For now, testing a package requires network access. However, there are
situations where everything is already cached locally (especially the
toolchains tarballs) and network is not available (e.g. in the train,
travelling back from FOSDEM...)

Alternatively, one may also want to test against a subset of the default
toolchains (e.g. the ones known to have a specific issue).

Add an option to use an alternate URL, which can be remote or a path to
a local file.

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
 support/scripts/test-pkg | 47 +++++++++++++++++++++++++++++++++++++++++------
 1 file changed, 41 insertions(+), 6 deletions(-)

diff --git a/support/scripts/test-pkg b/support/scripts/test-pkg
index a040ce1..9626c1a 100755
--- a/support/scripts/test-pkg
+++ b/support/scripts/test-pkg
@@ -5,16 +5,17 @@ TOOLCHAINS_URL='http://autobuild.buildroot.org/toolchains/configs/toolchain-conf
 
 main() {
     local o O opts
-    local cfg dir pkg random toolchain
+    local cfg dir pkg random url toolchain
     local ret nb nb_skip nb_fail
     local -a toolchains
 
-    o='hc:d:p:r:'
-    O='help,config-snippet:build-dir:package:,random:'
+    o='hc:d:p:r:t:'
+    O='help,config-snippet:build-dir:package:,random:,toolchains:'
     opts="$(getopt -n "${my_name}" -o "${o}" -l "${O}" -- "${@}")"
     eval set -- "${opts}"
 
     random=0
+    url="${TOOLCHAINS_URL}"
     while [ ${#} -gt 0 ]; do
         case "${1}" in
         (-h|--help)
@@ -32,6 +33,9 @@ main() {
         (-r|--random)
             random="${2}"; shift 2
             ;;
+        (-t|--toolchains)
+            url="${2}"; shift 2
+            ;;
         (--)
             shift; break
             ;;
@@ -47,10 +51,16 @@ main() {
         dir="${HOME}/br-test-pkg"
     fi
 
+    # Transform local paths to URI to make curl happy and simplify
+    # our code path
+    case "${url}" in
+    (/*)    url="file://${url}";;
+    esac
+
     # Extract the URLs of the toolchains; drop internal toolchains
     # E.g.: http://server/path/to/name.config,arch,libc
     #  -->  http://server/path/to/name.config
-    toolchains=($(curl -s "${TOOLCHAINS_URL}" \
+    toolchains=($(curl -s "${url}" \
                   |sed -r -e 's/,.*//; /internal/d;' \
                   |if [ ${random} -gt 0 ]; then \
                       sort -R |head -n ${random}
@@ -87,6 +97,12 @@ build_one() {
     local pkg="${4}"
     local toolchain
 
+    # Transform local paths to URI to make curl happy and simplify
+    # our code path
+    case "${url}" in
+    (/*)    url="file://${url}";;
+    esac
+
     # Using basename(1) on a URL works nicely
     toolchain="$(basename "${url}" .config)"
 
@@ -156,8 +172,22 @@ In case failures are noticed, you can fix the package and just re-run the
 same command again; it will re-run the test where it failed. If you did
 specify a package (with -p), the package build dir will be removed first.
 
-The list of toolchains is retrieved from the Buildroot autobuilders, available
-at ${TOOLCHAINS_URL}.
+Unless specified with -t, the list of toolchains is retrieved from the
+Buildroot autobuilders, available at:
+    ${TOOLCHAINS_URL}
+
+The list of toolchains should contain the URLs to all toolchains, one per
+line, along with the architecture and C library used, separated by commas,
+"URL,ARCH,LIBC" (only the first field, URL, is used by this script). For
+example:
+
+    https://server/path/to/toolchain-1.config,arm,glibc
+    /path/to/local-toolchain.config,i386,musl
+
+The URL for each toolchain should point to a .config file that contains
+only the toolchain and architecture settings. URLs that contain the string
+'internal' are skipped, on the assumption that the configuration would
+build an internal toolchain (which takes a lot of time).
 
 Options:
 
@@ -179,6 +209,11 @@ Options:
         Limit the tests to the N randomly selected toolchains, instead of
         building with all toolchains.
 
+    -t URL, --toolchains URL
+        Use the toolchains described at URL instead of the toolchains used
+        by the Buildroot autobuilders (see above). URL can be a path to a
+        local file.
+
 Example:
 
     Testing libcec would require a config snippet that contains:
-- 
2.7.4

[Buildroot] [PATCH 7/7 v4] support/test-pkg: print number of toolchain and progress

[Yann E. MORIN]

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Thomas De Schampheleire <patrickdepinguin@gmail.com>
---
 support/scripts/test-pkg | 25 ++++++++++---------------
 1 file changed, 10 insertions(+), 15 deletions(-)

diff --git a/support/scripts/test-pkg b/support/scripts/test-pkg
index 9626c1a..8d47415 100755
--- a/support/scripts/test-pkg
+++ b/support/scripts/test-pkg
@@ -6,7 +6,7 @@ TOOLCHAINS_URL='http://autobuild.buildroot.org/toolchains/configs/toolchain-conf
 main() {
     local o O opts
     local cfg dir pkg random url toolchain
-    local ret nb nb_skip nb_fail
+    local ret nb nb_skip nb_fail nb_tc
     local -a toolchains
 
     o='hc:d:p:r:t:'
@@ -70,21 +70,25 @@ main() {
                  )
                )
 
-    if [ ${#toolchains[@]} -eq 0 ]; then
+    nb_tc="${#toolchains[@]}"
+    if [ ${nb_tc} -eq 0 ]; then
         printf "error: no toolchain found (networking issue?)\n" >&2; exit 1
     fi
+    printf "Found %d toolchains\n" ${nb_tc}
 
     nb=0
     nb_skip=0
     nb_fail=0
     for toolchain in "${toolchains[@]}"; do
+        : $((nb++))
+        printf "%40s [%*d/%d]: " "$(basename "${toolchain}" .config)" \
+                                 ${#nb_tc} ${nb} ${nb_tc}
         build_one "${dir}" "${toolchain}" "${cfg}" "${pkg}" && ret=0 || ret=${?}
         case ${ret} in
-        (0) ;;
-        (1) : $((nb_skip++));;
-        (2) : $((nb_fail++));;
+        (0) printf "OK\n";;
+        (1) : $((nb_skip++)); printf "SKIPPED\n";;
+        (2) : $((nb_fail++)); printf "FAILED\n";;
         esac
-        : $((nb++))
     done
 
     printf "%d builds, %d skipped, %d failed\n" ${nb} ${nb_skip} ${nb_fail}
@@ -106,13 +110,10 @@ build_one() {
     # Using basename(1) on a URL works nicely
     toolchain="$(basename "${url}" .config)"
 
-    printf "%40s: " "${toolchain}"
-
     dir="${dir}/${toolchain}"
     mkdir -p "${dir}"
 
     if ! curl -s "${url}" >"${dir}/.config"; then
-        printf "FAILED\n"
         return 2
     fi
 
@@ -125,7 +126,6 @@ build_one() {
     cat "${cfg}" >>"${dir}/.config"
 
     if ! make O="${dir}" olddefconfig >/dev/null 2>&1; then
-        printf "FAILED\n"
         return 2
     fi
     # We want all the options from the snippet to be present as-is (set
@@ -136,7 +136,6 @@ build_one() {
     # done in the same locale.
     comm -23 <(sort "${cfg}") <(sort "${dir}/.config") >"${dir}/missing.config"
     if [ -s "${dir}/missing.config" ]; then
-        printf "SKIPPED\n"
         return 1
     fi
     # Remove file, it's empty anyway.
@@ -144,18 +143,14 @@ build_one() {
 
     if [ -n "${pkg}" ]; then
         if ! make O="${dir}" "${pkg}-dirclean" >> "${dir}/logfile" 2>&1; then
-            printf "FAILED\n"
             return 2
         fi
     fi
 
     # shellcheck disable=SC2086
     if ! make O="${dir}" ${pkg} >> "${dir}/logfile" 2>&1; then
-        printf "FAILED\n"
         return 2
     fi
-
-    printf "OK\n"
 }
 
 help() {
-- 
2.7.4

[Buildroot] [PATCH 0/7 v4] support/test-pkg: fixes and enhancements

[Yann E. MORIN]

Hello All!

This series brings a few fixes and improvements to the test-pkg script.

Changes v3 -> v4:
  - drop patches already applied
  - run legal-info as well  (Romain, Thomas)
  - add anentry in the manual  (Thomas)
  - misc cleanups in 3 new patches

Changes v2 -> v3:
  - drop patches already applied
  - simplify the config check  (Cam)
  - be less verbose  (Thomas)
  - fix coding style  (Thomas)

Changes v2 -> v3:
  - simplify the code to store missing config lines  (Luca)
  - properly run when -r is not provided
  - add 5th path to use an alternate list
  - add 6th patch to print the progress [n/N] for each toolchain


Regards,
Yann E. MORIN.


The following changes since commit 8ae3dce5275915a1784b00bf145af907827fed0d

  postgresql: disable spinlocks on openrisc (2017-02-15 22:34:44 +0100)


are available in the git repository at:

  git://git.buildroot.org/~ymorin/git/buildroot.git

for you to fetch changes up to 58d4b1a3fa0de47c84ee8bc281d3b89edfe5b40c

  support/test-pkg: run legal-info (2017-02-15 22:37:30 +0100)


----------------------------------------------------------------
Yann E. MORIN (7):
      docs/manual: document the test-pkg script
      support/test-pkg: add option to use an alternate list of toolchains
      support/test-pkg: print number of toolchain and progress
      support/test-pkg: the list of toolchains really contains URLs
      support/test-pkg: cannonicalize paths early
      support/test-pkg: create build dir from caller
      support/test-pkg: run legal-info

 docs/manual/adding-packages-tips.txt |  91 +++++++++++++++++++++++++++++++
 support/scripts/test-pkg             | 101 +++++++++++++++++++++++------------
 2 files changed, 159 insertions(+), 33 deletions(-)

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH 0/7 v4] support/test-pkg: fixes and enhancements

[Arnout Vandecappelle]

On 15-02-17 22:44, Yann E. MORIN wrote:
> Hello All!
> 
> This series brings a few fixes and improvements to the test-pkg script.

 I was going to modify test-pkg to use the toolchains from configs/toolchains,
but then I noticed this series was still not committed. It obviously conflicts
heavily with what I'm going to do, so I'm taking this over, OK?

[snip]

> ----------------------------------------------------------------
> Yann E. MORIN (7):
>       docs/manual: document the test-pkg script

 I'll include Thomas's feedback, plus some more fixes from me.

>       support/test-pkg: add option to use an alternate list of toolchains

 I'll drop this, since we're not going to get toolchains from a URL anymore. IMO
the same feature can easily be achieved by having a directory with toolchain
configs inside the tree (or inside an external tree).

>       support/test-pkg: print number of toolchain and progress
>       support/test-pkg: the list of toolchains really contains URLs

 With the toolchain URLs gone, this is not true anymore.

>       support/test-pkg: cannonicalize paths early

 With the toolchain URLs gone, this is not relevant anymore.

>       support/test-pkg: create build dir from caller

 Took me a while to figure out what this patch was doing, so I'll reword the
commit message.


 Regards,
 Arnout

>       support/test-pkg: run legal-info
> 
>  docs/manual/adding-packages-tips.txt |  91 +++++++++++++++++++++++++++++++
>  support/scripts/test-pkg             | 101 +++++++++++++++++++++++------------
>  2 files changed, 159 insertions(+), 33 deletions(-)
> 

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

[Buildroot] [PATCH 0/7 v4] support/test-pkg: fixes and enhancements

[Yann E. MORIN]

Arnout,

On 2017-04-05 16:37 +0200, Arnout Vandecappelle spake thusly:
> On 15-02-17 22:44, Yann E. MORIN wrote:
> > Hello All!
> > 
> > This series brings a few fixes and improvements to the test-pkg script.
> 
>  I was going to modify test-pkg to use the toolchains from configs/toolchains,
> but then I noticed this series was still not committed. It obviously conflicts
> heavily with what I'm going to do, so I'm taking this over, OK?

As you wish.

The latest version (which I did not yet post, did I?) is available, as
usual, on my git tree:

    git://git.busybox.net/~ymorin/git/buildroot   yem/test-pkg

> > ----------------------------------------------------------------
> > Yann E. MORIN (7):
> >       docs/manual: document the test-pkg script
> 
>  I'll include Thomas's feedback, plus some more fixes from me.

I think I already addresses Thomas' comments in the latest version.

Regards,
Yann E. MORIN.

> >       support/test-pkg: add option to use an alternate list of toolchains
> 
>  I'll drop this, since we're not going to get toolchains from a URL anymore. IMO
> the same feature can easily be achieved by having a directory with toolchain
> configs inside the tree (or inside an external tree).

Well, as long as I can specify a list of toolchains, that is not the
default, that's fine. If I just have to do a wget to have a local file,
I'm OK with that.

But I *want* to be able to use a custom list of toolchains.

> >       support/test-pkg: print number of toolchain and progress
> >       support/test-pkg: the list of toolchains really contains URLs
> 
>  With the toolchain URLs gone, this is not true anymore.

Well, I am not sure what you meant: we can't have a list of remote
config files to use anymore? That is sad... :-(

> >       support/test-pkg: cannonicalize paths early
> 
>  With the toolchain URLs gone, this is not relevant anymore.
> 
> >       support/test-pkg: create build dir from caller
> 
>  Took me a while to figure out what this patch was doing, so I'll reword the
> commit message.

Ah yes, sorry, the commit log is a bit terse... :-/

Please note that there is another patch on the series now:

    support/test-pkg: run legal-info

    https://git.buildroot.org/~ymorin/git/buildroot/commit/?h=yem/test-pkg&id=8a9fec1b939caad8ad282a94e6049c748eff5336

Regards,
Yann E. MORIN.

> 
>  Regards,
>  Arnout
> 
> >       support/test-pkg: run legal-info
> > 
> >  docs/manual/adding-packages-tips.txt |  91 +++++++++++++++++++++++++++++++
> >  support/scripts/test-pkg             | 101 +++++++++++++++++++++++------------
> >  2 files changed, 159 insertions(+), 33 deletions(-)
> > 
> 
> -- 
> Arnout Vandecappelle                          arnout at mind be
> Senior Embedded Software Architect            +32-16-286500
> Essensium/Mind                                http://www.mind.be
> G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
> LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
> GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH 0/7 v4] support/test-pkg: fixes and enhancements

[Arnout Vandecappelle]

On 05-04-17 21:16, Yann E. MORIN wrote:
> Arnout,
> 
> On 2017-04-05 16:37 +0200, Arnout Vandecappelle spake thusly:
>> On 15-02-17 22:44, Yann E. MORIN wrote:
>>> Hello All!
>>>
>>> This series brings a few fixes and improvements to the test-pkg script.
>>
>>  I was going to modify test-pkg to use the toolchains from configs/toolchains,
>> but then I noticed this series was still not committed. It obviously conflicts
>> heavily with what I'm going to do, so I'm taking this over, OK?
> 
> As you wish.
> 
> The latest version (which I did not yet post, did I?) is available, as
> usual, on my git tree:
> 
>     git://git.busybox.net/~ymorin/git/buildroot   yem/test-pkg

 Argh, I should have checked for that before starting my work... Your commits
don't have a version log, do you have any idea if anything changed except for
the first patch?

> 
>>> ----------------------------------------------------------------
>>> Yann E. MORIN (7):
>>>       docs/manual: document the test-pkg script
>>
>>  I'll include Thomas's feedback, plus some more fixes from me.
> 
> I think I already addresses Thomas' comments in the latest version.
> 
> Regards,
> Yann E. MORIN.
> 
>>>       support/test-pkg: add option to use an alternate list of toolchains
>>
>>  I'll drop this, since we're not going to get toolchains from a URL anymore. IMO
>> the same feature can easily be achieved by having a directory with toolchain
>> configs inside the tree (or inside an external tree).
> 
> Well, as long as I can specify a list of toolchains, that is not the
> default, that's fine. If I just have to do a wget to have a local file,
> I'm OK with that.
> 
> But I *want* to be able to use a custom list of toolchains.

 You don't need to get it from a URL, do you? I think having the list of
toolchains passed as a BR2_EXTERNAL is much more appropriate. Basically, I now have

TOOLCHAINS_PATH=configs/toolchains

which points to a directory containing toolchain configs. I can add an option
that allows you to override that directory. I don't see much point in getting
this from a URL, is there?

> 
>>>       support/test-pkg: print number of toolchain and progress
>>>       support/test-pkg: the list of toolchains really contains URLs
>>
>>  With the toolchain URLs gone, this is not true anymore.
> 
> Well, I am not sure what you meant: we can't have a list of remote
> config files to use anymore? That is sad... :-(

 Can you explain your use case for a list of *remote* config files?

> 
>>>       support/test-pkg: cannonicalize paths early
>>
>>  With the toolchain URLs gone, this is not relevant anymore.
>>
>>>       support/test-pkg: create build dir from caller
>>
>>  Took me a while to figure out what this patch was doing, so I'll reword the
>> commit message.
> 
> Ah yes, sorry, the commit log is a bit terse... :-/
> 
> Please note that there is another patch on the series now:
> 
>     support/test-pkg: run legal-info

 It was already there (see below).


 Regards,
 Arnout

> 
>     https://git.buildroot.org/~ymorin/git/buildroot/commit/?h=yem/test-pkg&id=8a9fec1b939caad8ad282a94e6049c748eff5336
> 
> Regards,
> Yann E. MORIN.
> 
>>
>>  Regards,
>>  Arnout
>>
>>>       support/test-pkg: run legal-info
>>>
>>>  docs/manual/adding-packages-tips.txt |  91 +++++++++++++++++++++++++++++++
>>>  support/scripts/test-pkg             | 101 +++++++++++++++++++++++------------
>>>  2 files changed, 159 insertions(+), 33 deletions(-)
>>>
>>
>> -- 
>> Arnout Vandecappelle                          arnout at mind be
>> Senior Embedded Software Architect            +32-16-286500
>> Essensium/Mind                                http://www.mind.be
>> G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
>> LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
>> GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
> 

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

[Buildroot] [PATCH 0/7 v4] support/test-pkg: fixes and enhancements

[Yann E. MORIN]

Arnout, All,

On 2017-04-06 10:48 +0200, Arnout Vandecappelle spake thusly:
> On 05-04-17 21:16, Yann E. MORIN wrote:
> > On 2017-04-05 16:37 +0200, Arnout Vandecappelle spake thusly:
> >>  I was going to modify test-pkg to use the toolchains from configs/toolchains,
> >> but then I noticed this series was still not committed. It obviously conflicts
> >> heavily with what I'm going to do, so I'm taking this over, OK?
> > The latest version (which I did not yet post, did I?) is available, as
> > usual, on my git tree:
> >     git://git.busybox.net/~ymorin/git/buildroot   yem/test-pkg
>  Argh, I should have checked for that before starting my work... Your commits
> don't have a version log, do you have any idea if anything changed except for
> the first patch?

Given that the first patch does have a changelog, but the others do not,
I guess nothing of great interest... :-/

> > Well, as long as I can specify a list of toolchains, that is not the
> > default, that's fine. If I just have to do a wget to have a local file,
> > I'm OK with that.
> > 
> > But I *want* to be able to use a custom list of toolchains.
> 
>  You don't need to get it from a URL, do you? I think having the list of
> toolchains passed as a BR2_EXTERNAL is much more appropriate. Basically, I now have
> 
> TOOLCHAINS_PATH=configs/toolchains

Please, make that an option to the script, not an environment variable!

    --toolchains-dir=/path/to/configs/toolchains

> which points to a directory containing toolchain configs. I can add an option
> that allows you to override that directory. I don't see much point in getting
> this from a URL, is there?

Well, if I can use a custom list of toolchians, I'm fine. Now, that I
need to pre-populate that directory by myself is acceptable. If I need
to store the toolchain configs remotely, it now behooves to me to
download them fiurst and feed local files to the script. That's OK.

> >>>       support/test-pkg: print number of toolchain and progress
> >>>       support/test-pkg: the list of toolchains really contains URLs
> >>  With the toolchain URLs gone, this is not true anymore.
> > Well, I am not sure what you meant: we can't have a list of remote
> > config files to use anymore? That is sad... :-(
>  Can you explain your use case for a list of *remote* config files?

It's just that my "tool_s_" are stored in their own repositor_ies_...

Regards,
Yann E. MORIN.

> > Please note that there is another patch on the series now:
> >     support/test-pkg: run legal-info
>  It was already there (see below).

/me rubs his eyes...
Ah, right...

Regards,
Yann E. MORIN.

>  Regards,
>  Arnout
> 
> > 
> >     https://git.buildroot.org/~ymorin/git/buildroot/commit/?h=yem/test-pkg&id=8a9fec1b939caad8ad282a94e6049c748eff5336
> > 
> > Regards,
> > Yann E. MORIN.
> > 
> >>
> >>  Regards,
> >>  Arnout
> >>
> >>>       support/test-pkg: run legal-info
> >>>
> >>>  docs/manual/adding-packages-tips.txt |  91 +++++++++++++++++++++++++++++++
> >>>  support/scripts/test-pkg             | 101 +++++++++++++++++++++++------------
> >>>  2 files changed, 159 insertions(+), 33 deletions(-)
> >>>
> >>
> >> -- 
> >> Arnout Vandecappelle                          arnout at mind be
> >> Senior Embedded Software Architect            +32-16-286500
> >> Essensium/Mind                                http://www.mind.be
> >> G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
> >> LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
> >> GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
> > 
> 
> -- 
> Arnout Vandecappelle                          arnout at mind be
> Senior Embedded Software Architect            +32-16-286500
> Essensium/Mind                                http://www.mind.be
> G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
> LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
> GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH 0/7 v4] support/test-pkg: fixes and enhancements

[Arnout Vandecappelle]

On 06-04-17 17:55, Yann E. MORIN wrote:
> Arnout, All,
> 
> On 2017-04-06 10:48 +0200, Arnout Vandecappelle spake thusly:
>> On 05-04-17 21:16, Yann E. MORIN wrote:
[snip]
>>> Well, as long as I can specify a list of toolchains, that is not the
>>> default, that's fine. If I just have to do a wget to have a local file,
>>> I'm OK with that.
>>>
>>> But I *want* to be able to use a custom list of toolchains.
>>
>>  You don't need to get it from a URL, do you? I think having the list of
>> toolchains passed as a BR2_EXTERNAL is much more appropriate. Basically, I now have
>>
>> TOOLCHAINS_PATH=configs/toolchains
> 
> Please, make that an option to the script, not an environment variable!

 That's what I wanted to do, of course.

> 
>     --toolchains-dir=/path/to/configs/toolchains

 Thanks for the naming tip, I would have chosen something much more stupid.

> 
>> which points to a directory containing toolchain configs. I can add an option
>> that allows you to override that directory. I don't see much point in getting
>> this from a URL, is there?
> 
> Well, if I can use a custom list of toolchians, I'm fine. Now, that I
> need to pre-populate that directory by myself is acceptable. If I need
> to store the toolchain configs remotely, it now behooves to me to
> download them fiurst and feed local files to the script. That's OK.

 Yeah, and you can also make a link farm if needed.

> 
>>>>>       support/test-pkg: print number of toolchain and progress
>>>>>       support/test-pkg: the list of toolchains really contains URLs
>>>>  With the toolchain URLs gone, this is not true anymore.
>>> Well, I am not sure what you meant: we can't have a list of remote
>>> config files to use anymore? That is sad... :-(
>>  Can you explain your use case for a list of *remote* config files?
> 
> It's just that my "tool_s_" are stored in their own repositor_ies_...

 But do those repositories contain toolchain.config files? They would typically
contain the config file for building the toolchain, not for using it as an
external toolchain, right?

 Some extra extensions that would be nice:

- specifying a shell glob pattern to match the toolchain;

- once we have a tool that can calculate the custom external toolchain
arguments: specify a list of toolchain tarball URLs and download derive the
toolchain_defconfig from there.


 Regards,
 Arnout

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF