From: Jose Abreu <Jose.Abreu@synopsys.com>
To: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Cc: "Jose Abreu" <Jose.Abreu@synopsys.com>,
"Carlos Palminha" <CARLOS.PALMINHA@synopsys.com>,
"Alexey Brodkin" <Alexey.Brodkin@synopsys.com>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
"Dave Airlie" <airlied@linux.ie>
Subject: [PATCH 0/2] Introduce crtc->mode_valid() callback
Date: Wed, 26 Apr 2017 11:48:33 +0100 [thread overview]
Message-ID: <cover.1493203049.git.joabreu@synopsys.com> (raw)
This patchset introduces a new callback for crtc, called mode_valid()
that is responsible to limit the number of probbed modes. Just like
connector->mode_valid(), this new callback is called at mode probbing
stage so that we can validate the mode.
This is specially useful because arcpgu crtc is responsible to set a
clock value in the commit() stage but unfortunatelly this clock does
not support all the needed ranges. This way we can restrict the number
of modes that are handed to userspace, so that we dont hand a mode
that will fail the commit() stage.
I guess this can also happen for other drivers so we introduce the
callback in the core.
The behaviour remains the same for crtcs that don't have the callback.
Also, for a given set of crtcs that can be bound to the connector, if
at least one can display the mode then the mode will be probbed.
For more info about why this is needed in arcpgu, please refer here [1].
[1] https://patchwork.kernel.org/patch/9694177/
Jose Abreu (2):
drm: Introduce crtc->mode_valid() callback
drm: arcpgu: Use crtc->mode_valid() callback
Cc: Carlos Palminha <palminha@synopsys.com>
Cc: Alexey Brodkin <abrodkin@synopsys.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Dave Airlie <airlied@linux.ie>
drivers/gpu/drm/arc/arcpgu_crtc.c | 14 ++++++++++
drivers/gpu/drm/drm_probe_helper.c | 44 ++++++++++++++++++++++++++++++++
include/drm/drm_modeset_helper_vtables.h | 26 +++++++++++++++++++
3 files changed, 84 insertions(+)
--
1.9.1
next reply other threads:[~2017-04-26 10:49 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-26 10:48 Jose Abreu [this message]
2017-04-26 10:48 ` [PATCH 1/2] drm: Introduce crtc->mode_valid() callback Jose Abreu
2017-04-27 10:05 ` Andrzej Hajda
2017-04-27 10:05 ` Andrzej Hajda
2017-04-27 12:34 ` Jose Abreu
2017-04-27 12:34 ` Jose Abreu
2017-04-28 11:41 ` Ville Syrjälä
2017-04-28 11:41 ` Ville Syrjälä
2017-04-28 12:30 ` Jose Abreu
2017-04-28 12:30 ` Jose Abreu
2017-04-28 12:58 ` Ville Syrjälä
2017-04-28 12:58 ` Ville Syrjälä
2017-05-02 8:48 ` Daniel Vetter
2017-05-02 8:48 ` Daniel Vetter
2017-05-02 9:29 ` Jose Abreu
2017-05-03 6:19 ` Daniel Vetter
2017-05-03 6:19 ` Daniel Vetter
2017-05-03 6:19 ` Daniel Vetter
2017-05-03 6:19 ` Daniel Vetter
2017-05-03 14:16 ` Jose Abreu
2017-05-03 15:00 ` Daniel Vetter
2017-05-03 15:00 ` Daniel Vetter
2017-05-03 15:21 ` Ville Syrjälä
2017-05-03 15:21 ` Ville Syrjälä
2017-05-04 12:49 ` Daniel Vetter
2017-05-04 12:49 ` Daniel Vetter
2017-05-04 13:08 ` Ville Syrjälä
2017-05-04 13:08 ` Ville Syrjälä
2017-05-04 10:21 ` Jose Abreu
2017-05-04 11:55 ` Jose Abreu
2017-05-04 12:48 ` Daniel Vetter
2017-05-04 12:48 ` Daniel Vetter
2017-04-26 10:48 ` [PATCH 2/2] drm: arcpgu: Use " Jose Abreu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1493203049.git.joabreu@synopsys.com \
--to=jose.abreu@synopsys.com \
--cc=Alexey.Brodkin@synopsys.com \
--cc=CARLOS.PALMINHA@synopsys.com \
--cc=airlied@linux.ie \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.