All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: Jose Abreu <Jose.Abreu@synopsys.com>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Carlos Palminha <CARLOS.PALMINHA@synopsys.com>,
	Alexey Brodkin <Alexey.Brodkin@synopsys.com>,
	Dave Airlie <airlied@linux.ie>
Subject: Re: [PATCH 1/2] drm: Introduce crtc->mode_valid() callback
Date: Thu, 4 May 2017 14:49:31 +0200	[thread overview]
Message-ID: <CAKMK7uFy3MMGusPtS=Jd1W9+_h8Do2+dnN5S3m9SjUF_=0E-=w@mail.gmail.com> (raw)
In-Reply-To: <20170503152129.GO12629@intel.com>

On Wed, May 3, 2017 at 5:21 PM, Ville Syrjälä
<ville.syrjala@linux.intel.com> wrote:
> We don't actually want the codepaths to match exactly. In i915
> we allow the user to exceed some of the display/dongle limits
> because those things often tell us that something shouldn't work
> when in fact it does. And some users are quick to complain if
> something stops working for them.

The goal here is to share the source-side checking
(crtc/encoder/bridges), and that should match perfectly between probe
and commit. Sink-side constraints are different, and for those we
should indeed not check everything. Maybe a good reason to only call
connector->mode_valid in the probe paths?
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel@ffwll.ch>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: Jose Abreu <Jose.Abreu@synopsys.com>,
	Alexey Brodkin <Alexey.Brodkin@synopsys.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	Carlos Palminha <CARLOS.PALMINHA@synopsys.com>
Subject: Re: [PATCH 1/2] drm: Introduce crtc->mode_valid() callback
Date: Thu, 4 May 2017 14:49:31 +0200	[thread overview]
Message-ID: <CAKMK7uFy3MMGusPtS=Jd1W9+_h8Do2+dnN5S3m9SjUF_=0E-=w@mail.gmail.com> (raw)
In-Reply-To: <20170503152129.GO12629@intel.com>

On Wed, May 3, 2017 at 5:21 PM, Ville Syrjälä
<ville.syrjala@linux.intel.com> wrote:
> We don't actually want the codepaths to match exactly. In i915
> we allow the user to exceed some of the display/dongle limits
> because those things often tell us that something shouldn't work
> when in fact it does. And some users are quick to complain if
> something stops working for them.

The goal here is to share the source-side checking
(crtc/encoder/bridges), and that should match perfectly between probe
and commit. Sink-side constraints are different, and for those we
should indeed not check everything. Maybe a good reason to only call
connector->mode_valid in the probe paths?
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2017-05-04 12:49 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-26 10:48 [PATCH 0/2] Introduce crtc->mode_valid() callback Jose Abreu
2017-04-26 10:48 ` [PATCH 1/2] drm: " Jose Abreu
2017-04-27 10:05   ` Andrzej Hajda
2017-04-27 10:05     ` Andrzej Hajda
2017-04-27 12:34     ` Jose Abreu
2017-04-27 12:34       ` Jose Abreu
2017-04-28 11:41   ` Ville Syrjälä
2017-04-28 11:41     ` Ville Syrjälä
2017-04-28 12:30     ` Jose Abreu
2017-04-28 12:30       ` Jose Abreu
2017-04-28 12:58       ` Ville Syrjälä
2017-04-28 12:58         ` Ville Syrjälä
2017-05-02  8:48   ` Daniel Vetter
2017-05-02  8:48     ` Daniel Vetter
2017-05-02  9:29     ` Jose Abreu
2017-05-03  6:19       ` Daniel Vetter
2017-05-03  6:19         ` Daniel Vetter
2017-05-03  6:19       ` Daniel Vetter
2017-05-03  6:19         ` Daniel Vetter
2017-05-03 14:16         ` Jose Abreu
2017-05-03 15:00           ` Daniel Vetter
2017-05-03 15:00             ` Daniel Vetter
2017-05-03 15:21             ` Ville Syrjälä
2017-05-03 15:21               ` Ville Syrjälä
2017-05-04 12:49               ` Daniel Vetter [this message]
2017-05-04 12:49                 ` Daniel Vetter
2017-05-04 13:08                 ` Ville Syrjälä
2017-05-04 13:08                   ` Ville Syrjälä
2017-05-04 10:21             ` Jose Abreu
2017-05-04 11:55               ` Jose Abreu
2017-05-04 12:48                 ` Daniel Vetter
2017-05-04 12:48                   ` Daniel Vetter
2017-04-26 10:48 ` [PATCH 2/2] drm: arcpgu: Use " Jose Abreu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKMK7uFy3MMGusPtS=Jd1W9+_h8Do2+dnN5S3m9SjUF_=0E-=w@mail.gmail.com' \
    --to=daniel@ffwll.ch \
    --cc=Alexey.Brodkin@synopsys.com \
    --cc=CARLOS.PALMINHA@synopsys.com \
    --cc=Jose.Abreu@synopsys.com \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.