* [PATCH v2 0/2] mfd: intel_quark_i2c_gpio: Refactor and support for IOT2000
@ 2017-05-22 10:53 Jan Kiszka
2017-05-22 10:53 ` [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency Jan Kiszka
` (3 more replies)
0 siblings, 4 replies; 18+ messages in thread
From: Jan Kiszka @ 2017-05-22 10:53 UTC (permalink / raw)
To: Lee Jones; +Cc: Linux Kernel Mailing List, Andy Shevchenko, Sascha Weisenberger
Changes in v2:
- refactor DMI matching first
Jan
Jan Kiszka (2):
mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving
frequency
mfd: intel_quark_i2c_gpio: Add support for SIMATIC IOT2000 platform
drivers/mfd/intel_quark_i2c_gpio.c | 49 ++++++++++++++++++++++----------------
1 file changed, 29 insertions(+), 20 deletions(-)
--
2.12.0
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency
2017-05-22 10:53 [PATCH v2 0/2] mfd: intel_quark_i2c_gpio: Refactor and support for IOT2000 Jan Kiszka
@ 2017-05-22 10:53 ` Jan Kiszka
2017-05-22 17:12 ` Andy Shevchenko
2017-05-22 10:53 ` [PATCH v2 2/2] mfd: intel_quark_i2c_gpio: Add support for SIMATIC IOT2000 platform Jan Kiszka
` (2 subsequent siblings)
3 siblings, 1 reply; 18+ messages in thread
From: Jan Kiszka @ 2017-05-22 10:53 UTC (permalink / raw)
To: Lee Jones; +Cc: Linux Kernel Mailing List, Andy Shevchenko, Sascha Weisenberger
Avoids reimplementation of DMI matching in intel_quark_i2c_setup.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
drivers/mfd/intel_quark_i2c_gpio.c | 33 +++++++++++++--------------------
1 file changed, 13 insertions(+), 20 deletions(-)
diff --git a/drivers/mfd/intel_quark_i2c_gpio.c b/drivers/mfd/intel_quark_i2c_gpio.c
index 7946d6e38b87..050061320377 100644
--- a/drivers/mfd/intel_quark_i2c_gpio.c
+++ b/drivers/mfd/intel_quark_i2c_gpio.c
@@ -58,19 +58,18 @@ struct intel_quark_mfd {
struct clk_lookup *i2c_clk_lookup;
};
-struct i2c_mode_info {
- const char *name;
- unsigned int i2c_scl_freq;
-};
-
-static const struct i2c_mode_info platform_i2c_mode_info[] = {
+static const struct dmi_system_id dmi_platform_info[] = {
{
- .name = "Galileo",
- .i2c_scl_freq = 100000,
+ .matches = {
+ DMI_EXACT_MATCH(DMI_BOARD_NAME, "Galileo"),
+ },
+ .driver_data = (void *)100000,
},
{
- .name = "GalileoGen2",
- .i2c_scl_freq = 400000,
+ .matches = {
+ DMI_EXACT_MATCH(DMI_BOARD_NAME, "GalileoGen2"),
+ },
+ .driver_data = (void *)400000,
},
{}
};
@@ -160,8 +159,7 @@ static void intel_quark_unregister_i2c_clk(struct device *dev)
static int intel_quark_i2c_setup(struct pci_dev *pdev, struct mfd_cell *cell)
{
- const char *board_name = dmi_get_system_info(DMI_BOARD_NAME);
- const struct i2c_mode_info *info;
+ const struct dmi_system_id *dmi_id;
struct dw_i2c_platform_data *pdata;
struct resource *res = (struct resource *)cell->resources;
struct device *dev = &pdev->dev;
@@ -181,14 +179,9 @@ static int intel_quark_i2c_setup(struct pci_dev *pdev, struct mfd_cell *cell)
/* Normal mode by default */
pdata->i2c_scl_freq = 100000;
- if (board_name) {
- for (info = platform_i2c_mode_info; info->name; info++) {
- if (!strcmp(board_name, info->name)) {
- pdata->i2c_scl_freq = info->i2c_scl_freq;
- break;
- }
- }
- }
+ dmi_id = dmi_first_match(dmi_platform_info);
+ if (dmi_id)
+ pdata->i2c_scl_freq = (uintptr_t)dmi_id->driver_data;
cell->platform_data = pdata;
cell->pdata_size = sizeof(*pdata);
--
2.12.0
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH v2 2/2] mfd: intel_quark_i2c_gpio: Add support for SIMATIC IOT2000 platform
2017-05-22 10:53 [PATCH v2 0/2] mfd: intel_quark_i2c_gpio: Refactor and support for IOT2000 Jan Kiszka
2017-05-22 10:53 ` [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency Jan Kiszka
@ 2017-05-22 10:53 ` Jan Kiszka
2017-05-23 15:02 ` [PATCH v2 0/2] mfd: intel_quark_i2c_gpio: Refactor and support for IOT2000 Andy Shevchenko
2017-05-30 8:13 ` Lee Jones
3 siblings, 0 replies; 18+ messages in thread
From: Jan Kiszka @ 2017-05-22 10:53 UTC (permalink / raw)
To: Lee Jones; +Cc: Linux Kernel Mailing List, Andy Shevchenko, Sascha Weisenberger
The SIMATIC IOT2020 and IOT2040 are derived from the Galileo Gen2 board
and share its I2C frequency.
Signed-off-by: Sascha Weisenberger <sascha.weisenberger@siemens.com>
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
drivers/mfd/intel_quark_i2c_gpio.c | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/drivers/mfd/intel_quark_i2c_gpio.c b/drivers/mfd/intel_quark_i2c_gpio.c
index 050061320377..90e35dec8648 100644
--- a/drivers/mfd/intel_quark_i2c_gpio.c
+++ b/drivers/mfd/intel_quark_i2c_gpio.c
@@ -71,6 +71,22 @@ static const struct dmi_system_id dmi_platform_info[] = {
},
.driver_data = (void *)400000,
},
+ {
+ .matches = {
+ DMI_EXACT_MATCH(DMI_BOARD_NAME, "SIMATIC IOT2000"),
+ DMI_EXACT_MATCH(DMI_BOARD_ASSET_TAG,
+ "6ES7647-0AA00-0YA2"),
+ },
+ .driver_data = (void *)400000,
+ },
+ {
+ .matches = {
+ DMI_EXACT_MATCH(DMI_BOARD_NAME, "SIMATIC IOT2000"),
+ DMI_EXACT_MATCH(DMI_BOARD_ASSET_TAG,
+ "6ES7647-0AA00-1YA2"),
+ },
+ .driver_data = (void *)400000,
+ },
{}
};
--
2.12.0
^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency
2017-05-22 10:53 ` [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency Jan Kiszka
@ 2017-05-22 17:12 ` Andy Shevchenko
2017-05-22 17:18 ` Jan Kiszka
0 siblings, 1 reply; 18+ messages in thread
From: Andy Shevchenko @ 2017-05-22 17:12 UTC (permalink / raw)
To: Jan Kiszka; +Cc: Lee Jones, Linux Kernel Mailing List, Sascha Weisenberger
On Mon, May 22, 2017 at 1:53 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
> Avoids reimplementation of DMI matching in intel_quark_i2c_setup.
What's wrong with current approach? I suppose this will make sense
when we will have an issue / impediment. Right now it looks like
over-engineering.
(Yes, I know what I said to you about this earlier, OTOH see above)
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency
2017-05-22 17:12 ` Andy Shevchenko
@ 2017-05-22 17:18 ` Jan Kiszka
2017-05-22 17:20 ` Andy Shevchenko
0 siblings, 1 reply; 18+ messages in thread
From: Jan Kiszka @ 2017-05-22 17:18 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: Lee Jones, Linux Kernel Mailing List, Sascha Weisenberger
On 2017-05-22 19:12, Andy Shevchenko wrote:
> On Mon, May 22, 2017 at 1:53 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>> Avoids reimplementation of DMI matching in intel_quark_i2c_setup.
>
> What's wrong with current approach? I suppose this will make sense
> when we will have an issue / impediment. Right now it looks like
> over-engineering.
>
> (Yes, I know what I said to you about this earlier, OTOH see above)
>
It allows matching on additional DMI tags without additional code -
patch 2 depends on it.
Jan
--
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Corporate Competence Center Embedded Linux
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency
2017-05-22 17:18 ` Jan Kiszka
@ 2017-05-22 17:20 ` Andy Shevchenko
2017-05-22 17:25 ` Jan Kiszka
0 siblings, 1 reply; 18+ messages in thread
From: Andy Shevchenko @ 2017-05-22 17:20 UTC (permalink / raw)
To: Jan Kiszka; +Cc: Lee Jones, Linux Kernel Mailing List, Sascha Weisenberger
On Mon, May 22, 2017 at 8:18 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
> On 2017-05-22 19:12, Andy Shevchenko wrote:
>> On Mon, May 22, 2017 at 1:53 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>>> Avoids reimplementation of DMI matching in intel_quark_i2c_setup.
>>
>> What's wrong with current approach? I suppose this will make sense
>> when we will have an issue / impediment. Right now it looks like
>> over-engineering.
>>
>> (Yes, I know what I said to you about this earlier, OTOH see above)
>>
>
> It allows matching on additional DMI tags without additional code -
> patch 2 depends on it.
And since there is no difference to the frequency the name is enough.
So, I wouldn't go with this series as is. See above.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency
2017-05-22 17:20 ` Andy Shevchenko
@ 2017-05-22 17:25 ` Jan Kiszka
2017-05-22 17:26 ` Andy Shevchenko
0 siblings, 1 reply; 18+ messages in thread
From: Jan Kiszka @ 2017-05-22 17:25 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: Lee Jones, Linux Kernel Mailing List, Sascha Weisenberger
On 2017-05-22 19:20, Andy Shevchenko wrote:
> On Mon, May 22, 2017 at 8:18 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>> On 2017-05-22 19:12, Andy Shevchenko wrote:
>>> On Mon, May 22, 2017 at 1:53 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>>>> Avoids reimplementation of DMI matching in intel_quark_i2c_setup.
>>>
>>> What's wrong with current approach? I suppose this will make sense
>>> when we will have an issue / impediment. Right now it looks like
>>> over-engineering.
>>>
>>> (Yes, I know what I said to you about this earlier, OTOH see above)
>>>
>>
>> It allows matching on additional DMI tags without additional code -
>> patch 2 depends on it.
>
> And since there is no difference to the frequency the name is enough.
> So, I wouldn't go with this series as is. See above.
Nope: Just like for the stmmac, we need to include the asset tags to
avoid matching variations of the devices which may carry the same board
name. While I will try to avoid that this happens, we are better safe
than sorry here.
Jan
--
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Corporate Competence Center Embedded Linux
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency
2017-05-22 17:25 ` Jan Kiszka
@ 2017-05-22 17:26 ` Andy Shevchenko
2017-05-22 17:34 ` Jan Kiszka
0 siblings, 1 reply; 18+ messages in thread
From: Andy Shevchenko @ 2017-05-22 17:26 UTC (permalink / raw)
To: Jan Kiszka; +Cc: Lee Jones, Linux Kernel Mailing List, Sascha Weisenberger
On Mon, May 22, 2017 at 8:25 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
> On 2017-05-22 19:20, Andy Shevchenko wrote:
>> On Mon, May 22, 2017 at 8:18 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>>> On 2017-05-22 19:12, Andy Shevchenko wrote:
>>>> On Mon, May 22, 2017 at 1:53 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>>>>> Avoids reimplementation of DMI matching in intel_quark_i2c_setup.
>>>>
>>>> What's wrong with current approach? I suppose this will make sense
>>>> when we will have an issue / impediment. Right now it looks like
>>>> over-engineering.
>>>>
>>>> (Yes, I know what I said to you about this earlier, OTOH see above)
>>>>
>>>
>>> It allows matching on additional DMI tags without additional code -
>>> patch 2 depends on it.
>>
>> And since there is no difference to the frequency the name is enough.
>> So, I wouldn't go with this series as is. See above.
>
> Nope: Just like for the stmmac, we need to include the asset tags to
> avoid matching variations of the devices which may carry the same board
> name. While I will try to avoid that this happens, we are better safe
> than sorry here.
Do we have an issue right now?
Yes / No
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency
2017-05-22 17:26 ` Andy Shevchenko
@ 2017-05-22 17:34 ` Jan Kiszka
2017-05-22 17:36 ` Andy Shevchenko
0 siblings, 1 reply; 18+ messages in thread
From: Jan Kiszka @ 2017-05-22 17:34 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: Lee Jones, Linux Kernel Mailing List, Sascha Weisenberger
On 2017-05-22 19:26, Andy Shevchenko wrote:
> On Mon, May 22, 2017 at 8:25 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>> On 2017-05-22 19:20, Andy Shevchenko wrote:
>>> On Mon, May 22, 2017 at 8:18 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>>>> On 2017-05-22 19:12, Andy Shevchenko wrote:
>>>>> On Mon, May 22, 2017 at 1:53 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>>>>>> Avoids reimplementation of DMI matching in intel_quark_i2c_setup.
>>>>>
>>>>> What's wrong with current approach? I suppose this will make sense
>>>>> when we will have an issue / impediment. Right now it looks like
>>>>> over-engineering.
>>>>>
>>>>> (Yes, I know what I said to you about this earlier, OTOH see above)
>>>>>
>>>>
>>>> It allows matching on additional DMI tags without additional code -
>>>> patch 2 depends on it.
>>>
>>> And since there is no difference to the frequency the name is enough.
>>> So, I wouldn't go with this series as is. See above.
>>
>> Nope: Just like for the stmmac, we need to include the asset tags to
>> avoid matching variations of the devices which may carry the same board
>> name. While I will try to avoid that this happens, we are better safe
>> than sorry here.
>
> Do we have an issue right now?
> Yes / No
Andy, we are trying to design a robust upstream driver here, no ad-hoc
BSP that will not survive the hardware anyway.
Jan
--
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Corporate Competence Center Embedded Linux
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency
2017-05-22 17:34 ` Jan Kiszka
@ 2017-05-22 17:36 ` Andy Shevchenko
2017-05-22 17:38 ` Jan Kiszka
0 siblings, 1 reply; 18+ messages in thread
From: Andy Shevchenko @ 2017-05-22 17:36 UTC (permalink / raw)
To: Jan Kiszka; +Cc: Lee Jones, Linux Kernel Mailing List, Sascha Weisenberger
On Mon, May 22, 2017 at 8:34 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
> On 2017-05-22 19:26, Andy Shevchenko wrote:
>> On Mon, May 22, 2017 at 8:25 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>>> On 2017-05-22 19:20, Andy Shevchenko wrote:
>>>> On Mon, May 22, 2017 at 8:18 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>>>>> On 2017-05-22 19:12, Andy Shevchenko wrote:
>>>>>> On Mon, May 22, 2017 at 1:53 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>>>> And since there is no difference to the frequency the name is enough.
>>>> So, I wouldn't go with this series as is. See above.
>>>
>>> Nope: Just like for the stmmac, we need to include the asset tags to
>>> avoid matching variations of the devices which may carry the same board
>>> name. While I will try to avoid that this happens, we are better safe
>>> than sorry here.
>>
>> Do we have an issue right now?
>> Yes / No
>
> Andy, we are trying to design a robust upstream driver here, no ad-hoc
> BSP that will not survive the hardware anyway.
You didn't answer my question...
I do not see a good point to solve the issue that might happen in the future.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency
2017-05-22 17:36 ` Andy Shevchenko
@ 2017-05-22 17:38 ` Jan Kiszka
2017-05-22 17:42 ` Andy Shevchenko
0 siblings, 1 reply; 18+ messages in thread
From: Jan Kiszka @ 2017-05-22 17:38 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: Lee Jones, Linux Kernel Mailing List, Sascha Weisenberger
On 2017-05-22 19:36, Andy Shevchenko wrote:
> On Mon, May 22, 2017 at 8:34 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>> On 2017-05-22 19:26, Andy Shevchenko wrote:
>>> On Mon, May 22, 2017 at 8:25 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>>>> On 2017-05-22 19:20, Andy Shevchenko wrote:
>>>>> On Mon, May 22, 2017 at 8:18 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>>>>>> On 2017-05-22 19:12, Andy Shevchenko wrote:
>>>>>>> On Mon, May 22, 2017 at 1:53 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>
>>>>> And since there is no difference to the frequency the name is enough.
>>>>> So, I wouldn't go with this series as is. See above.
>>>>
>>>> Nope: Just like for the stmmac, we need to include the asset tags to
>>>> avoid matching variations of the devices which may carry the same board
>>>> name. While I will try to avoid that this happens, we are better safe
>>>> than sorry here.
>>>
>>> Do we have an issue right now?
>>> Yes / No
>>
>> Andy, we are trying to design a robust upstream driver here, no ad-hoc
>> BSP that will not survive the hardware anyway.
>
> You didn't answer my question...
>
> I do not see a good point to solve the issue that might happen in the future.
>
While I do - that's why your question is misleading.
Then let's leave the decision up to the maintainer.
Jan
--
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Corporate Competence Center Embedded Linux
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency
2017-05-22 17:38 ` Jan Kiszka
@ 2017-05-22 17:42 ` Andy Shevchenko
2017-05-22 18:23 ` Lee Jones
0 siblings, 1 reply; 18+ messages in thread
From: Andy Shevchenko @ 2017-05-22 17:42 UTC (permalink / raw)
To: Jan Kiszka; +Cc: Lee Jones, Linux Kernel Mailing List, Sascha Weisenberger
On Mon, May 22, 2017 at 8:38 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
> On 2017-05-22 19:36, Andy Shevchenko wrote:
>> On Mon, May 22, 2017 at 8:34 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>>> On 2017-05-22 19:26, Andy Shevchenko wrote:
>>>> On Mon, May 22, 2017 at 8:25 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>>>>> On 2017-05-22 19:20, Andy Shevchenko wrote:
>>>>>> On Mon, May 22, 2017 at 8:18 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>>>>>>> On 2017-05-22 19:12, Andy Shevchenko wrote:
>>>>>>>> On Mon, May 22, 2017 at 1:53 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>>>>>> And since there is no difference to the frequency the name is enough.
>>>>>> So, I wouldn't go with this series as is. See above.
>>>>>
>>>>> Nope: Just like for the stmmac, we need to include the asset tags to
>>>>> avoid matching variations of the devices which may carry the same board
>>>>> name. While I will try to avoid that this happens, we are better safe
>>>>> than sorry here.
>>>>
>>>> Do we have an issue right now?
>>>> Yes / No
>>>
>>> Andy, we are trying to design a robust upstream driver here, no ad-hoc
>>> BSP that will not survive the hardware anyway.
>>
>> You didn't answer my question...
>>
>> I do not see a good point to solve the issue that might happen in the future.
>>
>
> While I do - that's why your question is misleading.
>
> Then let's leave the decision up to the maintainer.
Lee, just for your convenience I'm repeating myself here:
I do not like this series at all since it tries to solve non-existing
issue in over-engineering way.
If you on opposite side I will be happy to help reviewing it.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency
2017-05-22 17:42 ` Andy Shevchenko
@ 2017-05-22 18:23 ` Lee Jones
2017-05-22 18:37 ` Andy Shevchenko
0 siblings, 1 reply; 18+ messages in thread
From: Lee Jones @ 2017-05-22 18:23 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Jan Kiszka, Linux Kernel Mailing List, Sascha Weisenberger
On Mon, 22 May 2017, Andy Shevchenko wrote:
> On Mon, May 22, 2017 at 8:38 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
> > On 2017-05-22 19:36, Andy Shevchenko wrote:
> >> On Mon, May 22, 2017 at 8:34 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
> >>> On 2017-05-22 19:26, Andy Shevchenko wrote:
> >>>> On Mon, May 22, 2017 at 8:25 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
> >>>>> On 2017-05-22 19:20, Andy Shevchenko wrote:
> >>>>>> On Mon, May 22, 2017 at 8:18 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
> >>>>>>> On 2017-05-22 19:12, Andy Shevchenko wrote:
> >>>>>>>> On Mon, May 22, 2017 at 1:53 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>
> >>>>>> And since there is no difference to the frequency the name is enough.
> >>>>>> So, I wouldn't go with this series as is. See above.
> >>>>>
> >>>>> Nope: Just like for the stmmac, we need to include the asset tags to
> >>>>> avoid matching variations of the devices which may carry the same board
> >>>>> name. While I will try to avoid that this happens, we are better safe
> >>>>> than sorry here.
> >>>>
> >>>> Do we have an issue right now?
> >>>> Yes / No
> >>>
> >>> Andy, we are trying to design a robust upstream driver here, no ad-hoc
> >>> BSP that will not survive the hardware anyway.
> >>
> >> You didn't answer my question...
> >>
> >> I do not see a good point to solve the issue that might happen in the future.
> >>
> >
> > While I do - that's why your question is misleading.
> >
> > Then let's leave the decision up to the maintainer.
>
> Lee, just for your convenience I'm repeating myself here:
>
> I do not like this series at all since it tries to solve non-existing
> issue in over-engineering way.
>
> If you on opposite side I will be happy to help reviewing it.
New code looks cleaner and appears to use an already defined API.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency
2017-05-22 18:23 ` Lee Jones
@ 2017-05-22 18:37 ` Andy Shevchenko
2017-05-22 18:47 ` Jan Kiszka
0 siblings, 1 reply; 18+ messages in thread
From: Andy Shevchenko @ 2017-05-22 18:37 UTC (permalink / raw)
To: Lee Jones; +Cc: Jan Kiszka, Linux Kernel Mailing List, Sascha Weisenberger
On Mon, May 22, 2017 at 9:23 PM, Lee Jones <lee.jones@linaro.org> wrote:
> On Mon, 22 May 2017, Andy Shevchenko wrote:
>> On Mon, May 22, 2017 at 8:38 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>> > On 2017-05-22 19:36, Andy Shevchenko wrote:
>> > Then let's leave the decision up to the maintainer.
>>
>> Lee, just for your convenience I'm repeating myself here:
>>
>> I do not like this series at all since it tries to solve non-existing
>> issue in over-engineering way.
>>
>> If you on opposite side I will be happy to help reviewing it.
>
> New code looks cleaner and appears to use an already defined API.
Got your point.
Jan, care to resend (an updated?) version?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency
2017-05-22 18:37 ` Andy Shevchenko
@ 2017-05-22 18:47 ` Jan Kiszka
2017-05-22 19:35 ` Andy Shevchenko
0 siblings, 1 reply; 18+ messages in thread
From: Jan Kiszka @ 2017-05-22 18:47 UTC (permalink / raw)
To: Andy Shevchenko, Lee Jones; +Cc: Linux Kernel Mailing List, Sascha Weisenberger
On 2017-05-22 20:37, Andy Shevchenko wrote:
> On Mon, May 22, 2017 at 9:23 PM, Lee Jones <lee.jones@linaro.org> wrote:
>> On Mon, 22 May 2017, Andy Shevchenko wrote:
>>> On Mon, May 22, 2017 at 8:38 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>>>> On 2017-05-22 19:36, Andy Shevchenko wrote:
>
>>>> Then let's leave the decision up to the maintainer.
>>>
>>> Lee, just for your convenience I'm repeating myself here:
>>>
>>> I do not like this series at all since it tries to solve non-existing
>>> issue in over-engineering way.
>>>
>>> If you on opposite side I will be happy to help reviewing it.
>>
>> New code looks cleaner and appears to use an already defined API.
>
> Got your point.
> Jan, care to resend (an updated?) version?
>
Updated in which regard? The one for stmmac is broken, this one should
be fine.
Jan
--
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Corporate Competence Center Embedded Linux
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency
2017-05-22 18:47 ` Jan Kiszka
@ 2017-05-22 19:35 ` Andy Shevchenko
0 siblings, 0 replies; 18+ messages in thread
From: Andy Shevchenko @ 2017-05-22 19:35 UTC (permalink / raw)
To: Jan Kiszka; +Cc: Lee Jones, Linux Kernel Mailing List, Sascha Weisenberger
On Mon, May 22, 2017 at 9:47 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
> On 2017-05-22 20:37, Andy Shevchenko wrote:
>> On Mon, May 22, 2017 at 9:23 PM, Lee Jones <lee.jones@linaro.org> wrote:
>>> On Mon, 22 May 2017, Andy Shevchenko wrote:
>>>> On Mon, May 22, 2017 at 8:38 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>> Got your point.
>> Jan, care to resend (an updated?) version?
> Updated in which regard? The one for stmmac is broken, this one should
> be fine.
Can you just resend then, please? I have been out a while and now I
have a pile of mails, it would be slightly easy for me to go through a
fresh series.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v2 0/2] mfd: intel_quark_i2c_gpio: Refactor and support for IOT2000
2017-05-22 10:53 [PATCH v2 0/2] mfd: intel_quark_i2c_gpio: Refactor and support for IOT2000 Jan Kiszka
2017-05-22 10:53 ` [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency Jan Kiszka
2017-05-22 10:53 ` [PATCH v2 2/2] mfd: intel_quark_i2c_gpio: Add support for SIMATIC IOT2000 platform Jan Kiszka
@ 2017-05-23 15:02 ` Andy Shevchenko
2017-05-30 8:13 ` Lee Jones
3 siblings, 0 replies; 18+ messages in thread
From: Andy Shevchenko @ 2017-05-23 15:02 UTC (permalink / raw)
To: Jan Kiszka, Lee Jones
Cc: Linux Kernel Mailing List, Andy Shevchenko, Sascha Weisenberger
On Mon, 2017-05-22 at 12:53 +0200, Jan Kiszka wrote:
> Changes in v2:
> - refactor DMI matching first
Okay, we would do amendments later if something new comes up.
For now, FWIW:
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
P.S. After all it looks not bad.
>
> Jan
>
> Jan Kiszka (2):
> mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving
> frequency
> mfd: intel_quark_i2c_gpio: Add support for SIMATIC IOT2000 platform
>
> drivers/mfd/intel_quark_i2c_gpio.c | 49 ++++++++++++++++++++++-------
> ---------
> 1 file changed, 29 insertions(+), 20 deletions(-)
>
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v2 0/2] mfd: intel_quark_i2c_gpio: Refactor and support for IOT2000
2017-05-22 10:53 [PATCH v2 0/2] mfd: intel_quark_i2c_gpio: Refactor and support for IOT2000 Jan Kiszka
` (2 preceding siblings ...)
2017-05-23 15:02 ` [PATCH v2 0/2] mfd: intel_quark_i2c_gpio: Refactor and support for IOT2000 Andy Shevchenko
@ 2017-05-30 8:13 ` Lee Jones
3 siblings, 0 replies; 18+ messages in thread
From: Lee Jones @ 2017-05-30 8:13 UTC (permalink / raw)
To: Jan Kiszka
Cc: Linux Kernel Mailing List, Andy Shevchenko, Sascha Weisenberger
On Mon, 22 May 2017, Jan Kiszka wrote:
> Changes in v2:
> - refactor DMI matching first
>
> Jan
>
> Jan Kiszka (2):
> mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving
> frequency
> mfd: intel_quark_i2c_gpio: Add support for SIMATIC IOT2000 platform
>
> drivers/mfd/intel_quark_i2c_gpio.c | 49 ++++++++++++++++++++++----------------
> 1 file changed, 29 insertions(+), 20 deletions(-)
Jan, to make this easy, will you resend with Andy's Acks please?
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 18+ messages in thread
end of thread, other threads:[~2017-05-30 8:13 UTC | newest]
Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-22 10:53 [PATCH v2 0/2] mfd: intel_quark_i2c_gpio: Refactor and support for IOT2000 Jan Kiszka
2017-05-22 10:53 ` [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency Jan Kiszka
2017-05-22 17:12 ` Andy Shevchenko
2017-05-22 17:18 ` Jan Kiszka
2017-05-22 17:20 ` Andy Shevchenko
2017-05-22 17:25 ` Jan Kiszka
2017-05-22 17:26 ` Andy Shevchenko
2017-05-22 17:34 ` Jan Kiszka
2017-05-22 17:36 ` Andy Shevchenko
2017-05-22 17:38 ` Jan Kiszka
2017-05-22 17:42 ` Andy Shevchenko
2017-05-22 18:23 ` Lee Jones
2017-05-22 18:37 ` Andy Shevchenko
2017-05-22 18:47 ` Jan Kiszka
2017-05-22 19:35 ` Andy Shevchenko
2017-05-22 10:53 ` [PATCH v2 2/2] mfd: intel_quark_i2c_gpio: Add support for SIMATIC IOT2000 platform Jan Kiszka
2017-05-23 15:02 ` [PATCH v2 0/2] mfd: intel_quark_i2c_gpio: Refactor and support for IOT2000 Andy Shevchenko
2017-05-30 8:13 ` Lee Jones
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.