* [PATCH 0/1] toaster: last build id call
@ 2017-06-15 4:54 David Reyna
2017-06-15 4:54 ` [PATCH 1/1] toaster: get_last_build_id not called correctly David Reyna
0 siblings, 1 reply; 2+ messages in thread
From: David Reyna @ 2017-06-15 4:54 UTC (permalink / raw)
To: bitbake-devel
From: David Reyna <David.Reyna@windriver.com>
Many calls to "get_last_build_id" were missing the "()" in several calls, and
were previously failing silently.
The following changes since commit 6964efddd31c479386d1643c1025bc102710392f:
bitbake: cooker: ensure graceful exit after exception during BuildCompleted handler (2017-06-14 14:54:25 +0100)
are available in the git repository at:
git://git.yoctoproject.org/poky-contrib dreyna/submit/bdreyna/toaster/get_last_build_id_11570
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=dreyna/submit/bdreyna/toaster/get_last_build_id_11570
David Reyna (1):
toaster: get_last_build_id not called correctly
lib/toaster/orm/models.py | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH 1/1] toaster: get_last_build_id not called correctly
2017-06-15 4:54 [PATCH 0/1] toaster: last build id call David Reyna
@ 2017-06-15 4:54 ` David Reyna
0 siblings, 0 replies; 2+ messages in thread
From: David Reyna @ 2017-06-15 4:54 UTC (permalink / raw)
To: bitbake-devel
From: David Reyna <David.Reyna@windriver.com>
The method "get_last_build_id" missing the "()" in several calls. This
has been failing silently with Django 1.8 but intermittently crash with
Django 1.9.
[YOCTO #11570]
Signed-off-by: David Reyna <David.Reyna@windriver.com>
---
lib/toaster/orm/models.py | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/lib/toaster/orm/models.py b/lib/toaster/orm/models.py
index 6c5cfcd..a49f9a4 100644
--- a/lib/toaster/orm/models.py
+++ b/lib/toaster/orm/models.py
@@ -225,16 +225,16 @@ class Project(models.Model):
return( -1 )
def get_last_outcome(self):
- build_id = self.get_last_build_id
+ build_id = self.get_last_build_id()
if (-1 == build_id):
return( "" )
try:
- return Build.objects.filter( id = self.get_last_build_id )[ 0 ].outcome
+ return Build.objects.filter( id = build_id )[ 0 ].outcome
except (Build.DoesNotExist,IndexError):
return( "not_found" )
def get_last_target(self):
- build_id = self.get_last_build_id
+ build_id = self.get_last_build_id()
if (-1 == build_id):
return( "" )
try:
@@ -243,7 +243,7 @@ class Project(models.Model):
return( "not_found" )
def get_last_errors(self):
- build_id = self.get_last_build_id
+ build_id = self.get_last_build_id()
if (-1 == build_id):
return( 0 )
try:
@@ -252,7 +252,7 @@ class Project(models.Model):
return( "not_found" )
def get_last_warnings(self):
- build_id = self.get_last_build_id
+ build_id = self.get_last_build_id()
if (-1 == build_id):
return( 0 )
try:
@@ -269,7 +269,7 @@ class Project(models.Model):
return last_build.get_image_file_extensions()
def get_last_imgfiles(self):
- build_id = self.get_last_build_id
+ build_id = self.get_last_build_id()
if (-1 == build_id):
return( "" )
try:
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-15 5:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-15 4:54 [PATCH 0/1] toaster: last build id call David Reyna
2017-06-15 4:54 ` [PATCH 1/1] toaster: get_last_build_id not called correctly David Reyna
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.