* [PATCH 0/3] Staging: vc04_services: Code cleanup
@ 2017-09-12 17:39 Meghana Madhyastha
2017-09-12 17:52 ` [PATCH 2/3] Staging: vc04_services: Replace "foo * bar" with "foo *bar" Meghana Madhyastha
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Meghana Madhyastha @ 2017-09-12 17:39 UTC (permalink / raw)
To: gregkh, outreachy-kernel
The patches in this patchset fix some warnings
in the vc04_services driver.
Meghana Madhyastha (3):
Staging: vc04_services: Remove 80 columns error
Staging: vc04_services: Replace "foo * bar" with "foo *bar"
Staging: vc04_services: Remove commented lines
drivers/staging/vc04_services/interface/vchi/vchi.h | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
--
2.7.4
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/3] Staging: vc04_services: Replace "foo * bar" with "foo *bar"
2017-09-12 17:39 [PATCH 0/3] Staging: vc04_services: Code cleanup Meghana Madhyastha
@ 2017-09-12 17:52 ` Meghana Madhyastha
2017-09-12 20:43 ` Greg KH
2017-09-12 17:53 ` [PATCH 3/3] Staging: vc04_services: Remove commented lines Meghana Madhyastha
2017-09-12 17:55 ` [PATCH 1/3] Staging: vc04_services: Remove 80 columns error Meghana Madhyastha
2 siblings, 1 reply; 6+ messages in thread
From: Meghana Madhyastha @ 2017-09-12 17:52 UTC (permalink / raw)
To: gregkh, outreachy-kernel
Preferred coding style.
Found by checkpath.pl
Signed-off-by: Meghana Madhyastha <meghana.madhyastha@gmail.com>
---
drivers/staging/vc04_services/interface/vchi/vchi.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vc04_services/interface/vchi/vchi.h b/drivers/staging/vc04_services/interface/vchi/vchi.h
index 6fea154..7281a01 100644
--- a/drivers/staging/vc04_services/interface/vchi/vchi.h
+++ b/drivers/staging/vc04_services/interface/vchi/vchi.h
@@ -160,7 +160,7 @@ extern "C" {
#endif
extern /*@observer@*/ VCHI_CONNECTION_T * vchi_create_connection(
- const struct opaque_vchi_connection_api_t * function_table,
+ const struct opaque_vchi_connection_api_t *function_table,
const VCHI_MESSAGE_DRIVER_T * low_level);
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 3/3] Staging: vc04_services: Remove commented lines
2017-09-12 17:39 [PATCH 0/3] Staging: vc04_services: Code cleanup Meghana Madhyastha
2017-09-12 17:52 ` [PATCH 2/3] Staging: vc04_services: Replace "foo * bar" with "foo *bar" Meghana Madhyastha
@ 2017-09-12 17:53 ` Meghana Madhyastha
2017-09-12 20:43 ` Greg KH
2017-09-12 17:55 ` [PATCH 1/3] Staging: vc04_services: Remove 80 columns error Meghana Madhyastha
2 siblings, 1 reply; 6+ messages in thread
From: Meghana Madhyastha @ 2017-09-12 17:53 UTC (permalink / raw)
To: gregkh, outreachy-kernel
Remove the commented extern declarations
as they are not used.
Signed-off-by: Meghana Madhyastha <meghana.madhyastha@gmail.com>
---
drivers/staging/vc04_services/interface/vchi/vchi.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchi/vchi.h b/drivers/staging/vc04_services/interface/vchi/vchi.h
index 7281a01..c1c9073 100644
--- a/drivers/staging/vc04_services/interface/vchi/vchi.h
+++ b/drivers/staging/vc04_services/interface/vchi/vchi.h
@@ -343,8 +343,6 @@ extern int32_t vchi_bulk_queue_transmit( VCHI_SERVICE_HANDLE_T handle,
// function prototypes for the different mid layers (the state info gives the different physical connections)
extern const struct opaque_vchi_connection_api_t *single_get_func_table( void );
-//extern const struct opaque_vchi_connection_api_t *local_server_get_func_table( void );
-//extern const struct opaque_vchi_connection_api_t *local_client_get_func_table( void );
// declare all message drivers here
const VCHI_MESSAGE_DRIVER_T *vchi_mphi_message_driver_func_table( void );
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 1/3] Staging: vc04_services: Remove 80 columns error
2017-09-12 17:39 [PATCH 0/3] Staging: vc04_services: Code cleanup Meghana Madhyastha
2017-09-12 17:52 ` [PATCH 2/3] Staging: vc04_services: Replace "foo * bar" with "foo *bar" Meghana Madhyastha
2017-09-12 17:53 ` [PATCH 3/3] Staging: vc04_services: Remove commented lines Meghana Madhyastha
@ 2017-09-12 17:55 ` Meghana Madhyastha
2 siblings, 0 replies; 6+ messages in thread
From: Meghana Madhyastha @ 2017-09-12 17:55 UTC (permalink / raw)
To: gregkh, outreachy-kernel
Split the line into multiple lines to enhance readability
and to adhere to standard codingn style.
Signed-off-by: Meghana Madhyastha <meghana.madhyastha@gmail.com>
---
drivers/staging/vc04_services/interface/vchi/vchi.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchi/vchi.h b/drivers/staging/vc04_services/interface/vchi/vchi.h
index 23eb7a9..6fea154 100644
--- a/drivers/staging/vc04_services/interface/vchi/vchi.h
+++ b/drivers/staging/vc04_services/interface/vchi/vchi.h
@@ -159,8 +159,9 @@ typedef struct service_info_tag {
extern "C" {
#endif
-extern /*@observer@*/ VCHI_CONNECTION_T * vchi_create_connection( const struct opaque_vchi_connection_api_t * function_table,
- const VCHI_MESSAGE_DRIVER_T * low_level);
+extern /*@observer@*/ VCHI_CONNECTION_T * vchi_create_connection(
+ const struct opaque_vchi_connection_api_t * function_table,
+ const VCHI_MESSAGE_DRIVER_T * low_level);
// Routine used to initialise the vchi on both local + remote connections
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 2/3] Staging: vc04_services: Replace "foo * bar" with "foo *bar"
2017-09-12 17:52 ` [PATCH 2/3] Staging: vc04_services: Replace "foo * bar" with "foo *bar" Meghana Madhyastha
@ 2017-09-12 20:43 ` Greg KH
0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2017-09-12 20:43 UTC (permalink / raw)
To: Meghana Madhyastha; +Cc: outreachy-kernel
On Tue, Sep 12, 2017 at 11:22:24PM +0530, Meghana Madhyastha wrote:
> Preferred coding style.
> Found by checkpath.pl
>
> Signed-off-by: Meghana Madhyastha <meghana.madhyastha@gmail.com>
> ---
> drivers/staging/vc04_services/interface/vchi/vchi.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Patch does not apply to my tree at all :(
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 3/3] Staging: vc04_services: Remove commented lines
2017-09-12 17:53 ` [PATCH 3/3] Staging: vc04_services: Remove commented lines Meghana Madhyastha
@ 2017-09-12 20:43 ` Greg KH
0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2017-09-12 20:43 UTC (permalink / raw)
To: Meghana Madhyastha; +Cc: outreachy-kernel
On Tue, Sep 12, 2017 at 11:23:34PM +0530, Meghana Madhyastha wrote:
> Remove the commented extern declarations
> as they are not used.
>
> Signed-off-by: Meghana Madhyastha <meghana.madhyastha@gmail.com>
> ---
> drivers/staging/vc04_services/interface/vchi/vchi.h | 2 --
> 1 file changed, 2 deletions(-)
This patch also does not apply to my tree :(
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-09-12 20:43 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-12 17:39 [PATCH 0/3] Staging: vc04_services: Code cleanup Meghana Madhyastha
2017-09-12 17:52 ` [PATCH 2/3] Staging: vc04_services: Replace "foo * bar" with "foo *bar" Meghana Madhyastha
2017-09-12 20:43 ` Greg KH
2017-09-12 17:53 ` [PATCH 3/3] Staging: vc04_services: Remove commented lines Meghana Madhyastha
2017-09-12 20:43 ` Greg KH
2017-09-12 17:55 ` [PATCH 1/3] Staging: vc04_services: Remove 80 columns error Meghana Madhyastha
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.