All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: mporter@kernel.crashing.org, alexandre.bounine@idt.com,
	lstoakes@gmail.com, akpm@linux-foundation.org,
	jesper.nilsson@axis.com, christian.koenig@amd.com,
	logang@deltatee.com
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
	Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Subject: [PATCH 0/2] rapidio: Two fixes for 'rio_dma_transfer()'
Date: Mon, 18 Sep 2017 00:33:04 +0200	[thread overview]
Message-ID: <cover.1505687047.git.christophe.jaillet@wanadoo.fr> (raw)

These 2 patches are really close and are both related to error handling
in 'rio_dma_transfer()'.
The first one fixes some resources leak in case of error.
The 2nd one fixes a test so that the corresponding error can be handled
correctly.

I've splitted this into 2 paches because the first one looks trivial to me.
But the 2nd one should require more attention, IMO. The existing error
handling was dead code because 'dma_map_sg()' can not return -EFAULT. So
this error handling code has never been executed/tested and I can't test it
myself.

Christophe JAILLET (2):
  rapidio: Fix resources leak in error handling path in
    'rio_dma_transfer()'
  rapidio: Fix an error handling in 'rio_dma_transfer()'

 drivers/rapidio/devices/rio_mport_cdev.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

-- 
2.11.0

WARNING: multiple messages have this Message-ID (diff)
From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: mporter@kernel.crashing.org, alexandre.bounine@idt.com,
	lstoakes@gmail.com, akpm@linux-foundation.org,
	jesper.nilsson@axis.com, christian.koenig@amd.com,
	logang@deltatee.com
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
	Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Subject: [PATCH 0/2] rapidio: Two fixes for 'rio_dma_transfer()'
Date: Sun, 17 Sep 2017 22:33:04 +0000	[thread overview]
Message-ID: <cover.1505687047.git.christophe.jaillet@wanadoo.fr> (raw)

These 2 patches are really close and are both related to error handling
in 'rio_dma_transfer()'.
The first one fixes some resources leak in case of error.
The 2nd one fixes a test so that the corresponding error can be handled
correctly.

I've splitted this into 2 paches because the first one looks trivial to me.
But the 2nd one should require more attention, IMO. The existing error
handling was dead code because 'dma_map_sg()' can not return -EFAULT. So
this error handling code has never been executed/tested and I can't test it
myself.

Christophe JAILLET (2):
  rapidio: Fix resources leak in error handling path in
    'rio_dma_transfer()'
  rapidio: Fix an error handling in 'rio_dma_transfer()'

 drivers/rapidio/devices/rio_mport_cdev.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

-- 
2.11.0


             reply	other threads:[~2017-09-17 22:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-17 22:33 Christophe JAILLET [this message]
2017-09-17 22:33 ` [PATCH 0/2] rapidio: Two fixes for 'rio_dma_transfer()' Christophe JAILLET
2017-09-17 22:33 ` [PATCH 1/2] rapidio: Fix resources leak in error handling path in 'rio_dma_transfer()' Christophe JAILLET
2017-09-17 22:33   ` Christophe JAILLET
2017-09-17 22:33 ` [PATCH 2/2] rapidio: Fix an error handling " Christophe JAILLET
2017-09-17 22:33   ` Christophe JAILLET
2017-09-18 16:04 ` [PATCH 0/2] rapidio: Two fixes for 'rio_dma_transfer()' Logan Gunthorpe
2017-09-18 16:04   ` Logan Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1505687047.git.christophe.jaillet@wanadoo.fr \
    --to=christophe.jaillet@wanadoo.fr \
    --cc=akpm@linux-foundation.org \
    --cc=alexandre.bounine@idt.com \
    --cc=christian.koenig@amd.com \
    --cc=jesper.nilsson@axis.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=logang@deltatee.com \
    --cc=lstoakes@gmail.com \
    --cc=mporter@kernel.crashing.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.