All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: madalin.bucur@nxp.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org,
	Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Subject: [PATCH 0/4] fsl/fman: Fix some error handling code in mac_probe
Date: Mon,  6 Nov 2017 22:53:28 +0100	[thread overview]
Message-ID: <cover.1510003551.git.christophe.jaillet@wanadoo.fr> (raw)

Commit c6e26ea8c893 ("dpaa_eth: change device used") generated some
conflicts in my patches waiting for submission. So I took a closer look at
it.


So here is a serie of 4 patches.

The 1st one is just about a spurious call to 'dev_set_drvdata()', which is
done in only 1 error handling path in the function.

The 2nd one removes some devm_iounmap/release/kfree functions which look
useless to me.

The 3rd one fixes a missing of_node_put.

The 4th one is just cosmetic and removes a useless message.


Christophe JAILLET (4):
  fsl/fman: Remove a useless call to 'dev_set_drvdata()'
  fsl/fman: Remove some useless code
  fsl/fman: Add a missing 'of_node_put()' call in an error handling path
  fsl/fman: Remove a useless 'dev_err()' call

 drivers/net/ethernet/freescale/fman/mac.c | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

-- 
2.14.1

WARNING: multiple messages have this Message-ID (diff)
From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: madalin.bucur@nxp.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org,
	Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Subject: [PATCH 0/4] fsl/fman: Fix some error handling code in mac_probe
Date: Mon, 06 Nov 2017 21:53:28 +0000	[thread overview]
Message-ID: <cover.1510003551.git.christophe.jaillet@wanadoo.fr> (raw)

Commit c6e26ea8c893 ("dpaa_eth: change device used") generated some
conflicts in my patches waiting for submission. So I took a closer look at
it.


So here is a serie of 4 patches.

The 1st one is just about a spurious call to 'dev_set_drvdata()', which is
done in only 1 error handling path in the function.

The 2nd one removes some devm_iounmap/release/kfree functions which look
useless to me.

The 3rd one fixes a missing of_node_put.

The 4th one is just cosmetic and removes a useless message.


Christophe JAILLET (4):
  fsl/fman: Remove a useless call to 'dev_set_drvdata()'
  fsl/fman: Remove some useless code
  fsl/fman: Add a missing 'of_node_put()' call in an error handling path
  fsl/fman: Remove a useless 'dev_err()' call

 drivers/net/ethernet/freescale/fman/mac.c | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

-- 
2.14.1


             reply	other threads:[~2017-11-06 21:53 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-06 21:53 Christophe JAILLET [this message]
2017-11-06 21:53 ` [PATCH 0/4] fsl/fman: Fix some error handling code in mac_probe Christophe JAILLET
2017-11-06 21:53 ` [PATCH 1/4] fsl/fman: Remove a useless call to 'dev_set_drvdata()' Christophe JAILLET
2017-11-06 21:53   ` Christophe JAILLET
2017-11-06 21:53 ` [PATCH 2/4] fsl/fman: Remove some useless code Christophe JAILLET
2017-11-06 21:53   ` Christophe JAILLET
2017-11-07  6:29   ` Christophe JAILLET
2017-11-06 21:53 ` [PATCH 3/4] fsl/fman: Add a missing 'of_node_put()' call in an error handling path Christophe JAILLET
2017-11-06 21:53   ` Christophe JAILLET
2017-11-06 21:53 ` [PATCH 4/4] fsl/fman: Remove a useless 'dev_err()' call Christophe JAILLET
2017-11-06 21:53   ` Christophe JAILLET
2017-11-07  7:14 ` [PATCH 0/4] fsl/fman: Fix some error handling code in mac_probe Madalin-cristian Bucur
2017-11-07  7:14   ` Madalin-cristian Bucur
2017-11-08  4:53 ` David Miller
2017-11-08  4:53   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1510003551.git.christophe.jaillet@wanadoo.fr \
    --to=christophe.jaillet@wanadoo.fr \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=madalin.bucur@nxp.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.