All of lore.kernel.org
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH v2 0/1] Disk caches in VirtIO Balloon driver stats
@ 2017-12-05 12:14 ` Tomáš Golembiovský
  0 siblings, 0 replies; 16+ messages in thread
From: Tomáš Golembiovský @ 2017-12-05 12:14 UTC (permalink / raw)
  To: virtio-dev, qemu-devel
  Cc: Wei Wang, Michael S. Tsirkin, Tomáš Golembiovský

This is a QEMU counterpart to the patch for VirtIO balloon driver posted here:

https://lists.nongnu.org/archive/html/qemu-devel/2017-11/msg02106.html

Tomáš Golembiovský (1):
  virtio-balloon: include statistics of disk/file caches

 hw/virtio/virtio-balloon.c                      | 1 +
 include/standard-headers/linux/virtio_balloon.h | 3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)

-- 
2.15.1

^ permalink raw reply	[flat|nested] 16+ messages in thread
* [virtio-dev] [PATCH v2 0/1] Disk caches in VirtIO Balloon driver stats
@ 2017-12-05 12:14 ` Tomáš Golembiovský
  0 siblings, 0 replies; 16+ messages in thread
From: Tomáš Golembiovský @ 2017-12-05 12:14 UTC (permalink / raw)
  To: virtio-dev, qemu-devel
  Cc: Wei Wang, Michael S. Tsirkin, Tomáš Golembiovský

This is a QEMU counterpart to the patch for VirtIO balloon driver posted here:

https://lists.nongnu.org/archive/html/qemu-devel/2017-11/msg02106.html

Tomáš Golembiovský (1):
  virtio-balloon: include statistics of disk/file caches

 hw/virtio/virtio-balloon.c                      | 1 +
 include/standard-headers/linux/virtio_balloon.h | 3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)

-- 
2.15.1


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org


^ permalink raw reply	[flat|nested] 16+ messages in thread
* [Qemu-devel] [PATCH v2 1/1] virtio-balloon: include statistics of disk/file caches
  2017-12-05 12:14 ` [virtio-dev] " Tomáš Golembiovský
@ 2017-12-05 12:14   ` Tomáš Golembiovský
  -1 siblings, 0 replies; 16+ messages in thread
From: Tomáš Golembiovský @ 2017-12-05 12:14 UTC (permalink / raw)
  To: virtio-dev, qemu-devel
  Cc: Wei Wang, Michael S. Tsirkin, Tomáš Golembiovský

Signed-off-by: Tomáš Golembiovský <tgolembi@redhat.com>
---
 hw/virtio/virtio-balloon.c                      | 1 +
 include/standard-headers/linux/virtio_balloon.h | 3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c
index 37cde38982..8141326a51 100644
--- a/hw/virtio/virtio-balloon.c
+++ b/hw/virtio/virtio-balloon.c
@@ -50,6 +50,7 @@ static const char *balloon_stat_names[] = {
    [VIRTIO_BALLOON_S_MEMFREE] = "stat-free-memory",
    [VIRTIO_BALLOON_S_MEMTOT] = "stat-total-memory",
    [VIRTIO_BALLOON_S_AVAIL] = "stat-available-memory",
+   [VIRTIO_BALLOON_S_CACHES] = "stat-disk-caches",
    [VIRTIO_BALLOON_S_NR] = NULL
 };
 
diff --git a/include/standard-headers/linux/virtio_balloon.h b/include/standard-headers/linux/virtio_balloon.h
index 9d06ccd066..7b0a41b8fc 100644
--- a/include/standard-headers/linux/virtio_balloon.h
+++ b/include/standard-headers/linux/virtio_balloon.h
@@ -52,7 +52,8 @@ struct virtio_balloon_config {
 #define VIRTIO_BALLOON_S_MEMFREE  4   /* Total amount of free memory */
 #define VIRTIO_BALLOON_S_MEMTOT   5   /* Total amount of memory */
 #define VIRTIO_BALLOON_S_AVAIL    6   /* Available memory as in /proc */
-#define VIRTIO_BALLOON_S_NR       7
+#define VIRTIO_BALLOON_S_CACHES   7   /* Disk caches */
+#define VIRTIO_BALLOON_S_NR       8
 
 /*
  * Memory statistics structure.
-- 
2.15.1

^ permalink raw reply related	[flat|nested] 16+ messages in thread
* [virtio-dev] [PATCH v2 1/1] virtio-balloon: include statistics of disk/file caches
@ 2017-12-05 12:14   ` Tomáš Golembiovský
  0 siblings, 0 replies; 16+ messages in thread
From: Tomáš Golembiovský @ 2017-12-05 12:14 UTC (permalink / raw)
  To: virtio-dev, qemu-devel
  Cc: Wei Wang, Michael S. Tsirkin, Tomáš Golembiovský

Signed-off-by: Tomáš Golembiovský <tgolembi@redhat.com>
---
 hw/virtio/virtio-balloon.c                      | 1 +
 include/standard-headers/linux/virtio_balloon.h | 3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c
index 37cde38982..8141326a51 100644
--- a/hw/virtio/virtio-balloon.c
+++ b/hw/virtio/virtio-balloon.c
@@ -50,6 +50,7 @@ static const char *balloon_stat_names[] = {
    [VIRTIO_BALLOON_S_MEMFREE] = "stat-free-memory",
    [VIRTIO_BALLOON_S_MEMTOT] = "stat-total-memory",
    [VIRTIO_BALLOON_S_AVAIL] = "stat-available-memory",
+   [VIRTIO_BALLOON_S_CACHES] = "stat-disk-caches",
    [VIRTIO_BALLOON_S_NR] = NULL
 };
 
diff --git a/include/standard-headers/linux/virtio_balloon.h b/include/standard-headers/linux/virtio_balloon.h
index 9d06ccd066..7b0a41b8fc 100644
--- a/include/standard-headers/linux/virtio_balloon.h
+++ b/include/standard-headers/linux/virtio_balloon.h
@@ -52,7 +52,8 @@ struct virtio_balloon_config {
 #define VIRTIO_BALLOON_S_MEMFREE  4   /* Total amount of free memory */
 #define VIRTIO_BALLOON_S_MEMTOT   5   /* Total amount of memory */
 #define VIRTIO_BALLOON_S_AVAIL    6   /* Available memory as in /proc */
-#define VIRTIO_BALLOON_S_NR       7
+#define VIRTIO_BALLOON_S_CACHES   7   /* Disk caches */
+#define VIRTIO_BALLOON_S_NR       8
 
 /*
  * Memory statistics structure.
-- 
2.15.1


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org


^ permalink raw reply related	[flat|nested] 16+ messages in thread
* Re: [Qemu-devel] [PATCH v2 1/1] virtio-balloon: include statistics of disk/file caches
  2017-12-05 12:14   ` [virtio-dev] " Tomáš Golembiovský
@ 2018-02-05 12:08     ` Tomáš Golembiovský
  -1 siblings, 0 replies; 16+ messages in thread
From: Tomáš Golembiovský @ 2018-02-05 12:08 UTC (permalink / raw)
  To: virtio-dev, qemu-devel; +Cc: Wei Wang, Michael S. Tsirkin

ping

On Tue,  5 Dec 2017 13:14:46 +0100
Tomáš Golembiovský <tgolembi@redhat.com> wrote:

> Signed-off-by: Tomáš Golembiovský <tgolembi@redhat.com>
> ---
>  hw/virtio/virtio-balloon.c                      | 1 +
>  include/standard-headers/linux/virtio_balloon.h | 3 ++-
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c
> index 37cde38982..8141326a51 100644
> --- a/hw/virtio/virtio-balloon.c
> +++ b/hw/virtio/virtio-balloon.c
> @@ -50,6 +50,7 @@ static const char *balloon_stat_names[] = {
>     [VIRTIO_BALLOON_S_MEMFREE] = "stat-free-memory",
>     [VIRTIO_BALLOON_S_MEMTOT] = "stat-total-memory",
>     [VIRTIO_BALLOON_S_AVAIL] = "stat-available-memory",
> +   [VIRTIO_BALLOON_S_CACHES] = "stat-disk-caches",
>     [VIRTIO_BALLOON_S_NR] = NULL
>  };
>  
> diff --git a/include/standard-headers/linux/virtio_balloon.h b/include/standard-headers/linux/virtio_balloon.h
> index 9d06ccd066..7b0a41b8fc 100644
> --- a/include/standard-headers/linux/virtio_balloon.h
> +++ b/include/standard-headers/linux/virtio_balloon.h
> @@ -52,7 +52,8 @@ struct virtio_balloon_config {
>  #define VIRTIO_BALLOON_S_MEMFREE  4   /* Total amount of free memory */
>  #define VIRTIO_BALLOON_S_MEMTOT   5   /* Total amount of memory */
>  #define VIRTIO_BALLOON_S_AVAIL    6   /* Available memory as in /proc */
> -#define VIRTIO_BALLOON_S_NR       7
> +#define VIRTIO_BALLOON_S_CACHES   7   /* Disk caches */
> +#define VIRTIO_BALLOON_S_NR       8
>  
>  /*
>   * Memory statistics structure.
> -- 
> 2.15.1
> 


-- 
Tomáš Golembiovský <tgolembi@redhat.com>

^ permalink raw reply	[flat|nested] 16+ messages in thread
* [virtio-dev] Re: [PATCH v2 1/1] virtio-balloon: include statistics of disk/file caches
@ 2018-02-05 12:08     ` Tomáš Golembiovský
  0 siblings, 0 replies; 16+ messages in thread
From: Tomáš Golembiovský @ 2018-02-05 12:08 UTC (permalink / raw)
  To: virtio-dev, qemu-devel; +Cc: Wei Wang, Michael S. Tsirkin

ping

On Tue,  5 Dec 2017 13:14:46 +0100
Tomáš Golembiovský <tgolembi@redhat.com> wrote:

> Signed-off-by: Tomáš Golembiovský <tgolembi@redhat.com>
> ---
>  hw/virtio/virtio-balloon.c                      | 1 +
>  include/standard-headers/linux/virtio_balloon.h | 3 ++-
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c
> index 37cde38982..8141326a51 100644
> --- a/hw/virtio/virtio-balloon.c
> +++ b/hw/virtio/virtio-balloon.c
> @@ -50,6 +50,7 @@ static const char *balloon_stat_names[] = {
>     [VIRTIO_BALLOON_S_MEMFREE] = "stat-free-memory",
>     [VIRTIO_BALLOON_S_MEMTOT] = "stat-total-memory",
>     [VIRTIO_BALLOON_S_AVAIL] = "stat-available-memory",
> +   [VIRTIO_BALLOON_S_CACHES] = "stat-disk-caches",
>     [VIRTIO_BALLOON_S_NR] = NULL
>  };
>  
> diff --git a/include/standard-headers/linux/virtio_balloon.h b/include/standard-headers/linux/virtio_balloon.h
> index 9d06ccd066..7b0a41b8fc 100644
> --- a/include/standard-headers/linux/virtio_balloon.h
> +++ b/include/standard-headers/linux/virtio_balloon.h
> @@ -52,7 +52,8 @@ struct virtio_balloon_config {
>  #define VIRTIO_BALLOON_S_MEMFREE  4   /* Total amount of free memory */
>  #define VIRTIO_BALLOON_S_MEMTOT   5   /* Total amount of memory */
>  #define VIRTIO_BALLOON_S_AVAIL    6   /* Available memory as in /proc */
> -#define VIRTIO_BALLOON_S_NR       7
> +#define VIRTIO_BALLOON_S_CACHES   7   /* Disk caches */
> +#define VIRTIO_BALLOON_S_NR       8
>  
>  /*
>   * Memory statistics structure.
> -- 
> 2.15.1
> 


-- 
Tomáš Golembiovský <tgolembi@redhat.com>

---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org


^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: [Qemu-devel] [PATCH v2 1/1] virtio-balloon: include statistics of disk/file caches
  2018-02-05 12:08     ` [virtio-dev] " Tomáš Golembiovský
@ 2018-02-13 20:29       ` Jonathan Helman
  -1 siblings, 0 replies; 16+ messages in thread
From: Jonathan Helman @ 2018-02-13 20:29 UTC (permalink / raw)
  To: Tomáš Golembiovský, virtio-dev, qemu-devel
  Cc: Wei Wang, Michael S. Tsirkin



On 02/05/2018 04:08 AM, Tomáš Golembiovský wrote:
> ping
> 
> On Tue,  5 Dec 2017 13:14:46 +0100
> Tomáš Golembiovský <tgolembi@redhat.com> wrote:
> 

It would be good to include the corresponding upstream kernel change in 
the commit message. This would be similar to a previous change: 
https://lists.gnu.org/archive/html/qemu-devel/2016-02/msg05555.html

>> Signed-off-by: Tomáš Golembiovský <tgolembi@redhat.com>
>> ---
>>   hw/virtio/virtio-balloon.c                      | 1 +
>>   include/standard-headers/linux/virtio_balloon.h | 3 ++-
>>   2 files changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c
>> index 37cde38982..8141326a51 100644
>> --- a/hw/virtio/virtio-balloon.c
>> +++ b/hw/virtio/virtio-balloon.c
>> @@ -50,6 +50,7 @@ static const char *balloon_stat_names[] = {
>>      [VIRTIO_BALLOON_S_MEMFREE] = "stat-free-memory",
>>      [VIRTIO_BALLOON_S_MEMTOT] = "stat-total-memory",
>>      [VIRTIO_BALLOON_S_AVAIL] = "stat-available-memory",
>> +   [VIRTIO_BALLOON_S_CACHES] = "stat-disk-caches",
>>      [VIRTIO_BALLOON_S_NR] = NULL
>>   };
>>   
>> diff --git a/include/standard-headers/linux/virtio_balloon.h b/include/standard-headers/linux/virtio_balloon.h
>> index 9d06ccd066..7b0a41b8fc 100644
>> --- a/include/standard-headers/linux/virtio_balloon.h
>> +++ b/include/standard-headers/linux/virtio_balloon.h
>> @@ -52,7 +52,8 @@ struct virtio_balloon_config {
>>   #define VIRTIO_BALLOON_S_MEMFREE  4   /* Total amount of free memory */
>>   #define VIRTIO_BALLOON_S_MEMTOT   5   /* Total amount of memory */
>>   #define VIRTIO_BALLOON_S_AVAIL    6   /* Available memory as in /proc */
>> -#define VIRTIO_BALLOON_S_NR       7
>> +#define VIRTIO_BALLOON_S_CACHES   7   /* Disk caches */

I've been wondering, VIRTIO_BALLOON_S_AVAIL is not in the virtio spec 
(see Section 5.5.6.3). It seems like this header file needs to be in 
sync with the virtio spec in order to make this change.

I have a similar change to add a new statistic and was wondering this.

>> +#define VIRTIO_BALLOON_S_NR       8
>>   
>>   /*
>>    * Memory statistics structure.
>> -- 
>> 2.15.1
>>
> 
> 

You need to add your new stat to the list of stats in 
docs/virtio-balloon-stats.txt.

Jon

^ permalink raw reply	[flat|nested] 16+ messages in thread
* [virtio-dev] Re: [Qemu-devel] [PATCH v2 1/1] virtio-balloon: include statistics of disk/file caches
@ 2018-02-13 20:29       ` Jonathan Helman
  0 siblings, 0 replies; 16+ messages in thread
From: Jonathan Helman @ 2018-02-13 20:29 UTC (permalink / raw)
  To: Tomáš Golembiovský, virtio-dev, qemu-devel
  Cc: Wei Wang, Michael S. Tsirkin



On 02/05/2018 04:08 AM, Tomáš Golembiovský wrote:
> ping
> 
> On Tue,  5 Dec 2017 13:14:46 +0100
> Tomáš Golembiovský <tgolembi@redhat.com> wrote:
> 

It would be good to include the corresponding upstream kernel change in 
the commit message. This would be similar to a previous change: 
https://lists.gnu.org/archive/html/qemu-devel/2016-02/msg05555.html

>> Signed-off-by: Tomáš Golembiovský <tgolembi@redhat.com>
>> ---
>>   hw/virtio/virtio-balloon.c                      | 1 +
>>   include/standard-headers/linux/virtio_balloon.h | 3 ++-
>>   2 files changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c
>> index 37cde38982..8141326a51 100644
>> --- a/hw/virtio/virtio-balloon.c
>> +++ b/hw/virtio/virtio-balloon.c
>> @@ -50,6 +50,7 @@ static const char *balloon_stat_names[] = {
>>      [VIRTIO_BALLOON_S_MEMFREE] = "stat-free-memory",
>>      [VIRTIO_BALLOON_S_MEMTOT] = "stat-total-memory",
>>      [VIRTIO_BALLOON_S_AVAIL] = "stat-available-memory",
>> +   [VIRTIO_BALLOON_S_CACHES] = "stat-disk-caches",
>>      [VIRTIO_BALLOON_S_NR] = NULL
>>   };
>>   
>> diff --git a/include/standard-headers/linux/virtio_balloon.h b/include/standard-headers/linux/virtio_balloon.h
>> index 9d06ccd066..7b0a41b8fc 100644
>> --- a/include/standard-headers/linux/virtio_balloon.h
>> +++ b/include/standard-headers/linux/virtio_balloon.h
>> @@ -52,7 +52,8 @@ struct virtio_balloon_config {
>>   #define VIRTIO_BALLOON_S_MEMFREE  4   /* Total amount of free memory */
>>   #define VIRTIO_BALLOON_S_MEMTOT   5   /* Total amount of memory */
>>   #define VIRTIO_BALLOON_S_AVAIL    6   /* Available memory as in /proc */
>> -#define VIRTIO_BALLOON_S_NR       7
>> +#define VIRTIO_BALLOON_S_CACHES   7   /* Disk caches */

I've been wondering, VIRTIO_BALLOON_S_AVAIL is not in the virtio spec 
(see Section 5.5.6.3). It seems like this header file needs to be in 
sync with the virtio spec in order to make this change.

I have a similar change to add a new statistic and was wondering this.

>> +#define VIRTIO_BALLOON_S_NR       8
>>   
>>   /*
>>    * Memory statistics structure.
>> -- 
>> 2.15.1
>>
> 
> 

You need to add your new stat to the list of stats in 
docs/virtio-balloon-stats.txt.

Jon


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org


^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: [Qemu-devel] [PATCH v2 1/1] virtio-balloon: include statistics of disk/file caches
  2018-02-13 20:29       ` [virtio-dev] " Jonathan Helman
@ 2018-02-13 22:07         ` Michael S. Tsirkin
  -1 siblings, 0 replies; 16+ messages in thread
From: Michael S. Tsirkin @ 2018-02-13 22:07 UTC (permalink / raw)
  To: Jonathan Helman
  Cc: Tomáš Golembiovský, virtio-dev, qemu-devel, Wei Wang

On Tue, Feb 13, 2018 at 12:29:39PM -0800, Jonathan Helman wrote:
> 
> 
> On 02/05/2018 04:08 AM, Tomáš Golembiovský wrote:
> > ping
> > 
> > On Tue,  5 Dec 2017 13:14:46 +0100
> > Tomáš Golembiovský <tgolembi@redhat.com> wrote:
> > 
> 
> It would be good to include the corresponding upstream kernel change in the
> commit message. This would be similar to a previous change:
> https://lists.gnu.org/archive/html/qemu-devel/2016-02/msg05555.html

good idea, but this has been merged by now.

> > > Signed-off-by: Tomáš Golembiovský <tgolembi@redhat.com>
> > > ---
> > >   hw/virtio/virtio-balloon.c                      | 1 +
> > >   include/standard-headers/linux/virtio_balloon.h | 3 ++-
> > >   2 files changed, 3 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c
> > > index 37cde38982..8141326a51 100644
> > > --- a/hw/virtio/virtio-balloon.c
> > > +++ b/hw/virtio/virtio-balloon.c
> > > @@ -50,6 +50,7 @@ static const char *balloon_stat_names[] = {
> > >      [VIRTIO_BALLOON_S_MEMFREE] = "stat-free-memory",
> > >      [VIRTIO_BALLOON_S_MEMTOT] = "stat-total-memory",
> > >      [VIRTIO_BALLOON_S_AVAIL] = "stat-available-memory",
> > > +   [VIRTIO_BALLOON_S_CACHES] = "stat-disk-caches",
> > >      [VIRTIO_BALLOON_S_NR] = NULL
> > >   };
> > > diff --git a/include/standard-headers/linux/virtio_balloon.h b/include/standard-headers/linux/virtio_balloon.h
> > > index 9d06ccd066..7b0a41b8fc 100644
> > > --- a/include/standard-headers/linux/virtio_balloon.h
> > > +++ b/include/standard-headers/linux/virtio_balloon.h
> > > @@ -52,7 +52,8 @@ struct virtio_balloon_config {
> > >   #define VIRTIO_BALLOON_S_MEMFREE  4   /* Total amount of free memory */
> > >   #define VIRTIO_BALLOON_S_MEMTOT   5   /* Total amount of memory */
> > >   #define VIRTIO_BALLOON_S_AVAIL    6   /* Available memory as in /proc */
> > > -#define VIRTIO_BALLOON_S_NR       7
> > > +#define VIRTIO_BALLOON_S_CACHES   7   /* Disk caches */
> 
> I've been wondering, VIRTIO_BALLOON_S_AVAIL is not in the virtio spec (see
> Section 5.5.6.3). It seems like this header file needs to be in sync with
> the virtio spec in order to make this change.
> 
> I have a similar change to add a new statistic and was wondering this.

Absolutely. Tomáš?

> > > +#define VIRTIO_BALLOON_S_NR       8
> > >   /*
> > >    * Memory statistics structure.
> > > -- 
> > > 2.15.1
> > > 
> > 
> > 
> 
> You need to add your new stat to the list of stats in
> docs/virtio-balloon-stats.txt.
> 
> Jon

Can't hurt, I agree.

-- 
MST

^ permalink raw reply	[flat|nested] 16+ messages in thread
* [virtio-dev] Re: [Qemu-devel] [PATCH v2 1/1] virtio-balloon: include statistics of disk/file caches
@ 2018-02-13 22:07         ` Michael S. Tsirkin
  0 siblings, 0 replies; 16+ messages in thread
From: Michael S. Tsirkin @ 2018-02-13 22:07 UTC (permalink / raw)
  To: Jonathan Helman
  Cc: Tomáš Golembiovský, virtio-dev, qemu-devel, Wei Wang

On Tue, Feb 13, 2018 at 12:29:39PM -0800, Jonathan Helman wrote:
> 
> 
> On 02/05/2018 04:08 AM, Tomáš Golembiovský wrote:
> > ping
> > 
> > On Tue,  5 Dec 2017 13:14:46 +0100
> > Tomáš Golembiovský <tgolembi@redhat.com> wrote:
> > 
> 
> It would be good to include the corresponding upstream kernel change in the
> commit message. This would be similar to a previous change:
> https://lists.gnu.org/archive/html/qemu-devel/2016-02/msg05555.html

good idea, but this has been merged by now.

> > > Signed-off-by: Tomáš Golembiovský <tgolembi@redhat.com>
> > > ---
> > >   hw/virtio/virtio-balloon.c                      | 1 +
> > >   include/standard-headers/linux/virtio_balloon.h | 3 ++-
> > >   2 files changed, 3 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c
> > > index 37cde38982..8141326a51 100644
> > > --- a/hw/virtio/virtio-balloon.c
> > > +++ b/hw/virtio/virtio-balloon.c
> > > @@ -50,6 +50,7 @@ static const char *balloon_stat_names[] = {
> > >      [VIRTIO_BALLOON_S_MEMFREE] = "stat-free-memory",
> > >      [VIRTIO_BALLOON_S_MEMTOT] = "stat-total-memory",
> > >      [VIRTIO_BALLOON_S_AVAIL] = "stat-available-memory",
> > > +   [VIRTIO_BALLOON_S_CACHES] = "stat-disk-caches",
> > >      [VIRTIO_BALLOON_S_NR] = NULL
> > >   };
> > > diff --git a/include/standard-headers/linux/virtio_balloon.h b/include/standard-headers/linux/virtio_balloon.h
> > > index 9d06ccd066..7b0a41b8fc 100644
> > > --- a/include/standard-headers/linux/virtio_balloon.h
> > > +++ b/include/standard-headers/linux/virtio_balloon.h
> > > @@ -52,7 +52,8 @@ struct virtio_balloon_config {
> > >   #define VIRTIO_BALLOON_S_MEMFREE  4   /* Total amount of free memory */
> > >   #define VIRTIO_BALLOON_S_MEMTOT   5   /* Total amount of memory */
> > >   #define VIRTIO_BALLOON_S_AVAIL    6   /* Available memory as in /proc */
> > > -#define VIRTIO_BALLOON_S_NR       7
> > > +#define VIRTIO_BALLOON_S_CACHES   7   /* Disk caches */
> 
> I've been wondering, VIRTIO_BALLOON_S_AVAIL is not in the virtio spec (see
> Section 5.5.6.3). It seems like this header file needs to be in sync with
> the virtio spec in order to make this change.
> 
> I have a similar change to add a new statistic and was wondering this.

Absolutely. Tomáš?

> > > +#define VIRTIO_BALLOON_S_NR       8
> > >   /*
> > >    * Memory statistics structure.
> > > -- 
> > > 2.15.1
> > > 
> > 
> > 
> 
> You need to add your new stat to the list of stats in
> docs/virtio-balloon-stats.txt.
> 
> Jon

Can't hurt, I agree.

-- 
MST

---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org


^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: [Qemu-devel] [PATCH v2 1/1] virtio-balloon: include statistics of disk/file caches
  2018-02-13 22:07         ` [virtio-dev] " Michael S. Tsirkin
@ 2018-02-19 13:11           ` Tomáš Golembiovský
  -1 siblings, 0 replies; 16+ messages in thread
From: Tomáš Golembiovský @ 2018-02-19 13:11 UTC (permalink / raw)
  To: Michael S. Tsirkin; +Cc: Jonathan Helman, virtio-dev, qemu-devel, Wei Wang

On Wed, 14 Feb 2018 00:07:53 +0200
"Michael S. Tsirkin" <mst@redhat.com> wrote:

> On Tue, Feb 13, 2018 at 12:29:39PM -0800, Jonathan Helman wrote:
> > 
> > 
> > On 02/05/2018 04:08 AM, Tomáš Golembiovský wrote:  
> > > ping
> > > 
> > > On Tue,  5 Dec 2017 13:14:46 +0100
> > > Tomáš Golembiovský <tgolembi@redhat.com> wrote:
> > >   
> > 
> > It would be good to include the corresponding upstream kernel change in the
> > commit message. This would be similar to a previous change:
> > https://lists.gnu.org/archive/html/qemu-devel/2016-02/msg05555.html  
> 
> good idea, but this has been merged by now.

Maybe next time, sorry.


> > > > Signed-off-by: Tomáš Golembiovský <tgolembi@redhat.com>
> > > > ---
> > > >   hw/virtio/virtio-balloon.c                      | 1 +
> > > >   include/standard-headers/linux/virtio_balloon.h | 3 ++-
> > > >   2 files changed, 3 insertions(+), 1 deletion(-)
> > > > 
> > > > diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c
> > > > index 37cde38982..8141326a51 100644
> > > > --- a/hw/virtio/virtio-balloon.c
> > > > +++ b/hw/virtio/virtio-balloon.c
> > > > @@ -50,6 +50,7 @@ static const char *balloon_stat_names[] = {
> > > >      [VIRTIO_BALLOON_S_MEMFREE] = "stat-free-memory",
> > > >      [VIRTIO_BALLOON_S_MEMTOT] = "stat-total-memory",
> > > >      [VIRTIO_BALLOON_S_AVAIL] = "stat-available-memory",
> > > > +   [VIRTIO_BALLOON_S_CACHES] = "stat-disk-caches",
> > > >      [VIRTIO_BALLOON_S_NR] = NULL
> > > >   };
> > > > diff --git a/include/standard-headers/linux/virtio_balloon.h b/include/standard-headers/linux/virtio_balloon.h
> > > > index 9d06ccd066..7b0a41b8fc 100644
> > > > --- a/include/standard-headers/linux/virtio_balloon.h
> > > > +++ b/include/standard-headers/linux/virtio_balloon.h
> > > > @@ -52,7 +52,8 @@ struct virtio_balloon_config {
> > > >   #define VIRTIO_BALLOON_S_MEMFREE  4   /* Total amount of free memory */
> > > >   #define VIRTIO_BALLOON_S_MEMTOT   5   /* Total amount of memory */
> > > >   #define VIRTIO_BALLOON_S_AVAIL    6   /* Available memory as in /proc */
> > > > -#define VIRTIO_BALLOON_S_NR       7
> > > > +#define VIRTIO_BALLOON_S_CACHES   7   /* Disk caches */  
> > 
> > I've been wondering, VIRTIO_BALLOON_S_AVAIL is not in the virtio spec (see
> > Section 5.5.6.3). It seems like this header file needs to be in sync with
> > the virtio spec in order to make this change.
> > 
> > I have a similar change to add a new statistic and was wondering this.  
> 
> Absolutely. Tomáš?

Sent. I also included description for the VIRTIO_BALLOON_S_AVAIL that
was missing.


> > > > +#define VIRTIO_BALLOON_S_NR       8
> > > >   /*
> > > >    * Memory statistics structure.
> > > > -- 
> > > > 2.15.1
> > > >   
> > > 
> > >   
> > 
> > You need to add your new stat to the list of stats in
> > docs/virtio-balloon-stats.txt.
> > 
> > Jon  
> 
> Can't hurt, I agree.

Sent.

    Tomas

-- 
Tomáš Golembiovský <tgolembi@redhat.com>

^ permalink raw reply	[flat|nested] 16+ messages in thread
* [virtio-dev] Re: [Qemu-devel] [PATCH v2 1/1] virtio-balloon: include statistics of disk/file caches
@ 2018-02-19 13:11           ` Tomáš Golembiovský
  0 siblings, 0 replies; 16+ messages in thread
From: Tomáš Golembiovský @ 2018-02-19 13:11 UTC (permalink / raw)
  To: Michael S. Tsirkin; +Cc: Jonathan Helman, virtio-dev, qemu-devel, Wei Wang

On Wed, 14 Feb 2018 00:07:53 +0200
"Michael S. Tsirkin" <mst@redhat.com> wrote:

> On Tue, Feb 13, 2018 at 12:29:39PM -0800, Jonathan Helman wrote:
> > 
> > 
> > On 02/05/2018 04:08 AM, Tomáš Golembiovský wrote:  
> > > ping
> > > 
> > > On Tue,  5 Dec 2017 13:14:46 +0100
> > > Tomáš Golembiovský <tgolembi@redhat.com> wrote:
> > >   
> > 
> > It would be good to include the corresponding upstream kernel change in the
> > commit message. This would be similar to a previous change:
> > https://lists.gnu.org/archive/html/qemu-devel/2016-02/msg05555.html  
> 
> good idea, but this has been merged by now.

Maybe next time, sorry.


> > > > Signed-off-by: Tomáš Golembiovský <tgolembi@redhat.com>
> > > > ---
> > > >   hw/virtio/virtio-balloon.c                      | 1 +
> > > >   include/standard-headers/linux/virtio_balloon.h | 3 ++-
> > > >   2 files changed, 3 insertions(+), 1 deletion(-)
> > > > 
> > > > diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c
> > > > index 37cde38982..8141326a51 100644
> > > > --- a/hw/virtio/virtio-balloon.c
> > > > +++ b/hw/virtio/virtio-balloon.c
> > > > @@ -50,6 +50,7 @@ static const char *balloon_stat_names[] = {
> > > >      [VIRTIO_BALLOON_S_MEMFREE] = "stat-free-memory",
> > > >      [VIRTIO_BALLOON_S_MEMTOT] = "stat-total-memory",
> > > >      [VIRTIO_BALLOON_S_AVAIL] = "stat-available-memory",
> > > > +   [VIRTIO_BALLOON_S_CACHES] = "stat-disk-caches",
> > > >      [VIRTIO_BALLOON_S_NR] = NULL
> > > >   };
> > > > diff --git a/include/standard-headers/linux/virtio_balloon.h b/include/standard-headers/linux/virtio_balloon.h
> > > > index 9d06ccd066..7b0a41b8fc 100644
> > > > --- a/include/standard-headers/linux/virtio_balloon.h
> > > > +++ b/include/standard-headers/linux/virtio_balloon.h
> > > > @@ -52,7 +52,8 @@ struct virtio_balloon_config {
> > > >   #define VIRTIO_BALLOON_S_MEMFREE  4   /* Total amount of free memory */
> > > >   #define VIRTIO_BALLOON_S_MEMTOT   5   /* Total amount of memory */
> > > >   #define VIRTIO_BALLOON_S_AVAIL    6   /* Available memory as in /proc */
> > > > -#define VIRTIO_BALLOON_S_NR       7
> > > > +#define VIRTIO_BALLOON_S_CACHES   7   /* Disk caches */  
> > 
> > I've been wondering, VIRTIO_BALLOON_S_AVAIL is not in the virtio spec (see
> > Section 5.5.6.3). It seems like this header file needs to be in sync with
> > the virtio spec in order to make this change.
> > 
> > I have a similar change to add a new statistic and was wondering this.  
> 
> Absolutely. Tomáš?

Sent. I also included description for the VIRTIO_BALLOON_S_AVAIL that
was missing.


> > > > +#define VIRTIO_BALLOON_S_NR       8
> > > >   /*
> > > >    * Memory statistics structure.
> > > > -- 
> > > > 2.15.1
> > > >   
> > > 
> > >   
> > 
> > You need to add your new stat to the list of stats in
> > docs/virtio-balloon-stats.txt.
> > 
> > Jon  
> 
> Can't hurt, I agree.

Sent.

    Tomas

-- 
Tomáš Golembiovský <tgolembi@redhat.com>

---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org


^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: [Qemu-devel] [PATCH v2 1/1] virtio-balloon: include statistics of disk/file caches
  2018-02-19 13:11           ` [virtio-dev] " Tomáš Golembiovský
@ 2018-02-20  5:11             ` Jonathan Helman
  -1 siblings, 0 replies; 16+ messages in thread
From: Jonathan Helman @ 2018-02-20  5:11 UTC (permalink / raw)
  To: Tomáš Golembiovský
  Cc: Michael S. Tsirkin, virtio-dev, Wei Wang, qemu-devel


> On Feb 19, 2018, at 5:11 AM, Tomáš Golembiovský <tgolembi@redhat.com> wrote:
> 
> On Wed, 14 Feb 2018 00:07:53 +0200
> "Michael S. Tsirkin" <mst@redhat.com> wrote:
> 
>> On Tue, Feb 13, 2018 at 12:29:39PM -0800, Jonathan Helman wrote:
>>> 
>>> 
>>> On 02/05/2018 04:08 AM, Tomáš Golembiovský wrote:  
>>>> ping
>>>> 
>>>> On Tue,  5 Dec 2017 13:14:46 +0100
>>>> Tomáš Golembiovský <tgolembi@redhat.com> wrote:
>>>> 
>>> 
>>> It would be good to include the corresponding upstream kernel change in the
>>> commit message. This would be similar to a previous change:
>>> https://lists.gnu.org/archive/html/qemu-devel/2016-02/msg05555.html  
>> 
>> good idea, but this has been merged by now.
> 
> Maybe next time, sorry.
> 
> 
>>>>> Signed-off-by: Tomáš Golembiovský <tgolembi@redhat.com>
>>>>> ---
>>>>>  hw/virtio/virtio-balloon.c                      | 1 +
>>>>>  include/standard-headers/linux/virtio_balloon.h | 3 ++-
>>>>>  2 files changed, 3 insertions(+), 1 deletion(-)
>>>>> 
>>>>> diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c
>>>>> index 37cde38982..8141326a51 100644
>>>>> --- a/hw/virtio/virtio-balloon.c
>>>>> +++ b/hw/virtio/virtio-balloon.c
>>>>> @@ -50,6 +50,7 @@ static const char *balloon_stat_names[] = {
>>>>>     [VIRTIO_BALLOON_S_MEMFREE] = "stat-free-memory",
>>>>>     [VIRTIO_BALLOON_S_MEMTOT] = "stat-total-memory",
>>>>>     [VIRTIO_BALLOON_S_AVAIL] = "stat-available-memory",
>>>>> +   [VIRTIO_BALLOON_S_CACHES] = "stat-disk-caches",
>>>>>     [VIRTIO_BALLOON_S_NR] = NULL
>>>>>  };
>>>>> diff --git a/include/standard-headers/linux/virtio_balloon.h b/include/standard-headers/linux/virtio_balloon.h
>>>>> index 9d06ccd066..7b0a41b8fc 100644
>>>>> --- a/include/standard-headers/linux/virtio_balloon.h
>>>>> +++ b/include/standard-headers/linux/virtio_balloon.h
>>>>> @@ -52,7 +52,8 @@ struct virtio_balloon_config {
>>>>>  #define VIRTIO_BALLOON_S_MEMFREE  4   /* Total amount of free memory */
>>>>>  #define VIRTIO_BALLOON_S_MEMTOT   5   /* Total amount of memory */
>>>>>  #define VIRTIO_BALLOON_S_AVAIL    6   /* Available memory as in /proc */
>>>>> -#define VIRTIO_BALLOON_S_NR       7
>>>>> +#define VIRTIO_BALLOON_S_CACHES   7   /* Disk caches */  
>>> 
>>> I've been wondering, VIRTIO_BALLOON_S_AVAIL is not in the virtio spec (see
>>> Section 5.5.6.3). It seems like this header file needs to be in sync with
>>> the virtio spec in order to make this change.
>>> 
>>> I have a similar change to add a new statistic and was wondering this.  
>> 
>> Absolutely. Tomáš?
> 
> Sent. I also included description for the VIRTIO_BALLOON_S_AVAIL that
> was missing.
> 
> 
>>>>> +#define VIRTIO_BALLOON_S_NR       8
>>>>>  /*
>>>>>   * Memory statistics structure.
>>>>> -- 
>>>>> 2.15.1
>>>>> 
>>>> 
>>>> 
>>> 
>>> You need to add your new stat to the list of stats in
>>> docs/virtio-balloon-stats.txt.
>>> 
>>> Jon  
>> 
>> Can't hurt, I agree.
> 
> Sent.
> 

Awesome, thank you.

Do you also plan to make the commensurate changes in libvirt, or did I just miss the patch?

Jon

>    Tomas
> 
> -- 
> Tomáš Golembiovský <tgolembi@redhat.com>

^ permalink raw reply	[flat|nested] 16+ messages in thread
* [virtio-dev] Re: [Qemu-devel] [PATCH v2 1/1] virtio-balloon: include statistics of disk/file caches
@ 2018-02-20  5:11             ` Jonathan Helman
  0 siblings, 0 replies; 16+ messages in thread
From: Jonathan Helman @ 2018-02-20  5:11 UTC (permalink / raw)
  To: Tomáš Golembiovský
  Cc: Michael S. Tsirkin, virtio-dev, Wei Wang, qemu-devel


> On Feb 19, 2018, at 5:11 AM, Tomáš Golembiovský <tgolembi@redhat.com> wrote:
> 
> On Wed, 14 Feb 2018 00:07:53 +0200
> "Michael S. Tsirkin" <mst@redhat.com> wrote:
> 
>> On Tue, Feb 13, 2018 at 12:29:39PM -0800, Jonathan Helman wrote:
>>> 
>>> 
>>> On 02/05/2018 04:08 AM, Tomáš Golembiovský wrote:  
>>>> ping
>>>> 
>>>> On Tue,  5 Dec 2017 13:14:46 +0100
>>>> Tomáš Golembiovský <tgolembi@redhat.com> wrote:
>>>> 
>>> 
>>> It would be good to include the corresponding upstream kernel change in the
>>> commit message. This would be similar to a previous change:
>>> https://lists.gnu.org/archive/html/qemu-devel/2016-02/msg05555.html  
>> 
>> good idea, but this has been merged by now.
> 
> Maybe next time, sorry.
> 
> 
>>>>> Signed-off-by: Tomáš Golembiovský <tgolembi@redhat.com>
>>>>> ---
>>>>>  hw/virtio/virtio-balloon.c                      | 1 +
>>>>>  include/standard-headers/linux/virtio_balloon.h | 3 ++-
>>>>>  2 files changed, 3 insertions(+), 1 deletion(-)
>>>>> 
>>>>> diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c
>>>>> index 37cde38982..8141326a51 100644
>>>>> --- a/hw/virtio/virtio-balloon.c
>>>>> +++ b/hw/virtio/virtio-balloon.c
>>>>> @@ -50,6 +50,7 @@ static const char *balloon_stat_names[] = {
>>>>>     [VIRTIO_BALLOON_S_MEMFREE] = "stat-free-memory",
>>>>>     [VIRTIO_BALLOON_S_MEMTOT] = "stat-total-memory",
>>>>>     [VIRTIO_BALLOON_S_AVAIL] = "stat-available-memory",
>>>>> +   [VIRTIO_BALLOON_S_CACHES] = "stat-disk-caches",
>>>>>     [VIRTIO_BALLOON_S_NR] = NULL
>>>>>  };
>>>>> diff --git a/include/standard-headers/linux/virtio_balloon.h b/include/standard-headers/linux/virtio_balloon.h
>>>>> index 9d06ccd066..7b0a41b8fc 100644
>>>>> --- a/include/standard-headers/linux/virtio_balloon.h
>>>>> +++ b/include/standard-headers/linux/virtio_balloon.h
>>>>> @@ -52,7 +52,8 @@ struct virtio_balloon_config {
>>>>>  #define VIRTIO_BALLOON_S_MEMFREE  4   /* Total amount of free memory */
>>>>>  #define VIRTIO_BALLOON_S_MEMTOT   5   /* Total amount of memory */
>>>>>  #define VIRTIO_BALLOON_S_AVAIL    6   /* Available memory as in /proc */
>>>>> -#define VIRTIO_BALLOON_S_NR       7
>>>>> +#define VIRTIO_BALLOON_S_CACHES   7   /* Disk caches */  
>>> 
>>> I've been wondering, VIRTIO_BALLOON_S_AVAIL is not in the virtio spec (see
>>> Section 5.5.6.3). It seems like this header file needs to be in sync with
>>> the virtio spec in order to make this change.
>>> 
>>> I have a similar change to add a new statistic and was wondering this.  
>> 
>> Absolutely. Tomáš?
> 
> Sent. I also included description for the VIRTIO_BALLOON_S_AVAIL that
> was missing.
> 
> 
>>>>> +#define VIRTIO_BALLOON_S_NR       8
>>>>>  /*
>>>>>   * Memory statistics structure.
>>>>> -- 
>>>>> 2.15.1
>>>>> 
>>>> 
>>>> 
>>> 
>>> You need to add your new stat to the list of stats in
>>> docs/virtio-balloon-stats.txt.
>>> 
>>> Jon  
>> 
>> Can't hurt, I agree.
> 
> Sent.
> 

Awesome, thank you.

Do you also plan to make the commensurate changes in libvirt, or did I just miss the patch?

Jon

>    Tomas
> 
> -- 
> Tomáš Golembiovský <tgolembi@redhat.com>


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org


^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: [Qemu-devel] [PATCH v2 1/1] virtio-balloon: include statistics of disk/file caches
  2018-02-20  5:11             ` [virtio-dev] " Jonathan Helman
@ 2018-02-20 11:15               ` Tomáš Golembiovský
  -1 siblings, 0 replies; 16+ messages in thread
From: Tomáš Golembiovský @ 2018-02-20 11:15 UTC (permalink / raw)
  To: Jonathan Helman; +Cc: Michael S. Tsirkin, virtio-dev, Wei Wang, qemu-devel

On Mon, 19 Feb 2018 21:11:27 -0800
Jonathan Helman <jonathan.helman@oracle.com> wrote:

> > On Feb 19, 2018, at 5:11 AM, Tomáš Golembiovský <tgolembi@redhat.com> wrote:
> > 
> > On Wed, 14 Feb 2018 00:07:53 +0200
> > "Michael S. Tsirkin" <mst@redhat.com> wrote:
> >   
> >> On Tue, Feb 13, 2018 at 12:29:39PM -0800, Jonathan Helman wrote:  
> >>> 
> >>> 
> >>> On 02/05/2018 04:08 AM, Tomáš Golembiovský wrote:    
> >>>> ping
> >>>> 
> >>>> On Tue,  5 Dec 2017 13:14:46 +0100
> >>>> Tomáš Golembiovský <tgolembi@redhat.com> wrote:
> >>>>   
> >>> 
> >>> It would be good to include the corresponding upstream kernel change in the
> >>> commit message. This would be similar to a previous change:
> >>> https://lists.gnu.org/archive/html/qemu-devel/2016-02/msg05555.html    
> >> 
> >> good idea, but this has been merged by now.  
> > 
> > Maybe next time, sorry.
> > 
> >   
> >>>>> Signed-off-by: Tomáš Golembiovský <tgolembi@redhat.com>
> >>>>> ---
> >>>>>  hw/virtio/virtio-balloon.c                      | 1 +
> >>>>>  include/standard-headers/linux/virtio_balloon.h | 3 ++-
> >>>>>  2 files changed, 3 insertions(+), 1 deletion(-)
> >>>>> 
> >>>>> diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c
> >>>>> index 37cde38982..8141326a51 100644
> >>>>> --- a/hw/virtio/virtio-balloon.c
> >>>>> +++ b/hw/virtio/virtio-balloon.c
> >>>>> @@ -50,6 +50,7 @@ static const char *balloon_stat_names[] = {
> >>>>>     [VIRTIO_BALLOON_S_MEMFREE] = "stat-free-memory",
> >>>>>     [VIRTIO_BALLOON_S_MEMTOT] = "stat-total-memory",
> >>>>>     [VIRTIO_BALLOON_S_AVAIL] = "stat-available-memory",
> >>>>> +   [VIRTIO_BALLOON_S_CACHES] = "stat-disk-caches",
> >>>>>     [VIRTIO_BALLOON_S_NR] = NULL
> >>>>>  };
> >>>>> diff --git a/include/standard-headers/linux/virtio_balloon.h b/include/standard-headers/linux/virtio_balloon.h
> >>>>> index 9d06ccd066..7b0a41b8fc 100644
> >>>>> --- a/include/standard-headers/linux/virtio_balloon.h
> >>>>> +++ b/include/standard-headers/linux/virtio_balloon.h
> >>>>> @@ -52,7 +52,8 @@ struct virtio_balloon_config {
> >>>>>  #define VIRTIO_BALLOON_S_MEMFREE  4   /* Total amount of free memory */
> >>>>>  #define VIRTIO_BALLOON_S_MEMTOT   5   /* Total amount of memory */
> >>>>>  #define VIRTIO_BALLOON_S_AVAIL    6   /* Available memory as in /proc */
> >>>>> -#define VIRTIO_BALLOON_S_NR       7
> >>>>> +#define VIRTIO_BALLOON_S_CACHES   7   /* Disk caches */    
> >>> 
> >>> I've been wondering, VIRTIO_BALLOON_S_AVAIL is not in the virtio spec (see
> >>> Section 5.5.6.3). It seems like this header file needs to be in sync with
> >>> the virtio spec in order to make this change.
> >>> 
> >>> I have a similar change to add a new statistic and was wondering this.    
> >> 
> >> Absolutely. Tomáš?  
> > 
> > Sent. I also included description for the VIRTIO_BALLOON_S_AVAIL that
> > was missing.
> > 
> >   
> >>>>> +#define VIRTIO_BALLOON_S_NR       8
> >>>>>  /*
> >>>>>   * Memory statistics structure.
> >>>>> -- 
> >>>>> 2.15.1
> >>>>>   
> >>>> 
> >>>>   
> >>> 
> >>> You need to add your new stat to the list of stats in
> >>> docs/virtio-balloon-stats.txt.
> >>> 
> >>> Jon    
> >> 
> >> Can't hurt, I agree.  
> > 
> > Sent.
> >   
> 
> Awesome, thank you.
> 
> Do you also plan to make the commensurate changes in libvirt, or did I just miss the patch?

Yes, I do. I just didn't get to it yet.

    Tomas

> 
> Jon
> 
> >    Tomas
> > 
> > -- 
> > Tomáš Golembiovský <tgolembi@redhat.com>  
> 


-- 
Tomáš Golembiovský <tgolembi@redhat.com>

^ permalink raw reply	[flat|nested] 16+ messages in thread
* [virtio-dev] Re: [Qemu-devel] [PATCH v2 1/1] virtio-balloon: include statistics of disk/file caches
@ 2018-02-20 11:15               ` Tomáš Golembiovský
  0 siblings, 0 replies; 16+ messages in thread
From: Tomáš Golembiovský @ 2018-02-20 11:15 UTC (permalink / raw)
  To: Jonathan Helman; +Cc: Michael S. Tsirkin, virtio-dev, Wei Wang, qemu-devel

On Mon, 19 Feb 2018 21:11:27 -0800
Jonathan Helman <jonathan.helman@oracle.com> wrote:

> > On Feb 19, 2018, at 5:11 AM, Tomáš Golembiovský <tgolembi@redhat.com> wrote:
> > 
> > On Wed, 14 Feb 2018 00:07:53 +0200
> > "Michael S. Tsirkin" <mst@redhat.com> wrote:
> >   
> >> On Tue, Feb 13, 2018 at 12:29:39PM -0800, Jonathan Helman wrote:  
> >>> 
> >>> 
> >>> On 02/05/2018 04:08 AM, Tomáš Golembiovský wrote:    
> >>>> ping
> >>>> 
> >>>> On Tue,  5 Dec 2017 13:14:46 +0100
> >>>> Tomáš Golembiovský <tgolembi@redhat.com> wrote:
> >>>>   
> >>> 
> >>> It would be good to include the corresponding upstream kernel change in the
> >>> commit message. This would be similar to a previous change:
> >>> https://lists.gnu.org/archive/html/qemu-devel/2016-02/msg05555.html    
> >> 
> >> good idea, but this has been merged by now.  
> > 
> > Maybe next time, sorry.
> > 
> >   
> >>>>> Signed-off-by: Tomáš Golembiovský <tgolembi@redhat.com>
> >>>>> ---
> >>>>>  hw/virtio/virtio-balloon.c                      | 1 +
> >>>>>  include/standard-headers/linux/virtio_balloon.h | 3 ++-
> >>>>>  2 files changed, 3 insertions(+), 1 deletion(-)
> >>>>> 
> >>>>> diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c
> >>>>> index 37cde38982..8141326a51 100644
> >>>>> --- a/hw/virtio/virtio-balloon.c
> >>>>> +++ b/hw/virtio/virtio-balloon.c
> >>>>> @@ -50,6 +50,7 @@ static const char *balloon_stat_names[] = {
> >>>>>     [VIRTIO_BALLOON_S_MEMFREE] = "stat-free-memory",
> >>>>>     [VIRTIO_BALLOON_S_MEMTOT] = "stat-total-memory",
> >>>>>     [VIRTIO_BALLOON_S_AVAIL] = "stat-available-memory",
> >>>>> +   [VIRTIO_BALLOON_S_CACHES] = "stat-disk-caches",
> >>>>>     [VIRTIO_BALLOON_S_NR] = NULL
> >>>>>  };
> >>>>> diff --git a/include/standard-headers/linux/virtio_balloon.h b/include/standard-headers/linux/virtio_balloon.h
> >>>>> index 9d06ccd066..7b0a41b8fc 100644
> >>>>> --- a/include/standard-headers/linux/virtio_balloon.h
> >>>>> +++ b/include/standard-headers/linux/virtio_balloon.h
> >>>>> @@ -52,7 +52,8 @@ struct virtio_balloon_config {
> >>>>>  #define VIRTIO_BALLOON_S_MEMFREE  4   /* Total amount of free memory */
> >>>>>  #define VIRTIO_BALLOON_S_MEMTOT   5   /* Total amount of memory */
> >>>>>  #define VIRTIO_BALLOON_S_AVAIL    6   /* Available memory as in /proc */
> >>>>> -#define VIRTIO_BALLOON_S_NR       7
> >>>>> +#define VIRTIO_BALLOON_S_CACHES   7   /* Disk caches */    
> >>> 
> >>> I've been wondering, VIRTIO_BALLOON_S_AVAIL is not in the virtio spec (see
> >>> Section 5.5.6.3). It seems like this header file needs to be in sync with
> >>> the virtio spec in order to make this change.
> >>> 
> >>> I have a similar change to add a new statistic and was wondering this.    
> >> 
> >> Absolutely. Tomáš?  
> > 
> > Sent. I also included description for the VIRTIO_BALLOON_S_AVAIL that
> > was missing.
> > 
> >   
> >>>>> +#define VIRTIO_BALLOON_S_NR       8
> >>>>>  /*
> >>>>>   * Memory statistics structure.
> >>>>> -- 
> >>>>> 2.15.1
> >>>>>   
> >>>> 
> >>>>   
> >>> 
> >>> You need to add your new stat to the list of stats in
> >>> docs/virtio-balloon-stats.txt.
> >>> 
> >>> Jon    
> >> 
> >> Can't hurt, I agree.  
> > 
> > Sent.
> >   
> 
> Awesome, thank you.
> 
> Do you also plan to make the commensurate changes in libvirt, or did I just miss the patch?

Yes, I do. I just didn't get to it yet.

    Tomas

> 
> Jon
> 
> >    Tomas
> > 
> > -- 
> > Tomáš Golembiovský <tgolembi@redhat.com>  
> 


-- 
Tomáš Golembiovský <tgolembi@redhat.com>

---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org


^ permalink raw reply	[flat|nested] 16+ messages in thread
end of thread, other threads:[~2018-02-20 11:15 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-05 12:14 [Qemu-devel] [PATCH v2 0/1] Disk caches in VirtIO Balloon driver stats Tomáš Golembiovský
2017-12-05 12:14 ` [virtio-dev] " Tomáš Golembiovský
2017-12-05 12:14 ` [Qemu-devel] [PATCH v2 1/1] virtio-balloon: include statistics of disk/file caches Tomáš Golembiovský
2017-12-05 12:14   ` [virtio-dev] " Tomáš Golembiovský
2018-02-05 12:08   ` [Qemu-devel] " Tomáš Golembiovský
2018-02-05 12:08     ` [virtio-dev] " Tomáš Golembiovský
2018-02-13 20:29     ` [Qemu-devel] " Jonathan Helman
2018-02-13 20:29       ` [virtio-dev] " Jonathan Helman
2018-02-13 22:07       ` Michael S. Tsirkin
2018-02-13 22:07         ` [virtio-dev] " Michael S. Tsirkin
2018-02-19 13:11         ` Tomáš Golembiovský
2018-02-19 13:11           ` [virtio-dev] " Tomáš Golembiovský
2018-02-20  5:11           ` Jonathan Helman
2018-02-20  5:11             ` [virtio-dev] " Jonathan Helman
2018-02-20 11:15             ` Tomáš Golembiovský
2018-02-20 11:15               ` [virtio-dev] " Tomáš Golembiovský

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.