All of lore.kernel.org
 help / color / mirror / Atom feed
* [PULL] provide debug sources in externalsrc -dbg packages
@ 2018-04-19  4:26 Vignesh Rajendran
  2018-04-19  4:26 ` [PULL] package.bbclass: " Vignesh Rajendran
  0 siblings, 1 reply; 11+ messages in thread
From: Vignesh Rajendran @ 2018-04-19  4:26 UTC (permalink / raw)
  To: poky

Hi Yocto,

  I have made some changes to fix missing debug sources in -dbg packages while using externalsrc.
Please have look and let me know for any changes needed.

  Thanks. :-)

the changes are available in the git repository at:

  https://git.yoctoproject.org/git/poky-contrib vrajendran/externalsrc-debugsrc
  http://git.yoctoproject.org/cgit.cgi//log/?h=vrajendran/externalsrc-debugsrc

Vignesh Rajendran (1):
  package.bbclass: provide debug sources in externalsrc -dbg packages

 meta/classes/externalsrc.bbclass |  3 +++
 meta/classes/package.bbclass     | 14 +++++++++++---
 2 files changed, 14 insertions(+), 3 deletions(-)

-- 
2.7.4



^ permalink raw reply	[flat|nested] 11+ messages in thread
* [PULL] package.bbclass: provide debug sources in externalsrc -dbg packages
  2018-04-19  4:26 [PULL] provide debug sources in externalsrc -dbg packages Vignesh Rajendran
@ 2018-04-19  4:26 ` Vignesh Rajendran
  2018-04-19  7:26   ` Peter Kjellerstedt
  0 siblings, 1 reply; 11+ messages in thread
From: Vignesh Rajendran @ 2018-04-19  4:26 UTC (permalink / raw)
  To: poky

The recipes which are using externalsrc method doesn't contain the
debug sources in their -dbg packages.

Add a handling in copydebugsources function to copy the debugsources for
externalsrc -dbg packages.

Signed-off-by: Vignesh Rajendran <vignesh.rajendran@in.bosch.com>
---
 meta/classes/externalsrc.bbclass |  3 +++
 meta/classes/package.bbclass     | 14 +++++++++++---
 2 files changed, 14 insertions(+), 3 deletions(-)

diff --git a/meta/classes/externalsrc.bbclass b/meta/classes/externalsrc.bbclass
index 3f1d396..042f935 100644
--- a/meta/classes/externalsrc.bbclass
+++ b/meta/classes/externalsrc.bbclass
@@ -126,6 +126,9 @@ python () {
             d.setVar('CONFIGURESTAMPFILE', configstamp)
             d.setVar('STAMP', '${STAMPS_DIR}/work-shared/${PN}/${EXTENDPE}${PV}-${PR}')
             d.setVar('STAMPCLEAN', '${STAMPS_DIR}/work-shared/${PN}/*-*')
+
+	# set DEBUG_PREFIX_MAP to external source path
+	d.appendVar("DEBUG_PREFIX_MAP", "-fdebug-prefix-map=${EXTERNALSRC}=/usr/src/debug/${PN}/${EXTENDPE}${PV}-${PR}")
 }
 
 python externalsrc_configure_prefunc() {
diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass
index 504c023..9466a4b 100644
--- a/meta/classes/package.bbclass
+++ b/meta/classes/package.bbclass
@@ -414,6 +414,7 @@ def copydebugsources(debugsrcdir, d):
         workdir = d.getVar("WORKDIR")
         workparentdir = os.path.dirname(os.path.dirname(workdir))
         workbasedir = os.path.basename(os.path.dirname(workdir)) + "/" + os.path.basename(workdir)
+	externalsrc = d.getVar('EXTERNALSRC', True)
 
         # If build path exists in sourcefile, it means toolchain did not use
         # -fdebug-prefix-map to compile
@@ -438,10 +439,17 @@ def copydebugsources(debugsrcdir, d):
         processdebugsrc += "fgrep -zw '%s' | "
         # Remove prefix in the source paths
         processdebugsrc += "sed 's#%s##g' | "
-        processdebugsrc += "(cd '%s' ; cpio -pd0mlL --no-preserve-owner '%s%s' 2>/dev/null)"
+        # handle external sources to provide sources in -dbg packages
+        if externalsrc:
+            localsrc_prefix = "/usr/src/debug/"
+            processdebugsrc += "sed 's#%s/##g' | "
+            processdebugsrc += "(cd '%s' ; cpio -pd0mlL --no-preserve-owner '%s%s/%s' 2>/dev/null)"
+            cmd = processdebugsrc % (sourcefile, workbasedir, localsrc_prefix, workbasedir, externalsrc, dvar, debugsrcdir, workbasedir)
+        else:
+            processdebugsrc += "(cd '%s' ; cpio -pd0mlL --no-preserve-owner '%s%s' 2>/dev/null)"
+            cmd = processdebugsrc % (sourcefile, workbasedir, localsrc_prefix, workparentdir, dvar, debugsrcdir)
 
-        cmd = processdebugsrc % (sourcefile, workbasedir, localsrc_prefix, workparentdir, dvar, debugsrcdir)
-        (retval, output) = oe.utils.getstatusoutput(cmd)
+	(retval, output) = oe.utils.getstatusoutput(cmd)
         # Can "fail" if internal headers/transient sources are attempted
         #if retval:
         #    bb.fatal("debug source copy failed with exit code %s (cmd was %s)" % (retval, cmd))
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 11+ messages in thread
* Re: [PULL] package.bbclass: provide debug sources in externalsrc -dbg packages
  2018-04-19  4:26 ` [PULL] package.bbclass: " Vignesh Rajendran
@ 2018-04-19  7:26   ` Peter Kjellerstedt
  2018-04-19  9:24     ` Vignesh Rajendran (RBEI/ECF3)
  2018-04-24  4:38     ` Vignesh Rajendran (RBEI/ECF3)
  0 siblings, 2 replies; 11+ messages in thread
From: Peter Kjellerstedt @ 2018-04-19  7:26 UTC (permalink / raw)
  To: Vignesh Rajendran, poky

> -----Original Message-----
> From: poky-bounces@yoctoproject.org [mailto:poky-
> bounces@yoctoproject.org] On Behalf Of Vignesh Rajendran
> Sent: den 19 april 2018 06:27
> To: poky@yoctoproject.org
> Subject: [poky] [PULL] package.bbclass: provide debug sources in externalsrc -dbg packages
> 
> The recipes which are using externalsrc method doesn't contain the
> debug sources in their -dbg packages.
> 
> Add a handling in copydebugsources function to copy the debugsources for
> externalsrc -dbg packages.
> 
> Signed-off-by: Vignesh Rajendran <vignesh.rajendran@in.bosch.com>
> ---
>  meta/classes/externalsrc.bbclass |  3 +++
>  meta/classes/package.bbclass     | 14 +++++++++++---
>  2 files changed, 14 insertions(+), 3 deletions(-)
> 
> diff --git a/meta/classes/externalsrc.bbclass b/meta/classes/externalsrc.bbclass
> index 3f1d396..042f935 100644
> --- a/meta/classes/externalsrc.bbclass
> +++ b/meta/classes/externalsrc.bbclass
> @@ -126,6 +126,9 @@ python () {
>              d.setVar('CONFIGURESTAMPFILE', configstamp)
>              d.setVar('STAMP', '${STAMPS_DIR}/work-shared/${PN}/${EXTENDPE}${PV}-${PR}')
>              d.setVar('STAMPCLEAN', '${STAMPS_DIR}/work-shared/${PN}/*-*')
> +
> +	# set DEBUG_PREFIX_MAP to external source path
> +	d.appendVar("DEBUG_PREFIX_MAP", "-fdebug-prefix-map=${EXTERNALSRC}=/usr/src/debug/${PN}/${EXTENDPE}${PV}-${PR}")
>  }
> 
>  python externalsrc_configure_prefunc() {
> diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass
> index 504c023..9466a4b 100644
> --- a/meta/classes/package.bbclass
> +++ b/meta/classes/package.bbclass
> @@ -414,6 +414,7 @@ def copydebugsources(debugsrcdir, d):
>          workdir = d.getVar("WORKDIR")
>          workparentdir = os.path.dirname(os.path.dirname(workdir))
>          workbasedir = os.path.basename(os.path.dirname(workdir)) + "/" + os.path.basename(workdir)
> +	externalsrc = d.getVar('EXTERNALSRC', True)

Change the tab to spaces.

> 
>          # If build path exists in sourcefile, it means toolchain did not use
>          # -fdebug-prefix-map to compile
> @@ -438,10 +439,17 @@ def copydebugsources(debugsrcdir, d):
>          processdebugsrc += "fgrep -zw '%s' | "
>          # Remove prefix in the source paths
>          processdebugsrc += "sed 's#%s##g' | "
> -        processdebugsrc += "(cd '%s' ; cpio -pd0mlL --no-preserve-owner '%s%s' 2>/dev/null)"
> +        # handle external sources to provide sources in -dbg packages
> +        if externalsrc:
> +            localsrc_prefix = "/usr/src/debug/"
> +            processdebugsrc += "sed 's#%s/##g' | "
> +            processdebugsrc += "(cd '%s' ; cpio -pd0mlL --no-preserve-owner '%s%s/%s' 2>/dev/null)"
> +            cmd = processdebugsrc % (sourcefile, workbasedir, localsrc_prefix, workbasedir, externalsrc, dvar, debugsrcdir, workbasedir)
> +        else:
> +            processdebugsrc += "(cd '%s' ; cpio -pd0mlL --no-preserve-owner '%s%s' 2>/dev/null)"
> +            cmd = processdebugsrc % (sourcefile, workbasedir, localsrc_prefix, workparentdir, dvar, debugsrcdir)
> 
> -        cmd = processdebugsrc % (sourcefile, workbasedir, localsrc_prefix, workparentdir, dvar, debugsrcdir)
> -        (retval, output) = oe.utils.getstatusoutput(cmd)
> +	(retval, output) = oe.utils.getstatusoutput(cmd)

Change the tab to spaces.

>          # Can "fail" if internal headers/transient sources are attempted
>          #if retval:
>          #    bb.fatal("debug source copy failed with exit code %s (cmd was %s)" % (retval, cmd))
> --
> 2.7.4

//Peter



^ permalink raw reply	[flat|nested] 11+ messages in thread
* Re: [PULL] package.bbclass: provide debug sources in externalsrc -dbg packages
  2018-04-19  7:26   ` Peter Kjellerstedt
@ 2018-04-19  9:24     ` Vignesh Rajendran (RBEI/ECF3)
  2018-04-24  4:38     ` Vignesh Rajendran (RBEI/ECF3)
  1 sibling, 0 replies; 11+ messages in thread
From: Vignesh Rajendran (RBEI/ECF3) @ 2018-04-19  9:24 UTC (permalink / raw)
  To: Peter Kjellerstedt; +Cc: poky

Hi Peter,

I have removed the tabs and applied spaces in the mentioned lines.

Please see the changes here,
http://git.yoctoproject.org/cgit.cgi/poky-contrib/commit/?h=vrajendran/externalsrc-debugsrc&id=d835e41e35160941debaad4beff80b322ff60664

Patch:
package.bbclass: copydebugsources: remove tabs and apply spacevrajendran/externalsrc-debugsrc
Signed-off-by: Vignesh Rajendran <vignesh.rajendran@in.bosch.com>
Diffstat
-rw-r--r--	meta/classes/package.bbclass	4	
		
1 files changed, 2 insertions, 2 deletions
diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass
index 9466a4b..c76f6e4 100644
--- a/meta/classes/package.bbclass
+++ b/meta/classes/package.bbclass
@@ -414,7 +414,7 @@ def copydebugsources(debugsrcdir, d):
         workdir = d.getVar("WORKDIR")
         workparentdir = os.path.dirname(os.path.dirname(workdir))
         workbasedir = os.path.basename(os.path.dirname(workdir)) + "/" + os.path.basename(workdir)
-	externalsrc = d.getVar('EXTERNALSRC', True)
+        externalsrc = d.getVar('EXTERNALSRC', True)
 
         # If build path exists in sourcefile, it means toolchain did not use
         # -fdebug-prefix-map to compile
@@ -449,7 +449,7 @@ def copydebugsources(debugsrcdir, d):
             processdebugsrc += "(cd '%s' ; cpio -pd0mlL --no-preserve-owner '%s%s' 2>/dev/null)"
             cmd = processdebugsrc % (sourcefile, workbasedir, localsrc_prefix, workparentdir, dvar, debugsrcdir)
 
-	(retval, output) = oe.utils.getstatusoutput(cmd)
+        (retval, output) = oe.utils.getstatusoutput(cmd)
         # Can "fail" if internal headers/transient sources are attempted
         #if retval:
         #    bb.fatal("debug source copy failed with exit code %s (cmd was %s)" % (retval, cmd))

Thank You.

Mit freundlichen Grüßen / Best regards

Rajendran Vignesh
RBEI/ECF33  

Tel. +91 422 67-65103 


-----Original Message-----
From: Peter Kjellerstedt [mailto:peter.kjellerstedt@axis.com] 
Sent: Thursday, April 19, 2018 12:57 PM
To: Vignesh Rajendran (RBEI/ECF3) <Vignesh.Rajendran@in.bosch.com>; poky@yoctoproject.org
Subject: RE: [poky] [PULL] package.bbclass: provide debug sources in externalsrc -dbg packages

> -----Original Message-----
> From: poky-bounces@yoctoproject.org [mailto:poky-
> bounces@yoctoproject.org] On Behalf Of Vignesh Rajendran
> Sent: den 19 april 2018 06:27
> To: poky@yoctoproject.org
> Subject: [poky] [PULL] package.bbclass: provide debug sources in externalsrc -dbg packages
> 
> The recipes which are using externalsrc method doesn't contain the
> debug sources in their -dbg packages.
> 
> Add a handling in copydebugsources function to copy the debugsources for
> externalsrc -dbg packages.
> 
> Signed-off-by: Vignesh Rajendran <vignesh.rajendran@in.bosch.com>
> ---
>  meta/classes/externalsrc.bbclass |  3 +++
>  meta/classes/package.bbclass     | 14 +++++++++++---
>  2 files changed, 14 insertions(+), 3 deletions(-)
> 
> diff --git a/meta/classes/externalsrc.bbclass b/meta/classes/externalsrc.bbclass
> index 3f1d396..042f935 100644
> --- a/meta/classes/externalsrc.bbclass
> +++ b/meta/classes/externalsrc.bbclass
> @@ -126,6 +126,9 @@ python () {
>              d.setVar('CONFIGURESTAMPFILE', configstamp)
>              d.setVar('STAMP', '${STAMPS_DIR}/work-shared/${PN}/${EXTENDPE}${PV}-${PR}')
>              d.setVar('STAMPCLEAN', '${STAMPS_DIR}/work-shared/${PN}/*-*')
> +
> +	# set DEBUG_PREFIX_MAP to external source path
> +	d.appendVar("DEBUG_PREFIX_MAP", "-fdebug-prefix-map=${EXTERNALSRC}=/usr/src/debug/${PN}/${EXTENDPE}${PV}-${PR}")
>  }
> 
>  python externalsrc_configure_prefunc() {
> diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass
> index 504c023..9466a4b 100644
> --- a/meta/classes/package.bbclass
> +++ b/meta/classes/package.bbclass
> @@ -414,6 +414,7 @@ def copydebugsources(debugsrcdir, d):
>          workdir = d.getVar("WORKDIR")
>          workparentdir = os.path.dirname(os.path.dirname(workdir))
>          workbasedir = os.path.basename(os.path.dirname(workdir)) + "/" + os.path.basename(workdir)
> +	externalsrc = d.getVar('EXTERNALSRC', True)

Change the tab to spaces.

> 
>          # If build path exists in sourcefile, it means toolchain did not use
>          # -fdebug-prefix-map to compile
> @@ -438,10 +439,17 @@ def copydebugsources(debugsrcdir, d):
>          processdebugsrc += "fgrep -zw '%s' | "
>          # Remove prefix in the source paths
>          processdebugsrc += "sed 's#%s##g' | "
> -        processdebugsrc += "(cd '%s' ; cpio -pd0mlL --no-preserve-owner '%s%s' 2>/dev/null)"
> +        # handle external sources to provide sources in -dbg packages
> +        if externalsrc:
> +            localsrc_prefix = "/usr/src/debug/"
> +            processdebugsrc += "sed 's#%s/##g' | "
> +            processdebugsrc += "(cd '%s' ; cpio -pd0mlL --no-preserve-owner '%s%s/%s' 2>/dev/null)"
> +            cmd = processdebugsrc % (sourcefile, workbasedir, localsrc_prefix, workbasedir, externalsrc, dvar, debugsrcdir, workbasedir)
> +        else:
> +            processdebugsrc += "(cd '%s' ; cpio -pd0mlL --no-preserve-owner '%s%s' 2>/dev/null)"
> +            cmd = processdebugsrc % (sourcefile, workbasedir, localsrc_prefix, workparentdir, dvar, debugsrcdir)
> 
> -        cmd = processdebugsrc % (sourcefile, workbasedir, localsrc_prefix, workparentdir, dvar, debugsrcdir)
> -        (retval, output) = oe.utils.getstatusoutput(cmd)
> +	(retval, output) = oe.utils.getstatusoutput(cmd)

Change the tab to spaces.

>          # Can "fail" if internal headers/transient sources are attempted
>          #if retval:
>          #    bb.fatal("debug source copy failed with exit code %s (cmd was %s)" % (retval, cmd))
> --
> 2.7.4

//Peter



^ permalink raw reply related	[flat|nested] 11+ messages in thread
* Re: [PULL] package.bbclass: provide debug sources in externalsrc -dbg packages
  2018-04-19  7:26   ` Peter Kjellerstedt
  2018-04-19  9:24     ` Vignesh Rajendran (RBEI/ECF3)
@ 2018-04-24  4:38     ` Vignesh Rajendran (RBEI/ECF3)
  2018-04-24 10:29       ` Peter Kjellerstedt
  1 sibling, 1 reply; 11+ messages in thread
From: Vignesh Rajendran (RBEI/ECF3) @ 2018-04-24  4:38 UTC (permalink / raw)
  To: Peter Kjellerstedt; +Cc: poky

Hi Peter, 

I couldn't see my changes not merged to poky-contrib  master yet.
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=vrajendran/externalsrc-debugsrc

As an  external developer, I am unaware of Yocto QA process to intake changes to master branch.

Do I missing something from my end?

Mit freundlichen Grüßen / Best regards

Rajendran Vignesh
RBEI/ECF33  

Tel. +91 422 67-65103 


-----Original Message-----
From: Vignesh Rajendran (RBEI/ECF3) 
Sent: Thursday, April 19, 2018 2:54 PM
To: 'Peter Kjellerstedt' <peter.kjellerstedt@axis.com>
Cc: poky@yoctoproject.org; Vignesh Rajendran (RBEI/ECF3) (Vignesh.Rajendran@in.bosch.com) <Vignesh.Rajendran@in.bosch.com>
Subject: RE: [poky] [PULL] package.bbclass: provide debug sources in externalsrc -dbg packages

Hi Peter,

I have removed the tabs and applied spaces in the mentioned lines.

Please see the changes here,
http://git.yoctoproject.org/cgit.cgi/poky-contrib/commit/?h=vrajendran/externalsrc-debugsrc&id=d835e41e35160941debaad4beff80b322ff60664

Patch:
package.bbclass: copydebugsources: remove tabs and apply spacevrajendran/externalsrc-debugsrc
Signed-off-by: Vignesh Rajendran <vignesh.rajendran@in.bosch.com>
Diffstat
-rw-r--r--	meta/classes/package.bbclass	4	
		
1 files changed, 2 insertions, 2 deletions
diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass
index 9466a4b..c76f6e4 100644
--- a/meta/classes/package.bbclass
+++ b/meta/classes/package.bbclass
@@ -414,7 +414,7 @@ def copydebugsources(debugsrcdir, d):
         workdir = d.getVar("WORKDIR")
         workparentdir = os.path.dirname(os.path.dirname(workdir))
         workbasedir = os.path.basename(os.path.dirname(workdir)) + "/" + os.path.basename(workdir)
-	externalsrc = d.getVar('EXTERNALSRC', True)
+        externalsrc = d.getVar('EXTERNALSRC', True)
 
         # If build path exists in sourcefile, it means toolchain did not use
         # -fdebug-prefix-map to compile
@@ -449,7 +449,7 @@ def copydebugsources(debugsrcdir, d):
             processdebugsrc += "(cd '%s' ; cpio -pd0mlL --no-preserve-owner '%s%s' 2>/dev/null)"
             cmd = processdebugsrc % (sourcefile, workbasedir, localsrc_prefix, workparentdir, dvar, debugsrcdir)
 
-	(retval, output) = oe.utils.getstatusoutput(cmd)
+        (retval, output) = oe.utils.getstatusoutput(cmd)
         # Can "fail" if internal headers/transient sources are attempted
         #if retval:
         #    bb.fatal("debug source copy failed with exit code %s (cmd was %s)" % (retval, cmd))

Thank You.

Mit freundlichen Grüßen / Best regards

Rajendran Vignesh
RBEI/ECF33  

Tel. +91 422 67-65103 


-----Original Message-----
From: Peter Kjellerstedt [mailto:peter.kjellerstedt@axis.com] 
Sent: Thursday, April 19, 2018 12:57 PM
To: Vignesh Rajendran (RBEI/ECF3) <Vignesh.Rajendran@in.bosch.com>; poky@yoctoproject.org
Subject: RE: [poky] [PULL] package.bbclass: provide debug sources in externalsrc -dbg packages

> -----Original Message-----
> From: poky-bounces@yoctoproject.org [mailto:poky-
> bounces@yoctoproject.org] On Behalf Of Vignesh Rajendran
> Sent: den 19 april 2018 06:27
> To: poky@yoctoproject.org
> Subject: [poky] [PULL] package.bbclass: provide debug sources in externalsrc -dbg packages
> 
> The recipes which are using externalsrc method doesn't contain the
> debug sources in their -dbg packages.
> 
> Add a handling in copydebugsources function to copy the debugsources for
> externalsrc -dbg packages.
> 
> Signed-off-by: Vignesh Rajendran <vignesh.rajendran@in.bosch.com>
> ---
>  meta/classes/externalsrc.bbclass |  3 +++
>  meta/classes/package.bbclass     | 14 +++++++++++---
>  2 files changed, 14 insertions(+), 3 deletions(-)
> 
> diff --git a/meta/classes/externalsrc.bbclass b/meta/classes/externalsrc.bbclass
> index 3f1d396..042f935 100644
> --- a/meta/classes/externalsrc.bbclass
> +++ b/meta/classes/externalsrc.bbclass
> @@ -126,6 +126,9 @@ python () {
>              d.setVar('CONFIGURESTAMPFILE', configstamp)
>              d.setVar('STAMP', '${STAMPS_DIR}/work-shared/${PN}/${EXTENDPE}${PV}-${PR}')
>              d.setVar('STAMPCLEAN', '${STAMPS_DIR}/work-shared/${PN}/*-*')
> +
> +	# set DEBUG_PREFIX_MAP to external source path
> +	d.appendVar("DEBUG_PREFIX_MAP", "-fdebug-prefix-map=${EXTERNALSRC}=/usr/src/debug/${PN}/${EXTENDPE}${PV}-${PR}")
>  }
> 
>  python externalsrc_configure_prefunc() {
> diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass
> index 504c023..9466a4b 100644
> --- a/meta/classes/package.bbclass
> +++ b/meta/classes/package.bbclass
> @@ -414,6 +414,7 @@ def copydebugsources(debugsrcdir, d):
>          workdir = d.getVar("WORKDIR")
>          workparentdir = os.path.dirname(os.path.dirname(workdir))
>          workbasedir = os.path.basename(os.path.dirname(workdir)) + "/" + os.path.basename(workdir)
> +	externalsrc = d.getVar('EXTERNALSRC', True)

Change the tab to spaces.

> 
>          # If build path exists in sourcefile, it means toolchain did not use
>          # -fdebug-prefix-map to compile
> @@ -438,10 +439,17 @@ def copydebugsources(debugsrcdir, d):
>          processdebugsrc += "fgrep -zw '%s' | "
>          # Remove prefix in the source paths
>          processdebugsrc += "sed 's#%s##g' | "
> -        processdebugsrc += "(cd '%s' ; cpio -pd0mlL --no-preserve-owner '%s%s' 2>/dev/null)"
> +        # handle external sources to provide sources in -dbg packages
> +        if externalsrc:
> +            localsrc_prefix = "/usr/src/debug/"
> +            processdebugsrc += "sed 's#%s/##g' | "
> +            processdebugsrc += "(cd '%s' ; cpio -pd0mlL --no-preserve-owner '%s%s/%s' 2>/dev/null)"
> +            cmd = processdebugsrc % (sourcefile, workbasedir, localsrc_prefix, workbasedir, externalsrc, dvar, debugsrcdir, workbasedir)
> +        else:
> +            processdebugsrc += "(cd '%s' ; cpio -pd0mlL --no-preserve-owner '%s%s' 2>/dev/null)"
> +            cmd = processdebugsrc % (sourcefile, workbasedir, localsrc_prefix, workparentdir, dvar, debugsrcdir)
> 
> -        cmd = processdebugsrc % (sourcefile, workbasedir, localsrc_prefix, workparentdir, dvar, debugsrcdir)
> -        (retval, output) = oe.utils.getstatusoutput(cmd)
> +	(retval, output) = oe.utils.getstatusoutput(cmd)

Change the tab to spaces.

>          # Can "fail" if internal headers/transient sources are attempted
>          #if retval:
>          #    bb.fatal("debug source copy failed with exit code %s (cmd was %s)" % (retval, cmd))
> --
> 2.7.4

//Peter



^ permalink raw reply related	[flat|nested] 11+ messages in thread
* Re: [PULL] package.bbclass: provide debug sources in externalsrc -dbg packages
  2018-04-24  4:38     ` Vignesh Rajendran (RBEI/ECF3)
@ 2018-04-24 10:29       ` Peter Kjellerstedt
  2018-04-25  5:36         ` Vignesh Rajendran (RBEI/ECF3)
  0 siblings, 1 reply; 11+ messages in thread
From: Peter Kjellerstedt @ 2018-04-24 10:29 UTC (permalink / raw)
  To: Vignesh Rajendran (RBEI/ECF3); +Cc: poky

I am in no way responsible for integrating anything to Poky. That 
will be handled by the maintainers. However, OE-Core (and thus 
Poky) is currently near its next release and because of that 
integrations are limited to a bare minimum. 

Additionally, this patch belongs on the 
openembedded-core@lists.openembedded.org list as it modifies a 
file in OE-Core.

//Peter

> -----Original Message-----
> From: Vignesh Rajendran (RBEI/ECF3)
> [mailto:Vignesh.Rajendran@in.bosch.com]
> Sent: den 24 april 2018 06:39
> To: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
> Cc: poky@yoctoproject.org
> Subject: RE: [poky] [PULL] package.bbclass: provide debug sources in
> externalsrc -dbg packages
> 
> Hi Peter,
> 
> I couldn't see my changes not merged to poky-contrib  master yet.
> http://git.yoctoproject.org/cgit.cgi/poky-
> contrib/log/?h=vrajendran/externalsrc-debugsrc
> 
> As an  external developer, I am unaware of Yocto QA process to intake
> changes to master branch.
> 
> Do I missing something from my end?
> 
> Mit freundlichen Grüßen / Best regards
> 
> Rajendran Vignesh
> RBEI/ECF33
> 
> Tel. +91 422 67-65103
> 
> 
> -----Original Message-----
> From: Vignesh Rajendran (RBEI/ECF3)
> Sent: Thursday, April 19, 2018 2:54 PM
> To: 'Peter Kjellerstedt' <peter.kjellerstedt@axis.com>
> Cc: poky@yoctoproject.org; Vignesh Rajendran (RBEI/ECF3)
> (Vignesh.Rajendran@in.bosch.com) <Vignesh.Rajendran@in.bosch.com>
> Subject: RE: [poky] [PULL] package.bbclass: provide debug sources in
> externalsrc -dbg packages
> 
> Hi Peter,
> 
> I have removed the tabs and applied spaces in the mentioned lines.
> 
> Please see the changes here,
> http://git.yoctoproject.org/cgit.cgi/poky-
> contrib/commit/?h=vrajendran/externalsrc-
> debugsrc&id=d835e41e35160941debaad4beff80b322ff60664
> 
> Patch:
> package.bbclass: copydebugsources: remove tabs and apply
> spacevrajendran/externalsrc-debugsrc
> Signed-off-by: Vignesh Rajendran <vignesh.rajendran@in.bosch.com>
> Diffstat
> -rw-r--r--	meta/classes/package.bbclass	4
> 
> 1 files changed, 2 insertions, 2 deletions
> diff --git a/meta/classes/package.bbclass
> b/meta/classes/package.bbclass
> index 9466a4b..c76f6e4 100644
> --- a/meta/classes/package.bbclass
> +++ b/meta/classes/package.bbclass
> @@ -414,7 +414,7 @@ def copydebugsources(debugsrcdir, d):
>          workdir = d.getVar("WORKDIR")
>          workparentdir = os.path.dirname(os.path.dirname(workdir))
>          workbasedir = os.path.basename(os.path.dirname(workdir)) + "/"
> + os.path.basename(workdir)
> -	externalsrc = d.getVar('EXTERNALSRC', True)
> +        externalsrc = d.getVar('EXTERNALSRC', True)
> 
>          # If build path exists in sourcefile, it means toolchain did
> not use
>          # -fdebug-prefix-map to compile
> @@ -449,7 +449,7 @@ def copydebugsources(debugsrcdir, d):
>              processdebugsrc += "(cd '%s' ; cpio -pd0mlL --no-preserve-
> owner '%s%s' 2>/dev/null)"
>              cmd = processdebugsrc % (sourcefile, workbasedir,
> localsrc_prefix, workparentdir, dvar, debugsrcdir)
> 
> -	(retval, output) = oe.utils.getstatusoutput(cmd)
> +        (retval, output) = oe.utils.getstatusoutput(cmd)
>          # Can "fail" if internal headers/transient sources are
> attempted
>          #if retval:
>          #    bb.fatal("debug source copy failed with exit code %s (cmd
> was %s)" % (retval, cmd))
> 
> Thank You.
> 
> Mit freundlichen Grüßen / Best regards
> 
> Rajendran Vignesh
> RBEI/ECF33
> 
> Tel. +91 422 67-65103
> 
> 
> -----Original Message-----
> From: Peter Kjellerstedt [mailto:peter.kjellerstedt@axis.com]
> Sent: Thursday, April 19, 2018 12:57 PM
> To: Vignesh Rajendran (RBEI/ECF3) <Vignesh.Rajendran@in.bosch.com>;
> poky@yoctoproject.org
> Subject: RE: [poky] [PULL] package.bbclass: provide debug sources in
> externalsrc -dbg packages
> 
> > -----Original Message-----
> > From: poky-bounces@yoctoproject.org [mailto:poky-
> > bounces@yoctoproject.org] On Behalf Of Vignesh Rajendran
> > Sent: den 19 april 2018 06:27
> > To: poky@yoctoproject.org
> > Subject: [poky] [PULL] package.bbclass: provide debug sources in
> externalsrc -dbg packages
> >
> > The recipes which are using externalsrc method doesn't contain the
> > debug sources in their -dbg packages.
> >
> > Add a handling in copydebugsources function to copy the debugsources
> for
> > externalsrc -dbg packages.
> >
> > Signed-off-by: Vignesh Rajendran <vignesh.rajendran@in.bosch.com>
> > ---
> >  meta/classes/externalsrc.bbclass |  3 +++
> >  meta/classes/package.bbclass     | 14 +++++++++++---
> >  2 files changed, 14 insertions(+), 3 deletions(-)
> >
> > diff --git a/meta/classes/externalsrc.bbclass
> b/meta/classes/externalsrc.bbclass
> > index 3f1d396..042f935 100644
> > --- a/meta/classes/externalsrc.bbclass
> > +++ b/meta/classes/externalsrc.bbclass
> > @@ -126,6 +126,9 @@ python () {
> >              d.setVar('CONFIGURESTAMPFILE', configstamp)
> >              d.setVar('STAMP', '${STAMPS_DIR}/work-
> shared/${PN}/${EXTENDPE}${PV}-${PR}')
> >              d.setVar('STAMPCLEAN', '${STAMPS_DIR}/work-
> shared/${PN}/*-*')
> > +
> > +	# set DEBUG_PREFIX_MAP to external source path
> > +	d.appendVar("DEBUG_PREFIX_MAP", "-fdebug-prefix-
> map=${EXTERNALSRC}=/usr/src/debug/${PN}/${EXTENDPE}${PV}-${PR}")
> >  }
> >
> >  python externalsrc_configure_prefunc() {
> > diff --git a/meta/classes/package.bbclass
> b/meta/classes/package.bbclass
> > index 504c023..9466a4b 100644
> > --- a/meta/classes/package.bbclass
> > +++ b/meta/classes/package.bbclass
> > @@ -414,6 +414,7 @@ def copydebugsources(debugsrcdir, d):
> >          workdir = d.getVar("WORKDIR")
> >          workparentdir = os.path.dirname(os.path.dirname(workdir))
> >          workbasedir = os.path.basename(os.path.dirname(workdir)) +
> "/" + os.path.basename(workdir)
> > +	externalsrc = d.getVar('EXTERNALSRC', True)
> 
> Change the tab to spaces.
> 
> >
> >          # If build path exists in sourcefile, it means toolchain did
> not use
> >          # -fdebug-prefix-map to compile
> > @@ -438,10 +439,17 @@ def copydebugsources(debugsrcdir, d):
> >          processdebugsrc += "fgrep -zw '%s' | "
> >          # Remove prefix in the source paths
> >          processdebugsrc += "sed 's#%s##g' | "
> > -        processdebugsrc += "(cd '%s' ; cpio -pd0mlL --no-preserve-
> owner '%s%s' 2>/dev/null)"
> > +        # handle external sources to provide sources in -dbg
> packages
> > +        if externalsrc:
> > +            localsrc_prefix = "/usr/src/debug/"
> > +            processdebugsrc += "sed 's#%s/##g' | "
> > +            processdebugsrc += "(cd '%s' ; cpio -pd0mlL --no-
> preserve-owner '%s%s/%s' 2>/dev/null)"
> > +            cmd = processdebugsrc % (sourcefile, workbasedir,
> localsrc_prefix, workbasedir, externalsrc, dvar, debugsrcdir,
> workbasedir)
> > +        else:
> > +            processdebugsrc += "(cd '%s' ; cpio -pd0mlL --no-
> preserve-owner '%s%s' 2>/dev/null)"
> > +            cmd = processdebugsrc % (sourcefile, workbasedir,
> localsrc_prefix, workparentdir, dvar, debugsrcdir)
> >
> > -        cmd = processdebugsrc % (sourcefile, workbasedir,
> localsrc_prefix, workparentdir, dvar, debugsrcdir)
> > -        (retval, output) = oe.utils.getstatusoutput(cmd)
> > +	(retval, output) = oe.utils.getstatusoutput(cmd)
> 
> Change the tab to spaces.
> 
> >          # Can "fail" if internal headers/transient sources are
> attempted
> >          #if retval:
> >          #    bb.fatal("debug source copy failed with exit code %s
> (cmd was %s)" % (retval, cmd))
> > --
> > 2.7.4
> 
> //Peter



^ permalink raw reply	[flat|nested] 11+ messages in thread
* Re: [PULL] package.bbclass: provide debug sources in externalsrc -dbg packages
  2018-04-24 10:29       ` Peter Kjellerstedt
@ 2018-04-25  5:36         ` Vignesh Rajendran (RBEI/ECF3)
  2018-05-02  6:27           ` Vignesh Rajendran (RBEI/ECF3)
  0 siblings, 1 reply; 11+ messages in thread
From: Vignesh Rajendran (RBEI/ECF3) @ 2018-04-25  5:36 UTC (permalink / raw)
  To: Peter Kjellerstedt; +Cc: poky

Hi Peter,

Oh, Sorry for asking you.
Thanks for the information anyway.

I hope it will take some time for merging :-(

Mit freundlichen Grüßen / Best regards

Rajendran Vignesh
RBEI/ECF33  

Tel. +91 422 67-65103 



-----Original Message-----
From: Peter Kjellerstedt [mailto:peter.kjellerstedt@axis.com] 
Sent: Tuesday, April 24, 2018 3:59 PM
To: Vignesh Rajendran (RBEI/ECF3) <Vignesh.Rajendran@in.bosch.com>
Cc: poky@yoctoproject.org
Subject: RE: [poky] [PULL] package.bbclass: provide debug sources in externalsrc -dbg packages

I am in no way responsible for integrating anything to Poky. That 
will be handled by the maintainers. However, OE-Core (and thus 
Poky) is currently near its next release and because of that 
integrations are limited to a bare minimum. 

Additionally, this patch belongs on the 
openembedded-core@lists.openembedded.org list as it modifies a 
file in OE-Core.

//Peter

> -----Original Message-----
> From: Vignesh Rajendran (RBEI/ECF3)
> [mailto:Vignesh.Rajendran@in.bosch.com]
> Sent: den 24 april 2018 06:39
> To: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
> Cc: poky@yoctoproject.org
> Subject: RE: [poky] [PULL] package.bbclass: provide debug sources in
> externalsrc -dbg packages
> 
> Hi Peter,
> 
> I couldn't see my changes not merged to poky-contrib  master yet.
> http://git.yoctoproject.org/cgit.cgi/poky-
> contrib/log/?h=vrajendran/externalsrc-debugsrc
> 
> As an  external developer, I am unaware of Yocto QA process to intake
> changes to master branch.
> 
> Do I missing something from my end?
> 
> Mit freundlichen Grüßen / Best regards
> 
> Rajendran Vignesh
> RBEI/ECF33
> 
> Tel. +91 422 67-65103
> 
> 
> -----Original Message-----
> From: Vignesh Rajendran (RBEI/ECF3)
> Sent: Thursday, April 19, 2018 2:54 PM
> To: 'Peter Kjellerstedt' <peter.kjellerstedt@axis.com>
> Cc: poky@yoctoproject.org; Vignesh Rajendran (RBEI/ECF3)
> (Vignesh.Rajendran@in.bosch.com) <Vignesh.Rajendran@in.bosch.com>
> Subject: RE: [poky] [PULL] package.bbclass: provide debug sources in
> externalsrc -dbg packages
> 
> Hi Peter,
> 
> I have removed the tabs and applied spaces in the mentioned lines.
> 
> Please see the changes here,
> http://git.yoctoproject.org/cgit.cgi/poky-
> contrib/commit/?h=vrajendran/externalsrc-
> debugsrc&id=d835e41e35160941debaad4beff80b322ff60664
> 
> Patch:
> package.bbclass: copydebugsources: remove tabs and apply
> spacevrajendran/externalsrc-debugsrc
> Signed-off-by: Vignesh Rajendran <vignesh.rajendran@in.bosch.com>
> Diffstat
> -rw-r--r--	meta/classes/package.bbclass	4
> 
> 1 files changed, 2 insertions, 2 deletions
> diff --git a/meta/classes/package.bbclass
> b/meta/classes/package.bbclass
> index 9466a4b..c76f6e4 100644
> --- a/meta/classes/package.bbclass
> +++ b/meta/classes/package.bbclass
> @@ -414,7 +414,7 @@ def copydebugsources(debugsrcdir, d):
>          workdir = d.getVar("WORKDIR")
>          workparentdir = os.path.dirname(os.path.dirname(workdir))
>          workbasedir = os.path.basename(os.path.dirname(workdir)) + "/"
> + os.path.basename(workdir)
> -	externalsrc = d.getVar('EXTERNALSRC', True)
> +        externalsrc = d.getVar('EXTERNALSRC', True)
> 
>          # If build path exists in sourcefile, it means toolchain did
> not use
>          # -fdebug-prefix-map to compile
> @@ -449,7 +449,7 @@ def copydebugsources(debugsrcdir, d):
>              processdebugsrc += "(cd '%s' ; cpio -pd0mlL --no-preserve-
> owner '%s%s' 2>/dev/null)"
>              cmd = processdebugsrc % (sourcefile, workbasedir,
> localsrc_prefix, workparentdir, dvar, debugsrcdir)
> 
> -	(retval, output) = oe.utils.getstatusoutput(cmd)
> +        (retval, output) = oe.utils.getstatusoutput(cmd)
>          # Can "fail" if internal headers/transient sources are
> attempted
>          #if retval:
>          #    bb.fatal("debug source copy failed with exit code %s (cmd
> was %s)" % (retval, cmd))
> 
> Thank You.
> 
> Mit freundlichen Grüßen / Best regards
> 
> Rajendran Vignesh
> RBEI/ECF33
> 
> Tel. +91 422 67-65103
> 
> 
> -----Original Message-----
> From: Peter Kjellerstedt [mailto:peter.kjellerstedt@axis.com]
> Sent: Thursday, April 19, 2018 12:57 PM
> To: Vignesh Rajendran (RBEI/ECF3) <Vignesh.Rajendran@in.bosch.com>;
> poky@yoctoproject.org
> Subject: RE: [poky] [PULL] package.bbclass: provide debug sources in
> externalsrc -dbg packages
> 
> > -----Original Message-----
> > From: poky-bounces@yoctoproject.org [mailto:poky-
> > bounces@yoctoproject.org] On Behalf Of Vignesh Rajendran
> > Sent: den 19 april 2018 06:27
> > To: poky@yoctoproject.org
> > Subject: [poky] [PULL] package.bbclass: provide debug sources in
> externalsrc -dbg packages
> >
> > The recipes which are using externalsrc method doesn't contain the
> > debug sources in their -dbg packages.
> >
> > Add a handling in copydebugsources function to copy the debugsources
> for
> > externalsrc -dbg packages.
> >
> > Signed-off-by: Vignesh Rajendran <vignesh.rajendran@in.bosch.com>
> > ---
> >  meta/classes/externalsrc.bbclass |  3 +++
> >  meta/classes/package.bbclass     | 14 +++++++++++---
> >  2 files changed, 14 insertions(+), 3 deletions(-)
> >
> > diff --git a/meta/classes/externalsrc.bbclass
> b/meta/classes/externalsrc.bbclass
> > index 3f1d396..042f935 100644
> > --- a/meta/classes/externalsrc.bbclass
> > +++ b/meta/classes/externalsrc.bbclass
> > @@ -126,6 +126,9 @@ python () {
> >              d.setVar('CONFIGURESTAMPFILE', configstamp)
> >              d.setVar('STAMP', '${STAMPS_DIR}/work-
> shared/${PN}/${EXTENDPE}${PV}-${PR}')
> >              d.setVar('STAMPCLEAN', '${STAMPS_DIR}/work-
> shared/${PN}/*-*')
> > +
> > +	# set DEBUG_PREFIX_MAP to external source path
> > +	d.appendVar("DEBUG_PREFIX_MAP", "-fdebug-prefix-
> map=${EXTERNALSRC}=/usr/src/debug/${PN}/${EXTENDPE}${PV}-${PR}")
> >  }
> >
> >  python externalsrc_configure_prefunc() {
> > diff --git a/meta/classes/package.bbclass
> b/meta/classes/package.bbclass
> > index 504c023..9466a4b 100644
> > --- a/meta/classes/package.bbclass
> > +++ b/meta/classes/package.bbclass
> > @@ -414,6 +414,7 @@ def copydebugsources(debugsrcdir, d):
> >          workdir = d.getVar("WORKDIR")
> >          workparentdir = os.path.dirname(os.path.dirname(workdir))
> >          workbasedir = os.path.basename(os.path.dirname(workdir)) +
> "/" + os.path.basename(workdir)
> > +	externalsrc = d.getVar('EXTERNALSRC', True)
> 
> Change the tab to spaces.
> 
> >
> >          # If build path exists in sourcefile, it means toolchain did
> not use
> >          # -fdebug-prefix-map to compile
> > @@ -438,10 +439,17 @@ def copydebugsources(debugsrcdir, d):
> >          processdebugsrc += "fgrep -zw '%s' | "
> >          # Remove prefix in the source paths
> >          processdebugsrc += "sed 's#%s##g' | "
> > -        processdebugsrc += "(cd '%s' ; cpio -pd0mlL --no-preserve-
> owner '%s%s' 2>/dev/null)"
> > +        # handle external sources to provide sources in -dbg
> packages
> > +        if externalsrc:
> > +            localsrc_prefix = "/usr/src/debug/"
> > +            processdebugsrc += "sed 's#%s/##g' | "
> > +            processdebugsrc += "(cd '%s' ; cpio -pd0mlL --no-
> preserve-owner '%s%s/%s' 2>/dev/null)"
> > +            cmd = processdebugsrc % (sourcefile, workbasedir,
> localsrc_prefix, workbasedir, externalsrc, dvar, debugsrcdir,
> workbasedir)
> > +        else:
> > +            processdebugsrc += "(cd '%s' ; cpio -pd0mlL --no-
> preserve-owner '%s%s' 2>/dev/null)"
> > +            cmd = processdebugsrc % (sourcefile, workbasedir,
> localsrc_prefix, workparentdir, dvar, debugsrcdir)
> >
> > -        cmd = processdebugsrc % (sourcefile, workbasedir,
> localsrc_prefix, workparentdir, dvar, debugsrcdir)
> > -        (retval, output) = oe.utils.getstatusoutput(cmd)
> > +	(retval, output) = oe.utils.getstatusoutput(cmd)
> 
> Change the tab to spaces.
> 
> >          # Can "fail" if internal headers/transient sources are
> attempted
> >          #if retval:
> >          #    bb.fatal("debug source copy failed with exit code %s
> (cmd was %s)" % (retval, cmd))
> > --
> > 2.7.4
> 
> //Peter



^ permalink raw reply	[flat|nested] 11+ messages in thread
* Re: [PULL] package.bbclass: provide debug sources in externalsrc -dbg packages
  2018-04-25  5:36         ` Vignesh Rajendran (RBEI/ECF3)
@ 2018-05-02  6:27           ` Vignesh Rajendran (RBEI/ECF3)
  2018-05-06 21:07             ` Paul Eggleton
  0 siblings, 1 reply; 11+ messages in thread
From: Vignesh Rajendran (RBEI/ECF3) @ 2018-05-02  6:27 UTC (permalink / raw)
  To: richard.purdie; +Cc: poky

@Richard Purdie:
Do I have to split my changes in externalsrc.bbclass to submit to OE-core?
http://git.yoctoproject.org/cgit.cgi/poky-contrib/commit/?h=vrajendran/externalsrc-debugsrc&id=e8d2f42f4a0ff11961e831d00caeb86a5efdbb13

As I don't have any update on merging, I want to know if anything messed-up from my end.

Sorry for any inconvenience.

Mit freundlichen Grüßen / Best regards

Rajendran Vignesh
RBEI/ECF33  

Tel. +91 422 67-65103 



-----Original Message-----
From: poky-bounces@yoctoproject.org [mailto:poky-bounces@yoctoproject.org] On Behalf Of Vignesh Rajendran (RBEI/ECF3)
Sent: Wednesday, April 25, 2018 11:06 AM
To: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
Cc: poky@yoctoproject.org
Subject: Re: [poky] [PULL] package.bbclass: provide debug sources in externalsrc -dbg packages

Hi Peter,

Oh, Sorry for asking you.
Thanks for the information anyway.

I hope it will take some time for merging :-(

Mit freundlichen Grüßen / Best regards

Rajendran Vignesh
RBEI/ECF33  

Tel. +91 422 67-65103 



-----Original Message-----
From: Peter Kjellerstedt [mailto:peter.kjellerstedt@axis.com] 
Sent: Tuesday, April 24, 2018 3:59 PM
To: Vignesh Rajendran (RBEI/ECF3) <Vignesh.Rajendran@in.bosch.com>
Cc: poky@yoctoproject.org
Subject: RE: [poky] [PULL] package.bbclass: provide debug sources in externalsrc -dbg packages

I am in no way responsible for integrating anything to Poky. That 
will be handled by the maintainers. However, OE-Core (and thus 
Poky) is currently near its next release and because of that 
integrations are limited to a bare minimum. 

Additionally, this patch belongs on the 
openembedded-core@lists.openembedded.org list as it modifies a 
file in OE-Core.

//Peter

> -----Original Message-----
> From: Vignesh Rajendran (RBEI/ECF3)
> [mailto:Vignesh.Rajendran@in.bosch.com]
> Sent: den 24 april 2018 06:39
> To: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
> Cc: poky@yoctoproject.org
> Subject: RE: [poky] [PULL] package.bbclass: provide debug sources in
> externalsrc -dbg packages
> 
> Hi Peter,
> 
> I couldn't see my changes not merged to poky-contrib  master yet.
> http://git.yoctoproject.org/cgit.cgi/poky-
> contrib/log/?h=vrajendran/externalsrc-debugsrc
> 
> As an  external developer, I am unaware of Yocto QA process to intake
> changes to master branch.
> 
> Do I missing something from my end?
> 
> Mit freundlichen Grüßen / Best regards
> 
> Rajendran Vignesh
> RBEI/ECF33
> 
> Tel. +91 422 67-65103
> 
> 
> -----Original Message-----
> From: Vignesh Rajendran (RBEI/ECF3)
> Sent: Thursday, April 19, 2018 2:54 PM
> To: 'Peter Kjellerstedt' <peter.kjellerstedt@axis.com>
> Cc: poky@yoctoproject.org; Vignesh Rajendran (RBEI/ECF3)
> (Vignesh.Rajendran@in.bosch.com) <Vignesh.Rajendran@in.bosch.com>
> Subject: RE: [poky] [PULL] package.bbclass: provide debug sources in
> externalsrc -dbg packages
> 
> Hi Peter,
> 
> I have removed the tabs and applied spaces in the mentioned lines.
> 
> Please see the changes here,
> http://git.yoctoproject.org/cgit.cgi/poky-
> contrib/commit/?h=vrajendran/externalsrc-
> debugsrc&id=d835e41e35160941debaad4beff80b322ff60664
> 
> Patch:
> package.bbclass: copydebugsources: remove tabs and apply
> spacevrajendran/externalsrc-debugsrc
> Signed-off-by: Vignesh Rajendran <vignesh.rajendran@in.bosch.com>
> Diffstat
> -rw-r--r--	meta/classes/package.bbclass	4
> 
> 1 files changed, 2 insertions, 2 deletions
> diff --git a/meta/classes/package.bbclass
> b/meta/classes/package.bbclass
> index 9466a4b..c76f6e4 100644
> --- a/meta/classes/package.bbclass
> +++ b/meta/classes/package.bbclass
> @@ -414,7 +414,7 @@ def copydebugsources(debugsrcdir, d):
>          workdir = d.getVar("WORKDIR")
>          workparentdir = os.path.dirname(os.path.dirname(workdir))
>          workbasedir = os.path.basename(os.path.dirname(workdir)) + "/"
> + os.path.basename(workdir)
> -	externalsrc = d.getVar('EXTERNALSRC', True)
> +        externalsrc = d.getVar('EXTERNALSRC', True)
> 
>          # If build path exists in sourcefile, it means toolchain did
> not use
>          # -fdebug-prefix-map to compile
> @@ -449,7 +449,7 @@ def copydebugsources(debugsrcdir, d):
>              processdebugsrc += "(cd '%s' ; cpio -pd0mlL --no-preserve-
> owner '%s%s' 2>/dev/null)"
>              cmd = processdebugsrc % (sourcefile, workbasedir,
> localsrc_prefix, workparentdir, dvar, debugsrcdir)
> 
> -	(retval, output) = oe.utils.getstatusoutput(cmd)
> +        (retval, output) = oe.utils.getstatusoutput(cmd)
>          # Can "fail" if internal headers/transient sources are
> attempted
>          #if retval:
>          #    bb.fatal("debug source copy failed with exit code %s (cmd
> was %s)" % (retval, cmd))
> 
> Thank You.
> 
> Mit freundlichen Grüßen / Best regards
> 
> Rajendran Vignesh
> RBEI/ECF33
> 
> Tel. +91 422 67-65103
> 
> 
> -----Original Message-----
> From: Peter Kjellerstedt [mailto:peter.kjellerstedt@axis.com]
> Sent: Thursday, April 19, 2018 12:57 PM
> To: Vignesh Rajendran (RBEI/ECF3) <Vignesh.Rajendran@in.bosch.com>;
> poky@yoctoproject.org
> Subject: RE: [poky] [PULL] package.bbclass: provide debug sources in
> externalsrc -dbg packages
> 
> > -----Original Message-----
> > From: poky-bounces@yoctoproject.org [mailto:poky-
> > bounces@yoctoproject.org] On Behalf Of Vignesh Rajendran
> > Sent: den 19 april 2018 06:27
> > To: poky@yoctoproject.org
> > Subject: [poky] [PULL] package.bbclass: provide debug sources in
> externalsrc -dbg packages
> >
> > The recipes which are using externalsrc method doesn't contain the
> > debug sources in their -dbg packages.
> >
> > Add a handling in copydebugsources function to copy the debugsources
> for
> > externalsrc -dbg packages.
> >
> > Signed-off-by: Vignesh Rajendran <vignesh.rajendran@in.bosch.com>
> > ---
> >  meta/classes/externalsrc.bbclass |  3 +++
> >  meta/classes/package.bbclass     | 14 +++++++++++---
> >  2 files changed, 14 insertions(+), 3 deletions(-)
> >
> > diff --git a/meta/classes/externalsrc.bbclass
> b/meta/classes/externalsrc.bbclass
> > index 3f1d396..042f935 100644
> > --- a/meta/classes/externalsrc.bbclass
> > +++ b/meta/classes/externalsrc.bbclass
> > @@ -126,6 +126,9 @@ python () {
> >              d.setVar('CONFIGURESTAMPFILE', configstamp)
> >              d.setVar('STAMP', '${STAMPS_DIR}/work-
> shared/${PN}/${EXTENDPE}${PV}-${PR}')
> >              d.setVar('STAMPCLEAN', '${STAMPS_DIR}/work-
> shared/${PN}/*-*')
> > +
> > +	# set DEBUG_PREFIX_MAP to external source path
> > +	d.appendVar("DEBUG_PREFIX_MAP", "-fdebug-prefix-
> map=${EXTERNALSRC}=/usr/src/debug/${PN}/${EXTENDPE}${PV}-${PR}")
> >  }
> >
> >  python externalsrc_configure_prefunc() {
> > diff --git a/meta/classes/package.bbclass
> b/meta/classes/package.bbclass
> > index 504c023..9466a4b 100644
> > --- a/meta/classes/package.bbclass
> > +++ b/meta/classes/package.bbclass
> > @@ -414,6 +414,7 @@ def copydebugsources(debugsrcdir, d):
> >          workdir = d.getVar("WORKDIR")
> >          workparentdir = os.path.dirname(os.path.dirname(workdir))
> >          workbasedir = os.path.basename(os.path.dirname(workdir)) +
> "/" + os.path.basename(workdir)
> > +	externalsrc = d.getVar('EXTERNALSRC', True)
> 
> Change the tab to spaces.
> 
> >
> >          # If build path exists in sourcefile, it means toolchain did
> not use
> >          # -fdebug-prefix-map to compile
> > @@ -438,10 +439,17 @@ def copydebugsources(debugsrcdir, d):
> >          processdebugsrc += "fgrep -zw '%s' | "
> >          # Remove prefix in the source paths
> >          processdebugsrc += "sed 's#%s##g' | "
> > -        processdebugsrc += "(cd '%s' ; cpio -pd0mlL --no-preserve-
> owner '%s%s' 2>/dev/null)"
> > +        # handle external sources to provide sources in -dbg
> packages
> > +        if externalsrc:
> > +            localsrc_prefix = "/usr/src/debug/"
> > +            processdebugsrc += "sed 's#%s/##g' | "
> > +            processdebugsrc += "(cd '%s' ; cpio -pd0mlL --no-
> preserve-owner '%s%s/%s' 2>/dev/null)"
> > +            cmd = processdebugsrc % (sourcefile, workbasedir,
> localsrc_prefix, workbasedir, externalsrc, dvar, debugsrcdir,
> workbasedir)
> > +        else:
> > +            processdebugsrc += "(cd '%s' ; cpio -pd0mlL --no-
> preserve-owner '%s%s' 2>/dev/null)"
> > +            cmd = processdebugsrc % (sourcefile, workbasedir,
> localsrc_prefix, workparentdir, dvar, debugsrcdir)
> >
> > -        cmd = processdebugsrc % (sourcefile, workbasedir,
> localsrc_prefix, workparentdir, dvar, debugsrcdir)
> > -        (retval, output) = oe.utils.getstatusoutput(cmd)
> > +	(retval, output) = oe.utils.getstatusoutput(cmd)
> 
> Change the tab to spaces.
> 
> >          # Can "fail" if internal headers/transient sources are
> attempted
> >          #if retval:
> >          #    bb.fatal("debug source copy failed with exit code %s
> (cmd was %s)" % (retval, cmd))
> > --
> > 2.7.4
> 
> //Peter

-- 
_______________________________________________
poky mailing list
poky@yoctoproject.org
https://lists.yoctoproject.org/listinfo/poky


^ permalink raw reply	[flat|nested] 11+ messages in thread
* Re: [PULL] package.bbclass: provide debug sources in externalsrc -dbg packages
  2018-05-02  6:27           ` Vignesh Rajendran (RBEI/ECF3)
@ 2018-05-06 21:07             ` Paul Eggleton
  0 siblings, 0 replies; 11+ messages in thread
From: Paul Eggleton @ 2018-05-06 21:07 UTC (permalink / raw)
  To: Vignesh Rajendran (RBEI/ECF3); +Cc: poky

Hi Rajendran,

On Wednesday, 2 May 2018 6:27:42 PM NZST Vignesh Rajendran (RBEI/ECF3) wrote:
> Do I have to split my changes in externalsrc.bbclass to submit to OE-core?

I don't think any splitting should be needed, but you should send your patch 
to the OE-Core list, yes (with all corrections merged in).

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre




^ permalink raw reply	[flat|nested] 11+ messages in thread
* Re: [PULL] provide debug sources in externalsrc -dbg packages
  2018-04-18  4:14 [PULL] " Vignesh Rajendran (RBEI/ECF3)
@ 2018-04-18 20:07 ` Burton, Ross
  0 siblings, 0 replies; 11+ messages in thread
From: Burton, Ross @ 2018-04-18 20:07 UTC (permalink / raw)
  To: Vignesh Rajendran (RBEI/ECF3); +Cc: yocto

This is the wrong list, please submit the patch to
openembedded-core@lists.openembedded.org.  Also the patches, not just
a link to the patches.

Ross

On 18 April 2018 at 05:14, Vignesh Rajendran (RBEI/ECF3)
<Vignesh.Rajendran@in.bosch.com> wrote:
> Hi Yocto,
>
>
>
> I have made some changes to fix missing debug sources in -dbg packages while
> using externalsrc.
>
> Please have look and let me know for any changes needed.
>
>
>
> Thanks. :-)
>
>
>
> the changes are available in the git repository at:
>
>
>
> https://git.yoctoproject.org/git/poky-contrib
> vrajendran/externalsrc-debugsrc
>
> http://git.yoctoproject.org/cgit.cgi//log/?h=vrajendran/externalsrc-debugsrc
>
>
>
> Vignesh Rajendran (1):
>
>   package.bbclass: provide debug sources in externalsrc -dbg packages
>
>
>
> meta/classes/externalsrc.bbclass |  3 +++
>
> meta/classes/package.bbclass     | 14 +++++++++++---
>
> 2 files changed, 14 insertions(+), 3 deletions(-)
>
>
>
> --
>
> 2.7.4
>
>
>
> Mit freundlichen Grüßen / Best regards
>
> Rajendran Vignesh
> RBEI/ECF33
>
> Tel. +91 422 67-65103
>
>
> --
> _______________________________________________
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto
>


^ permalink raw reply	[flat|nested] 11+ messages in thread
* [PULL] provide debug sources in externalsrc -dbg packages
@ 2018-04-18  4:14 Vignesh Rajendran (RBEI/ECF3)
  2018-04-18 20:07 ` Burton, Ross
  0 siblings, 1 reply; 11+ messages in thread
From: Vignesh Rajendran (RBEI/ECF3) @ 2018-04-18  4:14 UTC (permalink / raw)
  To: yocto

[-- Attachment #1: Type: text/plain, Size: 837 bytes --]

Hi Yocto,

I have made some changes to fix missing debug sources in -dbg packages while using externalsrc.
Please have look and let me know for any changes needed.

Thanks. :-)

the changes are available in the git repository at:

https://git.yoctoproject.org/git/poky-contrib  vrajendran/externalsrc-debugsrc
http://git.yoctoproject.org/cgit.cgi//log/?h=vrajendran/externalsrc-debugsrc<http://git.yoctoproject.org/cgit.cgi/log/?h=vrajendran/externalsrc-debugsrc>

Vignesh Rajendran (1):
  package.bbclass: provide debug sources in externalsrc -dbg packages

meta/classes/externalsrc.bbclass |  3 +++
meta/classes/package.bbclass     | 14 +++++++++++---
2 files changed, 14 insertions(+), 3 deletions(-)

--
2.7.4

Mit freundlichen Grüßen / Best regards

Rajendran Vignesh
RBEI/ECF33

Tel. +91 422 67-65103


[-- Attachment #2: Type: text/html, Size: 3840 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread
end of thread, other threads:[~2018-05-06 21:07 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-19  4:26 [PULL] provide debug sources in externalsrc -dbg packages Vignesh Rajendran
2018-04-19  4:26 ` [PULL] package.bbclass: " Vignesh Rajendran
2018-04-19  7:26   ` Peter Kjellerstedt
2018-04-19  9:24     ` Vignesh Rajendran (RBEI/ECF3)
2018-04-24  4:38     ` Vignesh Rajendran (RBEI/ECF3)
2018-04-24 10:29       ` Peter Kjellerstedt
2018-04-25  5:36         ` Vignesh Rajendran (RBEI/ECF3)
2018-05-02  6:27           ` Vignesh Rajendran (RBEI/ECF3)
2018-05-06 21:07             ` Paul Eggleton
  -- strict thread matches above, loose matches on Subject: below --
2018-04-18  4:14 [PULL] " Vignesh Rajendran (RBEI/ECF3)
2018-04-18 20:07 ` Burton, Ross

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.