* [PATCH 0/1] devtool/sdk.py: error out in case of downloading file failure
@ 2018-05-14 8:35 Chen Qi
2018-05-14 8:35 ` [PATCH 1/1] " Chen Qi
0 siblings, 1 reply; 2+ messages in thread
From: Chen Qi @ 2018-05-14 8:35 UTC (permalink / raw)
To: openembedded-core
The following changes since commit 5479654eeaaa0f81bfff54ca49369c87f1658705:
rm_work: Stop appending _setscene to do_image_complete_setscene stamps (2018-05-11 07:49:38 +0100)
are available in the git repository at:
git://git.pokylinux.org/poky-contrib ChenQi/devtool-sdk-update
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=ChenQi/devtool-sdk-update
Chen Qi (1):
devtool/sdk.py: error out in case of downloading file failure
scripts/lib/devtool/sdk.py | 3 +++
1 file changed, 3 insertions(+)
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH 1/1] devtool/sdk.py: error out in case of downloading file failure
2018-05-14 8:35 [PATCH 0/1] devtool/sdk.py: error out in case of downloading file failure Chen Qi
@ 2018-05-14 8:35 ` Chen Qi
0 siblings, 0 replies; 2+ messages in thread
From: Chen Qi @ 2018-05-14 8:35 UTC (permalink / raw)
To: openembedded-core
It's possible that downloading file from updateserver fails. In
this case, we should error out instead of continue.
We have users reporting unexpected behavior of 'devtool sdk-update'.
When an invalid url is supplied, e.g., `devtool sdk-update http://invalid',
the program reports 'Note: Already up-to-date'.
This is obviously not expected. We should error out in such case.
Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
---
scripts/lib/devtool/sdk.py | 3 +++
1 file changed, 3 insertions(+)
diff --git a/scripts/lib/devtool/sdk.py b/scripts/lib/devtool/sdk.py
index f46577c..4616753 100644
--- a/scripts/lib/devtool/sdk.py
+++ b/scripts/lib/devtool/sdk.py
@@ -145,6 +145,9 @@ def sdk_update(args, config, basepath, workspace):
# Fetch manifest from server
tmpmanifest = os.path.join(tmpsdk_dir, 'conf', 'sdk-conf-manifest')
ret = subprocess.call("wget -q -O %s %s/conf/sdk-conf-manifest" % (tmpmanifest, updateserver), shell=True)
+ if ret != 0:
+ logger.error("Cannot dowload files from %s" % updateserver)
+ return ret
changedfiles = check_manifest(tmpmanifest, basepath)
if not changedfiles:
logger.info("Already up-to-date")
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-05-14 8:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-14 8:35 [PATCH 0/1] devtool/sdk.py: error out in case of downloading file failure Chen Qi
2018-05-14 8:35 ` [PATCH 1/1] " Chen Qi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.