All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/4] staging: mt7621-pci: cleanup
@ 2018-10-04 11:06 Mamta Shukla
  2018-10-04 11:12 ` [PATCH 1/4] staging: mt7621-pci: do not initialise statics to 0 Mamta Shukla
                   ` (3 more replies)
  0 siblings, 4 replies; 7+ messages in thread
From: Mamta Shukla @ 2018-10-04 11:06 UTC (permalink / raw)
  To: outreachy-kernel; +Cc: gregkh, mamtashukla555

Fix issues found with checkpatch.pl for mt7621-pci staging driver.

Mamta Shukla (4):
  staging: mt7621-pci: do not initialise statics to 0
  staging: mt7621-pci: spaces preferred around that '&'
  staging: mt7621-pci: spaces preferred around that '|'
  staging: mt7621-pci: spaces preferred around that '<<'

 drivers/staging/mt7621-pci/pci-mt7621.c | 50 ++++++++++++++++-----------------
 1 file changed, 25 insertions(+), 25 deletions(-)

-- 
1.9.1



^ permalink raw reply	[flat|nested] 7+ messages in thread
* [PATCH 1/4] staging: mt7621-pci: do not initialise statics to 0
  2018-10-04 11:06 [PATCH 0/4] staging: mt7621-pci: cleanup Mamta Shukla
@ 2018-10-04 11:12 ` Mamta Shukla
  2018-10-04 11:13 ` [PATCH 2/4] staging: mt7621-pci: spaces preferred around that '&' Mamta Shukla
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 7+ messages in thread
From: Mamta Shukla @ 2018-10-04 11:12 UTC (permalink / raw)
  To: outreachy-kernel; +Cc: gregkh, mamtashukla555

Remove initialisation for static global variable to fix checkpatch issue.
ERROR: do not initialise statics to 0

Signed-off-by: Mamta Shukla <mamtashukla555@gmail.com>
---
 drivers/staging/mt7621-pci/pci-mt7621.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/mt7621-pci/pci-mt7621.c b/drivers/staging/mt7621-pci/pci-mt7621.c
index ba1f117..3182d8a 100644
--- a/drivers/staging/mt7621-pci/pci-mt7621.c
+++ b/drivers/staging/mt7621-pci/pci-mt7621.c
@@ -122,7 +122,7 @@
 #define RALINK_PCIE_CLK_EN		BIT(21)
 
 #define MEMORY_BASE 0x0
-static int pcie_link_status = 0;
+static int pcie_link_status;
 
 /**
  * struct mt7621_pcie_port - PCIe port information
-- 
1.9.1

Removed initialisation to 0 for static global variable:
1.This type of variable iss initialised to 0 implicitly as per C coding
standard.
2.Also this will take space in .BSS segment of memory while linking.


^ permalink raw reply related	[flat|nested] 7+ messages in thread
* [PATCH 2/4] staging: mt7621-pci: spaces preferred around that '&'
  2018-10-04 11:06 [PATCH 0/4] staging: mt7621-pci: cleanup Mamta Shukla
  2018-10-04 11:12 ` [PATCH 1/4] staging: mt7621-pci: do not initialise statics to 0 Mamta Shukla
@ 2018-10-04 11:13 ` Mamta Shukla
  2018-10-04 11:15 ` [PATCH 3/4] staging: mt7621-pci: spaces preferred around that '|' Mamta Shukla
  2018-10-04 11:16 ` [PATCH 4/4] staging: mt7621-pci: spaces preferred around that '<<' Mamta Shukla
  3 siblings, 0 replies; 7+ messages in thread
From: Mamta Shukla @ 2018-10-04 11:13 UTC (permalink / raw)
  To: outreachy-kernel; +Cc: gregkh, mamtashukla555

Add spaces around '&' to fix checkpatch issue.
CHECK: spaces preferred around that '&' (ctx:VxV)

Signed-off-by: Mamta Shukla <mamtashukla555@gmail.com>
---
 drivers/staging/mt7621-pci/pci-mt7621.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/mt7621-pci/pci-mt7621.c b/drivers/staging/mt7621-pci/pci-mt7621.c
index 3182d8a..14aac08 100644
--- a/drivers/staging/mt7621-pci/pci-mt7621.c
+++ b/drivers/staging/mt7621-pci/pci-mt7621.c
@@ -489,7 +489,7 @@ static int mt7621_pci_probe(struct platform_device *pdev)
 
 	DEASSERT_SYSRST_PCIE(val);
 
-	if ((*(unsigned int *)(0xbe00000c)&0xFFFF) == 0x0101) // MT7621 E2
+	if ((*(unsigned int *)(0xbe00000c) & 0xFFFF) == 0x0101) // MT7621 E2
 		bypass_pipe_rst(pcie);
 	set_phy_for_ssc(pcie);
 
-- 
1.9.1



^ permalink raw reply related	[flat|nested] 7+ messages in thread
* [PATCH 3/4] staging: mt7621-pci: spaces preferred around that '|'
  2018-10-04 11:06 [PATCH 0/4] staging: mt7621-pci: cleanup Mamta Shukla
  2018-10-04 11:12 ` [PATCH 1/4] staging: mt7621-pci: do not initialise statics to 0 Mamta Shukla
  2018-10-04 11:13 ` [PATCH 2/4] staging: mt7621-pci: spaces preferred around that '&' Mamta Shukla
@ 2018-10-04 11:15 ` Mamta Shukla
  2018-10-04 11:16 ` [PATCH 4/4] staging: mt7621-pci: spaces preferred around that '<<' Mamta Shukla
  3 siblings, 0 replies; 7+ messages in thread
From: Mamta Shukla @ 2018-10-04 11:15 UTC (permalink / raw)
  To: outreachy-kernel; +Cc: mamtashukla555, gregkh

Add spaces around '|' to fix checkpatch issue.
CHECK: spaces preferred around that '|' (ctx:VxV)

Signed-off-by: Mamta Shukla <mamtashukla555@gmail.com>
---
 drivers/staging/mt7621-pci/pci-mt7621.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/mt7621-pci/pci-mt7621.c b/drivers/staging/mt7621-pci/pci-mt7621.c
index 14aac08..780ba56 100644
--- a/drivers/staging/mt7621-pci/pci-mt7621.c
+++ b/drivers/staging/mt7621-pci/pci-mt7621.c
@@ -644,7 +644,7 @@ static int mt7621_pci_probe(struct platform_device *pdev)
 	switch (pcie_link_status) {
 	case 7:
 		val = read_config(pcie, 2, 0x4);
-		write_config(pcie, 2, 0x4, val|0x4);
+		write_config(pcie, 2, 0x4, val | 0x4);
 		val = read_config(pcie, 2, 0x70c);
 		val &= ~(0xff)<<8;
 		val |= 0x50<<8;
@@ -653,14 +653,14 @@ static int mt7621_pci_probe(struct platform_device *pdev)
 	case 5:
 	case 6:
 		val = read_config(pcie, 1, 0x4);
-		write_config(pcie, 1, 0x4, val|0x4);
+		write_config(pcie, 1, 0x4, val | 0x4);
 		val = read_config(pcie, 1, 0x70c);
 		val &= ~(0xff)<<8;
 		val |= 0x50<<8;
 		write_config(pcie, 1, 0x70c, val);
 	default:
 		val = read_config(pcie, 0, 0x4);
-		write_config(pcie, 0, 0x4, val|0x4); //bus master enable
+		write_config(pcie, 0, 0x4, val | 0x4); //bus master enable
 		val = read_config(pcie, 0, 0x70c);
 		val &= ~(0xff)<<8;
 		val |= 0x50<<8;
-- 
1.9.1



^ permalink raw reply related	[flat|nested] 7+ messages in thread
* [PATCH 4/4] staging: mt7621-pci: spaces preferred around that '<<'
  2018-10-04 11:06 [PATCH 0/4] staging: mt7621-pci: cleanup Mamta Shukla
                   ` (2 preceding siblings ...)
  2018-10-04 11:15 ` [PATCH 3/4] staging: mt7621-pci: spaces preferred around that '|' Mamta Shukla
@ 2018-10-04 11:16 ` Mamta Shukla
  2018-10-04 12:06   ` [Outreachy kernel] " Himanshu Jha
  3 siblings, 1 reply; 7+ messages in thread
From: Mamta Shukla @ 2018-10-04 11:16 UTC (permalink / raw)
  To: outreachy-kernel; +Cc: mamtashukla555, gregkh

Add spaces around '<<' to fix checkpatch issue.
CHECK: spaces preferred around that '<<' (ctx:VxV)

Signed-off-by: Mamta Shukla <mamtashukla555@gmail.com>
---
 drivers/staging/mt7621-pci/pci-mt7621.c | 40 ++++++++++++++++-----------------
 1 file changed, 20 insertions(+), 20 deletions(-)

diff --git a/drivers/staging/mt7621-pci/pci-mt7621.c b/drivers/staging/mt7621-pci/pci-mt7621.c
index 780ba56..31b448d 100644
--- a/drivers/staging/mt7621-pci/pci-mt7621.c
+++ b/drivers/staging/mt7621-pci/pci-mt7621.c
@@ -474,12 +474,12 @@ static int mt7621_pci_probe(struct platform_device *pdev)
 
 	ASSERT_SYSRST_PCIE(RALINK_PCIE0_RST | RALINK_PCIE1_RST | RALINK_PCIE2_RST);
 
-	*(unsigned int *)(0xbe000060) &= ~(0x3<<10 | 0x3<<3);
-	*(unsigned int *)(0xbe000060) |= 0x1<<10 | 0x1<<3;
+	*(unsigned int *)(0xbe000060) &= ~(0x3 << 10 | 0x3 << 3);
+	*(unsigned int *)(0xbe000060) |= 0x1 << 10 | 0x1 << 3;
 	mdelay(100);
-	*(unsigned int *)(0xbe000600) |= 0x1<<19 | 0x1<<8 | 0x1<<7; // use GPIO19/GPIO8/GPIO7 (PERST_N/UART_RXD3/UART_TXD3)
+	*(unsigned int *)(0xbe000600) |= 0x1 << 19 | 0x1 << 8 | 0x1 << 7; // use GPIO19/GPIO8/GPIO7 (PERST_N/UART_RXD3/UART_TXD3)
 	mdelay(100);
-	*(unsigned int *)(0xbe000620) &= ~(0x1<<19 | 0x1<<8 | 0x1<<7);		// clear DATA
+	*(unsigned int *)(0xbe000620) &= ~(0x1 << 19 | 0x1 << 8 | 0x1 << 7);		// clear DATA
 
 	mdelay(100);
 
@@ -510,18 +510,18 @@ static int mt7621_pci_probe(struct platform_device *pdev)
 	rt_sysc_m32(RALINK_PCIE_RST, 0, RALINK_RSTCTRL);
 
 	/* Use GPIO control instead of PERST_N */
-	*(unsigned int *)(0xbe000620) |= 0x1<<19 | 0x1<<8 | 0x1<<7;		// set DATA
+	*(unsigned int *)(0xbe000620) |= 0x1 << 19 | 0x1 << 8 | 0x1 << 7;		// set DATA
 	mdelay(1000);
 
 	if ((pcie_read(pcie, RT6855_PCIE0_OFFSET + RALINK_PCI_STATUS) & 0x1) == 0) {
 		printk("PCIE0 no card, disable it(RST&CLK)\n");
 		ASSERT_SYSRST_PCIE(RALINK_PCIE0_RST);
 		rt_sysc_m32(RALINK_PCIE0_CLK_EN, 0, RALINK_CLKCFG1);
-		pcie_link_status &= ~(1<<0);
+		pcie_link_status &= ~(1 << 0);
 	} else {
-		pcie_link_status |= 1<<0;
+		pcie_link_status |= 1 << 0;
 		val = pcie_read(pcie, RALINK_PCI_PCIMSK_ADDR);
-		val |= (1<<20); // enable pcie1 interrupt
+		val |= (1 << 20); // enable pcie1 interrupt
 		pcie_write(pcie, val, RALINK_PCI_PCIMSK_ADDR);
 	}
 
@@ -529,11 +529,11 @@ static int mt7621_pci_probe(struct platform_device *pdev)
 		printk("PCIE1 no card, disable it(RST&CLK)\n");
 		ASSERT_SYSRST_PCIE(RALINK_PCIE1_RST);
 		rt_sysc_m32(RALINK_PCIE1_CLK_EN, 0, RALINK_CLKCFG1);
-		pcie_link_status &= ~(1<<1);
+		pcie_link_status &= ~(1 << 1);
 	} else {
-		pcie_link_status |= 1<<1;
+		pcie_link_status |= 1 << 1;
 		val = pcie_read(pcie, RALINK_PCI_PCIMSK_ADDR);
-		val |= (1<<21); // enable pcie1 interrupt
+		val |= (1 << 21); // enable pcie1 interrupt
 		pcie_write(pcie, val, RALINK_PCI_PCIMSK_ADDR);
 	}
 
@@ -541,11 +541,11 @@ static int mt7621_pci_probe(struct platform_device *pdev)
 		printk("PCIE2 no card, disable it(RST&CLK)\n");
 		ASSERT_SYSRST_PCIE(RALINK_PCIE2_RST);
 		rt_sysc_m32(RALINK_PCIE2_CLK_EN, 0, RALINK_CLKCFG1);
-		pcie_link_status &= ~(1<<2);
+		pcie_link_status &= ~(1 << 2);
 	} else {
-		pcie_link_status |= 1<<2;
+		pcie_link_status |= 1 << 2;
 		val = pcie_read(pcie, RALINK_PCI_PCIMSK_ADDR);
-		val |= (1<<22); // enable pcie2 interrupt
+		val |= (1 << 22); // enable pcie2 interrupt
 		pcie_write(pcie, val, RALINK_PCI_PCIMSK_ADDR);
 	}
 
@@ -646,8 +646,8 @@ static int mt7621_pci_probe(struct platform_device *pdev)
 		val = read_config(pcie, 2, 0x4);
 		write_config(pcie, 2, 0x4, val | 0x4);
 		val = read_config(pcie, 2, 0x70c);
-		val &= ~(0xff)<<8;
-		val |= 0x50<<8;
+		val &= ~(0xff) << 8;
+		val |= 0x50 << 8;
 		write_config(pcie, 2, 0x70c, val);
 	case 3:
 	case 5:
@@ -655,15 +655,15 @@ static int mt7621_pci_probe(struct platform_device *pdev)
 		val = read_config(pcie, 1, 0x4);
 		write_config(pcie, 1, 0x4, val | 0x4);
 		val = read_config(pcie, 1, 0x70c);
-		val &= ~(0xff)<<8;
-		val |= 0x50<<8;
+		val &= ~(0xff) << 8;
+		val |= 0x50 << 8;
 		write_config(pcie, 1, 0x70c, val);
 	default:
 		val = read_config(pcie, 0, 0x4);
 		write_config(pcie, 0, 0x4, val | 0x4); //bus master enable
 		val = read_config(pcie, 0, 0x70c);
-		val &= ~(0xff)<<8;
-		val |= 0x50<<8;
+		val &= ~(0xff) << 8;
+		val |= 0x50 << 8;
 		write_config(pcie, 0, 0x70c, val);
 	}
 
-- 
1.9.1



^ permalink raw reply related	[flat|nested] 7+ messages in thread
* Re: [Outreachy kernel] [PATCH 4/4] staging: mt7621-pci: spaces preferred around that '<<'
  2018-10-04 11:16 ` [PATCH 4/4] staging: mt7621-pci: spaces preferred around that '<<' Mamta Shukla
@ 2018-10-04 12:06   ` Himanshu Jha
  2018-10-04 14:37     ` Mamta Shukla
  0 siblings, 1 reply; 7+ messages in thread
From: Himanshu Jha @ 2018-10-04 12:06 UTC (permalink / raw)
  To: Mamta Shukla; +Cc: outreachy-kernel, gregkh

On Thu, Oct 04, 2018 at 04:46:11PM +0530, Mamta Shukla wrote:
> Add spaces around '<<' to fix checkpatch issue.
> CHECK: spaces preferred around that '<<' (ctx:VxV)
> 
> Signed-off-by: Mamta Shukla <mamtashukla555@gmail.com>
> ---
>  drivers/staging/mt7621-pci/pci-mt7621.c | 40 ++++++++++++++++-----------------
>  1 file changed, 20 insertions(+), 20 deletions(-)
> 
> diff --git a/drivers/staging/mt7621-pci/pci-mt7621.c b/drivers/staging/mt7621-pci/pci-mt7621.c
> index 780ba56..31b448d 100644
> --- a/drivers/staging/mt7621-pci/pci-mt7621.c
> +++ b/drivers/staging/mt7621-pci/pci-mt7621.c
> @@ -474,12 +474,12 @@ static int mt7621_pci_probe(struct platform_device *pdev)
>  
>  	ASSERT_SYSRST_PCIE(RALINK_PCIE0_RST | RALINK_PCIE1_RST | RALINK_PCIE2_RST);
>  
> -	*(unsigned int *)(0xbe000060) &= ~(0x3<<10 | 0x3<<3);
> -	*(unsigned int *)(0xbe000060) |= 0x1<<10 | 0x1<<3;
> +	*(unsigned int *)(0xbe000060) &= ~(0x3 << 10 | 0x3 << 3);
> +	*(unsigned int *)(0xbe000060) |= 0x1 << 10 | 0x1 << 3;
>  	mdelay(100);
> -	*(unsigned int *)(0xbe000600) |= 0x1<<19 | 0x1<<8 | 0x1<<7; // use GPIO19/GPIO8/GPIO7 (PERST_N/UART_RXD3/UART_TXD3)

You can use BIT() here as well.
Example:

+	*(unsigned int *)(0xbe000600) |= BIT(19) | BIT(8) | BIT(7); // use GPIO19/GPIO8/GPIO7 (PERST_N/UART_RXD3/UART_TXD3)

Check for others too.

-- 
Himanshu Jha
Undergraduate Student
Department of Electronics & Communication
Guru Tegh Bahadur Institute of Technology


^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [Outreachy kernel] [PATCH 4/4] staging: mt7621-pci: spaces preferred around that '<<'
  2018-10-04 12:06   ` [Outreachy kernel] " Himanshu Jha
@ 2018-10-04 14:37     ` Mamta Shukla
  0 siblings, 0 replies; 7+ messages in thread
From: Mamta Shukla @ 2018-10-04 14:37 UTC (permalink / raw)
  To: himanshujha199640; +Cc: outreachy-kernel, gregkh

[-- Attachment #1: Type: text/plain, Size: 1833 bytes --]

On Thu, Oct 4, 2018 at 5:36 PM Himanshu Jha <himanshujha199640@gmail.com>
wrote:

> On Thu, Oct 04, 2018 at 04:46:11PM +0530, Mamta Shukla wrote:
> > Add spaces around '<<' to fix checkpatch issue.
> > CHECK: spaces preferred around that '<<' (ctx:VxV)
> >
> > Signed-off-by: Mamta Shukla <mamtashukla555@gmail.com>
> > ---
> >  drivers/staging/mt7621-pci/pci-mt7621.c | 40
> ++++++++++++++++-----------------
> >  1 file changed, 20 insertions(+), 20 deletions(-)
> >
> > diff --git a/drivers/staging/mt7621-pci/pci-mt7621.c
> b/drivers/staging/mt7621-pci/pci-mt7621.c
> > index 780ba56..31b448d 100644
> > --- a/drivers/staging/mt7621-pci/pci-mt7621.c
> > +++ b/drivers/staging/mt7621-pci/pci-mt7621.c
> > @@ -474,12 +474,12 @@ static int mt7621_pci_probe(struct platform_device
> *pdev)
> >
> >       ASSERT_SYSRST_PCIE(RALINK_PCIE0_RST | RALINK_PCIE1_RST |
> RALINK_PCIE2_RST);
> >
> > -     *(unsigned int *)(0xbe000060) &= ~(0x3<<10 | 0x3<<3);
> > -     *(unsigned int *)(0xbe000060) |= 0x1<<10 | 0x1<<3;
> > +     *(unsigned int *)(0xbe000060) &= ~(0x3 << 10 | 0x3 << 3);
> > +     *(unsigned int *)(0xbe000060) |= 0x1 << 10 | 0x1 << 3;
> >       mdelay(100);
> > -     *(unsigned int *)(0xbe000600) |= 0x1<<19 | 0x1<<8 | 0x1<<7; // use
> GPIO19/GPIO8/GPIO7 (PERST_N/UART_RXD3/UART_TXD3)
>
> >You can use BIT() here as well.
> >Example:
>
> >+       *(unsigned int *)(0xbe000600) |= BIT(19) | BIT(8) | BIT(7); //
> use GPIO19/GPIO8/GPIO7 (PERST_N/UART_RXD3/UART_TXD3)
>
> >Check for others too.
>
> >--
> >Himanshu Jha
> >Undergraduate Student
> >Department of Electronics & Communication
> >Guru Tegh Bahadur Institute of Technology
>

Ok, I will add BIT() at possible places and submit a new patch in this
patch series.
-- 
Mamta Shukla
Pune Institute  of Computer Technology
Pune
m: 9158516957
e : mamtashukla555@gmail.com

[-- Attachment #2: Type: text/html, Size: 2981 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-10-04 14:38 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-04 11:06 [PATCH 0/4] staging: mt7621-pci: cleanup Mamta Shukla
2018-10-04 11:12 ` [PATCH 1/4] staging: mt7621-pci: do not initialise statics to 0 Mamta Shukla
2018-10-04 11:13 ` [PATCH 2/4] staging: mt7621-pci: spaces preferred around that '&' Mamta Shukla
2018-10-04 11:15 ` [PATCH 3/4] staging: mt7621-pci: spaces preferred around that '|' Mamta Shukla
2018-10-04 11:16 ` [PATCH 4/4] staging: mt7621-pci: spaces preferred around that '<<' Mamta Shukla
2018-10-04 12:06   ` [Outreachy kernel] " Himanshu Jha
2018-10-04 14:37     ` Mamta Shukla

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.