All of lore.kernel.org
 help / color / mirror / Atom feed
* [Outreachy kernel] [PATCH 0/8]staging: rtl8723bs: Remove unnecessary parentheses
@ 2019-03-30  5:12 Payal Kshirsagar
  2019-03-30  5:12 ` [Outreachy kernel] [PATCH 1/8] staging: rtl8723bs: hal: sdio_ops.c: " Payal Kshirsagar
                   ` (7 more replies)
  0 siblings, 8 replies; 11+ messages in thread
From: Payal Kshirsagar @ 2019-03-30  5:12 UTC (permalink / raw)
  To: outreachy-kernel; +Cc: Payal Kshirsagar

Challenge suggested by coccinelle

This patchset removes unnecessary parentheses while returning a value by
evaluating an expression, using following semantic patch:

@@ 
expression e;
@@

return
- (
e
- )
;

Payal Kshirsagar (8):
  staging: rtl8723bs: hal: sdio_ops.c: Remove unnecessary parentheses
  staging: rtl8723bs: hal: rtl8723b_phycfg.c: Remove unnecessary
    parentheses
  staging: rtl8723bs: hal: hal_com.c: Remove unnecessary parentheses
  staging: rtl8723bs: hal: odm_HWConfig.c: Remove unnecessary
    parentheses
  staging: rtl8723bs: core: rtw_mlme.c: Remove unnecessary parentheses
  staging: rtl8723bs: core: rtw_wlan_util.c: Remove unnecessary
    parentheses
  staging: rtl8723bs: core: rtw_ieee80211.c: Remove unnecessary
    parentheses
  staging: rtl8723bs: os_dep: ioctl_linux.c: Remove unnecessary
    parentheses

 drivers/staging/rtl8723bs/core/rtw_ieee80211.c  | 6 +++---
 drivers/staging/rtl8723bs/core/rtw_mlme.c       | 8 ++++----
 drivers/staging/rtl8723bs/core/rtw_wlan_util.c  | 2 +-
 drivers/staging/rtl8723bs/hal/hal_com.c         | 6 +++---
 drivers/staging/rtl8723bs/hal/odm_HWConfig.c    | 2 +-
 drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c | 2 +-
 drivers/staging/rtl8723bs/hal/sdio_ops.c        | 6 +++---
 drivers/staging/rtl8723bs/os_dep/ioctl_linux.c  | 2 +-
 8 files changed, 17 insertions(+), 17 deletions(-)

-- 
2.7.4



^ permalink raw reply	[flat|nested] 11+ messages in thread
* [Outreachy kernel] [PATCH 1/8] staging: rtl8723bs: hal: sdio_ops.c: Remove unnecessary parentheses
  2019-03-30  5:12 [Outreachy kernel] [PATCH 0/8]staging: rtl8723bs: Remove unnecessary parentheses Payal Kshirsagar
@ 2019-03-30  5:12 ` Payal Kshirsagar
  2019-03-30  5:12 ` [Outreachy kernel] [PATCH 2/8] staging: rtl8723bs: hal: rtl8723b_phycfg.c: " Payal Kshirsagar
                   ` (6 subsequent siblings)
  7 siblings, 0 replies; 11+ messages in thread
From: Payal Kshirsagar @ 2019-03-30  5:12 UTC (permalink / raw)
  To: outreachy-kernel; +Cc: Payal Kshirsagar

Challenge suggested by coccinelle.
Remove unnecessary parentheses around expressions.

Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
---
 drivers/staging/rtl8723bs/hal/sdio_ops.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/sdio_ops.c b/drivers/staging/rtl8723bs/hal/sdio_ops.c
index 3fee344..f5f7f36 100644
--- a/drivers/staging/rtl8723bs/hal/sdio_ops.c
+++ b/drivers/staging/rtl8723bs/hal/sdio_ops.c
@@ -560,7 +560,7 @@ static s32 _sdio_local_read(
 	n = RND4(cnt);
 	tmpbuf = rtw_malloc(n);
 	if (!tmpbuf)
-		return (-1);
+		return -1;
 
 	err = _sd_read(intfhdl, addr, n, tmpbuf);
 	if (!err)
@@ -601,7 +601,7 @@ s32 sdio_local_read(
 	n = RND4(cnt);
 	tmpbuf = rtw_malloc(n);
 	if (!tmpbuf)
-		return (-1);
+		return -1;
 
 	err = sd_read(intfhdl, addr, n, tmpbuf);
 	if (!err)
@@ -646,7 +646,7 @@ s32 sdio_local_write(
 
 	tmpbuf = rtw_malloc(cnt);
 	if (!tmpbuf)
-		return (-1);
+		return -1;
 
 	memcpy(tmpbuf, buf, cnt);
 
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 11+ messages in thread
* [Outreachy kernel] [PATCH 2/8] staging: rtl8723bs: hal: rtl8723b_phycfg.c: Remove unnecessary parentheses
  2019-03-30  5:12 [Outreachy kernel] [PATCH 0/8]staging: rtl8723bs: Remove unnecessary parentheses Payal Kshirsagar
  2019-03-30  5:12 ` [Outreachy kernel] [PATCH 1/8] staging: rtl8723bs: hal: sdio_ops.c: " Payal Kshirsagar
@ 2019-03-30  5:12 ` Payal Kshirsagar
  2019-03-30  5:12 ` [Outreachy kernel] [PATCH 3/8] staging: rtl8723bs: hal: hal_com.c: " Payal Kshirsagar
                   ` (5 subsequent siblings)
  7 siblings, 0 replies; 11+ messages in thread
From: Payal Kshirsagar @ 2019-03-30  5:12 UTC (permalink / raw)
  To: outreachy-kernel; +Cc: Payal Kshirsagar

Challenge suggested by coccinelle.
Remove unnecessary parentheses around an expression.

Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
---
 drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c b/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c
index 78a4828..0fd7a9a 100644
--- a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c
@@ -827,7 +827,7 @@ static u8 phy_GetSecondaryChnl_8723B(struct adapter *Adapter)
 	}
 
 	RT_TRACE(_module_hal_init_c_, _drv_info_, ("SCMapping: SC Value %x\n", ((SCSettingOf40 << 4) | SCSettingOf20)));
-	return  ((SCSettingOf40 << 4) | SCSettingOf20);
+	return  (SCSettingOf40 << 4) | SCSettingOf20;
 }
 
 static void phy_PostSetBwMode8723B(struct adapter *Adapter)
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 11+ messages in thread
* [Outreachy kernel] [PATCH 3/8] staging: rtl8723bs: hal: hal_com.c: Remove unnecessary parentheses
  2019-03-30  5:12 [Outreachy kernel] [PATCH 0/8]staging: rtl8723bs: Remove unnecessary parentheses Payal Kshirsagar
  2019-03-30  5:12 ` [Outreachy kernel] [PATCH 1/8] staging: rtl8723bs: hal: sdio_ops.c: " Payal Kshirsagar
  2019-03-30  5:12 ` [Outreachy kernel] [PATCH 2/8] staging: rtl8723bs: hal: rtl8723b_phycfg.c: " Payal Kshirsagar
@ 2019-03-30  5:12 ` Payal Kshirsagar
  2019-03-30  5:12 ` [Outreachy kernel] [PATCH 4/8] staging: rtl8723bs: hal: odm_HWConfig.c: " Payal Kshirsagar
                   ` (4 subsequent siblings)
  7 siblings, 0 replies; 11+ messages in thread
From: Payal Kshirsagar @ 2019-03-30  5:12 UTC (permalink / raw)
  To: outreachy-kernel; +Cc: Payal Kshirsagar

Challenge suggested by coccinelle.
Remove unnecessary parentheses around expressions.

Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
---
 drivers/staging/rtl8723bs/hal/hal_com.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/hal_com.c b/drivers/staging/rtl8723bs/hal/hal_com.c
index 7f8ec55..151e4e9 100644
--- a/drivers/staging/rtl8723bs/hal/hal_com.c
+++ b/drivers/staging/rtl8723bs/hal/hal_com.c
@@ -1389,11 +1389,11 @@ bool IsHexDigit(char chTmp)
 u32 MapCharToHexDigit(char chTmp)
 {
 	if (chTmp >= '0' && chTmp <= '9')
-		return (chTmp - '0');
+		return chTmp - '0';
 	else if (chTmp >= 'a' && chTmp <= 'f')
-		return (10 + (chTmp - 'a'));
+		return 10 + (chTmp - 'a');
 	else if (chTmp >= 'A' && chTmp <= 'F')
-		return (10 + (chTmp - 'A'));
+		return 10 + (chTmp - 'A');
 	else
 		return 0;
 }
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 11+ messages in thread
* [Outreachy kernel] [PATCH 4/8] staging: rtl8723bs: hal: odm_HWConfig.c: Remove unnecessary parentheses
  2019-03-30  5:12 [Outreachy kernel] [PATCH 0/8]staging: rtl8723bs: Remove unnecessary parentheses Payal Kshirsagar
                   ` (2 preceding siblings ...)
  2019-03-30  5:12 ` [Outreachy kernel] [PATCH 3/8] staging: rtl8723bs: hal: hal_com.c: " Payal Kshirsagar
@ 2019-03-30  5:12 ` Payal Kshirsagar
  2019-03-30  5:12 ` [Outreachy kernel] [PATCH 5/8] staging: rtl8723bs: core: rtw_mlme.c: " Payal Kshirsagar
                   ` (3 subsequent siblings)
  7 siblings, 0 replies; 11+ messages in thread
From: Payal Kshirsagar @ 2019-03-30  5:12 UTC (permalink / raw)
  To: outreachy-kernel; +Cc: Payal Kshirsagar

Challenge suggested by coccinelle.
Remove unnecessary parentheses around an expression, add spaces around
operator and remove trailing space.

Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
---
 drivers/staging/rtl8723bs/hal/odm_HWConfig.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/hal/odm_HWConfig.c b/drivers/staging/rtl8723bs/hal/odm_HWConfig.c
index ee2c293..d802a1f 100644
--- a/drivers/staging/rtl8723bs/hal/odm_HWConfig.c
+++ b/drivers/staging/rtl8723bs/hal/odm_HWConfig.c
@@ -19,7 +19,7 @@ static u8 odm_QueryRxPwrPercentage(s8 AntPower)
 	else if (AntPower >= 0)
 		return	100;
 	else
-		return	(100+AntPower);
+		return 100 + AntPower;
 
 }
 
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 11+ messages in thread
* [Outreachy kernel] [PATCH 5/8] staging: rtl8723bs: core: rtw_mlme.c: Remove unnecessary parentheses
  2019-03-30  5:12 [Outreachy kernel] [PATCH 0/8]staging: rtl8723bs: Remove unnecessary parentheses Payal Kshirsagar
                   ` (3 preceding siblings ...)
  2019-03-30  5:12 ` [Outreachy kernel] [PATCH 4/8] staging: rtl8723bs: hal: odm_HWConfig.c: " Payal Kshirsagar
@ 2019-03-30  5:12 ` Payal Kshirsagar
  2019-03-30  5:12 ` [Outreachy kernel] [PATCH 6/8] staging: rtl8723bs: core: rtw_wlan_util.c: " Payal Kshirsagar
                   ` (2 subsequent siblings)
  7 siblings, 0 replies; 11+ messages in thread
From: Payal Kshirsagar @ 2019-03-30  5:12 UTC (permalink / raw)
  To: outreachy-kernel; +Cc: Payal Kshirsagar

Challenge suggested by coccinelle.
Remove unnecessary parentheses around expressions.

Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_mlme.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c
index 406e313..12661d7 100644
--- a/drivers/staging/rtl8723bs/core/rtw_mlme.c
+++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c
@@ -332,7 +332,7 @@ void rtw_generate_random_ibss(u8 *pibss)
 
 u8 *rtw_get_capability_from_ie(u8 *ie)
 {
-	return (ie + 8 + 2);
+	return ie + 8 + 2;
 }
 
 
@@ -347,7 +347,7 @@ u16 rtw_get_capability(struct wlan_bssid_ex *bss)
 
 u8 *rtw_get_beacon_interval_from_ie(u8 *ie)
 {
-	return (ie + 8);
+	return ie + 8;
 }
 
 
@@ -451,14 +451,14 @@ int is_same_network(struct wlan_bssid_ex *src, struct wlan_bssid_ex *dst, u8 fea
 	s_cap = le16_to_cpu(tmps);
 	d_cap = le16_to_cpu(tmpd);
 
-	return ((src->Ssid.SsidLength == dst->Ssid.SsidLength) &&
+	return (src->Ssid.SsidLength == dst->Ssid.SsidLength) &&
 		/* 	(src->Configuration.DSConfig == dst->Configuration.DSConfig) && */
 			((!memcmp(src->MacAddress, dst->MacAddress, ETH_ALEN))) &&
 			((!memcmp(src->Ssid.Ssid, dst->Ssid.Ssid, src->Ssid.SsidLength))) &&
 			((s_cap & WLAN_CAPABILITY_IBSS) ==
 			(d_cap & WLAN_CAPABILITY_IBSS)) &&
 			((s_cap & WLAN_CAPABILITY_BSS) ==
-			(d_cap & WLAN_CAPABILITY_BSS)));
+			(d_cap & WLAN_CAPABILITY_BSS));
 
 }
 
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 11+ messages in thread
* [Outreachy kernel] [PATCH 6/8] staging: rtl8723bs: core: rtw_wlan_util.c: Remove unnecessary parentheses
  2019-03-30  5:12 [Outreachy kernel] [PATCH 0/8]staging: rtl8723bs: Remove unnecessary parentheses Payal Kshirsagar
                   ` (4 preceding siblings ...)
  2019-03-30  5:12 ` [Outreachy kernel] [PATCH 5/8] staging: rtl8723bs: core: rtw_mlme.c: " Payal Kshirsagar
@ 2019-03-30  5:12 ` Payal Kshirsagar
  2019-03-30  5:12 ` [Outreachy kernel] [PATCH 7/8] staging: rtl8723bs: core: rtw_ieee80211.c: " Payal Kshirsagar
  2019-03-30  5:12 ` [Outreachy kernel] [PATCH 8/8] staging: rtl8723bs: os_dep: ioctl_linux.c: " Payal Kshirsagar
  7 siblings, 0 replies; 11+ messages in thread
From: Payal Kshirsagar @ 2019-03-30  5:12 UTC (permalink / raw)
  To: outreachy-kernel; +Cc: Payal Kshirsagar

Challenge suggested by coccinelle.
Remove unnecessary parentheses around an expression.

Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
index 2c17296..fdbf967 100644
--- a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
+++ b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
@@ -518,7 +518,7 @@ unsigned int decide_wait_for_beacon_timeout(unsigned int bcn_interval)
 	else if ((bcn_interval << 2) > WAIT_FOR_BCN_TO_MAX)
 		return WAIT_FOR_BCN_TO_MAX;
 	else
-		return ((bcn_interval << 2));
+		return bcn_interval << 2;
 }
 
 void invalidate_cam_all(struct adapter *padapter)
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 11+ messages in thread
* [Outreachy kernel] [PATCH 7/8] staging: rtl8723bs: core: rtw_ieee80211.c: Remove unnecessary parentheses
  2019-03-30  5:12 [Outreachy kernel] [PATCH 0/8]staging: rtl8723bs: Remove unnecessary parentheses Payal Kshirsagar
                   ` (5 preceding siblings ...)
  2019-03-30  5:12 ` [Outreachy kernel] [PATCH 6/8] staging: rtl8723bs: core: rtw_wlan_util.c: " Payal Kshirsagar
@ 2019-03-30  5:12 ` Payal Kshirsagar
  2019-03-30  5:12 ` [Outreachy kernel] [PATCH 8/8] staging: rtl8723bs: os_dep: ioctl_linux.c: " Payal Kshirsagar
  7 siblings, 0 replies; 11+ messages in thread
From: Payal Kshirsagar @ 2019-03-30  5:12 UTC (permalink / raw)
  To: outreachy-kernel; +Cc: Payal Kshirsagar

Challenge suggested by coccinelle.
Remove unnecessary parentheses around expressions.

Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
index ac203c0..aaf2743 100644
--- a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
+++ b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
@@ -114,7 +114,7 @@ u8 *rtw_set_fixed_ie(unsigned char *pbuf, unsigned int len, unsigned char *sourc
 {
 	memcpy((void *)pbuf, (void *)source, len);
 	*frlen = *frlen + len;
-	return (pbuf + len);
+	return pbuf + len;
 }
 
 /*  rtw_set_ie will update frame length */
@@ -136,7 +136,7 @@ u8 *rtw_set_ie
 
 	*frlen = *frlen + (len + 2);
 
-	return (pbuf + len + 2);
+	return pbuf + len + 2;
 }
 
 /*----------------------------------------------------------------------------
@@ -706,7 +706,7 @@ int rtw_get_sec_ie(u8 *in_ie, uint in_len, u8 *rsn_ie, u16 *rsn_len, u8 *wpa_ie,
 		}
 	}
 
-	return (*rsn_len + *wpa_len);
+	return *rsn_len + *wpa_len;
 }
 
 u8 rtw_is_wps_ie(u8 *ie_ptr, uint *wps_ielen)
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 11+ messages in thread
* [Outreachy kernel] [PATCH 8/8] staging: rtl8723bs: os_dep: ioctl_linux.c: Remove unnecessary parentheses
  2019-03-30  5:12 [Outreachy kernel] [PATCH 0/8]staging: rtl8723bs: Remove unnecessary parentheses Payal Kshirsagar
                   ` (6 preceding siblings ...)
  2019-03-30  5:12 ` [Outreachy kernel] [PATCH 7/8] staging: rtl8723bs: core: rtw_ieee80211.c: " Payal Kshirsagar
@ 2019-03-30  5:12 ` Payal Kshirsagar
  2019-03-30  6:43   ` Julia Lawall
  7 siblings, 1 reply; 11+ messages in thread
From: Payal Kshirsagar @ 2019-03-30  5:12 UTC (permalink / raw)
  To: outreachy-kernel; +Cc: Payal Kshirsagar

Challenge suggested by coccinelle.
Remove unnecessary parentheses around an expression and fix identation
issue.

Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
---
 drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
index 8fb03ef..e43ad33 100644
--- a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
+++ b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
@@ -961,7 +961,7 @@ static int rtw_wx_set_pmkid(struct net_device *dev,
         if (pPMK->cmd == IW_PMKSA_ADD) {
                 DBG_871X("[rtw_wx_set_pmkid] IW_PMKSA_ADD!\n");
                 if (!memcmp(strIssueBssid, strZeroMacAddress, ETH_ALEN))
-                    return(intReturn);
+			return intReturn;
                 else
                     intReturn = true;
 
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 11+ messages in thread
* Re: [Outreachy kernel] [PATCH 8/8] staging: rtl8723bs: os_dep: ioctl_linux.c: Remove unnecessary parentheses
  2019-03-30  5:12 ` [Outreachy kernel] [PATCH 8/8] staging: rtl8723bs: os_dep: ioctl_linux.c: " Payal Kshirsagar
@ 2019-03-30  6:43   ` Julia Lawall
  2019-03-30 12:34     ` Payal Kshirsagar
  0 siblings, 1 reply; 11+ messages in thread
From: Julia Lawall @ 2019-03-30  6:43 UTC (permalink / raw)
  To: Payal Kshirsagar; +Cc: outreachy-kernel



On Sat, 30 Mar 2019, Payal Kshirsagar wrote:

> Challenge suggested by coccinelle.
> Remove unnecessary parentheses around an expression and fix identation
> issue.
>
> Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
> ---
>  drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
> index 8fb03ef..e43ad33 100644
> --- a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
> +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
> @@ -961,7 +961,7 @@ static int rtw_wx_set_pmkid(struct net_device *dev,
>          if (pPMK->cmd == IW_PMKSA_ADD) {
>                  DBG_871X("[rtw_wx_set_pmkid] IW_PMKSA_ADD!\n");
>                  if (!memcmp(strIssueBssid, strZeroMacAddress, ETH_ALEN))
> -                    return(intReturn);
> +			return intReturn;
>                  else
>                      intReturn = true;

I think you could really make another patch in the series for the
indentation issue and fix up both branches of the if.  It looks a bit odd
now.

julia

>
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/c92a25aaae32172a4c04e3b1cdcbb676ba316672.1553921776.git.payal.s.kshirsagar.98%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>


^ permalink raw reply	[flat|nested] 11+ messages in thread
* Re: [Outreachy kernel] [PATCH 8/8] staging: rtl8723bs: os_dep: ioctl_linux.c: Remove unnecessary parentheses
  2019-03-30  6:43   ` Julia Lawall
@ 2019-03-30 12:34     ` Payal Kshirsagar
  0 siblings, 0 replies; 11+ messages in thread
From: Payal Kshirsagar @ 2019-03-30 12:34 UTC (permalink / raw)
  To: Julia Lawall; +Cc: outreachy-kernel

[-- Attachment #1: Type: text/plain, Size: 2485 bytes --]

On Sat, 30 Mar 2019 at 12:13, Julia Lawall <julia.lawall@lip6.fr> wrote:

>
>
> On Sat, 30 Mar 2019, Payal Kshirsagar wrote:
>
> > Challenge suggested by coccinelle.
> > Remove unnecessary parentheses around an expression and fix identation
> > issue.
> >
> > Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
> > ---
> >  drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
> b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
> > index 8fb03ef..e43ad33 100644
> > --- a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
> > +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
> > @@ -961,7 +961,7 @@ static int rtw_wx_set_pmkid(struct net_device *dev,
> >          if (pPMK->cmd == IW_PMKSA_ADD) {
> >                  DBG_871X("[rtw_wx_set_pmkid] IW_PMKSA_ADD!\n");
> >                  if (!memcmp(strIssueBssid, strZeroMacAddress, ETH_ALEN))
> > -                    return(intReturn);
> > +                     return intReturn;
> >                  else
> >                      intReturn = true;
>
> I think you could really make another patch in the series for the
> indentation issue and fix up both branches of the if.  It looks a bit odd
> now.
>

Okay I will do corrections.
thanks,
payal


> julia
>
> >
> > --
> > 2.7.4
> >
> > --
> > You received this message because you are subscribed to the Google
> Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send
> an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit
> https://groups.google.com/d/msgid/outreachy-kernel/c92a25aaae32172a4c04e3b1cdcbb676ba316672.1553921776.git.payal.s.kshirsagar.98%40gmail.com
> .
> > For more options, visit https://groups.google.com/d/optout.
> >
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/outreachy-kernel/alpine.DEB.2.21.1903300742280.2817%40hadrien
> .
> For more options, visit https://groups.google.com/d/optout.
>

[-- Attachment #2: Type: text/html, Size: 4193 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread
end of thread, other threads:[~2019-03-30 12:34 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-30  5:12 [Outreachy kernel] [PATCH 0/8]staging: rtl8723bs: Remove unnecessary parentheses Payal Kshirsagar
2019-03-30  5:12 ` [Outreachy kernel] [PATCH 1/8] staging: rtl8723bs: hal: sdio_ops.c: " Payal Kshirsagar
2019-03-30  5:12 ` [Outreachy kernel] [PATCH 2/8] staging: rtl8723bs: hal: rtl8723b_phycfg.c: " Payal Kshirsagar
2019-03-30  5:12 ` [Outreachy kernel] [PATCH 3/8] staging: rtl8723bs: hal: hal_com.c: " Payal Kshirsagar
2019-03-30  5:12 ` [Outreachy kernel] [PATCH 4/8] staging: rtl8723bs: hal: odm_HWConfig.c: " Payal Kshirsagar
2019-03-30  5:12 ` [Outreachy kernel] [PATCH 5/8] staging: rtl8723bs: core: rtw_mlme.c: " Payal Kshirsagar
2019-03-30  5:12 ` [Outreachy kernel] [PATCH 6/8] staging: rtl8723bs: core: rtw_wlan_util.c: " Payal Kshirsagar
2019-03-30  5:12 ` [Outreachy kernel] [PATCH 7/8] staging: rtl8723bs: core: rtw_ieee80211.c: " Payal Kshirsagar
2019-03-30  5:12 ` [Outreachy kernel] [PATCH 8/8] staging: rtl8723bs: os_dep: ioctl_linux.c: " Payal Kshirsagar
2019-03-30  6:43   ` Julia Lawall
2019-03-30 12:34     ` Payal Kshirsagar

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.