[PATCH V2 0/1] runqemu: do not check return code of tput

[PATCH V2 0/1] runqemu: do not check return code of tput

[Chen Qi]

Changes in V2:
* Add comments in runqemu script to make clear that we are deliberately ignoring the return code.

The following changes since commit 9f7092416c40a96d9567bde99475de15a30e4989:

  insane.bbclass: Trigger unrecognzed configure option for meson (2019-04-11 21:15:57 +0100)

are available in the git repository at:

  git://git.pokylinux.org/poky-contrib ChenQi/qemu-tput
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=ChenQi/qemu-tput

Chen Qi (1):
  runqemu: do not check return code of tput

 scripts/runqemu | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

-- 
1.9.1

[PATCH V2 1/1] runqemu: do not check return code of tput

[Chen Qi]

The subprocess.run was replaced by subprocess.check_call because
of compatibility support down to python 3.4. But we really don't
care about whether that command succeeds. Some user reports that
in some tmux environment, this command fails and gives some
unpleasant traceback output. So we use 'call' instead of 'check_call'
to avoid such problem.

Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
---
 scripts/runqemu | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/scripts/runqemu b/scripts/runqemu
index c0e569c..a4fc606 100755
--- a/scripts/runqemu
+++ b/scripts/runqemu
@@ -1329,7 +1329,8 @@ def main():
             logger.info("SIGTERM received")
             os.kill(config.qemupid, signal.SIGTERM)
             config.cleanup()
-            subprocess.check_call(["tput", "smam"])
+            # Deliberately ignore the return code of 'tput smam'.
+            subprocess.call(["tput", "smam"])
         signal.signal(signal.SIGTERM, sigterm_handler)
 
         config.check_args()
@@ -1351,7 +1352,8 @@ def main():
         return 1
     finally:
         config.cleanup()
-        subprocess.check_call(["tput", "smam"])
+        # Deliberately ignore the return code of 'tput smam'.
+        subprocess.call(["tput", "smam"])
 
 if __name__ == "__main__":
     sys.exit(main())
-- 
1.9.1