All of lore.kernel.org
 help / color / mirror / Atom feed
* [MPTCP] [PATCH 0/3] mptcp: fix for ipv6-related oops
@ 2019-11-21 12:25 Paolo Abeni
  0 siblings, 0 replies; 2+ messages in thread
From: Paolo Abeni @ 2019-11-21 12:25 UTC (permalink / raw)
  To: mptcp

[-- Attachment #1: Type: text/plain, Size: 785 bytes --]

We need to allocate a larger struct sock for mptcp v6 master sockets,
otherwise inet6_sk() will access mptcp related data instead of
struct ipv6_pinfo.

This should fix the crash reported by Matt.

The protocol.c code changes are split in 2 patches to simplify the
squashing.
(yep, I know we somewhat agreed to big giant rebase, but this specific
should be trivial).

Additionally adds some fixlet for the ipv6 tests

Paolo Abeni (3):
  selftests: fixup for IPv6 tests
  mptcp: use ipv6-specific proto struct
  mptcp/ipv6: mptcp_v6_prot needs costom destroy.

 net/mptcp/protocol.c                          | 17 ++++++++++--
 .../selftests/net/mptcp/mptcp_connect.sh      | 27 +++++++++----------
 2 files changed, 27 insertions(+), 17 deletions(-)

-- 
2.21.0

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [MPTCP] [PATCH 0/3] mptcp: fix for ipv6-related oops
@ 2019-11-21 15:41 Paolo Abeni
  0 siblings, 0 replies; 2+ messages in thread
From: Paolo Abeni @ 2019-11-21 15:41 UTC (permalink / raw)
  To: mptcp

[-- Attachment #1: Type: text/plain, Size: 986 bytes --]

We need to allocate a larger struct sock for mptcp v6 master sockets,
otherwise inet6_sk() will access mptcp related data instead of
struct ipv6_pinfo.

This should fix the crash reported by Matt.

The protocol.c code changes are split in 2 patches to simplify the
squashing.
(yep, I know we somewhat agreed to big giant rebase, but this specific
should be trivial).

Additionally adds some fixlet for the ipv6 tests

v1 -> v2:
 - address Matt feedback on patches 1 && 2
 - add missing mptcp_v6 proto registration (I don't know why the previous
   iteration of these patches did not explode without that!!! :(((

Paolo Abeni (3):
  selftests: fixup for IPv6 tests
  mptcp: use ipv6-specific proto struct
  mptcp/ipv6: mptcp_v6_prot needs costom destroy.

 net/mptcp/protocol.c                          | 24 +++++++++++--
 .../selftests/net/mptcp/mptcp_connect.sh      | 34 ++++++-------------
 2 files changed, 33 insertions(+), 25 deletions(-)

-- 
2.21.0

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-11-21 15:41 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-21 12:25 [MPTCP] [PATCH 0/3] mptcp: fix for ipv6-related oops Paolo Abeni
2019-11-21 15:41 Paolo Abeni

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.