* [PATCH 0/2] Staging: media: rkisp1: trim diagram in comments to 80 chars
@ 2020-03-15 18:59 Enrique Vargas
2020-03-15 19:00 ` [PATCH 1/2] Staging: media: rkisp1: reduce comments width bellow " Enrique Vargas
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Enrique Vargas @ 2020-03-15 18:59 UTC (permalink / raw)
To: Helen Koike, Mauro Carvalho Chehab, Greg Kroah-Hartman, outreachy-kernel
Cc: linux-usb
*** BLURB HERE ***
Enrique Vargas (2):
reduce comments width bellow 80 chars
eliminate trailing whitespaces on comments
drivers/staging/media/rkisp1/rkisp1-dev.c | 54 ++++++++++++++++-------
1 file changed, 37 insertions(+), 17 deletions(-)
--
2.17.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] Staging: media: rkisp1: reduce comments width bellow 80 chars
2020-03-15 18:59 [PATCH 0/2] Staging: media: rkisp1: trim diagram in comments to 80 chars Enrique Vargas
@ 2020-03-15 19:00 ` Enrique Vargas
2020-03-16 11:32 ` Helen Koike
2020-03-15 19:01 ` [PATCH 2/2] Staging: media: rkisp1: eliminate trailing whitespaces on comments Enrique Vargas
2020-03-16 11:32 ` [PATCH 0/2] Staging: media: rkisp1: trim diagram in comments to 80 chars Helen Koike
2 siblings, 1 reply; 5+ messages in thread
From: Enrique Vargas @ 2020-03-15 19:00 UTC (permalink / raw)
To: Helen Koike, Mauro Carvalho Chehab, Greg Kroah-Hartman, outreachy-kernel
Cc: linux-usb
Make 'Main Picture Path' part of block diagram on separate rows to avoid
80 chars WARNING found with checkpatch.
Signed-off-by: Enrique Vargas <jevargas@seas.upenn.edu>
---
drivers/staging/media/rkisp1/rkisp1-dev.c | 57 ++++++++++++++++-------
1 file changed, 39 insertions(+), 18 deletions(-)
diff --git a/drivers/staging/media/rkisp1/rkisp1-dev.c b/drivers/staging/media/rkisp1/rkisp1-dev.c
index 558126e66465..194fc33941f0 100644
--- a/drivers/staging/media/rkisp1/rkisp1-dev.c
+++ b/drivers/staging/media/rkisp1/rkisp1-dev.c
@@ -37,26 +37,47 @@
*
* ISP Block Diagram
* -----------------
- * rkisp1-resizer.c rkisp1-capture.c
- * |====================| |=======================|
- * rkisp1-isp.c Main Picture Path
- * |==========================| |===============================================|
- * +-----------+ +--+--+--+--+ +--------+ +--------+ +-----------+
- * | | | | | | | | | | | | |
- * +--------+ |\ | | | | | | | -->| Crop |->| RSZ |------------->| |
- * | MIPI |--->| \ | | | | | | | | | | | | | |
- * +--------+ | | | | |IE|IE|IE|IE| | +--------+ +--------+ | Memory |
- * |MUX|--->| ISP |->|0 |1 |2 |3 |---+ | Interface |
- * +--------+ | | | | | | | | | | +--------+ +--------+ +--------+ | |
- * |Parallel|--->| / | | | | | | | | | | | | | | | |
- * +--------+ |/ | | | | | | | -->| Crop |->| RSZ |->| RGB |->| |
- * | | | | | | | | | | | | Rotate | | |
- * +-----------+ +--+--+--+--+ +--------+ +--------+ +--------+ +-----------+
+ *
+ *
+ * rkisp1-isp.c
+ * |==========================|
+ * +-----------+ +--+--+--+--+
+ * | | | | | | |
+ * +--------+ |\ | | | | | | |
+ * | MIPI |--->| \ | | | | | | |
+ * +--------+ | | | | |IE|IE|IE|IE|
+ * |MUX|--->| ISP |->|0 |1 |2 |3 |--[A]--
+ * +--------+ | | | | | | | | |
+ * |Parallel|--->| / | | | | | | |
+ * +--------+ |/ | | | | | | |
+ * | | | | | | |
+ * +-----------+ +--+--+--+--+
* ^
- * +--------+ | |===============================================|
- * | DMA |------------------------------------+ Self Picture Path
+ * +--------+ |
+ * | DMA |------------------------------------+
* +--------+
- *
+ *
+ *
+ * rkisp1-resizer.c rkisp1-capture.c
+ * |====================| |=======================|
+ * Main Picture Path
+ * |===============================================|
+ * +--------+ +--------+ +-----------+
+ * | | | | | |
+ * -->| Crop |->| RSZ |------------->| |
+ * | | | | | | |
+ * | +--------+ +--------+ | Memory |
+ * --[A]---+ | Interface |
+ * | +--------+ +--------+ +--------+ | |
+ * | | | | | | | | |
+ * -->| Crop |->| RSZ |->| RGB |->| |
+ * | | | | | Rotate | | |
+ * +--------+ +--------+ +--------+ +-----------+
+ *
+ * |===============================================|
+ * Self Picture Path
+ *
+ *
* rkisp1-stats.c rkisp1-params.c
* |===============| |===============|
* +---------------+ +---------------+
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] Staging: media: rkisp1: eliminate trailing whitespaces on comments
2020-03-15 18:59 [PATCH 0/2] Staging: media: rkisp1: trim diagram in comments to 80 chars Enrique Vargas
2020-03-15 19:00 ` [PATCH 1/2] Staging: media: rkisp1: reduce comments width bellow " Enrique Vargas
@ 2020-03-15 19:01 ` Enrique Vargas
2020-03-16 11:32 ` [PATCH 0/2] Staging: media: rkisp1: trim diagram in comments to 80 chars Helen Koike
2 siblings, 0 replies; 5+ messages in thread
From: Enrique Vargas @ 2020-03-15 19:01 UTC (permalink / raw)
To: Helen Koike, Mauro Carvalho Chehab, Greg Kroah-Hartman, outreachy-kernel
Cc: linux-usb
Eliminate lines with trailing whitespaces in block diagram. Found with
checkpatch.
Signed-off-by: Enrique Vargas <jevargas@seas.upenn.edu>
---
drivers/staging/media/rkisp1/rkisp1-dev.c | 41 +++++++++++------------
1 file changed, 20 insertions(+), 21 deletions(-)
diff --git a/drivers/staging/media/rkisp1/rkisp1-dev.c b/drivers/staging/media/rkisp1/rkisp1-dev.c
index 194fc33941f0..faa8538b9fea 100644
--- a/drivers/staging/media/rkisp1/rkisp1-dev.c
+++ b/drivers/staging/media/rkisp1/rkisp1-dev.c
@@ -37,27 +37,26 @@
*
* ISP Block Diagram
* -----------------
- *
- *
- * rkisp1-isp.c
- * |==========================|
- * +-----------+ +--+--+--+--+
- * | | | | | | |
- * +--------+ |\ | | | | | | |
- * | MIPI |--->| \ | | | | | | |
- * +--------+ | | | | |IE|IE|IE|IE|
+ *
+ * rkisp1-isp.c
+ * |==========================|
+ * +-----------+ +--+--+--+--+
+ * | | | | | | |
+ * +--------+ |\ | | | | | | |
+ * | MIPI |--->| \ | | | | | | |
+ * +--------+ | | | | |IE|IE|IE|IE|
* |MUX|--->| ISP |->|0 |1 |2 |3 |--[A]--
- * +--------+ | | | | | | | | |
- * |Parallel|--->| / | | | | | | |
- * +--------+ |/ | | | | | | |
- * | | | | | | |
- * +-----------+ +--+--+--+--+
+ * +--------+ | | | | | | | | |
+ * |Parallel|--->| / | | | | | | |
+ * +--------+ |/ | | | | | | |
+ * | | | | | | |
+ * +-----------+ +--+--+--+--+
* ^
- * +--------+ |
- * | DMA |------------------------------------+
+ * +--------+ |
+ * | DMA |------------------------------------+
* +--------+
- *
- *
+ *
+ *
* rkisp1-resizer.c rkisp1-capture.c
* |====================| |=======================|
* Main Picture Path
@@ -73,11 +72,11 @@
* -->| Crop |->| RSZ |->| RGB |->| |
* | | | | | Rotate | | |
* +--------+ +--------+ +--------+ +-----------+
- *
+ *
* |===============================================|
* Self Picture Path
- *
- *
+ *
+ *
* rkisp1-stats.c rkisp1-params.c
* |===============| |===============|
* +---------------+ +---------------+
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] Staging: media: rkisp1: reduce comments width bellow 80 chars
2020-03-15 19:00 ` [PATCH 1/2] Staging: media: rkisp1: reduce comments width bellow " Enrique Vargas
@ 2020-03-16 11:32 ` Helen Koike
0 siblings, 0 replies; 5+ messages in thread
From: Helen Koike @ 2020-03-16 11:32 UTC (permalink / raw)
To: Enrique Vargas, Mauro Carvalho Chehab, Greg Kroah-Hartman,
outreachy-kernel
Cc: linux-usb
Hi Enric,
On 3/15/20 4:00 PM, Enrique Vargas wrote:
> Make 'Main Picture Path' part of block diagram on separate rows to avoid
> 80 chars WARNING found with checkpatch.
>
> Signed-off-by: Enrique Vargas <jevargas@seas.upenn.edu>
> ---
> drivers/staging/media/rkisp1/rkisp1-dev.c | 57 ++++++++++++++++-------
> 1 file changed, 39 insertions(+), 18 deletions(-)
>
> diff --git a/drivers/staging/media/rkisp1/rkisp1-dev.c b/drivers/staging/media/rkisp1/rkisp1-dev.c
> index 558126e66465..194fc33941f0 100644
> --- a/drivers/staging/media/rkisp1/rkisp1-dev.c
> +++ b/drivers/staging/media/rkisp1/rkisp1-dev.c
> @@ -37,26 +37,47 @@
> *
> * ISP Block Diagram
> * -----------------
> - * rkisp1-resizer.c rkisp1-capture.c
> - * |====================| |=======================|
> - * rkisp1-isp.c Main Picture Path
> - * |==========================| |===============================================|
> - * +-----------+ +--+--+--+--+ +--------+ +--------+ +-----------+
> - * | | | | | | | | | | | | |
> - * +--------+ |\ | | | | | | | -->| Crop |->| RSZ |------------->| |
> - * | MIPI |--->| \ | | | | | | | | | | | | | |
> - * +--------+ | | | | |IE|IE|IE|IE| | +--------+ +--------+ | Memory |
> - * |MUX|--->| ISP |->|0 |1 |2 |3 |---+ | Interface |
> - * +--------+ | | | | | | | | | | +--------+ +--------+ +--------+ | |
> - * |Parallel|--->| / | | | | | | | | | | | | | | | |
> - * +--------+ |/ | | | | | | | -->| Crop |->| RSZ |->| RGB |->| |
> - * | | | | | | | | | | | | Rotate | | |
> - * +-----------+ +--+--+--+--+ +--------+ +--------+ +--------+ +-----------+
To be honest, I prefer the old way, I think it is easier to visualize.
But lets see what others think.
> + *
> + *
> + * rkisp1-isp.c
> + * |==========================|
> + * +-----------+ +--+--+--+--+
> + * | | | | | | |
> + * +--------+ |\ | | | | | | |
> + * | MIPI |--->| \ | | | | | | |
> + * +--------+ | | | | |IE|IE|IE|IE|
> + * |MUX|--->| ISP |->|0 |1 |2 |3 |--[A]--
> + * +--------+ | | | | | | | | |
> + * |Parallel|--->| / | | | | | | |
> + * +--------+ |/ | | | | | | |
> + * | | | | | | |
> + * +-----------+ +--+--+--+--+
You can eliminate the trailing spaces in this patch, since it was generated due to this
line break, so you don't need the second patch.
Regards,
Helen
> * ^
> - * +--------+ | |===============================================|
> - * | DMA |------------------------------------+ Self Picture Path
> + * +--------+ |
> + * | DMA |------------------------------------+
> * +--------+
> - *
> + *
> + *
> + * rkisp1-resizer.c rkisp1-capture.c
> + * |====================| |=======================|
> + * Main Picture Path
> + * |===============================================|
> + * +--------+ +--------+ +-----------+
> + * | | | | | |
> + * -->| Crop |->| RSZ |------------->| |
> + * | | | | | | |
> + * | +--------+ +--------+ | Memory |
> + * --[A]---+ | Interface |
> + * | +--------+ +--------+ +--------+ | |
> + * | | | | | | | | |
> + * -->| Crop |->| RSZ |->| RGB |->| |
> + * | | | | | Rotate | | |
> + * +--------+ +--------+ +--------+ +-----------+
> + *
> + * |===============================================|
> + * Self Picture Path
> + *
> + *
> * rkisp1-stats.c rkisp1-params.c
> * |===============| |===============|
> * +---------------+ +---------------+
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 0/2] Staging: media: rkisp1: trim diagram in comments to 80 chars
2020-03-15 18:59 [PATCH 0/2] Staging: media: rkisp1: trim diagram in comments to 80 chars Enrique Vargas
2020-03-15 19:00 ` [PATCH 1/2] Staging: media: rkisp1: reduce comments width bellow " Enrique Vargas
2020-03-15 19:01 ` [PATCH 2/2] Staging: media: rkisp1: eliminate trailing whitespaces on comments Enrique Vargas
@ 2020-03-16 11:32 ` Helen Koike
2 siblings, 0 replies; 5+ messages in thread
From: Helen Koike @ 2020-03-16 11:32 UTC (permalink / raw)
To: Enrique Vargas, Mauro Carvalho Chehab, Greg Kroah-Hartman,
outreachy-kernel
Cc: linux-usb
Hi Enrique,
On 3/15/20 3:59 PM, Enrique Vargas wrote:
> *** BLURB HERE ***
I think you forgot to fill out the cover letter.
Please, see more information on https://kernelnewbies.org/PatchSeries
Let me know if you have any questions.
Regards,
Helen
>
> Enrique Vargas (2):
> reduce comments width bellow 80 chars
> eliminate trailing whitespaces on comments
>
> drivers/staging/media/rkisp1/rkisp1-dev.c | 54 ++++++++++++++++-------
> 1 file changed, 37 insertions(+), 17 deletions(-)
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-03-16 11:32 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-15 18:59 [PATCH 0/2] Staging: media: rkisp1: trim diagram in comments to 80 chars Enrique Vargas
2020-03-15 19:00 ` [PATCH 1/2] Staging: media: rkisp1: reduce comments width bellow " Enrique Vargas
2020-03-16 11:32 ` Helen Koike
2020-03-15 19:01 ` [PATCH 2/2] Staging: media: rkisp1: eliminate trailing whitespaces on comments Enrique Vargas
2020-03-16 11:32 ` [PATCH 0/2] Staging: media: rkisp1: trim diagram in comments to 80 chars Helen Koike
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.