* [OE-core][dunfell 01/16] u-boot.inc: install u-boot-initial-env as ${PN}-initial-env in $D and $DEPLOYDIR
2020-04-29 16:10 [OE-core][dunfell 00/16] Patch review Steve Sakoman
@ 2020-04-29 16:10 ` Steve Sakoman
2020-04-29 16:10 ` [OE-core][dunfell 02/16] bzip2/pbzip2: Correct license information Steve Sakoman
` (14 subsequent siblings)
15 siblings, 0 replies; 30+ messages in thread
From: Steve Sakoman @ 2020-04-29 16:10 UTC (permalink / raw)
To: openembedded-core
From: Denys Dmytriyenko <denys@ti.com>
The common u-boot.inc can be used by multiple recipes in the same build for
different cores and/or multiple stages of the bootloader. Naming initial-env
with ${PN} prefix avoids clashes in deploy and rootfs between those recipes.
This fixes 69b3b093079c2ca2744d6c02747c5d1b5d3e7ecf that unconditionally
builds, installs and deploys u-boot-initial-env in the common u-boot.inc.
Signed-off-by: Denys Dmytriyenko <denys@ti.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Steve Sakoman <steve@sakoman.com>
---
meta/recipes-bsp/u-boot/u-boot.inc | 28 ++++++++++++++--------------
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/meta/recipes-bsp/u-boot/u-boot.inc b/meta/recipes-bsp/u-boot/u-boot.inc
index 188e5295cf..80f828df52 100644
--- a/meta/recipes-bsp/u-boot/u-boot.inc
+++ b/meta/recipes-bsp/u-boot/u-boot.inc
@@ -156,10 +156,10 @@ do_install () {
ln -sf u-boot-${type}-${PV}-${PR}.${UBOOT_SUFFIX} ${D}/boot/${UBOOT_BINARY}
# Install the uboot-initial-env
- install -D -m 644 ${B}/${config}/u-boot-initial-env-${type} ${D}/${sysconfdir}/u-boot-initial-env-${MACHINE}-${type}-${PV}-${PR}
- ln -sf u-boot-initial-env-${MACHINE}-${type}-${PV}-${PR} ${D}/${sysconfdir}/u-boot-initial-env-${MACHINE}-${type}
- ln -sf u-boot-initial-env-${MACHINE}-${type}-${PV}-${PR} ${D}/${sysconfdir}/u-boot-initial-env-${type}
- ln -sf u-boot-initial-env-${MACHINE}-${type}-${PV}-${PR} ${D}/${sysconfdir}/u-boot-initial-env
+ install -D -m 644 ${B}/${config}/u-boot-initial-env-${type} ${D}/${sysconfdir}/${PN}-initial-env-${MACHINE}-${type}-${PV}-${PR}
+ ln -sf ${PN}-initial-env-${MACHINE}-${type}-${PV}-${PR} ${D}/${sysconfdir}/${PN}-initial-env-${MACHINE}-${type}
+ ln -sf ${PN}-initial-env-${MACHINE}-${type}-${PV}-${PR} ${D}/${sysconfdir}/${PN}-initial-env-${type}
+ ln -sf ${PN}-initial-env-${MACHINE}-${type}-${PV}-${PR} ${D}/${sysconfdir}/${PN}-initial-env
fi
done
unset j
@@ -170,9 +170,9 @@ do_install () {
ln -sf ${UBOOT_IMAGE} ${D}/boot/${UBOOT_BINARY}
# Install the uboot-initial-env
- install -D -m 644 ${B}/u-boot-initial-env ${D}/${sysconfdir}/u-boot-initial-env-${MACHINE}-${PV}-${PR}
- ln -sf u-boot-initial-env-${MACHINE}-${PV}-${PR} ${D}/${sysconfdir}/u-boot-initial-env-${MACHINE}
- ln -sf u-boot-initial-env-${MACHINE}-${PV}-${PR} ${D}/${sysconfdir}/u-boot-initial-env
+ install -D -m 644 ${B}/u-boot-initial-env ${D}/${sysconfdir}/${PN}-initial-env-${MACHINE}-${PV}-${PR}
+ ln -sf ${PN}-initial-env-${MACHINE}-${PV}-${PR} ${D}/${sysconfdir}/${PN}-initial-env-${MACHINE}
+ ln -sf ${PN}-initial-env-${MACHINE}-${PV}-${PR} ${D}/${sysconfdir}/${PN}-initial-env
fi
if [ -n "${UBOOT_ELF}" ]
@@ -245,7 +245,7 @@ PACKAGE_BEFORE_PN += "${PN}-env"
RPROVIDES_${PN}-env += "u-boot-default-env"
FILES_${PN}-env = " \
- ${sysconfdir}/u-boot-initial-env* \
+ ${sysconfdir}/${PN}-initial-env* \
${sysconfdir}/fw_env.config \
"
@@ -269,10 +269,10 @@ do_deploy () {
ln -sf u-boot-${type}-${PV}-${PR}.${UBOOT_SUFFIX} ${UBOOT_BINARY}
# Deploy the uboot-initial-env
- install -D -m 644 ${B}/${config}/u-boot-initial-env-${type} ${DEPLOYDIR}/u-boot-initial-env-${MACHINE}-${type}-${PV}-${PR}
+ install -D -m 644 ${B}/${config}/u-boot-initial-env-${type} ${DEPLOYDIR}/${PN}-initial-env-${MACHINE}-${type}-${PV}-${PR}
cd ${DEPLOYDIR}
- ln -sf u-boot-initial-env-${MACHINE}-${type}-${PV}-${PR} u-boot-initial-env-${MACHINE}-${type}
- ln -sf u-boot-initial-env-${MACHINE}-${type}-${PV}-${PR} u-boot-initial-env-${type}
+ ln -sf ${PN}-initial-env-${MACHINE}-${type}-${PV}-${PR} ${PN}-initial-env-${MACHINE}-${type}
+ ln -sf ${PN}-initial-env-${MACHINE}-${type}-${PV}-${PR} ${PN}-initial-env-${type}
fi
done
unset j
@@ -287,10 +287,10 @@ do_deploy () {
ln -sf ${UBOOT_IMAGE} ${UBOOT_BINARY}
# Deploy the uboot-initial-env
- install -D -m 644 ${B}/u-boot-initial-env ${DEPLOYDIR}/u-boot-initial-env-${MACHINE}-${PV}-${PR}
+ install -D -m 644 ${B}/u-boot-initial-env ${DEPLOYDIR}/${PN}-initial-env-${MACHINE}-${PV}-${PR}
cd ${DEPLOYDIR}
- ln -sf u-boot-initial-env-${MACHINE}-${PV}-${PR} u-boot-initial-env-${MACHINE}
- ln -sf u-boot-initial-env-${MACHINE}-${PV}-${PR} u-boot-initial-env
+ ln -sf ${PN}-initial-env-${MACHINE}-${PV}-${PR} ${PN}-initial-env-${MACHINE}
+ ln -sf ${PN}-initial-env-${MACHINE}-${PV}-${PR} ${PN}-initial-env
fi
if [ -e ${WORKDIR}/fw_env.config ] ; then
--
2.17.1
^ permalink raw reply related [flat|nested] 30+ messages in thread* [OE-core][dunfell 02/16] bzip2/pbzip2: Correct license information
2020-04-29 16:10 [OE-core][dunfell 00/16] Patch review Steve Sakoman
2020-04-29 16:10 ` [OE-core][dunfell 01/16] u-boot.inc: install u-boot-initial-env as ${PN}-initial-env in $D and $DEPLOYDIR Steve Sakoman
@ 2020-04-29 16:10 ` Steve Sakoman
2020-04-29 19:13 ` Andre McCurdy
2020-04-29 16:10 ` [OE-core][dunfell 03/16] kernel-yocto.bbclass: Fix deps when externalsrc is used Steve Sakoman
` (13 subsequent siblings)
15 siblings, 1 reply; 30+ messages in thread
From: Steve Sakoman @ 2020-04-29 16:10 UTC (permalink / raw)
To: openembedded-core
From: Richard Purdie <richard.purdie@linuxfoundation.org>
The license of pbzip2 looks slightly BSD like but is in fact the bzip2
license. The SPDX identifier for this is "bzip-1.0.6" since there is
another version of the bzip license out there.
To clear up all the confusion, use the SPDX license name and update
both recipes to refer to it. The copyright information is slightly
different between the codebases but the license looks the same.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Steve Sakoman <steve@sakoman.com>
---
meta/files/common-licenses/{bzip2 => bzip2-1.0.6} | 0
meta/recipes-extended/bzip2/bzip2_1.0.8.bb | 2 +-
meta/recipes-extended/pbzip2/pbzip2_1.1.13.bb | 2 +-
3 files changed, 2 insertions(+), 2 deletions(-)
rename meta/files/common-licenses/{bzip2 => bzip2-1.0.6} (100%)
diff --git a/meta/files/common-licenses/bzip2 b/meta/files/common-licenses/bzip2-1.0.6
similarity index 100%
rename from meta/files/common-licenses/bzip2
rename to meta/files/common-licenses/bzip2-1.0.6
diff --git a/meta/recipes-extended/bzip2/bzip2_1.0.8.bb b/meta/recipes-extended/bzip2/bzip2_1.0.8.bb
index 8e9b779e67..d58f553a49 100644
--- a/meta/recipes-extended/bzip2/bzip2_1.0.8.bb
+++ b/meta/recipes-extended/bzip2/bzip2_1.0.8.bb
@@ -4,7 +4,7 @@ Huffman coding. Compression is generally considerably better than that achieved
LZ77/LZ78-based compressors, and approaches the performance of the PPM family of statistical compressors."
HOMEPAGE = "https://sourceware.org/bzip2/"
SECTION = "console/utils"
-LICENSE = "bzip2"
+LICENSE = "bzip2-1.0.6"
LIC_FILES_CHKSUM = "file://LICENSE;beginline=4;endline=37;md5=600af43c50f1fcb82e32f19b32df4664"
SRC_URI = "https://sourceware.org/pub/${BPN}/${BPN}-${PV}.tar.gz \
diff --git a/meta/recipes-extended/pbzip2/pbzip2_1.1.13.bb b/meta/recipes-extended/pbzip2/pbzip2_1.1.13.bb
index 1275cc0097..d7450c73c1 100644
--- a/meta/recipes-extended/pbzip2/pbzip2_1.1.13.bb
+++ b/meta/recipes-extended/pbzip2/pbzip2_1.1.13.bb
@@ -5,7 +5,7 @@ machines. The output of this version is fully compatible with bzip2 v1.0.2 or \
newer (ie: anything compressed with pbzip2 can be decompressed with bzip2)."
HOMEPAGE = "http://compression.ca/pbzip2/"
SECTION = "console/utils"
-LICENSE = "BSD-4-Clause"
+LICENSE = "bzip-1.0.6"
LIC_FILES_CHKSUM = "file://COPYING;md5=398b8832c6f840cfebd20ab2be6a3743"
DEPENDS = "bzip2"
--
2.17.1
^ permalink raw reply related [flat|nested] 30+ messages in thread* Re: [OE-core][dunfell 02/16] bzip2/pbzip2: Correct license information
2020-04-29 16:10 ` [OE-core][dunfell 02/16] bzip2/pbzip2: Correct license information Steve Sakoman
@ 2020-04-29 19:13 ` Andre McCurdy
2020-04-29 22:12 ` Steve Sakoman
` (2 more replies)
0 siblings, 3 replies; 30+ messages in thread
From: Andre McCurdy @ 2020-04-29 19:13 UTC (permalink / raw)
To: OE Core mailing list
On Wed, Apr 29, 2020 at 9:11 AM Steve Sakoman <steve@sakoman.com> wrote:
>
> From: Richard Purdie <richard.purdie@linuxfoundation.org>
>
> The license of pbzip2 looks slightly BSD like but is in fact the bzip2
> license. The SPDX identifier for this is "bzip-1.0.6" since there is
> another version of the bzip license out there.
>
> To clear up all the confusion, use the SPDX license name and update
> both recipes to refer to it. The copyright information is slightly
> different between the codebases but the license looks the same.
>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> Signed-off-by: Steve Sakoman <steve@sakoman.com>
> ---
> meta/files/common-licenses/{bzip2 => bzip2-1.0.6} | 0
> meta/recipes-extended/bzip2/bzip2_1.0.8.bb | 2 +-
> meta/recipes-extended/pbzip2/pbzip2_1.1.13.bb | 2 +-
> 3 files changed, 2 insertions(+), 2 deletions(-)
> rename meta/files/common-licenses/{bzip2 => bzip2-1.0.6} (100%)
>
> diff --git a/meta/files/common-licenses/bzip2 b/meta/files/common-licenses/bzip2-1.0.6
> similarity index 100%
> rename from meta/files/common-licenses/bzip2
> rename to meta/files/common-licenses/bzip2-1.0.6
The corresponding update to the busybox recipe should be merged too.
> diff --git a/meta/recipes-extended/bzip2/bzip2_1.0.8.bb b/meta/recipes-extended/bzip2/bzip2_1.0.8.bb
> index 8e9b779e67..d58f553a49 100644
> --- a/meta/recipes-extended/bzip2/bzip2_1.0.8.bb
> +++ b/meta/recipes-extended/bzip2/bzip2_1.0.8.bb
> @@ -4,7 +4,7 @@ Huffman coding. Compression is generally considerably better than that achieved
> LZ77/LZ78-based compressors, and approaches the performance of the PPM family of statistical compressors."
> HOMEPAGE = "https://sourceware.org/bzip2/"
> SECTION = "console/utils"
> -LICENSE = "bzip2"
> +LICENSE = "bzip2-1.0.6"
> LIC_FILES_CHKSUM = "file://LICENSE;beginline=4;endline=37;md5=600af43c50f1fcb82e32f19b32df4664"
>
> SRC_URI = "https://sourceware.org/pub/${BPN}/${BPN}-${PV}.tar.gz \
> diff --git a/meta/recipes-extended/pbzip2/pbzip2_1.1.13.bb b/meta/recipes-extended/pbzip2/pbzip2_1.1.13.bb
> index 1275cc0097..d7450c73c1 100644
> --- a/meta/recipes-extended/pbzip2/pbzip2_1.1.13.bb
> +++ b/meta/recipes-extended/pbzip2/pbzip2_1.1.13.bb
> @@ -5,7 +5,7 @@ machines. The output of this version is fully compatible with bzip2 v1.0.2 or \
> newer (ie: anything compressed with pbzip2 can be decompressed with bzip2)."
> HOMEPAGE = "http://compression.ca/pbzip2/"
> SECTION = "console/utils"
> -LICENSE = "BSD-4-Clause"
> +LICENSE = "bzip-1.0.6"
> LIC_FILES_CHKSUM = "file://COPYING;md5=398b8832c6f840cfebd20ab2be6a3743"
>
> DEPENDS = "bzip2"
> --
> 2.17.1
>
>
^ permalink raw reply [flat|nested] 30+ messages in thread* Re: [OE-core][dunfell 02/16] bzip2/pbzip2: Correct license information
2020-04-29 19:13 ` Andre McCurdy
@ 2020-04-29 22:12 ` Steve Sakoman
[not found] ` <160A69FC1635E57D.20868@lists.openembedded.org>
2020-04-30 19:44 ` Denys Dmytriyenko
2 siblings, 0 replies; 30+ messages in thread
From: Steve Sakoman @ 2020-04-29 22:12 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
On Wed, Apr 29, 2020 at 9:13 AM Andre McCurdy <armccurdy@gmail.com> wrote:
> The corresponding update to the busybox recipe should be merged too.
Thanks, I'm picking that one up in the next batch.
Steve
> > diff --git a/meta/recipes-extended/bzip2/bzip2_1.0.8.bb b/meta/recipes-extended/bzip2/bzip2_1.0.8.bb
> > index 8e9b779e67..d58f553a49 100644
> > --- a/meta/recipes-extended/bzip2/bzip2_1.0.8.bb
> > +++ b/meta/recipes-extended/bzip2/bzip2_1.0.8.bb
> > @@ -4,7 +4,7 @@ Huffman coding. Compression is generally considerably better than that achieved
> > LZ77/LZ78-based compressors, and approaches the performance of the PPM family of statistical compressors."
> > HOMEPAGE = "https://sourceware.org/bzip2/"
> > SECTION = "console/utils"
> > -LICENSE = "bzip2"
> > +LICENSE = "bzip2-1.0.6"
> > LIC_FILES_CHKSUM = "file://LICENSE;beginline=4;endline=37;md5=600af43c50f1fcb82e32f19b32df4664"
> >
> > SRC_URI = "https://sourceware.org/pub/${BPN}/${BPN}-${PV}.tar.gz \
> > diff --git a/meta/recipes-extended/pbzip2/pbzip2_1.1.13.bb b/meta/recipes-extended/pbzip2/pbzip2_1.1.13.bb
> > index 1275cc0097..d7450c73c1 100644
> > --- a/meta/recipes-extended/pbzip2/pbzip2_1.1.13.bb
> > +++ b/meta/recipes-extended/pbzip2/pbzip2_1.1.13.bb
> > @@ -5,7 +5,7 @@ machines. The output of this version is fully compatible with bzip2 v1.0.2 or \
> > newer (ie: anything compressed with pbzip2 can be decompressed with bzip2)."
> > HOMEPAGE = "http://compression.ca/pbzip2/"
> > SECTION = "console/utils"
> > -LICENSE = "BSD-4-Clause"
> > +LICENSE = "bzip-1.0.6"
> > LIC_FILES_CHKSUM = "file://COPYING;md5=398b8832c6f840cfebd20ab2be6a3743"
> >
> > DEPENDS = "bzip2"
> > --
> > 2.17.1
> >
> >
>
^ permalink raw reply [flat|nested] 30+ messages in thread[parent not found: <160A69FC1635E57D.20868@lists.openembedded.org>]
* Re: [OE-core][dunfell 02/16] bzip2/pbzip2: Correct license information
[not found] ` <160A69FC1635E57D.20868@lists.openembedded.org>
@ 2020-04-30 15:53 ` Steve Sakoman
2020-04-30 19:37 ` Andre McCurdy
0 siblings, 1 reply; 30+ messages in thread
From: Steve Sakoman @ 2020-04-30 15:53 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
On Wed, Apr 29, 2020 at 12:12 PM Steve Sakoman via
lists.openembedded.org <sakoman=gmail.com@lists.openembedded.org>
wrote:
> > The corresponding update to the busybox recipe should be merged too.
>
> Thanks, I'm picking that one up in the next batch.
In fact, I'm going to move this patch to my next set and group all the
bzip license changes and fixes together.
Steve
> > > diff --git a/meta/recipes-extended/bzip2/bzip2_1.0.8.bb b/meta/recipes-extended/bzip2/bzip2_1.0.8.bb
> > > index 8e9b779e67..d58f553a49 100644
> > > --- a/meta/recipes-extended/bzip2/bzip2_1.0.8.bb
> > > +++ b/meta/recipes-extended/bzip2/bzip2_1.0.8.bb
> > > @@ -4,7 +4,7 @@ Huffman coding. Compression is generally considerably better than that achieved
> > > LZ77/LZ78-based compressors, and approaches the performance of the PPM family of statistical compressors."
> > > HOMEPAGE = "https://sourceware.org/bzip2/"
> > > SECTION = "console/utils"
> > > -LICENSE = "bzip2"
> > > +LICENSE = "bzip2-1.0.6"
> > > LIC_FILES_CHKSUM = "file://LICENSE;beginline=4;endline=37;md5=600af43c50f1fcb82e32f19b32df4664"
> > >
> > > SRC_URI = "https://sourceware.org/pub/${BPN}/${BPN}-${PV}.tar.gz \
> > > diff --git a/meta/recipes-extended/pbzip2/pbzip2_1.1.13.bb b/meta/recipes-extended/pbzip2/pbzip2_1.1.13.bb
> > > index 1275cc0097..d7450c73c1 100644
> > > --- a/meta/recipes-extended/pbzip2/pbzip2_1.1.13.bb
> > > +++ b/meta/recipes-extended/pbzip2/pbzip2_1.1.13.bb
> > > @@ -5,7 +5,7 @@ machines. The output of this version is fully compatible with bzip2 v1.0.2 or \
> > > newer (ie: anything compressed with pbzip2 can be decompressed with bzip2)."
> > > HOMEPAGE = "http://compression.ca/pbzip2/"
> > > SECTION = "console/utils"
> > > -LICENSE = "BSD-4-Clause"
> > > +LICENSE = "bzip-1.0.6"
> > > LIC_FILES_CHKSUM = "file://COPYING;md5=398b8832c6f840cfebd20ab2be6a3743"
> > >
> > > DEPENDS = "bzip2"
> > > --
> > > 2.17.1
> > >
> > >
> >
>
^ permalink raw reply [flat|nested] 30+ messages in thread* Re: [OE-core][dunfell 02/16] bzip2/pbzip2: Correct license information
2020-04-30 15:53 ` Steve Sakoman
@ 2020-04-30 19:37 ` Andre McCurdy
0 siblings, 0 replies; 30+ messages in thread
From: Andre McCurdy @ 2020-04-30 19:37 UTC (permalink / raw)
To: OE Core mailing list
On Thu, Apr 30, 2020 at 8:53 AM Steve Sakoman <sakoman@gmail.com> wrote:
>
> On Wed, Apr 29, 2020 at 12:12 PM Steve Sakoman via
> lists.openembedded.org <sakoman=gmail.com@lists.openembedded.org>
> wrote:
>
> > > The corresponding update to the busybox recipe should be merged too.
> >
> > Thanks, I'm picking that one up in the next batch.
>
> In fact, I'm going to move this patch to my next set and group all the
> bzip license changes and fixes together.
Sounds like the safest approach while the issues with this change are
still being fixed. Note that it's going to affect anyone with their
own custom recipe for busybox too, but maybe it's early enough in the
3.1 release cycle that it's still OK to break a few external recipes.
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [OE-core][dunfell 02/16] bzip2/pbzip2: Correct license information
2020-04-29 19:13 ` Andre McCurdy
2020-04-29 22:12 ` Steve Sakoman
[not found] ` <160A69FC1635E57D.20868@lists.openembedded.org>
@ 2020-04-30 19:44 ` Denys Dmytriyenko
2020-04-30 22:06 ` Steve Sakoman
2 siblings, 1 reply; 30+ messages in thread
From: Denys Dmytriyenko @ 2020-04-30 19:44 UTC (permalink / raw)
To: openembedded-core
On Wed, Apr 29, 2020 at 12:13:20PM -0700, Andre McCurdy wrote:
> On Wed, Apr 29, 2020 at 9:11 AM Steve Sakoman <steve@sakoman.com> wrote:
> >
> > From: Richard Purdie <richard.purdie@linuxfoundation.org>
> >
> > The license of pbzip2 looks slightly BSD like but is in fact the bzip2
> > license. The SPDX identifier for this is "bzip-1.0.6" since there is
> > another version of the bzip license out there.
> >
> > To clear up all the confusion, use the SPDX license name and update
> > both recipes to refer to it. The copyright information is slightly
> > different between the codebases but the license looks the same.
> >
> > Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> > Signed-off-by: Steve Sakoman <steve@sakoman.com>
> > ---
> > meta/files/common-licenses/{bzip2 => bzip2-1.0.6} | 0
> > meta/recipes-extended/bzip2/bzip2_1.0.8.bb | 2 +-
> > meta/recipes-extended/pbzip2/pbzip2_1.1.13.bb | 2 +-
> > 3 files changed, 2 insertions(+), 2 deletions(-)
> > rename meta/files/common-licenses/{bzip2 => bzip2-1.0.6} (100%)
> >
> > diff --git a/meta/files/common-licenses/bzip2 b/meta/files/common-licenses/bzip2-1.0.6
> > similarity index 100%
> > rename from meta/files/common-licenses/bzip2
> > rename to meta/files/common-licenses/bzip2-1.0.6
>
> The corresponding update to the busybox recipe should be merged too.
>
>
> > diff --git a/meta/recipes-extended/bzip2/bzip2_1.0.8.bb b/meta/recipes-extended/bzip2/bzip2_1.0.8.bb
> > index 8e9b779e67..d58f553a49 100644
> > --- a/meta/recipes-extended/bzip2/bzip2_1.0.8.bb
> > +++ b/meta/recipes-extended/bzip2/bzip2_1.0.8.bb
> > @@ -4,7 +4,7 @@ Huffman coding. Compression is generally considerably better than that achieved
> > LZ77/LZ78-based compressors, and approaches the performance of the PPM family of statistical compressors."
> > HOMEPAGE = "https://sourceware.org/bzip2/"
> > SECTION = "console/utils"
> > -LICENSE = "bzip2"
> > +LICENSE = "bzip2-1.0.6"
> > LIC_FILES_CHKSUM = "file://LICENSE;beginline=4;endline=37;md5=600af43c50f1fcb82e32f19b32df4664"
> >
> > SRC_URI = "https://sourceware.org/pub/${BPN}/${BPN}-${PV}.tar.gz \
> > diff --git a/meta/recipes-extended/pbzip2/pbzip2_1.1.13.bb b/meta/recipes-extended/pbzip2/pbzip2_1.1.13.bb
> > index 1275cc0097..d7450c73c1 100644
> > --- a/meta/recipes-extended/pbzip2/pbzip2_1.1.13.bb
> > +++ b/meta/recipes-extended/pbzip2/pbzip2_1.1.13.bb
> > @@ -5,7 +5,7 @@ machines. The output of this version is fully compatible with bzip2 v1.0.2 or \
> > newer (ie: anything compressed with pbzip2 can be decompressed with bzip2)."
> > HOMEPAGE = "http://compression.ca/pbzip2/"
> > SECTION = "console/utils"
> > -LICENSE = "BSD-4-Clause"
> > +LICENSE = "bzip-1.0.6"
And this is also incorrect - should be bzip2-1.0.6. There's a patch on the
list for this...
> > LIC_FILES_CHKSUM = "file://COPYING;md5=398b8832c6f840cfebd20ab2be6a3743"
> >
> > DEPENDS = "bzip2"
> > --
> > 2.17.1
> >
> >
>
^ permalink raw reply [flat|nested] 30+ messages in thread* Re: [OE-core][dunfell 02/16] bzip2/pbzip2: Correct license information
2020-04-30 19:44 ` Denys Dmytriyenko
@ 2020-04-30 22:06 ` Steve Sakoman
0 siblings, 0 replies; 30+ messages in thread
From: Steve Sakoman @ 2020-04-30 22:06 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
On Thu, Apr 30, 2020 at 9:45 AM Denys Dmytriyenko <denis@denix.org> wrote:
> And this is also incorrect - should be bzip2-1.0.6. There's a patch on the
> list for this...
Yes, that's why I'm going to omit this patch for now and pull in all
the related patches in one go in the next round.
Steve
> > > LIC_FILES_CHKSUM = "file://COPYING;md5=398b8832c6f840cfebd20ab2be6a3743"
> > >
> > > DEPENDS = "bzip2"
> > > --
> > > 2.17.1
> > >
> > >
>
> >
>
>
^ permalink raw reply [flat|nested] 30+ messages in thread
* [OE-core][dunfell 03/16] kernel-yocto.bbclass: Fix deps when externalsrc is used
2020-04-29 16:10 [OE-core][dunfell 00/16] Patch review Steve Sakoman
2020-04-29 16:10 ` [OE-core][dunfell 01/16] u-boot.inc: install u-boot-initial-env as ${PN}-initial-env in $D and $DEPLOYDIR Steve Sakoman
2020-04-29 16:10 ` [OE-core][dunfell 02/16] bzip2/pbzip2: Correct license information Steve Sakoman
@ 2020-04-29 16:10 ` Steve Sakoman
2020-04-29 16:10 ` [OE-core][dunfell 04/16] qemu-system-native: Fix commented out PACKAGECONFIG Steve Sakoman
` (12 subsequent siblings)
15 siblings, 0 replies; 30+ messages in thread
From: Steve Sakoman @ 2020-04-29 16:10 UTC (permalink / raw)
To: openembedded-core
From: Paul Barker <pbarker@konsulko.com>
do_kernel_configme was recently removed from SRCTREECOVEREDTASKS so this
task still runs when externalsrc is used. This task normally runs after
do_patch but when externalsrc is used, do_patch is removed and this ordering
restriction does nothing. This allows bitbake to execute do_kernel_configme
too early, causing races with do_unpack.
This is fixed by adding in a dependency on do_unpack when externalsrc is
used.
Signed-off-by: Paul Barker <pbarker@konsulko.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Steve Sakoman <steve@sakoman.com>
---
meta/classes/kernel-yocto.bbclass | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/meta/classes/kernel-yocto.bbclass b/meta/classes/kernel-yocto.bbclass
index 6792c9a233..5bc627066e 100644
--- a/meta/classes/kernel-yocto.bbclass
+++ b/meta/classes/kernel-yocto.bbclass
@@ -489,6 +489,12 @@ python () {
# If diffconfig is available, ensure it runs after kernel_configme
if 'do_diffconfig' in d:
bb.build.addtask('do_diffconfig', None, 'do_kernel_configme', d)
+
+ externalsrc = d.getVar('EXTERNALSRC')
+ if externalsrc:
+ # If we deltask do_patch, do_kernel_configme is left without
+ # dependencies and runs too early
+ d.setVarFlag('do_kernel_configme', 'deps', (d.getVarFlag('do_kernel_configme', 'deps', False) or []) + ['do_unpack'])
}
# extra tasks
--
2.17.1
^ permalink raw reply related [flat|nested] 30+ messages in thread* [OE-core][dunfell 04/16] qemu-system-native: Fix commented out PACKAGECONFIG
2020-04-29 16:10 [OE-core][dunfell 00/16] Patch review Steve Sakoman
` (2 preceding siblings ...)
2020-04-29 16:10 ` [OE-core][dunfell 03/16] kernel-yocto.bbclass: Fix deps when externalsrc is used Steve Sakoman
@ 2020-04-29 16:10 ` Steve Sakoman
2020-04-29 16:10 ` [OE-core][dunfell 05/16] nativesdk-gcc-runtime: enable building libstdc++.a Steve Sakoman
` (11 subsequent siblings)
15 siblings, 0 replies; 30+ messages in thread
From: Steve Sakoman @ 2020-04-29 16:10 UTC (permalink / raw)
To: openembedded-core
From: Jeremy Puhlman <jpuhlman@mvista.com>
Signed-off-by: Jeremy A. Puhlman <jpuhlman@mvista.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Steve Sakoman <steve@sakoman.com>
---
meta/recipes-devtools/qemu/qemu.inc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/recipes-devtools/qemu/qemu.inc b/meta/recipes-devtools/qemu/qemu.inc
index f17a046fca..7a1ccf2115 100644
--- a/meta/recipes-devtools/qemu/qemu.inc
+++ b/meta/recipes-devtools/qemu/qemu.inc
@@ -180,7 +180,7 @@ PACKAGECONFIG[snappy] = "--enable-snappy,--disable-snappy,snappy"
PACKAGECONFIG[glusterfs] = "--enable-glusterfs,--disable-glusterfs"
PACKAGECONFIG[xkbcommon] = "--enable-xkbcommon,--disable-xkbcommon,libxkbcommon"
PACKAGECONFIG[libudev] = "--enable-libudev,--disable-libudev,eudev"
-#PACKAGECONFIG[libxml2] = "--enable-libxml2,--disable-libxml2,libxml2"
+PACKAGECONFIG[libxml2] = "--enable-libxml2,--disable-libxml2,libxml2"
INSANE_SKIP_${PN} = "arch"
--
2.17.1
^ permalink raw reply related [flat|nested] 30+ messages in thread* [OE-core][dunfell 05/16] nativesdk-gcc-runtime: enable building libstdc++.a
2020-04-29 16:10 [OE-core][dunfell 00/16] Patch review Steve Sakoman
` (3 preceding siblings ...)
2020-04-29 16:10 ` [OE-core][dunfell 04/16] qemu-system-native: Fix commented out PACKAGECONFIG Steve Sakoman
@ 2020-04-29 16:10 ` Steve Sakoman
2020-04-29 16:10 ` [OE-core][dunfell 06/16] buildtools-extended-tarball: Add libstc++.a Steve Sakoman
` (10 subsequent siblings)
15 siblings, 0 replies; 30+ messages in thread
From: Steve Sakoman @ 2020-04-29 16:10 UTC (permalink / raw)
To: openembedded-core
From: Jeremy Puhlman <jpuhlman@mvista.com>
Signed-off-by: Jeremy Puhlman <jpuhlman@mvista.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Steve Sakoman <steve@sakoman.com>
---
meta/recipes-devtools/gcc/gcc-runtime.inc | 2 ++
1 file changed, 2 insertions(+)
diff --git a/meta/recipes-devtools/gcc/gcc-runtime.inc b/meta/recipes-devtools/gcc/gcc-runtime.inc
index 771f344ac0..ace706dbf4 100644
--- a/meta/recipes-devtools/gcc/gcc-runtime.inc
+++ b/meta/recipes-devtools/gcc/gcc-runtime.inc
@@ -22,6 +22,8 @@ EXTRA_OECONF_append_libc-newlib = " --with-newlib"
EXTRA_OECONF_append_arm = " libat_cv_have_ifunc=no "
EXTRA_OECONF_append_armeb = " libat_cv_have_ifunc=no "
+DISABLE_STATIC_class-nativesdk ?= ""
+
# Newlib does not support symbol versioning on libsdtcc++
SYMVERS_CONF_libc-newlib = ""
--
2.17.1
^ permalink raw reply related [flat|nested] 30+ messages in thread* [OE-core][dunfell 06/16] buildtools-extended-tarball: Add libstc++.a
2020-04-29 16:10 [OE-core][dunfell 00/16] Patch review Steve Sakoman
` (4 preceding siblings ...)
2020-04-29 16:10 ` [OE-core][dunfell 05/16] nativesdk-gcc-runtime: enable building libstdc++.a Steve Sakoman
@ 2020-04-29 16:10 ` Steve Sakoman
2020-04-29 16:10 ` [OE-core][dunfell 07/16] libucontext: Bring in mips/mips64 support Steve Sakoman
` (9 subsequent siblings)
15 siblings, 0 replies; 30+ messages in thread
From: Steve Sakoman @ 2020-04-29 16:10 UTC (permalink / raw)
To: openembedded-core
From: Jeremy Puhlman <jpuhlman@mvista.com>
Builds like native-openjdk, really wants a to link
some tools against the static version. Since when
using the extended tarball, its the only place to
get it, add the library.
Signed-off-by: Jeremy Puhlman <jpuhlman@mvista.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Steve Sakoman <steve@sakoman.com>
---
meta/recipes-core/meta/buildtools-extended-tarball.bb | 1 +
1 file changed, 1 insertion(+)
diff --git a/meta/recipes-core/meta/buildtools-extended-tarball.bb b/meta/recipes-core/meta/buildtools-extended-tarball.bb
index dd780c5d57..e38967af3f 100644
--- a/meta/recipes-core/meta/buildtools-extended-tarball.bb
+++ b/meta/recipes-core/meta/buildtools-extended-tarball.bb
@@ -23,6 +23,7 @@ TOOLCHAIN_HOST_TASK += "\
nativesdk-libgcc \
nativesdk-libstdc++ \
nativesdk-libstdc++-dev \
+ nativesdk-libstdc++-staticdev \
nativesdk-libtool \
nativesdk-pkgconfig \
nativesdk-glibc-utils \
--
2.17.1
^ permalink raw reply related [flat|nested] 30+ messages in thread* [OE-core][dunfell 07/16] libucontext: Bring in mips/mips64 support
2020-04-29 16:10 [OE-core][dunfell 00/16] Patch review Steve Sakoman
` (5 preceding siblings ...)
2020-04-29 16:10 ` [OE-core][dunfell 06/16] buildtools-extended-tarball: Add libstc++.a Steve Sakoman
@ 2020-04-29 16:10 ` Steve Sakoman
2020-04-29 16:10 ` [OE-core][dunfell 08/16] ruby: Link with libucontext on musl Steve Sakoman
` (8 subsequent siblings)
15 siblings, 0 replies; 30+ messages in thread
From: Steve Sakoman @ 2020-04-29 16:10 UTC (permalink / raw)
To: openembedded-core
From: Khem Raj <raj.khem@gmail.com>
License-Update: Updated copyright years [1]
Latest master 0.10.x+ has added support for mips/mips64, which should
help compile ruby on musl for these architectures
Switch SRC_URI to github upstream URI
Check for common arches before checking others in map_kernel_arch
Drop already upstreamed patches
[1] https://github.com/kaniini/libucontext/commit/d31eaabbaf5f45656c10e4bccd3fe6653a7d3ec1
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Steve Sakoman <steve@sakoman.com>
---
...move-using-.end-directive-with-clang.patch | 36 ++++++++++++++
.../0001-Makefile-Add-LIBDIR-variable.patch | 46 ------------------
.../0001-pass-LDFLAGS-to-link-step.patch | 31 ------------
meta/recipes-core/musl/libucontext_git.bb | 48 +++++++++----------
4 files changed, 60 insertions(+), 101 deletions(-)
create mode 100644 meta/recipes-core/musl/0001-Remove-using-.end-directive-with-clang.patch
delete mode 100644 meta/recipes-core/musl/libucontext/0001-Makefile-Add-LIBDIR-variable.patch
delete mode 100644 meta/recipes-core/musl/libucontext/0001-pass-LDFLAGS-to-link-step.patch
diff --git a/meta/recipes-core/musl/0001-Remove-using-.end-directive-with-clang.patch b/meta/recipes-core/musl/0001-Remove-using-.end-directive-with-clang.patch
new file mode 100644
index 0000000000..be79cb53f1
--- /dev/null
+++ b/meta/recipes-core/musl/0001-Remove-using-.end-directive-with-clang.patch
@@ -0,0 +1,36 @@
+From b6732f68848ecc8ff01054bf7aea70a241c37116 Mon Sep 17 00:00:00 2001
+From: Khem Raj <raj.khem@gmail.com>
+Date: Fri, 10 Apr 2020 11:23:39 -0700
+Subject: [PATCH] Remove using .end directive with clang
+
+Clang does not support this asm directive
+Fixes Issue #19
+
+Upstream-Status: Submitted [https://github.com/kaniini/libucontext/pull/20]
+Signed-off-by: Khem Raj <raj.khem@gmail.com>
+---
+ arch/common/common-defs.h | 5 ++++-
+ 1 file changed, 4 insertions(+), 1 deletion(-)
+
+diff --git a/arch/common/common-defs.h b/arch/common/common-defs.h
+index bf2fb8c..618116b 100644
+--- a/arch/common/common-defs.h
++++ b/arch/common/common-defs.h
+@@ -28,10 +28,13 @@
+ ENT(__proc) \
+ __proc: \
+ SETUP_FRAME(__proc)
+-
++#ifdef __clang__
++#define END(__proc)
++#else
+ #define END(__proc) \
+ .end __proc; \
+ .size __proc,.-__proc;
++#endif
+
+ #define ALIAS(__alias, __real) \
+ .weak __alias; \
+--
+2.26.0
+
diff --git a/meta/recipes-core/musl/libucontext/0001-Makefile-Add-LIBDIR-variable.patch b/meta/recipes-core/musl/libucontext/0001-Makefile-Add-LIBDIR-variable.patch
deleted file mode 100644
index 4f91c8f189..0000000000
--- a/meta/recipes-core/musl/libucontext/0001-Makefile-Add-LIBDIR-variable.patch
+++ /dev/null
@@ -1,46 +0,0 @@
-From 9bc3cedba54708c40c4a853b240c46e69f87de3c Mon Sep 17 00:00:00 2001
-From: Khem Raj <raj.khem@gmail.com>
-Date: Tue, 17 Mar 2020 10:04:40 -0700
-Subject: [PATCH] Makefile: Add LIBDIR variable
-
-This ensures that it can be installed into custom location and also
-
-Upstream-Status: Submitted
-Signed-off-by: Khem Raj <raj.khem@gmail.com>
----
- Makefile | 6 +++---
- 1 file changed, 3 insertions(+), 3 deletions(-)
-
---- a/Makefile
-+++ b/Makefile
-@@ -1,5 +1,5 @@
- ARCH := $(shell uname -m)
--
-+LIBDIR := /lib
- CFLAGS = -ggdb3 -O2 -Wall -Iarch/${ARCH}
-
- LIBUCONTEXT_C_SRC = $(wildcard arch/${ARCH}/*.c)
-@@ -10,8 +10,8 @@ LIBUCONTEXT_SOVERSION = 0
- LIBUCONTEXT_NAME = libucontext.so
- LIBUCONTEXT_STATIC_NAME = libucontext.a
- LIBUCONTEXT_SONAME = libucontext.so.${LIBUCONTEXT_SOVERSION}
--LIBUCONTEXT_PATH = /lib/${LIBUCONTEXT_SONAME}
--LIBUCONTEXT_STATIC_PATH = /lib/${LIBUCONTEXT_STATIC_NAME}
-+LIBUCONTEXT_PATH = ${LIBDIR}/${LIBUCONTEXT_SONAME}
-+LIBUCONTEXT_STATIC_PATH = ${LIBDIR}/${LIBUCONTEXT_STATIC_NAME}
-
- all: ${LIBUCONTEXT_SONAME} ${LIBUCONTEXT_STATIC_NAME}
-
-@@ -36,9 +36,9 @@ clean:
- ${LIBUCONTEXT_OBJ} test_libucontext
-
- install: all
-- install -D -m755 ${LIBUCONTEXT_NAME} ${DESTDIR}/${LIBUCONTEXT_PATH}
-- install -D -m664 ${LIBUCONTEXT_STATIC_NAME} ${DESTDIR}/${LIBUCONTEXT_STATIC_PATH}
-- ln -sf ${LIBUCONTEXT_SONAME} ${DESTDIR}/lib/${LIBUCONTEXT_NAME}
-+ install -D -m755 ${LIBUCONTEXT_NAME} ${DESTDIR}${LIBUCONTEXT_PATH}
-+ install -D -m664 ${LIBUCONTEXT_STATIC_NAME} ${DESTDIR}${LIBUCONTEXT_STATIC_PATH}
-+ ln -sf ${LIBUCONTEXT_SONAME} ${DESTDIR}${LIBDIR}/${LIBUCONTEXT_NAME}
-
- check: test_libucontext ${LIBUCONTEXT_SONAME}
- env LD_LIBRARY_PATH=$(shell pwd) ./test_libucontext
diff --git a/meta/recipes-core/musl/libucontext/0001-pass-LDFLAGS-to-link-step.patch b/meta/recipes-core/musl/libucontext/0001-pass-LDFLAGS-to-link-step.patch
deleted file mode 100644
index 0ab8caf3e6..0000000000
--- a/meta/recipes-core/musl/libucontext/0001-pass-LDFLAGS-to-link-step.patch
+++ /dev/null
@@ -1,31 +0,0 @@
-From 12d45d250d08e96e889e38e77273c3ef73e6fc97 Mon Sep 17 00:00:00 2001
-From: Khem Raj <raj.khem@gmail.com>
-Date: Mon, 25 Nov 2019 15:07:35 -0800
-Subject: [PATCH] pass LDFLAGS to link step
-
-This helps to use OE specific linker flags and fixes
-
-do_package_qa: QA Issue: No GNU_HASH in the ELF binary
-
-Upstream-Status: Pending
-Signed-off-by: Khem Raj <raj.khem@gmail.com>
----
- Makefile | 2 +-
- 1 file changed, 1 insertion(+), 1 deletion(-)
-
-diff --git a/Makefile b/Makefile
-index 8a605fd..d1c9637 100644
---- a/Makefile
-+++ b/Makefile
-@@ -20,7 +20,7 @@ ${LIBUCONTEXT_STATIC_NAME}: ${LIBUCONTEXT_OBJ}
-
- ${LIBUCONTEXT_NAME}: ${LIBUCONTEXT_OBJ}
- $(CC) -o ${LIBUCONTEXT_NAME} -Wl,-soname,${LIBUCONTEXT_SONAME} \
-- -shared ${LIBUCONTEXT_OBJ}
-+ -shared ${LIBUCONTEXT_OBJ} ${LDFLAGS}
-
- ${LIBUCONTEXT_SONAME}: ${LIBUCONTEXT_NAME}
- ln -sf ${LIBUCONTEXT_NAME} ${LIBUCONTEXT_SONAME}
---
-2.24.0
-
diff --git a/meta/recipes-core/musl/libucontext_git.bb b/meta/recipes-core/musl/libucontext_git.bb
index 92cb703b0b..ec988f1920 100644
--- a/meta/recipes-core/musl/libucontext_git.bb
+++ b/meta/recipes-core/musl/libucontext_git.bb
@@ -4,26 +4,25 @@
SUMMARY = "ucontext implementation featuring glibc-compatible ABI"
HOMEPAGE = "https://github.com/kaniini/libucontext"
LICENSE = "ISC"
-LIC_FILES_CHKSUM = "file://LICENSE;md5=864cc1445419406b7093e8e531c9515e"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=6eed01fa0e673c76f5a5715438f65b1d"
SECTION = "libs"
DEPENDS = ""
-PV = "0.1.3+${SRCPV}"
-SRCREV = "e6b4d7516dae9b200e94fcfcb9ebc9331389655f"
-SRC_URI = "git://code.foxkit.us/adelie/libucontext.git;protocol=https \
- file://0001-pass-LDFLAGS-to-link-step.patch \
- file://0001-Makefile-Add-LIBDIR-variable.patch \
+PV = "0.10+${SRCPV}"
+SRCREV = "19fa1bbfc26efb92147b5e85cc0ca02a0e837561"
+SRC_URI = "git://github.com/kaniini/libucontext \
"
S = "${WORKDIR}/git"
COMPATIBLE_HOST = ".*-musl.*"
-valid_archs = "\
-i386 x86 \
-ppc powerpc powerpc64 ppc64 \
-arm aarch64 \
-s390 \
+valid_archs = " \
+ x86 x86_64 \
+ ppc ppc64 \
+ mips mips64 \
+ arm aarch64 \
+ s390x \
"
def map_kernel_arch(a, d):
@@ -31,18 +30,19 @@ def map_kernel_arch(a, d):
valid_archs = d.getVar('valid_archs').split()
- if re.match('(i.86|athlon)$', a): return 'x86'
- elif re.match('x86.64$', a): return 'x86_64'
- elif re.match('armeb$', a): return 'arm'
- elif re.match('aarch64$', a): return 'aarch64'
- elif re.match('aarch64_be$', a): return 'aarch64'
- elif re.match('aarch64_ilp32$', a): return 'aarch64'
- elif re.match('aarch64_be_ilp32$', a): return 'aarch64'
- elif re.match('mips(isa|)(32|64|)(r6|)(el|)$', a): return 'mips'
- elif re.match('p(pc|owerpc)', a): return 'ppc'
- elif re.match('p(pc64|owerpc64)', a): return 'ppc64'
- elif re.match('riscv64$', a): return 'riscv64'
- elif a in valid_archs: return a
+ if a in valid_archs: return a
+ elif re.match('(i.86|athlon)$', a): return 'x86'
+ elif re.match('x86.64$', a): return 'x86_64'
+ elif re.match('armeb$', a): return 'arm'
+ elif re.match('aarch64$', a): return 'aarch64'
+ elif re.match('aarch64_be$', a): return 'aarch64'
+ elif re.match('aarch64_ilp32$', a): return 'aarch64'
+ elif re.match('aarch64_be_ilp32$', a): return 'aarch64'
+ elif re.match('mips(isa|)(32|)(r6|)(el|)$', a): return 'mips'
+ elif re.match('mips(isa|)64(r6|)(el|)$', a): return 'mips64'
+ elif re.match('p(pc|owerpc)', a): return 'ppc'
+ elif re.match('p(pc64|owerpc64)', a): return 'ppc64'
+ elif re.match('riscv64$', a): return 'riscv64'
else:
if not d.getVar("TARGET_OS").startswith("linux"):
return a
@@ -50,7 +50,7 @@ def map_kernel_arch(a, d):
export ARCH = "${@map_kernel_arch(d.getVar('TARGET_ARCH'), d)}"
-CFLAGS += "-Iarch/${ARCH}"
+CFLAGS += "-Iarch/${ARCH} -Iarch/common"
EXTRA_OEMAKE = "CFLAGS='${CFLAGS}' LDFLAGS='${LDFLAGS}' LIBDIR='${base_libdir}'"
--
2.17.1
^ permalink raw reply related [flat|nested] 30+ messages in thread* [OE-core][dunfell 08/16] ruby: Link with libucontext on musl
2020-04-29 16:10 [OE-core][dunfell 00/16] Patch review Steve Sakoman
` (6 preceding siblings ...)
2020-04-29 16:10 ` [OE-core][dunfell 07/16] libucontext: Bring in mips/mips64 support Steve Sakoman
@ 2020-04-29 16:10 ` Steve Sakoman
2020-04-29 16:10 ` [OE-core][dunfell 09/16] tzdata: remove exit 0 from pkg_postinst Steve Sakoman
` (7 subsequent siblings)
15 siblings, 0 replies; 30+ messages in thread
From: Steve Sakoman @ 2020-04-29 16:10 UTC (permalink / raw)
To: openembedded-core
From: Khem Raj <raj.khem@gmail.com>
coroutines in ruby 2.7+ needs ucontext APIs which are not available in
musl but an external library is available to provide them so use it
Use cached values for ac_cv_func_isnan and ac_cv_func_isinf this is not
detected correctly by configure on musl
on ARM drop using old arm32 implementation of coroutine which is slow and
inefficient
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Steve Sakoman <steve@sakoman.com>
---
meta/recipes-devtools/ruby/ruby_2.7.0.bb | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/meta/recipes-devtools/ruby/ruby_2.7.0.bb b/meta/recipes-devtools/ruby/ruby_2.7.0.bb
index 44c76161d5..7f07080497 100644
--- a/meta/recipes-devtools/ruby/ruby_2.7.0.bb
+++ b/meta/recipes-devtools/ruby/ruby_2.7.0.bb
@@ -1,5 +1,7 @@
require ruby.inc
+DEPENDS_append_libc-musl = " libucontext"
+
SRC_URI += " \
file://remove_has_include_macros.patch \
file://run-ptest \
@@ -25,8 +27,11 @@ EXTRA_OECONF = "\
--with-pkg-config=pkg-config \
"
-EXTRA_OECONF_append_libc-musl_arm = " --with-coroutine=arm32"
-EXTRA_OECONF_append_libc-musl_armeb = " --with-coroutine=arm32"
+EXTRA_OECONF_append_libc-musl = "\
+ LIBS='-lucontext' \
+ ac_cv_func_isnan=yes \
+ ac_cv_func_isinf=yes \
+"
do_install() {
oe_runmake 'DESTDIR=${D}' install
--
2.17.1
^ permalink raw reply related [flat|nested] 30+ messages in thread* [OE-core][dunfell 09/16] tzdata: remove exit 0 from pkg_postinst
2020-04-29 16:10 [OE-core][dunfell 00/16] Patch review Steve Sakoman
` (7 preceding siblings ...)
2020-04-29 16:10 ` [OE-core][dunfell 08/16] ruby: Link with libucontext on musl Steve Sakoman
@ 2020-04-29 16:10 ` Steve Sakoman
2020-04-29 16:10 ` [OE-core][dunfell 10/16] gnutls: upgrade 3.6.12 -> 3.6.13 Steve Sakoman
` (6 subsequent siblings)
15 siblings, 0 replies; 30+ messages in thread
From: Steve Sakoman @ 2020-04-29 16:10 UTC (permalink / raw)
To: openembedded-core
From: Maxime Roussin-B?langer <maxime.roussinbelanger@gmail.com>
Documentation says that if you exit 0 in a pkg_postinst it will marked as
installed.
If you exit 0, before running postinst-intercepts defer_to_first_boot, the
pkg_postinst_ontarget script will not be present on target.
The "exit 0" in tzdata makes it difficult to have a bbappend with a
pkg_postinst_target step when you have `INSTALL_TIMEZONE_FILE = 0`
Signed-off-by: Maxime Roussin-Bélanger <maxime.roussinbelanger@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Steve Sakoman <steve@sakoman.com>
---
meta/recipes-extended/timezone/tzdata.bb | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/meta/recipes-extended/timezone/tzdata.bb b/meta/recipes-extended/timezone/tzdata.bb
index 1e2d9bd1b9..1e2b440fb0 100644
--- a/meta/recipes-extended/timezone/tzdata.bb
+++ b/meta/recipes-extended/timezone/tzdata.bb
@@ -60,12 +60,8 @@ pkg_postinst_${PN} () {
if [ -e ${src} ] ; then
tz=$(sed -e 's:#.*::' -e 's:[[:space:]]*::g' -e '/^$/d' "${src}")
fi
-
- if [ -z "${tz}" ] ; then
- exit 0
- fi
-
- if [ ! -e "$D${datadir}/zoneinfo/${tz}" ] ; then
+
+ if [ ! -z "${tz}" -a ! -e "$D${datadir}/zoneinfo/${tz}" ] ; then
echo "You have an invalid TIMEZONE setting in ${src}"
echo "Your ${etc_lt} has been reset to Universal; enjoy!"
tz="Universal"
--
2.17.1
^ permalink raw reply related [flat|nested] 30+ messages in thread* [OE-core][dunfell 10/16] gnutls: upgrade 3.6.12 -> 3.6.13
2020-04-29 16:10 [OE-core][dunfell 00/16] Patch review Steve Sakoman
` (8 preceding siblings ...)
2020-04-29 16:10 ` [OE-core][dunfell 09/16] tzdata: remove exit 0 from pkg_postinst Steve Sakoman
@ 2020-04-29 16:10 ` Steve Sakoman
2020-04-29 16:10 ` [OE-core][dunfell 11/16] ell: upgrade 0.30 -> 0.31 Steve Sakoman
` (5 subsequent siblings)
15 siblings, 0 replies; 30+ messages in thread
From: Steve Sakoman @ 2020-04-29 16:10 UTC (permalink / raw)
To: openembedded-core
From: Wang Mingyu <wangmy@cn.fujitsu.com>
Signed-off-by: Wang Mingyu <wangmy@cn.fujitsu.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Steve Sakoman <steve@sakoman.com>
---
.../gnutls/{gnutls_3.6.12.bb => gnutls_3.6.13.bb} | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
rename meta/recipes-support/gnutls/{gnutls_3.6.12.bb => gnutls_3.6.13.bb} (93%)
diff --git a/meta/recipes-support/gnutls/gnutls_3.6.12.bb b/meta/recipes-support/gnutls/gnutls_3.6.13.bb
similarity index 93%
rename from meta/recipes-support/gnutls/gnutls_3.6.12.bb
rename to meta/recipes-support/gnutls/gnutls_3.6.13.bb
index f1eeebc807..f56d42a613 100644
--- a/meta/recipes-support/gnutls/gnutls_3.6.12.bb
+++ b/meta/recipes-support/gnutls/gnutls_3.6.13.bb
@@ -21,8 +21,8 @@ SRC_URI = "https://www.gnupg.org/ftp/gcrypt/gnutls/v${SHRT_VER}/gnutls-${PV}.tar
file://arm_eabi.patch \
"
-SRC_URI[md5sum] = "a23900f14980a467bdce3a0fd31dfa18"
-SRC_URI[sha256sum] = "bfacf16e342949ffd977a9232556092c47164bd26e166736cf3459a870506c4b"
+SRC_URI[md5sum] = "bb1fe696a11543433785b4fc70ca225f"
+SRC_URI[sha256sum] = "32041df447d9f4644570cf573c9f60358e865637d69b7e59d1159b7240b52f38"
inherit autotools texinfo pkgconfig gettext lib_package gtk-doc
--
2.17.1
^ permalink raw reply related [flat|nested] 30+ messages in thread* [OE-core][dunfell 11/16] ell: upgrade 0.30 -> 0.31
2020-04-29 16:10 [OE-core][dunfell 00/16] Patch review Steve Sakoman
` (9 preceding siblings ...)
2020-04-29 16:10 ` [OE-core][dunfell 10/16] gnutls: upgrade 3.6.12 -> 3.6.13 Steve Sakoman
@ 2020-04-29 16:10 ` Steve Sakoman
2020-04-29 16:10 ` [OE-core][dunfell 12/16] python3-manifest.json: add pathlib to core Steve Sakoman
` (4 subsequent siblings)
15 siblings, 0 replies; 30+ messages in thread
From: Steve Sakoman @ 2020-04-29 16:10 UTC (permalink / raw)
To: openembedded-core
From: Pierre-Jean Texier <pjtexier@koncepto.io>
This is a bugfix release:
ver 0.31:
Fix issue with verification of the second certificate in chain.
Fix issue with handling trusted CA matching in verification.
Signed-off-by: Pierre-Jean Texier <pjtexier@koncepto.io>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Steve Sakoman <steve@sakoman.com>
---
meta/recipes-core/ell/{ell_0.30.bb => ell_0.31.bb} | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
rename meta/recipes-core/ell/{ell_0.30.bb => ell_0.31.bb} (83%)
diff --git a/meta/recipes-core/ell/ell_0.30.bb b/meta/recipes-core/ell/ell_0.31.bb
similarity index 83%
rename from meta/recipes-core/ell/ell_0.30.bb
rename to meta/recipes-core/ell/ell_0.31.bb
index 17045b3ae5..1db7131ab0 100644
--- a/meta/recipes-core/ell/ell_0.30.bb
+++ b/meta/recipes-core/ell/ell_0.31.bb
@@ -14,8 +14,8 @@ DEPENDS = "dbus"
inherit autotools pkgconfig
SRC_URI = "https://mirrors.edge.kernel.org/pub/linux/libs/${BPN}/${BPN}-${PV}.tar.xz"
-SRC_URI[md5sum] = "79c757858688cc6c36087605234d87a8"
-SRC_URI[sha256sum] = "51cf8cc66a9d1038e41f7d619ea5660aa4476904496562b2d45ca79370ca4a5e"
+SRC_URI[md5sum] = "3f670230be4d89d621b0508c70b1d36b"
+SRC_URI[sha256sum] = "ae88617275452f9f5840b2365e33e6c7fb6fa3405d42cbf9367de642ee8b6701"
do_configure_prepend () {
mkdir -p ${S}/build-aux
--
2.17.1
^ permalink raw reply related [flat|nested] 30+ messages in thread* [OE-core][dunfell 12/16] python3-manifest.json: add pathlib to core
2020-04-29 16:10 [OE-core][dunfell 00/16] Patch review Steve Sakoman
` (10 preceding siblings ...)
2020-04-29 16:10 ` [OE-core][dunfell 11/16] ell: upgrade 0.30 -> 0.31 Steve Sakoman
@ 2020-04-29 16:10 ` Steve Sakoman
2020-04-29 16:10 ` [OE-core][dunfell 13/16] alsa-state: ignore 'No soundcards found' error in pkg_postinst Steve Sakoman
` (3 subsequent siblings)
15 siblings, 0 replies; 30+ messages in thread
From: Steve Sakoman @ 2020-04-29 16:10 UTC (permalink / raw)
To: openembedded-core
From: Tim Orling <timothy.t.orling@linux.intel.com>
The pathlib module is for Object-oriented filesystem paths
It also provides a lot of handy utilities for checking on
paths. This seems to justify adding it to the core package
along side os, sys, and the other *path libraries.
[YOCTO #13670]
Signed-off-by: Tim Orling <timothy.t.orling@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Steve Sakoman <steve@sakoman.com>
---
meta/recipes-devtools/python/python3/python3-manifest.json | 2 ++
1 file changed, 2 insertions(+)
diff --git a/meta/recipes-devtools/python/python3/python3-manifest.json b/meta/recipes-devtools/python/python3/python3-manifest.json
index 251271cb84..3bcc9b8662 100644
--- a/meta/recipes-devtools/python/python3/python3-manifest.json
+++ b/meta/recipes-devtools/python/python3/python3-manifest.json
@@ -285,6 +285,7 @@
"${libdir}/python${PYTHON_MAJMIN}/operator.py",
"${libdir}/python${PYTHON_MAJMIN}/optparse.py",
"${libdir}/python${PYTHON_MAJMIN}/os.py",
+ "${libdir}/python${PYTHON_MAJMIN}/pathlib.py",
"${libdir}/python${PYTHON_MAJMIN}/pkgutil.py",
"${libdir}/python${PYTHON_MAJMIN}/platform.py",
"${libdir}/python${PYTHON_MAJMIN}/posixpath.py",
@@ -358,6 +359,7 @@
"${libdir}/python${PYTHON_MAJMIN}/__pycache__/operator.*.pyc",
"${libdir}/python${PYTHON_MAJMIN}/__pycache__/optparse.*.pyc",
"${libdir}/python${PYTHON_MAJMIN}/__pycache__/os.*.pyc",
+ "${libdir}/python${PYTHON_MAJMIN}/__pycache__/pathlib.*.pyc",
"${libdir}/python${PYTHON_MAJMIN}/__pycache__/pkgutil.*.pyc",
"${libdir}/python${PYTHON_MAJMIN}/__pycache__/platform.*.pyc",
"${libdir}/python${PYTHON_MAJMIN}/__pycache__/posixpath.*.pyc",
--
2.17.1
^ permalink raw reply related [flat|nested] 30+ messages in thread* [OE-core][dunfell 13/16] alsa-state: ignore 'No soundcards found' error in pkg_postinst
2020-04-29 16:10 [OE-core][dunfell 00/16] Patch review Steve Sakoman
` (11 preceding siblings ...)
2020-04-29 16:10 ` [OE-core][dunfell 12/16] python3-manifest.json: add pathlib to core Steve Sakoman
@ 2020-04-29 16:10 ` Steve Sakoman
2020-04-29 16:10 ` [OE-core][dunfell 14/16] buildtools-tarball: add nativesdk-mtools for `wic ls' Steve Sakoman
` (2 subsequent siblings)
15 siblings, 0 replies; 30+ messages in thread
From: Steve Sakoman @ 2020-04-29 16:10 UTC (permalink / raw)
To: openembedded-core
From: Yi Zhao <yi.zhao@windriver.com>
If there is no soundcards on the target (e.g. qemu), the pkp_postinst
function will report an error:
alsactl: load_state:1735: No soundcards found...
pkg_run_script: package "alsa-state" postinst script returned status 19.
opkg_configure: alsa-state.postinst returned 19.
Pass '-g' option to alsactl to ignore this error.
Signed-off-by: Yi Zhao <yi.zhao@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Steve Sakoman <steve@sakoman.com>
---
meta/recipes-bsp/alsa-state/alsa-state.bb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/recipes-bsp/alsa-state/alsa-state.bb b/meta/recipes-bsp/alsa-state/alsa-state.bb
index 0670556999..cec2272c80 100644
--- a/meta/recipes-bsp/alsa-state/alsa-state.bb
+++ b/meta/recipes-bsp/alsa-state/alsa-state.bb
@@ -62,7 +62,7 @@ pkg_postinst_${PN}() {
then
if test -x ${sbindir}/alsactl
then
- ${sbindir}/alsactl -f ${localstatedir}/lib/alsa/asound.state restore
+ ${sbindir}/alsactl -g -f ${localstatedir}/lib/alsa/asound.state restore
fi
fi
}
--
2.17.1
^ permalink raw reply related [flat|nested] 30+ messages in thread* [OE-core][dunfell 14/16] buildtools-tarball: add nativesdk-mtools for `wic ls'
2020-04-29 16:10 [OE-core][dunfell 00/16] Patch review Steve Sakoman
` (12 preceding siblings ...)
2020-04-29 16:10 ` [OE-core][dunfell 13/16] alsa-state: ignore 'No soundcards found' error in pkg_postinst Steve Sakoman
@ 2020-04-29 16:10 ` Steve Sakoman
2020-04-29 16:11 ` [OE-core][dunfell 15/16] parselogs.py: ignore pulseaudio startup warning messages Steve Sakoman
2020-04-29 16:11 ` [OE-core][dunfell 16/16] qemuboot.bbclass: don't redefine IMGDEPLOYDIR Steve Sakoman
15 siblings, 0 replies; 30+ messages in thread
From: Steve Sakoman @ 2020-04-29 16:10 UTC (permalink / raw)
To: openembedded-core
From: hongxu <hongxu.jia@windriver.com>
On ubuntu 18.04.1, it does not provides `mdir' by default
which caused `wic ls **.wic' failed on fat partition
...
$ wic ls build/tmp-glibc/deploy/images/xilinx-zynqmp/wrlinux-image-std-xilinx-zynqmp.wic
ERROR: Can't find executable 'mdir'
...
Add nativesdk-mtools to buildtools-tarball and use buildtools
to provide mdir
Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Steve Sakoman <steve@sakoman.com>
---
meta/recipes-core/meta/buildtools-tarball.bb | 1 +
1 file changed, 1 insertion(+)
diff --git a/meta/recipes-core/meta/buildtools-tarball.bb b/meta/recipes-core/meta/buildtools-tarball.bb
index aa55cde84a..977b6a5e1d 100644
--- a/meta/recipes-core/meta/buildtools-tarball.bb
+++ b/meta/recipes-core/meta/buildtools-tarball.bb
@@ -26,6 +26,7 @@ TOOLCHAIN_HOST_TASK ?= "\
nativesdk-libnss-nis \
nativesdk-rpcsvc-proto \
nativesdk-patch \
+ nativesdk-mtools \
"
MULTIMACH_TARGET_SYS = "${SDK_ARCH}-nativesdk${SDK_VENDOR}-${SDK_OS}"
--
2.17.1
^ permalink raw reply related [flat|nested] 30+ messages in thread* [OE-core][dunfell 15/16] parselogs.py: ignore pulseaudio startup warning messages
2020-04-29 16:10 [OE-core][dunfell 00/16] Patch review Steve Sakoman
` (13 preceding siblings ...)
2020-04-29 16:10 ` [OE-core][dunfell 14/16] buildtools-tarball: add nativesdk-mtools for `wic ls' Steve Sakoman
@ 2020-04-29 16:11 ` Steve Sakoman
2020-04-29 16:11 ` [OE-core][dunfell 16/16] qemuboot.bbclass: don't redefine IMGDEPLOYDIR Steve Sakoman
15 siblings, 0 replies; 30+ messages in thread
From: Steve Sakoman @ 2020-04-29 16:11 UTC (permalink / raw)
To: openembedded-core
From: Changqing Li <changqing.li@windriver.com>
If set default syslog to rsyslog, we can see below messages
in user.log,
[pulseaudio] authkey.c: Failed to open cookie file
[pulseaudio] authkey.c: Failed to load authentication key
They are only warnings when cookie file is not found. And
PulseAudio will create it if it doesn't exist.
refer:
https://wiki.archlinux.org/index.php/PulseAudio/Configuration
https://lists.freedesktop.org/archives/pulseaudio-discuss/2014-December/022719.html
Signed-off-by: Changqing Li <changqing.li@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Steve Sakoman <steve@sakoman.com>
---
meta/lib/oeqa/runtime/cases/parselogs.py | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/meta/lib/oeqa/runtime/cases/parselogs.py b/meta/lib/oeqa/runtime/cases/parselogs.py
index f94387c8bc..a1791b5cca 100644
--- a/meta/lib/oeqa/runtime/cases/parselogs.py
+++ b/meta/lib/oeqa/runtime/cases/parselogs.py
@@ -58,7 +58,9 @@ common_errors = [
"Failed to rename network interface",
"Failed to process device, ignoring: Device or resource busy",
"Cannot find a map file",
- "[rdrand]: Initialization Failed"
+ "[rdrand]: Initialization Failed",
+ "[pulseaudio] authkey.c: Failed to open cookie file",
+ "[pulseaudio] authkey.c: Failed to load authentication key",
]
video_related = [
--
2.17.1
^ permalink raw reply related [flat|nested] 30+ messages in thread* [OE-core][dunfell 16/16] qemuboot.bbclass: don't redefine IMGDEPLOYDIR
2020-04-29 16:10 [OE-core][dunfell 00/16] Patch review Steve Sakoman
` (14 preceding siblings ...)
2020-04-29 16:11 ` [OE-core][dunfell 15/16] parselogs.py: ignore pulseaudio startup warning messages Steve Sakoman
@ 2020-04-29 16:11 ` Steve Sakoman
2020-04-29 22:33 ` Richard Purdie
15 siblings, 1 reply; 30+ messages in thread
From: Steve Sakoman @ 2020-04-29 16:11 UTC (permalink / raw)
To: openembedded-core
From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
This variable is already defined in image.bbclass and there's not need
to redefine it here.
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Steve Sakoman <steve@sakoman.com>
---
meta/classes/qemuboot.bbclass | 1 -
1 file changed, 1 deletion(-)
diff --git a/meta/classes/qemuboot.bbclass b/meta/classes/qemuboot.bbclass
index 54044c38da..68f7a03619 100644
--- a/meta/classes/qemuboot.bbclass
+++ b/meta/classes/qemuboot.bbclass
@@ -83,7 +83,6 @@ QB_DRIVE_TYPE ?= "/dev/sd"
# Create qemuboot.conf
addtask do_write_qemuboot_conf after do_rootfs before do_image
-IMGDEPLOYDIR ?= "${WORKDIR}/deploy-${PN}-image-complete"
def qemuboot_vars(d):
build_vars = ['MACHINE', 'TUNE_ARCH', 'DEPLOY_DIR_IMAGE',
--
2.17.1
^ permalink raw reply related [flat|nested] 30+ messages in thread* Re: [OE-core][dunfell 16/16] qemuboot.bbclass: don't redefine IMGDEPLOYDIR
2020-04-29 16:11 ` [OE-core][dunfell 16/16] qemuboot.bbclass: don't redefine IMGDEPLOYDIR Steve Sakoman
@ 2020-04-29 22:33 ` Richard Purdie
2020-04-30 0:08 ` Steve Sakoman
0 siblings, 1 reply; 30+ messages in thread
From: Richard Purdie @ 2020-04-29 22:33 UTC (permalink / raw)
To: openembedded-core
On Wed, 2020-04-29 at 06:11 -1000, Steve Sakoman wrote:
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> This variable is already defined in image.bbclass and there's not
> need
> to redefine it here.
>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> Signed-off-by: Steve Sakoman <steve@sakoman.com>
> ---
> meta/classes/qemuboot.bbclass | 1 -
> 1 file changed, 1 deletion(-)
I think this causes a baremetal regression, there is a fix in master.
Whether we therefore want to take a cleanup into stable, not sure.
Cheers,
Richard
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [OE-core][dunfell 16/16] qemuboot.bbclass: don't redefine IMGDEPLOYDIR
2020-04-29 22:33 ` Richard Purdie
@ 2020-04-30 0:08 ` Steve Sakoman
0 siblings, 0 replies; 30+ messages in thread
From: Steve Sakoman @ 2020-04-30 0:08 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
On Wed, Apr 29, 2020 at 12:33 PM Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
>
> On Wed, 2020-04-29 at 06:11 -1000, Steve Sakoman wrote:
> > From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> >
> > This variable is already defined in image.bbclass and there's not
> > need
> > to redefine it here.
> >
> > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> > Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> > Signed-off-by: Steve Sakoman <steve@sakoman.com>
> > ---
> > meta/classes/qemuboot.bbclass | 1 -
> > 1 file changed, 1 deletion(-)
>
> I think this causes a baremetal regression, there is a fix in master.
> Whether we therefore want to take a cleanup into stable, not sure.
I haven't seen the baremetal issue, but I agree let's drop this patch
so we don't need to take the fix!
It's conveniently at the end of the series ;-)
Steve
>
^ permalink raw reply [flat|nested] 30+ messages in thread