From: Anand Jain <anand.jain@oracle.com> To: linux-btrfs@vger.kernel.org Cc: dsterba@suse.com, josef@toxicpanda.com Subject: [PATCH 0/11] btrfs: seed fix null ptr, use only main device_list_mutex, and cleanups Date: Mon, 31 Aug 2020 09:38:20 +0800 [thread overview] Message-ID: <cover.1598792561.git.anand.jain@oracle.com> (raw) In-Reply-To: <cover.1598792561.git.anand.jain@oracle.com> The cover letter for the patchset below [1] doesn't seem to have reached the ML. So here I am sending it again. [1] https://patchwork.kernel.org/project/linux-btrfs/list/?series=340699 In this patch set: Rebased on latest misc-next which contains the seed_list from Nicolas. This patchset has been sent before as two sets, here it is been merged. Patches 1/11 fix the null kobject being put, which is observed with kernel compiled with memory poisoning. Patches 2/11 and 3/11 are cleanups to maintain better flow in the functions btrfs_sysfs_add_devices_dir() and btrfs_sysfs_remove_devices_dir(). Patches 4/11 and 5/11 drops the last two users of seed device_list_mutex, so now they hold main filesystem device_list_mutex. Patches [6-10]/11 are cleanups. Patches 11/11 block the replacement of seed device in a sprouted FS, we already block replacing a seed device on a non-sprouted device. This set has passed through fstests/volume. ---- original cover-letter --------- In a sprouted file system, the seed's fs_devices are cloned and listed under the sprout's fs_devices. The fs_info::fs_devices points to the sprout::fs_devices and various critical operations like device-delete holds the top-level main device_list_mutex which is sprout::fs_devices::device_list_mutex and _not_ the seed level mutex such as sprout::fs_devices::seed::fs_devices::device_list_mutex. Also all related readers (except for two threads- reada and init_devices_late) hold the sprout::fs_devices::device_list_mutex too. And those two threads which are missing to hold the correct lock are being fixed here. I take the approach to fix the read end instead of fixing the writer end which are not holding the seed level mutex because to keep things simple and there isn't much benefit burning extra CPU cycles in going through the lock/unlock process as we traverse through the fs_devices::seed fs_devices (for example as in reada and init_devices_late threads). The first two patches (1/7, 2/7) fixes the threads using the seed::device_list_mutex. And rest of the patches ([3-7]/7) are cleanups and these patches are independent by themself. These patchset has been tested with full xfstests btrfs test cases and found to have no new regressions. Anand Jain (11): btrfs: initialize sysfs devid and device link for seed device btrfs: refactor btrfs_sysfs_add_devices_dir btrfs: refactor btrfs_sysfs_remove_devices_dir btrfs: reada: use sprout device_list_mutex btrfs: btrfs_init_devices_late: use sprout device_list_mutex btrfs: open code list_head pointer in btrfs_init_dev_replace_tgtdev btrfs: cleanup btrfs_remove_chunk btrfs: cleanup btrfs_assign_next_active_device() btrfs: cleanup unnecessary goto in open_seed_device btrfs: btrfs_dev_replace_update_device_in_mapping_tree drop file global declare btrfs: fix replace of seed device fs/btrfs/dev-replace.c | 66 ++++++++---------- fs/btrfs/reada.c | 5 +- fs/btrfs/sysfs.c | 151 ++++++++++++++++++++++++----------------- fs/btrfs/sysfs.h | 8 +-- fs/btrfs/volumes.c | 40 +++++------ 5 files changed, 143 insertions(+), 127 deletions(-) -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Anand Jain <anand.jain@oracle.com> To: linux-btrfs@vger.kernel.org Cc: dsterba@suse.com, josef@toxicpanda.com Subject: Date: Sun, 30 Aug 2020 22:40:55 +0800 [thread overview] Message-ID: <cover.1598792561.git.anand.jain@oracle.com> (raw) Message-ID: <20200830144055.fCPLCo-9sx41VzHbxvXDA8XQ38VDyfqRP7xFxS3DAVc@z> (raw) Subject: [PATCH 0/11] btrfs: seed fix null ptr, use only main device_list_mutex, and cleanups v2: Rebased on latest misc-next which contains the seed_list from Nicolas. This patchset has been sent before as two sets, here it is been merged. Patches 1/11 fix the null kobject being put, which is observed with kernel compiled with memory poisoning. Patches 2/11 and 3/11 are cleanups to maintain better flow in the functions btrfs_sysfs_add_devices_dir() and btrfs_sysfs_remove_devices_dir(). Patches 4/11 and 5/11 drops the last two users of seed device_list_mutex, so now they hold main filesystem device_list_mutex. Patches [6-10]/11 are cleanups. Patches 11/11 fix the replacement of seed device in a sprouted. It is safe to block that because we also block the replace of seed if it isn't a sprouted device. This set has passed through fstests/volume. ---- original cover-letter --------- In a sprouted file system, the seed's fs_devices are cloned and listed under the sprout's fs_devices. The fs_info::fs_devices points to the sprout::fs_devices and various critical operations like device-delete holds the top-level main device_list_mutex which is sprout::fs_devices::device_list_mutex and _not_ the seed level mutex such as sprout::fs_devices::seed::fs_devices::device_list_mutex. Also all related readers (except for two threads- reada and init_devices_late) hold the sprout::fs_devices::device_list_mutex too. And those two threads which are missing to hold the correct lock are being fixed here. I take the approach to fix the read end instead of fixing the writer end which are not holding the seed level mutex because to keep things simple and there isn't much benefit burning extra CPU cycles in going through the lock/unlock process as we traverse through the fs_devices::seed fs_devices (for example as in reada and init_devices_late threads). The first two patches (1/7, 2/7) fixes the threads using the seed::device_list_mutex. And rest of the patches ([3-7]/7) are cleanups and these patches are independent by themself. These patchset has been tested with full xfstests btrfs test cases and found to have no new regressions. Anand Jain (11): btrfs: initialize sysfs devid and device link for seed device btrfs: refactor btrfs_sysfs_add_devices_dir btrfs: refactor btrfs_sysfs_remove_devices_dir btrfs: reada: use sprout device_list_mutex btrfs: btrfs_init_devices_late: use sprout device_list_mutex btrfs: open code list_head pointer in btrfs_init_dev_replace_tgtdev btrfs: cleanup btrfs_remove_chunk btrfs: cleanup btrfs_assign_next_active_device() btrfs: cleanup unnecessary goto in open_seed_device btrfs: btrfs_dev_replace_update_device_in_mapping_tree drop file global declare btrfs: fix replace of seed device fs/btrfs/dev-replace.c | 66 ++++++++---------- fs/btrfs/reada.c | 5 +- fs/btrfs/sysfs.c | 151 ++++++++++++++++++++++++----------------- fs/btrfs/sysfs.h | 8 +-- fs/btrfs/volumes.c | 40 +++++------ 5 files changed, 143 insertions(+), 127 deletions(-) -- 2.25.1
next parent reply other threads:[~2020-08-31 1:38 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-30 14:40 Anand Jain [this message] 2020-08-30 14:40 ` Anand Jain 2020-08-31 1:38 ` [PATCH 0/11] btrfs: seed fix null ptr, use only main device_list_mutex, and cleanups Anand Jain 2020-08-30 14:40 ` [PATCH 01/11] btrfs: initialize sysfs devid and device link for seed device Anand Jain 2020-08-31 9:07 ` Nikolay Borisov 2020-08-31 12:00 ` Anand Jain 2020-08-31 16:21 ` Josef Bacik 2020-09-01 16:16 ` Anand Jain 2020-08-30 14:40 ` [PATCH 02/11] btrfs: refactor btrfs_sysfs_add_devices_dir Anand Jain 2020-08-30 14:40 ` [PATCH 03/11] btrfs: refactor btrfs_sysfs_remove_devices_dir Anand Jain 2020-08-31 8:58 ` Nikolay Borisov 2020-08-31 9:12 ` Anand Jain 2020-08-30 14:40 ` [PATCH 04/11] btrfs: reada: use sprout device_list_mutex Anand Jain 2020-08-31 8:54 ` Nikolay Borisov 2020-08-31 16:08 ` Josef Bacik 2020-09-01 9:02 ` Anand Jain 2020-08-30 14:41 ` [PATCH 05/11] btrfs: btrfs_init_devices_late: " Anand Jain 2020-08-31 8:37 ` Nikolay Borisov 2020-09-01 8:54 ` Anand Jain 2020-08-30 14:41 ` [PATCH 06/11] btrfs: open code list_head pointer in btrfs_init_dev_replace_tgtdev Anand Jain 2020-08-31 8:38 ` Nikolay Borisov 2020-08-30 14:41 ` [PATCH 07/11] btrfs: cleanup btrfs_remove_chunk Anand Jain 2020-08-31 8:43 ` Nikolay Borisov 2020-08-30 14:41 ` [PATCH 08/11] btrfs: cleanup btrfs_assign_next_active_device() Anand Jain 2020-08-31 8:44 ` Nikolay Borisov 2020-08-30 14:41 ` [PATCH 09/11] btrfs: cleanup unnecessary goto in open_seed_device Anand Jain 2020-08-31 8:44 ` Nikolay Borisov 2020-08-30 14:41 ` [PATCH 10/11] btrfs: btrfs_dev_replace_update_device_in_mapping_tree drop file global declare Anand Jain 2020-08-31 8:46 ` Nikolay Borisov 2020-08-30 14:41 ` [PATCH 11/11] btrfs: fix replace of seed device Anand Jain -- strict thread matches above, loose matches on Subject: below -- 2020-08-21 13:15 [PATCH RFC] btrfs/163: replace sprout instead of seed Anand Jain 2020-08-30 14:41 ` [PATCH] fstests: " Anand Jain 2020-08-21 13:15 ` [PATCH 1/2] btrfs: initialize sysfs devid and device link for seed device Anand Jain 2020-08-21 13:15 ` [PATCH RFC 2/2] btrfs: fix replace of " Anand Jain 2020-08-21 14:38 ` Josef Bacik 2020-08-23 15:05 ` Anand Jain 2020-08-21 14:36 ` [PATCH 1/2] btrfs: initialize sysfs devid and device link for " Josef Bacik 2020-08-23 13:05 ` Anand Jain 2020-08-29 11:44 ` Anand Jain
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=cover.1598792561.git.anand.jain@oracle.com \ --to=anand.jain@oracle.com \ --cc=dsterba@suse.com \ --cc=josef@toxicpanda.com \ --cc=linux-btrfs@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.