[PATCH v2 0/5] video: seps525: Add new driver for seps525 OLED display

[PATCH v2 0/5] video: seps525: Add new driver for seps525 OLED display

[Michal Simek]

Hi,

This driver is connected via spi on one ZynqMP board. Only 8bit SPI
connection is supported now. Spi zynq driver was used for testing this
driver.
We have tested load image via BMP command and also using it as console as
is visible from log in the last patch.

Thanks,
Michal

Changes in v2:
- New patch is series
- New patch is series
- Add support for returning value
- Update kernel-doc format to pass kernel-doc script
- Update patch subject s/call/operation/
- Fix Kconfig entry and use VIDEO_SEPS525 instead of SEPS525 and fix
  location
- Add kernel-doc structure for seps525_priv structure
- Remove flags variable and use macros directly

Michal Simek (4):
  video: Fix video sync kernel-doc format
  video: Let video_sync to return error value
  video: Introduce video_sync operation
  video: seps525: Add seps525 SPI driver

Vikhyat Goyal (1):
  video: seps525: Add dt binding description

 MAINTAINERS                                   |   2 +
 .../video/syncoam,seps525.txt                 |  24 ++
 drivers/video/Kconfig                         |   7 +
 drivers/video/Makefile                        |   1 +
 drivers/video/seps525.c                       | 327 ++++++++++++++++++
 drivers/video/vidconsole-uclass.c             |  40 ++-
 drivers/video/video-uclass.c                  |  21 +-
 include/video.h                               |  22 +-
 8 files changed, 424 insertions(+), 20 deletions(-)
 create mode 100644 doc/device-tree-bindings/video/syncoam,seps525.txt
 create mode 100644 drivers/video/seps525.c

-- 
2.29.2

[PATCH v2 1/5] video: Fix video sync kernel-doc format

[Michal Simek]

Place description below function parameters to make kernel-doc stript
happy. Also rename dev to vid to be aligned with function parameters.

Fixes: 1acafc73bfc7 ("dm: video: Add a video uclass")
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

Changes in v2:
- New patch is series

./scripts/kernel-doc -v -man include/video.h > /dev/null

---
 include/video.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/include/video.h b/include/video.h
index 9d09d2409af6..7313b17f7ce8 100644
--- a/include/video.h
+++ b/include/video.h
@@ -151,13 +151,13 @@ int video_clear(struct udevice *dev);
 /**
  * video_sync() - Sync a device's frame buffer with its hardware
  *
+ * @vid:	Device to sync
+ * @force:	True to force a sync even if there was one recently (this is
+ *		very expensive on sandbox)
+ *
  * Some frame buffers are cached or have a secondary frame buffer. This
  * function syncs these up so that the current contents of the U-Boot frame
  * buffer are displayed to the user.
- *
- * @dev:	Device to sync
- * @force:	True to force a sync even if there was one recently (this is
- *		very expensive on sandbox)
  */
 void video_sync(struct udevice *vid, bool force);
 
-- 
2.29.2

[PATCH v2 2/5] video: Let video_sync to return error value

[Michal Simek]

This patch is preparation for follow up one to support cases where
synchronization can fail.

Suggested-by: Simon Glass <sjg@chromium.org>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>

---

Changes in v2:
- New patch is series

 drivers/video/vidconsole-uclass.c | 40 ++++++++++++++++++++++---------
 drivers/video/video-uclass.c      | 12 +++++++---
 include/video.h                   |  4 +++-
 3 files changed, 41 insertions(+), 15 deletions(-)

diff --git a/drivers/video/vidconsole-uclass.c b/drivers/video/vidconsole-uclass.c
index 3a07f36ce278..f29c0e58c76d 100644
--- a/drivers/video/vidconsole-uclass.c
+++ b/drivers/video/vidconsole-uclass.c
@@ -89,9 +89,7 @@ static int vidconsole_back(struct udevice *dev)
 		if (priv->ycur < 0)
 			priv->ycur = 0;
 	}
-	video_sync(dev->parent, false);
-
-	return 0;
+	return video_sync(dev->parent, false);
 }
 
 /* Move to a newline, scrolling the display if necessary */
@@ -101,7 +99,7 @@ static void vidconsole_newline(struct udevice *dev)
 	struct udevice *vid_dev = dev->parent;
 	struct video_priv *vid_priv = dev_get_uclass_priv(vid_dev);
 	const int rows = CONFIG_CONSOLE_SCROLL_LINES;
-	int i;
+	int i, ret;
 
 	priv->xcur_frac = priv->xstart_frac;
 	priv->ycur += priv->y_charsize;
@@ -116,7 +114,12 @@ static void vidconsole_newline(struct udevice *dev)
 	}
 	priv->last_ch = 0;
 
-	video_sync(dev->parent, false);
+	ret = video_sync(dev->parent, false);
+	if (ret) {
+#ifdef DEBUG
+		console_puts_select_stderr(true, "[vc err: video_sync]");
+#endif
+	}
 }
 
 static const struct vid_rgb colors[VID_COLOR_COUNT] = {
@@ -348,8 +351,15 @@ static void vidconsole_escape_char(struct udevice *dev, char ch)
 		parsenum(priv->escape_buf + 1, &mode);
 
 		if (mode == 2) {
+			int ret;
+
 			video_clear(dev->parent);
-			video_sync(dev->parent, false);
+			ret = video_sync(dev->parent, false);
+			if (ret) {
+#ifdef DEBUG
+				console_puts_select_stderr(true, "[vc err: video_sync]");
+#endif
+			}
 			priv->ycur = 0;
 			priv->xcur_frac = priv->xstart_frac;
 		} else {
@@ -565,7 +575,12 @@ static void vidconsole_putc(struct stdio_dev *sdev, const char ch)
 		console_puts_select_stderr(true, "[vc err: putc]");
 #endif
 	}
-	video_sync(dev->parent, false);
+	ret = video_sync(dev->parent, false);
+	if (ret) {
+#ifdef DEBUG
+		console_puts_select_stderr(true, "[vc err: video_sync]");
+#endif
+	}
 }
 
 static void vidconsole_puts(struct stdio_dev *sdev, const char *s)
@@ -582,7 +597,12 @@ static void vidconsole_puts(struct stdio_dev *sdev, const char *s)
 		console_puts_select_stderr(true, str);
 #endif
 	}
-	video_sync(dev->parent, false);
+	ret = video_sync(dev->parent, false);
+	if (ret) {
+#ifdef DEBUG
+		console_puts_select_stderr(true, "[vc err: video_sync]");
+#endif
+	}
 }
 
 /* Set up the number of rows and colours (rotated drivers override this) */
@@ -691,9 +711,7 @@ static int do_video_puts(struct cmd_tbl *cmdtp, int flag, int argc,
 	for (s = argv[1]; *s; s++)
 		vidconsole_put_char(dev, *s);
 
-	video_sync(dev->parent, false);
-
-	return 0;
+	return video_sync(dev->parent, false);
 }
 
 U_BOOT_CMD(
diff --git a/drivers/video/video-uclass.c b/drivers/video/video-uclass.c
index 650891e49dd0..6fc412801714 100644
--- a/drivers/video/video-uclass.c
+++ b/drivers/video/video-uclass.c
@@ -15,6 +15,7 @@
 #include <video_console.h>
 #include <asm/cache.h>
 #include <dm/lists.h>
+#include <dm/device_compat.h>
 #include <dm/device-internal.h>
 #include <dm/uclass-internal.h>
 #ifdef CONFIG_SANDBOX
@@ -172,7 +173,7 @@ void video_set_default_colors(struct udevice *dev, bool invert)
 }
 
 /* Flush video activity to the caches */
-void video_sync(struct udevice *vid, bool force)
+int video_sync(struct udevice *vid, bool force)
 {
 	/*
 	 * flush_dcache_range() is declared in common.h but it seems that some
@@ -196,17 +197,22 @@ void video_sync(struct udevice *vid, bool force)
 		last_sync = get_timer(0);
 	}
 #endif
+	return 0;
 }
 
 void video_sync_all(void)
 {
 	struct udevice *dev;
+	int ret;
 
 	for (uclass_find_first_device(UCLASS_VIDEO, &dev);
 	     dev;
 	     uclass_find_next_device(&dev)) {
-		if (device_active(dev))
-			video_sync(dev, true);
+		if (device_active(dev)) {
+			ret = video_sync(dev, true);
+			if (ret)
+				dev_dbg(dev, "Video sync failed\n");
+		}
 	}
 }
 
diff --git a/include/video.h b/include/video.h
index 7313b17f7ce8..1bfe6843a805 100644
--- a/include/video.h
+++ b/include/video.h
@@ -155,11 +155,13 @@ int video_clear(struct udevice *dev);
  * @force:	True to force a sync even if there was one recently (this is
  *		very expensive on sandbox)
  *
+ * @return: 0 always
+ *
  * Some frame buffers are cached or have a secondary frame buffer. This
  * function syncs these up so that the current contents of the U-Boot frame
  * buffer are displayed to the user.
  */
-void video_sync(struct udevice *vid, bool force);
+int video_sync(struct udevice *vid, bool force);
 
 /**
  * video_sync_all() - Sync all devices' frame buffers with there hardware
-- 
2.29.2

[PATCH v2 3/5] video: Introduce video_sync operation

[Michal Simek]

Some drivers like LCD connected via SPI requires explicit sync function
which copy framebuffer content over SPI to controller to display.
This hook doesn't exist yet that's why introduce it via video operations.

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

Changes in v2:
- Add support for returning value
- Update kernel-doc format to pass kernel-doc script
- Update patch subject s/call/operation/

Simon: Please review this. I didn't find existing way how this can be done
that's why I am introducing this hook. Also maybe name can be named a
little bit differently. That's why waiting for better suggestion.

---
 drivers/video/video-uclass.c |  9 +++++++++
 include/video.h              | 12 ++++++++++--
 2 files changed, 19 insertions(+), 2 deletions(-)

diff --git a/drivers/video/video-uclass.c b/drivers/video/video-uclass.c
index 6fc412801714..938e7d371311 100644
--- a/drivers/video/video-uclass.c
+++ b/drivers/video/video-uclass.c
@@ -175,6 +175,15 @@ void video_set_default_colors(struct udevice *dev, bool invert)
 /* Flush video activity to the caches */
 int video_sync(struct udevice *vid, bool force)
 {
+	struct video_ops *ops = video_get_ops(vid);
+	int ret;
+
+	if (ops && ops->video_sync) {
+		ret = ops->video_sync(vid);
+		if (ret)
+			return ret;
+	}
+
 	/*
 	 * flush_dcache_range() is declared in common.h but it seems that some
 	 * architectures do not actually implement it. Is there a way to find
diff --git a/include/video.h b/include/video.h
index 1bfe6843a805..12fc525ab4ef 100644
--- a/include/video.h
+++ b/include/video.h
@@ -114,8 +114,16 @@ struct video_priv {
 	u8 bg_col_idx;
 };
 
-/* Placeholder - there are no video operations at present */
+/**
+ * struct video_ops - structure for keeping video operations
+ * @video_sync: Synchronize FB with device. Some device like SPI based LCD
+ *		displays needs synchronization when data in an FB is available.
+ *		For these devices implement video_sync hook to call a sync
+ *		function. vid is pointer to video device udevice. Function
+ *		should return 0 on success video_sync and error code otherwise
+ */
 struct video_ops {
+	int (*video_sync)(struct udevice *vid);
 };
 
 #define video_get_ops(dev)        ((struct video_ops *)(dev)->driver->ops)
@@ -155,7 +163,7 @@ int video_clear(struct udevice *dev);
  * @force:	True to force a sync even if there was one recently (this is
  *		very expensive on sandbox)
  *
- * @return: 0 always
+ * @return: 0 on success, error code otherwise
  *
  * Some frame buffers are cached or have a secondary frame buffer. This
  * function syncs these up so that the current contents of the U-Boot frame
-- 
2.29.2

[PATCH v2 4/5] video: seps525: Add dt binding description

[Michal Simek]

From: Vikhyat Goyal <vikhyat.goyal@xilinx.com>

Added dt binding for seps525 display driver.

Signed-off-by: Vikhyat Goyal <vikhyat.goyal@xilinx.com>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
---

(no changes since v1)

 MAINTAINERS                                   |  1 +
 .../video/syncoam,seps525.txt                 | 24 +++++++++++++++++++
 2 files changed, 25 insertions(+)
 create mode 100644 doc/device-tree-bindings/video/syncoam,seps525.txt

diff --git a/MAINTAINERS b/MAINTAINERS
index 127e30c0a5e0..11857ece9a53 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -547,6 +547,7 @@ S:	Maintained
 T:	git https://gitlab.denx.de/u-boot/custodians/u-boot-microblaze.git
 F:	arch/arm/mach-zynq/
 F:	doc/board/xilinx/
+F:	doc/device-tree-bindings/video/syncoam,seps525.txt
 F:	drivers/clk/clk_zynq.c
 F:	drivers/fpga/zynqpl.c
 F:	drivers/gpio/zynq_gpio.c
diff --git a/doc/device-tree-bindings/video/syncoam,seps525.txt b/doc/device-tree-bindings/video/syncoam,seps525.txt
new file mode 100644
index 000000000000..e1e0db9d71fb
--- /dev/null
+++ b/doc/device-tree-bindings/video/syncoam,seps525.txt
@@ -0,0 +1,24 @@
+spi based seps525 framebuffer display driver
+
+Driver for seps525 display controller (in spi mode), This binding supports selection
+of spi chipselect, spi max frequency, gpio to drive dc and reset pin of seps525
+controller and spi transaction bit length.
+
+Required properties:
+- compatible: "syncoam,seps525"
+- reg: Specifies the chip-select the seps525 is connected to on the spi bus
+- reset-gpios: gpio connected to reset pin of seps525 controller.
+- dc-gpios: gpio connected to dc pin of seps525 controller:
+- buswidth: bitlength of each spi transaction
+
+Example:
+	displayspi at 0 {
+		compatible = "syncoam,seps525";
+		reg = <0>;
+		spi-max-frequency = <10000000>;
+		spi-cpol;
+		spi-cpha;
+		buswidth = <8>;
+		reset-gpios = <&gpio 0x1c GPIO_ACTIVE_LOW>;
+		dc-gpios = <&gpio 0x1b GPIO_ACTIVE_HIGH>;
+	};
-- 
2.29.2

[PATCH v2 5/5] video: seps525: Add seps525 SPI driver

[Michal Simek]

Add support for the WiseChip Semiconductor Inc. (UG-6028GDEBF02) display
using the SEPS525 (Syncoam) LCD Controller. Syncoam Seps525 PM-Oled is RGB
160x128 display. This driver has been tested through zynq-spi driver.

ZynqMP> load mmc 1 100000 rainbow.bmp
61562 bytes read in 20 ms (2.9 MiB/s)
ZynqMP> bmp info 100000
Image size    : 160 x 128
Bits per pixel: 24
Compression   : 0
ZynqMP> bmp display 100000
ZynqMP> setenv stdout vidconsole

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
---

Changes in v2:
- Fix Kconfig entry and use VIDEO_SEPS525 instead of SEPS525 and fix
  location
- Add kernel-doc structure for seps525_priv structure
- Remove flags variable and use macros directly

 MAINTAINERS             |   1 +
 drivers/video/Kconfig   |   7 +
 drivers/video/Makefile  |   1 +
 drivers/video/seps525.c | 327 ++++++++++++++++++++++++++++++++++++++++
 4 files changed, 336 insertions(+)
 create mode 100644 drivers/video/seps525.c

diff --git a/MAINTAINERS b/MAINTAINERS
index 11857ece9a53..847b63685a29 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -589,6 +589,7 @@ F:	drivers/spi/zynq_qspi.c
 F:	drivers/spi/zynq_spi.c
 F:	drivers/timer/cadence-ttc.c
 F:	drivers/usb/host/ehci-zynq.c
+F:	drivers/video/seps525.c
 F:	drivers/watchdog/cdns_wdt.c
 F:	include/zynqmppl.h
 F:	include/zynqmp_firmware.h
diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
index 998271b9b628..71363409f04e 100644
--- a/drivers/video/Kconfig
+++ b/drivers/video/Kconfig
@@ -652,6 +652,13 @@ config VIDEO_NX
 	   HDMI. This option enables this support which can be used on devices
 	   which have an eDP display connected.
 
+config VIDEO_SEPS525
+	bool "Enable video support for Seps525"
+	depends on DM_VIDEO
+	help
+	  Enable support for the Syncoam PM-OLED display driver (RGB 160x128).
+	  Currently driver is supporting only SPI interface.
+
 source "drivers/video/nexell/Kconfig"
 
 config VIDEO
diff --git a/drivers/video/Makefile b/drivers/video/Makefile
index 67a492a2d60d..9db96aa891a3 100644
--- a/drivers/video/Makefile
+++ b/drivers/video/Makefile
@@ -70,6 +70,7 @@ obj-$(CONFIG_VIDEO_SIMPLE) += simplefb.o
 obj-$(CONFIG_VIDEO_TEGRA20) += tegra.o
 obj-$(CONFIG_VIDEO_VCXK) += bus_vcxk.o
 obj-$(CONFIG_VIDEO_VESA) += vesa.o
+obj-$(CONFIG_VIDEO_SEPS525) += seps525.o
 
 obj-y += bridge/
 obj-y += sunxi/
diff --git a/drivers/video/seps525.c b/drivers/video/seps525.c
new file mode 100644
index 000000000000..2b4d5bdda04e
--- /dev/null
+++ b/drivers/video/seps525.c
@@ -0,0 +1,327 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * FB driver for the WiseChip Semiconductor Inc. (UG-6028GDEBF02) display
+ * using the SEPS525 (Syncoam) LCD Controller
+ *
+ * Copyright (C) 2020 Xilinx Inc.
+ */
+
+#include <common.h>
+#include <command.h>
+#include <cpu_func.h>
+#include <dm.h>
+#include <errno.h>
+#include <spi.h>
+#include <video.h>
+#include <asm/gpio.h>
+#include <dm/device_compat.h>
+#include <linux/delay.h>
+
+#define WIDTH		160
+#define HEIGHT		128
+
+#define SEPS525_INDEX			0x00
+#define SEPS525_STATUS_RD		0x01
+#define SEPS525_OSC_CTL			0x02
+#define SEPS525_IREF			0x80
+#define SEPS525_CLOCK_DIV		0x03
+#define SEPS525_REDUCE_CURRENT		0x04
+#define SEPS525_SOFT_RST		0x05
+#define SEPS525_DISP_ONOFF		0x06
+#define SEPS525_PRECHARGE_TIME_R	0x08
+#define SEPS525_PRECHARGE_TIME_G	0x09
+#define SEPS525_PRECHARGE_TIME_B	0x0A
+#define SEPS525_PRECHARGE_CURRENT_R	0x0B
+#define SEPS525_PRECHARGE_CURRENT_G	0x0C
+#define SEPS525_PRECHARGE_CURRENT_B	0x0D
+#define SEPS525_DRIVING_CURRENT_R	0x10
+#define SEPS525_DRIVING_CURRENT_G	0x11
+#define SEPS525_DRIVING_CURRENT_B	0x12
+#define SEPS525_DISPLAYMODE_SET		0x13
+#define SEPS525_RGBIF			0x14
+#define SEPS525_RGB_POL			0x15
+#define SEPS525_MEMORY_WRITEMODE	0x16
+#define SEPS525_MX1_ADDR		0x17
+#define SEPS525_MX2_ADDR		0x18
+#define SEPS525_MY1_ADDR		0x19
+#define SEPS525_MY2_ADDR		0x1A
+#define SEPS525_MEMORY_ACCESS_POINTER_X	0x20
+#define SEPS525_MEMORY_ACCESS_POINTER_Y	0x21
+#define SEPS525_DDRAM_DATA_ACCESS_PORT	0x22
+#define SEPS525_GRAY_SCALE_TABLE_INDEX	0x50
+#define SEPS525_GRAY_SCALE_TABLE_DATA	0x51
+#define SEPS525_DUTY			0x28
+#define SEPS525_DSL			0x29
+#define SEPS525_D1_DDRAM_FAC		0x2E
+#define SEPS525_D1_DDRAM_FAR		0x2F
+#define SEPS525_D2_DDRAM_SAC		0x31
+#define SEPS525_D2_DDRAM_SAR		0x32
+#define SEPS525_SCR1_FX1		0x33
+#define SEPS525_SCR1_FX2		0x34
+#define SEPS525_SCR1_FY1		0x35
+#define SEPS525_SCR1_FY2		0x36
+#define SEPS525_SCR2_SX1		0x37
+#define SEPS525_SCR2_SX2		0x38
+#define SEPS525_SCR2_SY1		0x39
+#define SEPS525_SCR2_SY2		0x3A
+#define SEPS525_SCREEN_SAVER_CONTEROL	0x3B
+#define SEPS525_SS_SLEEP_TIMER		0x3C
+#define SEPS525_SCREEN_SAVER_MODE	0x3D
+#define SEPS525_SS_SCR1_FU		0x3E
+#define SEPS525_SS_SCR1_MXY		0x3F
+#define SEPS525_SS_SCR2_FU		0x40
+#define SEPS525_SS_SCR2_MXY		0x41
+#define SEPS525_MOVING_DIRECTION	0x42
+#define SEPS525_SS_SCR2_SX1		0x47
+#define SEPS525_SS_SCR2_SX2		0x48
+#define SEPS525_SS_SCR2_SY1		0x49
+#define SEPS525_SS_SCR2_SY2		0x4A
+
+/* SEPS525_DISPLAYMODE_SET */
+#define MODE_SWAP_BGR	BIT(7)
+#define MODE_SM		BIT(6)
+#define MODE_RD		BIT(5)
+#define MODE_CD		BIT(4)
+
+/**
+ * struct seps525_priv - Private structure
+ * @reset_gpio: Reset gpio pin
+ * @dc_gpio: Data/command control gpio pin
+ * @dev: Device uclass for video_ops
+ */
+struct seps525_priv {
+	struct gpio_desc reset_gpio;
+	struct gpio_desc dc_gpio;
+	struct udevice *dev;
+};
+
+static int seps525_spi_write_cmd(struct udevice *dev, u8 reg)
+{
+	struct seps525_priv *priv = dev_get_priv(dev);
+	u8 buf8 = reg;
+	int ret;
+
+	ret = dm_gpio_set_value(&priv->dc_gpio, 0);
+	if (ret) {
+		dev_dbg(dev, "Failed to handle dc\n");
+		return ret;
+	}
+
+	ret = dm_spi_xfer(dev, 8, &buf8, NULL, SPI_XFER_BEGIN | SPI_XFER_END);
+	if (ret)
+		dev_dbg(dev, "Failed to write command\n");
+
+	return ret;
+}
+
+static int seps525_spi_write_data(struct udevice *dev, u8 val)
+{
+	struct seps525_priv *priv = dev_get_priv(dev);
+	u8 buf8 = val;
+	int ret;
+
+	ret = dm_gpio_set_value(&priv->dc_gpio, 1);
+	if (ret) {
+		dev_dbg(dev, "Failed to handle dc\n");
+		return ret;
+	}
+
+	ret = dm_spi_xfer(dev, 8, &buf8, NULL, SPI_XFER_BEGIN | SPI_XFER_END);
+	if (ret)
+		dev_dbg(dev, "Failed to write data\n");
+
+	return ret;
+}
+
+static void seps525_spi_write(struct udevice *dev, u8 reg, u8 val)
+{
+	(void)seps525_spi_write_cmd(dev, reg);
+	(void)seps525_spi_write_data(dev, val);
+}
+
+static int seps525_display_init(struct udevice *dev)
+{
+	/* Disable Oscillator Power Down */
+	seps525_spi_write(dev, SEPS525_REDUCE_CURRENT, 0x03);
+	mdelay(5);
+
+	/* Set Normal Driving Current */
+	seps525_spi_write(dev, SEPS525_REDUCE_CURRENT, 0x00);
+	mdelay(5);
+
+	seps525_spi_write(dev, SEPS525_SCREEN_SAVER_CONTEROL, 0x00);
+	/* Set EXPORT1 Pin at Internal Clock */
+	seps525_spi_write(dev, SEPS525_OSC_CTL, 0x01);
+	/* Set Clock as 120 Frames/Sec */
+	seps525_spi_write(dev, SEPS525_CLOCK_DIV, 0x90);
+	/* Set Reference Voltage Controlled by External Resister */
+	seps525_spi_write(dev, SEPS525_IREF, 0x01);
+
+	/* precharge time R G B */
+	seps525_spi_write(dev, SEPS525_PRECHARGE_TIME_R, 0x04);
+	seps525_spi_write(dev, SEPS525_PRECHARGE_TIME_G, 0x05);
+	seps525_spi_write(dev, SEPS525_PRECHARGE_TIME_B, 0x05);
+
+	/* precharge current R G B (uA) */
+	seps525_spi_write(dev, SEPS525_PRECHARGE_CURRENT_R, 0x9D);
+	seps525_spi_write(dev, SEPS525_PRECHARGE_CURRENT_G, 0x8C);
+	seps525_spi_write(dev, SEPS525_PRECHARGE_CURRENT_B, 0x57);
+
+	/* driving current R G B (uA) */
+	seps525_spi_write(dev, SEPS525_DRIVING_CURRENT_R, 0x56);
+	seps525_spi_write(dev, SEPS525_DRIVING_CURRENT_G, 0x4D);
+	seps525_spi_write(dev, SEPS525_DRIVING_CURRENT_B, 0x46);
+	/* Set Color Sequence */
+	seps525_spi_write(dev, SEPS525_DISPLAYMODE_SET, 0x00);
+	/* Set MCU Interface Mode */
+	seps525_spi_write(dev, SEPS525_RGBIF, 0x01);
+	/* Set Memory Write Mode */
+	seps525_spi_write(dev, SEPS525_MEMORY_WRITEMODE, 0x66);
+	/* 1/128 Duty (0x0F~0x7F) */
+	seps525_spi_write(dev, SEPS525_DUTY, 0x7F);
+	/* Set Mapping RAM Display Start Line (0x00~0x7F) */
+	seps525_spi_write(dev, SEPS525_DSL, 0x00);
+	/* Display On (0x00/0x01) */
+	seps525_spi_write(dev, SEPS525_DISP_ONOFF, 0x01);
+	/* Set All Internal Register Value as Normal Mode */
+	seps525_spi_write(dev, SEPS525_SOFT_RST, 0x00);
+	/* Set RGB Interface Polarity as Active Low */
+	seps525_spi_write(dev, SEPS525_RGB_POL, 0x00);
+
+	/* Enable access for data */
+	(void)seps525_spi_write_cmd(dev, SEPS525_DDRAM_DATA_ACCESS_PORT);
+
+	return 0;
+}
+
+static int seps525_spi_startup(struct udevice *dev)
+{
+	struct seps525_priv *priv = dev_get_priv(dev);
+	int ret;
+
+	ret = dm_gpio_set_value(&priv->reset_gpio, 1);
+	if (ret)
+		return ret;
+
+	ret = dm_gpio_set_value(&priv->reset_gpio, 0);
+	if (ret)
+		return ret;
+
+	ret = dm_spi_claim_bus(dev);
+	if (ret) {
+		dev_err(dev, "Failed to claim SPI bus: %d\n", ret);
+		return ret;
+	}
+
+	ret = seps525_display_init(dev);
+	if (ret)
+		return ret;
+
+	dm_spi_release_bus(dev);
+
+	return 0;
+}
+
+static int seps525_sync(struct udevice *vid)
+{
+	struct video_priv *uc_priv = dev_get_uclass_priv(vid);
+	struct seps525_priv *priv = dev_get_priv(vid);
+	struct udevice *dev = priv->dev;
+	int i, ret;
+	u8 data1, data2;
+	u8 *start = uc_priv->fb;
+
+	ret = dm_spi_claim_bus(dev);
+	if (ret) {
+		dev_err(dev, "Failed to claim SPI bus: %d\n", ret);
+		return ret;
+	}
+
+	/* start position X,Y */
+	seps525_spi_write(dev, SEPS525_MEMORY_ACCESS_POINTER_X, 0);
+	seps525_spi_write(dev, SEPS525_MEMORY_ACCESS_POINTER_Y, 0);
+
+	/* Enable access for data */
+	(void)seps525_spi_write_cmd(dev, SEPS525_DDRAM_DATA_ACCESS_PORT);
+
+	for (i = 0; i < (uc_priv->xsize * uc_priv->ysize); i++) {
+		data2 = *start++;
+		data1 = *start++;
+		(void)seps525_spi_write_data(dev, data1);
+		(void)seps525_spi_write_data(dev, data2);
+	}
+
+	dm_spi_release_bus(dev);
+
+	return 0;
+}
+
+static int seps525_probe(struct udevice *dev)
+{
+	struct video_priv *uc_priv = dev_get_uclass_priv(dev);
+	struct seps525_priv *priv = dev_get_priv(dev);
+	u32 buswidth;
+	int ret;
+
+	buswidth = dev_read_u32_default(dev, "buswidth", 0);
+	if (buswidth != 8) {
+		dev_err(dev, "Only 8bit buswidth is supported now");
+		return -EINVAL;
+	}
+
+	ret = gpio_request_by_name(dev, "reset-gpios", 0,
+				   &priv->reset_gpio, GPIOD_IS_OUT);
+	if (ret) {
+		dev_err(dev, "missing reset GPIO\n");
+		return ret;
+	}
+
+	ret = gpio_request_by_name(dev, "dc-gpios", 0,
+				   &priv->dc_gpio, GPIOD_IS_OUT);
+	if (ret) {
+		dev_err(dev, "missing dc GPIO\n");
+		return ret;
+	}
+
+	uc_priv->bpix = VIDEO_BPP16;
+	uc_priv->xsize = WIDTH;
+	uc_priv->ysize = HEIGHT;
+	uc_priv->rot = 0;
+
+	priv->dev = dev;
+
+	ret = seps525_spi_startup(dev);
+	if (ret)
+		return ret;
+
+	return 0;
+}
+
+static int seps525_bind(struct udevice *dev)
+{
+	struct video_uc_platdata *plat = dev_get_uclass_platdata(dev);
+
+	plat->size = WIDTH * HEIGHT * 16;
+
+	return 0;
+}
+
+static const struct video_ops seps525_ops = {
+	.video_sync = seps525_sync,
+};
+
+static const struct udevice_id seps525_ids[] = {
+	{ .compatible = "syncoam,seps525" },
+	{ }
+};
+
+U_BOOT_DRIVER(seps525_video) = {
+	.name = "seps525_video",
+	.id = UCLASS_VIDEO,
+	.of_match = seps525_ids,
+	.ops = &seps525_ops,
+	.platdata_auto_alloc_size = sizeof(struct video_uc_platdata),
+	.bind = seps525_bind,
+	.probe = seps525_probe,
+	.priv_auto_alloc_size = sizeof(struct seps525_priv),
+};
-- 
2.29.2

[PATCH v2 1/5] video: Fix video sync kernel-doc format

[Simon Glass]

On Mon, 14 Dec 2020 at 01:38, Michal Simek <michal.simek@xilinx.com> wrote:
>
> Place description below function parameters to make kernel-doc stript
> happy. Also rename dev to vid to be aligned with function parameters.
>
> Fixes: 1acafc73bfc7 ("dm: video: Add a video uclass")
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
> Changes in v2:
> - New patch is series
>
> ./scripts/kernel-doc -v -man include/video.h > /dev/null
>
> ---
>  include/video.h | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

[PATCH v2 2/5] video: Let video_sync to return error value

[Simon Glass]

On Mon, 14 Dec 2020 at 01:38, Michal Simek <michal.simek@xilinx.com> wrote:
>
> This patch is preparation for follow up one to support cases where
> synchronization can fail.
>
> Suggested-by: Simon Glass <sjg@chromium.org>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>
> ---
>
> Changes in v2:
> - New patch is series
>
>  drivers/video/vidconsole-uclass.c | 40 ++++++++++++++++++++++---------
>  drivers/video/video-uclass.c      | 12 +++++++---
>  include/video.h                   |  4 +++-
>  3 files changed, 41 insertions(+), 15 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

[..]


> diff --git a/include/video.h b/include/video.h
> index 7313b17f7ce8..1bfe6843a805 100644
> --- a/include/video.h
> +++ b/include/video.h
> @@ -155,11 +155,13 @@ int video_clear(struct udevice *dev);
>   * @force:     True to force a sync even if there was one recently (this is
>   *             very expensive on sandbox)
>   *
> + * @return: 0 always
> + *
>   * Some frame buffers are cached or have a secondary frame buffer. This
>   * function syncs these up so that the current contents of the U-Boot frame
>   * buffer are displayed to the user.
>   */
> -void video_sync(struct udevice *vid, bool force);
> +int video_sync(struct udevice *vid, bool force);
>
>  /**
>   * video_sync_all() - Sync all devices' frame buffers with there hardware
> --
> 2.29.2
>

[PATCH v2 3/5] video: Introduce video_sync operation

[Simon Glass]

On Mon, 14 Dec 2020 at 01:38, Michal Simek <michal.simek@xilinx.com> wrote:
>
> Some drivers like LCD connected via SPI requires explicit sync function
> which copy framebuffer content over SPI to controller to display.
> This hook doesn't exist yet that's why introduce it via video operations.
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
> Changes in v2:
> - Add support for returning value
> - Update kernel-doc format to pass kernel-doc script
> - Update patch subject s/call/operation/
>
> Simon: Please review this. I didn't find existing way how this can be done
> that's why I am introducing this hook. Also maybe name can be named a
> little bit differently. That's why waiting for better suggestion.
>
> ---
>  drivers/video/video-uclass.c |  9 +++++++++
>  include/video.h              | 12 ++++++++++--
>  2 files changed, 19 insertions(+), 2 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

>
> diff --git a/drivers/video/video-uclass.c b/drivers/video/video-uclass.c
> index 6fc412801714..938e7d371311 100644
> --- a/drivers/video/video-uclass.c
> +++ b/drivers/video/video-uclass.c
> @@ -175,6 +175,15 @@ void video_set_default_colors(struct udevice *dev, bool invert)
>  /* Flush video activity to the caches */
>  int video_sync(struct udevice *vid, bool force)
>  {
> +       struct video_ops *ops = video_get_ops(vid);
> +       int ret;
> +
> +       if (ops && ops->video_sync) {
> +               ret = ops->video_sync(vid);
> +               if (ret)
> +                       return ret;
> +       }
> +
>         /*
>          * flush_dcache_range() is declared in common.h but it seems that some
>          * architectures do not actually implement it. Is there a way to find
> diff --git a/include/video.h b/include/video.h
> index 1bfe6843a805..12fc525ab4ef 100644
> --- a/include/video.h
> +++ b/include/video.h
> @@ -114,8 +114,16 @@ struct video_priv {
>         u8 bg_col_idx;
>  };
>
> -/* Placeholder - there are no video operations at present */
> +/**
> + * struct video_ops - structure for keeping video operations
> + * @video_sync: Synchronize FB with device. Some device like SPI based LCD
> + *             displays needs synchronization when data in an FB is available.
> + *             For these devices implement video_sync hook to call a sync
> + *             function. vid is pointer to video device udevice. Function
> + *             should return 0 on success video_sync and error code otherwise

Can this go before the video_sync, below?


> + */
>  struct video_ops {
> +       int (*video_sync)(struct udevice *vid);
>  };
>
>  #define video_get_ops(dev)        ((struct video_ops *)(dev)->driver->ops)
> @@ -155,7 +163,7 @@ int video_clear(struct udevice *dev);
>   * @force:     True to force a sync even if there was one recently (this is
>   *             very expensive on sandbox)
>   *
> - * @return: 0 always
> + * @return: 0 on success, error code otherwise
>   *
>   * Some frame buffers are cached or have a secondary frame buffer. This
>   * function syncs these up so that the current contents of the U-Boot frame
> --
> 2.29.2
>

[PATCH v2 3/5] video: Introduce video_sync operation

[Michal Simek]

On 15. 12. 20 5:00, Simon Glass wrote:
> On Mon, 14 Dec 2020 at 01:38, Michal Simek <michal.simek@xilinx.com> wrote:
>>
>> Some drivers like LCD connected via SPI requires explicit sync function
>> which copy framebuffer content over SPI to controller to display.
>> This hook doesn't exist yet that's why introduce it via video operations.
>>
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>> ---
>>
>> Changes in v2:
>> - Add support for returning value
>> - Update kernel-doc format to pass kernel-doc script
>> - Update patch subject s/call/operation/
>>
>> Simon: Please review this. I didn't find existing way how this can be done
>> that's why I am introducing this hook. Also maybe name can be named a
>> little bit differently. That's why waiting for better suggestion.
>>
>> ---
>>  drivers/video/video-uclass.c |  9 +++++++++
>>  include/video.h              | 12 ++++++++++--
>>  2 files changed, 19 insertions(+), 2 deletions(-)
> 
> Reviewed-by: Simon Glass <sjg@chromium.org>
> 
>>
>> diff --git a/drivers/video/video-uclass.c b/drivers/video/video-uclass.c
>> index 6fc412801714..938e7d371311 100644
>> --- a/drivers/video/video-uclass.c
>> +++ b/drivers/video/video-uclass.c
>> @@ -175,6 +175,15 @@ void video_set_default_colors(struct udevice *dev, bool invert)
>>  /* Flush video activity to the caches */
>>  int video_sync(struct udevice *vid, bool force)
>>  {
>> +       struct video_ops *ops = video_get_ops(vid);
>> +       int ret;
>> +
>> +       if (ops && ops->video_sync) {
>> +               ret = ops->video_sync(vid);
>> +               if (ret)
>> +                       return ret;
>> +       }
>> +
>>         /*
>>          * flush_dcache_range() is declared in common.h but it seems that some
>>          * architectures do not actually implement it. Is there a way to find
>> diff --git a/include/video.h b/include/video.h
>> index 1bfe6843a805..12fc525ab4ef 100644
>> --- a/include/video.h
>> +++ b/include/video.h
>> @@ -114,8 +114,16 @@ struct video_priv {
>>         u8 bg_col_idx;
>>  };
>>
>> -/* Placeholder - there are no video operations at present */
>> +/**
>> + * struct video_ops - structure for keeping video operations
>> + * @video_sync: Synchronize FB with device. Some device like SPI based LCD
>> + *             displays needs synchronization when data in an FB is available.
>> + *             For these devices implement video_sync hook to call a sync
>> + *             function. vid is pointer to video device udevice. Function
>> + *             should return 0 on success video_sync and error code otherwise
> 
> Can this go before the video_sync, below?

I was checking some files in Linux how they are dealing with it to pass
kernel-doc and all of them used this format.
Also if I look at include/dm/uclass.h  - struct uclass_driver
it is done in the same way.

Maybe we can ask Linux guys if there is a better way than this one.

Thanks,
Michal

[PATCH v2 3/5] video: Introduce video_sync operation

[Simon Glass]

Hi Michal,

On Mon, 14 Dec 2020 at 23:57, Michal Simek <michal.simek@xilinx.com> wrote:
>
>
>
> On 15. 12. 20 5:00, Simon Glass wrote:
> > On Mon, 14 Dec 2020 at 01:38, Michal Simek <michal.simek@xilinx.com> wrote:
> >>
> >> Some drivers like LCD connected via SPI requires explicit sync function
> >> which copy framebuffer content over SPI to controller to display.
> >> This hook doesn't exist yet that's why introduce it via video operations.
> >>
> >> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> >> ---
> >>
> >> Changes in v2:
> >> - Add support for returning value
> >> - Update kernel-doc format to pass kernel-doc script
> >> - Update patch subject s/call/operation/
> >>
> >> Simon: Please review this. I didn't find existing way how this can be done
> >> that's why I am introducing this hook. Also maybe name can be named a
> >> little bit differently. That's why waiting for better suggestion.
> >>
> >> ---
> >>  drivers/video/video-uclass.c |  9 +++++++++
> >>  include/video.h              | 12 ++++++++++--
> >>  2 files changed, 19 insertions(+), 2 deletions(-)
> >
> > Reviewed-by: Simon Glass <sjg@chromium.org>
> >
> >>
> >> diff --git a/drivers/video/video-uclass.c b/drivers/video/video-uclass.c
> >> index 6fc412801714..938e7d371311 100644
> >> --- a/drivers/video/video-uclass.c
> >> +++ b/drivers/video/video-uclass.c
> >> @@ -175,6 +175,15 @@ void video_set_default_colors(struct udevice *dev, bool invert)
> >>  /* Flush video activity to the caches */
> >>  int video_sync(struct udevice *vid, bool force)
> >>  {
> >> +       struct video_ops *ops = video_get_ops(vid);
> >> +       int ret;
> >> +
> >> +       if (ops && ops->video_sync) {
> >> +               ret = ops->video_sync(vid);
> >> +               if (ret)
> >> +                       return ret;
> >> +       }
> >> +
> >>         /*
> >>          * flush_dcache_range() is declared in common.h but it seems that some
> >>          * architectures do not actually implement it. Is there a way to find
> >> diff --git a/include/video.h b/include/video.h
> >> index 1bfe6843a805..12fc525ab4ef 100644
> >> --- a/include/video.h
> >> +++ b/include/video.h
> >> @@ -114,8 +114,16 @@ struct video_priv {
> >>         u8 bg_col_idx;
> >>  };
> >>
> >> -/* Placeholder - there are no video operations at present */
> >> +/**
> >> + * struct video_ops - structure for keeping video operations
> >> + * @video_sync: Synchronize FB with device. Some device like SPI based LCD
> >> + *             displays needs synchronization when data in an FB is available.
> >> + *             For these devices implement video_sync hook to call a sync
> >> + *             function. vid is pointer to video device udevice. Function
> >> + *             should return 0 on success video_sync and error code otherwise
> >
> > Can this go before the video_sync, below?
>
> I was checking some files in Linux how they are dealing with it to pass
> kernel-doc and all of them used this format.
> Also if I look at include/dm/uclass.h  - struct uclass_driver
> it is done in the same way.
>
> Maybe we can ask Linux guys if there is a better way than this one.

Yes I see that a lot in linux and it is unfortunate.

+Heinrich Schuchardt probably knows

Regards,
Simon