All of lore.kernel.org
 help / color / mirror / Atom feed
* [MPTCP] [RFC PATCH 0/2] mptcp: fix deadlock in mptcp{,6}_release
@ 2021-03-02 17:47 Paolo Abeni
  0 siblings, 0 replies; only message in thread
From: Paolo Abeni @ 2021-03-02 17:47 UTC (permalink / raw)
  To: mptcp

[-- Attachment #1: Type: text/plain, Size: 926 bytes --]

This address the issue the easy way: removing the bugged feature
(mcast support :).

AFAICS the mcast related sockopt manipulate a global state, so there
could be existing working application doing setsockopt(mcast opt) on
TCP sockets. This is why I did not disable mcast at the inet level
for stream sockets.

Still I'm wondering if we should take the opposite approach: explicitly
forbitting all setsockopt except the one we implement in
net/mptcp/protocol.c

Additionally this possibly overlap with wider task - a more
comprehensive sockopt support. Ence the RFC tag.

Side note: syzbot confirm this fixes issues/170

Paolo Abeni (2):
  mptcp: forbit mcast-related sockopt on MPTCP sockets
  mptcp: revert "mptcp: provide subflow aware release function"$ ....$

 net/mptcp/protocol.c | 100 ++++++++++++++++++++-----------------------
 1 file changed, 47 insertions(+), 53 deletions(-)

-- 
2.26.2

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-03-02 17:47 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-02 17:47 [MPTCP] [RFC PATCH 0/2] mptcp: fix deadlock in mptcp{,6}_release Paolo Abeni

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.