* [PATCH 01/10] docs: xlexample.hvm: Mention this isn't useful for other guests
2022-04-20 2:10 [PATCH 00/10] Increase consistency of domain examples Elliott Mitchell
@ 2021-01-09 17:52 ` Elliott Mitchell
2021-01-09 17:54 ` [PATCH 02/10] docs: xlexample.*: Use consistent vCPU count Elliott Mitchell
` (8 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Elliott Mitchell @ 2021-01-09 17:52 UTC (permalink / raw)
To: xen-devel; +Cc: Wei Liu, Anthony PERARD
I dislike the implication this default is valuable for all guests, need
some mention of trade-off.
Signed-off-by: Elliott Mitchell <ehem+xen@m5p.com>
---
tools/examples/xlexample.hvm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/examples/xlexample.hvm b/tools/examples/xlexample.hvm
index df9fe07653..c2db4f237a 100644
--- a/tools/examples/xlexample.hvm
+++ b/tools/examples/xlexample.hvm
@@ -18,7 +18,7 @@ name = "example.hvm"
# Enable Microsoft Hyper-V compatibile paravirtualisation /
# enlightenment interfaces. Turning this on can improve Windows guest
-# performance and is therefore recommended
+# performance and is therefore recommended for Windows guests
#viridian = 1
# Initial memory allocation (MB)
--
2.30.2
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 02/10] docs: xlexample.*: Use consistent vCPU count
2022-04-20 2:10 [PATCH 00/10] Increase consistency of domain examples Elliott Mitchell
2021-01-09 17:52 ` [PATCH 01/10] docs: xlexample.hvm: Mention this isn't useful for other guests Elliott Mitchell
@ 2021-01-09 17:54 ` Elliott Mitchell
2021-01-09 17:58 ` [PATCH 03/10] docs: xlexample.*: Use consistent initial memory Elliott Mitchell
` (7 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Elliott Mitchell @ 2021-01-09 17:54 UTC (permalink / raw)
To: xen-devel; +Cc: Wei Liu, Anthony PERARD
Make all examples use the same number of vCPUs. Hopefully this avoids
confusing attempts at benchmarking during installation.
Signed-off-by: Elliott Mitchell <ehem+xen@m5p.com>
---
tools/examples/xlexample.hvm | 2 +-
tools/examples/xlexample.pvhlinux | 2 +-
tools/examples/xlexample.pvlinux | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/examples/xlexample.hvm b/tools/examples/xlexample.hvm
index c2db4f237a..ed821fea87 100644
--- a/tools/examples/xlexample.hvm
+++ b/tools/examples/xlexample.hvm
@@ -30,7 +30,7 @@ memory = 128
#maxmem = 512
# Number of VCPUS
-vcpus = 2
+vcpus = 3
# Network devices
# A list of 'vifspec' entries as described in
diff --git a/tools/examples/xlexample.pvhlinux b/tools/examples/xlexample.pvhlinux
index 18305b80af..49961e4687 100644
--- a/tools/examples/xlexample.pvhlinux
+++ b/tools/examples/xlexample.pvhlinux
@@ -29,7 +29,7 @@ extra = "root=/dev/xvda1"
memory = 512
# Number of VCPUS
-vcpus = 4
+vcpus = 3
# Network devices
# A list of 'vifspec' entries as described in
diff --git a/tools/examples/xlexample.pvlinux b/tools/examples/xlexample.pvlinux
index bb5996b29f..0c7a535f39 100644
--- a/tools/examples/xlexample.pvlinux
+++ b/tools/examples/xlexample.pvlinux
@@ -31,7 +31,7 @@ memory = 128
#maxmem = 512
# Number of VCPUS
-vcpus = 2
+vcpus = 3
# Network devices
# A list of 'vifspec' entries as described in
--
2.30.2
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 03/10] docs: xlexample.*: Use consistent initial memory
2022-04-20 2:10 [PATCH 00/10] Increase consistency of domain examples Elliott Mitchell
2021-01-09 17:52 ` [PATCH 01/10] docs: xlexample.hvm: Mention this isn't useful for other guests Elliott Mitchell
2021-01-09 17:54 ` [PATCH 02/10] docs: xlexample.*: Use consistent vCPU count Elliott Mitchell
@ 2021-01-09 17:58 ` Elliott Mitchell
2021-01-09 18:01 ` [PATCH 04/10] docs: xlexample.pvhlinux: Add commented maxmem setting Elliott Mitchell
` (6 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Elliott Mitchell @ 2021-01-09 17:58 UTC (permalink / raw)
To: xen-devel; +Cc: Wei Liu, Anthony PERARD
Avoid confusing benchmarking during initial installation by using
consistent amounts of memory for examples.
Signed-off-by: Elliott Mitchell <ehem+xen@m5p.com>
---
tools/examples/xlexample.hvm | 2 +-
tools/examples/xlexample.pvhlinux | 2 +-
tools/examples/xlexample.pvlinux | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/examples/xlexample.hvm b/tools/examples/xlexample.hvm
index ed821fea87..26ae1c2fb4 100644
--- a/tools/examples/xlexample.hvm
+++ b/tools/examples/xlexample.hvm
@@ -22,7 +22,7 @@ name = "example.hvm"
#viridian = 1
# Initial memory allocation (MB)
-memory = 128
+memory = 384
# Maximum memory (MB)
# If this is greater than `memory' then the slack will start ballooned
diff --git a/tools/examples/xlexample.pvhlinux b/tools/examples/xlexample.pvhlinux
index 49961e4687..1e9bcb9de5 100644
--- a/tools/examples/xlexample.pvhlinux
+++ b/tools/examples/xlexample.pvhlinux
@@ -26,7 +26,7 @@ kernel = "/boot/vmlinuz"
extra = "root=/dev/xvda1"
# Initial memory allocation (MB)
-memory = 512
+memory = 384
# Number of VCPUS
vcpus = 3
diff --git a/tools/examples/xlexample.pvlinux b/tools/examples/xlexample.pvlinux
index 0c7a535f39..be6931549a 100644
--- a/tools/examples/xlexample.pvlinux
+++ b/tools/examples/xlexample.pvlinux
@@ -23,7 +23,7 @@ kernel = "/boot/vmlinuz"
extra = "root=/dev/xvda1"
# Initial memory allocation (MB)
-memory = 128
+memory = 384
# Maximum memory (MB)
# If this is greater than `memory' then the slack will start ballooned
--
2.30.2
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 04/10] docs: xlexample.pvhlinux: Add commented maxmem setting
2022-04-20 2:10 [PATCH 00/10] Increase consistency of domain examples Elliott Mitchell
` (2 preceding siblings ...)
2021-01-09 17:58 ` [PATCH 03/10] docs: xlexample.*: Use consistent initial memory Elliott Mitchell
@ 2021-01-09 18:01 ` Elliott Mitchell
2021-01-09 20:08 ` [PATCH 06/10] docs: xlexample.hvm: Add reference to nographic option Elliott Mitchell
` (5 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Elliott Mitchell @ 2021-01-09 18:01 UTC (permalink / raw)
To: xen-devel; +Cc: Wei Liu, Anthony PERARD
Avoid confusion caused by differing example configuration files.
Signed-off-by: Elliott Mitchell <ehem+xen@m5p.com>
---
tools/examples/xlexample.pvhlinux | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/tools/examples/xlexample.pvhlinux b/tools/examples/xlexample.pvhlinux
index 1e9bcb9de5..e1bf845093 100644
--- a/tools/examples/xlexample.pvhlinux
+++ b/tools/examples/xlexample.pvhlinux
@@ -28,6 +28,11 @@ extra = "root=/dev/xvda1"
# Initial memory allocation (MB)
memory = 384
+# Maximum memory (MB)
+# If this is greater than `memory' then the slack will start ballooned
+# (this assumes guest kernel support for ballooning)
+#maxmem = 512
+
# Number of VCPUS
vcpus = 3
--
2.30.2
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 06/10] docs: xlexample.hvm: Add reference to nographic option
2022-04-20 2:10 [PATCH 00/10] Increase consistency of domain examples Elliott Mitchell
` (3 preceding siblings ...)
2021-01-09 18:01 ` [PATCH 04/10] docs: xlexample.pvhlinux: Add commented maxmem setting Elliott Mitchell
@ 2021-01-09 20:08 ` Elliott Mitchell
2021-01-09 20:11 ` [PATCH 07/10] docs: xlexample.pvhlinux: Make disk setting consistent with other examples Elliott Mitchell
` (4 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Elliott Mitchell @ 2021-01-09 20:08 UTC (permalink / raw)
To: xen-devel; +Cc: Wei Liu, Anthony PERARD
Running without any display device is a completely legal configuration.
Signed-off-by: Elliott Mitchell <ehem+xen@m5p.com>
---
tools/examples/xlexample.hvm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/examples/xlexample.hvm b/tools/examples/xlexample.hvm
index a6cafcbf9f..7afb7c731d 100644
--- a/tools/examples/xlexample.hvm
+++ b/tools/examples/xlexample.hvm
@@ -42,6 +42,7 @@ vif = [ '' ]
# docs/misc/xl-disk-configuration.txt
disk = [ '/dev/vg/guest-volume,raw,xvda,rw' ]
-# Guest VGA console configuration, either SDL or VNC
+# Guest VGA console configuration, SDL, VNC, or none
sdl = 1
#vnc = 1
+#nographic = 1
--
2.30.2
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 07/10] docs: xlexample.pvhlinux: Make disk setting consistent with other examples
2022-04-20 2:10 [PATCH 00/10] Increase consistency of domain examples Elliott Mitchell
` (4 preceding siblings ...)
2021-01-09 20:08 ` [PATCH 06/10] docs: xlexample.hvm: Add reference to nographic option Elliott Mitchell
@ 2021-01-09 20:11 ` Elliott Mitchell
2021-01-09 20:13 ` [PATCH 08/10] docs: xlexample.hvm: Fix grammmer Elliott Mitchell
` (3 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Elliott Mitchell @ 2021-01-09 20:11 UTC (permalink / raw)
To: xen-devel; +Cc: Wei Liu, Anthony PERARD
While storing images on ZFS is now quite common, such isn't required
at all. As such the example should be as generic as possible and
consistent with other examples.
Signed-off-by: Elliott Mitchell <ehem+xen@m5p.com>
---
tools/examples/xlexample.pvhlinux | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/examples/xlexample.pvhlinux b/tools/examples/xlexample.pvhlinux
index e1bf845093..a6a52c336c 100644
--- a/tools/examples/xlexample.pvhlinux
+++ b/tools/examples/xlexample.pvhlinux
@@ -44,4 +44,4 @@ vif = [ '' ]
# Disk Devices
# A list of `diskspec' entries as described in
# docs/misc/xl-disk-configuration.txt
-disk = [ '/dev/zvol/tank/guest-volume,raw,xvda,rw' ]
+disk = [ '/dev/vg/guest-volume,raw,xvda,rw' ]
--
2.30.2
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 08/10] docs: xlexample.hvm: Fix grammmer
2022-04-20 2:10 [PATCH 00/10] Increase consistency of domain examples Elliott Mitchell
` (5 preceding siblings ...)
2021-01-09 20:11 ` [PATCH 07/10] docs: xlexample.pvhlinux: Make disk setting consistent with other examples Elliott Mitchell
@ 2021-01-09 20:13 ` Elliott Mitchell
2021-01-09 20:16 ` [PATCH 09/10] docs: xlexample.pvlinux: Add "type" setting Elliott Mitchell
` (2 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Elliott Mitchell @ 2021-01-09 20:13 UTC (permalink / raw)
To: xen-devel; +Cc: Wei Liu, Anthony PERARD
This is correct and makes comparing the files with `diff` easier.
Signed-off-by: Elliott Mitchell <ehem+xen@m5p.com>
---
tools/examples/xlexample.hvm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/examples/xlexample.hvm b/tools/examples/xlexample.hvm
index 7afb7c731d..df82280531 100644
--- a/tools/examples/xlexample.hvm
+++ b/tools/examples/xlexample.hvm
@@ -2,10 +2,10 @@
# Example HVM guest configuration
# =====================================================================
#
-# This is a fairly minimal example of what is required for an
+# This is a fairly minimal example of what is required for a
# HVM guest. For a more complete guide see xl.cfg(5)
-# This configures an HVM rather than PV guest
+# This configures a HVM guest instead of PV or PVH
type = "hvm"
# Guest name
--
2.30.2
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 09/10] docs: xlexample.pvlinux: Add "type" setting
2022-04-20 2:10 [PATCH 00/10] Increase consistency of domain examples Elliott Mitchell
` (6 preceding siblings ...)
2021-01-09 20:13 ` [PATCH 08/10] docs: xlexample.hvm: Fix grammmer Elliott Mitchell
@ 2021-01-09 20:16 ` Elliott Mitchell
2021-01-09 20:20 ` [PATCH 10/10] docs: xlexample.pvhlinux: Use similar text to other examples Elliott Mitchell
2021-01-09 22:44 ` [PATCH 05/10] docs: xlexample.hvm: Fix maxmem value Elliott Mitchell
9 siblings, 0 replies; 11+ messages in thread
From: Elliott Mitchell @ 2021-01-09 20:16 UTC (permalink / raw)
To: xen-devel; +Cc: Wei Liu, Anthony PERARD
Some environments will prefer to explicitly include this setting
despite being the default. This also increases consistency with other
examples.
Signed-off-by: Elliott Mitchell <ehem+xen@m5p.com>
---
tools/examples/xlexample.pvlinux | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tools/examples/xlexample.pvlinux b/tools/examples/xlexample.pvlinux
index be6931549a..19dac50fcd 100644
--- a/tools/examples/xlexample.pvlinux
+++ b/tools/examples/xlexample.pvlinux
@@ -5,6 +5,9 @@
# This is a fairly minimal example of what is required for a
# Paravirtualised Linux guest. For a more complete guide see xl.cfg(5)
+# This configures a PV guest instead of HVM or PVH
+#type = "pv" # "pv" is default
+
# Guest name
name = "example.pvlinux"
--
2.30.2
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 10/10] docs: xlexample.pvhlinux: Use similar text to other examples
2022-04-20 2:10 [PATCH 00/10] Increase consistency of domain examples Elliott Mitchell
` (7 preceding siblings ...)
2021-01-09 20:16 ` [PATCH 09/10] docs: xlexample.pvlinux: Add "type" setting Elliott Mitchell
@ 2021-01-09 20:20 ` Elliott Mitchell
2021-01-09 22:44 ` [PATCH 05/10] docs: xlexample.hvm: Fix maxmem value Elliott Mitchell
9 siblings, 0 replies; 11+ messages in thread
From: Elliott Mitchell @ 2021-01-09 20:20 UTC (permalink / raw)
To: xen-devel; +Cc: Wei Liu, Anthony PERARD
Simply making the word choice match the other examples.
Signed-off-by: Elliott Mitchell <ehem+xen@m5p.com>
---
tools/examples/xlexample.pvhlinux | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/examples/xlexample.pvhlinux b/tools/examples/xlexample.pvhlinux
index a6a52c336c..7685fb67b6 100644
--- a/tools/examples/xlexample.pvhlinux
+++ b/tools/examples/xlexample.pvhlinux
@@ -5,7 +5,7 @@
# This is a fairly minimal example of what is required for a
# PVH Linux guest. For a more complete guide see xl.cfg(5)
-# This configures a PVH rather than PV guest
+# This configures a PVH guest instead of HVM or PV
type = "pvh"
# Guest name
--
2.30.2
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 05/10] docs: xlexample.hvm: Fix maxmem value
2022-04-20 2:10 [PATCH 00/10] Increase consistency of domain examples Elliott Mitchell
` (8 preceding siblings ...)
2021-01-09 20:20 ` [PATCH 10/10] docs: xlexample.pvhlinux: Use similar text to other examples Elliott Mitchell
@ 2021-01-09 22:44 ` Elliott Mitchell
9 siblings, 0 replies; 11+ messages in thread
From: Elliott Mitchell @ 2021-01-09 22:44 UTC (permalink / raw)
To: xen-devel; +Cc: Wei Liu, Anthony PERARD
HVM doesn't balloon and so it makes no sense to specify maxmem.
Signed-off-by: Elliott Mitchell <ehem+xen@m5p.com>
---
tools/examples/xlexample.hvm | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/examples/xlexample.hvm b/tools/examples/xlexample.hvm
index 26ae1c2fb4..a6cafcbf9f 100644
--- a/tools/examples/xlexample.hvm
+++ b/tools/examples/xlexample.hvm
@@ -25,9 +25,9 @@ name = "example.hvm"
memory = 384
# Maximum memory (MB)
-# If this is greater than `memory' then the slack will start ballooned
-# (this assumes guest kernel support for ballooning)
-#maxmem = 512
+# Unlike PV or PVH, HVM cannot balloon memory and hence this should match
+# `memory' or simply be left unset.
+#maxmem =
# Number of VCPUS
vcpus = 3
--
2.30.2
^ permalink raw reply related [flat|nested] 11+ messages in thread