* [Intel-gfx] [PATCH 00/16] drm/i915: stop modifying "const" device info
@ 2022-06-20 8:37 ` Jani Nikula
0 siblings, 0 replies; 29+ messages in thread
From: Jani Nikula @ 2022-06-20 8:37 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
Move any device info that gets modified runtime into runtime info,
making device info a const pointer. Finally throw mkwrite_device_info()
into the curb.
The data size increases by sizeof(struct intel_runtime_info) for each
struct intel_device_info in i915_pci.c.
bloat-o-meter gives chg +0.08% in text size, almost all of which is
caused by the last commit (drm/i915: make device info a pointer to
static const data). IMO the first 14-15 commits separating
static/runtime info are worth it even if we decide the text size penalty
is too much to switch to using a pointer for static device info.
BR,
Jani.
Jani Nikula (16):
drm/i915: use GRAPHICS_VER() instead of accessing match_info directly
drm/i915: combine device info printing into one
drm/i915: add initial runtime info into device info
drm/i915: move fbc_mask to runtime info
drm/i915: move page_sizes to runtime info
drm/i915: move ppgtt_type and ppgtt_size to runtime info
drm/i915: move has_pooled_eu to runtime info
drm/i915: move memory_regions to runtime info
drm/i915: move platform_engine_mask to runtime info
drm/i915: move graphics.ver and graphics.rel to runtime info
drm/i915: move pipe_mask and cpu_transcoder_mask to runtime info
drm/i915: move has_hdcp to runtime info
drm/i915: move has_dmc to runtime info
drm/i915: move has_dsc to runtime info
drm/i915: stop resetting display info to zero for no display
drm/i915: make device info a pointer to static const data
drivers/gpu/drm/i915/display/intel_display.h | 4 +-
drivers/gpu/drm/i915/display/intel_fbc.c | 6 +-
drivers/gpu/drm/i915/display/intel_hdcp.c | 4 +-
drivers/gpu/drm/i915/display/intel_vdsc.c | 2 +-
.../drm/i915/display/skl_universal_plane.c | 2 +-
drivers/gpu/drm/i915/gem/i915_gem_pages.c | 2 +-
.../gpu/drm/i915/gem/selftests/huge_pages.c | 18 +-
drivers/gpu/drm/i915/gt/intel_engine_cs.c | 2 +-
drivers/gpu/drm/i915/gt/intel_ppgtt.c | 2 +-
drivers/gpu/drm/i915/gt/intel_sseu.c | 5 +-
drivers/gpu/drm/i915/i915_debugfs.c | 3 +-
drivers/gpu/drm/i915/i915_driver.c | 23 +-
drivers/gpu/drm/i915/i915_drv.h | 35 ++-
drivers/gpu/drm/i915/i915_gem.c | 3 +-
drivers/gpu/drm/i915/i915_gpu_error.c | 3 +-
drivers/gpu/drm/i915/i915_pci.c | 230 +++++++++---------
drivers/gpu/drm/i915/intel_device_info.c | 73 +++---
drivers/gpu/drm/i915/intel_device_info.h | 82 ++++---
drivers/gpu/drm/i915/intel_uncore.c | 2 +-
.../gpu/drm/i915/selftests/mock_gem_device.c | 8 +-
20 files changed, 255 insertions(+), 254 deletions(-)
--
2.30.2
^ permalink raw reply [flat|nested] 29+ messages in thread
* [Intel-gfx] [PATCH 01/16] drm/i915: use GRAPHICS_VER() instead of accessing match_info directly
@ 2022-06-20 8:38 ` Jani Nikula
0 siblings, 0 replies; 29+ messages in thread
From: Jani Nikula @ 2022-06-20 8:37 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
We've just set up device info in i915_driver_create() so we can use
GRAPHICS_VER() intead of looking at match_info directly.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/i915_driver.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_driver.c b/drivers/gpu/drm/i915/i915_driver.c
index d26dcca7e654..aeec3dfe3ebf 100644
--- a/drivers/gpu/drm/i915/i915_driver.c
+++ b/drivers/gpu/drm/i915/i915_driver.c
@@ -829,8 +829,6 @@ i915_driver_create(struct pci_dev *pdev, const struct pci_device_id *ent)
*/
int i915_driver_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
{
- const struct intel_device_info *match_info =
- (struct intel_device_info *)ent->driver_data;
struct drm_i915_private *i915;
int ret;
@@ -839,7 +837,7 @@ int i915_driver_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
return PTR_ERR(i915);
/* Disable nuclear pageflip by default on pre-ILK */
- if (!i915->params.nuclear_pageflip && match_info->graphics.ver < 5)
+ if (!i915->params.nuclear_pageflip && GRAPHICS_VER(i915) < 5)
i915->drm.driver_features &= ~DRIVER_ATOMIC;
ret = pci_enable_device(pdev);
--
2.30.2
^ permalink raw reply related [flat|nested] 29+ messages in thread
* [Intel-gfx] [PATCH 00/16] drm/i915: stop modifying "const" device info
@ 2022-06-20 8:37 ` Jani Nikula
0 siblings, 0 replies; 29+ messages in thread
From: Jani Nikula @ 2022-06-20 8:37 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
Move any device info that gets modified runtime into runtime info,
making device info a const pointer. Finally throw mkwrite_device_info()
into the curb.
The data size increases by sizeof(struct intel_runtime_info) for each
struct intel_device_info in i915_pci.c.
bloat-o-meter gives chg +0.08% in text size, almost all of which is
caused by the last commit (drm/i915: make device info a pointer to
static const data). IMO the first 14-15 commits separating
static/runtime info are worth it even if we decide the text size penalty
is too much to switch to using a pointer for static device info.
BR,
Jani.
Jani Nikula (16):
drm/i915: use GRAPHICS_VER() instead of accessing match_info directly
drm/i915: combine device info printing into one
drm/i915: add initial runtime info into device info
drm/i915: move fbc_mask to runtime info
drm/i915: move page_sizes to runtime info
drm/i915: move ppgtt_type and ppgtt_size to runtime info
drm/i915: move has_pooled_eu to runtime info
drm/i915: move memory_regions to runtime info
drm/i915: move platform_engine_mask to runtime info
drm/i915: move graphics.ver and graphics.rel to runtime info
drm/i915: move pipe_mask and cpu_transcoder_mask to runtime info
drm/i915: move has_hdcp to runtime info
drm/i915: move has_dmc to runtime info
drm/i915: move has_dsc to runtime info
drm/i915: stop resetting display info to zero for no display
drm/i915: make device info a pointer to static const data
drivers/gpu/drm/i915/display/intel_display.h | 4 +-
drivers/gpu/drm/i915/display/intel_fbc.c | 6 +-
drivers/gpu/drm/i915/display/intel_hdcp.c | 4 +-
drivers/gpu/drm/i915/display/intel_vdsc.c | 2 +-
.../drm/i915/display/skl_universal_plane.c | 2 +-
drivers/gpu/drm/i915/gem/i915_gem_pages.c | 2 +-
.../gpu/drm/i915/gem/selftests/huge_pages.c | 18 +-
drivers/gpu/drm/i915/gt/intel_engine_cs.c | 2 +-
drivers/gpu/drm/i915/gt/intel_ppgtt.c | 2 +-
drivers/gpu/drm/i915/gt/intel_sseu.c | 5 +-
drivers/gpu/drm/i915/i915_debugfs.c | 3 +-
drivers/gpu/drm/i915/i915_driver.c | 23 +-
drivers/gpu/drm/i915/i915_drv.h | 35 ++-
drivers/gpu/drm/i915/i915_gem.c | 3 +-
drivers/gpu/drm/i915/i915_gpu_error.c | 3 +-
drivers/gpu/drm/i915/i915_pci.c | 230 +++++++++---------
drivers/gpu/drm/i915/intel_device_info.c | 73 +++---
drivers/gpu/drm/i915/intel_device_info.h | 82 ++++---
drivers/gpu/drm/i915/intel_uncore.c | 2 +-
.../gpu/drm/i915/selftests/mock_gem_device.c | 8 +-
20 files changed, 255 insertions(+), 254 deletions(-)
--
2.30.2
^ permalink raw reply [flat|nested] 29+ messages in thread
* [Intel-gfx] [PATCH 01/16] drm/i915: use GRAPHICS_VER() instead of accessing match_info directly
@ 2022-06-20 8:38 ` Jani Nikula
0 siblings, 0 replies; 29+ messages in thread
From: Jani Nikula @ 2022-06-20 8:38 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
We've just set up device info in i915_driver_create() so we can use
GRAPHICS_VER() intead of looking at match_info directly.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/i915_driver.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_driver.c b/drivers/gpu/drm/i915/i915_driver.c
index d26dcca7e654..aeec3dfe3ebf 100644
--- a/drivers/gpu/drm/i915/i915_driver.c
+++ b/drivers/gpu/drm/i915/i915_driver.c
@@ -829,8 +829,6 @@ i915_driver_create(struct pci_dev *pdev, const struct pci_device_id *ent)
*/
int i915_driver_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
{
- const struct intel_device_info *match_info =
- (struct intel_device_info *)ent->driver_data;
struct drm_i915_private *i915;
int ret;
@@ -839,7 +837,7 @@ int i915_driver_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
return PTR_ERR(i915);
/* Disable nuclear pageflip by default on pre-ILK */
- if (!i915->params.nuclear_pageflip && match_info->graphics.ver < 5)
+ if (!i915->params.nuclear_pageflip && GRAPHICS_VER(i915) < 5)
i915->drm.driver_features &= ~DRIVER_ATOMIC;
ret = pci_enable_device(pdev);
--
2.30.2
^ permalink raw reply related [flat|nested] 29+ messages in thread
* [Intel-gfx] [PATCH 02/16] drm/i915: combine device info printing into one
2022-06-20 8:37 ` Jani Nikula
(?)
(?)
@ 2022-06-20 8:38 ` Jani Nikula
-1 siblings, 0 replies; 29+ messages in thread
From: Jani Nikula @ 2022-06-20 8:38 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
We'll be moving info between static and runtime info. Combine the
printing functions into one to keep the output sensible and (mostly)
unchanged in the process.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/i915_debugfs.c | 3 +--
drivers/gpu/drm/i915/i915_driver.c | 4 ++--
drivers/gpu/drm/i915/i915_gpu_error.c | 3 +--
drivers/gpu/drm/i915/intel_device_info.c | 11 ++++-------
drivers/gpu/drm/i915/intel_device_info.h | 7 +++----
5 files changed, 11 insertions(+), 17 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
index 94e5c29d2ee3..d131703de3d9 100644
--- a/drivers/gpu/drm/i915/i915_debugfs.c
+++ b/drivers/gpu/drm/i915/i915_debugfs.c
@@ -66,8 +66,7 @@ static int i915_capabilities(struct seq_file *m, void *data)
seq_printf(m, "pch: %d\n", INTEL_PCH_TYPE(i915));
- intel_device_info_print_static(INTEL_INFO(i915), &p);
- intel_device_info_print_runtime(RUNTIME_INFO(i915), &p);
+ intel_device_info_print(INTEL_INFO(i915), RUNTIME_INFO(i915), &p);
i915_print_iommu_status(i915, &p);
intel_gt_info_print(&to_gt(i915)->info, &p);
intel_driver_caps_print(&i915->caps, &p);
diff --git a/drivers/gpu/drm/i915/i915_driver.c b/drivers/gpu/drm/i915/i915_driver.c
index aeec3dfe3ebf..0b00a05f1a74 100644
--- a/drivers/gpu/drm/i915/i915_driver.c
+++ b/drivers/gpu/drm/i915/i915_driver.c
@@ -775,8 +775,8 @@ static void i915_welcome_messages(struct drm_i915_private *dev_priv)
INTEL_INFO(dev_priv)->platform),
GRAPHICS_VER(dev_priv));
- intel_device_info_print_static(INTEL_INFO(dev_priv), &p);
- intel_device_info_print_runtime(RUNTIME_INFO(dev_priv), &p);
+ intel_device_info_print(INTEL_INFO(dev_priv),
+ RUNTIME_INFO(dev_priv), &p);
i915_print_iommu_status(dev_priv, &p);
intel_gt_info_print(&to_gt(dev_priv)->info, &p);
}
diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c
index bff8a111424a..98e77fb02423 100644
--- a/drivers/gpu/drm/i915/i915_gpu_error.c
+++ b/drivers/gpu/drm/i915/i915_gpu_error.c
@@ -658,8 +658,7 @@ static void err_print_capabilities(struct drm_i915_error_state_buf *m,
{
struct drm_printer p = i915_error_printer(m);
- intel_device_info_print_static(&error->device_info, &p);
- intel_device_info_print_runtime(&error->runtime_info, &p);
+ intel_device_info_print(&error->device_info, &error->runtime_info, &p);
intel_driver_caps_print(&error->driver_caps, &p);
}
diff --git a/drivers/gpu/drm/i915/intel_device_info.c b/drivers/gpu/drm/i915/intel_device_info.c
index f0bf23726ed8..77f435dd5626 100644
--- a/drivers/gpu/drm/i915/intel_device_info.c
+++ b/drivers/gpu/drm/i915/intel_device_info.c
@@ -87,8 +87,9 @@ const char *intel_platform_name(enum intel_platform platform)
return platform_names[platform];
}
-void intel_device_info_print_static(const struct intel_device_info *info,
- struct drm_printer *p)
+void intel_device_info_print(const struct intel_device_info *info,
+ const struct intel_runtime_info *runtime,
+ struct drm_printer *p)
{
if (info->graphics.rel)
drm_printf(p, "graphics version: %u.%02u\n", info->graphics.ver,
@@ -121,12 +122,8 @@ void intel_device_info_print_static(const struct intel_device_info *info,
#define PRINT_FLAG(name) drm_printf(p, "%s: %s\n", #name, str_yes_no(info->display.name))
DEV_INFO_DISPLAY_FOR_EACH_FLAG(PRINT_FLAG);
#undef PRINT_FLAG
-}
-void intel_device_info_print_runtime(const struct intel_runtime_info *info,
- struct drm_printer *p)
-{
- drm_printf(p, "rawclk rate: %u kHz\n", info->rawclk_freq);
+ drm_printf(p, "rawclk rate: %u kHz\n", runtime->rawclk_freq);
}
#undef INTEL_VGA_DEVICE
diff --git a/drivers/gpu/drm/i915/intel_device_info.h b/drivers/gpu/drm/i915/intel_device_info.h
index 08341174ee0a..b86f68866e35 100644
--- a/drivers/gpu/drm/i915/intel_device_info.h
+++ b/drivers/gpu/drm/i915/intel_device_info.h
@@ -285,10 +285,9 @@ const char *intel_platform_name(enum intel_platform platform);
void intel_device_info_subplatform_init(struct drm_i915_private *dev_priv);
void intel_device_info_runtime_init(struct drm_i915_private *dev_priv);
-void intel_device_info_print_static(const struct intel_device_info *info,
- struct drm_printer *p);
-void intel_device_info_print_runtime(const struct intel_runtime_info *info,
- struct drm_printer *p);
+void intel_device_info_print(const struct intel_device_info *info,
+ const struct intel_runtime_info *runtime,
+ struct drm_printer *p);
void intel_driver_caps_print(const struct intel_driver_caps *caps,
struct drm_printer *p);
--
2.30.2
^ permalink raw reply related [flat|nested] 29+ messages in thread
* [Intel-gfx] [PATCH 03/16] drm/i915: add initial runtime info into device info
2022-06-20 8:37 ` Jani Nikula
` (2 preceding siblings ...)
(?)
@ 2022-06-20 8:38 ` Jani Nikula
2022-06-23 20:05 ` Ville Syrjälä
-1 siblings, 1 reply; 29+ messages in thread
From: Jani Nikula @ 2022-06-20 8:38 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
Add initial runtime info that we can copy to runtime info at i915
creation time. This lets us define the initial values for runtime info
statically while making it possible to change them runtime. This will be
the new home for the current "const" device info members that are
modified runtime anyway.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/i915_driver.c | 7 +++-
drivers/gpu/drm/i915/intel_device_info.h | 41 +++++++++++++-----------
2 files changed, 29 insertions(+), 19 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_driver.c b/drivers/gpu/drm/i915/i915_driver.c
index 0b00a05f1a74..5969cc7805d3 100644
--- a/drivers/gpu/drm/i915/i915_driver.c
+++ b/drivers/gpu/drm/i915/i915_driver.c
@@ -796,6 +796,7 @@ i915_driver_create(struct pci_dev *pdev, const struct pci_device_id *ent)
const struct intel_device_info *match_info =
(struct intel_device_info *)ent->driver_data;
struct intel_device_info *device_info;
+ struct intel_runtime_info *runtime;
struct drm_i915_private *i915;
i915 = devm_drm_dev_alloc(&pdev->dev, &i915_drm_driver,
@@ -811,7 +812,11 @@ i915_driver_create(struct pci_dev *pdev, const struct pci_device_id *ent)
/* Setup the write-once "constant" device info */
device_info = mkwrite_device_info(i915);
memcpy(device_info, match_info, sizeof(*device_info));
- RUNTIME_INFO(i915)->device_id = pdev->device;
+
+ /* Initialize initial runtime info from static const data and pdev. */
+ runtime = RUNTIME_INFO(i915);
+ memcpy(runtime, &INTEL_INFO(i915)->__runtime, sizeof(*runtime));
+ runtime->device_id = pdev->device;
return i915;
}
diff --git a/drivers/gpu/drm/i915/intel_device_info.h b/drivers/gpu/drm/i915/intel_device_info.h
index b86f68866e35..85385c98b9f4 100644
--- a/drivers/gpu/drm/i915/intel_device_info.h
+++ b/drivers/gpu/drm/i915/intel_device_info.h
@@ -197,6 +197,27 @@ struct ip_version {
u8 rel;
};
+struct intel_runtime_info {
+ /*
+ * Platform mask is used for optimizing or-ed IS_PLATFORM calls into
+ * into single runtime conditionals, and also to provide groundwork
+ * for future per platform, or per SKU build optimizations.
+ *
+ * Array can be extended when necessary if the corresponding
+ * BUILD_BUG_ON is hit.
+ */
+ u32 platform_mask[2];
+
+ u16 device_id;
+
+ u8 num_sprites[I915_MAX_PIPES];
+ u8 num_scalers[I915_MAX_PIPES];
+
+ u32 rawclk_freq;
+
+ struct intel_step_info step;
+};
+
struct intel_device_info {
struct ip_version graphics;
struct ip_version media;
@@ -252,27 +273,11 @@ struct intel_device_info {
u32 degamma_lut_tests;
u32 gamma_lut_tests;
} color;
-};
-struct intel_runtime_info {
/*
- * Platform mask is used for optimizing or-ed IS_PLATFORM calls into
- * into single runtime conditionals, and also to provide groundwork
- * for future per platform, or per SKU build optimizations.
- *
- * Array can be extended when necessary if the corresponding
- * BUILD_BUG_ON is hit.
+ * Initial runtime info. Do not access outside of i915_driver_create().
*/
- u32 platform_mask[2];
-
- u16 device_id;
-
- u8 num_sprites[I915_MAX_PIPES];
- u8 num_scalers[I915_MAX_PIPES];
-
- u32 rawclk_freq;
-
- struct intel_step_info step;
+ const struct intel_runtime_info __runtime;
};
struct intel_driver_caps {
--
2.30.2
^ permalink raw reply related [flat|nested] 29+ messages in thread
* [Intel-gfx] [PATCH 04/16] drm/i915: move fbc_mask to runtime info
2022-06-20 8:37 ` Jani Nikula
` (3 preceding siblings ...)
(?)
@ 2022-06-20 8:38 ` Jani Nikula
-1 siblings, 0 replies; 29+ messages in thread
From: Jani Nikula @ 2022-06-20 8:38 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
If it's modified runtime, it's runtime info.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/display/intel_fbc.c | 6 ++---
.../drm/i915/display/skl_universal_plane.c | 2 +-
drivers/gpu/drm/i915/i915_drv.h | 2 +-
drivers/gpu/drm/i915/i915_pci.c | 22 +++++++++----------
drivers/gpu/drm/i915/intel_device_info.c | 6 ++---
drivers/gpu/drm/i915/intel_device_info.h | 12 ++++++----
6 files changed, 27 insertions(+), 23 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c b/drivers/gpu/drm/i915/display/intel_fbc.c
index 8b807284cde1..deb0bfabd25d 100644
--- a/drivers/gpu/drm/i915/display/intel_fbc.c
+++ b/drivers/gpu/drm/i915/display/intel_fbc.c
@@ -54,7 +54,7 @@
#define for_each_fbc_id(__dev_priv, __fbc_id) \
for ((__fbc_id) = INTEL_FBC_A; (__fbc_id) < I915_MAX_FBCS; (__fbc_id)++) \
- for_each_if(INTEL_INFO(__dev_priv)->display.fbc_mask & BIT(__fbc_id))
+ for_each_if(RUNTIME_INFO(__dev_priv)->fbc_mask & BIT(__fbc_id))
#define for_each_intel_fbc(__dev_priv, __fbc, __fbc_id) \
for_each_fbc_id((__dev_priv), (__fbc_id)) \
@@ -1703,10 +1703,10 @@ void intel_fbc_init(struct drm_i915_private *i915)
enum intel_fbc_id fbc_id;
if (!drm_mm_initialized(&i915->mm.stolen))
- mkwrite_device_info(i915)->display.fbc_mask = 0;
+ RUNTIME_INFO(i915)->fbc_mask = 0;
if (need_fbc_vtd_wa(i915))
- mkwrite_device_info(i915)->display.fbc_mask = 0;
+ RUNTIME_INFO(i915)->fbc_mask = 0;
i915->params.enable_fbc = intel_sanitize_fbc_option(i915);
drm_dbg_kms(&i915->drm, "Sanitized enable_fbc value: %d\n",
diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane.c b/drivers/gpu/drm/i915/display/skl_universal_plane.c
index caa03324a733..0492596d1837 100644
--- a/drivers/gpu/drm/i915/display/skl_universal_plane.c
+++ b/drivers/gpu/drm/i915/display/skl_universal_plane.c
@@ -1928,7 +1928,7 @@ static enum intel_fbc_id skl_fbc_id_for_pipe(enum pipe pipe)
static bool skl_plane_has_fbc(struct drm_i915_private *dev_priv,
enum intel_fbc_id fbc_id, enum plane_id plane_id)
{
- if ((INTEL_INFO(dev_priv)->display.fbc_mask & BIT(fbc_id)) == 0)
+ if ((RUNTIME_INFO(dev_priv)->fbc_mask & BIT(fbc_id)) == 0)
return false;
return plane_id == PLANE_PRIMARY;
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index c22f29c3faa0..f4aa31499fd4 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -1244,7 +1244,7 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915,
#define I915_HAS_HOTPLUG(dev_priv) (INTEL_INFO(dev_priv)->display.has_hotplug)
#define HAS_FW_BLC(dev_priv) (DISPLAY_VER(dev_priv) > 2)
-#define HAS_FBC(dev_priv) (INTEL_INFO(dev_priv)->display.fbc_mask != 0)
+#define HAS_FBC(dev_priv) (RUNTIME_INFO(dev_priv)->fbc_mask != 0)
#define HAS_CUR_FBC(dev_priv) (!HAS_GMCH(dev_priv) && DISPLAY_VER(dev_priv) >= 7)
#define HAS_IPS(dev_priv) (IS_HSW_ULT(dev_priv) || IS_BROADWELL(dev_priv))
diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
index 5e51fc29bb8b..fb063284befa 100644
--- a/drivers/gpu/drm/i915/i915_pci.c
+++ b/drivers/gpu/drm/i915/i915_pci.c
@@ -218,13 +218,13 @@ static const struct intel_device_info i845g_info = {
static const struct intel_device_info i85x_info = {
I830_FEATURES,
PLATFORM(INTEL_I85X),
- .display.fbc_mask = BIT(INTEL_FBC_A),
+ .__runtime.fbc_mask = BIT(INTEL_FBC_A),
};
static const struct intel_device_info i865g_info = {
I845_FEATURES,
PLATFORM(INTEL_I865G),
- .display.fbc_mask = BIT(INTEL_FBC_A),
+ .__runtime.fbc_mask = BIT(INTEL_FBC_A),
};
#define GEN3_FEATURES \
@@ -263,7 +263,7 @@ static const struct intel_device_info i915gm_info = {
.display.has_overlay = 1,
.display.overlay_needs_physical = 1,
.display.supports_tv = 1,
- .display.fbc_mask = BIT(INTEL_FBC_A),
+ .__runtime.fbc_mask = BIT(INTEL_FBC_A),
.hws_needs_physical = 1,
.unfenced_needs_alignment = 1,
};
@@ -288,7 +288,7 @@ static const struct intel_device_info i945gm_info = {
.display.has_overlay = 1,
.display.overlay_needs_physical = 1,
.display.supports_tv = 1,
- .display.fbc_mask = BIT(INTEL_FBC_A),
+ .__runtime.fbc_mask = BIT(INTEL_FBC_A),
.hws_needs_physical = 1,
.unfenced_needs_alignment = 1,
};
@@ -348,7 +348,7 @@ static const struct intel_device_info i965gm_info = {
GEN4_FEATURES,
PLATFORM(INTEL_I965GM),
.is_mobile = 1,
- .display.fbc_mask = BIT(INTEL_FBC_A),
+ .__runtime.fbc_mask = BIT(INTEL_FBC_A),
.display.has_overlay = 1,
.display.supports_tv = 1,
.hws_needs_physical = 1,
@@ -366,7 +366,7 @@ static const struct intel_device_info gm45_info = {
GEN4_FEATURES,
PLATFORM(INTEL_GM45),
.is_mobile = 1,
- .display.fbc_mask = BIT(INTEL_FBC_A),
+ .__runtime.fbc_mask = BIT(INTEL_FBC_A),
.display.supports_tv = 1,
.platform_engine_mask = BIT(RCS0) | BIT(VCS0),
.gpu_reset_clobbers_display = false,
@@ -400,7 +400,7 @@ static const struct intel_device_info ilk_m_info = {
PLATFORM(INTEL_IRONLAKE),
.is_mobile = 1,
.has_rps = true,
- .display.fbc_mask = BIT(INTEL_FBC_A),
+ .__runtime.fbc_mask = BIT(INTEL_FBC_A),
};
#define GEN6_FEATURES \
@@ -408,7 +408,7 @@ static const struct intel_device_info ilk_m_info = {
.display.pipe_mask = BIT(PIPE_A) | BIT(PIPE_B), \
.display.cpu_transcoder_mask = BIT(TRANSCODER_A) | BIT(TRANSCODER_B), \
.display.has_hotplug = 1, \
- .display.fbc_mask = BIT(INTEL_FBC_A), \
+ .__runtime.fbc_mask = BIT(INTEL_FBC_A), \
.platform_engine_mask = BIT(RCS0) | BIT(VCS0) | BIT(BCS0), \
.has_3d_pipeline = 1, \
.has_coherent_ggtt = true, \
@@ -460,7 +460,7 @@ static const struct intel_device_info snb_m_gt2_info = {
.display.pipe_mask = BIT(PIPE_A) | BIT(PIPE_B) | BIT(PIPE_C), \
.display.cpu_transcoder_mask = BIT(TRANSCODER_A) | BIT(TRANSCODER_B) | BIT(TRANSCODER_C), \
.display.has_hotplug = 1, \
- .display.fbc_mask = BIT(INTEL_FBC_A), \
+ .__runtime.fbc_mask = BIT(INTEL_FBC_A), \
.platform_engine_mask = BIT(RCS0) | BIT(VCS0) | BIT(BCS0), \
.has_3d_pipeline = 1, \
.has_coherent_ggtt = true, \
@@ -703,7 +703,7 @@ static const struct intel_device_info skl_gt4_info = {
.has_64bit_reloc = 1, \
.display.has_ddi = 1, \
.display.has_fpga_dbg = 1, \
- .display.fbc_mask = BIT(INTEL_FBC_A), \
+ .__runtime.fbc_mask = BIT(INTEL_FBC_A), \
.display.has_hdcp = 1, \
.display.has_psr = 1, \
.display.has_psr_hw_tracking = 1, \
@@ -959,7 +959,7 @@ static const struct intel_device_info adl_s_info = {
.display.has_dp_mst = 1, \
.display.has_dsb = 1, \
.display.has_dsc = 1, \
- .display.fbc_mask = BIT(INTEL_FBC_A), \
+ .__runtime.fbc_mask = BIT(INTEL_FBC_A), \
.display.has_fpga_dbg = 1, \
.display.has_hdcp = 1, \
.display.has_hotplug = 1, \
diff --git a/drivers/gpu/drm/i915/intel_device_info.c b/drivers/gpu/drm/i915/intel_device_info.c
index 77f435dd5626..82a82fd83673 100644
--- a/drivers/gpu/drm/i915/intel_device_info.c
+++ b/drivers/gpu/drm/i915/intel_device_info.c
@@ -348,7 +348,7 @@ void intel_device_info_runtime_init(struct drm_i915_private *dev_priv)
"Display fused off, disabling\n");
info->display.pipe_mask = 0;
info->display.cpu_transcoder_mask = 0;
- info->display.fbc_mask = 0;
+ runtime->fbc_mask = 0;
} else if (fuse_strap & IVB_PIPE_C_DISABLE) {
drm_info(&dev_priv->drm, "PipeC fused off\n");
info->display.pipe_mask &= ~BIT(PIPE_C);
@@ -360,7 +360,7 @@ void intel_device_info_runtime_init(struct drm_i915_private *dev_priv)
if (dfsm & SKL_DFSM_PIPE_A_DISABLE) {
info->display.pipe_mask &= ~BIT(PIPE_A);
info->display.cpu_transcoder_mask &= ~BIT(TRANSCODER_A);
- info->display.fbc_mask &= ~BIT(INTEL_FBC_A);
+ runtime->fbc_mask &= ~BIT(INTEL_FBC_A);
}
if (dfsm & SKL_DFSM_PIPE_B_DISABLE) {
info->display.pipe_mask &= ~BIT(PIPE_B);
@@ -381,7 +381,7 @@ void intel_device_info_runtime_init(struct drm_i915_private *dev_priv)
info->display.has_hdcp = 0;
if (dfsm & SKL_DFSM_DISPLAY_PM_DISABLE)
- info->display.fbc_mask = 0;
+ runtime->fbc_mask = 0;
if (DISPLAY_VER(dev_priv) >= 11 && (dfsm & ICL_DFSM_DMC_DISABLE))
info->display.has_dmc = 0;
diff --git a/drivers/gpu/drm/i915/intel_device_info.h b/drivers/gpu/drm/i915/intel_device_info.h
index 85385c98b9f4..86d796eb93ad 100644
--- a/drivers/gpu/drm/i915/intel_device_info.h
+++ b/drivers/gpu/drm/i915/intel_device_info.h
@@ -210,12 +210,17 @@ struct intel_runtime_info {
u16 device_id;
- u8 num_sprites[I915_MAX_PIPES];
- u8 num_scalers[I915_MAX_PIPES];
-
u32 rawclk_freq;
struct intel_step_info step;
+
+ /* display */
+ struct {
+ u8 num_sprites[I915_MAX_PIPES];
+ u8 num_scalers[I915_MAX_PIPES];
+
+ u8 fbc_mask;
+ };
};
struct intel_device_info {
@@ -249,7 +254,6 @@ struct intel_device_info {
u8 pipe_mask;
u8 cpu_transcoder_mask;
- u8 fbc_mask;
u8 abox_mask;
#define DEFINE_FLAG(name) u8 name:1
--
2.30.2
^ permalink raw reply related [flat|nested] 29+ messages in thread
* [Intel-gfx] [PATCH 05/16] drm/i915: move page_sizes to runtime info
2022-06-20 8:37 ` Jani Nikula
` (4 preceding siblings ...)
(?)
@ 2022-06-20 8:38 ` Jani Nikula
-1 siblings, 0 replies; 29+ messages in thread
From: Jani Nikula @ 2022-06-20 8:38 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
If it's modified runtime, it's runtime info.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/gem/i915_gem_pages.c | 2 +-
.../gpu/drm/i915/gem/selftests/huge_pages.c | 14 +++++++-------
drivers/gpu/drm/i915/i915_drv.h | 2 +-
drivers/gpu/drm/i915/i915_gem.c | 3 +--
drivers/gpu/drm/i915/i915_pci.c | 18 +++++++++---------
drivers/gpu/drm/i915/intel_device_info.c | 2 +-
drivers/gpu/drm/i915/intel_device_info.h | 4 ++--
.../gpu/drm/i915/selftests/mock_gem_device.c | 2 +-
8 files changed, 23 insertions(+), 24 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_pages.c b/drivers/gpu/drm/i915/gem/i915_gem_pages.c
index 97c820eee115..0325ffa54e37 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_pages.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_pages.c
@@ -19,7 +19,7 @@ void __i915_gem_object_set_pages(struct drm_i915_gem_object *obj,
unsigned int sg_page_sizes)
{
struct drm_i915_private *i915 = to_i915(obj->base.dev);
- unsigned long supported = INTEL_INFO(i915)->page_sizes;
+ unsigned long supported = RUNTIME_INFO(i915)->page_sizes;
bool shrinkable;
int i;
diff --git a/drivers/gpu/drm/i915/gem/selftests/huge_pages.c b/drivers/gpu/drm/i915/gem/selftests/huge_pages.c
index ef15967be51a..488a10c20b85 100644
--- a/drivers/gpu/drm/i915/gem/selftests/huge_pages.c
+++ b/drivers/gpu/drm/i915/gem/selftests/huge_pages.c
@@ -358,7 +358,7 @@ fake_huge_pages_object(struct drm_i915_private *i915, u64 size, bool single)
static int igt_check_page_sizes(struct i915_vma *vma)
{
struct drm_i915_private *i915 = vma->vm->i915;
- unsigned int supported = INTEL_INFO(i915)->page_sizes;
+ unsigned int supported = RUNTIME_INFO(i915)->page_sizes;
struct drm_i915_gem_object *obj = vma->obj;
int err;
@@ -419,7 +419,7 @@ static int igt_mock_exhaust_device_supported_pages(void *arg)
{
struct i915_ppgtt *ppgtt = arg;
struct drm_i915_private *i915 = ppgtt->vm.i915;
- unsigned int saved_mask = INTEL_INFO(i915)->page_sizes;
+ unsigned int saved_mask = RUNTIME_INFO(i915)->page_sizes;
struct drm_i915_gem_object *obj;
struct i915_vma *vma;
int i, j, single;
@@ -438,7 +438,7 @@ static int igt_mock_exhaust_device_supported_pages(void *arg)
combination |= page_sizes[j];
}
- mkwrite_device_info(i915)->page_sizes = combination;
+ RUNTIME_INFO(i915)->page_sizes = combination;
for (single = 0; single <= 1; ++single) {
obj = fake_huge_pages_object(i915, combination, !!single);
@@ -485,7 +485,7 @@ static int igt_mock_exhaust_device_supported_pages(void *arg)
out_put:
i915_gem_object_put(obj);
out_device:
- mkwrite_device_info(i915)->page_sizes = saved_mask;
+ RUNTIME_INFO(i915)->page_sizes = saved_mask;
return err;
}
@@ -495,7 +495,7 @@ static int igt_mock_memory_region_huge_pages(void *arg)
const unsigned int flags[] = { 0, I915_BO_ALLOC_CONTIGUOUS };
struct i915_ppgtt *ppgtt = arg;
struct drm_i915_private *i915 = ppgtt->vm.i915;
- unsigned long supported = INTEL_INFO(i915)->page_sizes;
+ unsigned long supported = RUNTIME_INFO(i915)->page_sizes;
struct intel_memory_region *mem;
struct drm_i915_gem_object *obj;
struct i915_vma *vma;
@@ -573,7 +573,7 @@ static int igt_mock_ppgtt_misaligned_dma(void *arg)
{
struct i915_ppgtt *ppgtt = arg;
struct drm_i915_private *i915 = ppgtt->vm.i915;
- unsigned long supported = INTEL_INFO(i915)->page_sizes;
+ unsigned long supported = RUNTIME_INFO(i915)->page_sizes;
struct drm_i915_gem_object *obj;
int bit;
int err;
@@ -1390,7 +1390,7 @@ static int igt_ppgtt_smoke_huge(void *arg)
static int igt_ppgtt_sanity_check(void *arg)
{
struct drm_i915_private *i915 = arg;
- unsigned int supported = INTEL_INFO(i915)->page_sizes;
+ unsigned int supported = RUNTIME_INFO(i915)->page_sizes;
struct {
igt_create_fn fn;
unsigned int flags;
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index f4aa31499fd4..9529add807f5 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -1213,7 +1213,7 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915,
#define HAS_PAGE_SIZES(dev_priv, sizes) ({ \
GEM_BUG_ON((sizes) == 0); \
- ((sizes) & ~INTEL_INFO(dev_priv)->page_sizes) == 0; \
+ ((sizes) & ~RUNTIME_INFO(dev_priv)->page_sizes) == 0; \
})
#define HAS_OVERLAY(dev_priv) (INTEL_INFO(dev_priv)->display.has_overlay)
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index 702e5b89be22..4b76051312dd 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -1091,8 +1091,7 @@ int i915_gem_init(struct drm_i915_private *dev_priv)
/* We need to fallback to 4K pages if host doesn't support huge gtt. */
if (intel_vgpu_active(dev_priv) && !intel_vgpu_has_huge_gtt(dev_priv))
- mkwrite_device_info(dev_priv)->page_sizes =
- I915_GTT_PAGE_SIZE_4K;
+ RUNTIME_INFO(dev_priv)->page_sizes = I915_GTT_PAGE_SIZE_4K;
ret = i915_gem_init_userptr(dev_priv);
if (ret)
diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
index fb063284befa..0f888d044bc3 100644
--- a/drivers/gpu/drm/i915/i915_pci.c
+++ b/drivers/gpu/drm/i915/i915_pci.c
@@ -156,7 +156,7 @@
/* Keep in gen based order, and chronological order within a gen */
#define GEN_DEFAULT_PAGE_SIZES \
- .page_sizes = I915_GTT_PAGE_SIZE_4K
+ .__runtime.page_sizes = I915_GTT_PAGE_SIZE_4K
#define GEN_DEFAULT_REGIONS \
.memory_regions = REGION_SMEM | REGION_STOLEN_SMEM
@@ -643,8 +643,8 @@ static const struct intel_device_info chv_info = {
};
#define GEN9_DEFAULT_PAGE_SIZES \
- .page_sizes = I915_GTT_PAGE_SIZE_4K | \
- I915_GTT_PAGE_SIZE_64K
+ .__runtime.page_sizes = I915_GTT_PAGE_SIZE_4K | \
+ I915_GTT_PAGE_SIZE_64K
#define GEN9_FEATURES \
GEN8_FEATURES, \
@@ -798,9 +798,9 @@ static const struct intel_device_info cml_gt2_info = {
};
#define GEN11_DEFAULT_PAGE_SIZES \
- .page_sizes = I915_GTT_PAGE_SIZE_4K | \
- I915_GTT_PAGE_SIZE_64K | \
- I915_GTT_PAGE_SIZE_2M
+ .__runtime.page_sizes = I915_GTT_PAGE_SIZE_4K | \
+ I915_GTT_PAGE_SIZE_64K | \
+ I915_GTT_PAGE_SIZE_2M
#define GEN11_FEATURES \
GEN9_FEATURES, \
@@ -1004,9 +1004,9 @@ static const struct intel_device_info adl_p_info = {
#undef GEN
#define XE_HP_PAGE_SIZES \
- .page_sizes = I915_GTT_PAGE_SIZE_4K | \
- I915_GTT_PAGE_SIZE_64K | \
- I915_GTT_PAGE_SIZE_2M
+ .__runtime.page_sizes = I915_GTT_PAGE_SIZE_4K | \
+ I915_GTT_PAGE_SIZE_64K | \
+ I915_GTT_PAGE_SIZE_2M
#define XE_HP_FEATURES \
.graphics.ver = 12, \
diff --git a/drivers/gpu/drm/i915/intel_device_info.c b/drivers/gpu/drm/i915/intel_device_info.c
index 82a82fd83673..0b43da87d0ec 100644
--- a/drivers/gpu/drm/i915/intel_device_info.c
+++ b/drivers/gpu/drm/i915/intel_device_info.c
@@ -109,7 +109,7 @@ void intel_device_info_print(const struct intel_device_info *info,
drm_printf(p, "gt: %d\n", info->gt);
drm_printf(p, "memory-regions: %x\n", info->memory_regions);
- drm_printf(p, "page-sizes: %x\n", info->page_sizes);
+ drm_printf(p, "page-sizes: %x\n", runtime->page_sizes);
drm_printf(p, "platform: %s\n", intel_platform_name(info->platform));
drm_printf(p, "ppgtt-size: %d\n", info->ppgtt_size);
drm_printf(p, "ppgtt-type: %d\n", info->ppgtt_type);
diff --git a/drivers/gpu/drm/i915/intel_device_info.h b/drivers/gpu/drm/i915/intel_device_info.h
index 86d796eb93ad..f997ecf4b4fb 100644
--- a/drivers/gpu/drm/i915/intel_device_info.h
+++ b/drivers/gpu/drm/i915/intel_device_info.h
@@ -214,6 +214,8 @@ struct intel_runtime_info {
struct intel_step_info step;
+ unsigned int page_sizes; /* page sizes supported by the HW */
+
/* display */
struct {
u8 num_sprites[I915_MAX_PIPES];
@@ -236,8 +238,6 @@ struct intel_device_info {
enum intel_ppgtt_type ppgtt_type;
unsigned int ppgtt_size; /* log2, e.g. 31/32/48 bits */
- unsigned int page_sizes; /* page sizes supported by the HW */
-
u32 memory_regions; /* regions supported by the HW */
u32 display_mmio_offset;
diff --git a/drivers/gpu/drm/i915/selftests/mock_gem_device.c b/drivers/gpu/drm/i915/selftests/mock_gem_device.c
index 9c31a16f8380..4853b5804474 100644
--- a/drivers/gpu/drm/i915/selftests/mock_gem_device.c
+++ b/drivers/gpu/drm/i915/selftests/mock_gem_device.c
@@ -174,7 +174,7 @@ struct drm_i915_private *mock_gem_device(void)
mkwrite_device_info(i915)->graphics.ver = -1;
- mkwrite_device_info(i915)->page_sizes =
+ RUNTIME_INFO(i915)->page_sizes =
I915_GTT_PAGE_SIZE_4K |
I915_GTT_PAGE_SIZE_64K |
I915_GTT_PAGE_SIZE_2M;
--
2.30.2
^ permalink raw reply related [flat|nested] 29+ messages in thread
* [Intel-gfx] [PATCH 06/16] drm/i915: move ppgtt_type and ppgtt_size to runtime info
2022-06-20 8:37 ` Jani Nikula
` (5 preceding siblings ...)
(?)
@ 2022-06-20 8:38 ` Jani Nikula
-1 siblings, 0 replies; 29+ messages in thread
From: Jani Nikula @ 2022-06-20 8:38 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
If it's modified runtime, it's runtime info.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
.../gpu/drm/i915/gem/selftests/huge_pages.c | 4 +--
drivers/gpu/drm/i915/gt/intel_ppgtt.c | 2 +-
drivers/gpu/drm/i915/i915_drv.h | 2 +-
drivers/gpu/drm/i915/i915_pci.c | 36 +++++++++----------
drivers/gpu/drm/i915/intel_device_info.c | 6 ++--
drivers/gpu/drm/i915/intel_device_info.h | 6 ++--
6 files changed, 28 insertions(+), 28 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/selftests/huge_pages.c b/drivers/gpu/drm/i915/gem/selftests/huge_pages.c
index 488a10c20b85..c8c1842e8b7b 100644
--- a/drivers/gpu/drm/i915/gem/selftests/huge_pages.c
+++ b/drivers/gpu/drm/i915/gem/selftests/huge_pages.c
@@ -1759,8 +1759,8 @@ int i915_gem_huge_page_mock_selftests(void)
return -ENOMEM;
/* Pretend to be a device which supports the 48b PPGTT */
- mkwrite_device_info(dev_priv)->ppgtt_type = INTEL_PPGTT_FULL;
- mkwrite_device_info(dev_priv)->ppgtt_size = 48;
+ RUNTIME_INFO(dev_priv)->ppgtt_type = INTEL_PPGTT_FULL;
+ RUNTIME_INFO(dev_priv)->ppgtt_size = 48;
ppgtt = i915_ppgtt_create(to_gt(dev_priv), 0);
if (IS_ERR(ppgtt)) {
diff --git a/drivers/gpu/drm/i915/gt/intel_ppgtt.c b/drivers/gpu/drm/i915/gt/intel_ppgtt.c
index d8b94d638559..bf8570ae749a 100644
--- a/drivers/gpu/drm/i915/gt/intel_ppgtt.c
+++ b/drivers/gpu/drm/i915/gt/intel_ppgtt.c
@@ -308,7 +308,7 @@ void ppgtt_init(struct i915_ppgtt *ppgtt, struct intel_gt *gt,
ppgtt->vm.gt = gt;
ppgtt->vm.i915 = i915;
ppgtt->vm.dma = i915->drm.dev;
- ppgtt->vm.total = BIT_ULL(INTEL_INFO(i915)->ppgtt_size);
+ ppgtt->vm.total = BIT_ULL(RUNTIME_INFO(i915)->ppgtt_size);
ppgtt->vm.lmem_pt_obj_flags = lmem_pt_obj_flags;
dma_resv_init(&ppgtt->vm._resv);
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 9529add807f5..282a8103ed33 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -1205,7 +1205,7 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915,
#define HAS_EXECLISTS(dev_priv) HAS_LOGICAL_RING_CONTEXTS(dev_priv)
-#define INTEL_PPGTT(dev_priv) (INTEL_INFO(dev_priv)->ppgtt_type)
+#define INTEL_PPGTT(dev_priv) (RUNTIME_INFO(dev_priv)->ppgtt_type)
#define HAS_PPGTT(dev_priv) \
(INTEL_PPGTT(dev_priv) != INTEL_PPGTT_NONE)
#define HAS_FULL_PPGTT(dev_priv) \
diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
index 0f888d044bc3..1e9a17062d64 100644
--- a/drivers/gpu/drm/i915/i915_pci.c
+++ b/drivers/gpu/drm/i915/i915_pci.c
@@ -417,8 +417,8 @@ static const struct intel_device_info ilk_m_info = {
.has_rc6p = 1, \
.has_rps = true, \
.dma_mask_size = 40, \
- .ppgtt_type = INTEL_PPGTT_ALIASING, \
- .ppgtt_size = 31, \
+ .__runtime.ppgtt_type = INTEL_PPGTT_ALIASING, \
+ .__runtime.ppgtt_size = 31, \
I9XX_PIPE_OFFSETS, \
I9XX_CURSOR_OFFSETS, \
ILK_COLORS, \
@@ -470,8 +470,8 @@ static const struct intel_device_info snb_m_gt2_info = {
.has_reset_engine = true, \
.has_rps = true, \
.dma_mask_size = 40, \
- .ppgtt_type = INTEL_PPGTT_ALIASING, \
- .ppgtt_size = 31, \
+ .__runtime.ppgtt_type = INTEL_PPGTT_ALIASING, \
+ .__runtime.ppgtt_size = 31, \
IVB_PIPE_OFFSETS, \
IVB_CURSOR_OFFSETS, \
IVB_COLORS, \
@@ -531,8 +531,8 @@ static const struct intel_device_info vlv_info = {
.display.has_gmch = 1,
.display.has_hotplug = 1,
.dma_mask_size = 40,
- .ppgtt_type = INTEL_PPGTT_ALIASING,
- .ppgtt_size = 31,
+ .__runtime.ppgtt_type = INTEL_PPGTT_ALIASING,
+ .__runtime.ppgtt_size = 31,
.has_snoop = true,
.has_coherent_ggtt = false,
.platform_engine_mask = BIT(RCS0) | BIT(VCS0) | BIT(BCS0),
@@ -581,8 +581,8 @@ static const struct intel_device_info hsw_gt3_info = {
GEN(8), \
.has_logical_ring_contexts = 1, \
.dma_mask_size = 39, \
- .ppgtt_type = INTEL_PPGTT_FULL, \
- .ppgtt_size = 48, \
+ .__runtime.ppgtt_type = INTEL_PPGTT_FULL, \
+ .__runtime.ppgtt_size = 48, \
.has_64bit_reloc = 1
#define BDW_PLATFORM \
@@ -629,8 +629,8 @@ static const struct intel_device_info chv_info = {
.has_logical_ring_contexts = 1,
.display.has_gmch = 1,
.dma_mask_size = 39,
- .ppgtt_type = INTEL_PPGTT_FULL,
- .ppgtt_size = 32,
+ .__runtime.ppgtt_type = INTEL_PPGTT_FULL,
+ .__runtime.ppgtt_size = 32,
.has_reset_engine = 1,
.has_snoop = true,
.has_coherent_ggtt = false,
@@ -715,8 +715,8 @@ static const struct intel_device_info skl_gt4_info = {
.has_logical_ring_contexts = 1, \
.has_gt_uc = 1, \
.dma_mask_size = 39, \
- .ppgtt_type = INTEL_PPGTT_FULL, \
- .ppgtt_size = 48, \
+ .__runtime.ppgtt_type = INTEL_PPGTT_FULL, \
+ .__runtime.ppgtt_size = 48, \
.has_reset_engine = 1, \
.has_snoop = true, \
.has_coherent_ggtt = false, \
@@ -844,14 +844,14 @@ static const struct intel_device_info ehl_info = {
GEN11_FEATURES,
PLATFORM(INTEL_ELKHARTLAKE),
.platform_engine_mask = BIT(RCS0) | BIT(BCS0) | BIT(VCS0) | BIT(VECS0),
- .ppgtt_size = 36,
+ .__runtime.ppgtt_size = 36,
};
static const struct intel_device_info jsl_info = {
GEN11_FEATURES,
PLATFORM(INTEL_JASPERLAKE),
.platform_engine_mask = BIT(RCS0) | BIT(BCS0) | BIT(VCS0) | BIT(VECS0),
- .ppgtt_size = 36,
+ .__runtime.ppgtt_size = 36,
};
#define GEN12_FEATURES \
@@ -923,7 +923,7 @@ static const struct intel_device_info dg1_info = {
BIT(RCS0) | BIT(BCS0) | BIT(VECS0) |
BIT(VCS0) | BIT(VCS2),
/* Wa_16011227922 */
- .ppgtt_size = 47,
+ .__runtime.ppgtt_size = 47,
};
static const struct intel_device_info adl_s_info = {
@@ -997,7 +997,7 @@ static const struct intel_device_info adl_p_info = {
.display.has_psr_hw_tracking = 0,
.platform_engine_mask =
BIT(RCS0) | BIT(BCS0) | BIT(VECS0) | BIT(VCS0) | BIT(VCS2),
- .ppgtt_size = 48,
+ .__runtime.ppgtt_size = 48,
.dma_mask_size = 39,
};
@@ -1026,8 +1026,8 @@ static const struct intel_device_info adl_p_info = {
.has_reset_engine = 1, \
.has_rps = 1, \
.has_runtime_pm = 1, \
- .ppgtt_size = 48, \
- .ppgtt_type = INTEL_PPGTT_FULL
+ .__runtime.ppgtt_size = 48, \
+ .__runtime.ppgtt_type = INTEL_PPGTT_FULL
#define XE_HPM_FEATURES \
.media.ver = 12, \
diff --git a/drivers/gpu/drm/i915/intel_device_info.c b/drivers/gpu/drm/i915/intel_device_info.c
index 0b43da87d0ec..d1f5af57736c 100644
--- a/drivers/gpu/drm/i915/intel_device_info.c
+++ b/drivers/gpu/drm/i915/intel_device_info.c
@@ -111,8 +111,8 @@ void intel_device_info_print(const struct intel_device_info *info,
drm_printf(p, "memory-regions: %x\n", info->memory_regions);
drm_printf(p, "page-sizes: %x\n", runtime->page_sizes);
drm_printf(p, "platform: %s\n", intel_platform_name(info->platform));
- drm_printf(p, "ppgtt-size: %d\n", info->ppgtt_size);
- drm_printf(p, "ppgtt-type: %d\n", info->ppgtt_type);
+ drm_printf(p, "ppgtt-size: %d\n", runtime->ppgtt_size);
+ drm_printf(p, "ppgtt-type: %d\n", runtime->ppgtt_type);
drm_printf(p, "dma_mask_size: %u\n", info->dma_mask_size);
#define PRINT_FLAG(name) drm_printf(p, "%s: %s\n", #name, str_yes_no(info->name))
@@ -394,7 +394,7 @@ void intel_device_info_runtime_init(struct drm_i915_private *dev_priv)
if (GRAPHICS_VER(dev_priv) == 6 && i915_vtd_active(dev_priv)) {
drm_info(&dev_priv->drm,
"Disabling ppGTT for VT-d support\n");
- info->ppgtt_type = INTEL_PPGTT_NONE;
+ runtime->ppgtt_type = INTEL_PPGTT_NONE;
}
runtime->rawclk_freq = intel_read_rawclk(dev_priv);
diff --git a/drivers/gpu/drm/i915/intel_device_info.h b/drivers/gpu/drm/i915/intel_device_info.h
index f997ecf4b4fb..019f30c9e633 100644
--- a/drivers/gpu/drm/i915/intel_device_info.h
+++ b/drivers/gpu/drm/i915/intel_device_info.h
@@ -216,6 +216,9 @@ struct intel_runtime_info {
unsigned int page_sizes; /* page sizes supported by the HW */
+ enum intel_ppgtt_type ppgtt_type;
+ unsigned int ppgtt_size; /* log2, e.g. 31/32/48 bits */
+
/* display */
struct {
u8 num_sprites[I915_MAX_PIPES];
@@ -235,9 +238,6 @@ struct intel_device_info {
unsigned int dma_mask_size; /* available DMA address bits */
- enum intel_ppgtt_type ppgtt_type;
- unsigned int ppgtt_size; /* log2, e.g. 31/32/48 bits */
-
u32 memory_regions; /* regions supported by the HW */
u32 display_mmio_offset;
--
2.30.2
^ permalink raw reply related [flat|nested] 29+ messages in thread
* [Intel-gfx] [PATCH 07/16] drm/i915: move has_pooled_eu to runtime info
2022-06-20 8:37 ` Jani Nikula
` (6 preceding siblings ...)
(?)
@ 2022-06-20 8:49 ` Jani Nikula
-1 siblings, 0 replies; 29+ messages in thread
From: Jani Nikula @ 2022-06-20 8:49 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
If it's modified runtime, it's runtime info.
Curiously, the flag was never initialized statically.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/gt/intel_sseu.c | 5 ++---
drivers/gpu/drm/i915/i915_drv.h | 2 +-
drivers/gpu/drm/i915/intel_device_info.c | 2 ++
drivers/gpu/drm/i915/intel_device_info.h | 3 ++-
4 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_sseu.c b/drivers/gpu/drm/i915/gt/intel_sseu.c
index c6d3050604c8..66f21c735d54 100644
--- a/drivers/gpu/drm/i915/gt/intel_sseu.c
+++ b/drivers/gpu/drm/i915/gt/intel_sseu.c
@@ -382,7 +382,6 @@ static void cherryview_sseu_info_init(struct intel_gt *gt)
static void gen9_sseu_info_init(struct intel_gt *gt)
{
struct drm_i915_private *i915 = gt->i915;
- struct intel_device_info *info = mkwrite_device_info(i915);
struct sseu_dev_info *sseu = >->info.sseu;
struct intel_uncore *uncore = gt->uncore;
u32 fuse2, eu_disable, subslice_mask;
@@ -471,10 +470,10 @@ static void gen9_sseu_info_init(struct intel_gt *gt)
if (IS_GEN9_LP(i915)) {
#define IS_SS_DISABLED(ss) (!(sseu->subslice_mask.hsw[0] & BIT(ss)))
- info->has_pooled_eu = hweight8(sseu->subslice_mask.hsw[0]) == 3;
+ RUNTIME_INFO(i915)->has_pooled_eu = hweight8(sseu->subslice_mask.hsw[0]) == 3;
sseu->min_eu_in_pool = 0;
- if (info->has_pooled_eu) {
+ if (HAS_POOLED_EU(i915)) {
if (IS_SS_DISABLED(2) || IS_SS_DISABLED(0))
sseu->min_eu_in_pool = 3;
else if (IS_SS_DISABLED(1))
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 282a8103ed33..6ba1d528863c 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -1308,7 +1308,7 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915,
#define HAS_GT_UC(dev_priv) (INTEL_INFO(dev_priv)->has_gt_uc)
-#define HAS_POOLED_EU(dev_priv) (INTEL_INFO(dev_priv)->has_pooled_eu)
+#define HAS_POOLED_EU(dev_priv) (RUNTIME_INFO(dev_priv)->has_pooled_eu)
#define HAS_GLOBAL_MOCS_REGISTERS(dev_priv) (INTEL_INFO(dev_priv)->has_global_mocs)
diff --git a/drivers/gpu/drm/i915/intel_device_info.c b/drivers/gpu/drm/i915/intel_device_info.c
index d1f5af57736c..0ebb359a7791 100644
--- a/drivers/gpu/drm/i915/intel_device_info.c
+++ b/drivers/gpu/drm/i915/intel_device_info.c
@@ -119,6 +119,8 @@ void intel_device_info_print(const struct intel_device_info *info,
DEV_INFO_FOR_EACH_FLAG(PRINT_FLAG);
#undef PRINT_FLAG
+ drm_printf(p, "has_pooled_eu: %s\n", str_yes_no(runtime->has_pooled_eu));
+
#define PRINT_FLAG(name) drm_printf(p, "%s: %s\n", #name, str_yes_no(info->display.name))
DEV_INFO_DISPLAY_FOR_EACH_FLAG(PRINT_FLAG);
#undef PRINT_FLAG
diff --git a/drivers/gpu/drm/i915/intel_device_info.h b/drivers/gpu/drm/i915/intel_device_info.h
index 019f30c9e633..2025afa9ec71 100644
--- a/drivers/gpu/drm/i915/intel_device_info.h
+++ b/drivers/gpu/drm/i915/intel_device_info.h
@@ -159,7 +159,6 @@ enum intel_ppgtt_type {
func(has_media_ratio_mode); \
func(has_mslice_steering); \
func(has_one_eu_per_fuse_bit); \
- func(has_pooled_eu); \
func(has_pxp); \
func(has_rc6); \
func(has_rc6p); \
@@ -219,6 +218,8 @@ struct intel_runtime_info {
enum intel_ppgtt_type ppgtt_type;
unsigned int ppgtt_size; /* log2, e.g. 31/32/48 bits */
+ bool has_pooled_eu;
+
/* display */
struct {
u8 num_sprites[I915_MAX_PIPES];
--
2.30.2
^ permalink raw reply related [flat|nested] 29+ messages in thread
* [Intel-gfx] [PATCH 08/16] drm/i915: move memory_regions to runtime info
2022-06-20 8:37 ` Jani Nikula
` (7 preceding siblings ...)
(?)
@ 2022-06-20 8:49 ` Jani Nikula
-1 siblings, 0 replies; 29+ messages in thread
From: Jani Nikula @ 2022-06-20 8:49 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
If it's modified runtime, it's runtime info.
mock_gem_device() is the only one that modifies it. If that could be
fixed, we wouldn't have to do this.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/i915_drv.h | 2 +-
drivers/gpu/drm/i915/i915_pci.c | 4 ++--
drivers/gpu/drm/i915/intel_device_info.c | 2 +-
drivers/gpu/drm/i915/intel_device_info.h | 4 ++--
drivers/gpu/drm/i915/selftests/mock_gem_device.c | 2 +-
5 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 6ba1d528863c..6ad71a859cd5 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -1297,7 +1297,7 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915,
#define HAS_IPC(dev_priv) (INTEL_INFO(dev_priv)->display.has_ipc)
-#define HAS_REGION(i915, i) (INTEL_INFO(i915)->memory_regions & (i))
+#define HAS_REGION(i915, i) (RUNTIME_INFO(i915)->memory_regions & (i))
#define HAS_LMEM(i915) HAS_REGION(i915, REGION_LMEM)
/*
diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
index 1e9a17062d64..345d39d54bc9 100644
--- a/drivers/gpu/drm/i915/i915_pci.c
+++ b/drivers/gpu/drm/i915/i915_pci.c
@@ -159,7 +159,7 @@
.__runtime.page_sizes = I915_GTT_PAGE_SIZE_4K
#define GEN_DEFAULT_REGIONS \
- .memory_regions = REGION_SMEM | REGION_STOLEN_SMEM
+ .__runtime.memory_regions = REGION_SMEM | REGION_STOLEN_SMEM
#define I830_FEATURES \
GEN(2), \
@@ -905,7 +905,7 @@ static const struct intel_device_info rkl_info = {
};
#define DGFX_FEATURES \
- .memory_regions = REGION_SMEM | REGION_LMEM | REGION_STOLEN_LMEM, \
+ .__runtime.memory_regions = REGION_SMEM | REGION_LMEM | REGION_STOLEN_LMEM, \
.has_llc = 0, \
.has_pxp = 0, \
.has_snoop = 1, \
diff --git a/drivers/gpu/drm/i915/intel_device_info.c b/drivers/gpu/drm/i915/intel_device_info.c
index 0ebb359a7791..f9280f6f66d2 100644
--- a/drivers/gpu/drm/i915/intel_device_info.c
+++ b/drivers/gpu/drm/i915/intel_device_info.c
@@ -108,7 +108,7 @@ void intel_device_info_print(const struct intel_device_info *info,
drm_printf(p, "display version: %u\n", info->display.ver);
drm_printf(p, "gt: %d\n", info->gt);
- drm_printf(p, "memory-regions: %x\n", info->memory_regions);
+ drm_printf(p, "memory-regions: %x\n", runtime->memory_regions);
drm_printf(p, "page-sizes: %x\n", runtime->page_sizes);
drm_printf(p, "platform: %s\n", intel_platform_name(info->platform));
drm_printf(p, "ppgtt-size: %d\n", runtime->ppgtt_size);
diff --git a/drivers/gpu/drm/i915/intel_device_info.h b/drivers/gpu/drm/i915/intel_device_info.h
index 2025afa9ec71..1a2d19156410 100644
--- a/drivers/gpu/drm/i915/intel_device_info.h
+++ b/drivers/gpu/drm/i915/intel_device_info.h
@@ -218,6 +218,8 @@ struct intel_runtime_info {
enum intel_ppgtt_type ppgtt_type;
unsigned int ppgtt_size; /* log2, e.g. 31/32/48 bits */
+ u32 memory_regions; /* regions supported by the HW */
+
bool has_pooled_eu;
/* display */
@@ -239,8 +241,6 @@ struct intel_device_info {
unsigned int dma_mask_size; /* available DMA address bits */
- u32 memory_regions; /* regions supported by the HW */
-
u32 display_mmio_offset;
u8 gt; /* GT number, 0 if undefined */
diff --git a/drivers/gpu/drm/i915/selftests/mock_gem_device.c b/drivers/gpu/drm/i915/selftests/mock_gem_device.c
index 4853b5804474..3f05e870dc68 100644
--- a/drivers/gpu/drm/i915/selftests/mock_gem_device.c
+++ b/drivers/gpu/drm/i915/selftests/mock_gem_device.c
@@ -179,7 +179,7 @@ struct drm_i915_private *mock_gem_device(void)
I915_GTT_PAGE_SIZE_64K |
I915_GTT_PAGE_SIZE_2M;
- mkwrite_device_info(i915)->memory_regions = REGION_SMEM;
+ RUNTIME_INFO(i915)->memory_regions = REGION_SMEM;
intel_memory_regions_hw_probe(i915);
spin_lock_init(&i915->gpu_error.lock);
--
2.30.2
^ permalink raw reply related [flat|nested] 29+ messages in thread
* [Intel-gfx] [PATCH 09/16] drm/i915: move platform_engine_mask to runtime info
2022-06-20 8:37 ` Jani Nikula
` (8 preceding siblings ...)
(?)
@ 2022-06-20 8:49 ` Jani Nikula
-1 siblings, 0 replies; 29+ messages in thread
From: Jani Nikula @ 2022-06-20 8:49 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
If it's modified runtime, it's runtime info.
mock_gem_device() is the only one that modifies it. If that could be
fixed, we wouldn't have to do this.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/gt/intel_engine_cs.c | 2 +-
drivers/gpu/drm/i915/i915_pci.c | 56 +++++++++----------
drivers/gpu/drm/i915/intel_device_info.h | 4 +-
drivers/gpu/drm/i915/intel_uncore.c | 2 +-
.../gpu/drm/i915/selftests/mock_gem_device.c | 2 +-
5 files changed, 33 insertions(+), 33 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_engine_cs.c b/drivers/gpu/drm/i915/gt/intel_engine_cs.c
index 136cc44c3deb..77b6eeaf679d 100644
--- a/drivers/gpu/drm/i915/gt/intel_engine_cs.c
+++ b/drivers/gpu/drm/i915/gt/intel_engine_cs.c
@@ -736,7 +736,7 @@ static intel_engine_mask_t init_engine_mask(struct intel_gt *gt)
u16 vdbox_mask;
u16 vebox_mask;
- info->engine_mask = INTEL_INFO(i915)->platform_engine_mask;
+ info->engine_mask = RUNTIME_INFO(i915)->platform_engine_mask;
if (GRAPHICS_VER(i915) < 11)
return info->engine_mask;
diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
index 345d39d54bc9..64794063860c 100644
--- a/drivers/gpu/drm/i915/i915_pci.c
+++ b/drivers/gpu/drm/i915/i915_pci.c
@@ -174,7 +174,7 @@
.has_3d_pipeline = 1, \
.hws_needs_physical = 1, \
.unfenced_needs_alignment = 1, \
- .platform_engine_mask = BIT(RCS0), \
+ .__runtime.platform_engine_mask = BIT(RCS0), \
.has_snoop = true, \
.has_coherent_ggtt = false, \
.dma_mask_size = 32, \
@@ -195,7 +195,7 @@
.gpu_reset_clobbers_display = true, \
.hws_needs_physical = 1, \
.unfenced_needs_alignment = 1, \
- .platform_engine_mask = BIT(RCS0), \
+ .__runtime.platform_engine_mask = BIT(RCS0), \
.has_snoop = true, \
.has_coherent_ggtt = false, \
.dma_mask_size = 32, \
@@ -233,7 +233,7 @@ static const struct intel_device_info i865g_info = {
.display.cpu_transcoder_mask = BIT(TRANSCODER_A) | BIT(TRANSCODER_B), \
.display.has_gmch = 1, \
.gpu_reset_clobbers_display = true, \
- .platform_engine_mask = BIT(RCS0), \
+ .__runtime.platform_engine_mask = BIT(RCS0), \
.has_3d_pipeline = 1, \
.has_snoop = true, \
.has_coherent_ggtt = true, \
@@ -325,7 +325,7 @@ static const struct intel_device_info pnv_m_info = {
.display.has_hotplug = 1, \
.display.has_gmch = 1, \
.gpu_reset_clobbers_display = true, \
- .platform_engine_mask = BIT(RCS0), \
+ .__runtime.platform_engine_mask = BIT(RCS0), \
.has_3d_pipeline = 1, \
.has_snoop = true, \
.has_coherent_ggtt = true, \
@@ -358,7 +358,7 @@ static const struct intel_device_info i965gm_info = {
static const struct intel_device_info g45_info = {
GEN4_FEATURES,
PLATFORM(INTEL_G45),
- .platform_engine_mask = BIT(RCS0) | BIT(VCS0),
+ .__runtime.platform_engine_mask = BIT(RCS0) | BIT(VCS0),
.gpu_reset_clobbers_display = false,
};
@@ -368,7 +368,7 @@ static const struct intel_device_info gm45_info = {
.is_mobile = 1,
.__runtime.fbc_mask = BIT(INTEL_FBC_A),
.display.supports_tv = 1,
- .platform_engine_mask = BIT(RCS0) | BIT(VCS0),
+ .__runtime.platform_engine_mask = BIT(RCS0) | BIT(VCS0),
.gpu_reset_clobbers_display = false,
};
@@ -377,7 +377,7 @@ static const struct intel_device_info gm45_info = {
.display.pipe_mask = BIT(PIPE_A) | BIT(PIPE_B), \
.display.cpu_transcoder_mask = BIT(TRANSCODER_A) | BIT(TRANSCODER_B), \
.display.has_hotplug = 1, \
- .platform_engine_mask = BIT(RCS0) | BIT(VCS0), \
+ .__runtime.platform_engine_mask = BIT(RCS0) | BIT(VCS0), \
.has_3d_pipeline = 1, \
.has_snoop = true, \
.has_coherent_ggtt = true, \
@@ -409,7 +409,7 @@ static const struct intel_device_info ilk_m_info = {
.display.cpu_transcoder_mask = BIT(TRANSCODER_A) | BIT(TRANSCODER_B), \
.display.has_hotplug = 1, \
.__runtime.fbc_mask = BIT(INTEL_FBC_A), \
- .platform_engine_mask = BIT(RCS0) | BIT(VCS0) | BIT(BCS0), \
+ .__runtime.platform_engine_mask = BIT(RCS0) | BIT(VCS0) | BIT(BCS0), \
.has_3d_pipeline = 1, \
.has_coherent_ggtt = true, \
.has_llc = 1, \
@@ -461,7 +461,7 @@ static const struct intel_device_info snb_m_gt2_info = {
.display.cpu_transcoder_mask = BIT(TRANSCODER_A) | BIT(TRANSCODER_B) | BIT(TRANSCODER_C), \
.display.has_hotplug = 1, \
.__runtime.fbc_mask = BIT(INTEL_FBC_A), \
- .platform_engine_mask = BIT(RCS0) | BIT(VCS0) | BIT(BCS0), \
+ .__runtime.platform_engine_mask = BIT(RCS0) | BIT(VCS0) | BIT(BCS0), \
.has_3d_pipeline = 1, \
.has_coherent_ggtt = true, \
.has_llc = 1, \
@@ -535,7 +535,7 @@ static const struct intel_device_info vlv_info = {
.__runtime.ppgtt_size = 31,
.has_snoop = true,
.has_coherent_ggtt = false,
- .platform_engine_mask = BIT(RCS0) | BIT(VCS0) | BIT(BCS0),
+ .__runtime.platform_engine_mask = BIT(RCS0) | BIT(VCS0) | BIT(BCS0),
.display_mmio_offset = VLV_DISPLAY_BASE,
I9XX_PIPE_OFFSETS,
I9XX_CURSOR_OFFSETS,
@@ -546,7 +546,7 @@ static const struct intel_device_info vlv_info = {
#define G75_FEATURES \
GEN7_FEATURES, \
- .platform_engine_mask = BIT(RCS0) | BIT(VCS0) | BIT(BCS0) | BIT(VECS0), \
+ .__runtime.platform_engine_mask = BIT(RCS0) | BIT(VCS0) | BIT(BCS0) | BIT(VECS0), \
.display.cpu_transcoder_mask = BIT(TRANSCODER_A) | BIT(TRANSCODER_B) | \
BIT(TRANSCODER_C) | BIT(TRANSCODER_EDP), \
.display.has_ddi = 1, \
@@ -610,7 +610,7 @@ static const struct intel_device_info bdw_rsvd_info = {
static const struct intel_device_info bdw_gt3_info = {
BDW_PLATFORM,
.gt = 3,
- .platform_engine_mask =
+ .__runtime.platform_engine_mask =
BIT(RCS0) | BIT(VCS0) | BIT(BCS0) | BIT(VECS0) | BIT(VCS1),
};
@@ -621,7 +621,7 @@ static const struct intel_device_info chv_info = {
.display.cpu_transcoder_mask = BIT(TRANSCODER_A) | BIT(TRANSCODER_B) | BIT(TRANSCODER_C),
.display.has_hotplug = 1,
.is_lp = 1,
- .platform_engine_mask = BIT(RCS0) | BIT(VCS0) | BIT(BCS0) | BIT(VECS0),
+ .__runtime.platform_engine_mask = BIT(RCS0) | BIT(VCS0) | BIT(BCS0) | BIT(VECS0),
.has_64bit_reloc = 1,
.has_runtime_pm = 1,
.has_rc6 = 1,
@@ -675,7 +675,7 @@ static const struct intel_device_info skl_gt2_info = {
#define SKL_GT3_PLUS_PLATFORM \
SKL_PLATFORM, \
- .platform_engine_mask = \
+ .__runtime.platform_engine_mask = \
BIT(RCS0) | BIT(VCS0) | BIT(BCS0) | BIT(VECS0) | BIT(VCS1)
@@ -694,7 +694,7 @@ static const struct intel_device_info skl_gt4_info = {
.is_lp = 1, \
.dbuf.slice_mask = BIT(DBUF_S1), \
.display.has_hotplug = 1, \
- .platform_engine_mask = BIT(RCS0) | BIT(VCS0) | BIT(BCS0) | BIT(VECS0), \
+ .__runtime.platform_engine_mask = BIT(RCS0) | BIT(VCS0) | BIT(BCS0) | BIT(VECS0), \
.display.pipe_mask = BIT(PIPE_A) | BIT(PIPE_B) | BIT(PIPE_C), \
.display.cpu_transcoder_mask = BIT(TRANSCODER_A) | BIT(TRANSCODER_B) | \
BIT(TRANSCODER_C) | BIT(TRANSCODER_EDP) | \
@@ -758,7 +758,7 @@ static const struct intel_device_info kbl_gt2_info = {
static const struct intel_device_info kbl_gt3_info = {
KBL_PLATFORM,
.gt = 3,
- .platform_engine_mask =
+ .__runtime.platform_engine_mask =
BIT(RCS0) | BIT(VCS0) | BIT(BCS0) | BIT(VECS0) | BIT(VCS1),
};
@@ -779,7 +779,7 @@ static const struct intel_device_info cfl_gt2_info = {
static const struct intel_device_info cfl_gt3_info = {
CFL_PLATFORM,
.gt = 3,
- .platform_engine_mask =
+ .__runtime.platform_engine_mask =
BIT(RCS0) | BIT(VCS0) | BIT(BCS0) | BIT(VECS0) | BIT(VCS1),
};
@@ -836,21 +836,21 @@ static const struct intel_device_info cml_gt2_info = {
static const struct intel_device_info icl_info = {
GEN11_FEATURES,
PLATFORM(INTEL_ICELAKE),
- .platform_engine_mask =
+ .__runtime.platform_engine_mask =
BIT(RCS0) | BIT(BCS0) | BIT(VECS0) | BIT(VCS0) | BIT(VCS2),
};
static const struct intel_device_info ehl_info = {
GEN11_FEATURES,
PLATFORM(INTEL_ELKHARTLAKE),
- .platform_engine_mask = BIT(RCS0) | BIT(BCS0) | BIT(VCS0) | BIT(VECS0),
+ .__runtime.platform_engine_mask = BIT(RCS0) | BIT(BCS0) | BIT(VCS0) | BIT(VECS0),
.__runtime.ppgtt_size = 36,
};
static const struct intel_device_info jsl_info = {
GEN11_FEATURES,
PLATFORM(INTEL_JASPERLAKE),
- .platform_engine_mask = BIT(RCS0) | BIT(BCS0) | BIT(VCS0) | BIT(VECS0),
+ .__runtime.platform_engine_mask = BIT(RCS0) | BIT(BCS0) | BIT(VCS0) | BIT(VECS0),
.__runtime.ppgtt_size = 36,
};
@@ -887,7 +887,7 @@ static const struct intel_device_info tgl_info = {
GEN12_FEATURES,
PLATFORM(INTEL_TIGERLAKE),
.display.has_modular_fia = 1,
- .platform_engine_mask =
+ .__runtime.platform_engine_mask =
BIT(RCS0) | BIT(BCS0) | BIT(VECS0) | BIT(VCS0) | BIT(VCS2),
};
@@ -900,7 +900,7 @@ static const struct intel_device_info rkl_info = {
BIT(TRANSCODER_C),
.display.has_hti = 1,
.display.has_psr_hw_tracking = 0,
- .platform_engine_mask =
+ .__runtime.platform_engine_mask =
BIT(RCS0) | BIT(BCS0) | BIT(VECS0) | BIT(VCS0),
};
@@ -919,7 +919,7 @@ static const struct intel_device_info dg1_info = {
PLATFORM(INTEL_DG1),
.display.pipe_mask = BIT(PIPE_A) | BIT(PIPE_B) | BIT(PIPE_C) | BIT(PIPE_D),
.require_force_probe = 1,
- .platform_engine_mask =
+ .__runtime.platform_engine_mask =
BIT(RCS0) | BIT(BCS0) | BIT(VECS0) |
BIT(VCS0) | BIT(VCS2),
/* Wa_16011227922 */
@@ -932,7 +932,7 @@ static const struct intel_device_info adl_s_info = {
.display.pipe_mask = BIT(PIPE_A) | BIT(PIPE_B) | BIT(PIPE_C) | BIT(PIPE_D),
.display.has_hti = 1,
.display.has_psr_hw_tracking = 0,
- .platform_engine_mask =
+ .__runtime.platform_engine_mask =
BIT(RCS0) | BIT(BCS0) | BIT(VECS0) | BIT(VCS0) | BIT(VCS2),
.dma_mask_size = 39,
};
@@ -995,7 +995,7 @@ static const struct intel_device_info adl_p_info = {
.display.has_cdclk_crawl = 1,
.display.has_modular_fia = 1,
.display.has_psr_hw_tracking = 0,
- .platform_engine_mask =
+ .__runtime.platform_engine_mask =
BIT(RCS0) | BIT(BCS0) | BIT(VECS0) | BIT(VCS0) | BIT(VCS2),
.__runtime.ppgtt_size = 48,
.dma_mask_size = 39,
@@ -1043,7 +1043,7 @@ static const struct intel_device_info xehpsdv_info = {
.has_64k_pages = 1,
.needs_compact_pt = 1,
.has_media_ratio_mode = 1,
- .platform_engine_mask =
+ .__runtime.platform_engine_mask =
BIT(RCS0) | BIT(BCS0) |
BIT(VECS0) | BIT(VECS1) | BIT(VECS2) | BIT(VECS3) |
BIT(VCS0) | BIT(VCS1) | BIT(VCS2) | BIT(VCS3) |
@@ -1065,7 +1065,7 @@ static const struct intel_device_info xehpsdv_info = {
.has_heci_pxp = 1, \
.needs_compact_pt = 1, \
.has_media_ratio_mode = 1, \
- .platform_engine_mask = \
+ .__runtime.platform_engine_mask = \
BIT(RCS0) | BIT(BCS0) | \
BIT(VECS0) | BIT(VECS1) | \
BIT(VCS0) | BIT(VCS2) | \
@@ -1104,7 +1104,7 @@ static const struct intel_device_info pvc_info = {
PLATFORM(INTEL_PONTEVECCHIO),
.display = { 0 },
.has_flat_ccs = 0,
- .platform_engine_mask =
+ .__runtime.platform_engine_mask =
BIT(BCS0) |
BIT(VCS0) |
BIT(CCS0) | BIT(CCS1) | BIT(CCS2) | BIT(CCS3),
diff --git a/drivers/gpu/drm/i915/intel_device_info.h b/drivers/gpu/drm/i915/intel_device_info.h
index 1a2d19156410..8724621944a9 100644
--- a/drivers/gpu/drm/i915/intel_device_info.h
+++ b/drivers/gpu/drm/i915/intel_device_info.h
@@ -209,6 +209,8 @@ struct intel_runtime_info {
u16 device_id;
+ intel_engine_mask_t platform_engine_mask; /* Engines supported by the HW */
+
u32 rawclk_freq;
struct intel_step_info step;
@@ -235,8 +237,6 @@ struct intel_device_info {
struct ip_version graphics;
struct ip_version media;
- intel_engine_mask_t platform_engine_mask; /* Engines supported by the HW */
-
enum intel_platform platform;
unsigned int dma_mask_size; /* available DMA address bits */
diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c
index a852c471d1b3..c96b5c762ae6 100644
--- a/drivers/gpu/drm/i915/intel_uncore.c
+++ b/drivers/gpu/drm/i915/intel_uncore.c
@@ -2067,7 +2067,7 @@ static int intel_uncore_fw_domains_init(struct intel_uncore *uncore)
if (GRAPHICS_VER(i915) >= 11) {
/* we'll prune the domains of missing engines later */
- intel_engine_mask_t emask = INTEL_INFO(i915)->platform_engine_mask;
+ intel_engine_mask_t emask = RUNTIME_INFO(i915)->platform_engine_mask;
int i;
uncore->fw_get_funcs = &uncore_get_fallback;
diff --git a/drivers/gpu/drm/i915/selftests/mock_gem_device.c b/drivers/gpu/drm/i915/selftests/mock_gem_device.c
index 3f05e870dc68..207e6996f423 100644
--- a/drivers/gpu/drm/i915/selftests/mock_gem_device.c
+++ b/drivers/gpu/drm/i915/selftests/mock_gem_device.c
@@ -209,7 +209,7 @@ struct drm_i915_private *mock_gem_device(void)
mock_init_ggtt(to_gt(i915));
to_gt(i915)->vm = i915_vm_get(&to_gt(i915)->ggtt->vm);
- mkwrite_device_info(i915)->platform_engine_mask = BIT(0);
+ RUNTIME_INFO(i915)->platform_engine_mask = BIT(0);
to_gt(i915)->info.engine_mask = BIT(0);
to_gt(i915)->engine[RCS0] = mock_engine(i915, "mock", RCS0);
--
2.30.2
^ permalink raw reply related [flat|nested] 29+ messages in thread
* [Intel-gfx] [PATCH 10/16] drm/i915: move graphics.ver and graphics.rel to runtime info
2022-06-20 8:37 ` Jani Nikula
` (9 preceding siblings ...)
(?)
@ 2022-06-20 8:49 ` Jani Nikula
-1 siblings, 0 replies; 29+ messages in thread
From: Jani Nikula @ 2022-06-20 8:49 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
If it's modified runtime, it's runtime info.
mock_gem_device() is the only one that modifies them. If that could be
fixed, we wouldn't have to do this.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/i915_drv.h | 6 +++---
drivers/gpu/drm/i915/i915_pci.c | 12 ++++++------
drivers/gpu/drm/i915/intel_device_info.c | 8 ++++----
drivers/gpu/drm/i915/intel_device_info.h | 3 ++-
drivers/gpu/drm/i915/selftests/mock_gem_device.c | 2 +-
5 files changed, 16 insertions(+), 15 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 6ad71a859cd5..1343350b4dfc 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -856,9 +856,9 @@ static inline struct intel_gt *to_gt(struct drm_i915_private *i915)
#define IP_VER(ver, rel) ((ver) << 8 | (rel))
-#define GRAPHICS_VER(i915) (INTEL_INFO(i915)->graphics.ver)
-#define GRAPHICS_VER_FULL(i915) IP_VER(INTEL_INFO(i915)->graphics.ver, \
- INTEL_INFO(i915)->graphics.rel)
+#define GRAPHICS_VER(i915) (RUNTIME_INFO(i915)->graphics.ver)
+#define GRAPHICS_VER_FULL(i915) IP_VER(RUNTIME_INFO(i915)->graphics.ver, \
+ RUNTIME_INFO(i915)->graphics.rel)
#define IS_GRAPHICS_VER(i915, from, until) \
(GRAPHICS_VER(i915) >= (from) && GRAPHICS_VER(i915) <= (until))
diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
index 64794063860c..1a75acfd1fc1 100644
--- a/drivers/gpu/drm/i915/i915_pci.c
+++ b/drivers/gpu/drm/i915/i915_pci.c
@@ -33,7 +33,7 @@
#define PLATFORM(x) .platform = (x)
#define GEN(x) \
- .graphics.ver = (x), \
+ .__runtime.graphics.ver = (x), \
.media.ver = (x), \
.display.ver = (x)
@@ -915,7 +915,7 @@ static const struct intel_device_info rkl_info = {
static const struct intel_device_info dg1_info = {
GEN12_FEATURES,
DGFX_FEATURES,
- .graphics.rel = 10,
+ .__runtime.graphics.rel = 10,
PLATFORM(INTEL_DG1),
.display.pipe_mask = BIT(PIPE_A) | BIT(PIPE_B) | BIT(PIPE_C) | BIT(PIPE_D),
.require_force_probe = 1,
@@ -1009,8 +1009,8 @@ static const struct intel_device_info adl_p_info = {
I915_GTT_PAGE_SIZE_2M
#define XE_HP_FEATURES \
- .graphics.ver = 12, \
- .graphics.rel = 50, \
+ .__runtime.graphics.ver = 12, \
+ .__runtime.graphics.rel = 50, \
XE_HP_PAGE_SIZES, \
.dma_mask_size = 46, \
.has_3d_pipeline = 1, \
@@ -1056,7 +1056,7 @@ static const struct intel_device_info xehpsdv_info = {
XE_HP_FEATURES, \
XE_HPM_FEATURES, \
DGFX_FEATURES, \
- .graphics.rel = 55, \
+ .__runtime.graphics.rel = 55, \
.media.rel = 55, \
PLATFORM(INTEL_DG2), \
.has_4tile = 1, \
@@ -1099,7 +1099,7 @@ static const struct intel_device_info pvc_info = {
XE_HPC_FEATURES,
XE_HPM_FEATURES,
DGFX_FEATURES,
- .graphics.rel = 60,
+ .__runtime.graphics.rel = 60,
.media.rel = 60,
PLATFORM(INTEL_PONTEVECCHIO),
.display = { 0 },
diff --git a/drivers/gpu/drm/i915/intel_device_info.c b/drivers/gpu/drm/i915/intel_device_info.c
index f9280f6f66d2..43fefcc52ef1 100644
--- a/drivers/gpu/drm/i915/intel_device_info.c
+++ b/drivers/gpu/drm/i915/intel_device_info.c
@@ -91,11 +91,11 @@ void intel_device_info_print(const struct intel_device_info *info,
const struct intel_runtime_info *runtime,
struct drm_printer *p)
{
- if (info->graphics.rel)
- drm_printf(p, "graphics version: %u.%02u\n", info->graphics.ver,
- info->graphics.rel);
+ if (runtime->graphics.rel)
+ drm_printf(p, "graphics version: %u.%02u\n", runtime->graphics.ver,
+ runtime->graphics.rel);
else
- drm_printf(p, "graphics version: %u\n", info->graphics.ver);
+ drm_printf(p, "graphics version: %u\n", runtime->graphics.ver);
if (info->media.rel)
drm_printf(p, "media version: %u.%02u\n", info->media.ver, info->media.rel);
diff --git a/drivers/gpu/drm/i915/intel_device_info.h b/drivers/gpu/drm/i915/intel_device_info.h
index 8724621944a9..c354afd1c842 100644
--- a/drivers/gpu/drm/i915/intel_device_info.h
+++ b/drivers/gpu/drm/i915/intel_device_info.h
@@ -197,6 +197,8 @@ struct ip_version {
};
struct intel_runtime_info {
+ struct ip_version graphics;
+
/*
* Platform mask is used for optimizing or-ed IS_PLATFORM calls into
* into single runtime conditionals, and also to provide groundwork
@@ -234,7 +236,6 @@ struct intel_runtime_info {
};
struct intel_device_info {
- struct ip_version graphics;
struct ip_version media;
enum intel_platform platform;
diff --git a/drivers/gpu/drm/i915/selftests/mock_gem_device.c b/drivers/gpu/drm/i915/selftests/mock_gem_device.c
index 207e6996f423..f5904e659ef2 100644
--- a/drivers/gpu/drm/i915/selftests/mock_gem_device.c
+++ b/drivers/gpu/drm/i915/selftests/mock_gem_device.c
@@ -172,7 +172,7 @@ struct drm_i915_private *mock_gem_device(void)
/* Using the global GTT may ask questions about KMS users, so prepare */
drm_mode_config_init(&i915->drm);
- mkwrite_device_info(i915)->graphics.ver = -1;
+ RUNTIME_INFO(i915)->graphics.ver = -1;
RUNTIME_INFO(i915)->page_sizes =
I915_GTT_PAGE_SIZE_4K |
--
2.30.2
^ permalink raw reply related [flat|nested] 29+ messages in thread
* [Intel-gfx] [PATCH 11/16] drm/i915: move pipe_mask and cpu_transcoder_mask to runtime info
2022-06-20 8:37 ` Jani Nikula
` (10 preceding siblings ...)
(?)
@ 2022-06-20 8:49 ` Jani Nikula
-1 siblings, 0 replies; 29+ messages in thread
From: Jani Nikula @ 2022-06-20 8:49 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
If it's modified runtime, it's runtime info.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/display/intel_display.h | 4 +-
drivers/gpu/drm/i915/i915_drv.h | 6 +-
drivers/gpu/drm/i915/i915_pci.c | 66 ++++++++++----------
drivers/gpu/drm/i915/intel_device_info.c | 24 +++----
drivers/gpu/drm/i915/intel_device_info.h | 5 +-
5 files changed, 53 insertions(+), 52 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display.h b/drivers/gpu/drm/i915/display/intel_display.h
index 2feb8ae5d5d4..3a06fcb51c9b 100644
--- a/drivers/gpu/drm/i915/display/intel_display.h
+++ b/drivers/gpu/drm/i915/display/intel_display.h
@@ -374,7 +374,7 @@ enum hpd_pin {
#define for_each_pipe(__dev_priv, __p) \
for ((__p) = 0; (__p) < I915_MAX_PIPES; (__p)++) \
- for_each_if(INTEL_INFO(__dev_priv)->display.pipe_mask & BIT(__p))
+ for_each_if(RUNTIME_INFO(__dev_priv)->pipe_mask & BIT(__p))
#define for_each_pipe_masked(__dev_priv, __p, __mask) \
for_each_pipe(__dev_priv, __p) \
@@ -382,7 +382,7 @@ enum hpd_pin {
#define for_each_cpu_transcoder(__dev_priv, __t) \
for ((__t) = 0; (__t) < I915_MAX_TRANSCODERS; (__t)++) \
- for_each_if (INTEL_INFO(__dev_priv)->display.cpu_transcoder_mask & BIT(__t))
+ for_each_if (RUNTIME_INFO(__dev_priv)->cpu_transcoder_mask & BIT(__t))
#define for_each_cpu_transcoder_masked(__dev_priv, __t, __mask) \
for_each_cpu_transcoder(__dev_priv, __t) \
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 1343350b4dfc..5bb1f0e9368c 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -1259,7 +1259,7 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915,
#define HAS_PSR_HW_TRACKING(dev_priv) \
(INTEL_INFO(dev_priv)->display.has_psr_hw_tracking)
#define HAS_PSR2_SEL_FETCH(dev_priv) (DISPLAY_VER(dev_priv) >= 12)
-#define HAS_TRANSCODER(dev_priv, trans) ((INTEL_INFO(dev_priv)->display.cpu_transcoder_mask & BIT(trans)) != 0)
+#define HAS_TRANSCODER(dev_priv, trans) ((RUNTIME_INFO(dev_priv)->cpu_transcoder_mask & BIT(trans)) != 0)
#define HAS_RC6(dev_priv) (INTEL_INFO(dev_priv)->has_rc6)
#define HAS_RC6p(dev_priv) (INTEL_INFO(dev_priv)->has_rc6p)
@@ -1330,9 +1330,9 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915,
#define GT_FREQUENCY_MULTIPLIER 50
#define GEN9_FREQ_SCALER 3
-#define INTEL_NUM_PIPES(dev_priv) (hweight8(INTEL_INFO(dev_priv)->display.pipe_mask))
+#define INTEL_NUM_PIPES(dev_priv) (hweight8(RUNTIME_INFO(dev_priv)->pipe_mask))
-#define HAS_DISPLAY(dev_priv) (INTEL_INFO(dev_priv)->display.pipe_mask != 0)
+#define HAS_DISPLAY(dev_priv) (RUNTIME_INFO(dev_priv)->pipe_mask != 0)
#define HAS_VRR(i915) (DISPLAY_VER(i915) >= 11)
diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
index 1a75acfd1fc1..e9e036bec732 100644
--- a/drivers/gpu/drm/i915/i915_pci.c
+++ b/drivers/gpu/drm/i915/i915_pci.c
@@ -164,8 +164,8 @@
#define I830_FEATURES \
GEN(2), \
.is_mobile = 1, \
- .display.pipe_mask = BIT(PIPE_A) | BIT(PIPE_B), \
- .display.cpu_transcoder_mask = BIT(TRANSCODER_A) | BIT(TRANSCODER_B), \
+ .__runtime.pipe_mask = BIT(PIPE_A) | BIT(PIPE_B), \
+ .__runtime.cpu_transcoder_mask = BIT(TRANSCODER_A) | BIT(TRANSCODER_B), \
.display.has_overlay = 1, \
.display.cursor_needs_physical = 1, \
.display.overlay_needs_physical = 1, \
@@ -186,8 +186,8 @@
#define I845_FEATURES \
GEN(2), \
- .display.pipe_mask = BIT(PIPE_A), \
- .display.cpu_transcoder_mask = BIT(TRANSCODER_A), \
+ .__runtime.pipe_mask = BIT(PIPE_A), \
+ .__runtime.cpu_transcoder_mask = BIT(TRANSCODER_A), \
.display.has_overlay = 1, \
.display.overlay_needs_physical = 1, \
.display.has_gmch = 1, \
@@ -229,8 +229,8 @@ static const struct intel_device_info i865g_info = {
#define GEN3_FEATURES \
GEN(3), \
- .display.pipe_mask = BIT(PIPE_A) | BIT(PIPE_B), \
- .display.cpu_transcoder_mask = BIT(TRANSCODER_A) | BIT(TRANSCODER_B), \
+ .__runtime.pipe_mask = BIT(PIPE_A) | BIT(PIPE_B), \
+ .__runtime.cpu_transcoder_mask = BIT(TRANSCODER_A) | BIT(TRANSCODER_B), \
.display.has_gmch = 1, \
.gpu_reset_clobbers_display = true, \
.__runtime.platform_engine_mask = BIT(RCS0), \
@@ -320,8 +320,8 @@ static const struct intel_device_info pnv_m_info = {
#define GEN4_FEATURES \
GEN(4), \
- .display.pipe_mask = BIT(PIPE_A) | BIT(PIPE_B), \
- .display.cpu_transcoder_mask = BIT(TRANSCODER_A) | BIT(TRANSCODER_B), \
+ .__runtime.pipe_mask = BIT(PIPE_A) | BIT(PIPE_B), \
+ .__runtime.cpu_transcoder_mask = BIT(TRANSCODER_A) | BIT(TRANSCODER_B), \
.display.has_hotplug = 1, \
.display.has_gmch = 1, \
.gpu_reset_clobbers_display = true, \
@@ -374,8 +374,8 @@ static const struct intel_device_info gm45_info = {
#define GEN5_FEATURES \
GEN(5), \
- .display.pipe_mask = BIT(PIPE_A) | BIT(PIPE_B), \
- .display.cpu_transcoder_mask = BIT(TRANSCODER_A) | BIT(TRANSCODER_B), \
+ .__runtime.pipe_mask = BIT(PIPE_A) | BIT(PIPE_B), \
+ .__runtime.cpu_transcoder_mask = BIT(TRANSCODER_A) | BIT(TRANSCODER_B), \
.display.has_hotplug = 1, \
.__runtime.platform_engine_mask = BIT(RCS0) | BIT(VCS0), \
.has_3d_pipeline = 1, \
@@ -405,8 +405,8 @@ static const struct intel_device_info ilk_m_info = {
#define GEN6_FEATURES \
GEN(6), \
- .display.pipe_mask = BIT(PIPE_A) | BIT(PIPE_B), \
- .display.cpu_transcoder_mask = BIT(TRANSCODER_A) | BIT(TRANSCODER_B), \
+ .__runtime.pipe_mask = BIT(PIPE_A) | BIT(PIPE_B), \
+ .__runtime.cpu_transcoder_mask = BIT(TRANSCODER_A) | BIT(TRANSCODER_B), \
.display.has_hotplug = 1, \
.__runtime.fbc_mask = BIT(INTEL_FBC_A), \
.__runtime.platform_engine_mask = BIT(RCS0) | BIT(VCS0) | BIT(BCS0), \
@@ -457,8 +457,8 @@ static const struct intel_device_info snb_m_gt2_info = {
#define GEN7_FEATURES \
GEN(7), \
- .display.pipe_mask = BIT(PIPE_A) | BIT(PIPE_B) | BIT(PIPE_C), \
- .display.cpu_transcoder_mask = BIT(TRANSCODER_A) | BIT(TRANSCODER_B) | BIT(TRANSCODER_C), \
+ .__runtime.pipe_mask = BIT(PIPE_A) | BIT(PIPE_B) | BIT(PIPE_C), \
+ .__runtime.cpu_transcoder_mask = BIT(TRANSCODER_A) | BIT(TRANSCODER_B) | BIT(TRANSCODER_C), \
.display.has_hotplug = 1, \
.__runtime.fbc_mask = BIT(INTEL_FBC_A), \
.__runtime.platform_engine_mask = BIT(RCS0) | BIT(VCS0) | BIT(BCS0), \
@@ -513,8 +513,8 @@ static const struct intel_device_info ivb_q_info = {
GEN7_FEATURES,
PLATFORM(INTEL_IVYBRIDGE),
.gt = 2,
- .display.pipe_mask = 0, /* legal, last one wins */
- .display.cpu_transcoder_mask = 0,
+ .__runtime.pipe_mask = 0, /* legal, last one wins */
+ .__runtime.cpu_transcoder_mask = 0,
.has_l3_dpf = 1,
};
@@ -522,8 +522,8 @@ static const struct intel_device_info vlv_info = {
PLATFORM(INTEL_VALLEYVIEW),
GEN(7),
.is_lp = 1,
- .display.pipe_mask = BIT(PIPE_A) | BIT(PIPE_B),
- .display.cpu_transcoder_mask = BIT(TRANSCODER_A) | BIT(TRANSCODER_B),
+ .__runtime.pipe_mask = BIT(PIPE_A) | BIT(PIPE_B),
+ .__runtime.cpu_transcoder_mask = BIT(TRANSCODER_A) | BIT(TRANSCODER_B),
.has_runtime_pm = 1,
.has_rc6 = 1,
.has_reset_engine = true,
@@ -547,7 +547,7 @@ static const struct intel_device_info vlv_info = {
#define G75_FEATURES \
GEN7_FEATURES, \
.__runtime.platform_engine_mask = BIT(RCS0) | BIT(VCS0) | BIT(BCS0) | BIT(VECS0), \
- .display.cpu_transcoder_mask = BIT(TRANSCODER_A) | BIT(TRANSCODER_B) | \
+ .__runtime.cpu_transcoder_mask = BIT(TRANSCODER_A) | BIT(TRANSCODER_B) | \
BIT(TRANSCODER_C) | BIT(TRANSCODER_EDP), \
.display.has_ddi = 1, \
.display.has_fpga_dbg = 1, \
@@ -617,8 +617,8 @@ static const struct intel_device_info bdw_gt3_info = {
static const struct intel_device_info chv_info = {
PLATFORM(INTEL_CHERRYVIEW),
GEN(8),
- .display.pipe_mask = BIT(PIPE_A) | BIT(PIPE_B) | BIT(PIPE_C),
- .display.cpu_transcoder_mask = BIT(TRANSCODER_A) | BIT(TRANSCODER_B) | BIT(TRANSCODER_C),
+ .__runtime.pipe_mask = BIT(PIPE_A) | BIT(PIPE_B) | BIT(PIPE_C),
+ .__runtime.cpu_transcoder_mask = BIT(TRANSCODER_A) | BIT(TRANSCODER_B) | BIT(TRANSCODER_C),
.display.has_hotplug = 1,
.is_lp = 1,
.__runtime.platform_engine_mask = BIT(RCS0) | BIT(VCS0) | BIT(BCS0) | BIT(VECS0),
@@ -695,8 +695,8 @@ static const struct intel_device_info skl_gt4_info = {
.dbuf.slice_mask = BIT(DBUF_S1), \
.display.has_hotplug = 1, \
.__runtime.platform_engine_mask = BIT(RCS0) | BIT(VCS0) | BIT(BCS0) | BIT(VECS0), \
- .display.pipe_mask = BIT(PIPE_A) | BIT(PIPE_B) | BIT(PIPE_C), \
- .display.cpu_transcoder_mask = BIT(TRANSCODER_A) | BIT(TRANSCODER_B) | \
+ .__runtime.pipe_mask = BIT(PIPE_A) | BIT(PIPE_B) | BIT(PIPE_C), \
+ .__runtime.cpu_transcoder_mask = BIT(TRANSCODER_A) | BIT(TRANSCODER_B) | \
BIT(TRANSCODER_C) | BIT(TRANSCODER_EDP) | \
BIT(TRANSCODER_DSI_A) | BIT(TRANSCODER_DSI_C), \
.has_3d_pipeline = 1, \
@@ -806,7 +806,7 @@ static const struct intel_device_info cml_gt2_info = {
GEN9_FEATURES, \
GEN11_DEFAULT_PAGE_SIZES, \
.display.abox_mask = BIT(0), \
- .display.cpu_transcoder_mask = BIT(TRANSCODER_A) | BIT(TRANSCODER_B) | \
+ .__runtime.cpu_transcoder_mask = BIT(TRANSCODER_A) | BIT(TRANSCODER_B) | \
BIT(TRANSCODER_C) | BIT(TRANSCODER_EDP) | \
BIT(TRANSCODER_DSI_0) | BIT(TRANSCODER_DSI_1), \
.pipe_offsets = { \
@@ -858,8 +858,8 @@ static const struct intel_device_info jsl_info = {
GEN11_FEATURES, \
GEN(12), \
.display.abox_mask = GENMASK(2, 1), \
- .display.pipe_mask = BIT(PIPE_A) | BIT(PIPE_B) | BIT(PIPE_C) | BIT(PIPE_D), \
- .display.cpu_transcoder_mask = BIT(TRANSCODER_A) | BIT(TRANSCODER_B) | \
+ .__runtime.pipe_mask = BIT(PIPE_A) | BIT(PIPE_B) | BIT(PIPE_C) | BIT(PIPE_D), \
+ .__runtime.cpu_transcoder_mask = BIT(TRANSCODER_A) | BIT(TRANSCODER_B) | \
BIT(TRANSCODER_C) | BIT(TRANSCODER_D) | \
BIT(TRANSCODER_DSI_0) | BIT(TRANSCODER_DSI_1), \
.pipe_offsets = { \
@@ -895,8 +895,8 @@ static const struct intel_device_info rkl_info = {
GEN12_FEATURES,
PLATFORM(INTEL_ROCKETLAKE),
.display.abox_mask = BIT(0),
- .display.pipe_mask = BIT(PIPE_A) | BIT(PIPE_B) | BIT(PIPE_C),
- .display.cpu_transcoder_mask = BIT(TRANSCODER_A) | BIT(TRANSCODER_B) |
+ .__runtime.pipe_mask = BIT(PIPE_A) | BIT(PIPE_B) | BIT(PIPE_C),
+ .__runtime.cpu_transcoder_mask = BIT(TRANSCODER_A) | BIT(TRANSCODER_B) |
BIT(TRANSCODER_C),
.display.has_hti = 1,
.display.has_psr_hw_tracking = 0,
@@ -917,7 +917,7 @@ static const struct intel_device_info dg1_info = {
DGFX_FEATURES,
.__runtime.graphics.rel = 10,
PLATFORM(INTEL_DG1),
- .display.pipe_mask = BIT(PIPE_A) | BIT(PIPE_B) | BIT(PIPE_C) | BIT(PIPE_D),
+ .__runtime.pipe_mask = BIT(PIPE_A) | BIT(PIPE_B) | BIT(PIPE_C) | BIT(PIPE_D),
.require_force_probe = 1,
.__runtime.platform_engine_mask =
BIT(RCS0) | BIT(BCS0) | BIT(VECS0) |
@@ -929,7 +929,7 @@ static const struct intel_device_info dg1_info = {
static const struct intel_device_info adl_s_info = {
GEN12_FEATURES,
PLATFORM(INTEL_ALDERLAKE_S),
- .display.pipe_mask = BIT(PIPE_A) | BIT(PIPE_B) | BIT(PIPE_C) | BIT(PIPE_D),
+ .__runtime.pipe_mask = BIT(PIPE_A) | BIT(PIPE_B) | BIT(PIPE_C) | BIT(PIPE_D),
.display.has_hti = 1,
.display.has_psr_hw_tracking = 0,
.__runtime.platform_engine_mask =
@@ -966,7 +966,7 @@ static const struct intel_device_info adl_s_info = {
.display.has_ipc = 1, \
.display.has_psr = 1, \
.display.ver = 13, \
- .display.pipe_mask = BIT(PIPE_A) | BIT(PIPE_B) | BIT(PIPE_C) | BIT(PIPE_D), \
+ .__runtime.pipe_mask = BIT(PIPE_A) | BIT(PIPE_B) | BIT(PIPE_C) | BIT(PIPE_D), \
.pipe_offsets = { \
[TRANSCODER_A] = PIPE_A_OFFSET, \
[TRANSCODER_B] = PIPE_B_OFFSET, \
@@ -989,7 +989,7 @@ static const struct intel_device_info adl_p_info = {
GEN12_FEATURES,
XE_LPD_FEATURES,
PLATFORM(INTEL_ALDERLAKE_P),
- .display.cpu_transcoder_mask = BIT(TRANSCODER_A) | BIT(TRANSCODER_B) |
+ .__runtime.cpu_transcoder_mask = BIT(TRANSCODER_A) | BIT(TRANSCODER_B) |
BIT(TRANSCODER_C) | BIT(TRANSCODER_D) |
BIT(TRANSCODER_DSI_0) | BIT(TRANSCODER_DSI_1),
.display.has_cdclk_crawl = 1,
@@ -1074,7 +1074,7 @@ static const struct intel_device_info xehpsdv_info = {
static const struct intel_device_info dg2_info = {
DG2_FEATURES,
XE_LPD_FEATURES,
- .display.cpu_transcoder_mask = BIT(TRANSCODER_A) | BIT(TRANSCODER_B) |
+ .__runtime.cpu_transcoder_mask = BIT(TRANSCODER_A) | BIT(TRANSCODER_B) |
BIT(TRANSCODER_C) | BIT(TRANSCODER_D),
.require_force_probe = 1,
};
diff --git a/drivers/gpu/drm/i915/intel_device_info.c b/drivers/gpu/drm/i915/intel_device_info.c
index 43fefcc52ef1..166d1d74b885 100644
--- a/drivers/gpu/drm/i915/intel_device_info.c
+++ b/drivers/gpu/drm/i915/intel_device_info.c
@@ -348,35 +348,35 @@ void intel_device_info_runtime_init(struct drm_i915_private *dev_priv)
!(sfuse_strap & SFUSE_STRAP_FUSE_LOCK))) {
drm_info(&dev_priv->drm,
"Display fused off, disabling\n");
- info->display.pipe_mask = 0;
- info->display.cpu_transcoder_mask = 0;
+ runtime->pipe_mask = 0;
+ runtime->cpu_transcoder_mask = 0;
runtime->fbc_mask = 0;
} else if (fuse_strap & IVB_PIPE_C_DISABLE) {
drm_info(&dev_priv->drm, "PipeC fused off\n");
- info->display.pipe_mask &= ~BIT(PIPE_C);
- info->display.cpu_transcoder_mask &= ~BIT(TRANSCODER_C);
+ runtime->pipe_mask &= ~BIT(PIPE_C);
+ runtime->cpu_transcoder_mask &= ~BIT(TRANSCODER_C);
}
} else if (HAS_DISPLAY(dev_priv) && DISPLAY_VER(dev_priv) >= 9) {
u32 dfsm = intel_de_read(dev_priv, SKL_DFSM);
if (dfsm & SKL_DFSM_PIPE_A_DISABLE) {
- info->display.pipe_mask &= ~BIT(PIPE_A);
- info->display.cpu_transcoder_mask &= ~BIT(TRANSCODER_A);
+ runtime->pipe_mask &= ~BIT(PIPE_A);
+ runtime->cpu_transcoder_mask &= ~BIT(TRANSCODER_A);
runtime->fbc_mask &= ~BIT(INTEL_FBC_A);
}
if (dfsm & SKL_DFSM_PIPE_B_DISABLE) {
- info->display.pipe_mask &= ~BIT(PIPE_B);
- info->display.cpu_transcoder_mask &= ~BIT(TRANSCODER_B);
+ runtime->pipe_mask &= ~BIT(PIPE_B);
+ runtime->cpu_transcoder_mask &= ~BIT(TRANSCODER_B);
}
if (dfsm & SKL_DFSM_PIPE_C_DISABLE) {
- info->display.pipe_mask &= ~BIT(PIPE_C);
- info->display.cpu_transcoder_mask &= ~BIT(TRANSCODER_C);
+ runtime->pipe_mask &= ~BIT(PIPE_C);
+ runtime->cpu_transcoder_mask &= ~BIT(TRANSCODER_C);
}
if (DISPLAY_VER(dev_priv) >= 12 &&
(dfsm & TGL_DFSM_PIPE_D_DISABLE)) {
- info->display.pipe_mask &= ~BIT(PIPE_D);
- info->display.cpu_transcoder_mask &= ~BIT(TRANSCODER_D);
+ runtime->pipe_mask &= ~BIT(PIPE_D);
+ runtime->cpu_transcoder_mask &= ~BIT(TRANSCODER_D);
}
if (dfsm & SKL_DFSM_DISPLAY_HDCP_DISABLE)
diff --git a/drivers/gpu/drm/i915/intel_device_info.h b/drivers/gpu/drm/i915/intel_device_info.h
index c354afd1c842..d78fe045a499 100644
--- a/drivers/gpu/drm/i915/intel_device_info.h
+++ b/drivers/gpu/drm/i915/intel_device_info.h
@@ -228,6 +228,9 @@ struct intel_runtime_info {
/* display */
struct {
+ u8 pipe_mask;
+ u8 cpu_transcoder_mask;
+
u8 num_sprites[I915_MAX_PIPES];
u8 num_scalers[I915_MAX_PIPES];
@@ -254,8 +257,6 @@ struct intel_device_info {
u8 ver;
u8 rel;
- u8 pipe_mask;
- u8 cpu_transcoder_mask;
u8 abox_mask;
#define DEFINE_FLAG(name) u8 name:1
--
2.30.2
^ permalink raw reply related [flat|nested] 29+ messages in thread
* [Intel-gfx] [PATCH 12/16] drm/i915: move has_hdcp to runtime info
2022-06-20 8:37 ` Jani Nikula
` (11 preceding siblings ...)
(?)
@ 2022-06-20 8:49 ` Jani Nikula
-1 siblings, 0 replies; 29+ messages in thread
From: Jani Nikula @ 2022-06-20 8:49 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
If it's modified runtime, it's runtime info.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/display/intel_hdcp.c | 4 ++--
drivers/gpu/drm/i915/i915_pci.c | 6 +++---
drivers/gpu/drm/i915/intel_device_info.c | 4 +++-
drivers/gpu/drm/i915/intel_device_info.h | 3 ++-
4 files changed, 10 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/drivers/gpu/drm/i915/display/intel_hdcp.c
index 8ea66a2e1b09..123aecde7a2a 100644
--- a/drivers/gpu/drm/i915/display/intel_hdcp.c
+++ b/drivers/gpu/drm/i915/display/intel_hdcp.c
@@ -1109,8 +1109,8 @@ static void intel_hdcp_prop_work(struct work_struct *work)
bool is_hdcp_supported(struct drm_i915_private *dev_priv, enum port port)
{
- return INTEL_INFO(dev_priv)->display.has_hdcp &&
- (DISPLAY_VER(dev_priv) >= 12 || port < PORT_E);
+ return RUNTIME_INFO(dev_priv)->has_hdcp &&
+ (DISPLAY_VER(dev_priv) >= 12 || port < PORT_E);
}
static int
diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
index e9e036bec732..11c236b6a017 100644
--- a/drivers/gpu/drm/i915/i915_pci.c
+++ b/drivers/gpu/drm/i915/i915_pci.c
@@ -652,7 +652,7 @@ static const struct intel_device_info chv_info = {
GEN9_DEFAULT_PAGE_SIZES, \
.display.has_dmc = 1, \
.has_gt_uc = 1, \
- .display.has_hdcp = 1, \
+ .__runtime.has_hdcp = 1, \
.display.has_ipc = 1, \
.display.has_psr = 1, \
.display.has_psr_hw_tracking = 1, \
@@ -704,7 +704,7 @@ static const struct intel_device_info skl_gt4_info = {
.display.has_ddi = 1, \
.display.has_fpga_dbg = 1, \
.__runtime.fbc_mask = BIT(INTEL_FBC_A), \
- .display.has_hdcp = 1, \
+ .__runtime.has_hdcp = 1, \
.display.has_psr = 1, \
.display.has_psr_hw_tracking = 1, \
.has_runtime_pm = 1, \
@@ -961,7 +961,7 @@ static const struct intel_device_info adl_s_info = {
.display.has_dsc = 1, \
.__runtime.fbc_mask = BIT(INTEL_FBC_A), \
.display.has_fpga_dbg = 1, \
- .display.has_hdcp = 1, \
+ .__runtime.has_hdcp = 1, \
.display.has_hotplug = 1, \
.display.has_ipc = 1, \
.display.has_psr = 1, \
diff --git a/drivers/gpu/drm/i915/intel_device_info.c b/drivers/gpu/drm/i915/intel_device_info.c
index 166d1d74b885..26c883c05e44 100644
--- a/drivers/gpu/drm/i915/intel_device_info.c
+++ b/drivers/gpu/drm/i915/intel_device_info.c
@@ -125,6 +125,8 @@ void intel_device_info_print(const struct intel_device_info *info,
DEV_INFO_DISPLAY_FOR_EACH_FLAG(PRINT_FLAG);
#undef PRINT_FLAG
+ drm_printf(p, "has_hdcp: %s\n", str_yes_no(runtime->has_hdcp));
+
drm_printf(p, "rawclk rate: %u kHz\n", runtime->rawclk_freq);
}
@@ -380,7 +382,7 @@ void intel_device_info_runtime_init(struct drm_i915_private *dev_priv)
}
if (dfsm & SKL_DFSM_DISPLAY_HDCP_DISABLE)
- info->display.has_hdcp = 0;
+ runtime->has_hdcp = 0;
if (dfsm & SKL_DFSM_DISPLAY_PM_DISABLE)
runtime->fbc_mask = 0;
diff --git a/drivers/gpu/drm/i915/intel_device_info.h b/drivers/gpu/drm/i915/intel_device_info.h
index d78fe045a499..76317db394b7 100644
--- a/drivers/gpu/drm/i915/intel_device_info.h
+++ b/drivers/gpu/drm/i915/intel_device_info.h
@@ -180,7 +180,6 @@ enum intel_ppgtt_type {
func(has_dsc); \
func(has_fpga_dbg); \
func(has_gmch); \
- func(has_hdcp); \
func(has_hotplug); \
func(has_hti); \
func(has_ipc); \
@@ -235,6 +234,8 @@ struct intel_runtime_info {
u8 num_scalers[I915_MAX_PIPES];
u8 fbc_mask;
+
+ bool has_hdcp;
};
};
--
2.30.2
^ permalink raw reply related [flat|nested] 29+ messages in thread
* [Intel-gfx] [PATCH 13/16] drm/i915: move has_dmc to runtime info
2022-06-20 8:37 ` Jani Nikula
` (12 preceding siblings ...)
(?)
@ 2022-06-20 8:49 ` Jani Nikula
-1 siblings, 0 replies; 29+ messages in thread
From: Jani Nikula @ 2022-06-20 8:49 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
If it's modified runtime, it's runtime info.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/i915_drv.h | 2 +-
drivers/gpu/drm/i915/i915_pci.c | 6 +++---
drivers/gpu/drm/i915/intel_device_info.c | 3 ++-
drivers/gpu/drm/i915/intel_device_info.h | 2 +-
4 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 5bb1f0e9368c..89472440947c 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -1267,7 +1267,7 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915,
#define HAS_RPS(dev_priv) (INTEL_INFO(dev_priv)->has_rps)
-#define HAS_DMC(dev_priv) (INTEL_INFO(dev_priv)->display.has_dmc)
+#define HAS_DMC(dev_priv) (RUNTIME_INFO(dev_priv)->has_dmc)
#define HAS_HECI_PXP(dev_priv) \
(INTEL_INFO(dev_priv)->has_heci_pxp)
diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
index 11c236b6a017..c6637a4982ed 100644
--- a/drivers/gpu/drm/i915/i915_pci.c
+++ b/drivers/gpu/drm/i915/i915_pci.c
@@ -650,7 +650,7 @@ static const struct intel_device_info chv_info = {
GEN8_FEATURES, \
GEN(9), \
GEN9_DEFAULT_PAGE_SIZES, \
- .display.has_dmc = 1, \
+ .__runtime.has_dmc = 1, \
.has_gt_uc = 1, \
.__runtime.has_hdcp = 1, \
.display.has_ipc = 1, \
@@ -708,7 +708,7 @@ static const struct intel_device_info skl_gt4_info = {
.display.has_psr = 1, \
.display.has_psr_hw_tracking = 1, \
.has_runtime_pm = 1, \
- .display.has_dmc = 1, \
+ .__runtime.has_dmc = 1, \
.has_rc6 = 1, \
.has_rps = true, \
.display.has_dp_mst = 1, \
@@ -955,7 +955,7 @@ static const struct intel_device_info adl_s_info = {
.dbuf.slice_mask = BIT(DBUF_S1) | BIT(DBUF_S2) | BIT(DBUF_S3) | \
BIT(DBUF_S4), \
.display.has_ddi = 1, \
- .display.has_dmc = 1, \
+ .__runtime.has_dmc = 1, \
.display.has_dp_mst = 1, \
.display.has_dsb = 1, \
.display.has_dsc = 1, \
diff --git a/drivers/gpu/drm/i915/intel_device_info.c b/drivers/gpu/drm/i915/intel_device_info.c
index 26c883c05e44..ed5ad5c60db6 100644
--- a/drivers/gpu/drm/i915/intel_device_info.c
+++ b/drivers/gpu/drm/i915/intel_device_info.c
@@ -126,6 +126,7 @@ void intel_device_info_print(const struct intel_device_info *info,
#undef PRINT_FLAG
drm_printf(p, "has_hdcp: %s\n", str_yes_no(runtime->has_hdcp));
+ drm_printf(p, "has_dmc: %s\n", str_yes_no(runtime->has_dmc));
drm_printf(p, "rawclk rate: %u kHz\n", runtime->rawclk_freq);
}
@@ -388,7 +389,7 @@ void intel_device_info_runtime_init(struct drm_i915_private *dev_priv)
runtime->fbc_mask = 0;
if (DISPLAY_VER(dev_priv) >= 11 && (dfsm & ICL_DFSM_DMC_DISABLE))
- info->display.has_dmc = 0;
+ runtime->has_dmc = 0;
if (DISPLAY_VER(dev_priv) >= 10 &&
(dfsm & GLK_DFSM_DISPLAY_DSC_DISABLE))
diff --git a/drivers/gpu/drm/i915/intel_device_info.h b/drivers/gpu/drm/i915/intel_device_info.h
index 76317db394b7..0a3c925d02b7 100644
--- a/drivers/gpu/drm/i915/intel_device_info.h
+++ b/drivers/gpu/drm/i915/intel_device_info.h
@@ -173,7 +173,6 @@ enum intel_ppgtt_type {
/* Keep in alphabetical order */ \
func(cursor_needs_physical); \
func(has_cdclk_crawl); \
- func(has_dmc); \
func(has_ddi); \
func(has_dp_mst); \
func(has_dsb); \
@@ -236,6 +235,7 @@ struct intel_runtime_info {
u8 fbc_mask;
bool has_hdcp;
+ bool has_dmc;
};
};
--
2.30.2
^ permalink raw reply related [flat|nested] 29+ messages in thread
* [Intel-gfx] [PATCH 14/16] drm/i915: move has_dsc to runtime info
2022-06-20 8:37 ` Jani Nikula
` (13 preceding siblings ...)
(?)
@ 2022-06-20 8:49 ` Jani Nikula
-1 siblings, 0 replies; 29+ messages in thread
From: Jani Nikula @ 2022-06-20 8:49 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
If it's modified runtime, it's runtime info.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/display/intel_vdsc.c | 2 +-
drivers/gpu/drm/i915/i915_pci.c | 4 ++--
drivers/gpu/drm/i915/intel_device_info.c | 3 ++-
drivers/gpu/drm/i915/intel_device_info.h | 2 +-
4 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_vdsc.c b/drivers/gpu/drm/i915/display/intel_vdsc.c
index 43e1bbc1e303..bb5c5fa3f157 100644
--- a/drivers/gpu/drm/i915/display/intel_vdsc.c
+++ b/drivers/gpu/drm/i915/display/intel_vdsc.c
@@ -344,7 +344,7 @@ bool intel_dsc_source_support(const struct intel_crtc_state *crtc_state)
struct drm_i915_private *i915 = to_i915(crtc->base.dev);
enum transcoder cpu_transcoder = crtc_state->cpu_transcoder;
- if (!INTEL_INFO(i915)->display.has_dsc)
+ if (!RUNTIME_INFO(i915)->has_dsc)
return false;
if (DISPLAY_VER(i915) >= 12)
diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
index c6637a4982ed..687b49549d13 100644
--- a/drivers/gpu/drm/i915/i915_pci.c
+++ b/drivers/gpu/drm/i915/i915_pci.c
@@ -829,7 +829,7 @@ static const struct intel_device_info cml_gt2_info = {
ICL_COLORS, \
.dbuf.size = 2048, \
.dbuf.slice_mask = BIT(DBUF_S1) | BIT(DBUF_S2), \
- .display.has_dsc = 1, \
+ .__runtime.has_dsc = 1, \
.has_coherent_ggtt = false, \
.has_logical_ring_elsq = 1
@@ -958,7 +958,7 @@ static const struct intel_device_info adl_s_info = {
.__runtime.has_dmc = 1, \
.display.has_dp_mst = 1, \
.display.has_dsb = 1, \
- .display.has_dsc = 1, \
+ .__runtime.has_dsc = 1, \
.__runtime.fbc_mask = BIT(INTEL_FBC_A), \
.display.has_fpga_dbg = 1, \
.__runtime.has_hdcp = 1, \
diff --git a/drivers/gpu/drm/i915/intel_device_info.c b/drivers/gpu/drm/i915/intel_device_info.c
index ed5ad5c60db6..12c776900a40 100644
--- a/drivers/gpu/drm/i915/intel_device_info.c
+++ b/drivers/gpu/drm/i915/intel_device_info.c
@@ -127,6 +127,7 @@ void intel_device_info_print(const struct intel_device_info *info,
drm_printf(p, "has_hdcp: %s\n", str_yes_no(runtime->has_hdcp));
drm_printf(p, "has_dmc: %s\n", str_yes_no(runtime->has_dmc));
+ drm_printf(p, "has_dsc: %s\n", str_yes_no(runtime->has_dsc));
drm_printf(p, "rawclk rate: %u kHz\n", runtime->rawclk_freq);
}
@@ -393,7 +394,7 @@ void intel_device_info_runtime_init(struct drm_i915_private *dev_priv)
if (DISPLAY_VER(dev_priv) >= 10 &&
(dfsm & GLK_DFSM_DISPLAY_DSC_DISABLE))
- info->display.has_dsc = 0;
+ runtime->has_dsc = 0;
}
if (GRAPHICS_VER(dev_priv) == 6 && i915_vtd_active(dev_priv)) {
diff --git a/drivers/gpu/drm/i915/intel_device_info.h b/drivers/gpu/drm/i915/intel_device_info.h
index 0a3c925d02b7..daeaaad325b7 100644
--- a/drivers/gpu/drm/i915/intel_device_info.h
+++ b/drivers/gpu/drm/i915/intel_device_info.h
@@ -176,7 +176,6 @@ enum intel_ppgtt_type {
func(has_ddi); \
func(has_dp_mst); \
func(has_dsb); \
- func(has_dsc); \
func(has_fpga_dbg); \
func(has_gmch); \
func(has_hotplug); \
@@ -236,6 +235,7 @@ struct intel_runtime_info {
bool has_hdcp;
bool has_dmc;
+ bool has_dsc;
};
};
--
2.30.2
^ permalink raw reply related [flat|nested] 29+ messages in thread
* [Intel-gfx] [PATCH 15/16] drm/i915: stop resetting display info to zero for no display
2022-06-20 8:37 ` Jani Nikula
` (14 preceding siblings ...)
(?)
@ 2022-06-20 8:49 ` Jani Nikula
-1 siblings, 0 replies; 29+ messages in thread
From: Jani Nikula @ 2022-06-20 8:49 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
This is the last blocker in making device info a pointer to const
data. Hopefully resetting pipe_mask to 0 and thus ensuring HAS_DISPLAY()
is false is enough, and we don't go ahead and do something with the
display info regardless. Fingers crossed.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/intel_device_info.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_device_info.c b/drivers/gpu/drm/i915/intel_device_info.c
index 12c776900a40..84e6a54c82ff 100644
--- a/drivers/gpu/drm/i915/intel_device_info.c
+++ b/drivers/gpu/drm/i915/intel_device_info.c
@@ -283,7 +283,6 @@ void intel_device_info_subplatform_init(struct drm_i915_private *i915)
*/
void intel_device_info_runtime_init(struct drm_i915_private *dev_priv)
{
- struct intel_device_info *info = mkwrite_device_info(dev_priv);
struct intel_runtime_info *runtime = RUNTIME_INFO(dev_priv);
enum pipe pipe;
@@ -409,7 +408,6 @@ void intel_device_info_runtime_init(struct drm_i915_private *dev_priv)
if (!HAS_DISPLAY(dev_priv)) {
dev_priv->drm.driver_features &= ~(DRIVER_MODESET |
DRIVER_ATOMIC);
- memset(&info->display, 0, sizeof(info->display));
memset(runtime->num_sprites, 0, sizeof(runtime->num_sprites));
memset(runtime->num_scalers, 0, sizeof(runtime->num_scalers));
}
--
2.30.2
^ permalink raw reply related [flat|nested] 29+ messages in thread
* [Intel-gfx] [PATCH 16/16] drm/i915: make device info a pointer to static const data
2022-06-20 8:37 ` Jani Nikula
` (15 preceding siblings ...)
(?)
@ 2022-06-20 8:49 ` Jani Nikula
2022-08-18 9:57 ` Maarten Lankhorst
-1 siblings, 1 reply; 29+ messages in thread
From: Jani Nikula @ 2022-06-20 8:49 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
Now that the device info is no longer modified runtime, we don't need to
make a copy of it, and we can convert i915->__info into a pointer to
static const data. Also remove mkwrite_device_info().
This does increase the text size slightly.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
An alternative is to keep copying device info, but casting away the
const only once at the copy time, removing mkwrite_device_info().
---
drivers/gpu/drm/i915/i915_driver.c | 8 ++------
drivers/gpu/drm/i915/i915_drv.h | 11 ++---------
2 files changed, 4 insertions(+), 15 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_driver.c b/drivers/gpu/drm/i915/i915_driver.c
index 5969cc7805d3..9c9c492e97a8 100644
--- a/drivers/gpu/drm/i915/i915_driver.c
+++ b/drivers/gpu/drm/i915/i915_driver.c
@@ -793,9 +793,6 @@ static void i915_welcome_messages(struct drm_i915_private *dev_priv)
static struct drm_i915_private *
i915_driver_create(struct pci_dev *pdev, const struct pci_device_id *ent)
{
- const struct intel_device_info *match_info =
- (struct intel_device_info *)ent->driver_data;
- struct intel_device_info *device_info;
struct intel_runtime_info *runtime;
struct drm_i915_private *i915;
@@ -809,9 +806,8 @@ i915_driver_create(struct pci_dev *pdev, const struct pci_device_id *ent)
/* Device parameters start as a copy of module parameters. */
i915_params_copy(&i915->params, &i915_modparams);
- /* Setup the write-once "constant" device info */
- device_info = mkwrite_device_info(i915);
- memcpy(device_info, match_info, sizeof(*device_info));
+ /* Static const device info. */
+ i915->__info = (const struct intel_device_info *)ent->driver_data;
/* Initialize initial runtime info from static const data and pdev. */
runtime = RUNTIME_INFO(i915);
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 89472440947c..a2a57f07c5be 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -380,7 +380,7 @@ struct drm_i915_private {
/* i915 device parameters */
struct i915_params params;
- const struct intel_device_info __info; /* Use INTEL_INFO() to access. */
+ const struct intel_device_info *__info; /* Use INTEL_INFO() to access. */
struct intel_runtime_info __runtime; /* Use RUNTIME_INFO() to access. */
struct intel_driver_caps caps;
@@ -848,7 +848,7 @@ static inline struct intel_gt *to_gt(struct drm_i915_private *i915)
GENMASK(INTEL_FRONTBUFFER_BITS_PER_PIPE * ((pipe) + 1) - 1, \
INTEL_FRONTBUFFER_BITS_PER_PIPE * (pipe))
-#define INTEL_INFO(dev_priv) (&(dev_priv)->__info)
+#define INTEL_INFO(__i915) (__i915->__info)
#define RUNTIME_INFO(dev_priv) (&(dev_priv)->__runtime)
#define DRIVER_CAPS(dev_priv) (&(dev_priv)->caps)
@@ -1432,13 +1432,6 @@ void i915_gem_driver_release(struct drm_i915_private *dev_priv);
int i915_gem_open(struct drm_i915_private *i915, struct drm_file *file);
-/* intel_device_info.c */
-static inline struct intel_device_info *
-mkwrite_device_info(struct drm_i915_private *dev_priv)
-{
- return (struct intel_device_info *)INTEL_INFO(dev_priv);
-}
-
static inline enum i915_map_type
i915_coherent_map_type(struct drm_i915_private *i915,
struct drm_i915_gem_object *obj, bool always_coherent)
--
2.30.2
^ permalink raw reply related [flat|nested] 29+ messages in thread
* Re: [Intel-gfx] [PATCH 00/16] drm/i915: stop modifying "const" device info
2022-06-20 8:37 ` Jani Nikula
` (16 preceding siblings ...)
(?)
@ 2022-06-20 8:54 ` Jani Nikula
-1 siblings, 0 replies; 29+ messages in thread
From: Jani Nikula @ 2022-06-20 8:54 UTC (permalink / raw)
To: intel-gfx
On Mon, 20 Jun 2022, Jani Nikula <jani.nikula@intel.com> wrote:
> Move any device info that gets modified runtime into runtime info,
> making device info a const pointer. Finally throw mkwrite_device_info()
> into the curb.
Had some SMTP issues sending this series, sorry if you got multiple
copies of some patches.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 29+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: stop modifying "const" device info
2022-06-20 8:37 ` Jani Nikula
` (17 preceding siblings ...)
(?)
@ 2022-06-20 14:16 ` Patchwork
-1 siblings, 0 replies; 29+ messages in thread
From: Patchwork @ 2022-06-20 14:16 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: stop modifying "const" device info
URL : https://patchwork.freedesktop.org/series/105358/
State : warning
== Summary ==
Error: dim checkpatch failed
0c57ec003486 drm/i915: use GRAPHICS_VER() instead of accessing match_info directly
596a710de9af drm/i915: combine device info printing into one
27dda2c69a5b drm/i915: add initial runtime info into device info
-:50: WARNING:REPEATED_WORD: Possible repeated word: 'into'
#50: FILE: drivers/gpu/drm/i915/intel_device_info.h:203:
+ * Platform mask is used for optimizing or-ed IS_PLATFORM calls into
+ * into single runtime conditionals, and also to provide groundwork
total: 0 errors, 1 warnings, 0 checks, 75 lines checked
f2624b41fbe2 drm/i915: move fbc_mask to runtime info
efa469b40f22 drm/i915: move page_sizes to runtime info
340a168b80a7 drm/i915: move ppgtt_type and ppgtt_size to runtime info
f709762facd3 drm/i915: move has_pooled_eu to runtime info
991edfbbdf6d drm/i915: move memory_regions to runtime info
6f6f368ead3b drm/i915: move platform_engine_mask to runtime info
e72012a41c6b drm/i915: move graphics.ver and graphics.rel to runtime info
-:25: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects?
#25: FILE: drivers/gpu/drm/i915/i915_drv.h:860:
+#define GRAPHICS_VER_FULL(i915) IP_VER(RUNTIME_INFO(i915)->graphics.ver, \
+ RUNTIME_INFO(i915)->graphics.rel)
total: 0 errors, 0 warnings, 1 checks, 92 lines checked
6b83e911add8 drm/i915: move pipe_mask and cpu_transcoder_mask to runtime info
-:29: WARNING:SPACING: space prohibited between function name and open parenthesis '('
#29: FILE: drivers/gpu/drm/i915/display/intel_display.h:385:
+ for_each_if (RUNTIME_INFO(__dev_priv)->cpu_transcoder_mask & BIT(__t))
-:42: WARNING:LONG_LINE: line length of 106 exceeds 100 columns
#42: FILE: drivers/gpu/drm/i915/i915_drv.h:1262:
+#define HAS_TRANSCODER(dev_priv, trans) ((RUNTIME_INFO(dev_priv)->cpu_transcoder_mask & BIT(trans)) != 0)
-:135: WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#135: FILE: drivers/gpu/drm/i915/i915_pci.c:461:
+ .__runtime.cpu_transcoder_mask = BIT(TRANSCODER_A) | BIT(TRANSCODER_B) | BIT(TRANSCODER_C), \
total: 0 errors, 3 warnings, 0 checks, 285 lines checked
da3bd5bf69ed drm/i915: move has_hdcp to runtime info
ad747f8e7763 drm/i915: move has_dmc to runtime info
fb508a532365 drm/i915: move has_dsc to runtime info
69828fb97c44 drm/i915: stop resetting display info to zero for no display
66cd29e28b96 drm/i915: make device info a pointer to static const data
-:58: CHECK:MACRO_ARG_PRECEDENCE: Macro argument '__i915' may be better as '(__i915)' to avoid precedence issues
#58: FILE: drivers/gpu/drm/i915/i915_drv.h:851:
+#define INTEL_INFO(__i915) (__i915->__info)
total: 0 errors, 0 warnings, 1 checks, 49 lines checked
^ permalink raw reply [flat|nested] 29+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: stop modifying "const" device info
2022-06-20 8:37 ` Jani Nikula
` (18 preceding siblings ...)
(?)
@ 2022-06-20 14:43 ` Patchwork
-1 siblings, 0 replies; 29+ messages in thread
From: Patchwork @ 2022-06-20 14:43 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 15934 bytes --]
== Series Details ==
Series: drm/i915: stop modifying "const" device info
URL : https://patchwork.freedesktop.org/series/105358/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11780 -> Patchwork_105358v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/index.html
Participating hosts (42 -> 42)
------------------------------
Additional (2): fi-kbl-soraka bat-dg2-8
Missing (2): bat-jsl-2 fi-icl-u2
Known issues
------------
Here are the changes found in Patchwork_105358v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_huc_copy@huc-copy:
- fi-kbl-soraka: NOTRUN -> [SKIP][1] ([fdo#109271] / [i915#2190])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@basic:
- fi-kbl-soraka: NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#4613]) +3 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/fi-kbl-soraka/igt@gem_lmem_swapping@basic.html
* igt@i915_selftest@live@execlists:
- fi-bsw-n3050: [PASS][3] -> [INCOMPLETE][4] ([i915#2940])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/fi-bsw-n3050/igt@i915_selftest@live@execlists.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/fi-bsw-n3050/igt@i915_selftest@live@execlists.html
* igt@i915_selftest@live@gem_contexts:
- fi-bdw-5557u: [PASS][5] -> [INCOMPLETE][6] ([i915#5502])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/fi-bdw-5557u/igt@i915_selftest@live@gem_contexts.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/fi-bdw-5557u/igt@i915_selftest@live@gem_contexts.html
* igt@i915_selftest@live@gt_engines:
- bat-dg1-6: [PASS][7] -> [INCOMPLETE][8] ([i915#4418])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/bat-dg1-6/igt@i915_selftest@live@gt_engines.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/bat-dg1-6/igt@i915_selftest@live@gt_engines.html
* igt@i915_selftest@live@gt_pm:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][9] ([i915#1886])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html
* igt@i915_selftest@live@late_gt_pm:
- fi-bsw-nick: [PASS][10] -> [DMESG-FAIL][11] ([i915#3428])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/fi-bsw-nick/igt@i915_selftest@live@late_gt_pm.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/fi-bsw-nick/igt@i915_selftest@live@late_gt_pm.html
* igt@i915_selftest@live@requests:
- fi-pnv-d510: [PASS][12] -> [DMESG-FAIL][13] ([i915#4528])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/fi-pnv-d510/igt@i915_selftest@live@requests.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/fi-pnv-d510/igt@i915_selftest@live@requests.html
* igt@i915_suspend@basic-s2idle-without-i915:
- fi-bdw-gvtdvm: NOTRUN -> [INCOMPLETE][14] ([i915#4817])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/fi-bdw-gvtdvm/igt@i915_suspend@basic-s2idle-without-i915.html
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-hsw-g3258: NOTRUN -> [SKIP][15] ([fdo#109271] / [fdo#111827])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/fi-hsw-g3258/igt@kms_chamelium@common-hpd-after-suspend.html
- fi-snb-2600: NOTRUN -> [SKIP][16] ([fdo#109271] / [fdo#111827])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/fi-snb-2600/igt@kms_chamelium@common-hpd-after-suspend.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-bdw-gvtdvm: NOTRUN -> [SKIP][17] ([fdo#109271] / [fdo#111827]) +7 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/fi-bdw-gvtdvm/igt@kms_chamelium@hdmi-hpd-fast.html
- fi-kbl-soraka: NOTRUN -> [SKIP][18] ([fdo#109271] / [fdo#111827]) +7 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/fi-kbl-soraka/igt@kms_chamelium@hdmi-hpd-fast.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-kbl-soraka: NOTRUN -> [SKIP][19] ([fdo#109271]) +9 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/fi-kbl-soraka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
* igt@kms_flip@basic-flip-vs-modeset@a-edp1:
- fi-tgl-u2: [PASS][20] -> [DMESG-WARN][21] ([i915#402]) +2 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/fi-tgl-u2/igt@kms_flip@basic-flip-vs-modeset@a-edp1.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/fi-tgl-u2/igt@kms_flip@basic-flip-vs-modeset@a-edp1.html
* igt@kms_flip@basic-flip-vs-modeset@b-edp1:
- bat-adlp-4: [PASS][22] -> [DMESG-WARN][23] ([i915#3576])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/bat-adlp-4/igt@kms_flip@basic-flip-vs-modeset@b-edp1.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/bat-adlp-4/igt@kms_flip@basic-flip-vs-modeset@b-edp1.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c:
- fi-bdw-gvtdvm: NOTRUN -> [SKIP][24] ([fdo#109271]) +47 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/fi-bdw-gvtdvm/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- fi-kbl-soraka: NOTRUN -> [SKIP][25] ([fdo#109271] / [i915#533])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/fi-kbl-soraka/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
* igt@runner@aborted:
- fi-bsw-n3050: NOTRUN -> [FAIL][26] ([fdo#109271] / [i915#3428] / [i915#4312])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/fi-bsw-n3050/igt@runner@aborted.html
- fi-bsw-nick: NOTRUN -> [FAIL][27] ([fdo#109271] / [i915#3428] / [i915#4312])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/fi-bsw-nick/igt@runner@aborted.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s0@smem:
- {fi-ehl-2}: [DMESG-WARN][28] ([i915#5122]) -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/fi-ehl-2/igt@gem_exec_suspend@basic-s0@smem.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/fi-ehl-2/igt@gem_exec_suspend@basic-s0@smem.html
* igt@i915_module_load@load:
- {bat-jsl-1}: [SKIP][30] ([i915#6227]) -> [PASS][31]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/bat-jsl-1/igt@i915_module_load@load.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/bat-jsl-1/igt@i915_module_load@load.html
- bat-dg1-5: [SKIP][32] ([i915#6227]) -> [PASS][33]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/bat-dg1-5/igt@i915_module_load@load.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/bat-dg1-5/igt@i915_module_load@load.html
- {bat-dg2-9}: [SKIP][34] ([i915#6227]) -> [PASS][35]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/bat-dg2-9/igt@i915_module_load@load.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/bat-dg2-9/igt@i915_module_load@load.html
- {bat-adlp-6}: [SKIP][36] ([i915#6227]) -> [PASS][37]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/bat-adlp-6/igt@i915_module_load@load.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/bat-adlp-6/igt@i915_module_load@load.html
- bat-dg1-6: [SKIP][38] ([i915#6227]) -> [PASS][39]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/bat-dg1-6/igt@i915_module_load@load.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/bat-dg1-6/igt@i915_module_load@load.html
- bat-adlp-4: [SKIP][40] ([i915#6227]) -> [PASS][41]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/bat-adlp-4/igt@i915_module_load@load.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/bat-adlp-4/igt@i915_module_load@load.html
* igt@i915_selftest@live@evict:
- {bat-dg2-9}: [DMESG-WARN][42] ([i915#5763]) -> [PASS][43] +3 similar issues
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/bat-dg2-9/igt@i915_selftest@live@evict.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/bat-dg2-9/igt@i915_selftest@live@evict.html
* igt@i915_selftest@live@gt_heartbeat:
- fi-skl-6700k2: [DMESG-FAIL][44] ([i915#5334]) -> [PASS][45]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/fi-skl-6700k2/igt@i915_selftest@live@gt_heartbeat.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/fi-skl-6700k2/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_selftest@live@hangcheck:
- fi-hsw-g3258: [INCOMPLETE][46] ([i915#4785]) -> [PASS][47]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/fi-hsw-g3258/igt@i915_selftest@live@hangcheck.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/fi-hsw-g3258/igt@i915_selftest@live@hangcheck.html
- bat-dg1-5: [DMESG-FAIL][48] ([i915#4494] / [i915#4957]) -> [PASS][49]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/bat-dg1-5/igt@i915_selftest@live@hangcheck.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/bat-dg1-5/igt@i915_selftest@live@hangcheck.html
- fi-snb-2600: [INCOMPLETE][50] ([i915#3921]) -> [PASS][51]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/fi-snb-2600/igt@i915_selftest@live@hangcheck.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/fi-snb-2600/igt@i915_selftest@live@hangcheck.html
* igt@kms_busy@basic@modeset:
- bat-adlp-4: [DMESG-WARN][52] ([i915#3576]) -> [PASS][53]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/bat-adlp-4/igt@kms_busy@basic@modeset.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/bat-adlp-4/igt@kms_busy@basic@modeset.html
- fi-tgl-u2: [DMESG-WARN][54] ([i915#402]) -> [PASS][55]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/fi-tgl-u2/igt@kms_busy@basic@modeset.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/fi-tgl-u2/igt@kms_busy@basic@modeset.html
* igt@kms_flip@basic-flip-vs-modeset@a-edp1:
- {bat-adlp-6}: [DMESG-WARN][56] ([i915#3576]) -> [PASS][57]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/bat-adlp-6/igt@kms_flip@basic-flip-vs-modeset@a-edp1.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/bat-adlp-6/igt@kms_flip@basic-flip-vs-modeset@a-edp1.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2940]: https://gitlab.freedesktop.org/drm/intel/issues/2940
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3428]: https://gitlab.freedesktop.org/drm/intel/issues/3428
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3576]: https://gitlab.freedesktop.org/drm/intel/issues/3576
[i915#3595]: https://gitlab.freedesktop.org/drm/intel/issues/3595
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4418]: https://gitlab.freedesktop.org/drm/intel/issues/4418
[i915#4494]: https://gitlab.freedesktop.org/drm/intel/issues/4494
[i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785
[i915#4817]: https://gitlab.freedesktop.org/drm/intel/issues/4817
[i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873
[i915#4957]: https://gitlab.freedesktop.org/drm/intel/issues/4957
[i915#5122]: https://gitlab.freedesktop.org/drm/intel/issues/5122
[i915#5174]: https://gitlab.freedesktop.org/drm/intel/issues/5174
[i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
[i915#5270]: https://gitlab.freedesktop.org/drm/intel/issues/5270
[i915#5274]: https://gitlab.freedesktop.org/drm/intel/issues/5274
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5356]: https://gitlab.freedesktop.org/drm/intel/issues/5356
[i915#5502]: https://gitlab.freedesktop.org/drm/intel/issues/5502
[i915#5763]: https://gitlab.freedesktop.org/drm/intel/issues/5763
[i915#5885]: https://gitlab.freedesktop.org/drm/intel/issues/5885
[i915#6227]: https://gitlab.freedesktop.org/drm/intel/issues/6227
Build changes
-------------
* Linux: CI_DRM_11780 -> Patchwork_105358v1
CI-20190529: 20190529
CI_DRM_11780: e3c663c58e5fe6f5dc29ab062c7eea2540f42e1e @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6537: 331658a8475c8b0c0f7ffe5268a7318ef83da34e @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_105358v1: e3c663c58e5fe6f5dc29ab062c7eea2540f42e1e @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
7a7b8e9f4ce9 drm/i915: make device info a pointer to static const data
cedb4af8b241 drm/i915: stop resetting display info to zero for no display
d478de6a1adc drm/i915: move has_dsc to runtime info
6a03fb411629 drm/i915: move has_dmc to runtime info
3d29b58c379d drm/i915: move has_hdcp to runtime info
9c9785228c00 drm/i915: move pipe_mask and cpu_transcoder_mask to runtime info
15635e655b8f drm/i915: move graphics.ver and graphics.rel to runtime info
8090c4862efc drm/i915: move platform_engine_mask to runtime info
bace29d7f070 drm/i915: move memory_regions to runtime info
563e342cddf6 drm/i915: move has_pooled_eu to runtime info
d3e2fb331a4b drm/i915: move ppgtt_type and ppgtt_size to runtime info
251c7c0e666e drm/i915: move page_sizes to runtime info
24be65531af4 drm/i915: move fbc_mask to runtime info
7605c41250a4 drm/i915: add initial runtime info into device info
d36f60342755 drm/i915: combine device info printing into one
e08820d8e18f drm/i915: use GRAPHICS_VER() instead of accessing match_info directly
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/index.html
[-- Attachment #2: Type: text/html, Size: 17376 bytes --]
^ permalink raw reply [flat|nested] 29+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: stop modifying "const" device info
2022-06-20 8:37 ` Jani Nikula
` (19 preceding siblings ...)
(?)
@ 2022-06-20 19:45 ` Patchwork
-1 siblings, 0 replies; 29+ messages in thread
From: Patchwork @ 2022-06-20 19:45 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 70052 bytes --]
== Series Details ==
Series: drm/i915: stop modifying "const" device info
URL : https://patchwork.freedesktop.org/series/105358/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11780_full -> Patchwork_105358v1_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_105358v1_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_105358v1_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Participating hosts (13 -> 13)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_105358v1_full:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@mock@timelines:
- shard-skl: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-skl4/igt@i915_selftest@mock@timelines.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-skl10/igt@i915_selftest@mock@timelines.html
- shard-apl: [PASS][3] -> [INCOMPLETE][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-apl3/igt@i915_selftest@mock@timelines.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-apl6/igt@i915_selftest@mock@timelines.html
- shard-tglb: [PASS][5] -> [INCOMPLETE][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-tglb1/igt@i915_selftest@mock@timelines.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-tglb6/igt@i915_selftest@mock@timelines.html
- shard-glk: [PASS][7] -> [INCOMPLETE][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-glk8/igt@i915_selftest@mock@timelines.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-glk5/igt@i915_selftest@mock@timelines.html
- shard-iclb: [PASS][9] -> [INCOMPLETE][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-iclb5/igt@i915_selftest@mock@timelines.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-iclb4/igt@i915_selftest@mock@timelines.html
- shard-kbl: [PASS][11] -> [INCOMPLETE][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-kbl3/igt@i915_selftest@mock@timelines.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-kbl1/igt@i915_selftest@mock@timelines.html
- shard-snb: [PASS][13] -> [INCOMPLETE][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-snb7/igt@i915_selftest@mock@timelines.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-snb6/igt@i915_selftest@mock@timelines.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* {igt@drm_fdinfo@virtual-busy-idle}:
- {shard-dg1}: NOTRUN -> [SKIP][15]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-dg1-18/igt@drm_fdinfo@virtual-busy-idle.html
* igt@i915_selftest@mock@timelines:
- {shard-rkl}: [PASS][16] -> [INCOMPLETE][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-rkl-1/igt@i915_selftest@mock@timelines.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-rkl-2/igt@i915_selftest@mock@timelines.html
- {shard-dg1}: NOTRUN -> [INCOMPLETE][18]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-dg1-18/igt@i915_selftest@mock@timelines.html
New tests
---------
New tests have been introduced between CI_DRM_11780_full and Patchwork_105358v1_full:
### New IGT tests (3) ###
* igt@kms_cursor_edge_walk@left-edge@pipe-a-hdmi-a-3-128x128:
- Statuses : 1 pass(s)
- Exec time: [3.23] s
* igt@kms_cursor_edge_walk@left-edge@pipe-a-hdmi-a-3-256x256:
- Statuses : 1 pass(s)
- Exec time: [3.23] s
* igt@kms_cursor_edge_walk@left-edge@pipe-a-hdmi-a-3-64x64:
- Statuses : 1 pass(s)
- Exec time: [3.28] s
Known issues
------------
Here are the changes found in Patchwork_105358v1_full that come from known issues:
### CI changes ###
#### Issues hit ####
* boot:
- shard-snb: ([PASS][19], [PASS][20], [PASS][21], [PASS][22], [PASS][23], [PASS][24], [PASS][25], [PASS][26], [PASS][27], [PASS][28], [PASS][29], [PASS][30], [PASS][31], [PASS][32], [PASS][33], [PASS][34], [PASS][35], [PASS][36], [PASS][37], [PASS][38], [PASS][39], [PASS][40], [PASS][41], [PASS][42], [PASS][43]) -> ([PASS][44], [PASS][45], [PASS][46], [PASS][47], [PASS][48], [PASS][49], [PASS][50], [PASS][51], [PASS][52], [PASS][53], [PASS][54], [PASS][55], [FAIL][56], [PASS][57], [PASS][58], [PASS][59], [PASS][60], [PASS][61], [PASS][62], [PASS][63], [PASS][64], [PASS][65], [PASS][66], [PASS][67], [PASS][68]) ([i915#4338])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-snb7/boot.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-snb7/boot.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-snb7/boot.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-snb7/boot.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-snb7/boot.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-snb6/boot.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-snb6/boot.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-snb6/boot.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-snb6/boot.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-snb6/boot.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-snb5/boot.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-snb5/boot.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-snb5/boot.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-snb5/boot.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-snb5/boot.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-snb4/boot.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-snb4/boot.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-snb4/boot.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-snb4/boot.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-snb2/boot.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-snb2/boot.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-snb2/boot.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-snb2/boot.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-snb2/boot.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-snb2/boot.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-snb7/boot.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-snb7/boot.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-snb7/boot.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-snb7/boot.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-snb6/boot.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-snb6/boot.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-snb6/boot.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-snb6/boot.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-snb6/boot.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-snb6/boot.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-snb5/boot.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-snb5/boot.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-snb5/boot.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-snb5/boot.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-snb5/boot.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-snb4/boot.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-snb4/boot.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-snb4/boot.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-snb4/boot.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-snb4/boot.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-snb2/boot.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-snb2/boot.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-snb2/boot.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-snb2/boot.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-snb2/boot.html
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_exec@basic-nohangcheck:
- shard-tglb: [PASS][69] -> [FAIL][70] ([i915#6268])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-tglb2/igt@gem_ctx_exec@basic-nohangcheck.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-tglb7/igt@gem_ctx_exec@basic-nohangcheck.html
* igt@gem_ctx_isolation@preservation-s3@bcs0:
- shard-skl: [PASS][71] -> [INCOMPLETE][72] ([i915#4793])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-skl10/igt@gem_ctx_isolation@preservation-s3@bcs0.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-skl6/igt@gem_ctx_isolation@preservation-s3@bcs0.html
* igt@gem_exec_balancer@parallel-contexts:
- shard-iclb: [PASS][73] -> [SKIP][74] ([i915#4525]) +2 similar issues
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-iclb4/igt@gem_exec_balancer@parallel-contexts.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-iclb5/igt@gem_exec_balancer@parallel-contexts.html
* igt@gem_exec_fair@basic-deadline:
- shard-iclb: NOTRUN -> [FAIL][75] ([i915#6141])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-iclb4/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-none-rrul@rcs0:
- shard-iclb: NOTRUN -> [FAIL][76] ([i915#2842]) +4 similar issues
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-iclb7/igt@gem_exec_fair@basic-none-rrul@rcs0.html
* igt@gem_exec_fair@basic-none@vcs0:
- shard-glk: [PASS][77] -> [FAIL][78] ([i915#2842])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-glk4/igt@gem_exec_fair@basic-none@vcs0.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-glk4/igt@gem_exec_fair@basic-none@vcs0.html
* igt@gem_exec_fair@basic-none@vcs1:
- shard-kbl: [PASS][79] -> [FAIL][80] ([i915#2842]) +5 similar issues
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-kbl4/igt@gem_exec_fair@basic-none@vcs1.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-kbl4/igt@gem_exec_fair@basic-none@vcs1.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglb: [PASS][81] -> [FAIL][82] ([i915#2842])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-tglb1/igt@gem_exec_fair@basic-pace-share@rcs0.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-tglb5/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-iclb: [PASS][83] -> [FAIL][84] ([i915#2849])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-iclb6/igt@gem_exec_fair@basic-throttle@rcs0.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-iclb3/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_exec_params@secure-non-master:
- shard-iclb: NOTRUN -> [SKIP][85] ([fdo#112283])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-iclb7/igt@gem_exec_params@secure-non-master.html
* igt@gem_huc_copy@huc-copy:
- shard-tglb: [PASS][86] -> [SKIP][87] ([i915#2190])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-tglb2/igt@gem_huc_copy@huc-copy.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-tglb7/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@heavy-verify-multi:
- shard-skl: NOTRUN -> [SKIP][88] ([fdo#109271] / [i915#4613]) +3 similar issues
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-skl10/igt@gem_lmem_swapping@heavy-verify-multi.html
* igt@gem_lmem_swapping@heavy-verify-multi-ccs:
- shard-kbl: NOTRUN -> [SKIP][89] ([fdo#109271] / [i915#4613]) +1 similar issue
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-kbl6/igt@gem_lmem_swapping@heavy-verify-multi-ccs.html
- shard-apl: NOTRUN -> [SKIP][90] ([fdo#109271] / [i915#4613])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-apl1/igt@gem_lmem_swapping@heavy-verify-multi-ccs.html
* igt@gem_lmem_swapping@verify-random:
- shard-iclb: NOTRUN -> [SKIP][91] ([i915#4613]) +2 similar issues
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-iclb7/igt@gem_lmem_swapping@verify-random.html
* igt@gem_pwrite@basic-exhaustion:
- shard-apl: NOTRUN -> [WARN][92] ([i915#2658])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-apl1/igt@gem_pwrite@basic-exhaustion.html
- shard-kbl: NOTRUN -> [WARN][93] ([i915#2658])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-kbl6/igt@gem_pwrite@basic-exhaustion.html
* igt@gem_pxp@reject-modify-context-protection-on:
- shard-iclb: NOTRUN -> [SKIP][94] ([i915#4270])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-iclb4/igt@gem_pxp@reject-modify-context-protection-on.html
* igt@gem_render_copy@y-tiled-ccs-to-yf-tiled-mc-ccs:
- shard-iclb: NOTRUN -> [SKIP][95] ([i915#768]) +1 similar issue
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-iclb7/igt@gem_render_copy@y-tiled-ccs-to-yf-tiled-mc-ccs.html
* igt@gem_softpin@evict-snoop-interruptible:
- shard-iclb: NOTRUN -> [SKIP][96] ([fdo#109312])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-iclb4/igt@gem_softpin@evict-snoop-interruptible.html
* igt@gem_userptr_blits@input-checking:
- shard-skl: NOTRUN -> [DMESG-WARN][97] ([i915#1982] / [i915#4991])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-skl2/igt@gem_userptr_blits@input-checking.html
* igt@gem_userptr_blits@unsync-unmap:
- shard-iclb: NOTRUN -> [SKIP][98] ([i915#3297])
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-iclb7/igt@gem_userptr_blits@unsync-unmap.html
* igt@gem_userptr_blits@vma-merge:
- shard-skl: NOTRUN -> [FAIL][99] ([i915#3318])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-skl9/igt@gem_userptr_blits@vma-merge.html
* igt@gem_workarounds@suspend-resume:
- shard-kbl: [PASS][100] -> [DMESG-WARN][101] ([i915#180]) +3 similar issues
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-kbl3/igt@gem_workarounds@suspend-resume.html
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-kbl7/igt@gem_workarounds@suspend-resume.html
* igt@gen7_exec_parse@batch-without-end:
- shard-iclb: NOTRUN -> [SKIP][102] ([fdo#109289]) +4 similar issues
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-iclb7/igt@gen7_exec_parse@batch-without-end.html
* igt@gen9_exec_parse@allowed-single:
- shard-skl: [PASS][103] -> [DMESG-WARN][104] ([i915#5566] / [i915#716])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-skl9/igt@gen9_exec_parse@allowed-single.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-skl4/igt@gen9_exec_parse@allowed-single.html
- shard-apl: [PASS][105] -> [DMESG-WARN][106] ([i915#5566] / [i915#716])
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-apl1/igt@gen9_exec_parse@allowed-single.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-apl3/igt@gen9_exec_parse@allowed-single.html
* igt@gen9_exec_parse@unaligned-jump:
- shard-iclb: NOTRUN -> [SKIP][107] ([i915#2856]) +1 similar issue
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-iclb4/igt@gen9_exec_parse@unaligned-jump.html
* igt@i915_pm_dc@dc6-psr:
- shard-skl: NOTRUN -> [FAIL][108] ([i915#454])
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-skl10/igt@i915_pm_dc@dc6-psr.html
* igt@i915_pm_rpm@dpms-lpsp:
- shard-kbl: NOTRUN -> [SKIP][109] ([fdo#109271]) +118 similar issues
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-kbl3/igt@i915_pm_rpm@dpms-lpsp.html
* igt@i915_pm_rpm@dpms-mode-unset-non-lpsp:
- shard-iclb: NOTRUN -> [SKIP][110] ([fdo#110892])
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-iclb7/igt@i915_pm_rpm@dpms-mode-unset-non-lpsp.html
* igt@i915_pm_rpm@gem-execbuf-stress-pc8:
- shard-iclb: NOTRUN -> [SKIP][111] ([fdo#109293] / [fdo#109506])
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-iclb7/igt@i915_pm_rpm@gem-execbuf-stress-pc8.html
* igt@i915_query@test-query-geometry-subslices:
- shard-iclb: NOTRUN -> [SKIP][112] ([i915#5723])
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-iclb7/igt@i915_query@test-query-geometry-subslices.html
* igt@kms_atomic@atomic_plane_damage:
- shard-iclb: NOTRUN -> [SKIP][113] ([i915#4765])
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-iclb7/igt@kms_atomic@atomic_plane_damage.html
* igt@kms_big_fb@4-tiled-8bpp-rotate-90:
- shard-iclb: NOTRUN -> [SKIP][114] ([i915#5286]) +3 similar issues
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-iclb7/igt@kms_big_fb@4-tiled-8bpp-rotate-90.html
* igt@kms_big_fb@y-tiled-8bpp-rotate-90:
- shard-iclb: NOTRUN -> [SKIP][115] ([fdo#110725] / [fdo#111614]) +1 similar issue
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-iclb7/igt@kms_big_fb@y-tiled-8bpp-rotate-90.html
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-async-flip:
- shard-skl: NOTRUN -> [FAIL][116] ([i915#3763])
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-skl9/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-async-flip.html
* igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_mc_ccs:
- shard-kbl: NOTRUN -> [SKIP][117] ([fdo#109271] / [i915#3886]) +8 similar issues
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-kbl3/igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_mc_ccs:
- shard-skl: NOTRUN -> [SKIP][118] ([fdo#109271] / [i915#3886]) +2 similar issues
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-skl10/igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-b-bad-pixel-format-y_tiled_gen12_rc_ccs_cc:
- shard-iclb: NOTRUN -> [SKIP][119] ([fdo#109278] / [i915#3886]) +4 similar issues
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-iclb7/igt@kms_ccs@pipe-b-bad-pixel-format-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][120] ([fdo#109271] / [i915#3886]) +4 similar issues
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-apl1/igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-d-crc-primary-basic-y_tiled_ccs:
- shard-iclb: NOTRUN -> [SKIP][121] ([fdo#109278]) +40 similar issues
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-iclb7/igt@kms_ccs@pipe-d-crc-primary-basic-y_tiled_ccs.html
* igt@kms_cdclk@mode-transition:
- shard-iclb: NOTRUN -> [SKIP][122] ([i915#3742]) +1 similar issue
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-iclb7/igt@kms_cdclk@mode-transition.html
* igt@kms_chamelium@vga-hpd-without-ddc:
- shard-apl: NOTRUN -> [SKIP][123] ([fdo#109271] / [fdo#111827]) +4 similar issues
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-apl1/igt@kms_chamelium@vga-hpd-without-ddc.html
* igt@kms_color@pipe-d-ctm-negative:
- shard-iclb: NOTRUN -> [SKIP][124] ([fdo#109278] / [i915#1149])
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-iclb7/igt@kms_color@pipe-d-ctm-negative.html
* igt@kms_color_chamelium@pipe-b-ctm-0-5:
- shard-iclb: NOTRUN -> [SKIP][125] ([fdo#109284] / [fdo#111827]) +6 similar issues
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-iclb4/igt@kms_color_chamelium@pipe-b-ctm-0-5.html
* igt@kms_color_chamelium@pipe-c-ctm-0-75:
- shard-kbl: NOTRUN -> [SKIP][126] ([fdo#109271] / [fdo#111827]) +9 similar issues
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-kbl6/igt@kms_color_chamelium@pipe-c-ctm-0-75.html
* igt@kms_color_chamelium@pipe-c-ctm-negative:
- shard-skl: NOTRUN -> [SKIP][127] ([fdo#109271] / [fdo#111827]) +12 similar issues
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-skl10/igt@kms_color_chamelium@pipe-c-ctm-negative.html
* igt@kms_color_chamelium@pipe-d-ctm-0-25:
- shard-iclb: NOTRUN -> [SKIP][128] ([fdo#109278] / [fdo#109284] / [fdo#111827])
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-iclb7/igt@kms_color_chamelium@pipe-d-ctm-0-25.html
* igt@kms_content_protection@dp-mst-type-1:
- shard-iclb: NOTRUN -> [SKIP][129] ([i915#3116])
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-iclb4/igt@kms_content_protection@dp-mst-type-1.html
* igt@kms_content_protection@lic:
- shard-iclb: NOTRUN -> [SKIP][130] ([fdo#109300] / [fdo#111066])
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-iclb7/igt@kms_content_protection@lic.html
* igt@kms_cursor_crc@pipe-a-cursor-512x512-random:
- shard-iclb: NOTRUN -> [SKIP][131] ([fdo#109278] / [fdo#109279]) +2 similar issues
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-iclb4/igt@kms_cursor_crc@pipe-a-cursor-512x512-random.html
* igt@kms_cursor_crc@pipe-c-cursor-32x10-random:
- shard-apl: NOTRUN -> [SKIP][132] ([fdo#109271]) +91 similar issues
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-apl6/igt@kms_cursor_crc@pipe-c-cursor-32x10-random.html
* igt@kms_cursor_legacy@cursor-vs-flip-varying-size:
- shard-iclb: NOTRUN -> [FAIL][133] ([i915#5072])
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-iclb7/igt@kms_cursor_legacy@cursor-vs-flip-varying-size.html
* igt@kms_cursor_legacy@cursorb-vs-flipa-atomic-transitions-varying-size:
- shard-iclb: NOTRUN -> [SKIP][134] ([fdo#109274] / [fdo#109278]) +2 similar issues
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-iclb7/igt@kms_cursor_legacy@cursorb-vs-flipa-atomic-transitions-varying-size.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-skl: NOTRUN -> [FAIL][135] ([i915#2346] / [i915#533])
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-skl6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_cursor_legacy@pipe-d-single-bo:
- shard-skl: NOTRUN -> [SKIP][136] ([fdo#109271] / [i915#533])
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-skl6/igt@kms_cursor_legacy@pipe-d-single-bo.html
* igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-4tiled:
- shard-iclb: NOTRUN -> [SKIP][137] ([i915#5287]) +1 similar issue
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-iclb7/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-4tiled.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-apl: [PASS][138] -> [INCOMPLETE][139] ([i915#4939])
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-apl7/igt@kms_fbcon_fbt@fbc-suspend.html
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-apl2/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_flip@2x-blocking-wf_vblank:
- shard-iclb: NOTRUN -> [SKIP][140] ([fdo#109274]) +2 similar issues
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-iclb4/igt@kms_flip@2x-blocking-wf_vblank.html
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ab-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][141] -> [FAIL][142] ([i915#79]) +1 similar issue
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-glk4/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ab-hdmi-a1-hdmi-a2.html
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-glk5/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ab-hdmi-a1-hdmi-a2.html
* igt@kms_flip@flip-vs-expired-vblank@a-edp1:
- shard-skl: [PASS][143] -> [FAIL][144] ([i915#79])
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-skl7/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-skl7/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html
* igt@kms_flip@flip-vs-expired-vblank@b-dp1:
- shard-kbl: [PASS][145] -> [FAIL][146] ([i915#79])
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-kbl4/igt@kms_flip@flip-vs-expired-vblank@b-dp1.html
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-kbl4/igt@kms_flip@flip-vs-expired-vblank@b-dp1.html
* igt@kms_flip@flip-vs-suspend@a-dp1:
- shard-apl: [PASS][147] -> [DMESG-WARN][148] ([i915#180]) +2 similar issues
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-apl7/igt@kms_flip@flip-vs-suspend@a-dp1.html
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-apl2/igt@kms_flip@flip-vs-suspend@a-dp1.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-upscaling:
- shard-glk: [PASS][149] -> [FAIL][150] ([i915#4911])
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-glk2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-upscaling.html
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-glk8/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-upscaling.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile-upscaling:
- shard-skl: NOTRUN -> [SKIP][151] ([fdo#109271] / [i915#3701])
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-skl10/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile-upscaling.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-mmap-wc:
- shard-skl: NOTRUN -> [SKIP][152] ([fdo#109271]) +230 similar issues
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-skl10/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-cur-indfb-draw-pwrite:
- shard-iclb: NOTRUN -> [SKIP][153] ([fdo#109280]) +26 similar issues
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-cur-indfb-draw-pwrite.html
* igt@kms_hdr@bpc-switch-dpms:
- shard-iclb: NOTRUN -> [SKIP][154] ([i915#3555])
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-iclb7/igt@kms_hdr@bpc-switch-dpms.html
* igt@kms_hdr@bpc-switch@pipe-a-dp-1:
- shard-kbl: NOTRUN -> [FAIL][155] ([i915#1188])
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-kbl3/igt@kms_hdr@bpc-switch@pipe-a-dp-1.html
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-d-frame-sequence:
- shard-kbl: NOTRUN -> [SKIP][156] ([fdo#109271] / [i915#533])
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-kbl3/igt@kms_pipe_crc_basic@nonblocking-crc-pipe-d-frame-sequence.html
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min:
- shard-skl: NOTRUN -> [FAIL][157] ([fdo#108145] / [i915#265]) +2 similar issues
[157]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-skl9/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html
* igt@kms_plane_alpha_blend@pipe-c-alpha-basic:
- shard-apl: NOTRUN -> [FAIL][158] ([fdo#108145] / [i915#265])
[158]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-apl1/igt@kms_plane_alpha_blend@pipe-c-alpha-basic.html
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max:
- shard-kbl: NOTRUN -> [FAIL][159] ([fdo#108145] / [i915#265]) +1 similar issue
[159]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-kbl3/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max.html
* igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-75@pipe-b-edp-1:
- shard-iclb: NOTRUN -> [SKIP][160] ([i915#5176]) +5 similar issues
[160]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-iclb7/igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-75@pipe-b-edp-1.html
* igt@kms_prime@basic-crc@first-to-second:
- shard-iclb: NOTRUN -> [SKIP][161] ([i915#1836])
[161]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-iclb7/igt@kms_prime@basic-crc@first-to-second.html
* igt@kms_psr2_sf@overlay-plane-move-continuous-sf:
- shard-apl: NOTRUN -> [SKIP][162] ([fdo#109271] / [i915#658])
[162]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-apl1/igt@kms_psr2_sf@overlay-plane-move-continuous-sf.html
- shard-kbl: NOTRUN -> [SKIP][163] ([fdo#109271] / [i915#658])
[163]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-kbl6/igt@kms_psr2_sf@overlay-plane-move-continuous-sf.html
* igt@kms_psr2_sf@overlay-plane-update-continuous-sf:
- shard-iclb: NOTRUN -> [SKIP][164] ([fdo#111068] / [i915#658])
[164]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-iclb7/igt@kms_psr2_sf@overlay-plane-update-continuous-sf.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-big-fb:
- shard-skl: NOTRUN -> [SKIP][165] ([fdo#109271] / [i915#658]) +1 similar issue
[165]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-skl10/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-big-fb.html
* igt@kms_psr@psr2_cursor_plane_move:
- shard-iclb: [PASS][166] -> [SKIP][167] ([fdo#109441]) +1 similar issue
[166]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-iclb2/igt@kms_psr@psr2_cursor_plane_move.html
[167]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-iclb4/igt@kms_psr@psr2_cursor_plane_move.html
* igt@kms_psr@psr2_primary_render:
- shard-iclb: NOTRUN -> [SKIP][168] ([fdo#109441]) +2 similar issues
[168]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-iclb4/igt@kms_psr@psr2_primary_render.html
* igt@kms_rotation_crc@primary-4-tiled-reflect-x-0:
- shard-iclb: NOTRUN -> [SKIP][169] ([i915#5289])
[169]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-iclb7/igt@kms_rotation_crc@primary-4-tiled-reflect-x-0.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-skl: [PASS][170] -> [INCOMPLETE][171] ([i915#4939])
[170]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-skl4/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
[171]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-skl7/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
* igt@nouveau_crc@pipe-b-source-outp-complete:
- shard-iclb: NOTRUN -> [SKIP][172] ([i915#2530]) +1 similar issue
[172]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-iclb7/igt@nouveau_crc@pipe-b-source-outp-complete.html
* igt@prime_nv_pcopy@test3_2:
- shard-iclb: NOTRUN -> [SKIP][173] ([fdo#109291]) +2 similar issues
[173]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-iclb4/igt@prime_nv_pcopy@test3_2.html
* igt@prime_vgem@fence-read-hang:
- shard-iclb: NOTRUN -> [SKIP][174] ([fdo#109295])
[174]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-iclb7/igt@prime_vgem@fence-read-hang.html
* igt@sw_sync@sync_multi_timeline_wait:
- shard-skl: NOTRUN -> [FAIL][175] ([i915#6140])
[175]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-skl10/igt@sw_sync@sync_multi_timeline_wait.html
* igt@sysfs_clients@recycle:
- shard-iclb: NOTRUN -> [SKIP][176] ([i915#2994]) +2 similar issues
[176]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-iclb7/igt@sysfs_clients@recycle.html
* igt@sysfs_clients@sema-25:
- shard-skl: NOTRUN -> [SKIP][177] ([fdo#109271] / [i915#2994])
[177]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-skl6/igt@sysfs_clients@sema-25.html
* igt@sysfs_heartbeat_interval@mixed@rcs0:
- shard-skl: NOTRUN -> [FAIL][178] ([i915#1731])
[178]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-skl9/igt@sysfs_heartbeat_interval@mixed@rcs0.html
#### Possible fixes ####
* igt@feature_discovery@psr2:
- shard-iclb: [SKIP][179] ([i915#658]) -> [PASS][180]
[179]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-iclb5/igt@feature_discovery@psr2.html
[180]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-iclb2/igt@feature_discovery@psr2.html
* igt@gem_ctx_exec@basic-nohangcheck:
- {shard-rkl}: [FAIL][181] ([i915#6268]) -> [PASS][182]
[181]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-rkl-6/igt@gem_ctx_exec@basic-nohangcheck.html
[182]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-rkl-5/igt@gem_ctx_exec@basic-nohangcheck.html
* igt@gem_ctx_isolation@preservation-s3@bcs0:
- shard-apl: [DMESG-WARN][183] ([i915#180]) -> [PASS][184] +3 similar issues
[183]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-apl2/igt@gem_ctx_isolation@preservation-s3@bcs0.html
[184]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-apl6/igt@gem_ctx_isolation@preservation-s3@bcs0.html
* igt@gem_ctx_isolation@preservation-s3@vcs0:
- shard-kbl: [DMESG-WARN][185] ([i915#180]) -> [PASS][186] +5 similar issues
[185]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-kbl4/igt@gem_ctx_isolation@preservation-s3@vcs0.html
[186]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-kbl4/igt@gem_ctx_isolation@preservation-s3@vcs0.html
* igt@gem_ctx_persistence@legacy-engines-hostile@bsd1:
- {shard-dg1}: [FAIL][187] ([i915#4883]) -> [PASS][188]
[187]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-dg1-18/igt@gem_ctx_persistence@legacy-engines-hostile@bsd1.html
[188]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-dg1-16/igt@gem_ctx_persistence@legacy-engines-hostile@bsd1.html
* igt@gem_ctx_persistence@many-contexts:
- {shard-rkl}: [FAIL][189] ([i915#2410]) -> [PASS][190]
[189]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-rkl-6/igt@gem_ctx_persistence@many-contexts.html
[190]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-rkl-5/igt@gem_ctx_persistence@many-contexts.html
* igt@gem_eio@in-flight-contexts-1us:
- shard-iclb: [TIMEOUT][191] ([i915#3070]) -> [PASS][192]
[191]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-iclb5/igt@gem_eio@in-flight-contexts-1us.html
[192]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-iclb8/igt@gem_eio@in-flight-contexts-1us.html
- {shard-tglu}: [TIMEOUT][193] ([i915#3063]) -> [PASS][194] +1 similar issue
[193]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-tglu-5/igt@gem_eio@in-flight-contexts-1us.html
[194]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-tglu-2/igt@gem_eio@in-flight-contexts-1us.html
* igt@gem_eio@kms:
- shard-tglb: [FAIL][195] ([i915#5784]) -> [PASS][196]
[195]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-tglb3/igt@gem_eio@kms.html
[196]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-tglb6/igt@gem_eio@kms.html
* igt@gem_exec_fair@basic-flow@rcs0:
- {shard-rkl}: [FAIL][197] ([i915#2842]) -> [PASS][198]
[197]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-rkl-2/igt@gem_exec_fair@basic-flow@rcs0.html
[198]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-rkl-1/igt@gem_exec_fair@basic-flow@rcs0.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- {shard-tglu}: [FAIL][199] ([i915#2842]) -> [PASS][200]
[199]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-tglu-4/igt@gem_exec_fair@basic-pace-share@rcs0.html
[200]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-tglu-5/igt@gem_exec_fair@basic-pace-share@rcs0.html
- shard-apl: [FAIL][201] ([i915#2842]) -> [PASS][202]
[201]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-apl3/igt@gem_exec_fair@basic-pace-share@rcs0.html
[202]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-apl2/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-pace@vecs0:
- shard-iclb: [FAIL][203] ([i915#2842]) -> [PASS][204]
[203]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-iclb1/igt@gem_exec_fair@basic-pace@vecs0.html
[204]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-iclb7/igt@gem_exec_fair@basic-pace@vecs0.html
* igt@gem_exec_reloc@basic-gtt-cpu-active:
- {shard-rkl}: [SKIP][205] ([i915#3281]) -> [PASS][206] +6 similar issues
[205]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-rkl-2/igt@gem_exec_reloc@basic-gtt-cpu-active.html
[206]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-rkl-5/igt@gem_exec_reloc@basic-gtt-cpu-active.html
* igt@gem_exec_whisper@basic-fds-forked-all:
- shard-iclb: [INCOMPLETE][207] ([i915#5498] / [i915#5843]) -> [PASS][208]
[207]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-iclb7/igt@gem_exec_whisper@basic-fds-forked-all.html
[208]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-iclb4/igt@gem_exec_whisper@basic-fds-forked-all.html
* igt@gem_pwrite@basic-self:
- {shard-rkl}: [SKIP][209] ([i915#3282]) -> [PASS][210] +2 similar issues
[209]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-rkl-6/igt@gem_pwrite@basic-self.html
[210]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-rkl-5/igt@gem_pwrite@basic-self.html
* igt@gem_userptr_blits@huge-split:
- shard-kbl: [FAIL][211] ([i915#3376]) -> [PASS][212]
[211]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-kbl6/igt@gem_userptr_blits@huge-split.html
[212]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-kbl1/igt@gem_userptr_blits@huge-split.html
* igt@gen9_exec_parse@shadow-peek:
- {shard-rkl}: [SKIP][213] ([i915#2527]) -> [PASS][214] +2 similar issues
[213]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-rkl-2/igt@gen9_exec_parse@shadow-peek.html
[214]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-rkl-5/igt@gen9_exec_parse@shadow-peek.html
* igt@i915_pm_dc@dc9-dpms:
- {shard-rkl}: [SKIP][215] ([i915#3361]) -> [PASS][216]
[215]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-rkl-5/igt@i915_pm_dc@dc9-dpms.html
[216]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-rkl-1/igt@i915_pm_dc@dc9-dpms.html
- {shard-tglu}: [SKIP][217] ([i915#4281]) -> [PASS][218]
[217]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-tglu-3/igt@i915_pm_dc@dc9-dpms.html
[218]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-tglu-4/igt@i915_pm_dc@dc9-dpms.html
* igt@i915_pm_rpm@pm-tiling:
- {shard-rkl}: [SKIP][219] ([fdo#109308]) -> [PASS][220]
[219]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-rkl-1/igt@i915_pm_rpm@pm-tiling.html
[220]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-rkl-6/igt@i915_pm_rpm@pm-tiling.html
* igt@kms_cursor_crc@pipe-a-cursor-64x21-onscreen:
- {shard-rkl}: [SKIP][221] ([fdo#112022] / [i915#4070]) -> [PASS][222] +3 similar issues
[221]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-rkl-1/igt@kms_cursor_crc@pipe-a-cursor-64x21-onscreen.html
[222]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-rkl-6/igt@kms_cursor_crc@pipe-a-cursor-64x21-onscreen.html
* igt@kms_cursor_legacy@cursor-vs-flip-toggle:
- {shard-rkl}: [SKIP][223] ([fdo#111825] / [i915#4070]) -> [PASS][224] +2 similar issues
[223]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-rkl-1/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html
[224]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-rkl-6/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html
* igt@kms_cursor_legacy@pipe-c-forked-bo:
- {shard-rkl}: [SKIP][225] ([i915#4070]) -> [PASS][226]
[225]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-rkl-2/igt@kms_cursor_legacy@pipe-c-forked-bo.html
[226]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-rkl-5/igt@kms_cursor_legacy@pipe-c-forked-bo.html
* igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-xtiled:
- {shard-rkl}: [SKIP][227] ([fdo#111314] / [i915#4098] / [i915#4369]) -> [PASS][228] +1 similar issue
[227]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-rkl-1/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-xtiled.html
[228]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-rkl-6/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-xtiled.html
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ac-hdmi-a1-hdmi-a2:
- shard-glk: [FAIL][229] ([i915#79]) -> [PASS][230]
[229]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-glk4/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ac-hdmi-a1-hdmi-a2.html
[230]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-glk5/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ac-hdmi-a1-hdmi-a2.html
* igt@kms_flip@busy-flip@b-edp1:
- shard-skl: [FAIL][231] ([i915#5726]) -> [PASS][232]
[231]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-skl2/igt@kms_flip@busy-flip@b-edp1.html
[232]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-skl2/igt@kms_flip@busy-flip@b-edp1.html
* igt@kms_frontbuffer_tracking@psr-1p-rte:
- {shard-rkl}: [SKIP][233] ([i915#1849] / [i915#4098]) -> [PASS][234] +12 similar issues
[233]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-rkl-1/igt@kms_frontbuffer_tracking@psr-1p-rte.html
[234]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-rkl-6/igt@kms_frontbuffer_tracking@psr-1p-rte.html
* igt@kms_hdr@bpc-switch-dpms@pipe-a-dp-1:
- shard-kbl: [FAIL][235] ([i915#1188]) -> [PASS][236]
[235]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-kbl4/igt@kms_hdr@bpc-switch-dpms@pipe-a-dp-1.html
[236]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-kbl4/igt@kms_hdr@bpc-switch-dpms@pipe-a-dp-1.html
* igt@kms_plane@plane-position-hole-dpms@pipe-b-planes:
- {shard-rkl}: [SKIP][237] ([i915#3558]) -> [PASS][238] +1 similar issue
[237]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-rkl-1/igt@kms_plane@plane-position-hole-dpms@pipe-b-planes.html
[238]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-rkl-6/igt@kms_plane@plane-position-hole-dpms@pipe-b-planes.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-basic:
- {shard-rkl}: [SKIP][239] ([i915#1849] / [i915#4070] / [i915#4098]) -> [PASS][240]
[239]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-rkl-1/igt@kms_plane_alpha_blend@pipe-a-alpha-basic.html
[240]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-rkl-6/igt@kms_plane_alpha_blend@pipe-a-alpha-basic.html
* igt@kms_plane_cursor@pipe-b-overlay-size-64:
- {shard-rkl}: [SKIP][241] ([i915#1845] / [i915#4098]) -> [PASS][242] +8 similar issues
[241]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-rkl-1/igt@kms_plane_cursor@pipe-b-overlay-size-64.html
[242]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-rkl-6/igt@kms_plane_cursor@pipe-b-overlay-size-64.html
* igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-a-edp-1:
- shard-iclb: [SKIP][243] ([i915#5235]) -> [PASS][244] +2 similar issues
[243]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-iclb2/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-a-edp-1.html
[244]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-iclb8/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-a-edp-1.html
* igt@kms_psr2_su@page_flip-xrgb8888:
- shard-iclb: [SKIP][245] ([fdo#109642] / [fdo#111068] / [i915#658]) -> [PASS][246]
[245]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-iclb6/igt@kms_psr2_su@page_flip-xrgb8888.html
[246]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-iclb2/igt@kms_psr2_su@page_flip-xrgb8888.html
* igt@kms_psr@psr2_sprite_render:
- shard-iclb: [SKIP][247] ([fdo#109441]) -> [PASS][248]
[247]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-iclb6/igt@kms_psr@psr2_sprite_render.html
[248]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-iclb2/igt@kms_psr@psr2_sprite_render.html
* igt@kms_universal_plane@cursor-fb-leak-pipe-a:
- {shard-rkl}: [SKIP][249] ([i915#1845] / [i915#4070] / [i915#4098]) -> [PASS][250]
[249]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-rkl-1/igt@kms_universal_plane@cursor-fb-leak-pipe-a.html
[250]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-rkl-6/igt@kms_universal_plane@cursor-fb-leak-pipe-a.html
#### Warnings ####
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-iclb: [FAIL][251] ([i915#2842]) -> [FAIL][252] ([i915#2849])
[251]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-iclb3/igt@gem_exec_fair@basic-none-solo@rcs0.html
[252]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-iclb8/igt@gem_exec_fair@basic-none-solo@rcs0.html
* igt@gem_exec_fair@basic-pace@rcs0:
- shard-kbl: [FAIL][253] ([i915#2842]) -> [FAIL][254] ([i915#2851])
[253]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-kbl6/igt@gem_exec_fair@basic-pace@rcs0.html
[254]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-kbl7/igt@gem_exec_fair@basic-pace@rcs0.html
* igt@kms_ccs@pipe-d-crc-primary-rotation-180-4_tiled_dg2_rc_ccs_cc:
- shard-skl: [SKIP][255] ([fdo#109271] / [i915#1888]) -> [SKIP][256] ([fdo#109271]) +1 similar issue
[255]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-skl7/igt@kms_ccs@pipe-d-crc-primary-rotation-180-4_tiled_dg2_rc_ccs_cc.html
[256]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-skl2/igt@kms_ccs@pipe-d-crc-primary-rotation-180-4_tiled_dg2_rc_ccs_cc.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-kbl: [INCOMPLETE][257] ([i915#180]) -> [FAIL][258] ([i915#4767])
[257]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-kbl6/igt@kms_fbcon_fbt@fbc-suspend.html
[258]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-kbl3/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_psr2_sf@cursor-plane-move-continuous-sf:
- shard-iclb: [SKIP][259] ([i915#658]) -> [SKIP][260] ([i915#2920])
[259]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-iclb6/igt@kms_psr2_sf@cursor-plane-move-continuous-sf.html
[260]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-iclb2/igt@kms_psr2_sf@cursor-plane-move-continuous-sf.html
* igt@kms_psr2_sf@overlay-plane-move-continuous-sf:
- shard-iclb: [SKIP][261] ([i915#2920]) -> [SKIP][262] ([i915#658])
[261]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-iclb2/igt@kms_psr2_sf@overlay-plane-move-continuous-sf.html
[262]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-iclb4/igt@kms_psr2_sf@overlay-plane-move-continuous-sf.html
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area:
- shard-glk: [SKIP][263] ([fdo#109271] / [i915#1888] / [i915#658]) -> [SKIP][264] ([fdo#109271] / [i915#658])
[263]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-glk4/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area.html
[264]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-glk5/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area:
- shard-iclb: [SKIP][265] ([i915#2920]) -> [SKIP][266] ([fdo#111068] / [i915#658])
[265]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-iclb2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area.html
[266]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-iclb8/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area.html
* igt@kms_psr2_su@page_flip-nv12:
- shard-iclb: [SKIP][267] ([fdo#109642] / [fdo#111068] / [i915#658]) -> [FAIL][268] ([i915#5939])
[267]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-iclb5/igt@kms_psr2_su@page_flip-nv12.html
[268]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-iclb2/igt@kms_psr2_su@page_flip-nv12.html
* igt@runner@aborted:
- shard-skl: ([FAIL][269], [FAIL][270]) ([i915#2029] / [i915#3002] / [i915#4312] / [i915#5257]) -> ([FAIL][271], [FAIL][272], [FAIL][273], [FAIL][274]) ([i915#3002] / [i915#4312] / [i915#5257])
[269]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-skl2/igt@runner@aborted.html
[270]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-skl2/igt@runner@aborted.html
[271]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-skl10/igt@runner@aborted.html
[272]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-skl4/igt@runner@aborted.html
[273]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-skl2/igt@runner@aborted.html
[274]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-skl4/igt@runner@aborted.html
- shard-apl: ([FAIL][275], [FAIL][276], [FAIL][277], [FAIL][278], [FAIL][279], [FAIL][280], [FAIL][281]) ([i915#180] / [i915#3002] / [i915#4312] / [i915#5257]) -> ([FAIL][282], [FAIL][283], [FAIL][284], [FAIL][285], [FAIL][286], [FAIL][287]) ([fdo#109271] / [i915#180] / [i915#3002] / [i915#4312] / [i915#5257])
[275]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-apl6/igt@runner@aborted.html
[276]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-apl1/igt@runner@aborted.html
[277]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-apl2/igt@runner@aborted.html
[278]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-apl1/igt@runner@aborted.html
[279]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-apl6/igt@runner@aborted.html
[280]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-apl3/igt@runner@aborted.html
[281]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-apl3/igt@runner@aborted.html
[282]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-apl8/igt@runner@aborted.html
[283]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-apl3/igt@runner@aborted.html
[284]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-apl6/igt@runner@aborted.html
[285]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-apl8/igt@runner@aborted.html
[286]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-apl2/igt@runner@aborted.html
[287]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-apl3/igt@runner@aborted.html
- shard-tglb: ([FAIL][288], [FAIL][289]) ([i915#3002] / [i915#4312] / [i915#5257]) -> ([FAIL][290], [FAIL][291], [FAIL][292]) ([i915#3002] / [i915#3690] / [i915#4312] / [i915#5257])
[288]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-tglb2/igt@runner@aborted.html
[289]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-tglb3/igt@runner@aborted.html
[290]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-tglb1/igt@runner@aborted.html
[291]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-tglb3/igt@runner@aborted.html
[292]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-tglb6/igt@runner@aborted.html
- shard-iclb: ([FAIL][293], [FAIL][294], [FAIL][295]) ([i915#3002] / [i915#4312] / [i915#5257]) -> ([FAIL][296], [FAIL][297], [FAIL][298]) ([i915#3002] / [i915#3690] / [i915#4312] / [i915#5257])
[293]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-iclb7/igt@runner@aborted.html
[294]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-iclb7/igt@runner@aborted.html
[295]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-iclb4/igt@runner@aborted.html
[296]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-iclb4/igt@runner@aborted.html
[297]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-iclb2/igt@runner@aborted.html
[298]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-iclb5/igt@runner@aborted.html
- shard-kbl: ([FAIL][299], [FAIL][300], [FAIL][301], [FAIL][302], [FAIL][303], [FAIL][304], [FAIL][305]) ([i915#180] / [i915#3002] / [i915#4312] / [i915#5257] / [i915#92]) -> ([FAIL][306], [FAIL][307], [FAIL][308], [FAIL][309], [FAIL][310], [FAIL][311], [FAIL][312]) ([i915#180] / [i915#3002] / [i915#4312] / [i915#5257])
[299]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-kbl1/igt@runner@aborted.html
[300]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-kbl1/igt@runner@aborted.html
[301]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-kbl6/igt@runner@aborted.html
[302]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-kbl6/igt@runner@aborted.html
[303]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-kbl4/igt@runner@aborted.html
[304]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-kbl4/igt@runner@aborted.html
[305]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11780/shard-kbl4/igt@runner@aborted.html
[306]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-kbl1/igt@runner@aborted.html
[307]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-kbl7/igt@runner@aborted.html
[308]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-kbl7/igt@runner@aborted.html
[309]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-kbl1/igt@runner@aborted.html
[310]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-kbl7/igt@runner@aborted.html
[311]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-kbl7/igt@runner@aborted.html
[312]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/shard-kbl4/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109293]: https://bugs.freedesktop.org/show_bug.cgi?id=109293
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
[fdo#109302]: https://bugs.freedesktop.org/show_bug.cgi?id=109302
[fdo#109303]: https://bugs.freedesktop.org/show_bug.cgi?id=109303
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#110725]: https://bugs.freedesktop.org/show_bug.cgi?id=110725
[fdo#110892]: https://bugs.freedesktop.org/show_bug.cgi?id=110892
[fdo#111066]: https://bugs.freedesktop.org/show_bug.cgi?id=111066
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111314]: https://bugs.freedesktop.org/show_bug.cgi?id=111314
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112022]: https://bugs.freedesktop.org/show_bug.cgi?id=112022
[fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1149]: https://gitlab.freedesktop.org/drm/intel/issues/1149
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1722]: https://gitlab.freedesktop.org/drm/intel/issues/1722
[i915#1731]: https://gitlab.freedesktop.org/drm/intel/issues/1731
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1836]: https://gitlab.freedesktop.org/drm/intel/issues/1836
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1850]: https://gitlab.freedesktop.org/drm/intel/issues/1850
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#1902]: https://gitlab.freedesktop.org/drm/intel/issues/1902
[i915#1911]: https://gitlab.freedesktop.org/drm/intel/issues/1911
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2029]: https://gitlab.freedesktop.org/drm/intel/issues/2029
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2410]: https://gitlab.freedesktop.org/drm/intel/issues/2410
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2530]: https://gitlab.freedesktop.org/drm/intel/issues/2530
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2849]: https://gitlab.freedesktop.org/drm/intel/issues/2849
[i915#2851]: https://gitlab.freedesktop.org/drm/intel/issues/2851
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#3063]: https://gitlab.freedesktop.org/drm/intel/issues/3063
[i915#3070]: https://gitlab.freedesktop.org/drm/intel/issues/3070
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
[i915#3319]: https://gitlab.freedesktop.org/drm/intel/issues/3319
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3361]: https://gitlab.freedesktop.org/drm/intel/issues/3361
[i915#3376]: https://gitlab.freedesktop.org/drm/intel/issues/3376
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3528]: https://gitlab.freedesktop.org/drm/intel/issues/3528
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3690]: https://gitlab.freedesktop.org/drm/intel/issues/3690
[i915#3701]: https://gitlab.freedesktop.org/drm/intel/issues/3701
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3763]: https://gitlab.freedesktop.org/drm/intel/issues/3763
[i915#3810]: https://gitlab.freedesktop.org/drm/intel/issues/3810
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#3963]: https://gitlab.freedesktop.org/drm/intel/issues/3963
[i915#4032]: https://gitlab.freedesktop.org/drm/intel/issues/4032
[i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
[i915#426]: https://gitlab.freedesktop.org/drm/intel/issues/426
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4278]: https://gitlab.freedesktop.org/drm/intel/issues/4278
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4338]: https://gitlab.freedesktop.org/drm/intel/issues/4338
[i915#4369]: https://gitlab.freedesktop.org/drm/intel/issues/4369
[i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4765]: https://gitlab.freedesktop.org/drm/intel/issues/4765
[i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
[i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771
[i915#4793]: https://gitlab.freedesktop.org/drm/intel/issues/4793
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4842]: https://gitlab.freedesktop.org/drm/intel/issues/4842
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4855]: https://gitlab.freedesktop.org/drm/intel/issues/4855
[i915#4859]: https://gitlab.freedesktop.org/drm/intel/issues/4859
[i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873
[i915#4881]: https://gitlab.freedesktop.org/drm/intel/issues/4881
[i915#4883]: https://gitlab.freedesktop.org/drm/intel/issues/4883
[i915#4911]: https://gitlab.freedesktop.org/drm/intel/issues/4911
[i915#4936]: https://gitlab.freedesktop.org/drm/intel/issues/4936
[i915#4939]: https://gitlab.freedesktop.org/drm/intel/issues/4939
[i915#4991]: https://gitlab.freedesktop.org/drm/intel/issues/4991
[i915#5072]: https://gitlab.freedesktop.org/drm/intel/issues/5072
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5287]: https://gitlab.freedesktop.org/drm/intel/issues/5287
[i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#5327]: https://gitlab.freedesktop.org/drm/intel/issues/5327
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5498]: https://gitlab.freedesktop.org/drm/intel/issues/5498
[i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5723]: https://gitlab.freedesktop.org/drm/intel/issues/5723
[i915#5726]: https://gitlab.freedesktop.org/drm/intel/issues/5726
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#5843]: https://gitlab.freedesktop.org/drm/intel/issues/5843
[i915#5939]: https://gitlab.freedesktop.org/drm/intel/issues/5939
[i915#6076]: https://gitlab.freedesktop.org/drm/intel/issues/6076
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6140]: https://gitlab.freedesktop.org/drm/intel/issues/6140
[i915#6141]: https://gitlab.freedesktop.org/drm/intel/issues/6141
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6259]: https://gitlab.freedesktop.org/drm/intel/issues/6259
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#768]: https://gitlab.freedesktop.org/drm/intel/issues/768
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
Build changes
-------------
* Linux: CI_DRM_11780 -> Patchwork_105358v1
CI-20190529: 20190529
CI_DRM_11780: e3c663c58e5fe6f5dc29ab062c7eea2540f42e1e @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6537: 331658a8475c8b0c0f7ffe5268a7318ef83da34e @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_105358v1: e3c663c58e5fe6f5dc29ab062c7eea2540f42e1e @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105358v1/index.html
[-- Attachment #2: Type: text/html, Size: 79173 bytes --]
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [Intel-gfx] [PATCH 01/16] drm/i915: use GRAPHICS_VER() instead of accessing match_info directly
2022-06-20 8:38 ` Jani Nikula
(?)
@ 2022-06-23 20:00 ` Ville Syrjälä
2022-06-28 14:10 ` Jani Nikula
-1 siblings, 1 reply; 29+ messages in thread
From: Ville Syrjälä @ 2022-06-23 20:00 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
On Mon, Jun 20, 2022 at 11:37:40AM +0300, Jani Nikula wrote:
> We've just set up device info in i915_driver_create() so we can use
> GRAPHICS_VER() intead of looking at match_info directly.
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/i915_driver.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_driver.c b/drivers/gpu/drm/i915/i915_driver.c
> index d26dcca7e654..aeec3dfe3ebf 100644
> --- a/drivers/gpu/drm/i915/i915_driver.c
> +++ b/drivers/gpu/drm/i915/i915_driver.c
> @@ -829,8 +829,6 @@ i915_driver_create(struct pci_dev *pdev, const struct pci_device_id *ent)
> */
> int i915_driver_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
> {
> - const struct intel_device_info *match_info =
> - (struct intel_device_info *)ent->driver_data;
> struct drm_i915_private *i915;
> int ret;
>
> @@ -839,7 +837,7 @@ int i915_driver_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
> return PTR_ERR(i915);
>
> /* Disable nuclear pageflip by default on pre-ILK */
> - if (!i915->params.nuclear_pageflip && match_info->graphics.ver < 5)
> + if (!i915->params.nuclear_pageflip && GRAPHICS_VER(i915) < 5)
Should also be switched to DISPLAY_VER(), but that could be done as a
separate patch too.
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> i915->drm.driver_features &= ~DRIVER_ATOMIC;
>
> ret = pci_enable_device(pdev);
> --
> 2.30.2
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [Intel-gfx] [PATCH 03/16] drm/i915: add initial runtime info into device info
2022-06-20 8:38 ` [Intel-gfx] [PATCH 03/16] drm/i915: add initial runtime info into device info Jani Nikula
@ 2022-06-23 20:05 ` Ville Syrjälä
0 siblings, 0 replies; 29+ messages in thread
From: Ville Syrjälä @ 2022-06-23 20:05 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
On Mon, Jun 20, 2022 at 11:38:02AM +0300, Jani Nikula wrote:
> Add initial runtime info that we can copy to runtime info at i915
> creation time. This lets us define the initial values for runtime info
> statically while making it possible to change them runtime. This will be
> the new home for the current "const" device info members that are
> modified runtime anyway.
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/i915_driver.c | 7 +++-
> drivers/gpu/drm/i915/intel_device_info.h | 41 +++++++++++++-----------
> 2 files changed, 29 insertions(+), 19 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_driver.c b/drivers/gpu/drm/i915/i915_driver.c
> index 0b00a05f1a74..5969cc7805d3 100644
> --- a/drivers/gpu/drm/i915/i915_driver.c
> +++ b/drivers/gpu/drm/i915/i915_driver.c
> @@ -796,6 +796,7 @@ i915_driver_create(struct pci_dev *pdev, const struct pci_device_id *ent)
> const struct intel_device_info *match_info =
> (struct intel_device_info *)ent->driver_data;
> struct intel_device_info *device_info;
> + struct intel_runtime_info *runtime;
> struct drm_i915_private *i915;
>
> i915 = devm_drm_dev_alloc(&pdev->dev, &i915_drm_driver,
> @@ -811,7 +812,11 @@ i915_driver_create(struct pci_dev *pdev, const struct pci_device_id *ent)
> /* Setup the write-once "constant" device info */
> device_info = mkwrite_device_info(i915);
> memcpy(device_info, match_info, sizeof(*device_info));
> - RUNTIME_INFO(i915)->device_id = pdev->device;
> +
> + /* Initialize initial runtime info from static const data and pdev. */
> + runtime = RUNTIME_INFO(i915);
> + memcpy(runtime, &INTEL_INFO(i915)->__runtime, sizeof(*runtime));
> + runtime->device_id = pdev->device;
>
> return i915;
> }
> diff --git a/drivers/gpu/drm/i915/intel_device_info.h b/drivers/gpu/drm/i915/intel_device_info.h
> index b86f68866e35..85385c98b9f4 100644
> --- a/drivers/gpu/drm/i915/intel_device_info.h
> +++ b/drivers/gpu/drm/i915/intel_device_info.h
> @@ -197,6 +197,27 @@ struct ip_version {
> u8 rel;
> };
>
> +struct intel_runtime_info {
> + /*
> + * Platform mask is used for optimizing or-ed IS_PLATFORM calls into
> + * into single runtime conditionals, and also to provide groundwork
> + * for future per platform, or per SKU build optimizations.
> + *
> + * Array can be extended when necessary if the corresponding
> + * BUILD_BUG_ON is hit.
> + */
> + u32 platform_mask[2];
> +
> + u16 device_id;
> +
> + u8 num_sprites[I915_MAX_PIPES];
> + u8 num_scalers[I915_MAX_PIPES];
I was just thinking about moving these out from runtime init,
and perhaps converting to something a bit less funky (eg. plane
bitmask or somesuch thing). But then I got lost trying to parse
my way through the macro hell in i915_pci.c...
> +
> + u32 rawclk_freq;
> +
> + struct intel_step_info step;
> +};
> +
> struct intel_device_info {
> struct ip_version graphics;
> struct ip_version media;
> @@ -252,27 +273,11 @@ struct intel_device_info {
> u32 degamma_lut_tests;
> u32 gamma_lut_tests;
> } color;
> -};
>
> -struct intel_runtime_info {
> /*
> - * Platform mask is used for optimizing or-ed IS_PLATFORM calls into
> - * into single runtime conditionals, and also to provide groundwork
> - * for future per platform, or per SKU build optimizations.
> - *
> - * Array can be extended when necessary if the corresponding
> - * BUILD_BUG_ON is hit.
> + * Initial runtime info. Do not access outside of i915_driver_create().
> */
> - u32 platform_mask[2];
> -
> - u16 device_id;
> -
> - u8 num_sprites[I915_MAX_PIPES];
> - u8 num_scalers[I915_MAX_PIPES];
> -
> - u32 rawclk_freq;
> -
> - struct intel_step_info step;
> + const struct intel_runtime_info __runtime;
> };
>
> struct intel_driver_caps {
> --
> 2.30.2
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [Intel-gfx] [PATCH 01/16] drm/i915: use GRAPHICS_VER() instead of accessing match_info directly
2022-06-23 20:00 ` Ville Syrjälä
@ 2022-06-28 14:10 ` Jani Nikula
0 siblings, 0 replies; 29+ messages in thread
From: Jani Nikula @ 2022-06-28 14:10 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
On Thu, 23 Jun 2022, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Mon, Jun 20, 2022 at 11:37:40AM +0300, Jani Nikula wrote:
>> We've just set up device info in i915_driver_create() so we can use
>> GRAPHICS_VER() intead of looking at match_info directly.
>>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> ---
>> drivers/gpu/drm/i915/i915_driver.c | 4 +---
>> 1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/i915_driver.c b/drivers/gpu/drm/i915/i915_driver.c
>> index d26dcca7e654..aeec3dfe3ebf 100644
>> --- a/drivers/gpu/drm/i915/i915_driver.c
>> +++ b/drivers/gpu/drm/i915/i915_driver.c
>> @@ -829,8 +829,6 @@ i915_driver_create(struct pci_dev *pdev, const struct pci_device_id *ent)
>> */
>> int i915_driver_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>> {
>> - const struct intel_device_info *match_info =
>> - (struct intel_device_info *)ent->driver_data;
>> struct drm_i915_private *i915;
>> int ret;
>>
>> @@ -839,7 +837,7 @@ int i915_driver_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>> return PTR_ERR(i915);
>>
>> /* Disable nuclear pageflip by default on pre-ILK */
>> - if (!i915->params.nuclear_pageflip && match_info->graphics.ver < 5)
>> + if (!i915->params.nuclear_pageflip && GRAPHICS_VER(i915) < 5)
>
> Should also be switched to DISPLAY_VER(), but that could be done as a
> separate patch too.
>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Thanks, I've sent this separately with s/GRAPHICS_VER/DISPLAY_VER/.
BR,
Jani.
>
>> i915->drm.driver_features &= ~DRIVER_ATOMIC;
>>
>> ret = pci_enable_device(pdev);
>> --
>> 2.30.2
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [Intel-gfx] [PATCH 16/16] drm/i915: make device info a pointer to static const data
2022-06-20 8:49 ` [Intel-gfx] [PATCH 16/16] drm/i915: make device info a pointer to static const data Jani Nikula
@ 2022-08-18 9:57 ` Maarten Lankhorst
2022-08-18 10:48 ` Jani Nikula
0 siblings, 1 reply; 29+ messages in thread
From: Maarten Lankhorst @ 2022-08-18 9:57 UTC (permalink / raw)
To: Jani Nikula, intel-gfx
Op 20-06-2022 om 10:49 schreef Jani Nikula:
> Now that the device info is no longer modified runtime, we don't need to
> make a copy of it, and we can convert i915->__info into a pointer to
> static const data. Also remove mkwrite_device_info().
>
> This does increase the text size slightly.
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> ---
>
> An alternative is to keep copying device info, but casting away the
> const only once at the copy time, removing mkwrite_device_info().
> ---
> drivers/gpu/drm/i915/i915_driver.c | 8 ++------
> drivers/gpu/drm/i915/i915_drv.h | 11 ++---------
> 2 files changed, 4 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_driver.c b/drivers/gpu/drm/i915/i915_driver.c
> index 5969cc7805d3..9c9c492e97a8 100644
> --- a/drivers/gpu/drm/i915/i915_driver.c
> +++ b/drivers/gpu/drm/i915/i915_driver.c
> @@ -793,9 +793,6 @@ static void i915_welcome_messages(struct drm_i915_private *dev_priv)
> static struct drm_i915_private *
> i915_driver_create(struct pci_dev *pdev, const struct pci_device_id *ent)
> {
> - const struct intel_device_info *match_info =
> - (struct intel_device_info *)ent->driver_data;
> - struct intel_device_info *device_info;
> struct intel_runtime_info *runtime;
> struct drm_i915_private *i915;
>
> @@ -809,9 +806,8 @@ i915_driver_create(struct pci_dev *pdev, const struct pci_device_id *ent)
> /* Device parameters start as a copy of module parameters. */
> i915_params_copy(&i915->params, &i915_modparams);
>
> - /* Setup the write-once "constant" device info */
> - device_info = mkwrite_device_info(i915);
> - memcpy(device_info, match_info, sizeof(*device_info));
> + /* Static const device info. */
> + i915->__info = (const struct intel_device_info *)ent->driver_data;
>
> /* Initialize initial runtime info from static const data and pdev. */
> runtime = RUNTIME_INFO(i915);
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index 89472440947c..a2a57f07c5be 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -380,7 +380,7 @@ struct drm_i915_private {
> /* i915 device parameters */
> struct i915_params params;
>
> - const struct intel_device_info __info; /* Use INTEL_INFO() to access. */
> + const struct intel_device_info *__info; /* Use INTEL_INFO() to access. */
> struct intel_runtime_info __runtime; /* Use RUNTIME_INFO() to access. */
> struct intel_driver_caps caps;
>
> @@ -848,7 +848,7 @@ static inline struct intel_gt *to_gt(struct drm_i915_private *i915)
> GENMASK(INTEL_FRONTBUFFER_BITS_PER_PIPE * ((pipe) + 1) - 1, \
> INTEL_FRONTBUFFER_BITS_PER_PIPE * (pipe))
>
> -#define INTEL_INFO(dev_priv) (&(dev_priv)->__info)
> +#define INTEL_INFO(__i915) (__i915->__info)
> #define RUNTIME_INFO(dev_priv) (&(dev_priv)->__runtime)
> #define DRIVER_CAPS(dev_priv) (&(dev_priv)->caps)
>
> @@ -1432,13 +1432,6 @@ void i915_gem_driver_release(struct drm_i915_private *dev_priv);
>
> int i915_gem_open(struct drm_i915_private *i915, struct drm_file *file);
>
> -/* intel_device_info.c */
> -static inline struct intel_device_info *
> -mkwrite_device_info(struct drm_i915_private *dev_priv)
> -{
> - return (struct intel_device_info *)INTEL_INFO(dev_priv);
> -}
> -
> static inline enum i915_map_type
> i915_coherent_map_type(struct drm_i915_private *i915,
> struct drm_i915_gem_object *obj, bool always_coherent)
I think just moving around things is safest in this case. I believe all should be moved to the new display sub-struct, but this is a start of making that easier.
For the series, except patch 5:
Reviewed-by: Maarten Lankhort <maarten.lankhorst@linux.intel.com>
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [Intel-gfx] [PATCH 16/16] drm/i915: make device info a pointer to static const data
2022-08-18 9:57 ` Maarten Lankhorst
@ 2022-08-18 10:48 ` Jani Nikula
2022-08-18 11:05 ` Maarten Lankhorst
0 siblings, 1 reply; 29+ messages in thread
From: Jani Nikula @ 2022-08-18 10:48 UTC (permalink / raw)
To: Maarten Lankhorst, intel-gfx
On Thu, 18 Aug 2022, Maarten Lankhorst <maarten.lankhorst@linux.intel.com> wrote:
> Op 20-06-2022 om 10:49 schreef Jani Nikula:
>> Now that the device info is no longer modified runtime, we don't need to
>> make a copy of it, and we can convert i915->__info into a pointer to
>> static const data. Also remove mkwrite_device_info().
>>
>> This does increase the text size slightly.
>>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>>
>> ---
>>
>> An alternative is to keep copying device info, but casting away the
>> const only once at the copy time, removing mkwrite_device_info().
>> ---
>> drivers/gpu/drm/i915/i915_driver.c | 8 ++------
>> drivers/gpu/drm/i915/i915_drv.h | 11 ++---------
>> 2 files changed, 4 insertions(+), 15 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/i915_driver.c b/drivers/gpu/drm/i915/i915_driver.c
>> index 5969cc7805d3..9c9c492e97a8 100644
>> --- a/drivers/gpu/drm/i915/i915_driver.c
>> +++ b/drivers/gpu/drm/i915/i915_driver.c
>> @@ -793,9 +793,6 @@ static void i915_welcome_messages(struct drm_i915_private *dev_priv)
>> static struct drm_i915_private *
>> i915_driver_create(struct pci_dev *pdev, const struct pci_device_id *ent)
>> {
>> - const struct intel_device_info *match_info =
>> - (struct intel_device_info *)ent->driver_data;
>> - struct intel_device_info *device_info;
>> struct intel_runtime_info *runtime;
>> struct drm_i915_private *i915;
>>
>> @@ -809,9 +806,8 @@ i915_driver_create(struct pci_dev *pdev, const struct pci_device_id *ent)
>> /* Device parameters start as a copy of module parameters. */
>> i915_params_copy(&i915->params, &i915_modparams);
>>
>> - /* Setup the write-once "constant" device info */
>> - device_info = mkwrite_device_info(i915);
>> - memcpy(device_info, match_info, sizeof(*device_info));
>> + /* Static const device info. */
>> + i915->__info = (const struct intel_device_info *)ent->driver_data;
>>
>> /* Initialize initial runtime info from static const data and pdev. */
>> runtime = RUNTIME_INFO(i915);
>> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
>> index 89472440947c..a2a57f07c5be 100644
>> --- a/drivers/gpu/drm/i915/i915_drv.h
>> +++ b/drivers/gpu/drm/i915/i915_drv.h
>> @@ -380,7 +380,7 @@ struct drm_i915_private {
>> /* i915 device parameters */
>> struct i915_params params;
>>
>> - const struct intel_device_info __info; /* Use INTEL_INFO() to access. */
>> + const struct intel_device_info *__info; /* Use INTEL_INFO() to access. */
>> struct intel_runtime_info __runtime; /* Use RUNTIME_INFO() to access. */
>> struct intel_driver_caps caps;
>>
>> @@ -848,7 +848,7 @@ static inline struct intel_gt *to_gt(struct drm_i915_private *i915)
>> GENMASK(INTEL_FRONTBUFFER_BITS_PER_PIPE * ((pipe) + 1) - 1, \
>> INTEL_FRONTBUFFER_BITS_PER_PIPE * (pipe))
>>
>> -#define INTEL_INFO(dev_priv) (&(dev_priv)->__info)
>> +#define INTEL_INFO(__i915) (__i915->__info)
>> #define RUNTIME_INFO(dev_priv) (&(dev_priv)->__runtime)
>> #define DRIVER_CAPS(dev_priv) (&(dev_priv)->caps)
>>
>> @@ -1432,13 +1432,6 @@ void i915_gem_driver_release(struct drm_i915_private *dev_priv);
>>
>> int i915_gem_open(struct drm_i915_private *i915, struct drm_file *file);
>>
>> -/* intel_device_info.c */
>> -static inline struct intel_device_info *
>> -mkwrite_device_info(struct drm_i915_private *dev_priv)
>> -{
>> - return (struct intel_device_info *)INTEL_INFO(dev_priv);
>> -}
>> -
>> static inline enum i915_map_type
>> i915_coherent_map_type(struct drm_i915_private *i915,
>> struct drm_i915_gem_object *obj, bool always_coherent)
>
> I think just moving around things is safest in this case. I believe
> all should be moved to the new display sub-struct, but this is a start
> of making that easier.
>
> For the series, except patch 5:
>
> Reviewed-by: Maarten Lankhort <maarten.lankhorst@linux.intel.com>
Thanks... but there's v2 starting at [1]. I don't recall any changes
other than rebase and slight reordering of patches.
What's wrong with patch 5? I mean it does get modified runtime.
BR,
Jani.
[1] https://lore.kernel.org/r/cover.1660137416.git.jani.nikula@intel.com
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [Intel-gfx] [PATCH 16/16] drm/i915: make device info a pointer to static const data
2022-08-18 10:48 ` Jani Nikula
@ 2022-08-18 11:05 ` Maarten Lankhorst
0 siblings, 0 replies; 29+ messages in thread
From: Maarten Lankhorst @ 2022-08-18 11:05 UTC (permalink / raw)
To: Jani Nikula, intel-gfx
Op 18-08-2022 om 12:48 schreef Jani Nikula:
> On Thu, 18 Aug 2022, Maarten Lankhorst <maarten.lankhorst@linux.intel.com> wrote:
>> Op 20-06-2022 om 10:49 schreef Jani Nikula:
>>> Now that the device info is no longer modified runtime, we don't need to
>>> make a copy of it, and we can convert i915->__info into a pointer to
>>> static const data. Also remove mkwrite_device_info().
>>>
>>> This does increase the text size slightly.
>>>
>>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>>>
>>> ---
>>>
>>> An alternative is to keep copying device info, but casting away the
>>> const only once at the copy time, removing mkwrite_device_info().
>>> ---
>>> drivers/gpu/drm/i915/i915_driver.c | 8 ++------
>>> drivers/gpu/drm/i915/i915_drv.h | 11 ++---------
>>> 2 files changed, 4 insertions(+), 15 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/i915/i915_driver.c b/drivers/gpu/drm/i915/i915_driver.c
>>> index 5969cc7805d3..9c9c492e97a8 100644
>>> --- a/drivers/gpu/drm/i915/i915_driver.c
>>> +++ b/drivers/gpu/drm/i915/i915_driver.c
>>> @@ -793,9 +793,6 @@ static void i915_welcome_messages(struct drm_i915_private *dev_priv)
>>> static struct drm_i915_private *
>>> i915_driver_create(struct pci_dev *pdev, const struct pci_device_id *ent)
>>> {
>>> - const struct intel_device_info *match_info =
>>> - (struct intel_device_info *)ent->driver_data;
>>> - struct intel_device_info *device_info;
>>> struct intel_runtime_info *runtime;
>>> struct drm_i915_private *i915;
>>>
>>> @@ -809,9 +806,8 @@ i915_driver_create(struct pci_dev *pdev, const struct pci_device_id *ent)
>>> /* Device parameters start as a copy of module parameters. */
>>> i915_params_copy(&i915->params, &i915_modparams);
>>>
>>> - /* Setup the write-once "constant" device info */
>>> - device_info = mkwrite_device_info(i915);
>>> - memcpy(device_info, match_info, sizeof(*device_info));
>>> + /* Static const device info. */
>>> + i915->__info = (const struct intel_device_info *)ent->driver_data;
>>>
>>> /* Initialize initial runtime info from static const data and pdev. */
>>> runtime = RUNTIME_INFO(i915);
>>> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
>>> index 89472440947c..a2a57f07c5be 100644
>>> --- a/drivers/gpu/drm/i915/i915_drv.h
>>> +++ b/drivers/gpu/drm/i915/i915_drv.h
>>> @@ -380,7 +380,7 @@ struct drm_i915_private {
>>> /* i915 device parameters */
>>> struct i915_params params;
>>>
>>> - const struct intel_device_info __info; /* Use INTEL_INFO() to access. */
>>> + const struct intel_device_info *__info; /* Use INTEL_INFO() to access. */
>>> struct intel_runtime_info __runtime; /* Use RUNTIME_INFO() to access. */
>>> struct intel_driver_caps caps;
>>>
>>> @@ -848,7 +848,7 @@ static inline struct intel_gt *to_gt(struct drm_i915_private *i915)
>>> GENMASK(INTEL_FRONTBUFFER_BITS_PER_PIPE * ((pipe) + 1) - 1, \
>>> INTEL_FRONTBUFFER_BITS_PER_PIPE * (pipe))
>>>
>>> -#define INTEL_INFO(dev_priv) (&(dev_priv)->__info)
>>> +#define INTEL_INFO(__i915) (__i915->__info)
>>> #define RUNTIME_INFO(dev_priv) (&(dev_priv)->__runtime)
>>> #define DRIVER_CAPS(dev_priv) (&(dev_priv)->caps)
>>>
>>> @@ -1432,13 +1432,6 @@ void i915_gem_driver_release(struct drm_i915_private *dev_priv);
>>>
>>> int i915_gem_open(struct drm_i915_private *i915, struct drm_file *file);
>>>
>>> -/* intel_device_info.c */
>>> -static inline struct intel_device_info *
>>> -mkwrite_device_info(struct drm_i915_private *dev_priv)
>>> -{
>>> - return (struct intel_device_info *)INTEL_INFO(dev_priv);
>>> -}
>>> -
>>> static inline enum i915_map_type
>>> i915_coherent_map_type(struct drm_i915_private *i915,
>>> struct drm_i915_gem_object *obj, bool always_coherent)
>> I think just moving around things is safest in this case. I believe
>> all should be moved to the new display sub-struct, but this is a start
>> of making that easier.
>>
>> For the series, except patch 5:
>>
>> Reviewed-by: Maarten Lankhort <maarten.lankhorst@linux.intel.com>
> Thanks... but there's v2 starting at [1]. I don't recall any changes
> other than rebase and slight reordering of patches.
>
> What's wrong with patch 5? I mean it does get modified runtime.
>
> BR,
> Jani.
>
>
>
> [1] https://lore.kernel.org/r/cover.1660137416.git.jani.nikula@intel.com
>
>
Sorry, except 5 was for the display split series. Patch 5 from this series is fine. :)
^ permalink raw reply [flat|nested] 29+ messages in thread
end of thread, other threads:[~2022-08-18 11:06 UTC | newest]
Thread overview: 29+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-20 8:37 [Intel-gfx] [PATCH 00/16] drm/i915: stop modifying "const" device info Jani Nikula
2022-06-20 8:37 ` Jani Nikula
2022-06-20 8:37 ` [Intel-gfx] [PATCH 01/16] drm/i915: use GRAPHICS_VER() instead of accessing match_info directly Jani Nikula
2022-06-20 8:38 ` Jani Nikula
2022-06-23 20:00 ` Ville Syrjälä
2022-06-28 14:10 ` Jani Nikula
2022-06-20 8:38 ` [Intel-gfx] [PATCH 02/16] drm/i915: combine device info printing into one Jani Nikula
2022-06-20 8:38 ` [Intel-gfx] [PATCH 03/16] drm/i915: add initial runtime info into device info Jani Nikula
2022-06-23 20:05 ` Ville Syrjälä
2022-06-20 8:38 ` [Intel-gfx] [PATCH 04/16] drm/i915: move fbc_mask to runtime info Jani Nikula
2022-06-20 8:38 ` [Intel-gfx] [PATCH 05/16] drm/i915: move page_sizes " Jani Nikula
2022-06-20 8:38 ` [Intel-gfx] [PATCH 06/16] drm/i915: move ppgtt_type and ppgtt_size " Jani Nikula
2022-06-20 8:49 ` [Intel-gfx] [PATCH 07/16] drm/i915: move has_pooled_eu " Jani Nikula
2022-06-20 8:49 ` [Intel-gfx] [PATCH 08/16] drm/i915: move memory_regions " Jani Nikula
2022-06-20 8:49 ` [Intel-gfx] [PATCH 09/16] drm/i915: move platform_engine_mask " Jani Nikula
2022-06-20 8:49 ` [Intel-gfx] [PATCH 10/16] drm/i915: move graphics.ver and graphics.rel " Jani Nikula
2022-06-20 8:49 ` [Intel-gfx] [PATCH 11/16] drm/i915: move pipe_mask and cpu_transcoder_mask " Jani Nikula
2022-06-20 8:49 ` [Intel-gfx] [PATCH 12/16] drm/i915: move has_hdcp " Jani Nikula
2022-06-20 8:49 ` [Intel-gfx] [PATCH 13/16] drm/i915: move has_dmc " Jani Nikula
2022-06-20 8:49 ` [Intel-gfx] [PATCH 14/16] drm/i915: move has_dsc " Jani Nikula
2022-06-20 8:49 ` [Intel-gfx] [PATCH 15/16] drm/i915: stop resetting display info to zero for no display Jani Nikula
2022-06-20 8:49 ` [Intel-gfx] [PATCH 16/16] drm/i915: make device info a pointer to static const data Jani Nikula
2022-08-18 9:57 ` Maarten Lankhorst
2022-08-18 10:48 ` Jani Nikula
2022-08-18 11:05 ` Maarten Lankhorst
2022-06-20 8:54 ` [Intel-gfx] [PATCH 00/16] drm/i915: stop modifying "const" device info Jani Nikula
2022-06-20 14:16 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2022-06-20 14:43 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-06-20 19:45 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.