All of lore.kernel.org
 help / color / mirror / Atom feed
From: Siddh Raman Pant via Linux-kernel-mentees <linux-kernel-mentees@lists.linuxfoundation.org>
To: Eric Biggers <ebiggers@kernel.org>,
	Jonathan Corbet <corbet@lwn.net>,
	David Howells <dhowells@redhat.com>,
	Randy Dunlap <rdunlap@infradead.org>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
	Eric Dumazet <edumazet@google.com>
Cc: linux-kernel-mentees
	<linux-kernel-mentees@lists.linuxfoundation.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH 0/3] kernel/watch_queue: Clean up some code
Date: Thu,  4 Aug 2022 19:00:21 +0530	[thread overview]
Message-ID: <cover.1659618705.git.code@siddh.me> (raw)

There is a dangling reference to pipe in a watch_queue after clearing it.
Thus, NULL that pointer while clearing. This can be thought of as a v4 of
the patches I had sent earlier.

This change renders wqueue->defunct superfluous, as the latter is only used
to check if watch_queue is cleared. With this change, the pipe is NULL'd
while clearing, so we can just check if the pipe is NULL.

Extending comment for watch_queue->pipe in the definition of watch_queue
made the comment conventionally too long (it was already past 80 chars),
so I have changed the struct annotations to be doxygen-styled, so that
I can extend the comment mentioning that the pipe is NULL when watch_queue
is cleared.

Siddh Raman Pant (3):
  kernel/watch_queue: Remove dangling pipe reference while clearing
    watch_queue
  kernel/watch_queue: Improve struct annotation formatting
  kernel/watch_queue: Remove wqueue->defunct and use pipe for clear
    check

 include/linux/watch_queue.h | 95 +++++++++++++++++++++++++++----------
 kernel/watch_queue.c        | 11 ++---
 2 files changed, 75 insertions(+), 31 deletions(-)

-- 
2.35.1


_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

WARNING: multiple messages have this Message-ID (diff)
From: Siddh Raman Pant <code@siddh.me>
To: Eric Biggers <ebiggers@kernel.org>,
	Jonathan Corbet <corbet@lwn.net>,
	David Howells <dhowells@redhat.com>,
	Randy Dunlap <rdunlap@infradead.org>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
	Eric Dumazet <edumazet@google.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	linux-kernel-mentees 
	<linux-kernel-mentees@lists.linuxfoundation.org>
Subject: [PATCH 0/3] kernel/watch_queue: Clean up some code
Date: Thu,  4 Aug 2022 19:00:21 +0530	[thread overview]
Message-ID: <cover.1659618705.git.code@siddh.me> (raw)

There is a dangling reference to pipe in a watch_queue after clearing it.
Thus, NULL that pointer while clearing. This can be thought of as a v4 of
the patches I had sent earlier.

This change renders wqueue->defunct superfluous, as the latter is only used
to check if watch_queue is cleared. With this change, the pipe is NULL'd
while clearing, so we can just check if the pipe is NULL.

Extending comment for watch_queue->pipe in the definition of watch_queue
made the comment conventionally too long (it was already past 80 chars),
so I have changed the struct annotations to be doxygen-styled, so that
I can extend the comment mentioning that the pipe is NULL when watch_queue
is cleared.

Siddh Raman Pant (3):
  kernel/watch_queue: Remove dangling pipe reference while clearing
    watch_queue
  kernel/watch_queue: Improve struct annotation formatting
  kernel/watch_queue: Remove wqueue->defunct and use pipe for clear
    check

 include/linux/watch_queue.h | 95 +++++++++++++++++++++++++++----------
 kernel/watch_queue.c        | 11 ++---
 2 files changed, 75 insertions(+), 31 deletions(-)

-- 
2.35.1



             reply	other threads:[~2022-08-04 13:31 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-04 13:30 Siddh Raman Pant via Linux-kernel-mentees [this message]
2022-08-04 13:30 ` [PATCH 0/3] kernel/watch_queue: Clean up some code Siddh Raman Pant
2022-08-04 13:30 ` [PATCH 1/3 v4] kernel/watch_queue: Remove dangling pipe reference while clearing watch_queue Siddh Raman Pant via Linux-kernel-mentees
2022-08-04 13:30   ` Siddh Raman Pant
2022-08-04 13:30 ` [PATCH 2/3] kernel/watch_queue: Improve struct annotation formatting Siddh Raman Pant via Linux-kernel-mentees
2022-08-04 13:30   ` Siddh Raman Pant
2022-08-05  7:22   ` Eric Biggers
2022-08-05  7:22     ` Eric Biggers
2022-08-05  9:35     ` Siddh Raman Pant via Linux-kernel-mentees
2022-08-05  9:35       ` Siddh Raman Pant
2022-08-04 13:30 ` [PATCH 3/3] kernel/watch_queue: Remove wqueue->defunct and use pipe for clear check Siddh Raman Pant via Linux-kernel-mentees
2022-08-04 13:30   ` Siddh Raman Pant
2022-08-04 14:41   ` [PATCH v2 " Siddh Raman Pant via Linux-kernel-mentees
2022-08-04 14:41     ` Siddh Raman Pant
2022-08-05  7:24     ` Eric Biggers
2022-08-05  7:24       ` Eric Biggers
2022-08-05  9:35       ` Siddh Raman Pant via Linux-kernel-mentees
2022-08-05  9:35         ` Siddh Raman Pant
2022-08-05 18:33         ` Eric Biggers
2022-08-05 18:33           ` Eric Biggers
2022-08-06  7:23           ` Siddh Raman Pant
2022-08-06  7:23             ` Siddh Raman Pant via Linux-kernel-mentees
2022-08-05  7:16 ` [PATCH 0/3] kernel/watch_queue: Clean up some code Eric Biggers
2022-08-05  7:16   ` Eric Biggers
2022-08-05  9:35   ` Siddh Raman Pant via Linux-kernel-mentees
2022-08-05  9:35     ` Siddh Raman Pant

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1659618705.git.code@siddh.me \
    --to=linux-kernel-mentees@lists.linuxfoundation.org \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=code@siddh.me \
    --cc=corbet@lwn.net \
    --cc=dhowells@redhat.com \
    --cc=ebiggers@kernel.org \
    --cc=edumazet@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=rdunlap@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.