From: "Michael S. Tsirkin" <mst@redhat.com> To: virtio-comment@lists.oasis-open.org, virtio-dev@lists.oasis-open.org, jasowang@redhat.com, mst@redhat.com, cohuck@redhat.com, sgarzare@redhat.com, stefanha@redhat.com, nrupal.jani@intel.com, Piotr.Uminski@intel.com, hang.yuan@intel.com Cc: virtio@lists.oasis-open.org, Jiri Pirko <jiri@nvidia.com>, Zhu Lingshan <lingshan.zhu@intel.com>, pasic@linux.ibm.com, Shahaf Shuler <shahafs@nvidia.com>, Parav Pandit <parav@nvidia.com>, Max Gurtovoy <mgurtovoy@nvidia.com> Subject: [virtio-dev] [PATCH v13 00/10] Introduce device group and device management Date: Fri, 5 May 2023 11:40:33 -0400 [thread overview] Message-ID: <cover.1683301091.git.mst@redhat.com> (raw) Change log: since 13: command specific data is u8 again exclude admin queues in blk's num_queues minor other tweaks since 11: addressed lots of comments, all minor. consistency with outstanding number->index and queue->enqueue work i did not intentionally drop any reviewed-by tags as all changes are minor - if yours is missing it is because I forgot to record it, sorry one "breaking" change in response to stefan's comment: in patch 5, num_queues has been specified not to include admin queues: just regular ones. since v10: addressed lots of comments by Jiri, Stefan. Cornelia, Lngshan, Parav, Max since v9: addressed comments by Parav, Max, Cornelia, David and Zhu Lingshan: added link to errno header from Linux rename _MEM to _MEMBER admin vq num is zero based clarify who sends commands where minor english tweaks clarify command length specify interaction with sriov capability correct commit log - NumVFs can be 0 i could not decide what should happen when VFs are disabled. for now did not specify. since v8: addressed comments by Cornelia - as we agreed on list since v7: make high level error codes match linux, with virtio specific codes in a separate field renamed _ACCEPT to _USE since that's what it does clarified forward compatibility and non pci transports support multiple admin vqs conformance statements lots of changes all over the place to I changed author from Max to myself. Don't need to take credit but also don't want to blame Max for my mistakes. since v6: - removed some extentions intended for future use. We'll do them when we get there. - brought back command list query from v5 in a simplified form - it's here to address the case where a single parent can address multiple groups, such as PF addressing transport vq and sriov vfs. - attempt to make terminology more formal. In particular a term for whoever controls the group. I am still going back and forth between "parent" and "owner" - owner might be better after all since it will work if we ever have a self group. For now it's parent. TODO (maybe?) - probably ok to defer until this part is upstream: Add "all members" member id. Add commands for MSI, feature discovery. Add commands for transport vq. My intent is to try and support both SR-IOV and SIOV usecases with the same structure and maybe even the same VQ. For example, it might make sense to split creating/destroying SIOV devices from the transport passing data from the guest - the driver would then not negotiate VIRTIO_F_SR_IOV (which then means auto-provisioning). More ideas for use-cases: virtio VF features query and configuration space provisioning virtio VF resource (queues, msix vectors count) provisioning Future directions (shouldn't block this patch) - aborting commands - left for later. or is vq reset enough? - should we rename structures from admin to group admin? Michael S. Tsirkin (10): virtio: document forward compatibility guarantees admin: introduce device group and related concepts admin: introduce group administration commands admin: introduce virtio admin virtqueues pci: add admin vq registers to virtio over pci mmio: document ADMIN_VQ as reserved ccw: document ADMIN_VQ as reserved admin: command list discovery admin: conformance clauses ccw: document more reserved features admin.tex | 584 +++++++++++++++++++++++++++++++ content.tex | 62 +++- device-types/blk/description.tex | 2 +- introduction.tex | 3 + transport-ccw.tex | 14 + transport-mmio.tex | 12 + transport-pci.tex | 33 ++ 7 files changed, 707 insertions(+), 3 deletions(-) create mode 100644 admin.tex -- MST --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com> To: virtio-comment@lists.oasis-open.org, virtio-dev@lists.oasis-open.org, jasowang@redhat.com, mst@redhat.com, cohuck@redhat.com, sgarzare@redhat.com, stefanha@redhat.com, nrupal.jani@intel.com, Piotr.Uminski@intel.com, hang.yuan@intel.com Cc: virtio@lists.oasis-open.org, Jiri Pirko <jiri@nvidia.com>, Zhu Lingshan <lingshan.zhu@intel.com>, pasic@linux.ibm.com, Shahaf Shuler <shahafs@nvidia.com>, Parav Pandit <parav@nvidia.com>, Max Gurtovoy <mgurtovoy@nvidia.com> Subject: [virtio-comment] [PATCH v13 00/10] Introduce device group and device management Date: Fri, 5 May 2023 11:40:33 -0400 [thread overview] Message-ID: <cover.1683301091.git.mst@redhat.com> (raw) Change log: since 13: command specific data is u8 again exclude admin queues in blk's num_queues minor other tweaks since 11: addressed lots of comments, all minor. consistency with outstanding number->index and queue->enqueue work i did not intentionally drop any reviewed-by tags as all changes are minor - if yours is missing it is because I forgot to record it, sorry one "breaking" change in response to stefan's comment: in patch 5, num_queues has been specified not to include admin queues: just regular ones. since v10: addressed lots of comments by Jiri, Stefan. Cornelia, Lngshan, Parav, Max since v9: addressed comments by Parav, Max, Cornelia, David and Zhu Lingshan: added link to errno header from Linux rename _MEM to _MEMBER admin vq num is zero based clarify who sends commands where minor english tweaks clarify command length specify interaction with sriov capability correct commit log - NumVFs can be 0 i could not decide what should happen when VFs are disabled. for now did not specify. since v8: addressed comments by Cornelia - as we agreed on list since v7: make high level error codes match linux, with virtio specific codes in a separate field renamed _ACCEPT to _USE since that's what it does clarified forward compatibility and non pci transports support multiple admin vqs conformance statements lots of changes all over the place to I changed author from Max to myself. Don't need to take credit but also don't want to blame Max for my mistakes. since v6: - removed some extentions intended for future use. We'll do them when we get there. - brought back command list query from v5 in a simplified form - it's here to address the case where a single parent can address multiple groups, such as PF addressing transport vq and sriov vfs. - attempt to make terminology more formal. In particular a term for whoever controls the group. I am still going back and forth between "parent" and "owner" - owner might be better after all since it will work if we ever have a self group. For now it's parent. TODO (maybe?) - probably ok to defer until this part is upstream: Add "all members" member id. Add commands for MSI, feature discovery. Add commands for transport vq. My intent is to try and support both SR-IOV and SIOV usecases with the same structure and maybe even the same VQ. For example, it might make sense to split creating/destroying SIOV devices from the transport passing data from the guest - the driver would then not negotiate VIRTIO_F_SR_IOV (which then means auto-provisioning). More ideas for use-cases: virtio VF features query and configuration space provisioning virtio VF resource (queues, msix vectors count) provisioning Future directions (shouldn't block this patch) - aborting commands - left for later. or is vq reset enough? - should we rename structures from admin to group admin? Michael S. Tsirkin (10): virtio: document forward compatibility guarantees admin: introduce device group and related concepts admin: introduce group administration commands admin: introduce virtio admin virtqueues pci: add admin vq registers to virtio over pci mmio: document ADMIN_VQ as reserved ccw: document ADMIN_VQ as reserved admin: command list discovery admin: conformance clauses ccw: document more reserved features admin.tex | 584 +++++++++++++++++++++++++++++++ content.tex | 62 +++- device-types/blk/description.tex | 2 +- introduction.tex | 3 + transport-ccw.tex | 14 + transport-mmio.tex | 12 + transport-pci.tex | 33 ++ 7 files changed, 707 insertions(+), 3 deletions(-) create mode 100644 admin.tex -- MST This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC. In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting. Subscribe: virtio-comment-subscribe@lists.oasis-open.org Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org List help: virtio-comment-help@lists.oasis-open.org List archive: https://lists.oasis-open.org/archives/virtio-comment/ Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists Committee: https://www.oasis-open.org/committees/virtio/ Join OASIS: https://www.oasis-open.org/join/
next reply other threads:[~2023-05-05 15:40 UTC|newest] Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-05-05 15:40 Michael S. Tsirkin [this message] 2023-05-05 15:40 ` [virtio-comment] [PATCH v13 00/10] Introduce device group and device management Michael S. Tsirkin 2023-05-05 15:40 ` [virtio-dev] [PATCH v13 01/10] virtio: document forward compatibility guarantees Michael S. Tsirkin 2023-05-05 15:40 ` [virtio-comment] " Michael S. Tsirkin 2023-05-05 15:40 ` [virtio-dev] [PATCH v13 02/10] admin: introduce device group and related concepts Michael S. Tsirkin 2023-05-05 15:40 ` [virtio-comment] " Michael S. Tsirkin 2023-05-05 16:46 ` [virtio-dev] " Parav Pandit 2023-05-05 16:46 ` [virtio-comment] " Parav Pandit 2023-05-05 15:40 ` [virtio-dev] [PATCH v13 03/10] admin: introduce group administration commands Michael S. Tsirkin 2023-05-05 15:40 ` [virtio-comment] " Michael S. Tsirkin 2023-05-05 16:03 ` [virtio-dev] " Parav Pandit 2023-05-05 16:03 ` [virtio-comment] " Parav Pandit 2023-05-05 16:39 ` [virtio-dev] RE: [virtio] " Parav Pandit 2023-05-05 16:39 ` [virtio-comment] " Parav Pandit 2023-05-05 15:40 ` [virtio-dev] [PATCH v13 04/10] admin: introduce virtio admin virtqueues Michael S. Tsirkin 2023-05-05 15:40 ` [virtio-comment] " Michael S. Tsirkin 2023-05-05 16:59 ` [virtio-dev] " Parav Pandit 2023-05-05 16:59 ` [virtio-comment] " Parav Pandit 2023-05-05 15:40 ` [virtio-dev] [PATCH v13 05/10] pci: add admin vq registers to virtio over pci Michael S. Tsirkin 2023-05-05 15:40 ` [virtio-comment] " Michael S. Tsirkin 2023-05-05 17:21 ` [virtio-dev] " Parav Pandit 2023-05-05 17:21 ` [virtio-comment] " Parav Pandit 2023-05-05 15:40 ` [virtio-dev] [PATCH v13 06/10] mmio: document ADMIN_VQ as reserved Michael S. Tsirkin 2023-05-05 15:40 ` [virtio-comment] " Michael S. Tsirkin 2023-05-05 15:40 ` [virtio-dev] [PATCH v13 07/10] ccw: " Michael S. Tsirkin 2023-05-05 15:40 ` [virtio-comment] " Michael S. Tsirkin 2023-05-05 15:41 ` [virtio-dev] [PATCH v13 08/10] admin: command list discovery Michael S. Tsirkin 2023-05-05 15:41 ` [virtio-comment] " Michael S. Tsirkin 2023-05-05 17:26 ` [virtio-dev] " Parav Pandit 2023-05-05 17:26 ` [virtio-comment] " Parav Pandit 2023-05-05 15:41 ` [virtio-dev] [PATCH v13 09/10] admin: conformance clauses Michael S. Tsirkin 2023-05-05 15:41 ` [virtio-comment] " Michael S. Tsirkin 2023-05-05 15:41 ` [virtio-dev] [PATCH v13 10/10] ccw: document more reserved features Michael S. Tsirkin 2023-05-05 15:41 ` [virtio-comment] " Michael S. Tsirkin 2023-05-05 17:23 ` [virtio-dev] " Parav Pandit 2023-05-05 17:23 ` [virtio-comment] " Parav Pandit 2023-05-05 15:45 ` [virtio-dev] Re: [PATCH v13 00/10] Introduce device group and device management Michael S. Tsirkin 2023-05-05 15:45 ` [virtio-comment] " Michael S. Tsirkin 2023-05-10 14:30 ` [virtio-dev] " Jiri Pirko 2023-05-10 14:30 ` [virtio-comment] " Jiri Pirko 2023-05-10 14:33 ` [virtio-dev] " Parav Pandit 2023-05-10 14:33 ` [virtio-comment] " Parav Pandit 2023-05-10 14:45 ` [virtio-dev] " Jiri Pirko 2023-05-10 14:45 ` [virtio-comment] " Jiri Pirko 2023-05-10 16:11 ` Michael S. Tsirkin 2023-05-10 16:11 ` [virtio-dev] " Michael S. Tsirkin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=cover.1683301091.git.mst@redhat.com \ --to=mst@redhat.com \ --cc=Piotr.Uminski@intel.com \ --cc=cohuck@redhat.com \ --cc=hang.yuan@intel.com \ --cc=jasowang@redhat.com \ --cc=jiri@nvidia.com \ --cc=lingshan.zhu@intel.com \ --cc=mgurtovoy@nvidia.com \ --cc=nrupal.jani@intel.com \ --cc=parav@nvidia.com \ --cc=pasic@linux.ibm.com \ --cc=sgarzare@redhat.com \ --cc=shahafs@nvidia.com \ --cc=stefanha@redhat.com \ --cc=virtio-comment@lists.oasis-open.org \ --cc=virtio-dev@lists.oasis-open.org \ --cc=virtio@lists.oasis-open.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.