* [PATCH] staging: vc04_services: Remove unnecessary casts.
@ 2019-04-02 4:49 Sanjana Sanikommu
2019-04-02 5:40 ` sanjana99reddy99
0 siblings, 1 reply; 3+ messages in thread
From: Sanjana Sanikommu @ 2019-04-02 4:49 UTC (permalink / raw)
To: gregkh; +Cc: outreachy-kernel
Explicit type casting of variable, with same type as
that of variable, is not required.
Issue found using coccinelle.
Signed-off-by: Sanjana Sanikommu <sanjana99reddy99@gmail.com>
---
.../vc04_services/interface/vchiq_arm/vchiq_arm.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
index 804daf83be35..bd24ef9bc1cb 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
@@ -417,13 +417,13 @@ vchiq_bulk_transmit(VCHIQ_SERVICE_HANDLE_T handle, const void *data,
switch (mode) {
case VCHIQ_BULK_MODE_NOCALLBACK:
case VCHIQ_BULK_MODE_CALLBACK:
- status = vchiq_bulk_transfer(handle, (void *)data, size,
+ status = vchiq_bulk_transfer(handle, data, size,
userdata, mode,
VCHIQ_BULK_TRANSMIT);
break;
case VCHIQ_BULK_MODE_BLOCKING:
status = vchiq_blocking_bulk_transfer(handle,
- (void *)data, size, VCHIQ_BULK_TRANSMIT);
+ data, size, VCHIQ_BULK_TRANSMIT);
break;
default:
return VCHIQ_ERROR;
@@ -447,7 +447,7 @@ vchiq_bulk_receive(VCHIQ_SERVICE_HANDLE_T handle, void *data,
break;
case VCHIQ_BULK_MODE_BLOCKING:
status = vchiq_blocking_bulk_transfer(handle,
- (void *)data, size, VCHIQ_BULK_RECEIVE);
+ data, size, VCHIQ_BULK_RECEIVE);
break;
default:
return VCHIQ_ERROR;
@@ -1381,7 +1381,7 @@ vchiq_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
else if (header->size <= args.bufsize) {
/* Copy to user space if msgbuf is not NULL */
if ((args.buf == NULL) ||
- (copy_to_user((void __user *)args.buf,
+ (copy_to_user(args.buf,
header->data,
header->size) == 0)) {
ret = header->size;
@@ -2113,7 +2113,7 @@ static int vchiq_release(struct inode *inode, struct file *file)
void
vchiq_dump(void *dump_context, const char *str, int len)
{
- struct dump_context *context = (struct dump_context *)dump_context;
+ struct dump_context *context = dump_context;
if (context->actual < context->space) {
int copy_bytes;
@@ -2322,7 +2322,7 @@ vchiq_keepalive_vchiq_callback(VCHIQ_REASON_T reason,
static int
vchiq_keepalive_thread_func(void *v)
{
- struct vchiq_state *state = (struct vchiq_state *)v;
+ struct vchiq_state *state = v;
struct vchiq_arm_state *arm_state = vchiq_platform_get_arm_state(state);
VCHIQ_STATUS_T status;
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: vc04_services: Remove unnecessary casts.
2019-04-02 4:49 [PATCH] staging: vc04_services: Remove unnecessary casts Sanjana Sanikommu
@ 2019-04-02 5:40 ` sanjana99reddy99
0 siblings, 0 replies; 3+ messages in thread
From: sanjana99reddy99 @ 2019-04-02 5:40 UTC (permalink / raw)
To: outreachy-kernel
[-- Attachment #1.1: Type: text/plain, Size: 3482 bytes --]
Please ignore this patch. Build is broken
Thank you
Sanjana
On Tuesday, April 2, 2019 at 10:19:21 AM UTC+5:30, Sanjana Sanikommu wrote:
>
> Explicit type casting of variable, with same type as
> that of variable, is not required.
> Issue found using coccinelle.
>
> Signed-off-by: Sanjana Sanikommu <sanjana99reddy99@gmail.com>
> ---
> .../vc04_services/interface/vchiq_arm/vchiq_arm.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> index 804daf83be35..bd24ef9bc1cb 100644
> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> @@ -417,13 +417,13 @@ vchiq_bulk_transmit(VCHIQ_SERVICE_HANDLE_T handle,
> const void *data,
> switch (mode) {
> case VCHIQ_BULK_MODE_NOCALLBACK:
> case VCHIQ_BULK_MODE_CALLBACK:
> - status = vchiq_bulk_transfer(handle, (void *)data, size,
> + status = vchiq_bulk_transfer(handle, data, size,
> userdata, mode,
> VCHIQ_BULK_TRANSMIT);
> break;
> case VCHIQ_BULK_MODE_BLOCKING:
> status = vchiq_blocking_bulk_transfer(handle,
> - (void *)data, size, VCHIQ_BULK_TRANSMIT);
> + data, size, VCHIQ_BULK_TRANSMIT);
> break;
> default:
> return VCHIQ_ERROR;
> @@ -447,7 +447,7 @@ vchiq_bulk_receive(VCHIQ_SERVICE_HANDLE_T handle, void
> *data,
> break;
> case VCHIQ_BULK_MODE_BLOCKING:
> status = vchiq_blocking_bulk_transfer(handle,
> - (void *)data, size, VCHIQ_BULK_RECEIVE);
> + data, size, VCHIQ_BULK_RECEIVE);
> break;
> default:
> return VCHIQ_ERROR;
> @@ -1381,7 +1381,7 @@ vchiq_ioctl(struct file *file, unsigned int cmd,
> unsigned long arg)
> else if (header->size <= args.bufsize) {
> /* Copy to user space if msgbuf is not NULL */
> if ((args.buf == NULL) ||
> - (copy_to_user((void __user *)args.buf,
> + (copy_to_user(args.buf,
> header->data,
> header->size) == 0)) {
> ret = header->size;
> @@ -2113,7 +2113,7 @@ static int vchiq_release(struct inode *inode, struct
> file *file)
> void
> vchiq_dump(void *dump_context, const char *str, int len)
> {
> - struct dump_context *context = (struct dump_context
> *)dump_context;
> + struct dump_context *context = dump_context;
>
> if (context->actual < context->space) {
> int copy_bytes;
> @@ -2322,7 +2322,7 @@ vchiq_keepalive_vchiq_callback(VCHIQ_REASON_T
> reason,
> static int
> vchiq_keepalive_thread_func(void *v)
> {
> - struct vchiq_state *state = (struct vchiq_state *)v;
> + struct vchiq_state *state = v;
> struct vchiq_arm_state *arm_state =
> vchiq_platform_get_arm_state(state);
>
> VCHIQ_STATUS_T status;
> --
> 2.17.1
>
>
[-- Attachment #1.2: Type: text/html, Size: 4889 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] staging: vc04_services: Remove unnecessary casts.
@ 2019-04-01 14:35 Sanjana Sanikommu
0 siblings, 0 replies; 3+ messages in thread
From: Sanjana Sanikommu @ 2019-04-01 14:35 UTC (permalink / raw)
To: gregkh; +Cc: outreachy-kernel
Explicit type casting of variable, with same type as
that of variable, is not required.
Issue found using coccinelle.
Signed-off-by: Sanjana Sanikommu <sanjana99reddy99@gmail.com>
---
.../vc04_services/interface/vchiq_arm/vchiq_core.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
index 53f5a1cb4636..c60db447ae8e 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
@@ -1877,7 +1877,7 @@ parse_rx_slots(struct vchiq_state *state)
static int
slot_handler_func(void *v)
{
- struct vchiq_state *state = (struct vchiq_state *)v;
+ struct vchiq_state *state = v;
struct vchiq_shared_state *local = state->local;
DEBUG_INITIALISE(local)
@@ -1961,7 +1961,7 @@ slot_handler_func(void *v)
static int
recycle_func(void *v)
{
- struct vchiq_state *state = (struct vchiq_state *)v;
+ struct vchiq_state *state = v;
struct vchiq_shared_state *local = state->local;
BITSET_T *found;
size_t length;
@@ -1985,7 +1985,7 @@ recycle_func(void *v)
static int
sync_func(void *v)
{
- struct vchiq_state *state = (struct vchiq_state *)v;
+ struct vchiq_state *state = v;
struct vchiq_shared_state *local = state->local;
struct vchiq_header *header =
(struct vchiq_header *)SLOT_DATA_FROM_INDEX(state,
@@ -2111,7 +2111,7 @@ vchiq_init_slots(void *mem_base, int mem_size)
int mem_align =
(int)((VCHIQ_SLOT_SIZE - (long)mem_base) & VCHIQ_SLOT_MASK);
struct vchiq_slot_zero *slot_zero =
- (struct vchiq_slot_zero *)((char *)mem_base + mem_align);
+ (struct vchiq_slot_zero *)(mem_base + mem_align);
int num_slots = (mem_size - mem_align)/VCHIQ_SLOT_SIZE;
int first_data_slot = VCHIQ_SLOT_ZERO_SLOTS;
@@ -3039,13 +3039,13 @@ VCHIQ_STATUS_T vchiq_bulk_transfer(VCHIQ_SERVICE_HANDLE_T handle,
case VCHIQ_BULK_MODE_CALLBACK:
break;
case VCHIQ_BULK_MODE_BLOCKING:
- bulk_waiter = (struct bulk_waiter *)userdata;
+ bulk_waiter = userdata;
init_completion(&bulk_waiter->event);
bulk_waiter->actual = 0;
bulk_waiter->bulk = NULL;
break;
case VCHIQ_BULK_MODE_WAITING:
- bulk_waiter = (struct bulk_waiter *)userdata;
+ bulk_waiter = userdata;
bulk = bulk_waiter->bulk;
goto waiting;
default:
@@ -3624,7 +3624,7 @@ VCHIQ_STATUS_T vchiq_send_remote_use_active(struct vchiq_state *state)
void vchiq_log_dump_mem(const char *label, u32 addr, const void *void_mem,
size_t num_bytes)
{
- const u8 *mem = (const u8 *)void_mem;
+ const u8 *mem = void_mem;
size_t offset;
char line_buf[100];
char *s;
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-02 5:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-02 4:49 [PATCH] staging: vc04_services: Remove unnecessary casts Sanjana Sanikommu
2019-04-02 5:40 ` sanjana99reddy99
-- strict thread matches above, loose matches on Subject: below --
2019-04-01 14:35 Sanjana Sanikommu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.