All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mukesh Ojha <mojha@codeaurora.org>
To: Yue Haibing <yuehaibing@huawei.com>,
	alim.akhtar@samsung.com, avri.altman@wdc.com,
	pedrom.sousa@synopsys.com, jejb@linux.ibm.com,
	martin.petersen@oracle.com, matthias.bgg@gmail.com,
	stanley.chu@mediatek.com
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH -next] scsi: ufs-mediatek: Make some symbols static
Date: Thu, 21 Mar 2019 01:00:52 +0530	[thread overview]
Message-ID: <d0536ff3-c6aa-ae3d-49cd-1a54a8dce5b5@codeaurora.org> (raw)
In-Reply-To: <20190320142458.20052-1-yuehaibing@huawei.com>


On 3/20/2019 7:54 PM, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fix sparse warnings:
>
> drivers/scsi/ufs/ufs-mediatek.c:19:6: warning: symbol 'ufs_mtk_cfg_unipro_cg' was not declared. Should it be static?
> drivers/scsi/ufs/ufs-mediatek.c:55:5: warning: symbol 'ufs_mtk_bind_mphy' was not declared. Should it be static?
> drivers/scsi/ufs/ufs-mediatek.c:342:27: warning: symbol 'ufs_mtk_of_match' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>   drivers/scsi/ufs/ufs-mediatek.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c
> index c3b78fc..2fbb450 100644
> --- a/drivers/scsi/ufs/ufs-mediatek.c
> +++ b/drivers/scsi/ufs/ufs-mediatek.c
> @@ -16,7 +16,7 @@
>   #include "unipro.h"
>   #include "ufs-mediatek.h"
>   
> -void ufs_mtk_cfg_unipro_cg(struct ufs_hba *hba, bool enable)
> +static void ufs_mtk_cfg_unipro_cg(struct ufs_hba *hba, bool enable)
>   {
>   	u32 tmp;
>   
> @@ -52,7 +52,7 @@ void ufs_mtk_cfg_unipro_cg(struct ufs_hba *hba, bool enable)
>   	}
>   }
>   
> -int ufs_mtk_bind_mphy(struct ufs_hba *hba)
> +static int ufs_mtk_bind_mphy(struct ufs_hba *hba)
>   {
>   	struct ufs_mtk_host *host = ufshcd_get_variant(hba);
>   	struct device *dev = hba->dev;
> @@ -339,7 +339,7 @@ static int ufs_mtk_remove(struct platform_device *pdev)
>   	return 0;
>   }
>   
> -const struct of_device_id ufs_mtk_of_match[] = {
> +static const struct of_device_id ufs_mtk_of_match[] = {
>   	{ .compatible = "mediatek,mt8183-ufshci"},
>   	{},
>   };


Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>


Cheers,
Mukesh


WARNING: multiple messages have this Message-ID (diff)
From: Mukesh Ojha <mojha@codeaurora.org>
To: Yue Haibing <yuehaibing@huawei.com>,
	alim.akhtar@samsung.com, avri.altman@wdc.com,
	pedrom.sousa@synopsys.com, jejb@linux.ibm.com,
	martin.petersen@oracle.com, matthias.bgg@gmail.com,
	stanley.chu@mediatek.com
Cc: linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH -next] scsi: ufs-mediatek: Make some symbols static
Date: Thu, 21 Mar 2019 01:00:52 +0530	[thread overview]
Message-ID: <d0536ff3-c6aa-ae3d-49cd-1a54a8dce5b5@codeaurora.org> (raw)
In-Reply-To: <20190320142458.20052-1-yuehaibing@huawei.com>


On 3/20/2019 7:54 PM, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fix sparse warnings:
>
> drivers/scsi/ufs/ufs-mediatek.c:19:6: warning: symbol 'ufs_mtk_cfg_unipro_cg' was not declared. Should it be static?
> drivers/scsi/ufs/ufs-mediatek.c:55:5: warning: symbol 'ufs_mtk_bind_mphy' was not declared. Should it be static?
> drivers/scsi/ufs/ufs-mediatek.c:342:27: warning: symbol 'ufs_mtk_of_match' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>   drivers/scsi/ufs/ufs-mediatek.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c
> index c3b78fc..2fbb450 100644
> --- a/drivers/scsi/ufs/ufs-mediatek.c
> +++ b/drivers/scsi/ufs/ufs-mediatek.c
> @@ -16,7 +16,7 @@
>   #include "unipro.h"
>   #include "ufs-mediatek.h"
>   
> -void ufs_mtk_cfg_unipro_cg(struct ufs_hba *hba, bool enable)
> +static void ufs_mtk_cfg_unipro_cg(struct ufs_hba *hba, bool enable)
>   {
>   	u32 tmp;
>   
> @@ -52,7 +52,7 @@ void ufs_mtk_cfg_unipro_cg(struct ufs_hba *hba, bool enable)
>   	}
>   }
>   
> -int ufs_mtk_bind_mphy(struct ufs_hba *hba)
> +static int ufs_mtk_bind_mphy(struct ufs_hba *hba)
>   {
>   	struct ufs_mtk_host *host = ufshcd_get_variant(hba);
>   	struct device *dev = hba->dev;
> @@ -339,7 +339,7 @@ static int ufs_mtk_remove(struct platform_device *pdev)
>   	return 0;
>   }
>   
> -const struct of_device_id ufs_mtk_of_match[] = {
> +static const struct of_device_id ufs_mtk_of_match[] = {
>   	{ .compatible = "mediatek,mt8183-ufshci"},
>   	{},
>   };


Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>


Cheers,
Mukesh

WARNING: multiple messages have this Message-ID (diff)
From: Mukesh Ojha <mojha@codeaurora.org>
To: Yue Haibing <yuehaibing@huawei.com>,
	alim.akhtar@samsung.com, avri.altman@wdc.com,
	pedrom.sousa@synopsys.com, jejb@linux.ibm.com,
	martin.petersen@oracle.com, matthias.bgg@gmail.com,
	stanley.chu@mediatek.com
Cc: linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH -next] scsi: ufs-mediatek: Make some symbols static
Date: Thu, 21 Mar 2019 01:00:52 +0530	[thread overview]
Message-ID: <d0536ff3-c6aa-ae3d-49cd-1a54a8dce5b5@codeaurora.org> (raw)
In-Reply-To: <20190320142458.20052-1-yuehaibing@huawei.com>


On 3/20/2019 7:54 PM, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fix sparse warnings:
>
> drivers/scsi/ufs/ufs-mediatek.c:19:6: warning: symbol 'ufs_mtk_cfg_unipro_cg' was not declared. Should it be static?
> drivers/scsi/ufs/ufs-mediatek.c:55:5: warning: symbol 'ufs_mtk_bind_mphy' was not declared. Should it be static?
> drivers/scsi/ufs/ufs-mediatek.c:342:27: warning: symbol 'ufs_mtk_of_match' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>   drivers/scsi/ufs/ufs-mediatek.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c
> index c3b78fc..2fbb450 100644
> --- a/drivers/scsi/ufs/ufs-mediatek.c
> +++ b/drivers/scsi/ufs/ufs-mediatek.c
> @@ -16,7 +16,7 @@
>   #include "unipro.h"
>   #include "ufs-mediatek.h"
>   
> -void ufs_mtk_cfg_unipro_cg(struct ufs_hba *hba, bool enable)
> +static void ufs_mtk_cfg_unipro_cg(struct ufs_hba *hba, bool enable)
>   {
>   	u32 tmp;
>   
> @@ -52,7 +52,7 @@ void ufs_mtk_cfg_unipro_cg(struct ufs_hba *hba, bool enable)
>   	}
>   }
>   
> -int ufs_mtk_bind_mphy(struct ufs_hba *hba)
> +static int ufs_mtk_bind_mphy(struct ufs_hba *hba)
>   {
>   	struct ufs_mtk_host *host = ufshcd_get_variant(hba);
>   	struct device *dev = hba->dev;
> @@ -339,7 +339,7 @@ static int ufs_mtk_remove(struct platform_device *pdev)
>   	return 0;
>   }
>   
> -const struct of_device_id ufs_mtk_of_match[] = {
> +static const struct of_device_id ufs_mtk_of_match[] = {
>   	{ .compatible = "mediatek,mt8183-ufshci"},
>   	{},
>   };


Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>


Cheers,
Mukesh


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-03-20 19:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-20 14:24 [PATCH -next] scsi: ufs-mediatek: Make some symbols static Yue Haibing
2019-03-20 14:24 ` Yue Haibing
2019-03-20 14:24 ` Yue Haibing
2019-03-20 19:30 ` Mukesh Ojha [this message]
2019-03-20 19:30   ` Mukesh Ojha
2019-03-20 19:30   ` Mukesh Ojha
2019-03-20 23:17   ` Stanley Chu
2019-03-20 23:17     ` Stanley Chu
2019-03-20 23:17     ` Stanley Chu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d0536ff3-c6aa-ae3d-49cd-1a54a8dce5b5@codeaurora.org \
    --to=mojha@codeaurora.org \
    --cc=alim.akhtar@samsung.com \
    --cc=avri.altman@wdc.com \
    --cc=jejb@linux.ibm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=matthias.bgg@gmail.com \
    --cc=pedrom.sousa@synopsys.com \
    --cc=stanley.chu@mediatek.com \
    --cc=yuehaibing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.