All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: Jagan Teki <jagan@amarulasolutions.com>,
	Kever Yang <kever.yang@rock-chips.com>,
	Simon Glass <sjg@chromium.org>,
	Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
Cc: u-boot@lists.denx.de, linux-amarula@amarulasolutions.com,
	linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v2 07/10] usb: dwc3: Add phy interface for dwc3_uboot
Date: Tue, 19 Nov 2019 12:13:09 +0100	[thread overview]
Message-ID: <d0a52200-e247-44d8-7771-08ec42b5e6be@denx.de> (raw)
In-Reply-To: <20191119082623.6165-8-jagan@amarulasolutions.com>

On 11/19/19 9:26 AM, Jagan Teki wrote:
> U-Boot has two different variants of dwc3 initializations,
> - with dm variant gadget, so the respective dm driver would
>   call the dwc3_init in core.
> - with non-dm variant gadget, so the usage board file would
>   call dwc3_uboot_init in core.
> 
> The driver probe would handle all respective gadget properties
> including phy interface via phy_type property and then trigger
> dwc3_init for dm-variant gadgets.
> 
> So, to support the phy interface for non-dm variant gadgets,
> the better option is dwc3_uboot_init since there is no
> dedicated controller for non-dm variant gadgets.
> 
> This patch support for adding phy interface like 8/16-bit UTMI+
> code for dwc3_uboot.
> 
> This change used Linux phy.h enum list, to make proper code
> compatibility.
> 
> Cc: Marek Vasut <marex@denx.de>
> Tested-by: Levin Du <djw@t-chip.com.cn>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>

Reviewed-by: Marek Vasut <marex@denx.de>
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

WARNING: multiple messages have this Message-ID (diff)
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 07/10] usb: dwc3: Add phy interface for dwc3_uboot
Date: Tue, 19 Nov 2019 12:13:09 +0100	[thread overview]
Message-ID: <d0a52200-e247-44d8-7771-08ec42b5e6be@denx.de> (raw)
In-Reply-To: <20191119082623.6165-8-jagan@amarulasolutions.com>

On 11/19/19 9:26 AM, Jagan Teki wrote:
> U-Boot has two different variants of dwc3 initializations,
> - with dm variant gadget, so the respective dm driver would
>   call the dwc3_init in core.
> - with non-dm variant gadget, so the usage board file would
>   call dwc3_uboot_init in core.
> 
> The driver probe would handle all respective gadget properties
> including phy interface via phy_type property and then trigger
> dwc3_init for dm-variant gadgets.
> 
> So, to support the phy interface for non-dm variant gadgets,
> the better option is dwc3_uboot_init since there is no
> dedicated controller for non-dm variant gadgets.
> 
> This patch support for adding phy interface like 8/16-bit UTMI+
> code for dwc3_uboot.
> 
> This change used Linux phy.h enum list, to make proper code
> compatibility.
> 
> Cc: Marek Vasut <marex@denx.de>
> Tested-by: Levin Du <djw@t-chip.com.cn>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>

Reviewed-by: Marek Vasut <marex@denx.de>

  reply	other threads:[~2019-11-19 11:13 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-19  8:26 [PATCH v2 00/10] rockchip: rk3399: Add fastboot support Jagan Teki
2019-11-19  8:26 ` [U-Boot] " Jagan Teki
     [not found] ` <20191119082623.6165-1-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
2019-11-19  8:26   ` [PATCH v2 01/10] gadget: Select USB_GADGET_MANUFACTURER for rockchip Jagan Teki
2019-11-19  8:26     ` [U-Boot] " Jagan Teki
2019-11-23 14:20     ` Kever Yang
2019-11-23 14:20       ` [U-Boot] " Kever Yang
2019-11-19  8:26   ` [PATCH v2 02/10] gadget: Select USB_GADGET_VENDOR_NUM " Jagan Teki
2019-11-19  8:26     ` [U-Boot] " Jagan Teki
     [not found]     ` <20191119082623.6165-3-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
2019-11-23 14:20       ` Kever Yang
2019-11-23 14:20         ` [U-Boot] " Kever Yang
2019-11-19  8:26   ` [PATCH v2 03/10] gadget: rockchip: USB_GADGET_PRODUCT_NUM Jagan Teki
2019-11-19  8:26     ` [U-Boot] " Jagan Teki
     [not found]     ` <20191119082623.6165-4-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
2019-11-23 14:20       ` Kever Yang
2019-11-23 14:20         ` [U-Boot] " Kever Yang
2019-11-19  8:26   ` [PATCH v2 04/10] gadget: rockchip: Add rk3128 USB_GADGET_PRODUCT_NUM Jagan Teki
2019-11-19  8:26     ` [U-Boot] " Jagan Teki
     [not found]     ` <20191119082623.6165-5-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
2019-11-23 14:21       ` Kever Yang
2019-11-23 14:21         ` [U-Boot] " Kever Yang
2019-11-19  8:26   ` [PATCH v2 05/10] fastboot: rockchip: Select FASTBOOT_FLASH[_MMC_DEV] Jagan Teki
2019-11-19  8:26     ` [U-Boot] " Jagan Teki
     [not found]     ` <20191119082623.6165-6-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
2019-11-23 14:21       ` Kever Yang
2019-11-23 14:21         ` [U-Boot] " Kever Yang
2019-11-19  8:26   ` [PATCH v2 06/10] fastboot: rockchip: Fix rk3328 default mmc device Jagan Teki
2019-11-19  8:26     ` [U-Boot] " Jagan Teki
     [not found]     ` <20191119082623.6165-7-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
2019-11-23 14:21       ` Kever Yang
2019-11-23 14:21         ` [U-Boot] " Kever Yang
2019-11-19  8:26   ` [PATCH v2 07/10] usb: dwc3: Add phy interface for dwc3_uboot Jagan Teki
2019-11-19  8:26     ` [U-Boot] " Jagan Teki
2019-11-19 11:13     ` Marek Vasut [this message]
2019-11-19 11:13       ` Marek Vasut
     [not found]     ` <20191119082623.6165-8-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
2019-11-23 14:21       ` Kever Yang
2019-11-23 14:21         ` [U-Boot] " Kever Yang
2019-11-19  8:26   ` [PATCH v2 08/10] gadget: rockchip: Add rk3399 USB_GADGET_PRODUCT_NUM Jagan Teki
2019-11-19  8:26     ` [U-Boot] " Jagan Teki
     [not found]     ` <20191119082623.6165-9-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
2019-11-23 14:21       ` Kever Yang
2019-11-23 14:21         ` [U-Boot] " Kever Yang
2019-11-19  8:26   ` [PATCH v2 09/10] rockchip: Setup dwc3_device (for non-dm gadgets) Jagan Teki
2019-11-19  8:26     ` [U-Boot] " Jagan Teki
     [not found]     ` <20191119082623.6165-10-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
2019-11-23 14:22       ` Kever Yang
2019-11-23 14:22         ` [U-Boot] " Kever Yang
2019-11-23 15:37     ` Kever Yang
2019-11-23 15:37       ` [U-Boot] " Kever Yang
2019-11-19  8:26   ` [PATCH v2 10/10] rock960: Enable USB Gadget Jagan Teki
2019-11-19  8:26     ` [U-Boot] " Jagan Teki
     [not found]     ` <20191119082623.6165-11-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
2019-11-23 14:22       ` Kever Yang
2019-11-23 14:22         ` [U-Boot] " Kever Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d0a52200-e247-44d8-7771-08ec42b5e6be@denx.de \
    --to=marex@denx.de \
    --cc=jagan@amarulasolutions.com \
    --cc=kever.yang@rock-chips.com \
    --cc=linux-amarula@amarulasolutions.com \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=philipp.tomsich@theobroma-systems.com \
    --cc=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.