From: "Christian König" <ckoenig.leichtzumerken@gmail.com>
To: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
Nirmoy Das <nirmoy.das@amd.com>
Cc: alexander.deucher@amd.com, Christian.Koenig@amd.com,
amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/1] drm/amdgpu: remove excess function parameter
Date: Fri, 30 Apr 2021 14:56:42 +0200 [thread overview]
Message-ID: <d0cc8e0a-18fa-8218-0ff0-65d69b7eb76b@gmail.com> (raw)
In-Reply-To: <20210430125221.3lo5lvioo7nbrlk4@outlook.office365.com>
[-- Attachment #1.1: Type: text/plain, Size: 2178 bytes --]
Hi,
Am 30.04.21 um 14:52 schrieb Rodrigo Siqueira:
> Hi,
>
> On 04/30, Nirmoy Das wrote:
>> Fixes: 49020fc1f5("drm/amdgpu: cleanup amdgpu_vm_init()")
> Just for curiosity, do we need the Fixes tag for this?
It's indeed a bit overkill.
The purpose of the Fixes tag is to mark bug fixes for specific patches
so that backporters of feature know that when they picked up patch A
they also need to pick up the fixes for patch A.
But since this is just cleaning up a recently added warning in a code
documentation we could just push it without.
Christian.
>
> How about adding the warning/error message that this patch fixes? I
> think this can be useful for other people searching for a similar fix in
> the git log (I do it sometimes).
>
> Thanks
> Siqueira
>
>> Signed-off-by: Nirmoy Das <nirmoy.das@amd.com>
>> ---
>> drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
>> index dae51992c607..f2513be72980 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
>> @@ -2796,7 +2796,6 @@ long amdgpu_vm_wait_idle(struct amdgpu_vm *vm, long timeout)
>> *
>> * @adev: amdgpu_device pointer
>> * @vm: requested vm
>> - * @vm_context: Indicates if it GFX or Compute context
>> * @pasid: Process address space identifier
>> *
>> * Init @vm fields.
>> --
>> 2.30.2
>>
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx@lists.freedesktop.org
>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=04%7C01%7CRodrigo.Siqueira%40amd.com%7Ca88acdf110bc4994ff3c08d90bcd36f6%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637553798286590199%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=tS6NA4FPNYFPCbIdngKshN3I%2BwRwAumgC0vdA50h9l8%3D&reserved=0
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
[-- Attachment #1.2: Type: text/html, Size: 3957 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2021-04-30 12:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-30 11:43 [PATCH 1/1] drm/amdgpu: remove excess function parameter Nirmoy Das
2021-04-30 12:52 ` Rodrigo Siqueira
2021-04-30 12:56 ` Christian König [this message]
2021-04-30 13:28 ` Nirmoy
2021-04-30 13:32 Nirmoy Das
2021-04-30 13:33 ` Christian König
2021-04-30 13:33 Nirmoy Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0cc8e0a-18fa-8218-0ff0-65d69b7eb76b@gmail.com \
--to=ckoenig.leichtzumerken@gmail.com \
--cc=Christian.Koenig@amd.com \
--cc=Rodrigo.Siqueira@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=nirmoy.das@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.