* [PATCH 1/1] drm/amdgpu: remove excess function parameter
@ 2021-04-30 11:43 Nirmoy Das
2021-04-30 12:52 ` Rodrigo Siqueira
0 siblings, 1 reply; 7+ messages in thread
From: Nirmoy Das @ 2021-04-30 11:43 UTC (permalink / raw)
To: amd-gfx; +Cc: alexander.deucher, Nirmoy Das, Christian.Koenig
Fixes: 49020fc1f5("drm/amdgpu: cleanup amdgpu_vm_init()")
Signed-off-by: Nirmoy Das <nirmoy.das@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
index dae51992c607..f2513be72980 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
@@ -2796,7 +2796,6 @@ long amdgpu_vm_wait_idle(struct amdgpu_vm *vm, long timeout)
*
* @adev: amdgpu_device pointer
* @vm: requested vm
- * @vm_context: Indicates if it GFX or Compute context
* @pasid: Process address space identifier
*
* Init @vm fields.
--
2.30.2
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 1/1] drm/amdgpu: remove excess function parameter
2021-04-30 11:43 [PATCH 1/1] drm/amdgpu: remove excess function parameter Nirmoy Das
@ 2021-04-30 12:52 ` Rodrigo Siqueira
2021-04-30 12:56 ` Christian König
0 siblings, 1 reply; 7+ messages in thread
From: Rodrigo Siqueira @ 2021-04-30 12:52 UTC (permalink / raw)
To: Nirmoy Das; +Cc: alexander.deucher, Christian.Koenig, amd-gfx
[-- Attachment #1.1: Type: text/plain, Size: 1644 bytes --]
Hi,
On 04/30, Nirmoy Das wrote:
> Fixes: 49020fc1f5("drm/amdgpu: cleanup amdgpu_vm_init()")
Just for curiosity, do we need the Fixes tag for this?
How about adding the warning/error message that this patch fixes? I
think this can be useful for other people searching for a similar fix in
the git log (I do it sometimes).
Thanks
Siqueira
> Signed-off-by: Nirmoy Das <nirmoy.das@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> index dae51992c607..f2513be72980 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> @@ -2796,7 +2796,6 @@ long amdgpu_vm_wait_idle(struct amdgpu_vm *vm, long timeout)
> *
> * @adev: amdgpu_device pointer
> * @vm: requested vm
> - * @vm_context: Indicates if it GFX or Compute context
> * @pasid: Process address space identifier
> *
> * Init @vm fields.
> --
> 2.30.2
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=04%7C01%7CRodrigo.Siqueira%40amd.com%7Ca88acdf110bc4994ff3c08d90bcd36f6%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637553798286590199%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=tS6NA4FPNYFPCbIdngKshN3I%2BwRwAumgC0vdA50h9l8%3D&reserved=0
--
Rodrigo Siqueira
https://siqueira.tech
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 1/1] drm/amdgpu: remove excess function parameter
2021-04-30 12:52 ` Rodrigo Siqueira
@ 2021-04-30 12:56 ` Christian König
2021-04-30 13:28 ` Nirmoy
0 siblings, 1 reply; 7+ messages in thread
From: Christian König @ 2021-04-30 12:56 UTC (permalink / raw)
To: Rodrigo Siqueira, Nirmoy Das; +Cc: alexander.deucher, Christian.Koenig, amd-gfx
[-- Attachment #1.1: Type: text/plain, Size: 2178 bytes --]
Hi,
Am 30.04.21 um 14:52 schrieb Rodrigo Siqueira:
> Hi,
>
> On 04/30, Nirmoy Das wrote:
>> Fixes: 49020fc1f5("drm/amdgpu: cleanup amdgpu_vm_init()")
> Just for curiosity, do we need the Fixes tag for this?
It's indeed a bit overkill.
The purpose of the Fixes tag is to mark bug fixes for specific patches
so that backporters of feature know that when they picked up patch A
they also need to pick up the fixes for patch A.
But since this is just cleaning up a recently added warning in a code
documentation we could just push it without.
Christian.
>
> How about adding the warning/error message that this patch fixes? I
> think this can be useful for other people searching for a similar fix in
> the git log (I do it sometimes).
>
> Thanks
> Siqueira
>
>> Signed-off-by: Nirmoy Das <nirmoy.das@amd.com>
>> ---
>> drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
>> index dae51992c607..f2513be72980 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
>> @@ -2796,7 +2796,6 @@ long amdgpu_vm_wait_idle(struct amdgpu_vm *vm, long timeout)
>> *
>> * @adev: amdgpu_device pointer
>> * @vm: requested vm
>> - * @vm_context: Indicates if it GFX or Compute context
>> * @pasid: Process address space identifier
>> *
>> * Init @vm fields.
>> --
>> 2.30.2
>>
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx@lists.freedesktop.org
>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=04%7C01%7CRodrigo.Siqueira%40amd.com%7Ca88acdf110bc4994ff3c08d90bcd36f6%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637553798286590199%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=tS6NA4FPNYFPCbIdngKshN3I%2BwRwAumgC0vdA50h9l8%3D&reserved=0
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
[-- Attachment #1.2: Type: text/html, Size: 3957 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 1/1] drm/amdgpu: remove excess function parameter
2021-04-30 12:56 ` Christian König
@ 2021-04-30 13:28 ` Nirmoy
0 siblings, 0 replies; 7+ messages in thread
From: Nirmoy @ 2021-04-30 13:28 UTC (permalink / raw)
To: Christian König, Rodrigo Siqueira, Nirmoy Das
Cc: alexander.deucher, Christian.Koenig, amd-gfx
[-- Attachment #1.1: Type: text/plain, Size: 2367 bytes --]
On 4/30/21 2:56 PM, Christian König wrote:
> Hi,
>
> Am 30.04.21 um 14:52 schrieb Rodrigo Siqueira:
>> Hi,
>>
>> On 04/30, Nirmoy Das wrote:
>>> Fixes: 49020fc1f5("drm/amdgpu: cleanup amdgpu_vm_init()")
>> Just for curiosity, do we need the Fixes tag for this?
>
> It's indeed a bit overkill.
>
> The purpose of the Fixes tag is to mark bug fixes for specific patches
> so that backporters of feature know that when they picked up patch A
> they also need to pick up the fixes for patch A.
>
> But since this is just cleaning up a recently added warning in a code
> documentation we could just push it without.
Thanks Rodrigo and Christian, I will resend again without Fixes tag.
Nirmoy
>
> Christian.
>
>> How about adding the warning/error message that this patch fixes? I
>> think this can be useful for other people searching for a similar fix in
>> the git log (I do it sometimes).
>>
>> Thanks
>> Siqueira
>>
>>> Signed-off-by: Nirmoy Das<nirmoy.das@amd.com>
>>> ---
>>> drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 1 -
>>> 1 file changed, 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
>>> index dae51992c607..f2513be72980 100644
>>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
>>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
>>> @@ -2796,7 +2796,6 @@ long amdgpu_vm_wait_idle(struct amdgpu_vm *vm, long timeout)
>>> *
>>> * @adev: amdgpu_device pointer
>>> * @vm: requested vm
>>> - * @vm_context: Indicates if it GFX or Compute context
>>> * @pasid: Process address space identifier
>>> *
>>> * Init @vm fields.
>>> --
>>> 2.30.2
>>>
>>> _______________________________________________
>>> amd-gfx mailing list
>>> amd-gfx@lists.freedesktop.org
>>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=04%7C01%7CRodrigo.Siqueira%40amd.com%7Ca88acdf110bc4994ff3c08d90bcd36f6%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637553798286590199%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=tS6NA4FPNYFPCbIdngKshN3I%2BwRwAumgC0vdA50h9l8%3D&reserved=0
>>
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
>
[-- Attachment #1.2: Type: text/html, Size: 5440 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/1] drm/amdgpu: remove excess function parameter
@ 2021-04-30 13:32 Nirmoy Das
2021-04-30 13:33 ` Christian König
0 siblings, 1 reply; 7+ messages in thread
From: Nirmoy Das @ 2021-04-30 13:32 UTC (permalink / raw)
To: amd-gfx; +Cc: alexander.deucher, Nirmoy Das, Rodrigo.Siqueira, Christian.Koenig
Fix below htmldocs build warning:
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:2808:
warning: Excess function parameter 'vm_context' description in 'amdgpu_vm_init'
Signed-off-by: Nirmoy Das <nirmoy.das@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
index dae51992c607..f2513be72980 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
@@ -2796,7 +2796,6 @@ long amdgpu_vm_wait_idle(struct amdgpu_vm *vm, long timeout)
*
* @adev: amdgpu_device pointer
* @vm: requested vm
- * @vm_context: Indicates if it GFX or Compute context
* @pasid: Process address space identifier
*
* Init @vm fields.
--
2.30.2
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] drm/amdgpu: remove excess function parameter
2021-04-30 13:32 Nirmoy Das
@ 2021-04-30 13:33 ` Christian König
0 siblings, 0 replies; 7+ messages in thread
From: Christian König @ 2021-04-30 13:33 UTC (permalink / raw)
To: Nirmoy Das, amd-gfx; +Cc: alexander.deucher, Rodrigo.Siqueira, Christian.Koenig
Am 30.04.21 um 15:32 schrieb Nirmoy Das:
> Fix below htmldocs build warning:
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:2808:
> warning: Excess function parameter 'vm_context' description in 'amdgpu_vm_init'
>
> Signed-off-by: Nirmoy Das <nirmoy.das@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> index dae51992c607..f2513be72980 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> @@ -2796,7 +2796,6 @@ long amdgpu_vm_wait_idle(struct amdgpu_vm *vm, long timeout)
> *
> * @adev: amdgpu_device pointer
> * @vm: requested vm
> - * @vm_context: Indicates if it GFX or Compute context
> * @pasid: Process address space identifier
> *
> * Init @vm fields.
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/1] drm/amdgpu: remove excess function parameter
@ 2021-04-30 13:33 Nirmoy Das
0 siblings, 0 replies; 7+ messages in thread
From: Nirmoy Das @ 2021-04-30 13:33 UTC (permalink / raw)
To: amd-gfx; +Cc: alexander.deucher, Nirmoy Das, Rodrigo.Siqueira, Christian.Koenig
Fix below htmldocs build warning:
"warning: Excess function parameter 'vm_context' description in 'amdgpu_vm_init'"
Signed-off-by: Nirmoy Das <nirmoy.das@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
index dae51992c607..f2513be72980 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
@@ -2796,7 +2796,6 @@ long amdgpu_vm_wait_idle(struct amdgpu_vm *vm, long timeout)
*
* @adev: amdgpu_device pointer
* @vm: requested vm
- * @vm_context: Indicates if it GFX or Compute context
* @pasid: Process address space identifier
*
* Init @vm fields.
--
2.30.2
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-04-30 13:33 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-30 11:43 [PATCH 1/1] drm/amdgpu: remove excess function parameter Nirmoy Das
2021-04-30 12:52 ` Rodrigo Siqueira
2021-04-30 12:56 ` Christian König
2021-04-30 13:28 ` Nirmoy
2021-04-30 13:32 Nirmoy Das
2021-04-30 13:33 ` Christian König
2021-04-30 13:33 Nirmoy Das
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.