All of lore.kernel.org
 help / color / mirror / Atom feed
From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: devicetree@vger.kernel.org, Christian Eggers <CEggers@arri.de>,
	linux-kernel@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH v2] nvmem: core: don't consider subnodes not matching binding
Date: Wed, 15 Apr 2020 09:46:06 +0100	[thread overview]
Message-ID: <d0dc571f-4faf-f75c-1388-d1fab10f4aa8@linaro.org> (raw)
In-Reply-To: <4e861088-c17d-0eca-6efa-c50b55fdecd1@pengutronix.de>



On 15/04/2020 09:05, Ahmad Fatoum wrote:
>> - If the cell has a compatible node, it must be "nvmem-cell".
>>    Otherwise, a cell with a compatible node is skipped.
>>
This one sounds more sensible!
If we go this way, it needs to be properly documented in the bindings too.


>> - Adding a nvmem cell container with a compatible and making support for
>>    the old binding configurable

Older bindings should be still supported but we should encourage to use 
compatible string for new additions.

>>
>> - Skipping cells that are malformed and lack a reg = < > property_without_
>>    error
Currently we only support Offset and Size with address cell and size 
cells of 1. Adding an extra check here to see if its malformed makes 
sense too!


Thanks,
srini

> gentle ping. I can prepare another patch if you indicate which approach
> you'd prefer.
> 

      reply	other threads:[~2020-04-15  8:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-23 15:28 [PATCH v2] nvmem: core: don't consider subnodes not matching binding Ahmad Fatoum
2020-04-06 11:29 ` Ahmad Fatoum
2020-04-06 12:33 ` Srinivas Kandagatla
2020-04-06 14:20   ` Ahmad Fatoum
2020-04-15  8:05     ` Ahmad Fatoum
2020-04-15  8:46       ` Srinivas Kandagatla [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d0dc571f-4faf-f75c-1388-d1fab10f4aa8@linaro.org \
    --to=srinivas.kandagatla@linaro.org \
    --cc=CEggers@arri.de \
    --cc=a.fatoum@pengutronix.de \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel@pengutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.