From: Chao Yu <chao@kernel.org> To: Yangtao Li <frank.li@vivo.com>, jaegeuk@kernel.org Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] f2fs: rename flush_error_work() to f2fs_record_error_work() Date: Thu, 27 Oct 2022 21:24:02 +0800 [thread overview] Message-ID: <d0e09d40-89be-8f62-dfbb-1053405ad5d7@kernel.org> (raw) In-Reply-To: <20221027120807.6337-1-frank.li@vivo.com> On 2022/10/27 20:08, Yangtao Li wrote: > Since it is an f2fs module, it is best to prefix function names > with f2fs_. At the same time, there is already a flush thread > and related functions in the system, rename flush_error_work() > to f2fs_record_error_work(). It won't pollute global namespace since it's a static function just be used in f2fs/super.c... > > Signed-off-by: Yangtao Li <frank.li@vivo.com> > --- > fs/f2fs/super.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c > index a241e4073f1d..fc220b5c5599 100644 > --- a/fs/f2fs/super.c > +++ b/fs/f2fs/super.c > @@ -4019,7 +4019,7 @@ void f2fs_handle_critical_error(struct f2fs_sb_info *sbi, unsigned char reason, > f2fs_stop_discard_thread(sbi); > } > > -static void flush_error_work(struct work_struct *work) > +static void f2fs_record_error_work(struct work_struct *work) > { > struct f2fs_sb_info *sbi = container_of(work, > struct f2fs_sb_info, s_error_work); > @@ -4374,7 +4374,7 @@ static int f2fs_fill_super(struct super_block *sb, void *data, int silent) > goto free_devices; > } > > - INIT_WORK(&sbi->s_error_work, flush_error_work); > + INIT_WORK(&sbi->s_error_work, f2fs_record_error_work); > spin_lock_init(&sbi->error_lock); > memcpy(sbi->errors, raw_super->s_errors, MAX_F2FS_ERRORS); > memcpy(sbi->stop_reason, raw_super->s_stop_reason, MAX_STOP_REASON);
WARNING: multiple messages have this Message-ID (diff)
From: Chao Yu <chao@kernel.org> To: Yangtao Li <frank.li@vivo.com>, jaegeuk@kernel.org Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [f2fs-dev] [PATCH 1/3] f2fs: rename flush_error_work() to f2fs_record_error_work() Date: Thu, 27 Oct 2022 21:24:02 +0800 [thread overview] Message-ID: <d0e09d40-89be-8f62-dfbb-1053405ad5d7@kernel.org> (raw) In-Reply-To: <20221027120807.6337-1-frank.li@vivo.com> On 2022/10/27 20:08, Yangtao Li wrote: > Since it is an f2fs module, it is best to prefix function names > with f2fs_. At the same time, there is already a flush thread > and related functions in the system, rename flush_error_work() > to f2fs_record_error_work(). It won't pollute global namespace since it's a static function just be used in f2fs/super.c... > > Signed-off-by: Yangtao Li <frank.li@vivo.com> > --- > fs/f2fs/super.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c > index a241e4073f1d..fc220b5c5599 100644 > --- a/fs/f2fs/super.c > +++ b/fs/f2fs/super.c > @@ -4019,7 +4019,7 @@ void f2fs_handle_critical_error(struct f2fs_sb_info *sbi, unsigned char reason, > f2fs_stop_discard_thread(sbi); > } > > -static void flush_error_work(struct work_struct *work) > +static void f2fs_record_error_work(struct work_struct *work) > { > struct f2fs_sb_info *sbi = container_of(work, > struct f2fs_sb_info, s_error_work); > @@ -4374,7 +4374,7 @@ static int f2fs_fill_super(struct super_block *sb, void *data, int silent) > goto free_devices; > } > > - INIT_WORK(&sbi->s_error_work, flush_error_work); > + INIT_WORK(&sbi->s_error_work, f2fs_record_error_work); > spin_lock_init(&sbi->error_lock); > memcpy(sbi->errors, raw_super->s_errors, MAX_F2FS_ERRORS); > memcpy(sbi->stop_reason, raw_super->s_stop_reason, MAX_STOP_REASON); _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2022-10-27 13:24 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-10-27 12:08 [PATCH 1/3] f2fs: rename flush_error_work() to f2fs_record_error_work() Yangtao Li 2022-10-27 12:08 ` [f2fs-dev] " Yangtao Li via Linux-f2fs-devel 2022-10-27 12:08 ` [PATCH 2/3] f2fs: export f2fs_stop_flush_thread() for external use Yangtao Li 2022-10-27 12:08 ` [f2fs-dev] " Yangtao Li via Linux-f2fs-devel 2022-10-27 12:08 ` [PATCH 3/3] f2fs: fix to f2fs_handle_critical_error when errors=remount-ro Yangtao Li 2022-10-27 12:08 ` [f2fs-dev] " Yangtao Li via Linux-f2fs-devel 2022-10-27 13:31 ` Chao Yu 2022-10-27 13:31 ` [f2fs-dev] " Chao Yu 2022-10-28 2:33 ` Yangtao Li 2022-10-28 2:33 ` [f2fs-dev] " Yangtao Li via Linux-f2fs-devel 2022-10-28 2:43 ` Chao Yu 2022-10-28 2:43 ` [f2fs-dev] " Chao Yu 2022-10-28 3:17 ` Jaegeuk Kim 2022-10-28 3:17 ` Jaegeuk Kim 2022-10-28 3:38 ` Chao Yu 2022-10-28 3:38 ` [f2fs-dev] " Chao Yu 2022-10-27 13:24 ` Chao Yu [this message] 2022-10-27 13:24 ` [f2fs-dev] [PATCH 1/3] f2fs: rename flush_error_work() to f2fs_record_error_work() Chao Yu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=d0e09d40-89be-8f62-dfbb-1053405ad5d7@kernel.org \ --to=chao@kernel.org \ --cc=frank.li@vivo.com \ --cc=jaegeuk@kernel.org \ --cc=linux-f2fs-devel@lists.sourceforge.net \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.