All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Johannes Berg <johannes@sipsolutions.net>,
	"David S. Miller" <davem@davemloft.net>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	netdev@vger.kernel.org, russianneuromancer@ya.ru
Subject: Re: [PATCH] net: rfkill: gpio: Add OBDA8723 ACPI HID
Date: Sun, 9 Apr 2017 11:35:53 +0200	[thread overview]
Message-ID: <d1206383-7fad-55ca-0717-5e485b9bee92@redhat.com> (raw)
In-Reply-To: <D47F8D1B-8EE0-4754-A0F2-EC823A9BDA11@holtmann.org>

Hi,

On 09-04-17 10:01, Marcel Holtmann wrote:
> Hi Hans,
>
>> The OBDA8723 ACPI HID is used on quite a few Bay Trail based tablets
>> for bluetooth rfkill functionality.
>>
>> Tested-by: russianneuromancer@ya.ru <russianneuromancer@ya.ru>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>> ---
>> net/rfkill/rfkill-gpio.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/net/rfkill/rfkill-gpio.c b/net/rfkill/rfkill-gpio.c
>> index 76c01cb..50ca65e 100644
>> --- a/net/rfkill/rfkill-gpio.c
>> +++ b/net/rfkill/rfkill-gpio.c
>> @@ -163,6 +163,7 @@ static int rfkill_gpio_remove(struct platform_device *pdev)
>> static const struct acpi_device_id rfkill_acpi_match[] = {
>> 	{ "BCM4752", RFKILL_TYPE_GPS },
>> 	{ "LNV4752", RFKILL_TYPE_GPS },
>> +	{ "OBDA8723", RFKILL_TYPE_BLUETOOTH },
>> 	{ },
>> };
>
> NAK. We are integrating these with hci_bcm.c or hci_intel.c drivers.

This is for the bluetooth side of the rtl8723bs driver which recently
(yesterday) got merged in into drivers/staging. Which still needs
hciattach from userspace. I completely agree that eventually we should
fix that. In the mean time it would be nice if we could carry this
one line patch to give people using the staging driver working bluetooth.

Regards,

Hans

WARNING: multiple messages have this Message-ID (diff)
From: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Marcel Holtmann <marcel-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>
Cc: Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>,
	"David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
	linux-wireless
	<linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	russianneuromancer-k+OT61UuxXo@public.gmane.org
Subject: Re: [PATCH] net: rfkill: gpio: Add OBDA8723 ACPI HID
Date: Sun, 9 Apr 2017 11:35:53 +0200	[thread overview]
Message-ID: <d1206383-7fad-55ca-0717-5e485b9bee92@redhat.com> (raw)
In-Reply-To: <D47F8D1B-8EE0-4754-A0F2-EC823A9BDA11-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>

Hi,

On 09-04-17 10:01, Marcel Holtmann wrote:
> Hi Hans,
>
>> The OBDA8723 ACPI HID is used on quite a few Bay Trail based tablets
>> for bluetooth rfkill functionality.
>>
>> Tested-by: russianneuromancer-k+OT61UuxXo@public.gmane.org <russianneuromancer-k+OT61UuxXo@public.gmane.org>
>> Signed-off-by: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
>> ---
>> net/rfkill/rfkill-gpio.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/net/rfkill/rfkill-gpio.c b/net/rfkill/rfkill-gpio.c
>> index 76c01cb..50ca65e 100644
>> --- a/net/rfkill/rfkill-gpio.c
>> +++ b/net/rfkill/rfkill-gpio.c
>> @@ -163,6 +163,7 @@ static int rfkill_gpio_remove(struct platform_device *pdev)
>> static const struct acpi_device_id rfkill_acpi_match[] = {
>> 	{ "BCM4752", RFKILL_TYPE_GPS },
>> 	{ "LNV4752", RFKILL_TYPE_GPS },
>> +	{ "OBDA8723", RFKILL_TYPE_BLUETOOTH },
>> 	{ },
>> };
>
> NAK. We are integrating these with hci_bcm.c or hci_intel.c drivers.

This is for the bluetooth side of the rtl8723bs driver which recently
(yesterday) got merged in into drivers/staging. Which still needs
hciattach from userspace. I completely agree that eventually we should
fix that. In the mean time it would be nice if we could carry this
one line patch to give people using the staging driver working bluetooth.

Regards,

Hans

  reply	other threads:[~2017-04-09  9:35 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-08 21:05 [PATCH] net: rfkill: gpio: Add OBDA8723 ACPI HID Hans de Goede
2017-04-08 21:05 ` Hans de Goede
2017-04-09  8:01 ` Marcel Holtmann
2017-04-09  8:01   ` Marcel Holtmann
2017-04-09  9:35   ` Hans de Goede [this message]
2017-04-09  9:35     ` Hans de Goede
2017-04-09 12:11     ` Marcel Holtmann
2017-04-09 12:11       ` Marcel Holtmann
2017-04-09 15:50       ` Larry Finger
2017-04-09 15:50         ` Larry Finger
2017-04-11 14:47         ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d1206383-7fad-55ca-0717-5e485b9bee92@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=davem@davemloft.net \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=netdev@vger.kernel.org \
    --cc=russianneuromancer@ya.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.