* [PATCH] nvmet-fc: add a missing __rcu annotation to nvmet_fc_tgt_assoc.queues
@ 2021-02-07 16:20 Christoph Hellwig
2021-02-07 18:58 ` Chaitanya Kulkarni
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Christoph Hellwig @ 2021-02-07 16:20 UTC (permalink / raw)
To: Eldad.Zinger, Leonid.Ravich, Elad.Grupi, sagi,
chaitanya.kulkarni, james.smart
Cc: linux-nvme
Make sparse happy after the recent conversion to RCU lookups.
Fixes: 4e2f02bf77da ("nvmet-fc: use RCU proctection for assoc_list")
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
drivers/nvme/target/fc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/target/fc.c b/drivers/nvme/target/fc.c
index c14c60bfdf85c6..d375745fc4ed3d 100644
--- a/drivers/nvme/target/fc.c
+++ b/drivers/nvme/target/fc.c
@@ -165,7 +165,7 @@ struct nvmet_fc_tgt_assoc {
struct nvmet_fc_hostport *hostport;
struct nvmet_fc_ls_iod *rcv_disconn;
struct list_head a_list;
- struct nvmet_fc_tgt_queue *queues[NVMET_NR_QUEUES + 1];
+ struct nvmet_fc_tgt_queue __rcu *queues[NVMET_NR_QUEUES + 1];
struct kref ref;
struct work_struct del_work;
struct rcu_head rcu;
--
2.29.2
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] nvmet-fc: add a missing __rcu annotation to nvmet_fc_tgt_assoc.queues
2021-02-07 16:20 [PATCH] nvmet-fc: add a missing __rcu annotation to nvmet_fc_tgt_assoc.queues Christoph Hellwig
@ 2021-02-07 18:58 ` Chaitanya Kulkarni
2021-02-08 23:37 ` James Smart
2021-02-08 23:44 ` Sagi Grimberg
2 siblings, 0 replies; 4+ messages in thread
From: Chaitanya Kulkarni @ 2021-02-07 18:58 UTC (permalink / raw)
To: Christoph Hellwig, Eldad.Zinger, Leonid.Ravich, Elad.Grupi, sagi,
james.smart
Cc: linux-nvme
On 2/7/21 08:20, Christoph Hellwig wrote:
> Make sparse happy after the recent conversion to RCU lookups.
>
> Fixes: 4e2f02bf77da ("nvmet-fc: use RCU proctection for assoc_list")
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks good.
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] nvmet-fc: add a missing __rcu annotation to nvmet_fc_tgt_assoc.queues
2021-02-07 16:20 [PATCH] nvmet-fc: add a missing __rcu annotation to nvmet_fc_tgt_assoc.queues Christoph Hellwig
2021-02-07 18:58 ` Chaitanya Kulkarni
@ 2021-02-08 23:37 ` James Smart
2021-02-08 23:44 ` Sagi Grimberg
2 siblings, 0 replies; 4+ messages in thread
From: James Smart @ 2021-02-08 23:37 UTC (permalink / raw)
To: Christoph Hellwig, Eldad.Zinger, Leonid.Ravich, Elad.Grupi, sagi,
chaitanya.kulkarni
Cc: linux-nvme
[-- Attachment #1.1: Type: text/plain, Size: 1099 bytes --]
On 2/7/2021 8:20 AM, Christoph Hellwig wrote:
> Make sparse happy after the recent conversion to RCU lookups.
>
> Fixes: 4e2f02bf77da ("nvmet-fc: use RCU proctection for assoc_list")
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>
Reviewed-by: James Smart <james.smart@broadcom.com>
Thanks
-- james
--
This electronic communication and the information and any files transmitted
with it, or attached to it, are confidential and are intended solely for
the use of the individual or entity to whom it is addressed and may contain
information that is confidential, legally privileged, protected by privacy
laws, or otherwise restricted from disclosure to anyone else. If you are
not the intended recipient or the person responsible for delivering the
e-mail to the intended recipient, you are hereby notified that any use,
copying, distributing, dissemination, forwarding, printing, or copying of
this e-mail is strictly prohibited. If you received this e-mail in error,
please return the e-mail to the sender, delete it from your computer, and
destroy any printed copy of it.
[-- Attachment #1.2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4163 bytes --]
[-- Attachment #2: Type: text/plain, Size: 158 bytes --]
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] nvmet-fc: add a missing __rcu annotation to nvmet_fc_tgt_assoc.queues
2021-02-07 16:20 [PATCH] nvmet-fc: add a missing __rcu annotation to nvmet_fc_tgt_assoc.queues Christoph Hellwig
2021-02-07 18:58 ` Chaitanya Kulkarni
2021-02-08 23:37 ` James Smart
@ 2021-02-08 23:44 ` Sagi Grimberg
2 siblings, 0 replies; 4+ messages in thread
From: Sagi Grimberg @ 2021-02-08 23:44 UTC (permalink / raw)
To: Christoph Hellwig, Eldad.Zinger, Leonid.Ravich, Elad.Grupi,
chaitanya.kulkarni, james.smart
Cc: linux-nvme
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-02-08 23:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-07 16:20 [PATCH] nvmet-fc: add a missing __rcu annotation to nvmet_fc_tgt_assoc.queues Christoph Hellwig
2021-02-07 18:58 ` Chaitanya Kulkarni
2021-02-08 23:37 ` James Smart
2021-02-08 23:44 ` Sagi Grimberg
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.