All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Fainelli <f.fainelli@gmail.com>
To: "Rafał Miłecki" <zajec5@gmail.com>,
	"Wim Van Sebroeck" <wim@linux-watchdog.org>,
	"Guenter Roeck" <linux@roeck-us.net>,
	"Rob Herring" <robh+dt@kernel.org>
Cc: "Florian Fainelli" <f.fainelli@gmail.com>,
	bcm-kernel-feedback-list@broadcom.com,
	linux-watchdog@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-mips@vger.kernel.org, "Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH 1/3] dt-bindings: watchdog: convert Broadcom's WDT to the json-schema
Date: Thu, 28 Oct 2021 09:31:42 -0700	[thread overview]
Message-ID: <d139ad05-1140-0972-de6f-53e6fa0029ec@gmail.com> (raw)
In-Reply-To: <20211028093059.32535-1-zajec5@gmail.com>

On 10/28/21 2:30 AM, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> This helps validating DTS files. While at it also rename it to bcm63xx.
> It's the first SoC with that hardware block and it's a naming schema
> used for other Broadcom blocks. It's common for some (originally)
> bcm63xx blocks to be reused in newer SoCs (like 7038 or 4908).
> 
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>

I would prefer you do not rename the binding especially as I am about to
remove the bcm63xx_wdt.c driver, and so having a binding name that sort
of matches the driver names makes it a lot easier to keep all of your
eggs in the same basket. We can argue whether 63xx came before 7xxx in
terms of time line, but that still does not justify the rename IMHO.

I realized that we are missing a 7038 pattern in the MAINTAINERS file
for the BCM7XXX entry, and that will be fixed shortly after sending this
email.

Please add Justin Chen (original author) and myself as maintainers for
this binding.
-- 
Florian

WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <f.fainelli@gmail.com>
To: "Rafał Miłecki" <zajec5@gmail.com>,
	"Wim Van Sebroeck" <wim@linux-watchdog.org>,
	"Guenter Roeck" <linux@roeck-us.net>,
	"Rob Herring" <robh+dt@kernel.org>
Cc: "Florian Fainelli" <f.fainelli@gmail.com>,
	bcm-kernel-feedback-list@broadcom.com,
	linux-watchdog@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-mips@vger.kernel.org, "Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH 1/3] dt-bindings: watchdog: convert Broadcom's WDT to the json-schema
Date: Thu, 28 Oct 2021 09:31:42 -0700	[thread overview]
Message-ID: <d139ad05-1140-0972-de6f-53e6fa0029ec@gmail.com> (raw)
In-Reply-To: <20211028093059.32535-1-zajec5@gmail.com>

On 10/28/21 2:30 AM, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> This helps validating DTS files. While at it also rename it to bcm63xx.
> It's the first SoC with that hardware block and it's a naming schema
> used for other Broadcom blocks. It's common for some (originally)
> bcm63xx blocks to be reused in newer SoCs (like 7038 or 4908).
> 
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>

I would prefer you do not rename the binding especially as I am about to
remove the bcm63xx_wdt.c driver, and so having a binding name that sort
of matches the driver names makes it a lot easier to keep all of your
eggs in the same basket. We can argue whether 63xx came before 7xxx in
terms of time line, but that still does not justify the rename IMHO.

I realized that we are missing a 7038 pattern in the MAINTAINERS file
for the BCM7XXX entry, and that will be fixed shortly after sending this
email.

Please add Justin Chen (original author) and myself as maintainers for
this binding.
-- 
Florian

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2021-10-28 16:31 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-28  9:30 [PATCH 1/3] dt-bindings: watchdog: convert Broadcom's WDT to the json-schema Rafał Miłecki
2021-10-28  9:30 ` Rafał Miłecki
2021-10-28  9:30 ` [PATCH 2/3] dt-bindings: watchdog: brcm,bcm63xx-wdt: add BCM4908 compatibility Rafał Miłecki
2021-10-28  9:30   ` [PATCH 2/3] dt-bindings: watchdog: brcm, bcm63xx-wdt: " Rafał Miłecki
2021-10-28  9:30 ` [PATCH 3/3] watchdog: bcm7038_wdt: support BCM4908 SoC Rafał Miłecki
2021-10-28  9:30   ` Rafał Miłecki
2021-10-28 16:29   ` Florian Fainelli
2021-10-28 16:29     ` Florian Fainelli
2021-10-28 16:57     ` Guenter Roeck
2021-10-28 16:57       ` Guenter Roeck
2021-10-29 12:15       ` Rafał Miłecki
2021-10-29 12:15         ` Rafał Miłecki
2021-10-29 14:15         ` Guenter Roeck
2021-10-29 14:15           ` Guenter Roeck
2021-10-29 14:18           ` Rafał Miłecki
2021-10-29 14:18             ` Rafał Miłecki
2021-10-29 11:39     ` Rafał Miłecki
2021-10-29 11:39       ` Rafał Miłecki
2021-10-29 13:03       ` Rob Herring
2021-10-29 13:03         ` Rob Herring
2021-10-29 16:45         ` Florian Fainelli
2021-10-29 16:45           ` Florian Fainelli
2021-10-29 16:56           ` Rafał Miłecki
2021-10-29 16:56             ` Rafał Miłecki
2021-10-29 17:43           ` Guenter Roeck
2021-10-29 17:43             ` Guenter Roeck
2021-10-29 17:53             ` Florian Fainelli
2021-10-29 17:53               ` Florian Fainelli
2021-10-29 18:10               ` Guenter Roeck
2021-10-29 18:10                 ` Guenter Roeck
2021-10-29 18:26                 ` Florian Fainelli
2021-10-29 18:26                   ` Florian Fainelli
2021-11-01 17:28           ` Rob Herring
2021-11-01 17:28             ` Rob Herring
2021-10-28 16:31 ` Florian Fainelli [this message]
2021-10-28 16:31   ` [PATCH 1/3] dt-bindings: watchdog: convert Broadcom's WDT to the json-schema Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d139ad05-1140-0972-de6f-53e6fa0029ec@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=rafal@milecki.pl \
    --cc=robh+dt@kernel.org \
    --cc=wim@linux-watchdog.org \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.