From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Jiaxin Yu <jiaxin.yu@mediatek.com>,
broonie@kernel.org, robh+dt@kernel.org
Cc: aaronyu@google.com, matthias.bgg@gmail.com,
trevor.wu@mediatek.com, tzungbi@google.com,
julianbraha@gmail.com, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [v3 15/19] ASoC: mediatek: mt8186: add machine driver with mt6366, da7219 and max98357
Date: Mon, 14 Mar 2022 11:44:58 +0100 [thread overview]
Message-ID: <d13b7bb3-989c-55eb-c7b9-41836ccb95a9@collabora.com> (raw)
In-Reply-To: <20220313151023.21229-16-jiaxin.yu@mediatek.com>
Il 13/03/22 16:10, Jiaxin Yu ha scritto:
> Add support for mt8186 board with mt6366, da7219 and max98357.
>
> Signed-off-by: Jiaxin Yu <jiaxin.yu@mediatek.com>
> ---
> .../mt8186/mt8186-mt6366-da7219-max98357.c | 924 ++++++++++++++++++
> 1 file changed, 924 insertions(+)
> create mode 100644 sound/soc/mediatek/mt8186/mt8186-mt6366-da7219-max98357.c
>
Hello Jiaxin,
I see some duplication between this one and the mt6366-rt1019-rt5682s....
....for this reason, I would propose to split out the MT6366 bits into a
common file, something like mt8186-mt6366-common.c, as to reduce the duplication.
If it is expected to see MT8186 machines with DA7219 or MAX98357, then it'd be a
good idea to also do something about preventively commonizing these ones, like
it is being done in ... MT8192, if I remember correctly.
Regards,
Angelo
WARNING: multiple messages have this Message-ID (diff)
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Jiaxin Yu <jiaxin.yu@mediatek.com>,
broonie@kernel.org, robh+dt@kernel.org
Cc: aaronyu@google.com, matthias.bgg@gmail.com,
trevor.wu@mediatek.com, tzungbi@google.com,
julianbraha@gmail.com, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [v3 15/19] ASoC: mediatek: mt8186: add machine driver with mt6366, da7219 and max98357
Date: Mon, 14 Mar 2022 11:44:58 +0100 [thread overview]
Message-ID: <d13b7bb3-989c-55eb-c7b9-41836ccb95a9@collabora.com> (raw)
In-Reply-To: <20220313151023.21229-16-jiaxin.yu@mediatek.com>
Il 13/03/22 16:10, Jiaxin Yu ha scritto:
> Add support for mt8186 board with mt6366, da7219 and max98357.
>
> Signed-off-by: Jiaxin Yu <jiaxin.yu@mediatek.com>
> ---
> .../mt8186/mt8186-mt6366-da7219-max98357.c | 924 ++++++++++++++++++
> 1 file changed, 924 insertions(+)
> create mode 100644 sound/soc/mediatek/mt8186/mt8186-mt6366-da7219-max98357.c
>
Hello Jiaxin,
I see some duplication between this one and the mt6366-rt1019-rt5682s....
....for this reason, I would propose to split out the MT6366 bits into a
common file, something like mt8186-mt6366-common.c, as to reduce the duplication.
If it is expected to see MT8186 machines with DA7219 or MAX98357, then it'd be a
good idea to also do something about preventively commonizing these ones, like
it is being done in ... MT8192, if I remember correctly.
Regards,
Angelo
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Jiaxin Yu <jiaxin.yu@mediatek.com>,
broonie@kernel.org, robh+dt@kernel.org
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org,
Project_Global_Chrome_Upstream_Group@mediatek.com,
tzungbi@google.com, linux-mediatek@lists.infradead.org,
trevor.wu@mediatek.com, matthias.bgg@gmail.com,
aaronyu@google.com, julianbraha@gmail.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [v3 15/19] ASoC: mediatek: mt8186: add machine driver with mt6366, da7219 and max98357
Date: Mon, 14 Mar 2022 11:44:58 +0100 [thread overview]
Message-ID: <d13b7bb3-989c-55eb-c7b9-41836ccb95a9@collabora.com> (raw)
In-Reply-To: <20220313151023.21229-16-jiaxin.yu@mediatek.com>
Il 13/03/22 16:10, Jiaxin Yu ha scritto:
> Add support for mt8186 board with mt6366, da7219 and max98357.
>
> Signed-off-by: Jiaxin Yu <jiaxin.yu@mediatek.com>
> ---
> .../mt8186/mt8186-mt6366-da7219-max98357.c | 924 ++++++++++++++++++
> 1 file changed, 924 insertions(+)
> create mode 100644 sound/soc/mediatek/mt8186/mt8186-mt6366-da7219-max98357.c
>
Hello Jiaxin,
I see some duplication between this one and the mt6366-rt1019-rt5682s....
....for this reason, I would propose to split out the MT6366 bits into a
common file, something like mt8186-mt6366-common.c, as to reduce the duplication.
If it is expected to see MT8186 machines with DA7219 or MAX98357, then it'd be a
good idea to also do something about preventively commonizing these ones, like
it is being done in ... MT8192, if I remember correctly.
Regards,
Angelo
WARNING: multiple messages have this Message-ID (diff)
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Jiaxin Yu <jiaxin.yu@mediatek.com>,
broonie@kernel.org, robh+dt@kernel.org
Cc: aaronyu@google.com, matthias.bgg@gmail.com,
trevor.wu@mediatek.com, tzungbi@google.com,
julianbraha@gmail.com, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [v3 15/19] ASoC: mediatek: mt8186: add machine driver with mt6366, da7219 and max98357
Date: Mon, 14 Mar 2022 11:44:58 +0100 [thread overview]
Message-ID: <d13b7bb3-989c-55eb-c7b9-41836ccb95a9@collabora.com> (raw)
In-Reply-To: <20220313151023.21229-16-jiaxin.yu@mediatek.com>
Il 13/03/22 16:10, Jiaxin Yu ha scritto:
> Add support for mt8186 board with mt6366, da7219 and max98357.
>
> Signed-off-by: Jiaxin Yu <jiaxin.yu@mediatek.com>
> ---
> .../mt8186/mt8186-mt6366-da7219-max98357.c | 924 ++++++++++++++++++
> 1 file changed, 924 insertions(+)
> create mode 100644 sound/soc/mediatek/mt8186/mt8186-mt6366-da7219-max98357.c
>
Hello Jiaxin,
I see some duplication between this one and the mt6366-rt1019-rt5682s....
....for this reason, I would propose to split out the MT6366 bits into a
common file, something like mt8186-mt6366-common.c, as to reduce the duplication.
If it is expected to see MT8186 machines with DA7219 or MAX98357, then it'd be a
good idea to also do something about preventively commonizing these ones, like
it is being done in ... MT8192, if I remember correctly.
Regards,
Angelo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-03-14 10:45 UTC|newest]
Thread overview: 156+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-13 15:10 [v3 00/19] ASoC: mediatek: Add support for MT8186 SoC Jiaxin Yu
2022-03-13 15:10 ` Jiaxin Yu
2022-03-13 15:10 ` Jiaxin Yu
2022-03-13 15:10 ` Jiaxin Yu
2022-03-13 15:10 ` [v3 01/19] ASoC: mediatek: mt6366: support for mt6366 codec Jiaxin Yu
2022-03-13 15:10 ` Jiaxin Yu
2022-03-13 15:10 ` Jiaxin Yu
2022-03-13 15:10 ` Jiaxin Yu
2022-03-13 15:10 ` [v3 02/19] dt-bindings: mediatek: mt6358: add new compatible for using mt6366 Jiaxin Yu
2022-03-13 15:10 ` Jiaxin Yu
2022-03-13 15:10 ` Jiaxin Yu
2022-03-13 15:10 ` Jiaxin Yu
2022-03-23 17:09 ` Rob Herring
2022-03-23 17:09 ` Rob Herring
2022-03-23 17:09 ` Rob Herring
2022-03-23 17:09 ` Rob Herring
2022-03-13 15:10 ` [v3 03/19] ASoC: mediatek: mt8186: support audsys clock control Jiaxin Yu
2022-03-13 15:10 ` Jiaxin Yu
2022-03-13 15:10 ` Jiaxin Yu
2022-03-13 15:10 ` Jiaxin Yu
2022-03-14 10:18 ` AngeloGioacchino Del Regno
2022-03-14 10:18 ` AngeloGioacchino Del Regno
2022-03-14 10:18 ` AngeloGioacchino Del Regno
2022-03-14 10:18 ` AngeloGioacchino Del Regno
2022-03-13 15:10 ` [v3 04/19] ASoC: mediatek: mt8186: support adda in platform driver Jiaxin Yu
2022-03-13 15:10 ` Jiaxin Yu
2022-03-13 15:10 ` Jiaxin Yu
2022-03-13 15:10 ` Jiaxin Yu
2022-03-14 10:25 ` AngeloGioacchino Del Regno
2022-03-14 10:25 ` AngeloGioacchino Del Regno
2022-03-14 10:25 ` AngeloGioacchino Del Regno
2022-03-14 10:25 ` AngeloGioacchino Del Regno
2022-03-13 15:10 ` [v3 05/19] ASoC: mediatek: mt8186: support hostless " Jiaxin Yu
2022-03-13 15:10 ` Jiaxin Yu
2022-03-13 15:10 ` Jiaxin Yu
2022-03-13 15:10 ` Jiaxin Yu
2022-03-14 10:25 ` AngeloGioacchino Del Regno
2022-03-14 10:25 ` AngeloGioacchino Del Regno
2022-03-14 10:25 ` AngeloGioacchino Del Regno
2022-03-14 10:25 ` AngeloGioacchino Del Regno
2022-03-13 15:10 ` [v3 06/19] ASoC: mediatek: mt8186: support hw gain " Jiaxin Yu
2022-03-13 15:10 ` Jiaxin Yu
2022-03-13 15:10 ` Jiaxin Yu
2022-03-13 15:10 ` Jiaxin Yu
2022-03-14 10:25 ` AngeloGioacchino Del Regno
2022-03-14 10:25 ` AngeloGioacchino Del Regno
2022-03-14 10:25 ` AngeloGioacchino Del Regno
2022-03-14 10:25 ` AngeloGioacchino Del Regno
2022-03-13 15:10 ` [v3 07/19] ASoC: mediatek: mt8186: support i2s " Jiaxin Yu
2022-03-13 15:10 ` Jiaxin Yu
2022-03-13 15:10 ` Jiaxin Yu
2022-03-13 15:10 ` Jiaxin Yu
2022-03-14 10:28 ` AngeloGioacchino Del Regno
2022-03-14 10:28 ` AngeloGioacchino Del Regno
2022-03-14 10:28 ` AngeloGioacchino Del Regno
2022-03-14 10:28 ` AngeloGioacchino Del Regno
2022-03-13 15:10 ` [v3 08/19] ASoC: mediatek: mt8186: support pcm " Jiaxin Yu
2022-03-13 15:10 ` Jiaxin Yu
2022-03-13 15:10 ` Jiaxin Yu
2022-03-13 15:10 ` Jiaxin Yu
2022-03-14 10:29 ` AngeloGioacchino Del Regno
2022-03-14 10:29 ` AngeloGioacchino Del Regno
2022-03-14 10:29 ` AngeloGioacchino Del Regno
2022-03-14 10:29 ` AngeloGioacchino Del Regno
2022-03-13 15:10 ` [v3 09/19] ASoC: mediatek: mt8186: support src " Jiaxin Yu
2022-03-13 15:10 ` Jiaxin Yu
2022-03-13 15:10 ` Jiaxin Yu
2022-03-13 15:10 ` Jiaxin Yu
2022-03-14 10:34 ` AngeloGioacchino Del Regno
2022-03-14 10:34 ` AngeloGioacchino Del Regno
2022-03-14 10:34 ` AngeloGioacchino Del Regno
2022-03-14 10:34 ` AngeloGioacchino Del Regno
2022-03-13 15:10 ` [v3 10/19] ASoC: mediatek: mt8186: support tdm " Jiaxin Yu
2022-03-13 15:10 ` Jiaxin Yu
2022-03-13 15:10 ` Jiaxin Yu
2022-03-13 15:10 ` Jiaxin Yu
2022-03-14 10:39 ` AngeloGioacchino Del Regno
2022-03-14 10:39 ` AngeloGioacchino Del Regno
2022-03-14 10:39 ` AngeloGioacchino Del Regno
2022-03-14 10:39 ` AngeloGioacchino Del Regno
2022-03-15 13:15 ` Mark Brown
2022-03-15 13:15 ` Mark Brown
2022-03-15 13:15 ` Mark Brown
2022-03-15 13:15 ` Mark Brown
2022-03-15 13:19 ` AngeloGioacchino Del Regno
2022-03-15 13:19 ` AngeloGioacchino Del Regno
2022-03-15 13:19 ` AngeloGioacchino Del Regno
2022-03-15 13:19 ` AngeloGioacchino Del Regno
2022-03-13 15:10 ` [v3 11/19] ASoC: mediatek: mt8186: support audio clock control " Jiaxin Yu
2022-03-13 15:10 ` Jiaxin Yu
2022-03-13 15:10 ` Jiaxin Yu
2022-03-13 15:10 ` Jiaxin Yu
2022-03-13 15:10 ` [v3 12/19] ASoC: mediatek: mt8186: support gpio " Jiaxin Yu
2022-03-13 15:10 ` Jiaxin Yu
2022-03-13 15:10 ` Jiaxin Yu
2022-03-13 15:10 ` Jiaxin Yu
2022-03-13 15:10 ` [v3 13/19] ASoC: mediatek: mt8186: add " Jiaxin Yu
2022-03-13 15:10 ` Jiaxin Yu
2022-03-13 15:10 ` Jiaxin Yu
2022-03-13 18:59 ` kernel test robot
2022-03-13 18:59 ` kernel test robot
2022-03-13 18:59 ` kernel test robot
2022-03-13 18:59 ` kernel test robot
2022-03-14 10:11 ` Jiaxin Yu
2022-03-14 10:11 ` Jiaxin Yu
2022-03-14 10:11 ` Jiaxin Yu
2022-03-14 10:11 ` Jiaxin Yu
2022-03-14 10:11 ` Jiaxin Yu
2022-03-13 15:10 ` [v3 14/19] dt-bindings: mediatek: mt8186: add audio afe document Jiaxin Yu
2022-03-13 15:10 ` Jiaxin Yu
2022-03-13 15:10 ` Jiaxin Yu
2022-03-13 15:10 ` Jiaxin Yu
2022-03-14 10:25 ` AngeloGioacchino Del Regno
2022-03-14 10:25 ` AngeloGioacchino Del Regno
2022-03-14 10:25 ` AngeloGioacchino Del Regno
2022-03-14 10:25 ` AngeloGioacchino Del Regno
2022-03-13 15:10 ` [v3 15/19] ASoC: mediatek: mt8186: add machine driver with mt6366, da7219 and max98357 Jiaxin Yu
2022-03-13 15:10 ` Jiaxin Yu
2022-03-13 15:10 ` Jiaxin Yu
2022-03-13 15:10 ` Jiaxin Yu
2022-03-14 10:44 ` AngeloGioacchino Del Regno [this message]
2022-03-14 10:44 ` AngeloGioacchino Del Regno
2022-03-14 10:44 ` AngeloGioacchino Del Regno
2022-03-14 10:44 ` AngeloGioacchino Del Regno
2022-04-05 4:06 ` Jiaxin Yu
2022-04-05 4:06 ` Jiaxin Yu
2022-04-05 4:06 ` Jiaxin Yu
2022-04-05 4:06 ` Jiaxin Yu
2022-03-13 15:10 ` [v3 16/19] dt-bindings: mediatek: mt8186: add mt8186-mt6366-da7219-max98357 document Jiaxin Yu
2022-03-13 15:10 ` Jiaxin Yu
2022-03-13 15:10 ` Jiaxin Yu
2022-03-13 15:10 ` Jiaxin Yu
2022-03-13 15:10 ` [v3 17/19] ASoC: mediatek: mt8186: add machine driver with mt6366, rt1019 and rt5682s Jiaxin Yu
2022-03-13 15:10 ` Jiaxin Yu
2022-03-13 15:10 ` Jiaxin Yu
2022-03-13 15:10 ` Jiaxin Yu
2022-03-13 15:10 ` [v3 18/19] dt-bindings: mediatek: mt8186: add mt8186-mt6366-rt1019-rt5682s document Jiaxin Yu
2022-03-13 15:10 ` Jiaxin Yu
2022-03-13 15:10 ` Jiaxin Yu
2022-03-13 15:10 ` Jiaxin Yu
2022-03-13 15:10 ` [v3 19/19] ASoC: mediatek: mt6358: add missing EXPORT_SYMBOLs Jiaxin Yu
2022-03-13 15:10 ` Jiaxin Yu
2022-03-13 15:10 ` Jiaxin Yu
2022-03-13 15:10 ` Jiaxin Yu
2022-03-14 10:18 ` AngeloGioacchino Del Regno
2022-03-14 10:18 ` AngeloGioacchino Del Regno
2022-03-14 10:18 ` AngeloGioacchino Del Regno
2022-03-14 10:18 ` AngeloGioacchino Del Regno
2022-03-14 11:55 ` Jiaxin Yu
2022-03-14 11:55 ` Jiaxin Yu
2022-03-14 11:55 ` Jiaxin Yu
2022-03-14 11:55 ` Jiaxin Yu
2022-04-05 3:04 ` Jiaxin Yu
2022-04-05 3:04 ` Jiaxin Yu
2022-04-05 3:04 ` Jiaxin Yu
2022-04-05 3:04 ` Jiaxin Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d13b7bb3-989c-55eb-c7b9-41836ccb95a9@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=aaronyu@google.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jiaxin.yu@mediatek.com \
--cc=julianbraha@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=trevor.wu@mediatek.com \
--cc=tzungbi@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.