* [PATCH] staging: serqt_usb2: Add blank lines after declarations.
@ 2014-03-30 21:29 Thomas Vegas
2014-03-31 2:02 ` Joe Perches
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Vegas @ 2014-03-30 21:29 UTC (permalink / raw)
To: gregkh; +Cc: linux-kernel, devel
Use a more common kernel coding style.
Signed-off-by: Thomas Vegas <thomas_75@safe-mail.net>
---
drivers/staging/serqt_usb2/serqt_usb2.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/serqt_usb2/serqt_usb2.c b/drivers/staging/serqt_usb2/serqt_usb2.c
index 0267dd8..f883f48 100644
--- a/drivers/staging/serqt_usb2/serqt_usb2.c
+++ b/drivers/staging/serqt_usb2/serqt_usb2.c
@@ -995,8 +995,8 @@ static void qt_close(struct usb_serial_port *port)
struct tty_struct *tty;
int status;
unsigned int index;
- status = 0;
+ status = 0;
tty = tty_port_tty_get(&port->port);
index = port->port_number;
@@ -1268,8 +1268,8 @@ static void qt_set_termios(struct tty_struct *tty,
if (I_IXOFF(tty) || I_IXON(tty)) {
unsigned char stop_char = STOP_CHAR(tty);
unsigned char start_char = START_CHAR(tty);
- status =
- box_set_sw_flow_ctrl(port->serial, index, stop_char,
+
+ status = box_set_sw_flow_ctrl(port->serial, index, stop_char,
start_char);
if (status < 0)
dev_dbg(&port->dev,
--
1.8.3.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: serqt_usb2: Add blank lines after declarations.
2014-03-30 21:29 [PATCH] staging: serqt_usb2: Add blank lines after declarations Thomas Vegas
@ 2014-03-31 2:02 ` Joe Perches
0 siblings, 0 replies; 2+ messages in thread
From: Joe Perches @ 2014-03-31 2:02 UTC (permalink / raw)
To: Thomas Vegas; +Cc: gregkh, linux-kernel, devel
On Sun, 2014-03-30 at 23:29 +0200, Thomas Vegas wrote:
> Use a more common kernel coding style.
[]
> diff --git a/drivers/staging/serqt_usb2/serqt_usb2.c b/drivers/staging/serqt_usb2/serqt_usb2.c
[]
> @@ -995,8 +995,8 @@ static void qt_close(struct usb_serial_port *port)
> struct tty_struct *tty;
> int status;
> unsigned int index;
> - status = 0;
>
> + status = 0;
My preference would be to change the declarations to
struct tty_struct *tty = tty_port_tty_get(&port->port);
unsigned int index = port->port_number;
int status = 0;
> tty = tty_port_tty_get(&port->port);
> index = port->port_number;
>
> @@ -1268,8 +1268,8 @@ static void qt_set_termios(struct tty_struct *tty,
> if (I_IXOFF(tty) || I_IXON(tty)) {
> unsigned char stop_char = STOP_CHAR(tty);
> unsigned char start_char = START_CHAR(tty);
> - status =
> - box_set_sw_flow_ctrl(port->serial, index, stop_char,
> +
> + status = box_set_sw_flow_ctrl(port->serial, index, stop_char,
> start_char);
Please realign start_char to the open parenthesis
status = box_set_sw_flow_ctrl(port->serial, index, stop_char,
start_char);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-03-31 2:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-03-30 21:29 [PATCH] staging: serqt_usb2: Add blank lines after declarations Thomas Vegas
2014-03-31 2:02 ` Joe Perches
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.