All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hannes Reinecke <hare@suse.de>
To: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@redhat.com>
Subject: Re: [RFC] [PATCH] add serial keyword to the weightedpath prioritizer
Date: Mon, 1 Aug 2016 15:18:16 +0200	[thread overview]
Message-ID: <d14bb6d9-70f2-0daf-7fd7-91e76cc6a1d7@suse.de> (raw)
In-Reply-To: <CABr-Gnd6zGeHgo5ka1LjQ5xB2WtZVCW_-=fH8UYZR_qppfog8Q@mail.gmail.com>

On 08/01/2016 02:25 PM, Christophe Varoqui wrote:
> Or we could honor arythmetic expressions like "5*alua+weightedpath",
> giving users more control about preferences (and more opportunities to
> step on their toes, sure).
>
Ugh. No.
You still would need to know which values the 'alua' (or any 
prioritizer) will be returning.
ATM there is no guarantee nor even advise which values a prioritizer 
should return. Which in itself is a good idea IMHO.

> Another idea, less invasive if possible, but less versatile :
>
> - Merge the alua prioritizer into the weightedpath prioritizer, given
> the optimized/non-optimized and other ALUA states are available in the
> path struct and have their snprint_path_* function and %wildcard.
>
Hmm. I still prefer the 'stacked prioritizer' approach, what with it 
being far more flexible.

> - Then weightedpath prio_args can be extended to support additive
> priorities, like "alua <optimized state>:<... state> 10 serial foo 20"
>
Which again would require us to define the possible return values from 
the alua (or any other handler).

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		   Teamlead Storage & Networking
hare@suse.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)

  reply	other threads:[~2016-08-01 13:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-31 19:26 [RFC] [PATCH] add serial keyword to the weightedpath prioritizer Christophe Varoqui
2016-08-01  7:49 ` Hannes Reinecke
2016-08-01  8:42   ` Christophe Varoqui
2016-08-01 11:40     ` Hannes Reinecke
2016-08-01 12:25       ` Christophe Varoqui
2016-08-01 13:18         ` Hannes Reinecke [this message]
2016-08-01 16:02 ` Bart Van Assche
2016-08-01 16:11   ` Christophe Varoqui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d14bb6d9-70f2-0daf-7fd7-91e76cc6a1d7@suse.de \
    --to=hare@suse.de \
    --cc=christophe.varoqui@opensvc.com \
    --cc=dm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.