Re: [RFC] [PATCH] add serial keyword to the weightedpath prioritizer

From: Christophe Varoqui <christophe.varoqui@opensvc.com>
To: Bart Van Assche <bart.vanassche@sandisk.com>
Cc: device-mapper development <dm-devel@redhat.com>
Subject: Re: [RFC] [PATCH] add serial keyword to the weightedpath prioritizer
Date: Mon, 1 Aug 2016 18:11:35 +0200	[thread overview]
Message-ID: <CABr-GnfV9SLd3-qeR07yu_Dwx2zNWE6gxa9Sm792qhGx28cvDA@mail.gmail.com> (raw)
In-Reply-To: <577b156f-4b6f-ae00-10ba-d5b65fbe2ae7@sandisk.com>

[-- Attachment #1.1: Type: text/plain, Size: 892 bytes --]

Oops no !
Thanks for noting.

An incremental fix is now merged.

You are right about the spelling fix that accidentaly was wrapped into this
patch, but the patch has already been pushed online as-is so I don't see
how I can improve that now.

Regards,
Christophe

On Mon, Aug 1, 2016 at 6:02 PM, Bart Van Assche <bart.vanassche@sandisk.com>
wrote:

> On 07/31/2016 12:26 PM, Christophe Varoqui wrote:
>
>> Can you review this patch, adding a new 'serial' keyword to the
>> weightedpath prioritizer.
>>
>
> Is the following part of the patch intended?
>
>         } else if (!strcmp(regex, WWN)) {
> -               if (build_wwn_path(pp, path, FILE_NAME_SIZE) != 0) {
> +               if (build_serial_path(pp, path, FILE_NAME_SIZE) != 0) {
>
> Additionally, have you considered to apply the mulitpathd -> multipathd
> spelling fix in this patch as a separate patch?
>
> Thanks,
>
> Bart.
>

[-- Attachment #1.2: Type: text/html, Size: 1522 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]