* [ANNOUNCE] xfsprogs for-next updated to 7189ee53
@ 2021-10-15 19:42 Eric Sandeen
2021-10-15 20:32 ` [ANNOUNCE] xfsprogs for-next rebased to b4c6731a Eric Sandeen
0 siblings, 1 reply; 5+ messages in thread
From: Eric Sandeen @ 2021-10-15 19:42 UTC (permalink / raw)
To: xfs
[-- Attachment #1.1: Type: text/plain, Size: 6857 bytes --]
Hi folks,
The for-next branch of the xfsprogs repository at:
git://git.kernel.org/pub/scm/fs/xfs/xfsprogs-dev.git
has just been updated.
Patches often get missed, so please check if your outstanding
patches were in this update. If they have not been in this update,
please resubmit them to linux-xfs@vger.kernel.org so they can be
picked up in the next update.
This is really just the libxfs-5.14 sync (finally!). Big thanks
to chandan, djwong, dchinner who all helped significantly with what
was a much more challenging libxfs sync this time.
Odds are this will be the bulk of the final 5.14 release. I will just
add Darrick's deprecation warning, and anything else I get reminded
of in the next week. :)
Thanks,
-Eric
The new head of the for-next branch is commit:
7189ee53 xfs_db: convert the agresv command to use for_each_perag
New Commits:
Allison Henderson (15):
[6192efa0] xfs: Reverse apply 72b97ea40d
[2e99d844] xfs: Add xfs_attr_node_remove_name
[93c12ca7] xfs: Refactor xfs_attr_set_shortform
[fd1fa5dc] xfs: Separate xfs_attr_node_addname and xfs_attr_node_addname_clear_incomplete
[60e52902] xfs: Add helper xfs_attr_node_addname_find_attr
[87f9c1ef] xfs: Hoist xfs_attr_node_addname
[d5ad8996] xfs: Hoist xfs_attr_leaf_addname
[f3b8734c] xfs: Hoist node transaction handling
[d9e349b4] xfs: Add delay ready attr remove routines
[fc58731c] xfs: Add delay ready attr set routines
[9347c64a] xfs: Remove xfs_attr_rmtval_set
[74d86e11] xfs: Clean up xfs_attr_node_addname_clear_incomplete
[326d555b] xfs: Fix default ASSERT in xfs_attr_set_iter
[425d2fa7] xfs: Make attr name schemes consistent
[8e407b7c] xfs: Initialize error in xfs_attr_remove_iter
Christoph Hellwig (1):
[86fbe221] xfs: mark xfs_bmap_set_attrforkoff static
Darrick J. Wong (7):
[18986e26] libxfs: fix call_rcu crash when unmounting the fake mount in mkfs
[ec59d2c9] xfs: clean up open-coded fs block unit conversions
[a3b7445c] xfs: fix radix tree tag signs
[3ce0b614] xfs: fix endianness issue in xfs_ag_shrink_space
[a0ecdcb2] xfs: check for sparse inode clusters that cross new EOAG when shrinking
[20cd781d] xfs: correct the narrative around misaligned rtinherit/extszinherit dirs
[7189ee53] xfs_db: convert the agresv command to use for_each_perag
Dave Chinner (28):
[f9a530f7] xfs: use xfs_buf_alloc_pages for uncached buffers
[9356d46f] xfs: move xfs_perag_get/put to xfs_ag.[ch]
[5e5ea04e] xfs: move perag structure and setup to libxfs/xfs_ag.[ch]
[ad8ddf16] xfs: make for_each_perag... a first class citizen
[35a68866] xfs: convert raw ag walks to use for_each_perag
[088be795] xfs: convert xfs_iwalk to use perag references
[feea80af] xfs: convert secondary superblock walk to use perags
[fd1d428e] xfs: pass perags through to the busy extent code
[726f3756] xfs: push perags through the ag reservation callouts
[3bc39252] xfs: pass perags around in fsmap data dev functions
[f329b883] xfs: add a perag to the btree cursor
[c7aecb6a] xfs: convert rmap btree cursor to using a perag
[fd5d24f8] xfs: convert refcount btree cursor to use perags
[6225c0b1] xfs: convert allocbt cursors to use perags
[864e0520] xfs: use perag for ialloc btree cursors
[c5cec050] xfs: remove agno from btree cursor
[48313127] xfs: simplify xfs_dialloc_select_ag() return values
[9dead8d8] xfs: collapse AG selection for inode allocation
[d767a286] xfs: get rid of xfs_dir_ialloc()
[5ae8938e] xfs: inode allocation can use a single perag instance
[4eef1273] xfs: clean up and simplify xfs_dialloc()
[0613aa91] xfs: use perag through unlink processing
[2a978990] xfs: remove xfs_perag_t
[82ebf65d] xfs: drop the AGI being passed to xfs_check_agi_freecount
[f19ae9c5] xfs: perag may be null in xfs_imap()
[5f5bb116] xfs: log stripe roundoff is a property of the log
[a4cf5233] xfs: xfs_log_force_lsn isn't passed a LSN
[5d2fd591] xfs: logging the on disk inode LSN can make it go backwards
Gustavo A. R. Silva (1):
[173e4568] xfs: Fix multiple fall-through warnings for Clang
Jiapeng Chong (1):
[558e5cdd] xfs: Remove redundant assignment to busy
Shaokun Zhang (1):
[9b849afb] xfs: sort variable alphabetically to avoid repeated declaration
Code Diffstat:
db/fsmap.c | 17 +-
db/info.c | 18 +-
include/libxfs.h | 1 +
include/xfs_mount.h | 67 +---
libfrog/radix-tree.h | 3 +
libxfs/init.c | 67 +---
libxfs/libxfs_api_defs.h | 2 +
libxfs/libxfs_priv.h | 14 +-
libxfs/util.c | 12 +-
libxfs/xfs_ag.c | 287 +++++++++++++-
libxfs/xfs_ag.h | 136 +++++++
libxfs/xfs_ag_resv.c | 11 +-
libxfs/xfs_ag_resv.h | 15 +
libxfs/xfs_alloc.c | 111 +++---
libxfs/xfs_alloc.h | 2 +-
libxfs/xfs_alloc_btree.c | 31 +-
libxfs/xfs_alloc_btree.h | 9 +-
libxfs/xfs_attr.c | 910 ++++++++++++++++++++++++++------------------
libxfs/xfs_attr.h | 403 ++++++++++++++++++++
libxfs/xfs_attr_leaf.c | 5 +-
libxfs/xfs_attr_leaf.h | 2 +-
libxfs/xfs_attr_remote.c | 167 ++++----
libxfs/xfs_attr_remote.h | 8 +-
libxfs/xfs_bmap.c | 3 +-
libxfs/xfs_bmap.h | 1 -
libxfs/xfs_btree.c | 15 +-
libxfs/xfs_btree.h | 10 +-
libxfs/xfs_ialloc.c | 692 ++++++++++++++++-----------------
libxfs/xfs_ialloc.h | 43 +--
libxfs/xfs_ialloc_btree.c | 46 +--
libxfs/xfs_ialloc_btree.h | 13 +-
libxfs/xfs_inode_buf.c | 30 +-
libxfs/xfs_log_format.h | 14 +-
libxfs/xfs_refcount.c | 122 +++---
libxfs/xfs_refcount.h | 9 +-
libxfs/xfs_refcount_btree.c | 39 +-
libxfs/xfs_refcount_btree.h | 7 +-
libxfs/xfs_rmap.c | 147 +++----
libxfs/xfs_rmap.h | 6 +-
libxfs/xfs_rmap_btree.c | 46 +--
libxfs/xfs_rmap_btree.h | 6 +-
libxfs/xfs_sb.c | 145 +------
libxfs/xfs_sb.h | 9 -
libxfs/xfs_shared.h | 40 +-
libxfs/xfs_trans_inode.c | 10 +-
libxfs/xfs_types.c | 4 +-
libxfs/xfs_types.h | 1 +
repair/agbtree.c | 28 +-
repair/agbtree.h | 8 +-
repair/phase5.c | 16 +-
repair/rmap.c | 43 ++-
51 files changed, 2333 insertions(+), 1518 deletions(-)
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* [ANNOUNCE] xfsprogs for-next rebased to b4c6731a
2021-10-15 19:42 [ANNOUNCE] xfsprogs for-next updated to 7189ee53 Eric Sandeen
@ 2021-10-15 20:32 ` Eric Sandeen
2021-10-16 4:10 ` Darrick J. Wong
0 siblings, 1 reply; 5+ messages in thread
From: Eric Sandeen @ 2021-10-15 20:32 UTC (permalink / raw)
To: xfs
On 10/15/21 2:42 PM, Eric Sandeen wrote:
> Hi folks,
>
> The for-next branch of the xfsprogs repository at:
>
> git://git.kernel.org/pub/scm/fs/xfs/xfsprogs-dev.git
>
> has just been updated.
>
> Patches often get missed, so please check if your outstanding
> patches were in this update. If they have not been in this update,
> please resubmit them to linux-xfs@vger.kernel.org so they can be
> picked up in the next update.
>
> This is really just the libxfs-5.14 sync (finally!). Big thanks
> to chandan, djwong, dchinner who all helped significantly with what
> was a much more challenging libxfs sync this time.
>
> Odds are this will be the bulk of the final 5.14 release. I will just
> add Darrick's deprecation warning, and anything else I get reminded
> of in the next week. :)
I missed Derrick's "libxfs: fix crash on second attempt to initialize library"
because my old userspace rcu library did not exhibit the problem. :/
Rather than leave a few dozen commits with regressed behavior as a bisect bomb,
I have force-pushed and anybody who pulled in the last hour will need to rebase.
Sorry about that!
Now it's:
New Commits:
Allison Henderson (15):
[67f397e4] xfs: Reverse apply 72b97ea40d
[48a540b6] xfs: Add xfs_attr_node_remove_name
[0469587e] xfs: Refactor xfs_attr_set_shortform
[473c6b8f] xfs: Separate xfs_attr_node_addname and xfs_attr_node_addname_clear_incomplete
[f7dcc61f] xfs: Add helper xfs_attr_node_addname_find_attr
[edd2419e] xfs: Hoist xfs_attr_node_addname
[1200ab60] xfs: Hoist xfs_attr_leaf_addname
[7e9eeb93] xfs: Hoist node transaction handling
[c749b4e1] xfs: Add delay ready attr remove routines
[d6d6237c] xfs: Add delay ready attr set routines
[1ad8a3b5] xfs: Remove xfs_attr_rmtval_set
[38f71479] xfs: Clean up xfs_attr_node_addname_clear_incomplete
[2c8cf7d9] xfs: Fix default ASSERT in xfs_attr_set_iter
[f0c4e745] xfs: Make attr name schemes consistent
[13f632a6] xfs: Initialize error in xfs_attr_remove_iter
Christoph Hellwig (1):
[8a3be25d] xfs: mark xfs_bmap_set_attrforkoff static
Darrick J. Wong (8):
[7bf9cd9d] libxfs: fix call_rcu crash when unmounting the fake mount in mkfs
[c1ab394a] libxfs: fix crash on second attempt to initialize library
[6d211aaa] xfs: clean up open-coded fs block unit conversions
[79eb2dcf] xfs: fix radix tree tag signs
[a789987d] xfs: fix endianness issue in xfs_ag_shrink_space
[23435e3c] xfs: check for sparse inode clusters that cross new EOAG when shrinking
[d7de0c3e] xfs: correct the narrative around misaligned rtinherit/extszinherit dirs
[b4c6731a] xfs_db: convert the agresv command to use for_each_perag
Dave Chinner (28):
[0bba7995] xfs: use xfs_buf_alloc_pages for uncached buffers
[f93d2173] xfs: move xfs_perag_get/put to xfs_ag.[ch]
[4bcd30f6] xfs: move perag structure and setup to libxfs/xfs_ag.[ch]
[bcac47dc] xfs: make for_each_perag... a first class citizen
[29d36774] xfs: convert raw ag walks to use for_each_perag
[b92a329e] xfs: convert xfs_iwalk to use perag references
[3a0efe08] xfs: convert secondary superblock walk to use perags
[7635c486] xfs: pass perags through to the busy extent code
[653f37bc] xfs: push perags through the ag reservation callouts
[48af87dd] xfs: pass perags around in fsmap data dev functions
[ca7d293d] xfs: add a perag to the btree cursor
[195c248c] xfs: convert rmap btree cursor to using a perag
[971fceb4] xfs: convert refcount btree cursor to use perags
[ecb44e84] xfs: convert allocbt cursors to use perags
[a426d0e1] xfs: use perag for ialloc btree cursors
[a0577dbb] xfs: remove agno from btree cursor
[3fbe9fa3] xfs: simplify xfs_dialloc_select_ag() return values
[d38ed6a9] xfs: collapse AG selection for inode allocation
[51b1e167] xfs: get rid of xfs_dir_ialloc()
[895ee7c3] xfs: inode allocation can use a single perag instance
[771d0670] xfs: clean up and simplify xfs_dialloc()
[b8268cdd] xfs: use perag through unlink processing
[d2ff101f] xfs: remove xfs_perag_t
[1dbf114f] xfs: drop the AGI being passed to xfs_check_agi_freecount
[e86bc63f] xfs: perag may be null in xfs_imap()
[6d95c77a] xfs: log stripe roundoff is a property of the log
[08602f16] xfs: xfs_log_force_lsn isn't passed a LSN
[f682c323] xfs: logging the on disk inode LSN can make it go backwards
Gustavo A. R. Silva (1):
[8b1a8326] xfs: Fix multiple fall-through warnings for Clang
Jiapeng Chong (1):
[396a1948] xfs: Remove redundant assignment to busy
Shaokun Zhang (1):
[398f22e7] xfs: sort variable alphabetically to avoid repeated declaration
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [ANNOUNCE] xfsprogs for-next rebased to b4c6731a
2021-10-15 20:32 ` [ANNOUNCE] xfsprogs for-next rebased to b4c6731a Eric Sandeen
@ 2021-10-16 4:10 ` Darrick J. Wong
2021-10-16 6:29 ` Dave Chinner
0 siblings, 1 reply; 5+ messages in thread
From: Darrick J. Wong @ 2021-10-16 4:10 UTC (permalink / raw)
To: Eric Sandeen; +Cc: xfs
On Fri, Oct 15, 2021 at 03:32:41PM -0500, Eric Sandeen wrote:
> On 10/15/21 2:42 PM, Eric Sandeen wrote:
> > Hi folks,
> >
> > The for-next branch of the xfsprogs repository at:
> >
> > git://git.kernel.org/pub/scm/fs/xfs/xfsprogs-dev.git
> >
> > has just been updated.
> >
> > Patches often get missed, so please check if your outstanding
> > patches were in this update. If they have not been in this update,
> > please resubmit them to linux-xfs@vger.kernel.org so they can be
> > picked up in the next update.
> >
> > This is really just the libxfs-5.14 sync (finally!). Big thanks
> > to chandan, djwong, dchinner who all helped significantly with what
> > was a much more challenging libxfs sync this time.
> >
> > Odds are this will be the bulk of the final 5.14 release. I will just
> > add Darrick's deprecation warning, and anything else I get reminded
> > of in the next week. :)
>
> I missed Derrick's "libxfs: fix crash on second attempt to initialize library"
> because my old userspace rcu library did not exhibit the problem. :/
>
> Rather than leave a few dozen commits with regressed behavior as a bisect bomb,
> I have force-pushed and anybody who pulled in the last hour will need to rebase.
> Sorry about that!
Er... /me notices the following discrepancy between the kernel and
xfsprogs in libxfs/xfs_shared.h:
--- a/libxfs/xfs_shared.h
+++ b/libxfs/xfs_shared.h
@@ -174,24 +174,4 @@ struct xfs_ino_geometry {
};
-/* Faked up kernel bits */
-struct rb_root {
-};
-
-#define RB_ROOT (struct rb_root) { }
-
-typedef struct wait_queue_head {
-} wait_queue_head_t;
-
-#define init_waitqueue_head(wqh) do { } while(0)
-
-struct rhashtable {
-};
-
-struct delayed_work {
-};
-
-#define INIT_DELAYED_WORK(work, func) do { } while(0)
-#define cancel_delayed_work_sync(work) do { } while(0)
-
#endif /* __XFS_SHARED_H__ */
--D
> Now it's:
>
> New Commits:
>
> Allison Henderson (15):
> [67f397e4] xfs: Reverse apply 72b97ea40d
> [48a540b6] xfs: Add xfs_attr_node_remove_name
> [0469587e] xfs: Refactor xfs_attr_set_shortform
> [473c6b8f] xfs: Separate xfs_attr_node_addname and xfs_attr_node_addname_clear_incomplete
> [f7dcc61f] xfs: Add helper xfs_attr_node_addname_find_attr
> [edd2419e] xfs: Hoist xfs_attr_node_addname
> [1200ab60] xfs: Hoist xfs_attr_leaf_addname
> [7e9eeb93] xfs: Hoist node transaction handling
> [c749b4e1] xfs: Add delay ready attr remove routines
> [d6d6237c] xfs: Add delay ready attr set routines
> [1ad8a3b5] xfs: Remove xfs_attr_rmtval_set
> [38f71479] xfs: Clean up xfs_attr_node_addname_clear_incomplete
> [2c8cf7d9] xfs: Fix default ASSERT in xfs_attr_set_iter
> [f0c4e745] xfs: Make attr name schemes consistent
> [13f632a6] xfs: Initialize error in xfs_attr_remove_iter
>
> Christoph Hellwig (1):
> [8a3be25d] xfs: mark xfs_bmap_set_attrforkoff static
>
> Darrick J. Wong (8):
> [7bf9cd9d] libxfs: fix call_rcu crash when unmounting the fake mount in mkfs
> [c1ab394a] libxfs: fix crash on second attempt to initialize library
> [6d211aaa] xfs: clean up open-coded fs block unit conversions
> [79eb2dcf] xfs: fix radix tree tag signs
> [a789987d] xfs: fix endianness issue in xfs_ag_shrink_space
> [23435e3c] xfs: check for sparse inode clusters that cross new EOAG when shrinking
> [d7de0c3e] xfs: correct the narrative around misaligned rtinherit/extszinherit dirs
> [b4c6731a] xfs_db: convert the agresv command to use for_each_perag
>
> Dave Chinner (28):
> [0bba7995] xfs: use xfs_buf_alloc_pages for uncached buffers
> [f93d2173] xfs: move xfs_perag_get/put to xfs_ag.[ch]
> [4bcd30f6] xfs: move perag structure and setup to libxfs/xfs_ag.[ch]
> [bcac47dc] xfs: make for_each_perag... a first class citizen
> [29d36774] xfs: convert raw ag walks to use for_each_perag
> [b92a329e] xfs: convert xfs_iwalk to use perag references
> [3a0efe08] xfs: convert secondary superblock walk to use perags
> [7635c486] xfs: pass perags through to the busy extent code
> [653f37bc] xfs: push perags through the ag reservation callouts
> [48af87dd] xfs: pass perags around in fsmap data dev functions
> [ca7d293d] xfs: add a perag to the btree cursor
> [195c248c] xfs: convert rmap btree cursor to using a perag
> [971fceb4] xfs: convert refcount btree cursor to use perags
> [ecb44e84] xfs: convert allocbt cursors to use perags
> [a426d0e1] xfs: use perag for ialloc btree cursors
> [a0577dbb] xfs: remove agno from btree cursor
> [3fbe9fa3] xfs: simplify xfs_dialloc_select_ag() return values
> [d38ed6a9] xfs: collapse AG selection for inode allocation
> [51b1e167] xfs: get rid of xfs_dir_ialloc()
> [895ee7c3] xfs: inode allocation can use a single perag instance
> [771d0670] xfs: clean up and simplify xfs_dialloc()
> [b8268cdd] xfs: use perag through unlink processing
> [d2ff101f] xfs: remove xfs_perag_t
> [1dbf114f] xfs: drop the AGI being passed to xfs_check_agi_freecount
> [e86bc63f] xfs: perag may be null in xfs_imap()
> [6d95c77a] xfs: log stripe roundoff is a property of the log
> [08602f16] xfs: xfs_log_force_lsn isn't passed a LSN
> [f682c323] xfs: logging the on disk inode LSN can make it go backwards
>
> Gustavo A. R. Silva (1):
> [8b1a8326] xfs: Fix multiple fall-through warnings for Clang
>
> Jiapeng Chong (1):
> [396a1948] xfs: Remove redundant assignment to busy
>
> Shaokun Zhang (1):
> [398f22e7] xfs: sort variable alphabetically to avoid repeated declaration
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [ANNOUNCE] xfsprogs for-next rebased to b4c6731a
2021-10-16 4:10 ` Darrick J. Wong
@ 2021-10-16 6:29 ` Dave Chinner
2021-10-18 14:56 ` Eric Sandeen
0 siblings, 1 reply; 5+ messages in thread
From: Dave Chinner @ 2021-10-16 6:29 UTC (permalink / raw)
To: Darrick J. Wong; +Cc: Eric Sandeen, xfs
On Fri, Oct 15, 2021 at 09:10:17PM -0700, Darrick J. Wong wrote:
> On Fri, Oct 15, 2021 at 03:32:41PM -0500, Eric Sandeen wrote:
> > On 10/15/21 2:42 PM, Eric Sandeen wrote:
> > > Hi folks,
> > >
> > > The for-next branch of the xfsprogs repository at:
> > >
> > > git://git.kernel.org/pub/scm/fs/xfs/xfsprogs-dev.git
> > >
> > > has just been updated.
> > >
> > > Patches often get missed, so please check if your outstanding
> > > patches were in this update. If they have not been in this update,
> > > please resubmit them to linux-xfs@vger.kernel.org so they can be
> > > picked up in the next update.
> > >
> > > This is really just the libxfs-5.14 sync (finally!). Big thanks
> > > to chandan, djwong, dchinner who all helped significantly with what
> > > was a much more challenging libxfs sync this time.
> > >
> > > Odds are this will be the bulk of the final 5.14 release. I will just
> > > add Darrick's deprecation warning, and anything else I get reminded
> > > of in the next week. :)
> >
> > I missed Derrick's "libxfs: fix crash on second attempt to initialize library"
> > because my old userspace rcu library did not exhibit the problem. :/
> >
> > Rather than leave a few dozen commits with regressed behavior as a bisect bomb,
> > I have force-pushed and anybody who pulled in the last hour will need to rebase.
> > Sorry about that!
>
> Er... /me notices the following discrepancy between the kernel and
> xfsprogs in libxfs/xfs_shared.h:
>
> --- a/libxfs/xfs_shared.h
> +++ b/libxfs/xfs_shared.h
> @@ -174,24 +174,4 @@ struct xfs_ino_geometry {
>
> };
>
> -/* Faked up kernel bits */
> -struct rb_root {
> -};
> -
> -#define RB_ROOT (struct rb_root) { }
> -
> -typedef struct wait_queue_head {
> -} wait_queue_head_t;
> -
> -#define init_waitqueue_head(wqh) do { } while(0)
> -
> -struct rhashtable {
> -};
> -
> -struct delayed_work {
> -};
> -
> -#define INIT_DELAYED_WORK(work, func) do { } while(0)
> -#define cancel_delayed_work_sync(work) do { } while(0)
> -
> #endif /* __XFS_SHARED_H__ */
Shouldn't those be libxfs/libxfs_priv.h along with all the other
faked up kernel bits?
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [ANNOUNCE] xfsprogs for-next rebased to b4c6731a
2021-10-16 6:29 ` Dave Chinner
@ 2021-10-18 14:56 ` Eric Sandeen
0 siblings, 0 replies; 5+ messages in thread
From: Eric Sandeen @ 2021-10-18 14:56 UTC (permalink / raw)
To: Dave Chinner, Darrick J. Wong; +Cc: Eric Sandeen, xfs
On 10/16/21 1:29 AM, Dave Chinner wrote:
> On Fri, Oct 15, 2021 at 09:10:17PM -0700, Darrick J. Wong wrote:
>> On Fri, Oct 15, 2021 at 03:32:41PM -0500, Eric Sandeen wrote:
>>> On 10/15/21 2:42 PM, Eric Sandeen wrote:
>>>> Hi folks,
>>>>
>>>> The for-next branch of the xfsprogs repository at:
>>>>
>>>> git://git.kernel.org/pub/scm/fs/xfs/xfsprogs-dev.git
>>>>
>>>> has just been updated.
>>>>
>>>> Patches often get missed, so please check if your outstanding
>>>> patches were in this update. If they have not been in this update,
>>>> please resubmit them to linux-xfs@vger.kernel.org so they can be
>>>> picked up in the next update.
>>>>
>>>> This is really just the libxfs-5.14 sync (finally!). Big thanks
>>>> to chandan, djwong, dchinner who all helped significantly with what
>>>> was a much more challenging libxfs sync this time.
>>>>
>>>> Odds are this will be the bulk of the final 5.14 release. I will just
>>>> add Darrick's deprecation warning, and anything else I get reminded
>>>> of in the next week. :)
>>>
>>> I missed Derrick's "libxfs: fix crash on second attempt to initialize library"
>>> because my old userspace rcu library did not exhibit the problem. :/
>>>
>>> Rather than leave a few dozen commits with regressed behavior as a bisect bomb,
>>> I have force-pushed and anybody who pulled in the last hour will need to rebase.
>>> Sorry about that!
>>
>> Er... /me notices the following discrepancy between the kernel and
>> xfsprogs in libxfs/xfs_shared.h:
>>
>> --- a/libxfs/xfs_shared.h
>> +++ b/libxfs/xfs_shared.h
>> @@ -174,24 +174,4 @@ struct xfs_ino_geometry {
>>
>> };
>>
>> -/* Faked up kernel bits */
>> -struct rb_root {
>> -};
>> -
>> -#define RB_ROOT (struct rb_root) { }
>> -
>> -typedef struct wait_queue_head {
>> -} wait_queue_head_t;
>> -
>> -#define init_waitqueue_head(wqh) do { } while(0)
>> -
>> -struct rhashtable {
>> -};
>> -
>> -struct delayed_work {
>> -};
>> -
>> -#define INIT_DELAYED_WORK(work, func) do { } while(0)
>> -#define cancel_delayed_work_sync(work) do { } while(0)
>> -
>> #endif /* __XFS_SHARED_H__ */
>
> Shouldn't those be libxfs/libxfs_priv.h along with all the other
> faked up kernel bits?
IIRC that doesn't work but I don't remember why - has to do w/ the ag code move,
and use in userspace IIRC. And TBH I forgot that "xfs_shared" was uhhhh actually
shared with the kernel and failed to check.
I'll figure something out. Tired of pushing this stuff from file to file,
subdir to subdir ... was trying to avoid libfrog.
But thanks for noticing, Darrick - and sorry for missing it.
-Eric
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-10-18 14:56 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-15 19:42 [ANNOUNCE] xfsprogs for-next updated to 7189ee53 Eric Sandeen
2021-10-15 20:32 ` [ANNOUNCE] xfsprogs for-next rebased to b4c6731a Eric Sandeen
2021-10-16 4:10 ` Darrick J. Wong
2021-10-16 6:29 ` Dave Chinner
2021-10-18 14:56 ` Eric Sandeen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.