* [linux-next:master 7104/8410] drivers/power/supply/axp288_charger.c:411:8: error: implicit declaration of function 'iosf_mbi_block_punit_i2c_access'
@ 2021-10-16 18:05 ` kernel test robot
0 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2021-10-16 18:05 UTC (permalink / raw)
To: Kate Hsuan
Cc: llvm, kbuild-all, Linux Memory Management List,
Sebastian Reichel, Hans de Goede
[-- Attachment #1: Type: text/plain, Size: 3323 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 7c832d2f9b959e3181370c8b0dacaf9efe13fc05
commit: ed229454856e565c5a7d3287cbc63f2cf077b34f [7104/8410] power: supply: axp288-charger: Optimize register reading method
config: i386-randconfig-c001-20211016 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 8ca4b3ef19fe82d7ad6a6e1515317dcc01b41515)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=ed229454856e565c5a7d3287cbc63f2cf077b34f
git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git fetch --no-tags linux-next master
git checkout ed229454856e565c5a7d3287cbc63f2cf077b34f
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Note: the linux-next/master HEAD 7c832d2f9b959e3181370c8b0dacaf9efe13fc05 builds fine.
It may have been fixed somewhere.
All errors (new ones prefixed by >>):
>> drivers/power/supply/axp288_charger.c:411:8: error: implicit declaration of function 'iosf_mbi_block_punit_i2c_access' [-Werror,-Wimplicit-function-declaration]
ret = iosf_mbi_block_punit_i2c_access();
^
>> drivers/power/supply/axp288_charger.c:430:2: error: implicit declaration of function 'iosf_mbi_unblock_punit_i2c_access' [-Werror,-Wimplicit-function-declaration]
iosf_mbi_unblock_punit_i2c_access();
^
drivers/power/supply/axp288_charger.c:430:2: note: did you mean 'iosf_mbi_block_punit_i2c_access'?
drivers/power/supply/axp288_charger.c:411:8: note: 'iosf_mbi_block_punit_i2c_access' declared here
ret = iosf_mbi_block_punit_i2c_access();
^
2 errors generated.
vim +/iosf_mbi_block_punit_i2c_access +411 drivers/power/supply/axp288_charger.c
401
402 static int axp288_charger_usb_update_property(struct axp288_chrg_info *info)
403 {
404 int ret = 0;
405
406 if (info->valid && time_before(jiffies, info->last_updated + AXP288_REG_UPDATE_INTERVAL))
407 return 0;
408
409 dev_dbg(&info->pdev->dev, "Charger updating register values...\n");
410
> 411 ret = iosf_mbi_block_punit_i2c_access();
412 if (ret < 0)
413 return ret;
414
415 ret = axp288_charger_reg_readb(info, AXP20X_PWR_INPUT_STATUS, &info->input_status);
416 if (ret < 0)
417 goto out;
418
419 ret = axp288_charger_reg_readb(info, AXP20X_PWR_OP_MODE, &info->op_mode);
420 if (ret < 0)
421 goto out;
422
423 ret = axp288_charger_reg_readb(info, AXP20X_CHRG_BAK_CTRL, &info->backend_control);
424 if (ret < 0)
425 goto out;
426
427 info->last_updated = jiffies;
428 info->valid = true;
429 out:
> 430 iosf_mbi_unblock_punit_i2c_access();
431 return ret;
432 }
433
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 33747 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* [linux-next:master 7104/8410] drivers/power/supply/axp288_charger.c:411:8: error: implicit declaration of function 'iosf_mbi_block_punit_i2c_access'
@ 2021-10-16 18:05 ` kernel test robot
0 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2021-10-16 18:05 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 3400 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 7c832d2f9b959e3181370c8b0dacaf9efe13fc05
commit: ed229454856e565c5a7d3287cbc63f2cf077b34f [7104/8410] power: supply: axp288-charger: Optimize register reading method
config: i386-randconfig-c001-20211016 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 8ca4b3ef19fe82d7ad6a6e1515317dcc01b41515)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=ed229454856e565c5a7d3287cbc63f2cf077b34f
git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git fetch --no-tags linux-next master
git checkout ed229454856e565c5a7d3287cbc63f2cf077b34f
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Note: the linux-next/master HEAD 7c832d2f9b959e3181370c8b0dacaf9efe13fc05 builds fine.
It may have been fixed somewhere.
All errors (new ones prefixed by >>):
>> drivers/power/supply/axp288_charger.c:411:8: error: implicit declaration of function 'iosf_mbi_block_punit_i2c_access' [-Werror,-Wimplicit-function-declaration]
ret = iosf_mbi_block_punit_i2c_access();
^
>> drivers/power/supply/axp288_charger.c:430:2: error: implicit declaration of function 'iosf_mbi_unblock_punit_i2c_access' [-Werror,-Wimplicit-function-declaration]
iosf_mbi_unblock_punit_i2c_access();
^
drivers/power/supply/axp288_charger.c:430:2: note: did you mean 'iosf_mbi_block_punit_i2c_access'?
drivers/power/supply/axp288_charger.c:411:8: note: 'iosf_mbi_block_punit_i2c_access' declared here
ret = iosf_mbi_block_punit_i2c_access();
^
2 errors generated.
vim +/iosf_mbi_block_punit_i2c_access +411 drivers/power/supply/axp288_charger.c
401
402 static int axp288_charger_usb_update_property(struct axp288_chrg_info *info)
403 {
404 int ret = 0;
405
406 if (info->valid && time_before(jiffies, info->last_updated + AXP288_REG_UPDATE_INTERVAL))
407 return 0;
408
409 dev_dbg(&info->pdev->dev, "Charger updating register values...\n");
410
> 411 ret = iosf_mbi_block_punit_i2c_access();
412 if (ret < 0)
413 return ret;
414
415 ret = axp288_charger_reg_readb(info, AXP20X_PWR_INPUT_STATUS, &info->input_status);
416 if (ret < 0)
417 goto out;
418
419 ret = axp288_charger_reg_readb(info, AXP20X_PWR_OP_MODE, &info->op_mode);
420 if (ret < 0)
421 goto out;
422
423 ret = axp288_charger_reg_readb(info, AXP20X_CHRG_BAK_CTRL, &info->backend_control);
424 if (ret < 0)
425 goto out;
426
427 info->last_updated = jiffies;
428 info->valid = true;
429 out:
> 430 iosf_mbi_unblock_punit_i2c_access();
431 return ret;
432 }
433
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 33747 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [linux-next:master 7104/8410] drivers/power/supply/axp288_charger.c:411:8: error: implicit declaration of function 'iosf_mbi_block_punit_i2c_access'
2021-10-16 18:05 ` kernel test robot
@ 2021-10-18 13:13 ` Hans de Goede
-1 siblings, 0 replies; 4+ messages in thread
From: Hans de Goede @ 2021-10-18 13:13 UTC (permalink / raw)
To: kernel test robot, Kate Hsuan
Cc: llvm, kbuild-all, Linux Memory Management List, Sebastian Reichel
Hi,
On 10/16/21 20:05, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head: 7c832d2f9b959e3181370c8b0dacaf9efe13fc05
> commit: ed229454856e565c5a7d3287cbc63f2cf077b34f [7104/8410] power: supply: axp288-charger: Optimize register reading method
> config: i386-randconfig-c001-20211016 (attached as .config)
> compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 8ca4b3ef19fe82d7ad6a6e1515317dcc01b41515)
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=ed229454856e565c5a7d3287cbc63f2cf077b34f
> git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
> git fetch --no-tags linux-next master
> git checkout ed229454856e565c5a7d3287cbc63f2cf077b34f
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=i386
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> Note: the linux-next/master HEAD 7c832d2f9b959e3181370c8b0dacaf9efe13fc05 builds fine.
> It may have been fixed somewhere.
>
> All errors (new ones prefixed by >>):
>
>>> drivers/power/supply/axp288_charger.c:411:8: error: implicit declaration of function 'iosf_mbi_block_punit_i2c_access' [-Werror,-Wimplicit-function-declaration]
> ret = iosf_mbi_block_punit_i2c_access();
> ^
>>> drivers/power/supply/axp288_charger.c:430:2: error: implicit declaration of function 'iosf_mbi_unblock_punit_i2c_access' [-Werror,-Wimplicit-function-declaration]
> iosf_mbi_unblock_punit_i2c_access();
> ^
> drivers/power/supply/axp288_charger.c:430:2: note: did you mean 'iosf_mbi_block_punit_i2c_access'?
> drivers/power/supply/axp288_charger.c:411:8: note: 'iosf_mbi_block_punit_i2c_access' declared here
> ret = iosf_mbi_block_punit_i2c_access();
> ^
> 2 errors generated.
This is my bad, the Kconfig entry for CONFIG_AXP288_CHARGER now needs a depends on IOSF_MBI, just like
we needed it for AXP288_FUEL_GAUGE when similar changes were made to that. I should have caught this
during review.
I'll send a follow-up patch fixing this.
Regards,
Hans
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [linux-next:master 7104/8410] drivers/power/supply/axp288_charger.c:411:8: error: implicit declaration of function 'iosf_mbi_block_punit_i2c_access'
@ 2021-10-18 13:13 ` Hans de Goede
0 siblings, 0 replies; 4+ messages in thread
From: Hans de Goede @ 2021-10-18 13:13 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 2559 bytes --]
Hi,
On 10/16/21 20:05, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head: 7c832d2f9b959e3181370c8b0dacaf9efe13fc05
> commit: ed229454856e565c5a7d3287cbc63f2cf077b34f [7104/8410] power: supply: axp288-charger: Optimize register reading method
> config: i386-randconfig-c001-20211016 (attached as .config)
> compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 8ca4b3ef19fe82d7ad6a6e1515317dcc01b41515)
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=ed229454856e565c5a7d3287cbc63f2cf077b34f
> git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
> git fetch --no-tags linux-next master
> git checkout ed229454856e565c5a7d3287cbc63f2cf077b34f
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=i386
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> Note: the linux-next/master HEAD 7c832d2f9b959e3181370c8b0dacaf9efe13fc05 builds fine.
> It may have been fixed somewhere.
>
> All errors (new ones prefixed by >>):
>
>>> drivers/power/supply/axp288_charger.c:411:8: error: implicit declaration of function 'iosf_mbi_block_punit_i2c_access' [-Werror,-Wimplicit-function-declaration]
> ret = iosf_mbi_block_punit_i2c_access();
> ^
>>> drivers/power/supply/axp288_charger.c:430:2: error: implicit declaration of function 'iosf_mbi_unblock_punit_i2c_access' [-Werror,-Wimplicit-function-declaration]
> iosf_mbi_unblock_punit_i2c_access();
> ^
> drivers/power/supply/axp288_charger.c:430:2: note: did you mean 'iosf_mbi_block_punit_i2c_access'?
> drivers/power/supply/axp288_charger.c:411:8: note: 'iosf_mbi_block_punit_i2c_access' declared here
> ret = iosf_mbi_block_punit_i2c_access();
> ^
> 2 errors generated.
This is my bad, the Kconfig entry for CONFIG_AXP288_CHARGER now needs a depends on IOSF_MBI, just like
we needed it for AXP288_FUEL_GAUGE when similar changes were made to that. I should have caught this
during review.
I'll send a follow-up patch fixing this.
Regards,
Hans
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-10-18 13:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-16 18:05 [linux-next:master 7104/8410] drivers/power/supply/axp288_charger.c:411:8: error: implicit declaration of function 'iosf_mbi_block_punit_i2c_access' kernel test robot
2021-10-16 18:05 ` kernel test robot
2021-10-18 13:13 ` Hans de Goede
2021-10-18 13:13 ` Hans de Goede
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.